From nobody Mon Aug 24 11:03:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1783352102; cv=none; d=zohomail.com; s=zohoarc; b=Ay31IElEgY+STyVhJmIUrulsMgB3H+bkLw/0cNVNKY5HPZDWp1JnIY/6StLAwaEiCXmdq6gVYpp81ewKFRLYHHVU7/1f28QE1mp/AV/EVtk0688/hw2p0VtdO8/cOuGUbnkxNKAFzeHoIfnxrTdPLHKzlIAcnmTLlDPMHQLHuBo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783352102; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PHcjQ1xCF4fLVyfPs91K9Nneq4AcxnJkrKeQtPWGRmI=; b=K3KKBEDf0gzbSvylaDXcAgZJI9zzWvRnqQA2mfzmUxNlHPK4sEd09QsrItY9wcqk54UhRJsZI/bs1/mLPijEJXzmL3PGJcuqpAsAfVL2g9ZUB7L9z7IZZYUXB9YP8VDevv5Oil4UNZGt6W5mMuCkZFu5ANXU5Vt/NBjNiFQtqSs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1783352102023915.366446544935; Mon, 6 Jul 2026 08:35:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1355439.1610214 (Exim 4.92) (envelope-from ) id 1wglKx-0000z9-7m; Mon, 06 Jul 2026 15:34:23 +0000 Received: by outflank-mailman (output) from mailman id 1355439.1610214; Mon, 06 Jul 2026 15:34:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wglKx-0000xa-24; Mon, 06 Jul 2026 15:34:23 +0000 Received: by outflank-mailman (input) for mailman id 1355439; Mon, 06 Jul 2026 15:34:22 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wglKw-0000we-Bh for xen-devel@lists.xenproject.org; Mon, 06 Jul 2026 15:34:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wglKv-000YCn-3d for xen-devel@lists.xenproject.org; Mon, 06 Jul 2026 17:34:21 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4bcaea-5cb7-0a2a0a5109dd-0a2a450a95fe-22 for ; Mon, 06 Jul 2026 17:34:21 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4bcafc-e40e-0a2a450a0019-d1558032bcd6-3 for ; Mon, 06 Jul 2026 17:34:21 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so22101625e9.0 for ; Mon, 06 Jul 2026 08:34:20 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63bfba1sm433726505e9.15.2026.07.06.08.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 08:34:19 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1783352060; x=1783956860; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PHcjQ1xCF4fLVyfPs91K9Nneq4AcxnJkrKeQtPWGRmI=; b=crnPhurb8VFajf9bDQFa9skywLv6bvYlNkRf2aLdPfvWLCojTxsF0JKCqN9Y+c2QKX xfMI5CopS/ZEtHtNYkyMnNbFbdAkPM9Xs8ivnqsZ5xUVpbqXQFZM2D+UxwZ2zeTSvhIm rZoQ/ZYGWhbgEIIqN9EPMsFye2zsHWXdj5ULc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783352060; x=1783956860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PHcjQ1xCF4fLVyfPs91K9Nneq4AcxnJkrKeQtPWGRmI=; b=fCN7KT2DRkSzJujQRQhouwQAdVX7vjA2ES0ydXvRPKWZU6jU0FiJ1yImwSN/LtvUXW HatvPCT8WXRM0nKO/POHNyThNVBdbuj9R1oeGDkNKumuqt2MK9DWLUDiBHyvpjDe17Ug 4Gaod67UbRC7agHkSlDFOpNQJB2C9rbMVXac/6WtJOzRDJt3BsN+AuhE/qBR4H6k0mph uc29LiOt1/FDYovDe1ypNK5zEA7Ku3SnBTD4eqhquXRjSMEMI9Glm1e8izxsztQiJbtt 6elZ6Xqg8qXrve6Pb+/KVswu8DGmAuKYw6510gzM5n4WGPio2RW6rW/v5TnYIU8IbVeq uzxQ== X-Gm-Message-State: AOJu0Yz2efzilR2UcGeFImVJDlPVUFFZSlmMg68hNXVxYB1mndlleLqN AAErB5P6nN+CuKj+PbKqycFzkMca937h86UUDGALPtEve3LAFXzwMp3KcSJ38rFhokoLC+ip2dO 8WbQX X-Gm-Gg: AfdE7cm5FLjFmvDVWinV1Rb0ZkMiJEe1B107qPaMNEzQyqQnN/tR0Vsr4pg0ZzJooP9 u9AVWiuglBJekOJDWyR1Uk9emCV5llQADXUCSQa0meFWUol90bPsIEitH1IDjw0LMpGlrsZLbtp AjnC8pr3chmPFqyp4AN5qZKbPZSWBFDrQ9rMQc9HJHsqdDfUQ8pHo5D+CV1Hlh+8mHWbIHSXx4m /Pxic8qBYlFgXlgxFe5UKd2IBpZFD1pJyImw/Kwb+3GJlMmg6WvW2NbTLB01kH6krCKqJ0eNgil ImbOdqDq6V8emxI1TuLzrA+UP8ydCXiMamKBDQfHqYe20EdkjdVFcpvw8P+xcKq8ZB9FnWU/M7j +CbQIF6S2XD+yYYK4ShoChWcvLtY/m9vf3WAwvOa8sl+csK3dgqvmf65RJ7kZcp5GCnzOR+gn5d x1+oain8oMf5Qt0RI8xC8SvbHBWsFtacFk48bn3NeSppjJQZqJuYzhbfJBIChRK/Y= X-Received: by 2002:a05:600c:4e8e:b0:493:c194:4e7a with SMTP id 5b1f17b1804b1-493df0377e0mr11774875e9.3.1783352059809; Mon, 06 Jul 2026 08:34:19 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH 1/3] x86/hvm: Use PUSH_AND_CLEAR_GPRS in preference to SAVE_ALL Date: Mon, 6 Jul 2026 16:34:13 +0100 Message-Id: <20260706153415.1264750-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260706153415.1264750-1-andrew.cooper3@citrix.com> References: <20260706153415.1264750-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-4011c0/1783352061-D5129DDE-772D8F18/0/0 X-purgate-type: clean X-purgate-size: 1790 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1783352104313158500 SAVE_ALL hides a CLD instruction which is not needed anywhere here. * VMX VMExit always clears flags. VMX VMentry failure never switched away from the host flags, so they're still good. * SVM VMRUN always saves and restores the host flags. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Teddy Astie Bloat-o-meter reports: add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-168 (-168) Function old new delta svm_asm_do_resume 416 360 -56 vmx_asm_vmexit_handler 576 464 -112 --- xen/arch/x86/hvm/svm/entry.S | 2 +- xen/arch/x86/hvm/vmx/entry.S | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index b6ea699bb9c0..d9613a2a8fed 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -89,7 +89,7 @@ __UNLIKELY_END(nsvm_hap) =20 vmrun =20 - SAVE_ALL + PUSH_AND_CLEAR_GPRS =20 GET_CURRENT(bx) =20 diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S index c34f5a1ee0af..cebc70064048 100644 --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -22,7 +22,7 @@ #include =20 FUNC(vmx_asm_vmexit_handler) - SAVE_ALL + PUSH_AND_CLEAR_GPRS =20 mov %cr2,%rax GET_CURRENT(bx) @@ -157,7 +157,7 @@ UNLIKELY_END(realmode) =20 .Lvmx_vmentry_fail: sti - SAVE_ALL + PUSH_AND_CLEAR_GPRS =20 /* * SPEC_CTRL_ENTRY notes --=20 2.39.5