From nobody Thu Aug 27 11:13:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1782934600; cv=none; d=zohomail.com; s=zohoarc; b=MbgDen8GYzMJFijS0Be1nAErqbj5ReaT681h+4QamB/DKxFLvLakaASOWCTqmF6J/Tg6hDHKlChoZJ6xgQKI9SeSJKd+9YJtmAYYozz6K3bKmF2JX9gXiAv4O/1Wl7MExd5Zey717K+tKS1s4/2H/rqTRyLfvB0C5oyFUKMPOjo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782934600; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=aK5m/cPAf0bdBYumbExr1aJO4L8QPhhYatB0l9CbU30=; b=irY7sn5G2VUYKcdkHJP06JvIsSG0SyyLblp4CWYEvfuWYFGMUGlKMIF01oGhPGrAhwswQQnJCEb7a0bqChaN/ZIWVBIaKG4QYTWrI0iGBdrOpLah4m7QuJTKLmRaM/DzLBv31QsJMR9mZwyopwAXfeeW1Fn3mn/inmY5omlAZYo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 178293460057862.746865989506205; Wed, 1 Jul 2026 12:36:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1350745.1608266 (Exim 4.92) (envelope-from ) id 1wf0jI-0005hb-4p; Wed, 01 Jul 2026 19:36:16 +0000 Received: by outflank-mailman (output) from mailman id 1350745.1608266; Wed, 01 Jul 2026 19:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0jI-0005hU-1y; Wed, 01 Jul 2026 19:36:16 +0000 Received: by outflank-mailman (input) for mailman id 1350745; Wed, 01 Jul 2026 19:36:15 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3eGtFagYKCb0vhdqmfjrrjoh.frp0hq-ghyhoolvwv.0hqsurmhfw.ruj@flex--seanjc.bounces.google.com>) id 1wf0jH-0005gb-FF for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:36:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0jG-003oa2-SK for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:36:14 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3eGtFagYKCb0vhdqmfjrrjoh.frp0hq-ghyhoolvwv.0hqsurmhfw.ruj@flex--seanjc.bounces.google.com>) id 6a456bfe-bab6-0a2a0a5309dd-0a2a4509b1ae-44 for ; Wed, 01 Jul 2026 21:36:14 +0200 Received: from [209.85.216.74] (helo=mail-pj1-f74.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3eGtFagYKCb0vhdqmfjrrjoh.frp0hq-ghyhoolvwv.0hqsurmhfw.ruj@flex--seanjc.bounces.google.com>) id 6a456b79-97e6-0a2a45090019-d155d84ad47a-3 for ; Wed, 01 Jul 2026 21:33:14 +0200 Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-37e24235ce1so1374668a91.0 for ; Wed, 01 Jul 2026 12:33:14 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934393; x=1783539193; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=aK5m/cPAf0bdBYumbExr1aJO4L8QPhhYatB0l9CbU30=; b=RFJGBZma1fonKwjoMQxVhpEy/UOIMSO+s32U36rMVRqgLIFF6HYhxZ4V4DfgMc3HIZ 8jX8ccc07Xo21pk5b39hL/z+fpammNwoWws7RFiKLMbaGXLV9WbW6lFbj9T59+oPXJYt C0K/VZEJD2NZqBuHG1LWIJTgz7BHgnobobm0ycIYesMFY5sk4PYFvzjDt/RHVK9msifi m3J8izuHSyH5ipo08L5wFyytZmH8ciI7jtU/PE1aPHgwJ/c3IwpFdXutRP4hPANMyMWE 82Q9HrgqdW15Pt4ShQ0Krbrw32ig+WQpblxNGmvIkJLxycG8qekLmy6rSQJiyAXGwseb Ouvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934393; x=1783539193; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aK5m/cPAf0bdBYumbExr1aJO4L8QPhhYatB0l9CbU30=; b=Ih6dRLR4lQi9xbmnEzq/AlmxJERs7CygcVsJ/OkyUoffuoBMSUuSnSEFwfqMiupWAM F/qxdU14KgjgLYWjnP9ttspmg4nz5s6LsQ2nWyh8veYry7ure74MJsLdlbgSKw2jdo/w c0SKntYp9ChCEmqScIbb0HSg4K0aXhiKExdW0i2clWqTS/F9A+dvNCvIirfuy5qFsvF3 8k/LakuG20ejjywoPvOa8+88cFHsEBlo0IOUZfC/69YNzprVB9np8hHy3+5XBlSqmMXK FHLZUI9tRZWn3z7hB9ufVXcpJOuQMGxMMQpFnJgQX/bIO+hs9PZf6vGPq9f3/xrNsiSf d7Fg== X-Forwarded-Encrypted: i=1; AHgh+RrKPTvC8jPaTy6gS+tNvsTEmUXEnO/KZSUEnHztOUWsJWjotX9I8vUj3nLYi4IHbKy8hW2TAMSNADI=@lists.xenproject.org X-Gm-Message-State: AOJu0YweOnfzrwzy7IvxAEA2xIIUD4nD+G6Q2pERbZCrq7yJg/IAbLu4 zMT+1fZHLMwG2G4dg/QHDFkAq+mYk7HLULW8KIeu11qAWF8ixT5a/LZiuYG0B0AmWtqzqGuWN3X 57yLiJQ== X-Received: from pjbil4.prod.google.com ([2002:a17:90b:1644:b0:37d:ece0:dd38]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3810:b0:37f:9ce1:cdaf with SMTP id 98e67ed59e1d1-380aa1ed882mr2896319a91.29.1782934392117; Wed, 01 Jul 2026 12:33:12 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:58 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-38-seanjc@google.com> Subject: [PATCH v5 37/51] x86/kvmclock: Move kvm_sched_clock_init() down in kvmclock.c From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner X-purgate-ID: tlsNG-bad1c0/1782934394-45B23986-928943A0/13/0 X-purgate-type: clean X-purgate-size: 2301 X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1782934601459158500 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move kvm_sched_clock_init() "down" so that it can reference the global kvm_clock structure without needing a forward declaration. Opportunistically mark the helper as "__init" instead of "inline" to make its usage more obvious; modern compilers don't need a hint to inline a single-use function, and an extra CALL+RET pair during boot is a complete non-issue. And, if the compiler ignores the hint and does NOT inline the function, the resulting code may not get discarded after boot due lack of an __init annotation. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 5b9955343199..5220d205abc7 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -155,20 +155,6 @@ static void kvm_restore_sched_clock_state(void) kvm_register_clock("primary cpu clock, resume"); } =20 -static inline void kvm_sched_clock_init(bool stable) -{ - kvm_sched_clock_offset =3D kvm_clock_read(); - __paravirt_set_sched_clock(kvm_sched_clock_read, stable, - kvm_save_sched_clock_state, - kvm_restore_sched_clock_state); - - pr_info("kvm-clock: using sched offset of %llu cycles", - kvm_sched_clock_offset); - - BUILD_BUG_ON(sizeof(kvm_sched_clock_offset) > - sizeof(((struct pvclock_vcpu_time_info *)NULL)->system_time)); -} - void kvmclock_cpu_action(enum kvm_guest_cpu_action action) { /* @@ -325,6 +311,20 @@ static int kvmclock_setup_percpu(unsigned int cpu) return p ? 0 : -ENOMEM; } =20 +static __init void kvm_sched_clock_init(bool stable) +{ + kvm_sched_clock_offset =3D kvm_clock_read(); + __paravirt_set_sched_clock(kvm_sched_clock_read, stable, + kvm_save_sched_clock_state, + kvm_restore_sched_clock_state); + + pr_info("kvm-clock: using sched offset of %llu cycles", + kvm_sched_clock_offset); + + BUILD_BUG_ON(sizeof(kvm_sched_clock_offset) > + sizeof(((struct pvclock_vcpu_time_info *)NULL)->system_time)); +} + void __init kvmclock_init(bool prefer_tsc) { u8 flags; --=20 2.55.0.rc0.799.gd6f94ed593-goog