From nobody Sat Jul 4 21:04:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1782726422; cv=pass; d=zohomail.com; s=zohoarc; b=NaCM+7JjVjrjJlTPqDUjf20deP8pHXb+qqrWzdOliWhj+CfhDlryOZQvXBArE+dzSb0BApeaUxQKPh4bzbYjJsg6SGQFbcBbq1CAbv9HO6zkTWY8f1CbCxkUNoq/Ak+FNNmFoODqD090JqbPuJE4TSEQWItNKeU5/MX0QDaNg8Y= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782726422; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HY5yZIB/IQ6+L8KU+ioxvL6s7xlSNcpLpZDSMfGZOqw=; b=L4crWJr15lDazSDusj2+T6h8EO4hYO+kbKaHndLLezzeYjtAdc09QbprCeUbbM988vYHuWxSHDonBy13fS1LwEFqRr7gRsFUCuoKB/VJdxiGlft9fYW2XEFMMMuDm0baEaE0gonQ1mqk0VFUV0Nig+cMXVO8DuKkn01az8b7twI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1782726422427292.79353627910814; Mon, 29 Jun 2026 02:47:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1347353.1605213 (Exim 4.92) (envelope-from ) id 1we8Za-0001jI-MX; Mon, 29 Jun 2026 09:46:38 +0000 Received: by outflank-mailman (output) from mailman id 1347353.1605213; Mon, 29 Jun 2026 09:46:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1we8Za-0001jB-J7; Mon, 29 Jun 2026 09:46:38 +0000 Received: by outflank-mailman (input) for mailman id 1347353; Mon, 29 Jun 2026 09:46:37 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1we8ZZ-0001Zg-5W for xen-devel@lists.xenproject.org; Mon, 29 Jun 2026 09:46:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1we8ZY-00DMLz-5c for xen-devel@lists.xenproject.org; Mon, 29 Jun 2026 11:46:36 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a423efa-5cb7-0a2a0a5109dd-0a2a450c8216-8 for ; Mon, 29 Jun 2026 11:46:36 +0200 Received: from [40.93.201.59] (helo=CY3PR05CU001.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a423efa-f399-0a2a450c0019-285dc93b14e9-3 for ; Mon, 29 Jun 2026 11:46:35 +0200 Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by BY5PR03MB5141.namprd03.prod.outlook.com (2603:10b6:a03:1e9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.16; Mon, 29 Jun 2026 09:46:33 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.21.0159.018; Mon, 29 Jun 2026 09:46:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nKeyCOr26EnzApBdLLdXg784PsHPCB4PYXZ/ObHuGnV/k6Y7MoeYnr4Jb8mMFDu215L2XMkos8uE+yKOIYb6FJUbv0KpMRc9uqnQjAOC4xAXzxYWYMgrExGI/DtVW8jdcAhtodBpyJMFfDCK7KMD7JWHlPbQawtlb7xq5u0pDEOjqI0/3qeE78VwzFE6RwsVxfXFUz9ig7dfX1KaEMe0Pdniv9VUpDmLQrqhGkfkrcDqBtDZrJm6bSM+CWBf+4EHgy6wSOiSLn145Q9/Xkopn2pGrxd9FrNXvE21r/O5VeBN1Onn8aONDs4PqJYAH0D8Mxoey8nZD+XNuizRW0yO9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HY5yZIB/IQ6+L8KU+ioxvL6s7xlSNcpLpZDSMfGZOqw=; b=POBTv2wk3HOh5jWCJZJe+pLB+LrvttDa5mb5L1K57xjnBkF3KzZs75XGOAQy4ojE5CQMw28r5ePgh2hCDVkva4wc2EJ9XEAzzLXIEn6RGJlrh22XGB+I6JC143EkhCGrR5eX9crch5190aNKUOSv4s1TiB73A875dFURxJkdY/IX+mmZOvgB6YKU85NQB7mhEmv5bF3gf2cTavYP7jEWuPGBtqwWYos6JmD+BaXYqNfmg+YvsT2kapB6mLhJ26cUzI/OBMvCpN/XG8nUI/UR8B7vw6igPBuA0qaDLFOGDpkKd4o8x81yJLRO2uu7hcgzYMrLAfTfRK2JfvFSEqsx0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HY5yZIB/IQ6+L8KU+ioxvL6s7xlSNcpLpZDSMfGZOqw=; b=jEFUjYf0IUH4Crdfjp/2KvTzB7L5sEFBUqLyIG4JE5c/ZC9DbbtL8raYdYBkojKEQ5tOPtMNEwjhndtZWYBzSchPDpe6bAKXywTIDdWjGHu5uCWs6VCM9HFtSTS3WDNCAqbya8gvMo26aqPIQCs1qVIHYkJ4FYwl4jHxGgAGiU0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Roger Pau Monne , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH for-4.22 v2 1/4] riscv/irq: define a per-arch irq_to_desc() Date: Mon, 29 Jun 2026 11:45:28 +0200 Message-ID: <20260629094531.55555-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260629094531.55555-1-roger.pau@citrix.com> References: <20260629094531.55555-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MR1P264CA0154.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:54::20) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|BY5PR03MB5141:EE_ X-MS-Office365-Filtering-Correlation-Id: d36fcc14-811e-4e5b-3175-08ded5c34d74 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|376014|56012099006|18002099003|11063799006|22082099003; X-Microsoft-Antispam-Message-Info: 8OT16dL8izRjfn47tWOsSvJMP/+mP+ZZiK+sv8lwe069VJECXK8RyrlrREun8GQamvpd4pbnyJsJ8WP7K3QG9r/nHEGd+WZWtZz6HwnNnNOpxNFb8hX2ZE2Y7RCJIniH+19tDd92EPTrnIx7Sw4BvJhw/JK5hdrenBrFCxo/0VBM2T7PqSkCecPIwpuyxujlmr7dvhrqjVEyk3D7suKcl6wRm7ttHLlxcRZPhf/No03qgx2QP3TLgTW5KZSnHVP9ojyjY2b1l1wD2nULKvXXObYUE01DL2n4IYiFMTJ1AtKQP6mcjqtY9RSl9fWll8VtF8W9uhi2EH9BmxQQbvUrEflw8oxbRa3BtgRNzOGKAT4gF7G85baRXjcqYSIpwRVO/3Plp3WWPzOzu/wt+WuYVMFhhOfJBuuSfJwLQ3h0oaQs7tN+Cxvw1nuw2ixNp2JUy041GQLm6QqAugK+E80MhG14PqqUCuafh6fEi6MiPAmeNyw7KPu8x3vekArSZRFAlTjTIrh/pUjqB5YNp2qj24wrHnOEyttI87cRwx5+rlyZJJLxWthsnPCyIqX3GdjF2LYBuZ8Zat/A75VKhEL3K8AZExyMla+e1gj8SqqkUOh1EEIkYyrnhe8Sqj43DXm0b7goX5Jnwn85ZFdvMrLomUh9JddMx4AuMkln8ckfrDM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(56012099006)(18002099003)(11063799006)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHdJUy8vc1FKOVJ0R3hHaXZpNmpXVlhyeDZUaVBYZFRKVHZWKyticjRBR1VH?= =?utf-8?B?bVdRTFRjYkg2MlBOUTA5MGtmcjZBVFBmZzNSTFpHOS8rcWpYU0djc3JVZmJH?= =?utf-8?B?aUNyZ0pocDJwQWhzRmhxTWE0eURuS0FyMkgyMU0zdTlickI2aEJBdVFwdkVX?= =?utf-8?B?bEtJWEF6SDkwZ05Takd4WGllZHBUV2lBaUZGOFRaZm9WQjJjcW5pbXZobSt0?= =?utf-8?B?dDltRWJVZnRpREhlQnVrRG5vcm91VWxoMjBwcTE0Qk9CVWhKbUJQbzVFMUpR?= =?utf-8?B?T1d3cVlCSm1RSkdVU2lBNEZ0VnY1MzF2aWRlNStwOThBS29tVlN3ZG9wSjc0?= =?utf-8?B?eUtEdUpSeXZTUlhQRmxaOUhSb3pSRlJUalM3MDVYSkgrM0gzWnpOSUdEZGdS?= =?utf-8?B?eDd4Y2QzSFhFZVU3VnRiajNuVXEvR3VETmNKNHZDNjNleWMxZnlPOS8vbkV4?= =?utf-8?B?ZDlEYTJGdy9hMnRCMVBncWRJT0h6V0FKK21vdlRBTHBYMzJaZTdSSjBjckpE?= =?utf-8?B?R080M01VWXhZb1Rqd1ZBME9neWYxenZMbkJ4TnQyR09UVHlGSHdMK3l2VXBH?= =?utf-8?B?a3FSTXRXbGptbHp0T3FibXpHeGwyQ254M0ttNGUyQ0JGUklrU2dDc0MxNzBI?= =?utf-8?B?SHRxbFVRYWJjVHVjZWRteGFTd3psYnJQaEllMFRKTmFPZ3ZsRHBmRE1VdnhT?= =?utf-8?B?QlRLRnVYRXN6MGxGeUlvSFpkNlA3RmZXazNrMWx4UitWVlVnWEhWOWZBTmpw?= =?utf-8?B?NFg3TDhkdXZvc2Y4dGJhTDJNMUFuVE9SWmpUdVRCRVhRSnJKUExrWUhFVUhi?= =?utf-8?B?R2ZpVk1pT1IvMDY2L2grcXB5bUszY1JVTDZOci9kZ0lxOU1kc0g2RVFmZ1lU?= =?utf-8?B?MVM4R1lMa1Y4L29YUjR4M0VaTUtid0tiMDZzbjdwTFV1NkRJM04ybUx2YW1a?= =?utf-8?B?L1prRHQ5K05PU3dNUTZDZzhmb2JEUVRqdWVOY1NXM1dOSldBRFgyTTd4WGZT?= =?utf-8?B?Z1NMaFBqK2xpdEtTZGFWZG1xTUxOSDZ0eHQrdG5aNjh0SVFhakNHRkpIZTFa?= =?utf-8?B?TStWaE5jNWhDU1k3ancvcGg2T1A5YStwdVFUL2lZTHl6TFV0TWUrNU5IZTBE?= =?utf-8?B?UWpHQXVmbFlCd0pGUFIySHJsL29xRGVGUHFHdGwzQ0kwYlZBZjIzd1J0OG1i?= =?utf-8?B?MEVaTGxjQzBTY3Y0RG5lTnZxWWpQMnFBeXlwN05nbGNSYXlaakk5S1REcVhI?= =?utf-8?B?RVRsakEyTVhvWGVuRElDVTBYVEVSVGY2SU12dnhFajZpMmpIbnR4N2NsM1la?= =?utf-8?B?b3diY0E5ZncxcThJa0NvSi9CbzNKUmg5NFN2S0x1bGNESmVEbmRpUXFvaGMz?= =?utf-8?B?Qk5KeWpJTXdOV1psZGNDcHYrR1FrT3BsTUNUN3FmcXBMcy9YcGxqTGZHcXdz?= =?utf-8?B?N3IyZVh1YldMcVAyYXRpYTVjdjJrcmJodGwyMmFlRjd3M05CQ29ZQXNuaDM3?= =?utf-8?B?a0FTOUNBRDhCdW5iVzJaQUNwNzBSV2JiZG04ekpuZTNEVnVtZjhSRm5kaFF2?= =?utf-8?B?Y2FIQk9VM3FvcmFrNEhBUFlVemFtZVNhNm1rcjdRV1RzdXpJWWJXbXBQSFpw?= =?utf-8?B?UGFzM2FZeU5qdlQ1dkNsVHJ3RDBubU5yVTFrQVhGQ2U1UG5VdGVpWlh1VzFY?= =?utf-8?B?ZktxQ1JrcURxcEtXekFWVTMwcUxtbTFzbCs4aTUyRWd1cWVYTDgxR1NzZFlp?= =?utf-8?B?SFRNQzNXSk1CSkRLWWFzbml1V01YNWtCQ0FFeG9ONlFjNzdUUVlYcGJKMXU2?= =?utf-8?B?QkxiUUFKVE5ES01JRStsSUE4ZlNQOUxoTG55OENDMG00QkUwYlZEaUhNL0xB?= =?utf-8?B?SEVOaUVlMjdMbWxnbFRqNFJiOVdoK0ZHQjFOT1pTUkhLQWhIMVdDb0tFOXNU?= =?utf-8?B?cXRhU3dVTnFwS3UyK0hGTTQwVk1pVGZqTHd3N1ZWb0dlMTNWYjdpT2xtSzZM?= =?utf-8?B?ZnpEdHF5YUNjZ1dJRUVzbmRON0daTXhWbnMrbDcrRXZxb2JTaml3eXJGM2Ux?= =?utf-8?B?bkRmYVJCbjhNU29MVE83WWVHcTR1Uzk2aTlpdUJrTUM3NlByS1A4WC93aGRC?= =?utf-8?B?LzRGM2RndUdsLzVYU0tqc0ZKN0IwME00RzNaNGxVOFRVK3VRR3BXVFN0QXlY?= =?utf-8?B?UEVTRkZiOGtyZlFzZk1ZN2duL1Vqd1lTcUxRQ1NPL2h1cVRweXg1N1hza1V5?= =?utf-8?B?TVdmMWwzWEtOQjBSa29CSTZnUnEwZHExUjJxL0p1WFV2WjJmN0NZbnJRb0lr?= =?utf-8?B?cVVEL21uS3hXaWVWc3ZTb1VuQWlib3ljbmlCL05VQnJQZ1ZLeWlKUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d36fcc14-811e-4e5b-3175-08ded5c34d74 X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2026 09:46:32.9643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BVILyCFB8ycHIS7gGDyL6DrHbQ4mKTay1GC5+95s6F+zEa4U5P9q+D++XRtrK+1igKvXrxuJe441L/NqUanscw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5141 X-purgate-ID: tlsNG-d25034/1782726396-92321D51-E1E696EC/0/0 X-purgate-type: clean X-purgate-size: 1468 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1782726424261158500 RISCV declares irq_desc as a static array, opposed to x86 that uses a pointer allocated at boot time. This creates issues when attempting to add an extern declaration for irq_desc, as asm/irq.h is included by xen/irq.h w= here the definition of struct irq_desc resides, and an empty forward declaration doesn't make the compiler happy because it doesn't know the type data-storage. Signed-off-by: Roger Pau Monn=C3=A9 --- xen/arch/riscv/include/asm/irq.h | 4 ++++ xen/arch/riscv/irq.c | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/xen/arch/riscv/include/asm/irq.h b/xen/arch/riscv/include/asm/= irq.h index f633636dc308..b3e03117ac97 100644 --- a/xen/arch/riscv/include/asm/irq.h +++ b/xen/arch/riscv/include/asm/irq.h @@ -35,6 +35,10 @@ struct arch_irq_desc { unsigned int type; }; =20 +struct irq_desc; +struct irq_desc *irq_to_desc(unsigned int irq); +#define irq_to_desc irq_to_desc + struct cpu_user_regs; struct dt_device_node; =20 diff --git a/xen/arch/riscv/irq.c b/xen/arch/riscv/irq.c index 25d329500212..353e9246f15b 100644 --- a/xen/arch/riscv/irq.c +++ b/xen/arch/riscv/irq.c @@ -19,6 +19,11 @@ =20 static irq_desc_t irq_desc[NR_IRQS]; =20 +struct irq_desc *irq_to_desc(unsigned int irq) +{ + return &irq_desc[irq]; +} + static bool irq_validate_new_type(unsigned int curr, unsigned int new) { return curr =3D=3D IRQ_TYPE_INVALID || curr =3D=3D new; --=20 2.53.0 From nobody Sat Jul 4 21:04:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1782726421; cv=pass; d=zohomail.com; s=zohoarc; b=VZzorxkUDFGDFFI3jO5MdnA7DCyF23zRyznOk0gIhhn9qlnI8VP+MUFoR88RUxQiLkn5lW8045YpQ9F1gT0Il09kFxokBpdQDGMUtc9H6G3FN4puanTll8InORyeHYcxb2TG/xWDB/31QOlWAEnbXgIv2nhd2y+/9vq15mmTspQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782726421; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SB2wbjUvy0R0FHhYbGZoS+Kajo8TUqIXA5aTQJgQCh0=; b=fxsDFpHJQUp3UMsFFj6cM2Lxf0BwY27oXKjCudx5cD0G4v8ny5c/sY1USiIHrNtpBRPxe0A8cuHZmOdUGNM1pwWdYYb4Bo+1HImRz+/aZvEPI3I0chhP4DNQg+Y0/w+eL8AhKseEF+eCqmwrSeaZ3LO0KXXYKmE0HtFBAfIA0H8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1782726421014250.0754437303491; Mon, 29 Jun 2026 02:47:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1347354.1605222 (Exim 4.92) (envelope-from ) id 1we8Ze-0001yW-TN; Mon, 29 Jun 2026 09:46:42 +0000 Received: by outflank-mailman (output) from mailman id 1347354.1605222; Mon, 29 Jun 2026 09:46:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1we8Ze-0001yN-PV; Mon, 29 Jun 2026 09:46:42 +0000 Received: by outflank-mailman (input) for mailman id 1347354; Mon, 29 Jun 2026 09:46:41 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1we8Zd-0001we-DE for xen-devel@lists.xenproject.org; Mon, 29 Jun 2026 09:46:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1we8Zc-00DxKs-9v for xen-devel@lists.xenproject.org; Mon, 29 Jun 2026 11:46:40 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a423ef2-e002-0a2a0a5209dd-0a2a4502dae2-42 for ; Mon, 29 Jun 2026 11:46:40 +0200 Received: from [40.107.209.16] (helo=PH8PR06CU001.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a423efe-5a27-0a2a45020019-286bd110c41b-3 for ; Mon, 29 Jun 2026 11:46:39 +0200 Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by BY5PR03MB5141.namprd03.prod.outlook.com (2603:10b6:a03:1e9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.16; Mon, 29 Jun 2026 09:46:36 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.21.0159.018; Mon, 29 Jun 2026 09:46:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WYxlEIHLy1kNi2j5vYUPDFbXTVkj3SjoeB4tXtj/Z/MhMnjlem9qtNgZMT/xK9SzsOHU76JDOUfp4pHP5RRsoMWycy42dcCM0++IHqOxSUagP7EUl200HEB8BKwE0w9rWelELXnaBUTj1An3452uphoGvat2Flmg//FLvpVd/xWS1tWNxj/mIXeNqM+Gj7Kov5alWce9ehgCn95MSnPKeXfowQ8TO4Ia28RKCKVgjwtpvHApqkSfoCA6prWomVyCisjTNBVd9kzwpAvuzlAvrtXFtAACjn7S5R+bbpovKGg91FEfSm5P6qRauAdu+eUQCOK5/G+qwTlbVlWa4fM9DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SB2wbjUvy0R0FHhYbGZoS+Kajo8TUqIXA5aTQJgQCh0=; b=mJahms7vTwsFPDowc4jXvzMbU3Usmd3AnBtUpehAO2IifNj2oeqC1UKOT/+RqJZ+lnZmbVisNpjpevPvJDiT+tSkDoMs89xCfiidGSivOTHUzv//gaBTsVf37cyZVG1nJfAXRusnJ+HsQwbPaSIiaLUJCarrxoDS7OJzrA/dJoP4hKwcprVpzJFxXfdg0lY4hlBhjPrjsZKOrBKHMATpE7Uc7Y/OaXSdoXq9yaupPdNqi6OqWutUJEBtwHOornvJRvMqRvJImHPTVAeDVWjOHrWqJ1NUex9wfyzX70THkXvW8F/jA37Upn7lUq2I2/+GLVtZ0u5UL/RUdulgSNbf5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SB2wbjUvy0R0FHhYbGZoS+Kajo8TUqIXA5aTQJgQCh0=; b=s8oCm1wH8ChoVHD+RSfo83RvY1V4VyaiqZg/o3g4x9ZQqz3vcttg+MeC1hOZAWKOmBh7Ns1aFhR5TbU18RITh8eAPSEUoIttzWDTYGNOXmIUiSumRMc/iv4U3TsZCRM9KH9KP5DgaMzzPfNuIED7ZOC1eEln6hi4sDo/ejbCBZU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Roger Pau Monne , Timothy Pearson , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH for-4.22 v2 2/4] xen/ppc: introduce a dummy irq_to_desc() Date: Mon, 29 Jun 2026 11:45:29 +0200 Message-ID: <20260629094531.55555-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260629094531.55555-1-roger.pau@citrix.com> References: <20260629094531.55555-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MR1P264CA0083.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::23) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|BY5PR03MB5141:EE_ X-MS-Office365-Filtering-Correlation-Id: 0016a1d9-9cab-43c8-2a65-08ded5c34faf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|376014|56012099006|18002099003|11063799006|22082099003; X-Microsoft-Antispam-Message-Info: +U7PQEjOHWPPqMRDNitsR+JI6+WGrlX5amAqE0dJtuPaqotbV/rsfOjq4XbZhQeYxz8rZFYgVHmyOfWVA3CJkaCuYqsWiQfD/tkZhavH/ONIHXLWppgxUP6G5EZR66AfHGM+BLi34wCwroIMmqU1HmcNvnklpGAVZVfuC+4S5IPTp9lF+zD6pJwWUS91qdd8k0ERqJ47xEPkD6/RUILmijVN69v5+GIm5rIcmuIpVJy8sVioVNWM3XoFIqDGucrQNHAbjFdicPbmcXZQFBbXew5VSq3covYKyAMQ000j9oJc07064S5bRHKybExUBk2/pU7yK/On+oP9IsfZB623zR4W8Lh5G/H/uYULa3X0u9Rntm04wnabgOlq7NEerYk9h+MHUuS0OaVwjN6S5yg+UIUmZ0ARj44EAt8fcSnvdWQyOIdwncbMxB6C8mma9/3kQ4jqzrhRy8/Oy3QOC98BWsU9gITePodSiN3ZTfW9uX6yIWf6QM0UK717QgC5e8xgY8G+sSbCRbRumgnzkVhQRVCmyI0PLcMXIQT+lhPID2LPFgKctAS7zrPS/hmrhMDggtuCR4lrjrsnNDrSSF0q3dT9fwUVHNf+n+U1yv27PETCyaOHYtAXUpe3oaL1CGt36YXiQKfqCZ6XcuHGEXxOwbHDc4FyIflUa2Cjn9WXCnM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(56012099006)(18002099003)(11063799006)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUtyK0RIeTRabTlmNHQ2MitDSmVZU3BJVW5nZjZEM21RMFZ4K3pLZzg4eUs1?= =?utf-8?B?Z1d0NFFTTWtiWjNYZnUwZk5jaWVQRGUvTHlYYjBsTE93dldzVFJBTzFLSVly?= =?utf-8?B?OVJWa3lCOVZFd3lPTk1YaXRKc2tnZFhFYzFYempkQ2loZ0M1UGFnTWVTWkw1?= =?utf-8?B?amVXNE40czRtc3BQSmtIb3A3MERQcCtpU2VJeHMxSkZUUkdjMVZNUTc5Z216?= =?utf-8?B?YURrbDVISko2Wk5KdTU4RHRJeXQxZFFvT3RyKzhXQmJYeVhpSitzWE5uZkdM?= =?utf-8?B?clBTaGowSy9IM0hyMXdMOHIvL3hBSmtqYTZxNlRDOWtWUGFlN0lXa3NlcmhF?= =?utf-8?B?ZDU0bkRISVRHbjFwOCttQ0JpVml2eC9JQ0hxczArc0QzRklQN2NGcTlpYjJE?= =?utf-8?B?dW5Ydks1M3R4U1dXRkk5Qi92QndtNUlYM3NyVk5tTWxUWmRCSnl2ekpBeUIv?= =?utf-8?B?djBLVkNBTG01R0k0OU1vb216U3JqMnNuak5OUEJuUHZpV1JCZFlBcTlHeU9r?= =?utf-8?B?cGhTTTQ2UWwxWTRJWktmS0pvSnNjSVJtZkVBYUJFMzliUUc4ZWlmaGREZU04?= =?utf-8?B?dGF4NGpVejhWUHRGak1GMmpPMHBsamVweGpQYUV6UXVZZU1GUDVPVWlKaUdU?= =?utf-8?B?aUZtQjMyeUxYaVpjbnNUME04K2ZSTzc2Z1RTYzlQTGpQSVZmQzNmeUgwMWcz?= =?utf-8?B?eStuNTNnSm5tSHpua3R3ZlNGaTFZTXZuM3hWUUVsbEM3bllISDZxaExjQm0r?= =?utf-8?B?SFRqaUNFLzEzVlVOZE1LMERKTVlJa0VoWlBWUGp1a3hGd3JNVGU2VUFLT1ll?= =?utf-8?B?RmI5T3NQK0RZSkpiSEwvR1p6M3ErdFhRSmxtVGxJdk12RVZjK3ZnVmptdkYz?= =?utf-8?B?UWJUT2piQm9tR1FaZGE4K0hiODB1RUl5bVBObEdmOVBKUmpUWnhWdXp0aTl0?= =?utf-8?B?NmFNN3hwSU5IMGxRZCtFQ0VaL1AvN083Zjk1QmdzRzFLNklTTllVMmt3SGYr?= =?utf-8?B?SmdoMjVIV1BnQ25xR2dnRS96cHJEM2tzdlROMUNtUG5EMlRDMEJBd21qNHZh?= =?utf-8?B?WVdlUXZuVHZjYTVJdndreGhHWU1rSzVmTjFQQ0xHRERVUmJ6WXJxVHdERWta?= =?utf-8?B?dUkrb1ZwWTBEbXZqOGZ0S2lpbVFnazJHSVcwcE82N25GMUwxeG9XbldTY2xq?= =?utf-8?B?eWZZMkx1Y2planhPUGhjQUVCTmI0dUt5djQ2MGNTZ2pWKzJsTmk0cHc0Q1Va?= =?utf-8?B?bDJzVzl0U0VVU1FHbzhEY0ZMMWhFRFF2STh5aTNaampmWWRvWU8zSUs4LzhI?= =?utf-8?B?UVNzK21tYWVobVBhUVQxS1N5WFA4TVJDVy9iODVRQ0ZpMi9LZVBjU2VQRFRi?= =?utf-8?B?bGFhdlJXQUV1c0RZcEVoSzFDa05MODN5V05BWUx3RU90NlZLUFJlNTFXcUV0?= =?utf-8?B?eXc2S0Q2aGFLNloxQ0I2alVRdWNVbS90ZUwwQkcwb25MQkNlZkRHRVNvL3JY?= =?utf-8?B?dCtvOFJieHM1NWkwdVY5OEp0M0NRdjU5S21uRW1jNWJqc0g3R256cjVnekpL?= =?utf-8?B?TnZWM3NyamFNZmJMNGJad0xXR2FuU3Vsc25CYmxxMkxzMXJOa25lNXovWVRs?= =?utf-8?B?VmUzTGoyNkxjSFFJMmNJVWtWSkVzWlJKVGdVZG5CN1dNY0ZjOWJFUTNQUGNt?= =?utf-8?B?V283MkU0eXRxd0phWXdGTDMvRFlFaE0rRGFNMDFzbEhkWkh4alBxdU0vcy9F?= =?utf-8?B?SU9GTGhsRHVwemxQd1JMY01jQWRrTWUwTGZGd0RxN1dLNGxYbUlnRzIxRUtD?= =?utf-8?B?Si9ldDFKQkFFSkszcGd6L3BtVzdhRXphQUVDRkxlUklQOVliTUgzd0Y1c1FJ?= =?utf-8?B?cURGa1l4ZnBNN0RySTFuTkNiZ1pUNTQ2bkQ5NDN3Z0ttZlQxNkpIb09OMkE4?= =?utf-8?B?QmRnQThSOEd4VjRpSUVoYlJrU0dRR3VzME9YMThJbkE0T0hSSE5kTVRsZVJY?= =?utf-8?B?Y1BQU3UxNmRzWHpWWFlFUkxwMHloaHAyWmtLYmw0WWl6amJPYW5NR1kyZW5G?= =?utf-8?B?TnZ4dEVmWFhmSlJlOVpSeUpIOEdFdWVoYWsvSXcvSlhSM1hRMDdLMDdaUTRU?= =?utf-8?B?YWdEdU1vOWlSQ1FEV0prSVU2UEcreVRhNnlUM24vV2VrVXRINGlMUnNSVTFB?= =?utf-8?B?ekRmVVF2SHZubmxwbTQ2VjhkMWYrQWptTktwYmcweWxBaTE3TzV3Z2NmeGF2?= =?utf-8?B?Q0kzY1BGRHdRcGZkZkE5Rm9FZTJtNTRsWXRJcDNvaWtnTFBnenNaR0FONVZ4?= =?utf-8?B?eEs4UFZicng2aS9UNDNxTGkxYVcvSXpxTjdOa01sS295QUNURGhrQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0016a1d9-9cab-43c8-2a65-08ded5c34faf X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2026 09:46:36.7663 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GgG00QVakSMxOZF1MDPcojunwI+RibR3QVy/qqFhRspEwEipj4/CwoeBvjYKkhFTK4En9LVp8IgG05szUlpucw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5141 X-purgate-ID: tlsNG-720697/1782726399-76D107C5-E9BD08D1/0/0 X-purgate-type: clean X-purgate-size: 839 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1782726422245158500 In preparation for irq_to_desc() being called by common IRQ code. PowerPC doesn't have an irq_desc array defined, so it cannot use the generic irq_to_desc macro in the common header. Signed-off-by: Roger Pau Monn=C3=A9 Acked-by: Jan Beulich Reviewed-by: Oleksii Kurochko --- xen/arch/ppc/include/asm/irq.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/arch/ppc/include/asm/irq.h b/xen/arch/ppc/include/asm/irq.h index 5c37d0cf2500..fa70fd7d46dc 100644 --- a/xen/arch/ppc/include/asm/irq.h +++ b/xen/arch/ppc/include/asm/irq.h @@ -30,4 +30,10 @@ static inline int platform_get_irq(const struct dt_devic= e_node *device, int inde BUG_ON("unimplemented"); } =20 +static inline void *irq_to_desc(unsigned int irq) +{ + BUG_ON("unimplemented"); +} +#define irq_to_desc irq_to_desc + #endif /* __ASM_PPC_IRQ_H__ */ --=20 2.53.0 From nobody Sat Jul 4 21:04:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1782726429; cv=pass; d=zohomail.com; s=zohoarc; b=g0iVbTpfB1j4amxVjD476UmwiN463EOCcn3Vxk8ZLqEC69CwDNQFcCKK1F4bPGp4adQd1bjXwDWWH/Ih2g0jkDS5s+V1LFXPVNdQRnzLaahuBU0lroqw4FISGc0O6CcgcPvqoPooaLsT9HbfbGqgcvozmckqAQpiqfCItTPlDOc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782726429; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hINVQXag379ub8ETN0UXT7mZHnxEf6Iv20JJg6aNYIM=; b=Z2kzFofebJLxQLCSGbaShEltGDKrIIPRtVlnVdlq5iu8xaQ3INcbeAKpz39phR43r0HFahozMZv8uAQN/PyGlHA7PnsbxYAYDTCnVoPHbkIBeu81266wwsodjZIiozGbY6Tv87+G4RohVW6oOFo5+PkLencxBZlM2N+josLoIHo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17827264292624.2594998461943305; Mon, 29 Jun 2026 02:47:09 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1347355.1605231 (Exim 4.92) (envelope-from ) id 1we8Zi-0002F7-6j; Mon, 29 Jun 2026 09:46:46 +0000 Received: by outflank-mailman (output) from mailman id 1347355.1605231; Mon, 29 Jun 2026 09:46:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1we8Zi-0002F0-1B; Mon, 29 Jun 2026 09:46:46 +0000 Received: by outflank-mailman (input) for mailman id 1347355; Mon, 29 Jun 2026 09:46:44 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1we8Zg-0002Cm-Fe for xen-devel@lists.xenproject.org; Mon, 29 Jun 2026 09:46:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1we8Zf-00DxKs-OH for xen-devel@lists.xenproject.org; Mon, 29 Jun 2026 11:46:43 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a423ef7-e002-0a2a0a5209dd-0a2a45059dc2-22 for ; Mon, 29 Jun 2026 11:46:43 +0200 Received: from [40.93.196.8] (helo=SA9PR02CU001.outbound.protection.outlook.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a423f02-3cb2-0a2a45050019-285dc4083578-3 for ; Mon, 29 Jun 2026 11:46:43 +0200 Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by BY5PR03MB5141.namprd03.prod.outlook.com (2603:10b6:a03:1e9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.16; Mon, 29 Jun 2026 09:46:40 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.21.0159.018; Mon, 29 Jun 2026 09:46:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g3Fw/rpbwGRSRsZZCxcLzAPizsuE2H4e1CuTf0VVkx246aAO0ZkPRzeiaVBmDjEgh7SVbG9o1G5waz7M1NqX+xSJ4C9sByRbV1FgxTOhour1KRTsvYAnq2YgiWoRvMPlvgeo66FN2gGPFNiN0LTY5YRTgG+OXyEBhA29xzQq1QcGNB1584ckwuDL0v1bqqTvvpx8tUGVpSzsOEhldXWvy+5ojALAS8bW/4x+HJ2cGfrwc7fhlRe0d5XujKeCaSTfeEBCvRAicV6/XoPyZcnlBUKqVPsEYqGnFSNK++lmpZ1JtCRrUFNcxW4nZ+IQKsvy9WctoYSlTZBLNyVxcvl52g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hINVQXag379ub8ETN0UXT7mZHnxEf6Iv20JJg6aNYIM=; b=HWVs6nrWoUjPZsALRrwP5P89ZtKEo1t89m7nPvH7JA0CBLMGucJaSAddQr0d3zdZOK2PXmAfPETUU6o+k1/AsCLCJuuq3MgwgQ7CKqSWryjkddHyZclEpvPKnwWb3WgKq4f+JqA3o/fSq3nNwWa4/eB67LnFSiXs+RWCgpWmfJJRWId58HjXVJi2K1uVjHT2V9hjhIlzt+zVYbAzVPYykSsUPD/+4N+wvdFOGOGc41izn16yfjLw5bE0qmwF7Vfk17ho+ojUnHu1bnK1GWAKJ9n95ovw8+vaUXAIl22jSeFfsFqaRY4or+vv/hMA8wIpWoh8PN6HDPgvxG3ykAMxTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hINVQXag379ub8ETN0UXT7mZHnxEf6Iv20JJg6aNYIM=; b=C1Y/IoWZt3WhhLOBEeYlCJUsm/r3Riw/rhKITvEZ6ALDI354a1JuIDghC/QYGXOx47zojJzGqsawEdv/+aDSJ1aESsxnS5csmvZ9Xv8hWs92wgzfIo0s5S+SxLWTuxQGl8lY2ICqMmm1IHV+GkcsEyqlcqPUCJOmW797AZIK4EU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Roger Pau Monne , Jan Beulich , Andrew Cooper , Teddy Astie Subject: [PATCH for-4.22 v2 3/4] xen/irq: handle IRQ being disabled while executing its handler Date: Mon, 29 Jun 2026 11:45:30 +0200 Message-ID: <20260629094531.55555-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260629094531.55555-1-roger.pau@citrix.com> References: <20260629094531.55555-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MR1P264CA0054.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3e::7) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|BY5PR03MB5141:EE_ X-MS-Office365-Filtering-Correlation-Id: 153cc2b6-e990-4654-ab4f-08ded5c351fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|376014|56012099006|6133799003|18002099003|11063799006|22082099003; X-Microsoft-Antispam-Message-Info: 5kT278cU/EGVt+5V6M+/gbuFni4/7U/vGJrLCXlfg+mCId7O5IL4ugEvxuLbM0j5l8OZG1E3AQPDgUVUN6Wj2FzAI7cwrmYq+OgcGFn8N4xZIBrvc7y2HAxsL+JYviyk0c4HD2RT36srpRJA1rX16P//o+wnyHMR6PmRtf5Lrq3CVwzRDQ5We799cuqtBJ+J255LejXXOqRzye1uxyA/wTUgA0/Ff2C/66AvhxVMMhs2Wem6Jei99XZkw7wFmO0jM1ZTPnqNC/Qya49LsOOvL30r6DBxfFsCgDdAYpm00nerWnhXHLxgQYSDkLOiFgb6iVwGRDdLUKvfSsPVAsO57dEyi9xm3xqMkNgZPJnTK8IqkcklJG8liY7z6w4z+QfuwkMaE0eNQkCajw1/tRIIduVnGOKD2n553oUKJ3iii4nQ1MX0bNqqTJRkSpNhqAkUwcW3l/2Q2gKJ8ZV/BmL9d+YVYk3DF0ZhZ/Vybv0Re9zOrIr8vpBCLs+Oo06PMsz+nyJXpywNqxqb3nttfLlECGL7I8pRDziqXdpwZeyoahYuGvclFV6YIAW+lZZ2TuNyTZqNHp3UV9Udm42OBoo9h0WLj5nABY10VzlsQeU4eUEOXFoEff/6cQvFTHqbajrd/HRxuEPcq4t44PpdfgVAcIfR+JpWjMMeJdcmoJlnbao= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(56012099006)(6133799003)(18002099003)(11063799006)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TU5ES0FURkgyVXVOdEZ3bGluVnZUVWIvYTVrNlRJbzNBYmtkT3g1VGw5QnAz?= =?utf-8?B?bTFYVW9ZeG5WWW9zNk4zSWZqUFlGbXk5YVpDVERwc1FuL0loOXJwKzZaTlZP?= =?utf-8?B?dXJmVXNhbDhrazhJYTdTTTZwRVZkVGVhYjJ2aC96QUgzZnVFajJxSkV5TlRF?= =?utf-8?B?N25UcGtvVWY5VUdvVXFXMWZoNXhzZVdFUXFNV1RTcFJ4ZUxrQm95aUplT0Vw?= =?utf-8?B?QlVrRmN2Sy83ZVdVVFgwVWc2R3EwaUd2dy9nVHh3TnlrUFRXN0hZbE1UNGtS?= =?utf-8?B?eExES2tjNDZJUUp0Yk5VV1VFVDB4cERKaVpHeHhTWEpRR3dWU1VJZk5kSHhx?= =?utf-8?B?M1NUY013OXdUeWZaUklsSG9iVXdCNHNZOVpxanUrVTNyVTJ4VlpPUW4vdTM5?= =?utf-8?B?dVFmdGk3bi9yYm5sSnVRL3BuaElCRERIa1c0dm5KVHo1OHJ5OVNhMmtFM0lD?= =?utf-8?B?cDRBSmNKK091Qmg5TVJoUjJkZ0ovbWhUMG9IcjViS1hTcTJLcnpMbVNFUzVF?= =?utf-8?B?dko4S2R2UFNSS0NoYUVqOVI0OEt5U3F4TGc4aWYvTGNsTFl3TGpnanRMRERJ?= =?utf-8?B?Qkt0bVdCOUV2aFdxY0JTTHFEOVk2TGRJQWgyc0MrWU9HRXB6VUpvYjJJOXhi?= =?utf-8?B?U3dCblR1VmpzVWhwWFJXSCtaQlh4dHFiTmRZdEVQeE1xQlZ2MnZtTDNvZnFi?= =?utf-8?B?T3FSZHJtT3FVQzNPNjcwQkdmRkxVRC9ZRUc0bjQyUXVHNTBGanZjMkp6b1pm?= =?utf-8?B?SmpEM3d2S3kvWGxIdSt1VnVRYVIwaFhQbWZvMVhwaHR4V2dOSTUvdzREL1Vh?= =?utf-8?B?M09yRmFrellpZ3RsSlVTTnNxRFN4b2RjQUZXc1BGZTRFSTRZZVpzWWJKVkhY?= =?utf-8?B?YTRXWk42YjBLQ2dPeWsra0E4ZlJZZ2cwTERnZkszTExjcW42a2syRHM3Q2VT?= =?utf-8?B?UlJUbDZDK2EvQXk1eXp6V3pJV0RwTTROdkFYa0RYUmMvSEpuRDlLTDk3TlNJ?= =?utf-8?B?eXR0MUUyWnA4M0hzYmNnZE1ZdmZZZlNNMkFDR1lXenNidjVzQ2lDZ2NuRkpZ?= =?utf-8?B?M1UyenZyMkJSUHQ5dHQrSmtORjVEakxlUW04YjVuRGhFR2diMC9CLzRQNEpG?= =?utf-8?B?WFNsNHlPU2orNEl3cTJoVTlvY1BtQnpqcnpVbG84dEJILzdMRUhGY1haZHpR?= =?utf-8?B?MGkwODJ4bWk2Rlg5WitPTkJQT2I3VldISXpmU1VqU055M0pkcG10N0ZZbHhE?= =?utf-8?B?b2UzdGdhc0Qrc1hXT0ExUk9OQXdkTWlDcnhSQlBjYlRJRGJUc1JCWlU1d0N4?= =?utf-8?B?VWorNEFkNGtMNWtjbjdzRFk0UkxwRzV0THZYdGhUSnF6Y0VvSGRjc2xud0Rm?= =?utf-8?B?YlpVTkVSMk9TM1BqdWNubmRFNmJ4YTBQVFptc2M0MGNjSVpEL3IrbUVMSUJa?= =?utf-8?B?aXNYczN2Nlc3ekV4Nkp1djBmOUV5T2Z2K29lOGVuY1RNajNJblFwaDdua05T?= =?utf-8?B?dGM4Ris2cThBVzRzdzYrSGdKZnB3bmRyaG5DcFhWTWROWmhXVWFtcy9XMXJN?= =?utf-8?B?UzJ3OXc1WDVGaS9pRFNPTTRNQWdiWmpTTmR0SWZZTWtEYy94UjFoallxRmFq?= =?utf-8?B?UFlsZVpwYTJvTnZQZm5JTDBycEJKcFBzM24vSGtxYzRRNkw2R2daUjNldFpn?= =?utf-8?B?SnpuNEo2ZUNjR2VrSFNZWDdONWV4YmhYQkNhNkh2aTVFMWxOV3hIU1BySmpC?= =?utf-8?B?cVFFSEZYQXpVemo1ZTBObDI3aE5mVnJPeEhqL2swZlNQcnQ5N01YVzVzdzg1?= =?utf-8?B?bHJ1TExSOGNjcnVrYVJ0Vmx0MzB2a1pqT2xlblFnNUYvYmVlTU9GT0Nac3JM?= =?utf-8?B?RStGRjN4SklDZkNVRTZsWmZMT1NFVzJtREpRWXZuNGtiYnExVDUveVNzbHZs?= =?utf-8?B?N3NneHZkM3RJU21rV3F1WlZ0dTB6c0E2dkhYQVd4eEc1ZWpFY2NlRzI2c0lQ?= =?utf-8?B?T3p4RXpEVG1XcWwyd0dKbVdXeWFsSVdlQ2pMTEk1UzYxY3BpdWh3T0hwM2sv?= =?utf-8?B?V3hNQUx5VHdjQkE0QWhSUTVWSDM3dUJiZnpQcXVkRnZ6VGVId2Y0VDRIVDRW?= =?utf-8?B?aG1vdThOSktzQ29xekgwTi9rMmRDcmk3ZVgxMnNGNGUyVDVzTW5rU2JJOG1x?= =?utf-8?B?TS9ERnhTRXJJVExEbGxDakhldmVxYW1Ed1hCWGFCam94TTluTW84OHhJcFZB?= =?utf-8?B?cnd4SUYwbEpLMVlYTmhNTExKR1UxSUFaMkRIM0hnNXh3Mk05N0xZZ0RXaGdV?= =?utf-8?B?R002QURkUUE5RnM5djJSV2dBZGdvcHFkRVcyeSsxOE16WWpVNzRYZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 153cc2b6-e990-4654-ab4f-08ded5c351fe X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2026 09:46:40.5760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Z7irz5qrBT+RazFqfDrdu1T2/38odlPBjgExY/vs1scTGpHWbkOq4xtFtaqKa2iXXiirizy1ErwyfKbeboegg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5141 X-purgate-ID: tlsNG-c201ff/1782726403-0E5122B8-99831AC0/0/0 X-purgate-type: clean X-purgate-size: 1228 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1782726430149158500 It's possible for IRQ_DISABLED to be set while running the handler execution loop in do_IRQ(). Such disabling can be done by the handler itself, or from a remote CPU. Check for IRQ_DISABLED not being set in the loop condition, as to not execute the handler if the IRQ has been disabled. Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich --- I wanted to add a fixes tag, but this has been broken since forever, and hence I should add: Fixes: 4676bbf96dc8 ("bitkeeper revision 1.2 (3ddb79c9KusG02eh7i-uXkgY0IksK= A)") Which is pointless IMO. --- xen/arch/x86/irq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 739fc04bd16a..2082ad489d74 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -2088,7 +2088,9 @@ void do_IRQ(struct cpu_user_regs *regs) desc->status |=3D IRQ_INPROGRESS; =20 action =3D desc->action; - while ( desc->status & IRQ_PENDING ) + + /* Deal with IRQ_DISABLED being set while inside the loop body. */ + while ( (desc->status & (IRQ_PENDING | IRQ_DISABLED)) =3D=3D IRQ_PENDI= NG ) { desc->status &=3D ~IRQ_PENDING; spin_unlock_irq(&desc->lock); --=20 2.53.0 From nobody Sat Jul 4 21:04:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1782726427; cv=pass; d=zohomail.com; s=zohoarc; b=fi9m64UvOJXz6H1spIBcepR1NNBGMgbxoMpl5kFyPn9XNJobYhuQz5c1mdE+CTc/pX2h+1E/wE4ocOs486/ZpSy77ibkrsnAT7yINxChSuc391Km3VAEuPgt/LsulNb6yttGf+cJZApl1KE8uJA3GBbIwCHlT3fVIzr0k5enLzQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782726427; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MQ0ARhz1drnK6o4nFWM5dxAzHHPreb+bqF6dDS8tTi8=; b=Vrxg6oVZlcEmvoqinkDwsEMh1acHrBTSutrrNglKCmZACaE4vBJP4Os5ItCZVPv7D0rbYwkO8U97MiNFA0VfVRXW1+M/wgIWGv2gR1dq3bS84JWSkILyPZJCl/OcFV0TXqFsiQPaEDGuC9r06xPGlWVidfAlljNtK+LDBf5R7ks= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1782726427821742.0118460691087; Mon, 29 Jun 2026 02:47:07 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1347358.1605240 (Exim 4.92) (envelope-from ) id 1we8Zl-0002YY-GU; Mon, 29 Jun 2026 09:46:49 +0000 Received: by outflank-mailman (output) from mailman id 1347358.1605240; Mon, 29 Jun 2026 09:46:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1we8Zl-0002YJ-Cq; Mon, 29 Jun 2026 09:46:49 +0000 Received: by outflank-mailman (input) for mailman id 1347358; Mon, 29 Jun 2026 09:46:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1we8Zj-0002UU-VG for xen-devel@lists.xenproject.org; Mon, 29 Jun 2026 09:46:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1we8Zj-00DMOt-By for xen-devel@lists.xenproject.org; Mon, 29 Jun 2026 11:46:47 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a423f01-2eae-0a2a0a5409dd-0a2a45038398-14 for ; Mon, 29 Jun 2026 11:46:47 +0200 Received: from [40.107.209.34] (helo=PH8PR06CU001.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a423f05-ec1a-0a2a45030019-286bd122e0a2-3 for ; Mon, 29 Jun 2026 11:46:47 +0200 Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by BY5PR03MB5141.namprd03.prod.outlook.com (2603:10b6:a03:1e9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.16; Mon, 29 Jun 2026 09:46:44 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.21.0159.018; Mon, 29 Jun 2026 09:46:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bj+0BGrk8leKWPuc/6N4WrlRZVJKJm19Jdqee5/i7HCgUPIIyDAaJMxZtoqc+zXdVqhy4DZHX6ME680/38i2oNx6WNCKM1Bb+PCw/B+DzFj8JJnS6PuW1teLQtJPjhMy4B3WwsoA85rOFyo/rTkQ+JOtkBgV8sfshAejarB12ymIs2asfz9rJQXLw832jaBB4MuVkL354K/hmVz+flDjosS9vVtVVhpmQTtKUcNvq/9ej0Iq3IVWNMJ2oZlj0V0523/NdeMJvzaeh8ao/X2n2y0wgnqw8ALsHAD8Hts2cPWoOBzi4rOOYmtW+1ODarBCIa30h1uQN4by9GlL6D9BEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MQ0ARhz1drnK6o4nFWM5dxAzHHPreb+bqF6dDS8tTi8=; b=Y3QTQuqAD+G6T/6+Qi2NJkDph6/dpsCxyvbARO0nVpyqFaQxuZFKgoobsgzHHvSV+jiFWl92vKolTEVqfs+oBNV/fMqdHge+w1u27xX5WTkobkmPyFY2pUmWIsvJSEFdCwLO7DjSQ+AWoQNPt6ZmlxOqpmiFID59YHmVx2wIZasSD4k9IhCPL7Moesula5RlJY23RSkR+ZxIzV18mWRE3IDLTorTRwSsJOdnjjvXOE7RAgYT9o7+89DXuRHRtlxCR3OcxCe+rzr3/r0lVX3dOpy7xbILfFIrUwevJbmxU434bG2JcaIPnkzyCIRf5AC7no4zVkLO4zs31TF1Nj/U/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MQ0ARhz1drnK6o4nFWM5dxAzHHPreb+bqF6dDS8tTi8=; b=pc94AQ8xIU8G0sl2BTd5jMuxqaJKE0MmyT1nrMtAoz3DRgT0WJLRf3MC7FUiMqDe5bOxySKMwlggR1VqOjERjsUrrb/pTnCI9Q3rgYBizE9Nt8TI63pKZRDhtxd+V/2g+Z5+c/9+PxdJv2Vyyqt80fsX31Gb5WZ3VpmL9ni2uHQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Roger Pau Monne , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH for-4.22 v2 4/4] char/ns16550: bound execution time of ns16550_interrupt() Date: Mon, 29 Jun 2026 11:45:31 +0200 Message-ID: <20260629094531.55555-5-roger.pau@citrix.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260629094531.55555-1-roger.pau@citrix.com> References: <20260629094531.55555-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MR1P264CA0192.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:57::8) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|BY5PR03MB5141:EE_ X-MS-Office365-Filtering-Correlation-Id: c6dabde2-b356-4a6b-23ee-08ded5c35419 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|376014|56012099006|6133799003|18002099003|11063799006|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: R0OFv4v0xLGxFKiUSddbYgsKR7hRPBGVa3fA0nPa1+yFoBCrW84uRV3zkK75LRWfWBlj+nhZtvIN66z/FS3WmILfCU4i3R+ztaq2pmY04eWSvuC6UzkyFgVnR0TKHXShxahUcCokZBZzlVfwFQvvuqhsFOF72mjCH3DLGh4fE9DhWrB1EjeurksCesVY9kiKz8j38hFjc3hi21zsU569q5Cz+v+rhpAXZfV9zpnm8momf2qGp7L9G/DM53BMn6WWo+2ylK4Xqg8klT1aFyI0Nn2U+CYG2tFFVnM9x9O7w3yZ4AE0Bw6+EezQwvhEWNHPHxSls80GuC8l1ZWJekhnaBIaDxcYR4TbZfCTKZY4AMGSXrfhx2Fbl/bwqjw0BwZFFhxBgYtnPH2vfIpljxu7Z0g+zf4ahj4Hr/An3w4fFIWcgtXEtR7JtVufGabFRNgO0i6unHvXJJx9w97req2nIw6cugenHFEWpnML5E65tNyLQo8FZPXIAQjXtl7SbpXiEqYpD6jkb8fQIUeufzR+M91kMheQ44zgGC7xBbDbloI1mnLRecJRR2iN+2DNp8PC8X32vTVLZYlIiVsA02FQDSL/L1A28beBLmvGdz1NYW9NRRLxZXeI3X/vv6U0kyQ93RO4C5tFWpBnB7lD/8tbC/R0Ojjrja26SNI2SiqWlO4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(56012099006)(6133799003)(18002099003)(11063799006)(22082099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3JrYzgwZndSZlVFWTFzOSs2RzdoKzZxM1l2QXlZc3FUQ1BPc1JMbVlpQ1Ar?= =?utf-8?B?cUZZVWdScDRtTStVMFp0eWFXOHhzVG9kbFQ0ZU9kOXZlZkErME4va1Fwd3hZ?= =?utf-8?B?SFFiSmMvK0d4cXFwenBXTTJ5NEExU0RKZFE1YlB3L2pEK0hVQitENmpReTh6?= =?utf-8?B?VUkzYmp6RVVMbDlWd1NFMjVBSXk2a3B1OGtpZUdObHUybVlXdFhQUUpGWGQx?= =?utf-8?B?Wno0a01FcXhIUXoyUmw0cEVCUEdOa3BVRXpoWUszbnB3algxQTFXUWNrQS9D?= =?utf-8?B?WXQ4c1pHYm9VU3k4Uk5OZnhMOWcxZUVCcmNoMVkxZkhtMWJ5Zmc1Qk44UXNW?= =?utf-8?B?L0VLS0h1b2V3TGhVNFF4K29BaDFlc3hWY1g1NTBpa1hVWWovVkNGSWlwUWZw?= =?utf-8?B?SnJuYU1OVzdZZ2tWREc0NmU1cHQrVW5jOWJ4ZmlPUCtRRUpXYVFZRG5aYnpi?= =?utf-8?B?ZzZ5anJneVFWZWZpWHlNZDY3YzlaSlJUaDJCeWdKRU53SlpWTlFFL282QUk3?= =?utf-8?B?K3NNNE13MWNZRnBOZ3V1ZWZ3cE9xWU5hRkxLcENGNEFlWXZmeWVCK0Z0c25V?= =?utf-8?B?NWRmZE8rZHo1WCsyU05HaS9pTmZIRTRjK3IweTBhOU1KSk45bVBwTEVYM0Rm?= =?utf-8?B?V01IMC85b0F1M3B4eDE1cVBPYW0rYmgzUXh1WVl4S2tRZ0c0VzY0ZEZjRTcv?= =?utf-8?B?Z3JMUmlJMEVsSEtmM3hwbSt0bHU0Mk1jM2ZLV0s5QjhCRVA2Uit2REMrc1k2?= =?utf-8?B?ZVVtQTJyS3JqYVpBKzczKzRySWt6TzAxanRyb0p2bUwzTG55SS9UUzVZVit0?= =?utf-8?B?cU9aMm0zUHlZSW11Yy9FUjZZZHBRb2c2NDJMeWN2ZXRWZ2JJRzNreVRrNUdX?= =?utf-8?B?ZGl1RlEvTWttaU0wTnVoeTUxaXFFZ09Gc20vNHF0NHl1TS9sTG5EWXRYMnRv?= =?utf-8?B?cUZsNEFmejN4ZFF3R2tJNVVkOGpWU09PdUpvQmZMNmlDMU9adkE4dFhhb1lK?= =?utf-8?B?d0hNWVRZK3VvdlVzOFBzV2RlV3VPcTJyVVFlVkRSZE5VYnVaUldYczJJQ1Ev?= =?utf-8?B?Y01pWkptQ1pMZVQ4VGFSd2phU2w2WGhtWm5rOEpLM1dDUmgrbUZQUmFoSGZs?= =?utf-8?B?djZ4Zlg3UGIwQjRCV3pTa1ZvcGdhMUFRYmdVRzFCYTRXVFl3U1VBczQzenJD?= =?utf-8?B?aVRYZUhvV2JHSzlreGtSUjk0bzhxNU1TN3k0eGRVUVdQeEVLSUJvbHVRL0pa?= =?utf-8?B?RVFtQ2VGdVYvdFQ2c0FwSi9ZYWxIT0lRSWRsSU54REZjMHc5d29CaGczMmFn?= =?utf-8?B?RXp6RGhzN05SRmxxWmduTWlhdHZCTzd1SExBYXJjaUltd2NTd2FqUnB1TnZk?= =?utf-8?B?NVhMeGxSWW9vbTFmcnF3VDlnTVhtdmVvUnRJVUx4eTdLZG5pTE9oWU5aTHVU?= =?utf-8?B?TC9UOWs0V0RHeVJQOTJQSEUyemQ1Z2hQOGZFSGFHM1h5RjlwYWhYa3B4Sllx?= =?utf-8?B?Y2ljKzRXVkcvMGVFQmU2V1g3UFdlWGNZZmVvQTVPOWlobUdpcnM5M2dLbi9q?= =?utf-8?B?bnFBd25EdXMva2szMXFzdkJ0LzhnQWNtWjVzbHhmaGgxaWhRMFllVlhUdXBH?= =?utf-8?B?Y2Zob3hmVlZObE1ldDRVcCtTRjJtczVqTm9iVmF3cldCNVVGZmNIZ0hsZXFu?= =?utf-8?B?RURxcFlXeG1rcnRZUlFTL3dMRDQ0cS9RdjExcFJxMlNwMFZMb1F3a29TUnZx?= =?utf-8?B?L3B6WEdPd096TklVKzlHVnZMZVJ5M0djKy9KMDdxaVVIbkxIa3ppbkN2NW9F?= =?utf-8?B?Vkt5MEdCT0NHTVk1TGtnTXpUYmhtb2NVQ1lJeCt2b0VVQUJIUEFCRjArL0NS?= =?utf-8?B?aEpFd3VYSHRzT2RRbm5ETGhrd1ZHWFlzWGJVbGZRUjVSUnM3aHV0bVRTVnJT?= =?utf-8?B?ZDFYcEpGYjdmNjkxWnYvWjlXcEdBYlN1SXBBRE1ZVjhaUEFZU3Fsc1FCVjVp?= =?utf-8?B?Q2Z5SnREaEpESktIeldIL1FGa1VPZkZtRWJrUFF2VEdGZGxjOGRDQmFGb0p5?= =?utf-8?B?WFMxcS9SQXVacEhlRnNIdDEzYjcrVEtPbWdSWi9nMFNaRXdzZzFkMUlRelRT?= =?utf-8?B?TjI2Vmo5S2xNNVlFcEFGNHNmeTI2cm9DSXQxMXRoMkVGdjlUNkR3d0Q3eUdh?= =?utf-8?B?bVk0S0FmOUZDUGhiWURMYUNpazJXaUJOSS9iTmNGcGpFdXg3SGlVTEtUeGRy?= =?utf-8?B?M2xFdk1wRGpPQi9Mc2gyMUN0YlRVaGw2ZFdYRGRxUzVCejkycUkvSHNMUW9D?= =?utf-8?B?T0k1TTVjamVmL3RFRHltL0VESU1ZQTZhOHJTdlhjaVNqR2FBeVZjdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6dabde2-b356-4a6b-23ee-08ded5c35419 X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2026 09:46:44.1172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bQqQmkpISebonw9TOsEfBS1R9gluA/mIBuQVy9ul2LxJuURjpx8GysIDj9KZc8H9bbpoDfhgIPK+aMUdeuRRqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5141 X-purgate-ID: tlsNG-33051d/1782726407-06F2A5D1-F6231E85/0/0 X-purgate-type: clean X-purgate-size: 4855 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1782726428170158500 The current logic in ns16550_interrupt() will loop until the device sets the NOINT in IIR. At least on the Lenovo ThinkSystem SR630 V4 the flow control of the serial-over-lan emulated UART seems to be broken, as it doesn't set the NOINT bit consistently. The Transmitter Holding Register Empty in LSR also seems to not be properly signaled, as even with it set writes to the transmit register take ~6ms. This leads to the watchdog triggering very easily on such system. Introduce an upper bound on the execution time of ns16550_interrupt(), this is currently set as 4x the polling interval, which is calculated as the time to fill RX FIFO and/or empty TX FIFO. The current maximum is 5ms. Once the timeout triggers the interrupt is disabled and the uart is switched to polling mode. Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich --- Changes since v1: - Move irq disabling to its own helper. - Turn force_polling check in interrupt handler into an ASSERT(). - Improve logic for timeout calculation. --- xen/common/irq.c | 12 ++++++++++++ xen/drivers/char/ns16550.c | 30 +++++++++++++++++++++++++++++- xen/include/xen/irq.h | 1 + 3 files changed, 42 insertions(+), 1 deletion(-) diff --git a/xen/common/irq.c b/xen/common/irq.c index 29729349a6f2..102974d120f4 100644 --- a/xen/common/irq.c +++ b/xen/common/irq.c @@ -54,3 +54,15 @@ unsigned int cf_check irq_startup_none(struct irq_desc *= desc) { return 0; } + +void disable_irq(unsigned int irq) +{ + struct irq_desc *desc =3D irq_to_desc(irq); + unsigned long flags; + + spin_lock_irqsave(&desc->lock, flags); + desc->status |=3D IRQ_DISABLED; + if ( desc->handler->disable ) + desc->handler->disable(desc); + spin_unlock_irqrestore(&desc->lock, flags); +} diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 878da27f2ef8..a371bc5cc85e 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -62,6 +62,7 @@ static struct ns16550 { #endif unsigned int timeout_ms; bool intr_works; + bool force_polling; bool dw_usr_bsy; #ifdef NS16550_PCI /* PCI card parameters. */ @@ -190,12 +191,38 @@ static void cf_check ns16550_interrupt(int irq, void = *dev_id) { struct serial_port *port =3D dev_id; struct ns16550 *uart =3D port->uart; + /* + * Set quite arbitrarily as 4x the time to drain the TX or fill RX FIF= Os, + * set the upper bound as 5ms or the timeout_ms value, whatever is hig= her. + */ + const unsigned int delta =3D min(uart->timeout_ms * 4, + max(5u, uart->timeout_ms)); + const s_time_t timeout =3D NOW() + MILLISECS(delta); =20 + ASSERT(!uart->force_polling); uart->intr_works =3D 1; =20 while ( !(ns_read_reg(uart, UART_IIR) & UART_IIR_NOINT) ) { u8 lsr =3D ns_read_reg(uart, UART_LSR); + s_time_t now =3D NOW(); + + /* Break out of the loop if spending too much time. */ + if ( now > timeout ) + { + /* Disable the interrupt source - it's never shared. */ + disable_irq(irq); + + /* Disable interrupt generation on the device and arm the time= r. */ + uart->force_polling =3D true; + ns_write_reg(uart, UART_IER, 0); + set_timer(&uart->timer, now + MILLISECS(uart->timeout_ms)); + printk(XENLOG_WARNING + "uart interrupt taking more than %ums, switched to poll= ing\n", + delta); + + return; + } =20 if ( (lsr & uart->lsr_mask) =3D=3D uart->lsr_mask ) serial_tx_interrupt(port); @@ -223,7 +250,7 @@ static void cf_check __ns16550_poll(const struct cpu_us= er_regs *regs) struct ns16550 *uart =3D port->uart; const struct cpu_user_regs *old_regs; =20 - if ( uart->intr_works ) + if ( uart->intr_works && !uart->force_polling ) return; /* Interrupts work - no more polling */ =20 /* Mimic interrupt context. */ @@ -313,6 +340,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart) unsigned int divisor; =20 uart->intr_works =3D 0; + uart->force_polling =3D false; =20 pci_serial_early_init(uart); =20 diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index 6071b00f621e..64a25c96a4b7 100644 --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -121,6 +121,7 @@ extern void release_irq(unsigned int irq, const void *d= ev_id); extern int request_irq(unsigned int irq, unsigned int irqflags, void (*handler)(int irq, void *dev_id), const char *devname, void *dev_id); +void disable_irq(unsigned int irq); =20 extern const hw_irq_controller no_irq_type; void cf_check no_action(int cpl, void *dev_id); --=20 2.53.0