From nobody Mon Jun 8 06:38:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1780688549; cv=none; d=zohomail.com; s=zohoarc; b=jvAtMwlfgFLgMm4ugPa1OfxLhdU2pVvSaAIudrEtiDN2aEcBNlC1WZPausGko3VY9UuRqxUE39TTISRJkukBzPKpsA7ZQbSV+YHtGDB1G35NPVmQRwdlgQeeGg7CVii09pLDmWBqwu0AJHPDly19+W/LlwajO9M2L9BlhO43V3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780688549; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=q6oiapKsV+cY2nYjZA9ZlhILCfHHCwea7VA5eY2aWGs=; b=FocOOEo/IIwdCU2SVXaiJlIMqxT4v0EmY4Cj3V/XFhBlZimrmN4SncxJuQHC3XvJBT0vdgr9c1pcHXR2sXCBWvKk70YHqVgjlzCqcK1dsthmxGDv28/ADbWO3XQvKxZ96EfcHsivOuCuuxfoRoGJKJ047lTdVHW/oppn2rf3W2g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1780688549410876.7703036426211; Fri, 5 Jun 2026 12:42:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1330004.1593846 (Exim 4.92) (envelope-from ) id 1wVaQc-0002us-Gf; Fri, 05 Jun 2026 19:42:02 +0000 Received: by outflank-mailman (output) from mailman id 1330004.1593846; Fri, 05 Jun 2026 19:42:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wVaQc-0002ul-DQ; Fri, 05 Jun 2026 19:42:02 +0000 Received: by outflank-mailman (input) for mailman id 1330004; Fri, 05 Jun 2026 19:42:01 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wVaQb-0002uf-Hf for xen-devel@lists.xenproject.org; Fri, 05 Jun 2026 19:42:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wVaQa-00EeIU-Uq for xen-devel@lists.xenproject.org; Fri, 05 Jun 2026 21:42:00 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a232688-e002-0a2a0a5209dd-0a2a45079678-0 for ; Fri, 05 Jun 2026 21:42:00 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a232688-229c-0a2a45070019-d1558030e0ba-3 for ; Fri, 05 Jun 2026 21:42:00 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-490be29c1c5so27978425e9.2 for ; Fri, 05 Jun 2026 12:42:00 -0700 (PDT) Received: from localhost.localdomain (host-78-146-242-105.as13285.net. [78.146.242.105]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3d6c65sm172706495e9.12.2026.06.05.12.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 12:41:59 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1780688520; x=1781293320; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=q6oiapKsV+cY2nYjZA9ZlhILCfHHCwea7VA5eY2aWGs=; b=SoUuEzhsx4S3c2aDq+Ov/ADE/uWQq/Jcds7vWPTzQjaEtu0Eos8xFqoJl6P4ktrylE GSvf85qTQUxiYJyT9zK7yl0QP1NsjAOoRp/g+h2MulU5PupDfT3eIwcpCzR/OHbAyGC3 gvLPg+QqYTZJ3zfl5r9inHJQvkqpoOiSRcpiM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780688520; x=1781293320; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q6oiapKsV+cY2nYjZA9ZlhILCfHHCwea7VA5eY2aWGs=; b=TaKDkKc0g9TBQIgr+oYFcARKBr6NnpzzPvYECQ6xsAZdWGL6plEn3wTQy0BpbEYYny 8XPYzyTcEzFUlaW2KF3osGJ+mqL1ucfbg4kBTik4donkFHljRo9JUBzIwVzkpaV+EHPn L0fpJE3mrwXEAPmK37C4pHo4cZDho36gAWszoC6P4yyOPP1twNTnZIWaQREFxZct/DAo lgnFeT+F8l/r3CHxJ+4WXt1wTDaNtOjA2b3F1aQs+w4WG4oMDSYgd7DTVzNnAeaSQK21 LKZUEjUPqx5pfig+cm8x6R8FFkF8Ysh0wlsjHkxS+FLvn9szNZGJcQp0OucwhYMHaULV 9Iqg== X-Gm-Message-State: AOJu0Yxy0q1/b3y3xEB2V4hHBlwe4mv3G5sdB09buuhRIU7UytCpCN1a XAN2Lm79rDhMzd5pzg0KnSpN6JuIrUdAjY8OHJ85vQjFEooXaOCFLQCLXpzgqGSNoV36Vga2z3I VqO33 X-Gm-Gg: Acq92OEW2toCSUStNPsyAnpCZBAXj9V5PxTBwKK6QTNNHkydEgI2AgnvM+iRdnrnGD0 23syXBpBjpZzwbIXHlvBD/70AfOQom8A0GRug+vY7Yj17fka3kglbULuuiV5r9yyTCh0eq7zqwF hwIe3Liq8uTwWPLOXBQa+jXqPeqdmJxX6HjkwF85wGVJuARvlIpq+IkbMoLgfO6EcAzbnMZxFqE CAFNZrgZaUwyZW7YJU2mXtbtvlWmwUwvGwtAoyOCDYUaqUCnl8gp+0hnN6QyflyP97w3KHfdWGd V1u+zKZBRp9bSt2g5s2dcO88NfGMFqNelnUf58mKibV/QSoYHRpjXJKpCDtJP2NtFWLmNWCBqrA dZHoRAOipQmZVrjm1ZnkL2N5a8qU1sxvUoTY1gWnvGwpLpeEWTdaqBpY/2i85WJXrfCTULAPZfO tK2udRbDFHGcBTTMAilILpzylgJp4Q5eOFAWLcTLYjQwviaW9Pg51ae/VpzvAEzqrej0g2ltDIA yz3MJRv/hDtQuM= X-Received: by 2002:a05:600c:34c1:b0:485:4388:3492 with SMTP id 5b1f17b1804b1-490c25716dcmr79832775e9.11.1780688520099; Fri, 05 Jun 2026 12:42:00 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Hady Azzam , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tamas K Lengyel , Jason Andryuk , Penny Zheng , Oleksii Kurochko Subject: [PATCH for-4.22] x86/hvm: Partially revert ("xen/mem_access: wrap memory access when VM_EVENT=n") Date: Fri, 5 Jun 2026 20:41:57 +0100 Message-Id: <20260605194157.2762581-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ef75cf/1780688520-2176AC48-4119BEAA/10/73395122804 X-purgate-type: spam X-purgate-size: 1976 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1780688552346154100 It is erroneous to check current like this. e.g. Dom0 does not have VM_EVE= NT active when it's introspecting domUs. The use of vm_event_is_enabled() is only for the IS_ENABLED(CONFIG_VM_EVENT) short circut, so just use that directly. Reported-by: Hady Azzam Fixes: b18e38e42da6 ("xen/mem_access: wrap memory access when VM_EVENT=3Dn") Signed-off-by: Andrew Cooper Reviewed-by: Jason Andryuk Tested-by: Hady Azzam --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Teddy Astie CC: Hady Azzam CC: Tamas K Lengyel CC: Jason Andryuk CC: Penny Zheng CC: Oleksii Kurochko For 4.22. This is a regression vs 4.21. Only compile tested. --- xen/arch/x86/hvm/hvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index f759a397c557..cbcef18449ee 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4789,7 +4789,7 @@ static int do_altp2m_op( break; =20 case HVMOP_altp2m_set_mem_access: - if ( !vm_event_is_enabled(current) ) + if ( !IS_ENABLED(CONFIG_VM_EVENT) ) { rc =3D -EOPNOTSUPP; break; @@ -4804,7 +4804,7 @@ static int do_altp2m_op( break; =20 case HVMOP_altp2m_set_mem_access_multi: - if ( !vm_event_is_enabled(current) ) + if ( !IS_ENABLED(CONFIG_VM_EVENT) ) { rc =3D -EOPNOTSUPP; break; @@ -4841,7 +4841,7 @@ static int do_altp2m_op( break; =20 case HVMOP_altp2m_get_mem_access: - if ( !vm_event_is_enabled(current) ) + if ( !IS_ENABLED(CONFIG_VM_EVENT) ) { rc =3D -EOPNOTSUPP; break; base-commit: 3c4e804607a5a1254b168d88572cb9ec311543a9 --=20 2.39.5