From nobody Sat May 23 20:59:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1779138341; cv=none; d=zohomail.com; s=zohoarc; b=Ool4362/f183YRwx+J7y5JHvUJ7VDE/JNNCTF54dH9RRApzkpJPJ75S+eBITIdy9L7c6wGe0nn/eFDRd6VeSs8i/22oY2QfouEFkNLsHvUsvIftd9TuLrLBfjtzRHpcr+AxWSHOJtbBaOPkMVvknFIvWHcx9x+Rm7MElxwxflbQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779138341; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=agHCrwJYP0DCxaiVVTnVqUVT8BS6ccgDGvOgzoEs3C4=; b=ALCE7vYVPZHKcN68/OxsWT8Mj9WqytcTCyKqdWh+IW0Th+CTsanpcYLn5iFI3qrxTVb8Oe6PpMocnLlw6uyctQSsRa1SWNTBPdzkg5e2eCzinGL/w1sPoYdlJqxdvRmcX//mScPGtT07HLlVVT9nesl7m7MVN8Oztkuwqu3efMo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17791383416221022.0549190950651; Mon, 18 May 2026 14:05:41 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1312239.1582381 (Exim 4.92) (envelope-from ) id 1wP59M-0007Gd-EV; Mon, 18 May 2026 21:05:20 +0000 Received: by outflank-mailman (output) from mailman id 1312239.1582381; Mon, 18 May 2026 21:05:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wP59M-0007GW-Bd; Mon, 18 May 2026 21:05:20 +0000 Received: by outflank-mailman (input) for mailman id 1312239; Mon, 18 May 2026 21:05:18 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wP59K-0007GQ-Ln for xen-devel@lists.xenproject.org; Mon, 18 May 2026 21:05:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wP59J-009coL-JP for xen-devel@lists.xenproject.org; Mon, 18 May 2026 23:05:17 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a0b7efc-5cb7-0a2a0a5109dd-0a2a4504ccc0-16 for ; Mon, 18 May 2026 23:05:17 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a0b7f0d-1dec-0a2a45040019-d155dd31b507-3 for ; Mon, 18 May 2026 23:05:17 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-45ae6a0e523so1431151f8f.1 for ; Mon, 18 May 2026 14:05:17 -0700 (PDT) Received: from fedora ([212.231.230.22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a17a22sm40443669f8f.22.2026.05.18.14.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 14:05:16 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779138317; x=1779743117; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=agHCrwJYP0DCxaiVVTnVqUVT8BS6ccgDGvOgzoEs3C4=; b=iNx23pqOp5n8Zstd1aSEz+UOlJ6s0IWCLpGRKuk9gv6+NPTb+KeGyXfB+mJh5Zq7kg uZBbE8lZQNfTDVKiDHg81fRL8YWXIZcqME4Hajezhq4kavOTFL1JjC+HZcnD3gfDVKg2 oScj7lsWjBykG5mVYTuRqqOvyCMnFlz69pUllcIzubwLgoN4AR1GC1Bykd8MOzIUe3xf D8Gg+dxBQnPHUOPzI/9Y/Du/vsUdVNdMmAFPHfmdyFWAZHVHFANBke+Oh1lPfH3oa7b/ 8maf6QEwXb0hJ7qQBENTG831Sivk4h9epXKdZ22/bVebOx9aEYFjAoChx63LUIKwGzWT kQ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779138317; x=1779743117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=agHCrwJYP0DCxaiVVTnVqUVT8BS6ccgDGvOgzoEs3C4=; b=SHnuBss08wuC1uNuWLrHJdMmuhf7mt0I8PWN/CdQ95xMnSVFf7UGrZ4GDZsw6NdjyW oe57w7QuD2a91mlc+UOIPJHlFEkRqWvY80ENJ2ooF9C7tZHOmkFUx6kMZwLDsuWCz7Ub qSY1x0YRE8+MYlUILVJaE5RqDfKQnxoYs7fzQVqfnQMiT5g1YrEnhKbk7+hqFDDD87TU 4ycSxMxxXxgG6oi308Qc6j9BiNQQpd6han9iYsfv2Wl6TUUEmwwmAYpJnDMlWkJvjaTr BCgpksU/V9KK5b3qPCjePU7f7W1SquPczsjmE3ZsR8pHNvrE1CnUollRcoyk3M/SXoNI 2heA== X-Gm-Message-State: AOJu0YzyMU1Rj6SBXHdD8U1S61fOlo0wHBtU4aOsSbzoe0qNCqCWBAAk 3mA6U2YCxZijH7MIXCDbyYuLf5wtYb/+NLBz1ODha+vRlPhDtJH9hca6g8aSrlWYQ1A= X-Gm-Gg: Acq92OGaasIoxL2d+Z4iiwvWoJwzut1gPK3qEEUMfk2/TFmDhtoVfa5C/n2DRjNBVDj Ry163sHFT61XbKNcXhbA86dVVT1xPYv8KlMCvyqVkQAJIPxtvS6885phK22pUNuBBmPRKICPN7b QBZl3vBPck+7JC/SRO45O5M4wEgVFfyh6KkngY3UkRNpHPFN1ZDGlCPSWu37sRPDyfARPvnI8Oo WRj+Cde6srod8MBtgztmJrK9pNVk0+9ryZ2gBBwSkuPVwCYaJdPNStwtRjkNQfnaoxSJ7aKkQoW mFLpLYEeaXfkYm0g8oyucprb0yqan7/U5mqRAjTXxi9kDpjIcsj6mE8K/J6UM8xPRZPpFjW2G1G SZzA3OUmnO8ZOhS3r68TRr9BLr/gyqi1IK9iRYM8sZPadCbAHXtp/8xKVJFxJhHQWlD3cA97bF9 8A87b7I8PowZFk9LbXF6zCR7U5fCKtrtU= X-Received: by 2002:a05:6000:400f:b0:456:15fa:9eba with SMTP id ffacd0b85a97d-45e5c5a56f7mr25710079f8f.43.1779138316581; Mon, 18 May 2026 14:05:16 -0700 (PDT) From: =?UTF-8?q?Gabriel=20Quint=C3=A1ns=20Souto?= To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, =?UTF-8?q?Gabriel=20Quint=C3=A1ns=20Souto?= Subject: [PATCH v3] arm: Fix PT_PT table descriptor value and comment Date: Mon, 18 May 2026 23:00:08 +0200 Message-ID: <20260518210340.81347-1-gabi.qs.mail@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ebf023/1779138317-28F753FF-7C68DAAE/0/0 X-purgate-type: clean X-purgate-size: 1929 X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1779138342303158500 Per ARMv7-A/ARMv8-A ARM, bits [11:2] of table descriptors are ignored by hardware. The original comment incorrectly described block/page descriptor fields which are not present in table descriptors. Use the minimal valid encoding for table descriptors by setting PT_PT to 0x3. This updates both arm32 and arm64 for consistency. Signed-off-by: Gabriel Quint=C3=A1ns Souto Reviewed-by: Julien Grall Reviewed-by: Michal Orzel --- Changes in v3: - Use 0x3 instead of 0x403 Changes in v2: - Apply fix to both arm32 and arm64 - Use 0x403 instead of 0x743 --- xen/arch/arm/arm32/mmu/head.S | 2 +- xen/arch/arm/arm64/mmu/head.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/arm32/mmu/head.S b/xen/arch/arm/arm32/mmu/head.S index cab7be0621..3731322f7e 100644 --- a/xen/arch/arm/arm32/mmu/head.S +++ b/xen/arch/arm/arm32/mmu/head.S @@ -8,7 +8,7 @@ #include #include =20 -#define PT_PT 0x403 /* AF=3D1 T=3D1 P=3D1 (bits [11:2] ignored in tabl= e descriptors) */ +#define PT_PT 0x3 /* T=3D1 P=3D1 */ #define PT_MEM 0xf7d /* nG=3D1 AF=3D1 SH=3D11 AP=3D01 NS=3D1 ATTR=3D111= T=3D0 P=3D1 */ #define PT_MEM_L3 0xf7f /* nG=3D1 AF=3D1 SH=3D11 AP=3D01 NS=3D1 ATTR=3D111= T=3D1 P=3D1 */ #define PT_DEV 0xe71 /* nG=3D1 AF=3D1 SH=3D10 AP=3D01 NS=3D1 ATTR=3D100= T=3D0 P=3D1 */ diff --git a/xen/arch/arm/arm64/mmu/head.S b/xen/arch/arm/arm64/mmu/head.S index 375d703d9b..8e514d2114 100644 --- a/xen/arch/arm/arm64/mmu/head.S +++ b/xen/arch/arm/arm64/mmu/head.S @@ -8,7 +8,7 @@ #include #include =20 -#define PT_PT 0x403 /* AF=3D1 T=3D1 P=3D1 (bits [11:2] ignored in tabl= e descriptors) */ +#define PT_PT 0x3 /* T=3D1 P=3D1 */ #define PT_MEM 0xf7d /* nG=3D1 AF=3D1 SH=3D11 AP=3D01 NS=3D1 ATTR=3D111= T=3D0 P=3D1 */ #define PT_MEM_L3 0xf7f /* nG=3D1 AF=3D1 SH=3D11 AP=3D01 NS=3D1 ATTR=3D111= T=3D1 P=3D1 */ #define PT_DEV 0xe71 /* nG=3D1 AF=3D1 SH=3D10 AP=3D01 NS=3D1 ATTR=3D100= T=3D0 P=3D1 */ --=20 2.54.0