From nobody Sun Apr 12 22:39:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1775734804; cv=pass; d=zohomail.com; s=zohoarc; b=CLn8ZVsLr3Pzk4OH+I4Pha+Tv9F4t5ZpY1/hwKhRlTDxEqVJjEsLJPde+VJvag7jS+o5Y3k6suazDCsBvxyIX8RWruaK8lalAfEkEmmM9aF3MygqHcYggfX5L+zeFG8+ZxjhdIa7ckS7pEPxN9X2VIqdNybHToiOohbsPhokvlE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775734804; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=I41Wz6kgb/0DOUu+lYlBPOYvv2CAkwrbJsEJj/f2BGE=; b=bxmxrtHDY1h4v1X6AD6jWwWAIdnIkgSRT5BLJWehN7qvWJ4uF0eW9UNTZEM+I8LVcE1wAt5dMYEKIqSyjSYKY9weCnIWc8SHYNvdAuyCn/szn+PFd5mDkF91qjKsgDU1JnL8EoVBpocGU+eP6zN88dLaS5AUQI64sFtKral0TZ0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1775734804308472.9747792916281; Thu, 9 Apr 2026 04:40:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1277086.1562360 (Exim 4.92) (envelope-from ) id 1wAnjg-0008Ax-4h; Thu, 09 Apr 2026 11:39:48 +0000 Received: by outflank-mailman (output) from mailman id 1277086.1562360; Thu, 09 Apr 2026 11:39:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wAnjg-0008Am-20; Thu, 09 Apr 2026 11:39:48 +0000 Received: by outflank-mailman (input) for mailman id 1277086; Thu, 09 Apr 2026 11:39:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wAnjf-00084F-CU for xen-devel@lists.xenproject.org; Thu, 09 Apr 2026 11:39:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wAnje-00C2vv-Ow for xen-devel@lists.xenproject.org; Thu, 09 Apr 2026 13:39:46 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69d78ff8-2eae-0a2a0a5409dd-0a2a4506c630-8 for ; Thu, 09 Apr 2026 13:39:46 +0200 Received: from [52.101.201.2] (helo=PH7PR06CU001.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.0) (envelope-from ) id 69d79000-0df0-0a2a45060019-3465c9025642-3 for ; Thu, 09 Apr 2026 13:39:46 +0200 Received: from PH5P220CA0012.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:34a::9) by DM4PR12MB8473.namprd12.prod.outlook.com (2603:10b6:8:183::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Thu, 9 Apr 2026 11:39:40 +0000 Received: from MW1PEPF00016160.namprd21.prod.outlook.com (2603:10b6:510:34a:cafe::b7) by PH5P220CA0012.outlook.office365.com (2603:10b6:510:34a::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.40 via Frontend Transport; Thu, 9 Apr 2026 11:40:04 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by MW1PEPF00016160.mail.protection.outlook.com (10.167.249.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.0 via Frontend Transport; Thu, 9 Apr 2026 11:39:40 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 9 Apr 2026 06:39:39 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 9 Apr 2026 06:39:39 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 9 Apr 2026 06:39:38 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CG3l8jFdMDSrbe2ddx2a/K0lMymDBWFlZLyO1gU3w8ylq3OwOHmDYYtccLRjHANWUflntWqq6e1bhVs3NjrmPKMk8B1Zs0QT4Wuq2NjzgVwV4/9L3m/A/T/v5sFV4s2gPEf1e1MQN3Ldbuka0TbUbaZDqRCuWat2Ct/sS4ymr5CCVz8o06pkS5t2rJfUTa9+2hM4fv6TJYTkU7RF0lekfp6gT/w9Q+VQLJJaIdUN94tO+b1U6JsjvoAZnm7z7VrTLwPmBwI96r1tVHnErtO8/J+usA1+H/TdzIVOtAbTnggSv8EQt2PSMW2v1Ywmr0adxUraxeuWmTEQdspune1m8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I41Wz6kgb/0DOUu+lYlBPOYvv2CAkwrbJsEJj/f2BGE=; b=C/1GXh1V1mffLbofrobU5yIpvzKNXpxbHNteAwbjF8gcsQcLaLzZ58OUjDYSw1YvGtgFgTLnE7nw9YcRvgL7r0Pqr1/VvOBpEgn0mpboYLuwLGITetA5XgpGp4HLumMroWSFJWS6IGwr0ceGBAjVX1Qvl9TdiGICyTlxa4YMJqFTQ3+CzbWkJV3kD+IJLkxZydmFZgEnQj+OeXIGrILEg/6c098ZB+ijtlpeCBYAvBe2nxrCwdw6KtesVoMs/3M1I2naPLJHgNf6xXtjw6FzSt7zninJn5pLoO3ge9uDtUCv97EMsUT8ZJRBfWlBhSRGGiT7uQSbTe/qdypJIa6Vsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I41Wz6kgb/0DOUu+lYlBPOYvv2CAkwrbJsEJj/f2BGE=; b=4lCLIqE8abZaxsWbw+cxpFIPcWVXYIIYUDfWMSNX/g4XnzgvtxoasX818g4/tyQviDovS9qwEnc/aZWmxwuQxT2isFalZNAqTP9he/RLMXA1SbJU6O21hBunf/eS7ZG+V+yDxWFhFcZ5AxueIqFrQd/xGmavoqA9dUPoS7ucd0k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/3] xen/arm: Fix off-by-one in iomem_deny_access() calls Date: Thu, 9 Apr 2026 13:39:32 +0200 Message-ID: <20260409113934.197619-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260409113934.197619-1-michal.orzel@amd.com> References: <20260409113934.197619-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016160:EE_|DM4PR12MB8473:EE_ X-MS-Office365-Filtering-Correlation-Id: c3ac2837-4cd0-4f39-a074-08de962cafc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|82310400026|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: ySKnjYqy5s/N9Fd8svTAU7dt/kU8T9u4gMshi0HMmUsZ+wal2WwPeA4OCWCPOe18KkNjyX+qNGLU3zAQs+nB5bxcemX1fnucifwprzyBf/gS2wSbvxjOZHUHJDjG4u+x330qzQAyTjvIgCkj8wpmCzrKOkn8s+uV2dd96BBgJkMlLjmVJD59U2Fs7rXGQvrsTMqIthHRjQjGqZWb8o8DJ56edPDFrMwtmJYmxiiVujE4S2eulBo2ibfkfh84Alcej9xasvXw0kIA8Y8aH5sC5XAnhazvbjtK3Ulsn4v0Wxnidn7Eta9iow7LYqZdm77bJO4mbRLC1t6xsuAx8HBBbRjO68y5w9VCLPdQZlggHgQiciEcUirqBW9TVxUygQ0jWRmJWz5tFOTMtwBQEpowGpyiLbfZj6sJFMxJKkUbd2dxDZz/B65d2EkNXvKU13rM1eQiMsHYjK1JOjwIUrjDoocrvHbmdcbwPHJh6/EzlQv3W/tKoLUnOeEr58ObRy7/++HJhnTtkTEn0wirxqMJaQMm27Us/S+3YdXTgKvq3Ze+PU4+B6Gl8HXeM8a+6uFxEFFdoBy5c/hVmIEDxqj2ftnQsq+mCawTAGNndQ7RN9yjexx1dQiAGKz6Oe+vh1YHnNyM8LfD/7BizfP+VciiequQIrr6zDzKk3Rd2XoYmh51xOIupZAaXo3XGQ6G9RY7qxusvNXpygWMTMifNhwBeN4p7pI7cPojS6SZ5fUbK65AVAwqFuTos3Ccud0B8dgN32gtSn8ACMqycBmpO2Huug== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: B7fzeapXP7uNPQipQC2yF11wiOXtjpWmni6t2Rb1E3ivrfhSnck/6fgA9jTGRXLNX1yeRHpny1w9lPn748nNazFE7sZor7fksay6UGG/rnJxKwiy1QZH5dGV5+wATvVXWmA4Iwwg8cv6TaNeqUZM4x6g2sNd7/ZF3y30hyXPRTS4JJw9MRgWg94aE091DdZ0+oGW226QSyoCxtSC2Z7zA1YltUZOo9BbYvOu7SwnBwBvXSEBDov7dJ/inBqj22HoNFNXO262SYLV47KyeqWMSF3GspTy0VOTBHTfAZi01jZ3AleLGddaAcMbJsFbUPoRtsJVJ7pq/e9hpnLvfArsvRVcayxlTMCaDn+wNfk+lezV6tUYyBF4AbYWBruML+jqI+eL5Tr0947WPqu2SPIeHDC3mP5a5DkfM7ktwQ/mjUNn+m3uxRnwYoTbtuwX43bQ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2026 11:39:40.3429 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c3ac2837-4cd0-4f39-a074-08de962cafc3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MW1PEPF00016160.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8473 X-purgate-ID: tlsNG-16d1c6/1775734786-5CD243D8-BBB4CCF6/0/0 X-purgate-type: clean X-purgate-size: 4470 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1775734805888158500 Content-Type: text/plain; charset="utf-8" iomem_deny_access() wraps rangeset_remove_range() which takes inclusive endpoints. All call sites in the GIC and ACPI code pass 'mfn + nr' (or 'mfn + 1' for single-page regions) as the end parameter, which causes one extra page beyond each region to be denied. For single-page regions, use 'mfn' as the end (denying exactly one page). For all multi-page regions, use 'mfn + nr - 1'. This matches the correct pattern used elsewhere, e.g. in device.c. Fixes: 8300b3377e ("arm/gic: Add a new callback to deny Dom0 access to GIC = regions") Fixes: 66158be465 ("ARM: ITS: Deny hardware domain access to ITS") Fixes: 97e9875646 ("arm/acpi: Permit MMIO access of Xen unused devices for = Dom0") Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- xen/arch/arm/acpi/domain_build.c | 2 +- xen/arch/arm/gic-v2.c | 8 ++++---- xen/arch/arm/gic-v3-its.c | 2 +- xen/arch/arm/gic-v3.c | 8 ++++---- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_bu= ild.c index 5a117001ef11..249d899c3337 100644 --- a/xen/arch/arm/acpi/domain_build.c +++ b/xen/arch/arm/acpi/domain_build.c @@ -48,7 +48,7 @@ static int __init acpi_iomem_deny_access(struct domain *d) { mfn =3D spcr->serial_port.address >> PAGE_SHIFT; /* Deny MMIO access for UART */ - rc =3D iomem_deny_access(d, mfn, mfn + 1); + rc =3D iomem_deny_access(d, mfn, mfn); if ( rc ) return rc; } diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index b23e72a3d05d..014f9559673b 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -1079,23 +1079,23 @@ static int gicv2_iomem_deny_access(struct domain *d) unsigned long mfn, nr; =20 mfn =3D dbase >> PAGE_SHIFT; - rc =3D iomem_deny_access(d, mfn, mfn + 1); + rc =3D iomem_deny_access(d, mfn, mfn); if ( rc ) return rc; =20 mfn =3D hbase >> PAGE_SHIFT; - rc =3D iomem_deny_access(d, mfn, mfn + 1); + rc =3D iomem_deny_access(d, mfn, mfn); if ( rc ) return rc; =20 mfn =3D cbase >> PAGE_SHIFT; nr =3D DIV_ROUND_UP(csize, PAGE_SIZE); - rc =3D iomem_deny_access(d, mfn, mfn + nr); + rc =3D iomem_deny_access(d, mfn, mfn + nr - 1); if ( rc ) return rc; =20 mfn =3D vbase >> PAGE_SHIFT; - return iomem_deny_access(d, mfn, mfn + nr); + return iomem_deny_access(d, mfn, mfn + nr - 1); } =20 #ifdef CONFIG_ACPI diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c index 9ba068c46fcb..e38aa8711744 100644 --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -1009,7 +1009,7 @@ int gicv3_its_deny_access(struct domain *d) { mfn =3D paddr_to_pfn(its_data->addr); nr =3D PFN_UP(its_data->size); - rc =3D iomem_deny_access(d, mfn, mfn + nr); + rc =3D iomem_deny_access(d, mfn, mfn + nr - 1); if ( rc ) { printk("iomem_deny_access failed for %lx:%lx \r\n", mfn, nr); diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index bc07f97c16ab..b3e104ea4ad0 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1602,7 +1602,7 @@ static int gicv3_iomem_deny_access(struct domain *d) =20 mfn =3D dbase >> PAGE_SHIFT; nr =3D PFN_UP(SZ_64K); - rc =3D iomem_deny_access(d, mfn, mfn + nr); + rc =3D iomem_deny_access(d, mfn, mfn + nr - 1); if ( rc ) return rc; =20 @@ -1614,7 +1614,7 @@ static int gicv3_iomem_deny_access(struct domain *d) { mfn =3D gicv3.rdist_regions[i].base >> PAGE_SHIFT; nr =3D PFN_UP(gicv3.rdist_regions[i].size); - rc =3D iomem_deny_access(d, mfn, mfn + nr); + rc =3D iomem_deny_access(d, mfn, mfn + nr - 1); if ( rc ) return rc; } @@ -1623,7 +1623,7 @@ static int gicv3_iomem_deny_access(struct domain *d) { mfn =3D cbase >> PAGE_SHIFT; nr =3D PFN_UP(csize); - rc =3D iomem_deny_access(d, mfn, mfn + nr); + rc =3D iomem_deny_access(d, mfn, mfn + nr - 1); if ( rc ) return rc; } @@ -1632,7 +1632,7 @@ static int gicv3_iomem_deny_access(struct domain *d) { mfn =3D vbase >> PAGE_SHIFT; nr =3D PFN_UP(csize); - return iomem_deny_access(d, mfn, mfn + nr); + return iomem_deny_access(d, mfn, mfn + nr - 1); } =20 return 0; --=20 2.43.0 From nobody Sun Apr 12 22:39:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1775734809; cv=pass; d=zohomail.com; s=zohoarc; b=LyWHAaXeF7pBxDzymdZmUkxoQNsAPvK7zXjwyzZljM08t6Z9Sj0pAVIWmvFrEMHZ1wYA+avU8CjyOryA1ReslUskzf/KUPjB+QVPNNol7dmghwR9hR7JKpcV+FkmcachL+cNC24v915fTrQJDPKSf+JhTT6v17rumNsES/bJ2Uw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775734809; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XAopumW9tXcTDkz+Pn6jm6L9ZBc2XUfcfTkK3WsQW18=; b=Gr86pAFacEgnliAL4KF9FNEp7PqXZcO5LMR7F0BJnryRMcjQpvbFuO9MF5W22SPkezYnIbPw8Ytah0o5HmtcE2Cbs8A8kDCB864vUH2c5t/s6VqlApOHg/CTa3gO800LWNGlyiBGqXLeAR/ZmacCb86Gm9UIQX7mc/yaXp6Uwbw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1775734809730454.6199839920191; Thu, 9 Apr 2026 04:40:09 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1277087.1562370 (Exim 4.92) (envelope-from ) id 1wAnjh-0008P8-E3; Thu, 09 Apr 2026 11:39:49 +0000 Received: by outflank-mailman (output) from mailman id 1277087.1562370; Thu, 09 Apr 2026 11:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wAnjh-0008Oz-9R; Thu, 09 Apr 2026 11:39:49 +0000 Received: by outflank-mailman (input) for mailman id 1277087; Thu, 09 Apr 2026 11:39:48 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wAnjg-0008Aj-08 for xen-devel@lists.xenproject.org; Thu, 09 Apr 2026 11:39:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wAnjf-00C2vv-CO for xen-devel@lists.xenproject.org; Thu, 09 Apr 2026 13:39:47 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69d79003-2eae-0a2a0a5409dd-0a2a450288cc-0 for ; Thu, 09 Apr 2026 13:39:47 +0200 Received: from [52.101.193.6] (helo=CH1PR05CU001.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.0) (envelope-from ) id 69d79001-42fa-0a2a45020019-3465c1062599-3 for ; Thu, 09 Apr 2026 13:39:46 +0200 Received: from SJ0PR03CA0228.namprd03.prod.outlook.com (2603:10b6:a03:39f::23) by DM4PR12MB5772.namprd12.prod.outlook.com (2603:10b6:8:63::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Thu, 9 Apr 2026 11:39:42 +0000 Received: from SJ5PEPF00000205.namprd05.prod.outlook.com (2603:10b6:a03:39f:cafe::8a) by SJ0PR03CA0228.outlook.office365.com (2603:10b6:a03:39f::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.40 via Frontend Transport; Thu, 9 Apr 2026 11:39:42 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by SJ5PEPF00000205.mail.protection.outlook.com (10.167.244.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17 via Frontend Transport; Thu, 9 Apr 2026 11:39:42 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 9 Apr 2026 06:39:41 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 9 Apr 2026 06:39:41 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 9 Apr 2026 06:39:39 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rO8Zp3Yx6LD7KLoE0hVzsL4ZuqKwN8wn7o+etaU3zFlqsk45Y0XiNouG0SytFqqmmHp01/u46HgnabwcU+sxoxKrDTS3a/LmuQQCfFSP/1m5eyFTrUwWuIS07ZBzegtG/BMEyR7sYSBjmQVULSDevj/w0JX16u6TAtOPW6+K4Arg0H7/GDRa/DygxhaAuJEcybx8xu0ymBlB2yGyZYGy8HGLUd9hgrHISwdtoXII643KFndn98E84J/Ga5DT2rMZCqnHsalivlFUs0QjNGh6/FQARghqLYirx5INEb08eYNSDFXEqaKRApc/UBeZsndqqrS/OXtADJuL/X2PtsPnrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XAopumW9tXcTDkz+Pn6jm6L9ZBc2XUfcfTkK3WsQW18=; b=WWtBAXE1fHUSnTo7viFA0kSHiaU4HKL4g7EiYEuAfsDKm0AeAxwk+Qo4B7YZnZNT/0GL6QBsMCk6AUyak8NbV3kEQh4T3ssd/X8KmDtR0vZl6ql8MgVgpYGT/+50sm7mfA4shp3vJbJzEE6iNeli8uasl+2JpxB7u85+AJigtTzhnnP0/FD02p7+gMYsAZpWlcEZAzWtma5eSWpzNugEDqbllZRlXd/M828ON3muRQp2t/uxGPZGxz/VWUAGO53EJTHK7pFSVh+elrTqdjoRO7jRJxf4oij5PB2xEWvDIPEz+8nRxZsX/1ZI8aKCNcGbFaILBsNF30DD3xLv+8qMxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XAopumW9tXcTDkz+Pn6jm6L9ZBc2XUfcfTkK3WsQW18=; b=3xZSEggRpmPx5oewCDuTTNlnGZY0BAh4oW7IoV1BqIPKL5pQOM0VnVx5C5Oc+CkChCWqziW57jLBbZunug8wBPwFCQBBgvcxNbxsnk01dt6mNlIDwQ04SmCwm+I0F54wvTgDcywYu2CUqyVAJ/YFtEnm05tzOj663+cwlvzj/GI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Andrew Cooper , Anthony PERARD , "Jan Beulich" , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , "Stefano Stabellini" Subject: [PATCH 2/3] xen/common: llc-coloring: Fix off-by-one in parse_color_config() Date: Thu, 9 Apr 2026 13:39:33 +0200 Message-ID: <20260409113934.197619-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260409113934.197619-1-michal.orzel@amd.com> References: <20260409113934.197619-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000205:EE_|DM4PR12MB5772:EE_ X-MS-Office365-Filtering-Correlation-Id: 42b22715-b2c0-485f-dfa5-08de962cb0d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700016|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: apyWwzUUUiRAXj8a8GZoQf584U4AYZEOZ2D6vpAOgQ9e/as075hipKPqTYIIsl/R9lnFNwQnMOOSapkeqMdAl/xnJtL9MdrX+AZXkNVmmEtJCSCzhZdHo56unBOyh5vK886PDnKgwUVG46Kp0JbAbC1y27Atizsv5H29X4dxvQkuPZn/nl/b3J/VwPGkzgcZBW8YzLOWokuFKUe9dCmD3ieW9ivefbKrxieRzMvZYFhWeOGVqQbupGT3M7Lj+gpo0Lrr4NF/Lj9uz2rXYpJjC0fyUardpC/dqx2e7Qg07odlYM691aihjV+IwC+rqNkWJbUO89CltEFU+c5S9zg+TTyB/eMMyMysezNrWlR0pHXahIhS5csidCmpNBkX3cLwbchWWxrB9ZXJmi4bldc+BJLK4yHa7NkQ1TrQNlCkmf1XQZUk/PbJDl0V/Pl4FJ+7dTX3DrfRDBj/aGxusE6c++87zzxKC2sbAFFp35+OwJA3PbOE3JttmIUdH68EuGgnEiouOV9HduL5xRvtw/7VlVyK+3a24C7D+64C/hZZciSKVfoy5RwBwh0o2030jdwoxda2lqZ17Y8kboWgQO+y2rEyvN2wcGou9aN8Ejy3KkDuW3fdsasYulCgvoiG4me1JuMIWtMQC4mlhzHRD4Omrxm4qs/bTOoZNlxWKIDHUwRozgog/pb0k3IaomIEojQbqLpfEf7Ftn4nmjR1KYsVn2z7ZjsVBpcxfkbLH6CVc+Uen/ovhU6+I+43GjhBgKVi5QL6pjVCnURdFJv8bgGSJg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700016)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: u9lstO0b1NBY+1MmFW473LJuwpjMo0vSq1yrEFiBPn84DfjWx65IBLMdoE/98PiggCN390jEIMPbcXxnXYn07zrmg7FHl+InqxfZ8wCiPSFeE/m2Z3Ml5bQOb3+dh7a9ccUGh/lNrFApo9DbqBe0u+6kakLuSznXvVVwNHkGxfJdP/Ojqd3ceFuOe0lkmF8NzKyZf41PaNDwfvrEOo9Aky7taygi3I/cRfDS0EwiDRrtE7Ymy4ihv1sfakVDoEvNz0HEvKf/GFVfR7YymLITv8ONA+DnC58FzX54GNI2VD58cNfNFb9RN7MzhBYUMWFaTHTq4n5YtLrEhS4M2+DwegrB5pK2fFi0N6t9GMbrpQ5ggkQySR2QBt/NvvqIsJ+5p8aNAPMtoxR62EImY9I1wjy6zBtQ3Mn0SXJiMtRQ5tsm/LQPHs9/nWyuWF3v/zcg X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2026 11:39:42.1428 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42b22715-b2c0-485f-dfa5-08de962cb0d6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000205.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5772 X-purgate-ID: tlsNG-720697/1775734787-46B27CD1-FDD1E078/0/0 X-purgate-type: clean X-purgate-size: 1193 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1775734811787158500 Content-Type: text/plain; charset="utf-8" The check uses >=3D to compare the total number of colors against max_num_colors (which is ARRAY_SIZE of the colors array). This incorrectly rejects input that would exactly fill the array. For example, with NR_LLC_COLORS=3D16, specifying 1 color for Xen and 15 for dom0 would fail. Change >=3D to > so that exactly filling the array is permitted. Fixes: 95ef5ddf8a ("xen/arm: add Dom0 cache coloring support") Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu --- xen/common/llc-coloring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/llc-coloring.c b/xen/common/llc-coloring.c index eb7c72b24023..30c1594dac9f 100644 --- a/xen/common/llc-coloring.c +++ b/xen/common/llc-coloring.c @@ -78,7 +78,7 @@ static int __init parse_color_config(const char *buf, uns= igned int colors[], =20 if ( end >=3D NR_LLC_COLORS || start > end || (end - start) >=3D (UINT_MAX - *num_colors) || - (*num_colors + (end - start + 1)) >=3D max_num_colors ) + (*num_colors + (end - start + 1)) > max_num_colors ) return -EINVAL; =20 /* Colors are range checked in check_colors() */ --=20 2.43.0 From nobody Sun Apr 12 22:39:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1775734809; cv=pass; d=zohomail.com; s=zohoarc; b=Vj23uOItEhqfIeWWYNHRACkqrKLfvfhCXdVulj7q6Ylff9QJbbXQQOWVggIU+BMHVXpPSIa4XKMB+XfKfeyPlFWcrlQ4Q4XKwUqWVUrAvagxhiTrf39U93UvNriPtNj6Iele0SukXeXTf0tWoRnqWxrp4mSXIn40JVWryzIrZHU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775734809; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3sbiLpiolSgNF7o8RKtIPkDTBElPtkFOamtiYxQtoEA=; b=ZOM3KVSYNAF0NxA9LgPe9rppjmJlyOggw6yCEvmO/KC3bTMZdeYPx56L44L+HDVq8yE/BgR6ha5ePx1QusOGks8s8eRRuFGkqyE6rExkPov6dgOwWdNOLnEYA8S6b6pVdBtvjK7wmFp+a3r8FzI2VynFF8/E4mTPGvhFIKZ4lxE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1775734809029711.5589475582989; Thu, 9 Apr 2026 04:40:09 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1277091.1562378 (Exim 4.92) (envelope-from ) id 1wAnjn-0000It-Lo; Thu, 09 Apr 2026 11:39:55 +0000 Received: by outflank-mailman (output) from mailman id 1277091.1562378; Thu, 09 Apr 2026 11:39:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wAnjn-0000Im-I7; Thu, 09 Apr 2026 11:39:55 +0000 Received: by outflank-mailman (input) for mailman id 1277091; Thu, 09 Apr 2026 11:39:53 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wAnjl-0000Ft-KV for xen-devel@lists.xenproject.org; Thu, 09 Apr 2026 11:39:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wAnjj-0091Qm-El for xen-devel@lists.xenproject.org; Thu, 09 Apr 2026 13:39:53 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69d78ff4-e002-0a2a0a5209dd-0a2a450a96b4-44 for ; Thu, 09 Apr 2026 13:39:52 +0200 Received: from [52.101.61.26] (helo=DM1PR04CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.0) (envelope-from ) id 69d79007-ee98-0a2a450a0019-34653d1a837b-4 for ; Thu, 09 Apr 2026 13:39:52 +0200 Received: from PH5P220CA0006.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:34a::7) by SJ2PR12MB8882.namprd12.prod.outlook.com (2603:10b6:a03:537::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.42; Thu, 9 Apr 2026 11:39:44 +0000 Received: from MW1PEPF00016160.namprd21.prod.outlook.com (2603:10b6:510:34a:cafe::aa) by PH5P220CA0006.outlook.office365.com (2603:10b6:510:34a::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.40 via Frontend Transport; Thu, 9 Apr 2026 11:40:07 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by MW1PEPF00016160.mail.protection.outlook.com (10.167.249.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.0 via Frontend Transport; Thu, 9 Apr 2026 11:39:44 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Thu, 9 Apr 2026 06:39:43 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 9 Apr 2026 06:39:42 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 9 Apr 2026 06:39:41 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WZ1LeZMOk93Y3rQa4B4LhPloBl7Dcs4+DHsiVuSiin8RmYghBal60/DpwJb3ISHpDn4rT4g8AIVDLKRLNV56zz5tXmWZDhuKN3Lf5iAA4SNoExvni3LAI1Yrncw8XIdUXbXxLRREnLcSEdqu2WPTqokQtVmW9t1k2mXPZm1u4UJpZ/4aPzy/SXSXqtkyJeuYqG5R6tccvPEJY8bMu0qPchRVib19mWmeMyBqCu6YMfwyROAfv1AUiHetANV/C1GlJU+lYcG+p28owcu8bqPHYLjQrEVzkeLSwsfGNrQgWCM/pY5BKzQUjIpUI9CTVS3LA47wAlCYiXrtWQfrN1oFAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3sbiLpiolSgNF7o8RKtIPkDTBElPtkFOamtiYxQtoEA=; b=xi6kFBIViEf9/JAYl/cWJisyvBvgCT4/3pJYSjJsJxAVsy26Hdj/hx9CPFDU53dC9N7LONtkrhaMHTNLONtRA1AXK1Z2gCMKSLSyLkdwoW80gXVLs4JSKe1kzyl1SOjGFubN1cTuh0BEbNtYJnJIpoYpPcJjfgPyLWzXbRjjP3UFASVndqClez8olt02+9QTFHOfKFfmd5dsCLlND2QukJ6z5xNZGMTRsEjMVVlab5QwpygGTLFlFIqj3kmfq+bzajPO23tXb16pmkrV3zmWOtAOdTQvrhXHQOQSnVP+jSXNptR4Bebo3N3Z4iSS3gLS53SRZErdNz+4XM5qBbrUjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3sbiLpiolSgNF7o8RKtIPkDTBElPtkFOamtiYxQtoEA=; b=KZ3BHmBREJD/AzdyFs+ik3oq+nDYQDvCpMCTmJRIOgaMoZHryCteSt8cWJVUPyET61ZsRH956dgKDY54lrwTnN+pFKZXtP5/HqToXY0a1AGyOtNHtyMCa9XZVZRxnNEG4cPF/etXqvZrvsysHs8ClwZaK5hLifK9wBuHGWQqIKo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 3/3] xen/arm: gic-v3: Use vsize instead of csize for virtual CPU interface Date: Thu, 9 Apr 2026 13:39:34 +0200 Message-ID: <20260409113934.197619-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260409113934.197619-1-michal.orzel@amd.com> References: <20260409113934.197619-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB04.amd.com: michal.orzel@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016160:EE_|SJ2PR12MB8882:EE_ X-MS-Office365-Filtering-Correlation-Id: ad4b818d-e5c2-4db3-f187-08de962cb212 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: avtAXAK4ccOJ+7RfRIIZEgixOY20gUovA/CgrbzsRsQu6gDJfupLfSw+eH5xIBdFW25e9yFZyiJ8bPfNdasVd6ZzNZiRNYPPQwXzTSdajXcdSO70Gp/z5aWF8HMUuUjw4B6HV/LnOjASva3zoJg/M5fOG2uSZv2KKU5cNhtxcl/Z/PcKYNQVEWFST5ayCG/i+M/7Y1tPwGDJBxAdwgpYk0qn+B0wQaS/5XkZC3tOgzVMKikp2Dp67Uc3RHWJm8Lb5tKM8MQJWc5gfrPQznd1W20ypuRwkAe8ZFxr++WdaG9NINdLyhx4kbRjQCB582uPWypsD1gX+R325fiJZWBssTfnPkLa62PklcQExtCceTgNUIodXqc/SWFDmcaVPbbDxj6YrA16t+knaBuw37qZnX/7+zyu9/6rYtBzxvbMxTYhtu0Qkc0s8uFKV9y4s7VvK05bTI0fe9T2ON4DPfts+6I59LT18bGzhpB7upLDNzrHFRd/w8AzHbcf9uDy994MDM3WXXFfXhnJV8rKPniNvB4d4f34QzB6S+YRneLpmzo9Ye00O2uMRrKstwe8SEr4mPDNda48V8ngLxUY1oxLV4+FUtkmddK/o/4kPfXlJZ0c6YQ9vmFtWiwIDXH87p00KARaFuUKZNePrzMv1yhgQ0ixDt6oGwEXeBrf1olg0MUDZdLGF8bP8hY44qpgFVXZhqYu2KkbcbE9mwkH6hkcVB/QpuRK6EKXYY9DeZXW0BZWygxLMB8SWwY6F/oHC/8VBMlXqOw4jUaPO4PY/XZFVw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JEkyIN2Ik+czf9icSAkIKZ+lWHg6fbBYt1t2Ftf+ZfHbl2HKuGDcLmQJCRBDWppSx+ekhp7pf4JkXzQmNh2kcZD1g09LzKkUj+lIXsGTGfhf9JiyOO6cfE7Hhs4VJF8QUilBvloqPorWiVQ9l9vsryObfSqY33IKphFdDOTp2hwPEASmrmqZ0v+RPEhzIYwIUp5CGzuaWBZU2XwgSiTPn1MTSN+SMl3b4W1TFW+jsgf3MG/A6l/qk7T+69IO8ccCTJ2w5x3wp0XP5kW6rh/NDxV/IB683CNL34ECCoVEfnUvHKQhECbQ0oZEWC/56xVQEiyfQGvHHZ8mUqTUymVd9Vzp4nJvJwiFF/eqriftMoiPUi/fjo93W8/UU/7jSx8vl06qqupnbln6gDXSRObG006pDIj8rCA6vy9XaRmCQPLaoIHYwkJsV6XH4xKNpG4B X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2026 11:39:44.2175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad4b818d-e5c2-4db3-f187-08de962cb212 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MW1PEPF00016160.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8882 X-purgate-ID: tlsNG-4011c0/1775734792-C50180B1-4F21F8EC/0/0 X-purgate-type: clean X-purgate-size: 907 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1775734809771158500 Content-Type: text/plain; charset="utf-8" gicv3_iomem_deny_access() incorrectly uses csize (physical CPU interface size) instead of vsize (virtual CPU interface size) when calculating the number of pages to deny for the virtual CPU interface region at vbase. Fixes: 8300b3377e ("arm/gic: Add a new callback to deny Dom0 access to GIC = regions") Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini Reviewed-by: Ayan Kumar Halder Reviewed-by: Luca Fancellu --- xen/arch/arm/gic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index b3e104ea4ad0..5641ee870f23 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1631,7 +1631,7 @@ static int gicv3_iomem_deny_access(struct domain *d) if ( vbase !=3D INVALID_PADDR ) { mfn =3D vbase >> PAGE_SHIFT; - nr =3D PFN_UP(csize); + nr =3D PFN_UP(vsize); return iomem_deny_access(d, mfn, mfn + nr - 1); } =20 --=20 2.43.0