From nobody Thu Apr 2 01:29:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1774888330; cv=none; d=zohomail.com; s=zohoarc; b=N2VMeg4Brmer6CFHaE6/cKATXAS+sA66mjGko/UAb1elGGDVqzZNoGPQ4F4UlGR2Gnj2e6hMBrhPLKeNsZRKIHKz9DL8x1+nmXRqJSjfWOxf6paRLYiUVTq4o2DePKK4IZSjKIwTiYMlQy3pVFJABMMTMl16lFWUT+9hErRFzf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774888330; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cCmmnfsjsR1FfBOfPVTo9rY5b6iLiQ5Z5igoSN4IYdM=; b=Io1FbtDJphsTFD0Bn+ynAGQYzChrQsdVjCsyCDuj+p+qDHewbYwJ775UJX+0xv2PlbEXsNMbN96qdP0xQsatL+b6ZxZiZ3lpFleo4+p4FJ8PiiSRMD///aVzq2AQHMSdE1sW5IgC0kgyvi29IcNqL4A36gJjl3vlQTBBwpkUCno= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1774888330692946.398004002212; Mon, 30 Mar 2026 09:32:10 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1268038.1557389 (Exim 4.92) (envelope-from ) id 1w7FWw-000728-G6; Mon, 30 Mar 2026 16:31:58 +0000 Received: by outflank-mailman (output) from mailman id 1268038.1557389; Mon, 30 Mar 2026 16:31:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w7FWw-000721-D7; Mon, 30 Mar 2026 16:31:58 +0000 Received: by outflank-mailman (input) for mailman id 1268038; Mon, 30 Mar 2026 16:31:57 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w7FWv-00071t-EM for xen-devel@lists.xenproject.org; Mon, 30 Mar 2026 16:31:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1w7FWu-004nCd-QW for xen-devel@lists.xenproject.org; Mon, 30 Mar 2026 18:31:56 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69caa56f-bab6-0a2a0a5309dd-0a2a450388b4-28 for ; Mon, 30 Mar 2026 18:31:56 +0200 Received: from [195.135.223.130] (helo=smtp-out1.suse.de) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.55.2) (envelope-from ) id 69caa57c-1947-0a2a45030019-c387df82a4f2-3 for ; Mon, 30 Mar 2026 18:31:56 +0200 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4DB994D522; Mon, 30 Mar 2026 16:31:56 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 211514A0A2; Mon, 30 Mar 2026 16:31:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QcD9Bnylymm0WwAAD6G6ig (envelope-from ); Mon, 30 Mar 2026 16:31:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1774888316; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=cCmmnfsjsR1FfBOfPVTo9rY5b6iLiQ5Z5igoSN4IYdM=; b=a0ukubFl7Z3WCJVnh5jv+V2cuLge4x6EkE6WIHA9vjM8fBKItg6FEm4BGCkpA10/fK8K0C vYBaBUz66kk8PAe5TMCP78N1iBVy48GZAnsSctZ2dI+Guv5SAkyzM9MvCH7NjsvN9ElqUp EuW8uxwlR70WF+0AznRjPRhlajZ4jD8= Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1774888316; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=cCmmnfsjsR1FfBOfPVTo9rY5b6iLiQ5Z5igoSN4IYdM=; b=a0ukubFl7Z3WCJVnh5jv+V2cuLge4x6EkE6WIHA9vjM8fBKItg6FEm4BGCkpA10/fK8K0C vYBaBUz66kk8PAe5TMCP78N1iBVy48GZAnsSctZ2dI+Guv5SAkyzM9MvCH7NjsvN9ElqUp EuW8uxwlR70WF+0AznRjPRhlajZ4jD8= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH] tools/xenstored: remove unneeded check in create_node() Date: Mon, 30 Mar 2026 18:31:53 +0200 Message-ID: <20260330163153.676464-1-jgross@suse.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:mid,suse.com:email]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO X-purgate-ID: tlsNG-33051d/1774888316-EB48872C-F3D4C910/0/0 X-purgate-type: clean X-purgate-size: 727 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1774888331780158500 Content-Type: text/plain; charset="utf-8" create_node() is called only for issued xenstore commands. This means that the "conn" parameter is never NULL. Remove checking whether "conn" is not NULL. Signed-off-by: Juergen Gross --- tools/xenstored/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c index 4786a2a82e..34cb266e8a 100644 --- a/tools/xenstored/core.c +++ b/tools/xenstored/core.c @@ -1524,7 +1524,7 @@ static struct node *create_node(struct connection *co= nn, const void *ctx, if (!node) return NULL; =20 - if (conn && conn->transaction) + if (conn->transaction) ta_node_created(conn->transaction); =20 node->data =3D data; --=20 2.53.0