From nobody Sun Apr 5 13:44:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1774346977; cv=none; d=zohomail.com; s=zohoarc; b=LU9z5fP2BYaOvRTHSweLcYuum8IdO5KsxADZAYhhT9l3V7wg+dpivAoZ8nMTLRfjIfBvX05AvyCEfXbuPau2jVJhFegXgc+uZMZcwDXCdCAgBoX3GKz3LQ7HZp8mwq22478r3gD1qRrd0BL+Mv0tPImVmIVeRKMURaeAqRMMoAc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774346977; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S7lJOGAyXgWXm5RAImeMolbrvF/QPjaKzs3OuvcIdvo=; b=erSOt9pVszNKx2weJ/kfHIHlw7aWHsnG9Rtaip9Up6iaKKznhZ/9G/VPCixfuZF7oBmlyd4GKMcHxSg/UiYquuS9Z8QEiMfuqqZZpYfoMLxCNwY7x6INpfAl6zAwnJmg7iKni0+d2DHAc1stgdU13QFhQ3x6Th5tbPFwhzVUn+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1774346977892413.34725478558016; Tue, 24 Mar 2026 03:09:37 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1260231.1553602 (Exim 4.92) (envelope-from ) id 1w4yhL-0001rk-LN; Tue, 24 Mar 2026 10:09:19 +0000 Received: by outflank-mailman (output) from mailman id 1260231.1553602; Tue, 24 Mar 2026 10:09:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w4yhL-0001rV-HT; Tue, 24 Mar 2026 10:09:19 +0000 Received: by outflank-mailman (input) for mailman id 1260231; Tue, 24 Mar 2026 10:09:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w4yhK-0001Nh-7r for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 10:09:18 +0000 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 835e60d7-2769-11f1-9ccf-f158ae23cfc8; Tue, 24 Mar 2026 11:09:16 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-82c4b5dfe6cso948241b3a.2 for ; Tue, 24 Mar 2026 03:09:16 -0700 (PDT) Received: from fedora ([103.2.232.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c74665ca206sm11377434a12.18.2026.03.24.03.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 03:09:13 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 835e60d7-2769-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774346954; x=1774951754; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S7lJOGAyXgWXm5RAImeMolbrvF/QPjaKzs3OuvcIdvo=; b=YxPwxc2SlyXElmo7X+3rbbmq6Fu192D7n9jpOa/CKoJ99PbxKGW6xRGzHYBIkY4mKi UdNVLkHXgvbRGoN0kAAUp179XYDxMDGxSZylGLmE0sQ4NV24WJdoRLghpUfMTyKbGoQJ TreSwjGP1P09OjE/Mze1R9pWeIlPi+6ojeuItg+zLJpzTGRZrqFOO5RCQnMYtUNOlYTS YfGGIhsh09dwyJExrXaDeG9gRuIPNivqlEuw71xj2/pOExJ4UTCvO20/AzlQaQ5VzZOu jb0r9sM1cOgLaVDQofyQr7UymDRXxI4INhi8D/B5y4tsVgwa3kQ75UTWLzLFf2slR1el h9yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774346954; x=1774951754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S7lJOGAyXgWXm5RAImeMolbrvF/QPjaKzs3OuvcIdvo=; b=k7NUA7GFf1V5HfRli0bqEeoPOqm89+Txi5Xhh7rRJ6TK9V4qsHJMNgag8QXtjaHqgd A7Y4ev/P4skjKQzy6UCYo1djJZ1bMTMzJQhuP0oGbVjHiYw77nvNBScfevj0WB3f7Alu EjCLoHRRqRUCtFGnX4+1XDmQrv6uxIxwgPifttK3KrkOZaCmOOg4Gt1/gPO94F3qJ6Dp udSsxbAwMzEqAXsTIk+ig6mYSKPNHpGzMfD6GMkwtgSbaKFiaN4UY01kxXvGt+d5mucu fIQWk/6HUj4+avl/9kmNwgrNQ3jHjnR2XuW/AwUYXvrWLy2uwnZAT/ZGFdufhap/Xhdr 6HeQ== X-Gm-Message-State: AOJu0YwKmUKIfYXw6mMeLV+Ns2Dk1hRnZdbzuSkcDWBq0MYIauQXdyTT KxsHzd/OfCKFD/zQdXydA8UCUzD70ZPMTXyIDWGos85+Jj/U80e6ZzwhcnW7qGFv X-Gm-Gg: ATEYQzy1XVYnw11RFNBwPZ5bP/eLiwdZPdLkd3tHwkEDugbjcKJPDxUCB2gI8VEBgkx Jcqz4kIbvnP2LLQZ/TjDoztpuswzPlKv2nFUjUx45Civ8V2Q9KWVTCCXskbhKUQngUHsP5Y8931 NwVb1ERA3ppSzZsvqhFRwao8lBzOuX1+29v+d9UCcuCH2GwU/qKgp/+8mqsZhQT0jyXy8nQyYXb JWLdVe/shIJWxhbO7s7/F2Rn0t1BU6OA6EI4RmbgeBZoR8OSb7auaZjEQfjDcPlapTU4h8Acg4O rdARZMZos8DYtWyJ9XfcWUhdcsReOR15MFeBrsYksenMcnj4HvYzlkB9PO+4sCSwa8H4Hj+m4Of WOq1bpTU6iL0xnNBpv2TotLtjxgaleKnq0w1WlNMAj5iIvW+o4O8Bes7eQuE4bAkiDYObdbAB1D J2+uTFYsmCnInfDt1GcxngKGOwIm2Bn3j6xLRUebVEfPmwkfOub2zt6UMpA/nqW05qv9/pieQEs 5f3irhZOBehlMbvabhvWHeQYX0oFG4IOFJM1erlnVz0Z/Pk8ashgNmqRDpvRTzico0HWtvNjw== X-Received: by 2002:a05:6a20:9189:b0:398:c170:1c7 with SMTP id adf61e73a8af0-39bcea27c41mr14127397637.26.1774346954322; Tue, 24 Mar 2026 03:09:14 -0700 (PDT) From: Soumyajyotii Ssarkar To: xen-devel@lists.xenproject.org, sarkarsoumyajyoti23@gmail.com Cc: "Daniel P . Smith" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Andrew Cooper , Jan Beulich , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Soumyajyotii Ssarkar Subject: [PATCH v4 2/3] x86/acpi: Integrate BGRT preservation with status reporting Date: Tue, 24 Mar 2026 15:38:55 +0530 Message-ID: <20260324100856.6691-3-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324100856.6691-1-soumyajyotisarkar23@gmail.com> References: <20260324100856.6691-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1774346979962158500 Content-Type: text/plain; charset="utf-8" Add status reporting for BGRT preservation and integrate with Xen's ACPI subsystem: - efi_bgrt_status_info() prints preservation status (success/failure) - Called from acpi_boot_init() after ACPI tables are processed - Clarifying comment explains why invalidation code remains The invalidation code in acpi_invalidate_bgrt() now acts as a safety net: if preservation fails, the image remains in conventional RAM and gets invalidated. If preservation succeeds, the image is in EfiACPIReclaimMemory which won't match the RAM_TYPE_CONVENTIONAL check, leaving the table valid. Signed-off-by: Soumyajyotii Ssarkar --- xen/arch/x86/acpi/boot.c | 8 ++++++++ xen/common/efi/boot.c | 16 ++++++++++++++++ xen/include/xen/efi.h | 1 + 3 files changed, 25 insertions(+) diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c index 1ca2360e00..20afe79db9 100644 --- a/xen/arch/x86/acpi/boot.c +++ b/xen/arch/x86/acpi/boot.c @@ -29,6 +29,7 @@ #include #include #include +#include #include #include #include @@ -327,6 +328,11 @@ static int __init cf_check acpi_parse_hpet(struct acpi= _table_header *table) return 0; } +/* + * Invalidate BGRT if image is in conventional RAM (preservation failed). + * If preservation succeeded, image is in EfiACPIReclaimMemory, which + * won't match RAM_TYPE_CONVENTIONAL check, so table remains valid. + */ static int __init cf_check acpi_invalidate_bgrt(struct acpi_table_header *= table) { struct acpi_table_bgrt *bgrt_tbl =3D @@ -754,5 +760,7 @@ int __init acpi_boot_init(void) acpi_table_parse(ACPI_SIG_BGRT, acpi_invalidate_bgrt); + efi_bgrt_status_info(); + return 0; } diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 47d5b9b2a8..e22a42c15b 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -1911,6 +1911,22 @@ static bool __init cf_check rt_range_valid(unsigned = long smfn, unsigned long emf return true; } +void __init efi_bgrt_status_info(void) +{ + if ( !efi_enabled(EFI_BOOT) ) + return; + + if ( bgrt_info.preserved ) + { + printk(XENLOG_INFO "EFI: BGRT image preserved: %lu KB\n", + bgrt_info.size / 1024); + printk(XENLOG_INFO "EFI: BGRT relocated from %p to %p\n", + bgrt_info.old_addr, bgrt_info.new_addr); + } + else if ( bgrt_info.failure_reason[0] ) + printk(XENLOG_WARNING "EFI: BGRT preservation failed: %s\n", + bgrt_info.failure_reason); +} void __init efi_init_memory(void) { diff --git a/xen/include/xen/efi.h b/xen/include/xen/efi.h index 723cb80852..e72ab3c6b5 100644 --- a/xen/include/xen/efi.h +++ b/xen/include/xen/efi.h @@ -39,6 +39,7 @@ static inline bool efi_enabled(unsigned int feature) extern bool efi_secure_boot; void efi_init_memory(void); +void efi_bgrt_status_info(void); bool efi_boot_mem_unused(unsigned long *start, unsigned long *end); bool efi_rs_using_pgtables(void); unsigned long efi_get_time(void); -- 2.53.0