From nobody Mon Mar 23 21:25:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1774019508; cv=none; d=zohomail.com; s=zohoarc; b=EmwX5rrSBerKhYDZYO9m50xOvqwm+AyYSNrUQJr68MO5VX7krpWr4sIaDmlDyMmhbj3khIZywh6SmGu6zKu6/0HhJmDFLvYbcVcDZaD2g/9Q1wPe/bKyiQZYw7ak6MZrJVHmMsnNIDMPwkIBnlMItZcfhzscrZGL29DkL88WV78= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774019508; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yEuehUlwv5fMYrq9vtoirIlozvH3dEV269XfkzYgNss=; b=BoMNgxvQPl5ZiBQJM02BdhMHW2uqQidmfGd3ZfKnn2uAqTdAQ/CtR/S2suCoCASTNGq7KfbJ0QCXIpTpIIjFnDBvdvSVnByeHS9z8WXbs5lqA+zdc6vqlLbNxzdP3i+I8C84zATnn0I2AOrJBx2L46m5JTz5HA6t35aK0FNX94I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1774019508658391.8303505261898; Fri, 20 Mar 2026 08:11:48 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1258213.1552365 (Exim 4.92) (envelope-from ) id 1w3bVd-0001Bb-6e; Fri, 20 Mar 2026 15:11:33 +0000 Received: by outflank-mailman (output) from mailman id 1258213.1552365; Fri, 20 Mar 2026 15:11:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w3bVd-0001BU-3b; Fri, 20 Mar 2026 15:11:33 +0000 Received: by outflank-mailman (input) for mailman id 1258213; Fri, 20 Mar 2026 15:11:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w3bMl-0001ko-Gr for xen-devel@lists.xenproject.org; Fri, 20 Mar 2026 15:02:23 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cbde84f1-246d-11f1-9ccf-f158ae23cfc8; Fri, 20 Mar 2026 16:02:21 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0E3375BDF1; Fri, 20 Mar 2026 15:02:11 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DCB2F42866; Fri, 20 Mar 2026 15:02:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ll/PNHJhvWnpXAAAD6G6ig (envelope-from ); Fri, 20 Mar 2026 15:02:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbde84f1-246d-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1774018935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yEuehUlwv5fMYrq9vtoirIlozvH3dEV269XfkzYgNss=; b=T6DmaqxNH0Blb5cy10dYluQkE/UVVbMDbkyOC1lKBJUWBln5GrMVqMIEm9tb8VcXHYz2Xp 2cPIjSGlYyIQaGWUnYZ3sxzxWaXfADO7K+aqvBGoSAoI5PR8Qz4eWfJoELJw2z19Qg4iOi Rqee8A/RHXEanvQ3WTk18amsR2Aueso= Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=qk+UQdiW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1774018931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yEuehUlwv5fMYrq9vtoirIlozvH3dEV269XfkzYgNss=; b=qk+UQdiWmj+Z6a59Nl9lfH2OfrCbGM/lZHDhziABoik4HjNjfuWCwagut55CdiHpviqeCS 2tMNFZuL+mSUotU9EuYgU2aB/sOEBbcKU11c5xj6wrnV7IHu8Bt50ggAfEKgviwbkl9bCs VH/mqJA7DE+uEnMzO08Yg+0VF2uHjS4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Nick Rosbrook , George Dunlap , Anthony PERARD Subject: [PATCH v2 09/12] tools/libxl: add functions for retrieving and setting xenstore quota Date: Fri, 20 Mar 2026 16:01:17 +0100 Message-ID: <20260320150120.874878-10-jgross@suse.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260320150120.874878-1-jgross@suse.com> References: <20260320150120.874878-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:mid,suse.com:dkim,suse.com:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; DKIM_TRACE(0.00)[suse.com:+] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 0E3375BDF1 X-ZohoMail-DKIM: pass (identity @suse.com) (identity @suse.com) X-ZM-MESSAGEID: 1774019509421158500 Content-Type: text/plain; charset="utf-8" Add some functions allowing to retrieve and set Xenstore quota (either global or domain specific). Signed-off-by: Juergen Gross Acked-by: Nick Rosbrook # golang stuff Reviewed-by: Anthony PERARD --- V2: - rename libxl functions to use "xs_quota" instead of "xsquota" (Anthony Perard) - rename the libxl_xs_quota_*_get() "q" parameter to "q_out" (Anthony Perard) - rename the struct xs_quota_set to xs_quota_list (Anthony Perard) - several style changes (Anthony Perard) --- tools/golang/xenlight/helpers.gen.go | 78 ++++++++++++++++++ tools/golang/xenlight/types.gen.go | 9 +++ tools/include/libxl.h | 20 +++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_types.idl | 9 +++ tools/libs/light/libxl_xsquota.c | 116 +++++++++++++++++++++++++++ 6 files changed, 233 insertions(+) create mode 100644 tools/libs/light/libxl_xsquota.c diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/h= elpers.gen.go index 8909fe8a1b..767b9e45f5 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -998,6 +998,84 @@ xc.policy =3D C.libxl_rdm_reserve_policy(x.Policy) return nil } =20 +// NewXsQuotaItem returns an instance of XsQuotaItem initialized with defa= ults. +func NewXsQuotaItem() (*XsQuotaItem, error) { +var ( +x XsQuotaItem +xc C.libxl_xs_quota_item) + +C.libxl_xs_quota_item_init(&xc) +defer C.libxl_xs_quota_item_dispose(&xc) + +if err :=3D x.fromC(&xc); err !=3D nil { +return nil, err } + +return &x, nil} + +func (x *XsQuotaItem) fromC(xc *C.libxl_xs_quota_item) error { + x.Name =3D C.GoString(xc.name) +x.Val =3D uint32(xc.val) + + return nil} + +func (x *XsQuotaItem) toC(xc *C.libxl_xs_quota_item) (err error){defer fun= c(){ +if err !=3D nil{ +C.libxl_xs_quota_item_dispose(xc)} +}() + +if x.Name !=3D "" { +xc.name =3D C.CString(x.Name)} +xc.val =3D C.uint32_t(x.Val) + + return nil + } + +// NewXsQuotaList returns an instance of XsQuotaList initialized with defa= ults. +func NewXsQuotaList() (*XsQuotaList, error) { +var ( +x XsQuotaList +xc C.libxl_xs_quota_list) + +C.libxl_xs_quota_list_init(&xc) +defer C.libxl_xs_quota_list_dispose(&xc) + +if err :=3D x.fromC(&xc); err !=3D nil { +return nil, err } + +return &x, nil} + +func (x *XsQuotaList) fromC(xc *C.libxl_xs_quota_list) error { + x.Quota =3D nil +if n :=3D int(xc.num_quota); n > 0 { +cQuota :=3D (*[1<<28]C.libxl_xs_quota_item)(unsafe.Pointer(xc.quota))[:n:n] +x.Quota =3D make([]XsQuotaItem, n) +for i, v :=3D range cQuota { +if err :=3D x.Quota[i].fromC(&v); err !=3D nil { +return fmt.Errorf("converting field Quota: %v", err) } +} +} + + return nil} + +func (x *XsQuotaList) toC(xc *C.libxl_xs_quota_list) (err error){defer fun= c(){ +if err !=3D nil{ +C.libxl_xs_quota_list_dispose(xc)} +}() + +if numQuota :=3D len(x.Quota); numQuota > 0 { +xc.quota =3D (*C.libxl_xs_quota_item)(C.malloc(C.ulong(numQuota)*C.sizeof_= libxl_xs_quota_item)) +xc.num_quota =3D C.int(numQuota) +cQuota :=3D (*[1<<28]C.libxl_xs_quota_item)(unsafe.Pointer(xc.quota))[:num= Quota:numQuota] +for i,v :=3D range x.Quota { +if err :=3D v.toC(&cQuota[i]); err !=3D nil { +return fmt.Errorf("converting field Quota: %v", err) +} +} +} + + return nil + } + // NewDomainBuildInfo returns an instance of DomainBuildInfo initialized w= ith defaults. func NewDomainBuildInfo(dtype DomainType) (*DomainBuildInfo, error) { var ( diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/typ= es.gen.go index ab9d4ca7b4..8dd610919d 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -543,6 +543,15 @@ Altp2MModeExternal Altp2MMode =3D 2 Altp2MModeLimited Altp2MMode =3D 3 ) =20 +type XsQuotaItem struct { +Name string +Val uint32 +} + +type XsQuotaList struct { +Quota []XsQuotaItem +} + type DomainBuildInfo struct { MaxVcpus int AvailVcpus Bitmap diff --git a/tools/include/libxl.h b/tools/include/libxl.h index bc35e412da..6d2910df34 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -1537,6 +1537,18 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac *dst, = const libxl_mac *src); */ #define LIBXL_HAVE_XEN_PLATFORM_PCI_BAR_UC =20 +/* + * LIBXL_HAVE_XENSTORE_QUOTA + * + * If this is defined the Xenstore quota related functions + * libxl_xs_quota_global_get() + * libxl_xs_quota_global_set() + * libxl_xs_quota_domain_get() + * libxl_xs_quota_domain_set() + * are available. + */ +#define LIBXL_HAVE_XENSTORE_QUOTA + typedef char **libxl_string_list; void libxl_string_list_dispose(libxl_string_list *sl); int libxl_string_list_length(const libxl_string_list *sl); @@ -3011,6 +3023,14 @@ static inline int libxl_qemu_monitor_command_0x04120= 0(libxl_ctx *ctx, #define libxl_qemu_monitor_command libxl_qemu_monitor_command_0x041200 #endif =20 +/* Get/set global and per-domain Xenstore quota. */ +int libxl_xs_quota_global_get(libxl_ctx *ctx, libxl_xs_quota_list *q_out); +int libxl_xs_quota_global_set(libxl_ctx *ctx, libxl_xs_quota_list *q); +int libxl_xs_quota_domain_get(libxl_ctx *ctx, uint32_t domid, + libxl_xs_quota_list *q_out); +int libxl_xs_quota_domain_set(libxl_ctx *ctx, uint32_t domid, + libxl_xs_quota_list *q); + #include =20 /* diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index bc60c46558..ca22a40c6c 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -106,6 +106,7 @@ OBJS-y +=3D libxl_pvcalls.o OBJS-y +=3D libxl_vsnd.o OBJS-y +=3D libxl_vkb.o OBJS-y +=3D libxl_virtio.o +OBJS-y +=3D libxl_xsquota.o OBJS-y +=3D libxl_genid.o OBJS-y +=3D _libxl_types.o OBJS-y +=3D libxl_flask.o diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_type= s.idl index d64a573ff3..1a63c8af76 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -574,6 +574,15 @@ libxl_altp2m_mode =3D Enumeration("altp2m_mode", [ (3, "limited"), ], init_val =3D "LIBXL_ALTP2M_MODE_DISABLED") =20 +libxl_xs_quota_item =3D Struct("xs_quota_item", [ + ("name", string), + ("val", uint32), + ]) + +libxl_xs_quota_list =3D Struct("xs_quota_list", [ + ("quota", Array(libxl_xs_quota_item, "num_quota")) + ]) + libxl_domain_build_info =3D Struct("domain_build_info",[ ("max_vcpus", integer), ("avail_vcpus", libxl_bitmap), diff --git a/tools/libs/light/libxl_xsquota.c b/tools/libs/light/libxl_xsqu= ota.c new file mode 100644 index 0000000000..4524442655 --- /dev/null +++ b/tools/libs/light/libxl_xsquota.c @@ -0,0 +1,116 @@ +/* SPDX-License-Identifier: LGPL-2.1-only */ + +/* Xenstore quota handling functions. */ + +#include "libxl_internal.h" + +static int get_quota(libxl_ctx *ctx, unsigned int domid, + libxl_xs_quota_list *q_out, + bool (func)(struct xs_handle *h, unsigned int domid, + const char *quota, unsigned int *value)) +{ + const char **names; + unsigned int num, i; + bool ok; + int rc; + GC_INIT(ctx); + + libxl_xs_quota_list_init(q_out); + names =3D xs_get_quota_names(ctx->xsh, &num); + if (!names) { + /* Xenstore quota support is optional! */ + if (errno !=3D ENOSYS) { + libxl_xs_quota_list_dispose(q_out); + rc =3D ERROR_FAIL; + } else { + rc =3D 0; + } + goto out; + } + + q_out->num_quota =3D num; + q_out->quota =3D libxl__calloc(NOGC, num, sizeof(*q_out->quota)); + for (i =3D 0; i < num; i++) { + q_out->quota[i].name =3D libxl__strdup(NOGC, names[i]); + ok =3D func(ctx->xsh, domid, q_out->quota[i].name, &q_out->quota[i= ].val); + if (!ok) { + libxl_xs_quota_list_dispose(q_out); + rc =3D ERROR_FAIL; + goto out; + } + } + + rc =3D 0; + + out: + free(names); + + GC_FREE; + return rc; +} + +static int set_quota(libxl_ctx *ctx, unsigned int domid, libxl_xs_quota_li= st *q, + bool (func)(struct xs_handle *h, unsigned int domid, + const char *quota, unsigned int value)) +{ + unsigned int i; + bool ok; + int rc; + GC_INIT(ctx); + + for (i =3D 0; i < q->num_quota; i++) { + ok =3D func(ctx->xsh, domid, q->quota[i].name, q->quota[i].val); + if (!ok) { + rc =3D ERROR_FAIL; + goto out; + } + } + + rc =3D 0; + + out: + GC_FREE; + return rc; +} + +static bool get_global_quota(struct xs_handle *h, unsigned int domid, + const char *quota, unsigned int *value) +{ + return xs_get_global_quota(h, quota, value); +} + +int libxl_xs_quota_global_get(libxl_ctx *ctx, libxl_xs_quota_list *q_out) +{ + return get_quota(ctx, 0, q_out, get_global_quota); +} + +static bool set_global_quota(struct xs_handle *h, unsigned int domid, + const char *quota, unsigned int value) +{ + return xs_set_global_quota(h, quota, value); +} + +int libxl_xs_quota_global_set(libxl_ctx *ctx, libxl_xs_quota_list *q) +{ + return set_quota(ctx, 0, q, set_global_quota);; +} + +int libxl_xs_quota_domain_get(libxl_ctx *ctx, uint32_t domid, + libxl_xs_quota_list *q_out) +{ + return get_quota(ctx, domid, q_out, xs_get_domain_quota); +} + +int libxl_xs_quota_domain_set(libxl_ctx *ctx, uint32_t domid, + libxl_xs_quota_list *q) +{ + return set_quota(ctx, domid, q, xs_set_domain_quota); +} + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ --=20 2.53.0