From nobody Tue Mar 3 03:06:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1772177617; cv=pass; d=zohomail.com; s=zohoarc; b=ZZHEtDRlGgVM8WI0QEKukzURqT28g0eZ6/dYIpMf0m/DVIkwMi5bpOPL4DiRzXbiXEnRCUw9FAqNRlJRaQsjGrPKkQTRPHCiwgZJRprapbrCVa8kwj1/q+glYhyQQgisaTLZ0BY4WDPFwJko8l2iBHBhRPDdILTf5Fuv7Vslb7k= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772177617; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DPPIUPm12nWgbE3ZxGYrVCdi/GpigvkTLG3rTr9R7oI=; b=TuWX/MD2KqrBIZl2zDnB4bXKYvryET+8PodPTyuDS2k/IYyLpEzVNgdtEEgsl72Q0r634oUxnWW2U2Zzvta2dNYMKXRb4jDceyCD6GA+mB+gZnWGM5SOS8rrjG8YjpyRt0B9qm+sm+pkMhDG/JPCL+W0qwpe1oPrwcs2eXyfexE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1772177617788273.58723055315784; Thu, 26 Feb 2026 23:33:37 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1242482.1542918 (Exim 4.92) (envelope-from ) id 1vvsLc-0003ca-Hg; Fri, 27 Feb 2026 07:33:16 +0000 Received: by outflank-mailman (output) from mailman id 1242482.1542918; Fri, 27 Feb 2026 07:33:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vvsLc-0003cR-EG; Fri, 27 Feb 2026 07:33:16 +0000 Received: by outflank-mailman (input) for mailman id 1242482; Fri, 27 Feb 2026 07:33:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vvsLb-0003P8-8P for xen-devel@lists.xenproject.org; Fri, 27 Feb 2026 07:33:15 +0000 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azlp170100009.outbound.protection.outlook.com [2a01:111:f403:c107::9]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9352483c-13ae-11f1-b164-2bf370ae4941; Fri, 27 Feb 2026 08:33:14 +0100 (CET) Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by PH0PR03MB5703.namprd03.prod.outlook.com (2603:10b6:510:30::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Fri, 27 Feb 2026 07:33:10 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.20.9654.014; Fri, 27 Feb 2026 07:33:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9352483c-13ae-11f1-b164-2bf370ae4941 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=skAbc5lk+b9UuPGVUcqLQiDjlrdS4wBvh97l4CXrDls2YU2ZVM1SFTyXfPAAdLcQPQyv9/knpIszaQeRbK3otz7xbCf3qVmA2bJJ8vX3CiyBPQw4CTT2pFculaIQTTniek968hR03GZmJWW4XFBedwfzIaOpqk2o6Y/zCehaGjaDpaIwKGGiMVPFWyCceloFdZTxrHCUsQ/IaL0YJslUEfVWgDF1yaILrSHAbbX6VHmU3cRhlkQH2m6ekShnCWtcgOFosuRjOVq83x0vD1YeeThU7NckFtdp4Ewg9IMPcZhtpr9W1LWUGMHwtpfs7s8yeB7PSVGGATbLcbrX0KGpFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DPPIUPm12nWgbE3ZxGYrVCdi/GpigvkTLG3rTr9R7oI=; b=Sf9Wtv5K1wcAiSvp+7jNqY3jGMsz7gxUWYjmmH+4tde550kdrpCPDSfPgE8af0p1nJCUXQEkBFKmnrq5e+x8TMpLVuMAd6VYDNYKBWjLuWKu5BQC5lDOJZO37KLBIaHvIlC9oGqTTB7vk710SQTy6KUZJcVz0XOVMEWFnABsqOAAkal3Eh8L1eN5X2yYdhXNg3CzfxhDUM8Um3F4w8fo/MBhUKCBWiJ+MqmmVmOppCUBJUCKfoo5xqF3JJxps9RTizzblzewIKR4vS8rHXusiFoTMg7tjeM0d49kH+PPB45JWqSOBHfX3lx3KRDPe4dKgjYdq9wJRwPCtMkG/mtS/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DPPIUPm12nWgbE3ZxGYrVCdi/GpigvkTLG3rTr9R7oI=; b=oWgWtoHSfFFOEZLXoi4T2yEx5N72mtdLyPMJvCfiJP0wplQpk/2yC61UZLN0bns83u54Uz2D8x6xGDWc5mA7R2QaTM5748AT5pu66yhOFpB7H4O57YBh69DgsM4UdXZ3/yYhegJvGbUItJcxFUdhGxLyTPv2HoJjSywQedCQgZU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich Subject: [PATCH 1/2] xen/cpufreq: fix adjusting of sampling window on early exit Date: Fri, 27 Feb 2026 08:32:58 +0100 Message-ID: <20260227073259.1200-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260227073259.1200-1-roger.pau@citrix.com> References: <20260227073259.1200-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA2P292CA0017.ESPP292.PROD.OUTLOOK.COM (2603:10a6:250::20) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|PH0PR03MB5703:EE_ X-MS-Office365-Filtering-Correlation-Id: 63022971-5773-479b-2cb2-08de75d27523 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: HXpUl5T1nlNuLUcOMkxs8rNdbaywbnYsFJ7SS7gEDNvkHenlRDo+Z3PXI1cyocU2innaqXxzecsSrOH+lBqkjVNpcw3BOjyvDxR2Rst9z2XyP8qqKwJ3Z8KK82+kj+Wefyp7cILF3f0OfyGrzhOd4y/Iy6fsCYwjD7/2vyqDh2KIHeM8b/SbsBulISsXik2HdSHm8O1NZR1qQhoc38C9zcEG7MKPqrc3xsgFIFV1rHekLN72WlBirvMASf5BYsMrJucYvA+x8qr8nvJSZcYINSMSE9Ulyclt0p++q25CKMz7H7HtS1qqngunGo4N+f9v/eAbfSoCzDZSaay03GZNXqay3vaWoYum8ihruSqUxh2kw8XlW0mgW46CkWBaU72IDE9o1Rs63VDPVE5814u+h80aGh/jd5TCbslvmGB6wfjhoi8xYXl8+LCEkNszPQ8JF6aRU5s1BFGyeePRyWf1NZxJGgN0zw/O5QMlk3GUgkXy6e8Obafrnv/VLQjmNT+311uUGB8qcYRybQFDJu4we0Km8SASojF5KL4pL7nRfIQwAgITFRCzP8YNj0xvCkLqYCtec0sNpyCi/1Iqraw+ZEqUlKYfEk63VcYK0MDvLTvVj/GsBWFIMsGEIDp7Coi8MHyaW9FzMd1m5WGw/1cJk1ka4MVIB+fg6+UUHOoAvg8F4S8cvbSasRjhpsgTA5IWp2jUurYAKmA48bkBLljRMRsR9MEL6HHKibuOqdsobVg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEVHanpSNzVsSEovU3pWQkxtWmxkclVZTWJOUWNDWEM3REE0ZkQ4RUdxT0tX?= =?utf-8?B?UTltWWxBNWFTeUdXYkdFWlY5ZUM0QjVTNUVxWGdQWGlpcFllc1duSnlpQWVV?= =?utf-8?B?a01qYiszRzFES0pIU1NNeE5FcXpSMldmc2VDaVBEL0E4U2ZNMXEreHJ3dWVH?= =?utf-8?B?elYwNjcySHFoVjdQZi9tdTlrTC9tbmFNT1NtZXNvcGs1OFMzdUN2ci9hSFJN?= =?utf-8?B?SDRrbjI1SEJMNWcrMFFDdWEyZW5CdlA5dWsxb1BwVHlZd25DTUxCdlErVTc4?= =?utf-8?B?d2dqQTNMeHRWQnluRkdmZkdCUUV1dnVEcDIrMExvcCtNY2k5emhNN1hkajUx?= =?utf-8?B?c3RrM1ZiTXZYeEpTdm55YXVlQUp6YXhMaWVnVHZkRjVxNkJYUEE4UFFrOVBS?= =?utf-8?B?SkVlM3NRQ2w2blZJOVFYclRwU3piZHNnbEYyZWJ4K3p1VEdMS2F3eXlnajBO?= =?utf-8?B?cThDZDBPWE1DQ3R5blhHTFF2QjM3NWdjMlVWSHhqMWpZdzNnbVd4QlhNcEZ3?= =?utf-8?B?VitaMEJkeDByajZhMjZhYXdOK1Vmb2pFd1dSS3c0T2wyZlQrQ2xGNURrSlNL?= =?utf-8?B?djFkcXRjU3VZMmtlc0dEYURuSlRETHF5TlFNaWhWbTVmVFYxRG5ydmswWWNw?= =?utf-8?B?MktXQTVyanBVMFB2UEI2ajRhV0pqOGJwVVhFcm5WTXdqM0x4Q3RIVUs1dzZ2?= =?utf-8?B?Q1FNeDlubGs2d0ZFOWJCdmZJVmZJR3R6aVJUZCs0aHJpQ2gwaXZUQzF2Vm42?= =?utf-8?B?MisxTW5ZVG1COHpPT0hlanJjNWpBSjJlaktaMEJLU3pHZDFFUGZkR01rN3JI?= =?utf-8?B?ZE1PR2ErbEE2d25MZGk0b1p6R3kvUEk0Y3NVNnZoVHZwZ0hkU0hScFVCSUZx?= =?utf-8?B?OHVGc0lHbm1na3pYc2lRZWQ2NFg3THVUcE1zbkpxSkQ4ZG1QcjBZbzRKVy83?= =?utf-8?B?c3ZjU0VjK1VkM2JyMXNoME5BMlBGQ2Z1TGtSVlNkZlRpeTk2SFlsSDdKNmpK?= =?utf-8?B?VVhjOUxCOVZZaTVCZDVkelZhbGd6WTZUMUd5QTFYUk91NlphMzViNWVVcFFB?= =?utf-8?B?MkhqOG4xQnBoQWovdU10bnBxOW9XdVN3WmJQanBPVFlGOXpyUGRUL3dGei9z?= =?utf-8?B?YkhXM1UzQldYYXoyU0wxbGprZVR0YllYMUZNY21kZ3o5NFAzdkNuYk9IcmNQ?= =?utf-8?B?M0RhbXZTS1NNTk1nTWVBTEFWNTgzd3lhcjNscjFJS0hQVVNuZVJ3TEJBL3lD?= =?utf-8?B?aTdJVytjSWxZZUc2eVp2N0F4NXlxSm9DN24rUzlMeHExRkl0ellTeTZWRzc4?= =?utf-8?B?S1JQbnZUM1kxSTk5RFh5OWE5NFl2ZXdZRmgvQVhyRG9kOHF2d0FwNEE0Nzdj?= =?utf-8?B?Y0kxT1k4ZUNjY3dWQ0VEOThQdExDdVVQM0dDR2VXNFpGOTEyR2NIcHhaNllB?= =?utf-8?B?ZmgzU011YVg1UUpMVTJsdm9qb3ZpOHNYWDk2ZEZtUlA3Y0loWStjaGpJcmhZ?= =?utf-8?B?WktqMUt2UkMxQjNjeGdzcUhzdlNDVVd1WkJzNmFCZEpXVFJwd0kwQkhSdGQy?= =?utf-8?B?MFdxYTk1K0huUjkwVERaV1Nia2lvbVVMS3VzUUw5Z205VGdvWFE0bnAzcGh5?= =?utf-8?B?Wi9UcmptUTJGZjREWDBBOXZ3ZjBKVWtPMHYzeFRmaGtRWHRpQXVyb3o0bEE0?= =?utf-8?B?UWU4c3RXcXRkSUh6MjRWMStTWmltb2pCMEQ2c0ZVZWJKSlFKRW4zN3ZQQytz?= =?utf-8?B?U0xWTGZIbnNhODZnSzVNM1VDMUZKakgvVitGVysyZlNBaDN0cWJZSjZIdG4y?= =?utf-8?B?UXk5UlZxZEZkZHdZU091SDJnWW43bGhDNnVWZXR4SVIwWlkvWGw4elBlTTZw?= =?utf-8?B?Ync5NGd0MDAxNHFvNm96T2p1NUFEdFNNb2IyL09wMnU2bmZReXJDUU9YVXV3?= =?utf-8?B?cmZlV0lPYlVlNVU2UkpSRnBIQnhLZU44S21naUtYRElQYStLaHhCbE1iOEJu?= =?utf-8?B?OVlTMk1zaXRBT1NzQmVFbFF5Zmw4TFpjRlhNVzlsUC9ORGprd1hXd3F2TS9R?= =?utf-8?B?Tm1iV3JnYTNMbnhqT3VmWGFER1REV1o2Z0RkbTRkZDdaYVkrWkhYc2YzL2Y3?= =?utf-8?B?V1lVNFhvM2pqbUlQTDVkcFhPSy84SWU1bCs4WEdHSkM0VGg0YlZyU0trWmVa?= =?utf-8?B?ZzNPRnlSNWZRM1BYa012LzU1emVqVVM3Tm9HbGJQeXB6R2JlaTErRGluV2U4?= =?utf-8?B?VVN6YUQrS0N3aWtwRlMzdXJ5dm9sK1NselFKUS9kZjU1N3pIMGJ5Qi9EZCs5?= =?utf-8?B?UnJCT2p4K1ZPUlBibW1uVmx5UDJoK0t3RmFZUWFLWkR6clFWbW5vZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63022971-5773-479b-2cb2-08de75d27523 X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 07:33:10.3545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0/rWDO5hkQEJp6KmKcwwcrcdMPYYpTcgZ1gglQk6Kmg1r1hNl3UAA/ioNwst/rlWxJB1P63bu6QhUmIkhYhnpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5703 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1772177619836158500 The logic in dbs_check_cpu() resets the sampling window even when the sampling period is considered too small. This leads to further calls finding an imbalance between the total window time and the idle time, as the total window time is possibly shorter than the idle time. Fix by resetting the sampling window start time in the same block where the current idle time is stored. While there also prevent a duplicated call to NOW() and instead re-use the previously fetched value. Fixes: d6f001cb91ac ("x86: Implement cpufreq ondemand policy") Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich --- xen/drivers/cpufreq/cpufreq_ondemand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/drivers/cpufreq/cpufreq_ondemand.c b/xen/drivers/cpufreq/c= pufreq_ondemand.c index 0126a3f5d9b4..537695eaab19 100644 --- a/xen/drivers/cpufreq/cpufreq_ondemand.c +++ b/xen/drivers/cpufreq/cpufreq_ondemand.c @@ -117,11 +117,12 @@ static void dbs_check_cpu(struct cpu_dbs_info_s *this= _dbs_info) =20 cur_ns =3D NOW(); total_ns =3D cur_ns - this_dbs_info->prev_cpu_wall; - this_dbs_info->prev_cpu_wall =3D NOW(); =20 if (total_ns < MIN_DBS_INTERVAL) return; =20 + this_dbs_info->prev_cpu_wall =3D cur_ns; + /* Get Idle Time */ for_each_cpu(j, policy->cpus) { uint64_t idle_ns, total_idle_ns; --=20 2.51.0 From nobody Tue Mar 3 03:06:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1772177619; cv=pass; d=zohomail.com; s=zohoarc; b=PmmILCxmMO+9QnCiJr7DGLsuNLJn0tON4ZKqgFqZBG0u9BK/aS8AJzKQn5N218YOJEXdX6hOvjA0j70cgEE2SCRac9zAcADk+ACl8mZQhZlh+iLYkhFYWJnreZ5iKQzOd/i26iC4grZdGm7YTCCeRjdumjr8URM8oOHrNThDusY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772177619; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Urh8wr5J46bIDyHt/VSWqgUO0+Dn2AXVKCUHBxW0PlI=; b=MkpjPqL4WUfbcWVsjkFEKXHtLmqcJwF/Bz493DrLircLCnfKO6M6awOktr0rVhjCqTO409kg40Gl6sJORiLtCTtDZsZEMAHeONOExh2MDaTtQaRjwoNtwEIMnMdhwjC9ScL14J/Mlmew8/izErqk7DB0HgFyYTulzow3+KWRLbk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1772177619392771.6969472541982; Thu, 26 Feb 2026 23:33:39 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1242483.1542928 (Exim 4.92) (envelope-from ) id 1vvsLd-0003pv-O2; Fri, 27 Feb 2026 07:33:17 +0000 Received: by outflank-mailman (output) from mailman id 1242483.1542928; Fri, 27 Feb 2026 07:33:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vvsLd-0003po-KZ; Fri, 27 Feb 2026 07:33:17 +0000 Received: by outflank-mailman (input) for mailman id 1242483; Fri, 27 Feb 2026 07:33:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vvsLc-0003P8-8i for xen-devel@lists.xenproject.org; Fri, 27 Feb 2026 07:33:16 +0000 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azlp170100009.outbound.protection.outlook.com [2a01:111:f403:c107::9]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 939da2a3-13ae-11f1-b164-2bf370ae4941; Fri, 27 Feb 2026 08:33:14 +0100 (CET) Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by PH0PR03MB5703.namprd03.prod.outlook.com (2603:10b6:510:30::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Fri, 27 Feb 2026 07:33:13 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.20.9654.014; Fri, 27 Feb 2026 07:33:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 939da2a3-13ae-11f1-b164-2bf370ae4941 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rJtoW1Cz720HUTRBe4380NcJfkeNk7MLnBfapSa6fb00CieE+F5jS2m/Ik0842Y8JlKQJutJz1ComPTXzRY9/KzEEHPC8v4NDKgi8UD808yYtK9sssC3qQqO7oQyLFUBclqob01sWnvk7FBdzPb2cqZOXP3GMkSd9aM/+fhTcovKeXMTxAkYmDnL98fJO+D0EyFgiOSCdUWOeHPZal7lqI3YdfjT0DGqjLoU9sbm80HVdk6JEjYRoDQ73L+dKhfLSAv/vwp9enzXGzy6smjF3CPvNMpF8fhRqxea1E9HQvINShSe1HGVvih0+g32sg6xiovZWA8od37CrLGnMA2zOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Urh8wr5J46bIDyHt/VSWqgUO0+Dn2AXVKCUHBxW0PlI=; b=N/3gGoM22qw4iRM+01htD4ZWlfXSqflL+6M2cLi8XZouushhXf0A22CvbN13gXy8Ah28qS2CHRpXUyW82kWlX1iNU51JuRfnHN3wZS0ynUyFLxBaMBEd0OVRVLRDGo2voPACdAj3X1LVUTMC905SifKwCKGvZBRGInH4BFvbWkYHi+2M/jxugQysrx+ba0cN3lyxhCAz6cgq7amB0+0msrBu9h/I8lG1g7ummpNhJdUtx/qc10ZBCIJS/WwFkcJ6y0c/lXVaDbFe7TDPEBTvZFF/WeMPX8+u2QifULPdk1GKKhQT9nbdnoOLKKIGawbrS8yWYbmPyFyQqIeALVr0HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Urh8wr5J46bIDyHt/VSWqgUO0+Dn2AXVKCUHBxW0PlI=; b=Y/HKGGPAzPpcataWaR20u7oEBgEuAbqTj4Ecqwbdm0OLGwPqigUkGm4L3nIjRw3TVGDmILW0URXh+Awjl5mV6+aRBIgyQ7FPDJcu42/SQl0QmdbRRe0yUkXaTlqFpQVHA0jZW6HirprzE9Yqm48nN2JknHF+gx09f6dkTt7ufSg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich Subject: [PATCH 2/2] xen/cpufreq: fix usages of align_timer() in the on-demand governor Date: Fri, 27 Feb 2026 08:32:59 +0100 Message-ID: <20260227073259.1200-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260227073259.1200-1-roger.pau@citrix.com> References: <20260227073259.1200-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA2P292CA0002.ESPP292.PROD.OUTLOOK.COM (2603:10a6:250:1::18) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|PH0PR03MB5703:EE_ X-MS-Office365-Filtering-Correlation-Id: ffe9cd97-6320-4dac-ef6f-08de75d276bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: /gK9hHoonsgV4cbJtvfgqTm8vci9w6XYjlXb5bGtBMUKh1StLxm5DZe3uwZTLtiY5Wwfh4noHQmpE7mowoSNOtJ5d0KdjCJa5JzVCX9+YhQUNDifDZ1Cjm8mVM5wqXX3cx0MiUu9JYt7Y30NIaAfo5xxfrYATN68kd6BKWnDj6kuEQZIyLLER9sL/WCEbKI2YhE8Xpzc9VEeYrwDClsrbLn+z9FJZnh2ITViQmgW3XQbwOPVe3OOkCe7fZkMSHnmQRtsyKzLZasRR8dhJYMJIVI6bu4teSTSqSgdZdu9pSHc9jtuGcTbcLCqo4jphDmQqrUyLtKZAhPNNabsZRr+KT0+zaQuCbjrGXlgVkrfVTtJEkJ3AHDjJ6TPohObOfsHTmzvuohIWZUcG45yBgBbZ8TwtzfvpZbcPLlOmMdcpZpR74wV1rjpKkYKVFv1CkJADu6yKaTUdFwv+j3cPxNk0f6AveoZWo1+mPqB+RdZKdUdtnXnOtVqsJE6+uSvXb/XCPQW4h366wuKHSwq4gmBGuXq24Mb8FcQ53gpNkG287JFYk9xC9jdm7P+mZou4wr1tDbARKvG0FFjsHorMx1Jk8TT710g1BJw98VNeOGDlIXzMsom+8yI5kECAgJQpXjwtvRkvYPu3QMQAp755VKR7YCbg/AL7m5F5b+M7r/SAq7FeiJEG5TJW1Q8iug8ypNl5oavLg65M+OTvxKL3tr2olqzE0tGGSYcOQf4UMy/Q3g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enFoWkhjam5rMEtIWDhuempNZW5EdTRnWWVwa045YmpxcjJZcTlwQmJzcTlZ?= =?utf-8?B?MVJYd3RnSVhlWlFoekRIMmx3SWZMVHcwTnNkRVA3bDNEMXRiQlVBazhnQlJY?= =?utf-8?B?N1ZQa2M2TWpqQlFaTWw1OWQzSU1FREJWNE4yckNESDBhL0RCY1JtWFlBR0E5?= =?utf-8?B?dkp2ODJOd2JycWN0ZDZkQ3ZzVFVZUU40Um1rQWFqNUVON1lKMUJlcnlUc01K?= =?utf-8?B?MDQxa3lNMGI0dnExL0l0YjAvSkhORFFLY1I2THhtQlJTSUprSXNGY05EZ0Nw?= =?utf-8?B?Y3phckNnMU9aLzdnMmdZcERQRXN6RXdHNXVUKzVrYi9MUTNlWkdWdFByd2Jj?= =?utf-8?B?Tm9PZDlMbUxOY1hrT3pBNUErVVJ0czZyZEVWM3gvNkdSNGIwT0lKSGhUeXQz?= =?utf-8?B?aUswdVhBNE5LcUo3K3A0WTlYa00vRlVUaHF4SnU2SEJoOXdGRC9Ha1l5MGdW?= =?utf-8?B?UVNhbXlUNUgxUTRYR2NMeXZzTVI2YXdEcGt5Wm9xVjBGWnloR3NwcE01WFd0?= =?utf-8?B?djNZdlJxSUM5cEhtVGpBT2NDRHVYTnFBaUNkSnI5Zmd0WXNHT2VHRkdXelVq?= =?utf-8?B?M2ExRkwrblJnc1lpektXL2FTaElwV21yOWR0b1BwZkQvTEV3aWFqN3lJRUYr?= =?utf-8?B?cm5HanFkMkNxS3Q0bkVnazN4TTMxcXAvQWlvU1hZdUFMRXVrNWlBR2dGbVNk?= =?utf-8?B?TG9qUUFlS1YrYVkydUdEMG51cDBFTTI4Um1SMER5S0NHRldyVVZNNzBVNUYy?= =?utf-8?B?QTg1TGlMTlN0YytwMm1iOTk3eDJRSDIyb2tWcGIrb0lJU0F5aDJQUU9DbW1x?= =?utf-8?B?dEtXczVSVHJLMy9QMW5MT0puRG96aGNOcUloK01ucnQ2TCtRN2ZpWkJkTHJo?= =?utf-8?B?enc5NS9GNUlDZVdkVVdhd1VqbFZwQkRKdWMra0d5QnJlbG02VStBUy9iR3BZ?= =?utf-8?B?bG9ndjlmVHFDVVlsLzdkOU0reEZEOUtMWFhsSkpWZndyWUNoS1ZFWUZJcmxR?= =?utf-8?B?Zk4vb3lrc3d2eVdxNldEa2hTdWsyQUJpUmdwUlFYeUF3ZGZkeXFCQnZEaHBj?= =?utf-8?B?b0VPUGZhR0gxZ0VkS0lHV1orNHA3REp5OHF1TC93czBXN3dnd255MXZQZnpy?= =?utf-8?B?bTcxWUFPQytYMFk2L2VBTVdjcEZKSGQvR0VOSGM3VUZPZzRZRE1taktCZys1?= =?utf-8?B?aWUzK1JnY081UE82TTV3L1BRMFdWcmNpVWs1cCtHMjFrWVhVVXBDV1c0QTR3?= =?utf-8?B?L203aVRlUStYSkoyNFFtNkYrazA1R3prY3JRSmxrSjl0RGxWcTBrVklLbUlT?= =?utf-8?B?YjUySzdMdnh5TVVYakVHRExpczJzWXh2UXZtb3h1T0R3Sis5R1ZyNmRjRTVM?= =?utf-8?B?UmphaE5PNndMdjBPUmRwU0ZFZXpzbjhCT3V0bDNGMCszNjNIY3ZLYjhCNUd6?= =?utf-8?B?NlpYYjBXcjAzTTRYYWpzNGZZTzEvWTA0MVM3TTlvVWZ5ZUI0cmY1RC9WdHh4?= =?utf-8?B?TXV1dUFjS1dMcTRvaGdGSVAwaVc4UEhISFhIS0NNZTI0Y2U5VUdUVGMyQUZu?= =?utf-8?B?b0hpRjN6cmRXaUZFMGZxbVZDU3FvRWdZbnpkajhuQjIxVEg3L0dNQnR5bmZo?= =?utf-8?B?Y05rUmNsMmxURTV3VFhxYzA2RHdENkJ2ZjNZYjk5MmVHeklwangxTUcxaUd6?= =?utf-8?B?YVdhWU9zU2NoV0lYbzdOaGsyczdNQ3F2UzJMdDlKcjVBZE5OcWJWOXZKRGtq?= =?utf-8?B?QWZuOVRvSmlkNFlJeWtRVnArQTIyMzNpVGtNVlZ1c2VoSXhUU3hTY0xQNDZY?= =?utf-8?B?VXV1MnFacDJLSDUvWXBlaDVZQzV4blpvSDdNeFdXZFRkQTZVQUpRZXFkUW00?= =?utf-8?B?b2lXeUhmS0svaW1MQkJLZXkwNGFkOExXWDczTmVCVWdXdDRvZEEzQ005K1Bj?= =?utf-8?B?N1Y5c2wzVFV5VnZDMklZa2RXbzV0emRyUWVsVE91cWZ6QWdXcDl4emp5SklM?= =?utf-8?B?U1JWUjdMdFlTbFgrWVVlZzZXbDErNGc2bWtOeGtuU1BrcG9GbEh1cTBJSUla?= =?utf-8?B?K0E4UXg4QTlLeUpVbHV5MXg5ZzNhM2tPZm10YnphNCtkZWlDYTR6cEVFelNR?= =?utf-8?B?VTFQUElpZE9LMCtQR2Q1MkV5Y0hTOXRxVTBZbDdmTndna2YrUkNuVHFycVdK?= =?utf-8?B?Z2V4QXREZlg4c2tyVEdqYUdpbkJlQlBYKzJKU3JaNzVUQ3ZmdjRuTGUyS0hv?= =?utf-8?B?Z3dRSzNUOGxhdVQ1MzRGcEhqbS96enlMaUQxWFExQVhxL0ZuTHpWTVpNRng5?= =?utf-8?B?bXhNc0tPYnlRS0NrN211S051b2k0UEpjU2hIMDVqU0o0RmQvc1FjQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffe9cd97-6320-4dac-ef6f-08de75d276bc X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 07:33:13.0607 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ExjLJYqKk5lAEusCu3nxSVssao2mNXqRJTzTiq8XcftxL9jVLFaKTfh4/Qa+Te1mwhnQxcwVr2sBIPa0uAW8rA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5703 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1772177621480158500 The first parameter passed to align_timer() is the timer expiration, not the current time. Adjust the calls to align_timer() in the on-demand governor to pass the expected timer expiration as the first parameter. Fixes: af74e3a15a83 ("cpufreq: align dbs timer for better package C state r= esidency") Fixes: 382b95f627a9 ("Fix cpufreq HW-ALL coordination handle") Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich --- xen/drivers/cpufreq/cpufreq_ondemand.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/drivers/cpufreq/cpufreq_ondemand.c b/xen/drivers/cpufreq/c= pufreq_ondemand.c index 537695eaab19..0d94c0e464a6 100644 --- a/xen/drivers/cpufreq/cpufreq_ondemand.c +++ b/xen/drivers/cpufreq/cpufreq_ondemand.c @@ -185,7 +185,8 @@ static void cf_check do_dbs_timer(void *dbs) dbs_check_cpu(dbs_info); =20 set_timer(&per_cpu(dbs_timer, dbs_info->cpu), - align_timer(NOW() , dbs_tuners_ins.sampling_rate)); + align_timer(NOW() + dbs_tuners_ins.sampling_rate, + dbs_tuners_ins.sampling_rate)); } =20 static void dbs_timer_init(struct cpu_dbs_info_s *dbs_info) @@ -400,6 +401,6 @@ void cpufreq_dbs_timer_resume(void) (void)cmpxchg(stoppable, -1, 1); } else - set_timer(t, align_timer(now, dbs_tuners_ins.sampling_rate)); + set_timer(t, align_timer(t->expires, dbs_tuners_ins.sampling_r= ate)); } } --=20 2.51.0