From nobody Tue Mar 3 05:12:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624054; cv=none; d=zohomail.com; s=zohoarc; b=nW2weOTxVnhBYp/jB8cbE9IsHKT3CVScq0m2wUGkULe0Sb6diLbHF9lUF1Ys13ydlYEixbKoi1CQUNgs1OZWvYaiAj7gssUM2US6lbg+ColVT8kEH5yXjZIG80s3y168hxH/mX1j3ekWC/laeFVzsUb2gXHuPk5yEJBi3qloLpI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624054; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5TrnZ66XZ6HFaBzMCfnoTCQeXNsoz4cCSZgGcCFs61o=; b=lO2g8uU4tqUstvddX9yWOnJLX+Nyp5AYT3Y2K8heQHE9xjs7hWlzl8lJnZHFHQdSn+RRxRvqJPq94dmx8/V3DUyky4JqyOB4dgLvip1QRqJBt9jspcCPiH3pJfM1H97PqMG1PrshSIVjnS9KNmK/UBRZGpcYLAt5t5jF7ao49mQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624054811842.4727133699137; Fri, 20 Feb 2026 13:47:34 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237616.1539913 (Exim 4.92) (envelope-from ) id 1vtYLB-0001RV-Ax; Fri, 20 Feb 2026 21:47:13 +0000 Received: by outflank-mailman (output) from mailman id 1237616.1539913; Fri, 20 Feb 2026 21:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLB-0001QX-1C; Fri, 20 Feb 2026 21:47:13 +0000 Received: by outflank-mailman (input) for mailman id 1237616; Fri, 20 Feb 2026 21:47:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL8-0008Ew-J7 for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:10 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b54e7943-0ea5-11f1-b164-2bf370ae4941; Fri, 20 Feb 2026 22:47:10 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4837f27cf2dso21378625e9.2 for ; Fri, 20 Feb 2026 13:47:10 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:08 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b54e7943-0ea5-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624029; x=1772228829; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5TrnZ66XZ6HFaBzMCfnoTCQeXNsoz4cCSZgGcCFs61o=; b=HuudOdGd40eHvHS0yy4pLmIDMIVjjBSs4APab6PAXlwE3ZTtzKjt8ramAAi+6j4hYt QRs1qd0O8oXNmb1p9xYPXW0zMYuXmDeKCWormUGiEVIsAH4AwwjsRP/RcAUpFWc0vMTJ Lkke1/iEsUQHS/0AUFXEcnAtlJpR+AzgmOfZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624029; x=1772228829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5TrnZ66XZ6HFaBzMCfnoTCQeXNsoz4cCSZgGcCFs61o=; b=GzPbOoN37lGp8szPI6XjGt6EuoxNzVHbMNieGbQ681b/7Ey5sbnD4MwDixVGXGmu6W w2WQzA03wW77G9oBI0thX8mWMB1H2r1iRKB7HDewzbzZWwEDS+lSBgguF+X5xN1Ek35H XjC9s9Y1tYahL6E9A7Kal/veismAVfrjKAjmDFRDkPT7/TcavbXToqIxUwwYLl+BJ3lr uNSA6V/LKPqhgkgNnBwcRDtM7Ffi97n0WFhhkpKCJdmcVo/wKkixa3HAnrkoC2bLYrej kTbOR/n3AhXo+Xcgzq3qghyUYwgftOUisGFcWf8qQi8qDngmpMO/KqL1tZ6a3Re8Zlit ERmA== X-Gm-Message-State: AOJu0YzBSJYknj5424beAoBxfTJMOGYrUABFQd2pzXZjcINA1LMz71YT zjXTuSiIiMerxAhc79LHCbn5cw5KIdLyBM3SWAjJtzJM9GzSu92m/byXt9ENiTVdUbux83tjPvy Gm4MKzCDy5w== X-Gm-Gg: AZuq6aKqI4nU4GIgOwTZSiQGSfMlh1HW0xCyuq3XGo1KyMh8DwpNHnj98ofdLo7dF9W 9Fvv/c3rsxVkGdxS0PaNprezeLR5cTAsnnQZiGp9RNPUlg1gs3Ua24nS/7SH3bJwwZUtYxufgUC FIbcuYZveH4Oj9GN6Di4uMw/cUlD6wZpDvHQV1iAeL5krNF3amDDqZOu8StmUpxY4VwmQ8v2s/N qp6KerEIxXhfpTFFDmECsGMibl53jtujQ6N+eMD5slWMns+ATYje/qNA5+ix6wJ13kj9VP0w2OE n9f2uDd1WD0LyTh1B/PwMfVCA/Gl7J2rOX8FQJFIXFI0xuEEqkMwZ9xeR3iE9ZPuUAMUb2yBMDS /B5Q31FDGVtxWth/2Av3D4wZ/DnG6Xycl2GSIaFxoRjagpwSME8dLhUNMrO0YbjUoXaMAJaU92B Z4o//jN9Mlxm0HO/HA0W0Lh+v9sG40e37iOlQh4EEdRrSvgScoo/J5M2l4EuPm/BGGP7cWbAA= X-Received: by 2002:a05:600c:8b88:b0:479:35e7:a0e3 with SMTP id 5b1f17b1804b1-483a963d64bmr14245295e9.30.1771624029103; Fri, 20 Feb 2026 13:47:09 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 09/12] x86/shadow: Rework write_atomic() call in shadow_write_entries() Date: Fri, 20 Feb 2026 21:46:50 +0000 Message-Id: <20260220214653.3497384-10-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624054981158500 Eclair complains of a side effect in a sizeof() expression (R13.6). write_atomic() only evaluates each parameter once, but rewrite the expressi= on to less resemble entries in an obfuscation contest. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/mm/shadow/set.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/shadow/set.c b/xen/arch/x86/mm/shadow/set.c index 8b670b6bb555..96ba2811077e 100644 --- a/xen/arch/x86/mm/shadow/set.c +++ b/xen/arch/x86/mm/shadow/set.c @@ -62,8 +62,8 @@ shadow_write_entries(void *d, const void *s, unsigned int= entries, mfn_t mfn) =20 ASSERT(IS_ALIGNED((unsigned long)dst, sizeof(*dst))); =20 - for ( ; i < entries; i++ ) - write_atomic(&dst++->l1, src++->l1); + for ( ; i < entries; i++, dst++, src++ ) + write_atomic(&dst->l1, src->l1); =20 unmap_domain_page(map); } --=20 2.39.5