From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624046; cv=none; d=zohomail.com; s=zohoarc; b=IFxLMAqKe5G0rJmkDQSs+za3HsoLVMlhJz2HZWGLyT4gIV0zVV4zhQqv4M1TtLmFihXCSCnjxifbC+UBAtIIHLzxYUS0nkCqF8r04Z2xIGR9Ly+Uzsv3SKcNjTrHNjAqOlEerq811hrenTiMf2Ams5Ls50bfh5z7KcGUUMd+5sY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624046; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dnaGS3zzuYsqMjk2MsjJw1YBBqsXTM67p067A0SdSPM=; b=QM/RC71VJqK2YxTazy+NuUVHazHPQtzkeXBfkMxDrD39gWaP1Q943wPDoFji9smYLUDasrWDocMeFisivj3cgCLV0OL3Af7jdE1ixdEERQ8xpsTj3rTQxZgqQvZdU6vSAkro/YjtQl8pB21p2WPLQ2cHPZXskIngEfWBXJxS42A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624046703134.8324945974192; Fri, 20 Feb 2026 13:47:26 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237610.1539855 (Exim 4.92) (envelope-from ) id 1vtYL5-0008V2-QS; Fri, 20 Feb 2026 21:47:07 +0000 Received: by outflank-mailman (output) from mailman id 1237610.1539855; Fri, 20 Feb 2026 21:47:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL5-0008U7-Km; Fri, 20 Feb 2026 21:47:07 +0000 Received: by outflank-mailman (input) for mailman id 1237610; Fri, 20 Feb 2026 21:47:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL4-0008IG-Si for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:06 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b20f812e-0ea5-11f1-9ccf-f158ae23cfc8; Fri, 20 Feb 2026 22:47:04 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4833115090dso23877675e9.3 for ; Fri, 20 Feb 2026 13:47:04 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:03 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b20f812e-0ea5-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624023; x=1772228823; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dnaGS3zzuYsqMjk2MsjJw1YBBqsXTM67p067A0SdSPM=; b=RnV7e929jDxnjFS6JQ1PaZUmscQO56lX1vX8mSew/OL7dfQNIdUGs02ZTmWFgLS/0T VoJDmJejvbzmTq6eXKP6KVm9l1Npg8Dm0B2t59xY4ZsCctucIwX0QvYbPbeZizUJi54T o4feGno69YrXtOUygsi7AUFFvkflZ97rRa/e8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624023; x=1772228823; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dnaGS3zzuYsqMjk2MsjJw1YBBqsXTM67p067A0SdSPM=; b=K2Gd4ORZZz3GFRVt/pXGy8c9FaE2rIXRMeloFhhCvJxkxwy9PGdZB8BQpL2A575Egs mvEmVP8r7sl5q39qzrs7qPfMwuLylnhZNUwveQIxFiPZRSOvHWtxf0GPfodT8JRKzfjo mQYP3dh1A1A+EEIR7enApPbdQZOGZHQvOpUVeTo1wKqhjS2mWloA2YTp5BnajCPAxWi5 oOGOTBzjyP+8iyFqkxJ/DSDfc6FOOx96iVgVRcc1KULY2qOx49+j38Ee9baVK0zRT/Fb /nQDWd61jSeyEijwEUKdKwubzYibX26gxuCQDA5uqrJPFOQUTBEqavsY4VlcFIyVKYsb zZ9A== X-Gm-Message-State: AOJu0YxX0AqGxbKJ4V9jFxEdOn2rr9YkjbskbYYAENqaQm1H6uICAJWW xrC9xmZtjFe32QabGx7au1AdDsP/lrDn4CVS5C55k9fAQiwecJDwnDD25vPb7qR0KmisYICzIiT pHHkBO9P5jg== X-Gm-Gg: AZuq6aK/6IG9NRGuqysHDcmBKOoI/a4hvFp6UALIzcpRbhddizb/wkQy4bIvte1qiR6 s6BQ+3PEnUVeDvkd5Sk3l5SBP20ORuvXcZnClfg11A5+yZoDO10E+QrzQLHEGozzhldOfQdnr2K XeXF/PCBAQohvRwSAyRYIew4LlV6MPypVhCm5HvW210joQdislBLEWj6FzifapCMt1m8S4/v/iZ XfdhowkfNo72Dki4+PMfl0DNANYsuIukvzB9noVWKWF2S27G+MUoSIpYBKfgbr4DqsDPAXDw2at ULwIoEFDRT8NBmNtWzdxg9jCJIEzzYsxczHUmnX8W08Ofq4lies2ulzd0iTLPgwCtLLMhXPg0bF 6EdCZ/k0sHPdTXvO23RMn2SmtzAI38LgCzvvTj+j2dKsZBotqrPmjqz5Wt/UyJQepLJKK5zcy87 v/d/5QH/eUn6e8R/Q1F7wo+iIyLc7AXcGjFGFFjMSyaoKRTgrCdUmTGaqgN9DQ/CFJCQhqlvm2z uMnsIXJmA== X-Received: by 2002:a05:600c:6291:b0:477:8985:4036 with SMTP id 5b1f17b1804b1-483a95b5a7dmr15500545e9.1.1771624023312; Fri, 20 Feb 2026 13:47:03 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 01/12] arm: Use __func__ in acpi_boot_table_init() Date: Fri, 20 Feb 2026 21:46:42 +0000 Message-Id: <20260220214653.3497384-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624047631158500 Elcair rejects __FUNCTION__ as nonstandard syntax and a R1.1 violation. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel Reviewed-by: Nicola Vetrini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/arm/acpi/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c index db5085e15d84..4ac0fd8f51e8 100644 --- a/xen/arch/arm/acpi/boot.c +++ b/xen/arch/arm/acpi/boot.c @@ -264,14 +264,14 @@ int __init acpi_boot_table_init(void) if ( error ) { printk("%s: Unable to initialize table parser (%d)\n", - __FUNCTION__, error); + __func__, error); goto disable; } =20 error =3D acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt); if ( error ) { - printk("%s: FADT not found (%d)\n", __FUNCTION__, error); + printk("%s: FADT not found (%d)\n", __func__, error); goto disable; } =20 --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624050; cv=none; d=zohomail.com; s=zohoarc; b=LxjdFuivbKmzDKfL+8FIuLQzFEr/lF+krNrZpdwsae5vfo9RBbcaXVO3bhPG++GZ2Pc3vcHF+38KLYk4/XmTXMEl4JCGOvPriRPjXk/OLEXFzU4hWXH/T2mARR4iW8D1tUysX665TrYGYfvHYRwHUlxUJnyJUWUtxKF9lFOgAso= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624050; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jDPL04AxDc8Xafccu1ZVRQiZUTvtnTnKwY+v0GkBCrE=; b=C0lqR4uIrv7HJZcMn9sGj2eeCD5YXkKyNWdEzBSUoRTDuleETSjSnpmBH1GDKvzTk42uv7q70Gw4GgjPONxKhHsvRlgt5iXcGkHkj55EDduedvFVVlYPKVwN4aHwewKZeMlKpjWcjv3peeCE4JxX0uIlckB524bTJh9konLmIAg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624050367551.3627583319881; Fri, 20 Feb 2026 13:47:30 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237609.1539850 (Exim 4.92) (envelope-from ) id 1vtYL5-0008Se-Iy; Fri, 20 Feb 2026 21:47:07 +0000 Received: by outflank-mailman (output) from mailman id 1237609.1539850; Fri, 20 Feb 2026 21:47:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL5-0008SW-EX; Fri, 20 Feb 2026 21:47:07 +0000 Received: by outflank-mailman (input) for mailman id 1237609; Fri, 20 Feb 2026 21:47:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL4-0008Ew-An for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:06 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2a20ada-0ea5-11f1-b164-2bf370ae4941; Fri, 20 Feb 2026 22:47:05 +0100 (CET) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4834826e5a0so29346975e9.2 for ; Fri, 20 Feb 2026 13:47:05 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:03 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2a20ada-0ea5-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624025; x=1772228825; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jDPL04AxDc8Xafccu1ZVRQiZUTvtnTnKwY+v0GkBCrE=; b=Ji2GEFyPAZ3Ns9pvX2Of+s46mxwkpdcPtoXIxxk0svZSdwXS5RUddD/zEj4LRs7dRd LBhVjCn3P1n0gtbIAeNITqJ5rvs7woU453b/TpRZM+xm/tunb1eNfC2t0NAF1KYvH44w yTMggrHCWWqn3R/fmHJQs8SXG5H04Kwj7r2Tk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624025; x=1772228825; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jDPL04AxDc8Xafccu1ZVRQiZUTvtnTnKwY+v0GkBCrE=; b=eZRnDdXdqskNblg2lNBZT6HTvrjyqzD+H13RDCtizGou2zwx8ULfEw2OBC9AFdGRP3 M6W9IT3gkPItztdVKlzd18p+X/EywCnSF3p2JgpjMEiy6uIfj6RUdkNiK12hOSfBOvSh +r3FugzF3FzfVz1E0lJ7y6C7ExQhCw6rjLV+kGInB6EivBnvYgzsiY2k6a3ZtZTzvmga w1Efb2lSFj8vs7TGmrXF8mAKetuAxll2cMbzDO78EjJDf7XnHHwNt76wvA8YcUYE5QFF aFJ2lBJMLch88vWWU/pjxsalpNipVNKyFUt/3ALsl52WnBVdFR/bWPBFwCKZTG64yf2c ORzQ== X-Gm-Message-State: AOJu0Yz7Hmi6JQFPVS8EoMT5XlkAEZ71SuRu9DTD0PXlyIWtosB9mo3Q HDG/7dSLZjJcqQrMidD4N9LOPhZiWvCFAwb604Hhf3vZAi8xzo6hpLfhCumSFx2OvFdd7LKvWhs oMEz+Ef/1zQ== X-Gm-Gg: AZuq6aIX95OOjm//yzhFosaDE7YGnn4F1uwh/Q7xbtZyYnulaOIi6ibCSaRo6Aoh8CD kFWTPYs/sENDCzGeCtqWwWvu4MD3NSExDwqatJpJ9qEHBASwjVivuBkikd4FPc6Dzlli8SHjZnJ iSZYpNk8a/EimAy4B2v2rB6H2mzkWFisUcMGmQZJdnYLjzvSXGXRL9DxKU7gTU3/MPBOik+ybtW T+8qGFcuy0t/fR4kBS312ePqx1jOxj5kPTFtZbou2GdMnxbxC57W56xwLQmSLVDa4GiSyQ4UhFY v5FWNEeRhgDWlDee69KjSKp2IBJuEfs7M4k4UGGHCHiZSCHZQbQG1G393ghRLGTz1rA/YWI2jLU xNqpSxgT44YP5UMYEuqdZeu5pix/w3zTwr3MWzPWD9eKMCEgID9Pxlgv5T6jNizGkBVZ4k5+sH2 ka2cH1gMC2KB+/wFwTgO6z7FaehMOGA+abq/zxjUjElaOQe2PEovihXl4iifyx0jUuFwgFD4Q= X-Received: by 2002:a05:600c:6291:b0:477:9814:6882 with SMTP id 5b1f17b1804b1-483a95b5975mr16770775e9.5.1771624024597; Fri, 20 Feb 2026 13:47:04 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 02/12] xen/treewide: Adjust suffixes on integer literals Date: Fri, 20 Feb 2026 21:46:43 +0000 Message-Id: <20260220214653.3497384-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624051113158500 Use U where necessary (Misra Rule 7.2) and uppercase L (Misra Rule 7.3). No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/arm/gic-v3-its.c | 2 +- xen/arch/arm/include/asm/tee/optee_msg.h | 16 ++++++++-------- xen/arch/arm/include/asm/tee/optee_smc.h | 8 ++++---- xen/arch/arm/tee/optee.c | 6 +++--- xen/arch/x86/guest/xen/xen.c | 2 +- xen/arch/x86/include/asm/config.h | 2 +- xen/arch/x86/include/asm/guest/hyperv.h | 2 +- xen/arch/x86/pv/emul-gate-op.c | 2 +- xen/arch/x86/tboot.c | 4 ++-- xen/drivers/char/xhci-dbc.c | 14 +++++++------- 10 files changed, 29 insertions(+), 29 deletions(-) diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c index 34833166adcc..9ba068c46fcb 100644 --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -76,7 +76,7 @@ static const struct its_quirk its_quirks[] =3D { { .desc =3D "R-Car Gen4", .iidr =3D 0x0201743b, - .mask =3D 0xffffffff, + .mask =3D 0xffffffffU, .init =3D gicv3_its_enable_quirk_gen4, }, { diff --git a/xen/arch/arm/include/asm/tee/optee_msg.h b/xen/arch/arm/includ= e/asm/tee/optee_msg.h index fe743dbde3c8..09820ff8638c 100644 --- a/xen/arch/arm/include/asm/tee/optee_msg.h +++ b/xen/arch/arm/include/asm/tee/optee_msg.h @@ -222,10 +222,10 @@ struct optee_msg_arg { * Represented in 4 32-bit words in OPTEE_MSG_UID_0, OPTEE_MSG_UID_1, * OPTEE_MSG_UID_2, OPTEE_MSG_UID_3. */ -#define OPTEE_MSG_UID_0 0x384fb3e0 -#define OPTEE_MSG_UID_1 0xe7f811e3 -#define OPTEE_MSG_UID_2 0xaf630002 -#define OPTEE_MSG_UID_3 0xa5d5c51b +#define OPTEE_MSG_UID_0 0x384fb3e0U +#define OPTEE_MSG_UID_1 0xe7f811e3U +#define OPTEE_MSG_UID_2 0xaf630002U +#define OPTEE_MSG_UID_3 0xa5d5c51bU #define OPTEE_MSG_FUNCID_CALLS_UID 0xFF01 =20 /* @@ -246,10 +246,10 @@ struct optee_msg_arg { * Returns UUID in 4 32-bit words in the same way as * OPTEE_MSG_FUNCID_CALLS_UID described above. */ -#define OPTEE_MSG_OS_OPTEE_UUID_0 0x486178e0 -#define OPTEE_MSG_OS_OPTEE_UUID_1 0xe7f811e3 -#define OPTEE_MSG_OS_OPTEE_UUID_2 0xbc5e0002 -#define OPTEE_MSG_OS_OPTEE_UUID_3 0xa5d5c51b +#define OPTEE_MSG_OS_OPTEE_UUID_0 0x486178e0U +#define OPTEE_MSG_OS_OPTEE_UUID_1 0xe7f811e3U +#define OPTEE_MSG_OS_OPTEE_UUID_2 0xbc5e0002U +#define OPTEE_MSG_OS_OPTEE_UUID_3 0xa5d5c51bU #define OPTEE_MSG_FUNCID_GET_OS_UUID 0x0000 =20 /* diff --git a/xen/arch/arm/include/asm/tee/optee_smc.h b/xen/arch/arm/includ= e/asm/tee/optee_smc.h index 2f5c702326f7..39c04eb5ad1b 100644 --- a/xen/arch/arm/include/asm/tee/optee_smc.h +++ b/xen/arch/arm/include/asm/tee/optee_smc.h @@ -443,9 +443,9 @@ #define OPTEE_SMC_CALL_RETURN_FROM_RPC \ OPTEE_SMC_STD_CALL_VAL(OPTEE_SMC_FUNCID_RETURN_FROM_RPC) =20 -#define OPTEE_SMC_RETURN_RPC_PREFIX_MASK 0xFFFF0000 -#define OPTEE_SMC_RETURN_RPC_PREFIX 0xFFFF0000 -#define OPTEE_SMC_RETURN_RPC_FUNC_MASK 0x0000FFFF +#define OPTEE_SMC_RETURN_RPC_PREFIX_MASK 0xFFFF0000U +#define OPTEE_SMC_RETURN_RPC_PREFIX 0xFFFF0000U +#define OPTEE_SMC_RETURN_RPC_FUNC_MASK 0x0000FFFFU =20 #define OPTEE_SMC_RETURN_GET_RPC_FUNC(ret) \ ((ret) & OPTEE_SMC_RETURN_RPC_FUNC_MASK) @@ -548,7 +548,7 @@ OPTEE_SMC_RPC_VAL(OPTEE_SMC_RPC_FUNC_CMD) =20 /* Returned in a0 */ -#define OPTEE_SMC_RETURN_UNKNOWN_FUNCTION 0xFFFFFFFF +#define OPTEE_SMC_RETURN_UNKNOWN_FUNCTION 0xFFFFFFFFU =20 /* Returned in a0 only from Trusted OS functions */ #define OPTEE_SMC_RETURN_OK 0x0 diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c index 5151bd90ed02..699e8d536862 100644 --- a/xen/arch/arm/tee/optee.c +++ b/xen/arch/arm/tee/optee.c @@ -49,16 +49,16 @@ #define TEEC_ORIGIN_COMMS 0x00000002 =20 /* "Non-specific cause" as in GP TEE Client API Specification */ -#define TEEC_ERROR_GENERIC 0xFFFF0000 +#define TEEC_ERROR_GENERIC 0xFFFF0000U =20 /* * "Input parameters were invalid" as described * in GP TEE Client API Specification. */ -#define TEEC_ERROR_BAD_PARAMETERS 0xFFFF0006 +#define TEEC_ERROR_BAD_PARAMETERS 0xFFFF0006U =20 /* "System ran out of resources" as in GP TEE Client API Specification */ -#define TEEC_ERROR_OUT_OF_MEMORY 0xFFFF000C +#define TEEC_ERROR_OUT_OF_MEMORY 0xFFFF000CU =20 /* Client ID 0 is reserved for the hypervisor itself */ #define OPTEE_CLIENT_ID(domain) ((domain)->domain_id + 1) diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c index 77a3a8742a3e..315e5ded05ab 100644 --- a/xen/arch/x86/guest/xen/xen.c +++ b/xen/arch/x86/guest/xen/xen.c @@ -120,7 +120,7 @@ static void map_shared_info(void) =20 /* Mask all upcalls */ for ( i =3D 0; i < ARRAY_SIZE(XEN_shared_info->evtchn_mask); i++ ) - write_atomic(&XEN_shared_info->evtchn_mask[i], ~0ul); + write_atomic(&XEN_shared_info->evtchn_mask[i], ~0UL); } =20 static int map_vcpuinfo(void) diff --git a/xen/arch/x86/include/asm/config.h b/xen/arch/x86/include/asm/c= onfig.h index cc80f2c62310..1b28349a427b 100644 --- a/xen/arch/x86/include/asm/config.h +++ b/xen/arch/x86/include/asm/config.h @@ -200,7 +200,7 @@ #ifdef CONFIG_PV32 =20 /* This is not a fixed value, just a lower limit. */ -#define __HYPERVISOR_COMPAT_VIRT_START 0xF5800000 +#define __HYPERVISOR_COMPAT_VIRT_START 0xF5800000U #define HYPERVISOR_COMPAT_VIRT_START(d) ((d)->arch.pv.hv_compat_vstart) =20 #else /* !CONFIG_PV32 */ diff --git a/xen/arch/x86/include/asm/guest/hyperv.h b/xen/arch/x86/include= /asm/guest/hyperv.h index c05efdce71a4..dabc62727b44 100644 --- a/xen/arch/x86/include/asm/guest/hyperv.h +++ b/xen/arch/x86/include/asm/guest/hyperv.h @@ -11,7 +11,7 @@ #include =20 /* Use top-most MFN for hypercall page */ -#define HV_HCALL_MFN (((1ull << paddr_bits) - 1) >> HV_HYP_PAGE_SHIFT) +#define HV_HCALL_MFN (((1ULL << paddr_bits) - 1) >> HV_HYP_PAGE_SHIFT) =20 /* * The specification says: "The partition reference time is computed diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c index dcac0a04015b..1faf13b962b1 100644 --- a/xen/arch/x86/pv/emul-gate-op.c +++ b/xen/arch/x86/pv/emul-gate-op.c @@ -32,7 +32,7 @@ static int read_gate_descriptor(unsigned int gate_sel, return 0; =20 *sel =3D (desc.a >> 16) & 0x0000fffc; - *off =3D (desc.a & 0x0000ffff) | (desc.b & 0xffff0000); + *off =3D (desc.a & 0x0000ffff) | (desc.b & 0xffff0000U); *ar =3D desc.b & 0x0000ffff; =20 /* diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c index 9d9bb6e7cf6d..0b3d596690cc 100644 --- a/xen/arch/x86/tboot.c +++ b/xen/arch/x86/tboot.c @@ -41,8 +41,8 @@ static bool __ro_after_init is_vtd; * TXT configuration registers (offsets from TXT_{PUB, PRIV}_CONFIG_REGS_B= ASE) */ =20 -#define TXT_PUB_CONFIG_REGS_BASE 0xfed30000 -#define TXT_PRIV_CONFIG_REGS_BASE 0xfed20000 +#define TXT_PUB_CONFIG_REGS_BASE 0xfed30000U +#define TXT_PRIV_CONFIG_REGS_BASE 0xfed20000U =20 /* # pages for each config regs space - used by fixmap */ #define NR_TXT_CONFIG_PAGES ((TXT_PUB_CONFIG_REGS_BASE - = \ diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 1f7d4395dc9d..c1ff528de62f 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -353,8 +353,8 @@ static bool __init dbc_init_xhc(struct dbc *dbc) cmd =3D pci_conf_read16(dbc->sbdf, PCI_COMMAND); pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd & ~PCI_COMMAND_MEMORY); =20 - pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, 0xFFFFFFFF); - pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, 0xFFFFFFFF); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, 0xFFFFFFFFU); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, 0xFFFFFFFFU); bar_size =3D pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_0); bar_size |=3D (uint64_t)pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_1)= << 32; xhc_mmio_size =3D ~(bar_size & PCI_BASE_ADDRESS_MEM_MASK) + 1; @@ -398,7 +398,7 @@ static struct dbc_reg __iomem *xhci_find_dbc(struct dbc= *dbc) * This is initially an offset to the first capability. All the offsets * (both in HCCP1 and then next capability pointer) are dword-based. */ - next =3D (readl(hccp1) & 0xFFFF0000) >> 16; + next =3D readl(hccp1) >> 16; =20 while ( id !=3D DBC_ID && next && ttl-- ) { @@ -735,7 +735,7 @@ static void dbc_init_ep(uint32_t *ep, uint64_t mbs, uin= t32_t type, memset(ep, 0, DBC_CTX_BYTES); =20 ep[1] =3D (1024 << 16) | ((uint32_t)mbs << 8) | (type << 3); - ep[2] =3D (ring_dma & 0xFFFFFFFF) | 1; + ep[2] =3D (uint32_t)ring_dma | 1; ep[3] =3D ring_dma >> 32; ep[4] =3D 3 * 1024; } @@ -816,7 +816,7 @@ static void dbc_reset_debug_port(struct dbc *dbc) * This is initially an offset to the first capability. All the offsets * (both in HCCP1 and then next capability pointer are dword-based. */ - next =3D (readl(hccp1) & 0xFFFF0000) >> 16; + next =3D readl(hccp1) >> 16; =20 /* * Look for "supported protocol" capability, major revision 3. @@ -1094,7 +1094,7 @@ static void dbc_enqueue_in(struct dbc *dbc, struct xh= ci_trb_ring *trb, struct dbc_work_ring *wrk) { struct dbc_reg *reg =3D dbc->dbc_reg; - uint32_t db =3D (readl(®->db) & 0xFFFF00FF) | (trb->db << 8); + uint32_t db =3D (readl(®->db) & 0xFFFF00FFU) | (trb->db << 8); =20 /* Check if there is already queued TRB */ if ( xhci_trb_ring_size(trb) >=3D 1 ) @@ -1289,7 +1289,7 @@ static void cf_check dbc_uart_resume(struct serial_po= rt *port) struct dbc_uart *uart =3D port->uart; struct dbc *dbc =3D &uart->dbc; =20 - pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, dbc->bar_val & 0xFFFFF= FFF); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, dbc->bar_val); pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, dbc->bar_val >> 32); pci_conf_write16(dbc->sbdf, PCI_COMMAND, dbc->pci_cr); =20 --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624049; cv=none; d=zohomail.com; s=zohoarc; b=dkl+AAiWYnBWxye6kBCrkV+ZT7zaNX7Qj4rXLlAmjOXvKUjNJH7WHvZeLP7756LYLtN+FCxEpoh0Vl1/Odo/8lTW9GANhcdF7xHAx9KlioecarvaljPWfJX083Zc+l5NZRAUT/x2dvKBGdb44MnvOrraoKSsGoIigl6po++WBMk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624049; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=F7fA2pJ5wU91qVSnLRts4j2C2n/06cd+/6bA5bE+4M0=; b=gYqz+cS59731nsJCsjqZG1vVR0LOw4GKGCjAZJ9/J/St/ryioGcbOio57gUNHkLiPRUmZjQiUFYrmOyzZcj2uL5WWx0sC/P0P9l2SjhrX9yjsrmUA9yAPIdbcl2YSUMaQBjnhpoOjURKjR51WOyFDBGq7GtBfOZkbFNCWWgtacU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624049663163.4152175141336; Fri, 20 Feb 2026 13:47:29 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237611.1539868 (Exim 4.92) (envelope-from ) id 1vtYL7-0000TE-12; Fri, 20 Feb 2026 21:47:09 +0000 Received: by outflank-mailman (output) from mailman id 1237611.1539868; Fri, 20 Feb 2026 21:47:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL6-0000T3-Up; Fri, 20 Feb 2026 21:47:08 +0000 Received: by outflank-mailman (input) for mailman id 1237611; Fri, 20 Feb 2026 21:47:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL5-0008Ew-Bg for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:07 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b309dc2b-0ea5-11f1-b164-2bf370ae4941; Fri, 20 Feb 2026 22:47:06 +0100 (CET) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-48371119eacso24629185e9.2 for ; Fri, 20 Feb 2026 13:47:06 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:04 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b309dc2b-0ea5-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624025; x=1772228825; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F7fA2pJ5wU91qVSnLRts4j2C2n/06cd+/6bA5bE+4M0=; b=P+n+Jw261ki3egld4sClFtEsttya0CKtnHY0fjtiQDUcqumvNYTw7kstErSWq9lOTL TALtfUpfIu3dOenbls9IFLPu9TOHtXbwLKPemXmvcoR4TMrvmCFTqVxao+d9ONSJr18q ZHozBulh3BnPltcJxS/fGhlalKyxpiPC/Bw/M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624025; x=1772228825; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F7fA2pJ5wU91qVSnLRts4j2C2n/06cd+/6bA5bE+4M0=; b=OaB0e5ePqL2N7McG+sfJComQ59HIxmb8x6OXZWucT1grfs97HEAzx9aBf8JaiMANmf 6ySmiYTdyGMHnaF3k3yFWWEVfQgY7s5RjWUy3L2q7X9H8PxrPpsBFg6Ytxbs9o75ZZnu s+GoeRlOasmrM8FIY0Y6+r0q7fXdgcHrYgha5B8IJ/418G+pRhMyfI/VbWZ8Pls9sHbr zs+x4B2bU8ill1swSb/yYUIBr4VRPIRfnj5W0sE+1/GXnrvUGUV6Iw0KyJ9b/IV8rD/F uo78fmoy8pM/RVPqdS2yymqq821ZCfEJ5SVckLdr34koPwpsfSkffD3TQLHy9NecCg8q mSyQ== X-Gm-Message-State: AOJu0YyJdqi6wIXM+LRnvXhIsPsvwbn2cR0ZHJUTVo6fNZlFKzJfStuc x27OP9osicnYDBt/TZpM5RODQqqYMk9aZVX+BxGbAQF1vzce9NebObVT4+lqzqWRCT7nZwZohmA ZvFUVA+1D8g== X-Gm-Gg: AZuq6aLhvuAi5xMtiorQK/45A2MlTdhwnbLt2m8NvpDsaaqjWIbHxVXWETEwMn9qnsC mCEd96jRHs6UK65bAaXtdS/IzYUIrDEydfCUBgzljKpLbiYFJVk3zZLo9MrzZgqtkEoILNCX4FG L9GOc8lSPZ8FsAg0AfKHUc5UfS4u31nK2nyxa0TGhwYoptZdYwvreQ5mr5CbgTLTxfDeCsKZVdk 2UKqLGkfMd9c/3px8Ftn+kVE2HYbzZvU5xCiiNKm+bapFeD17evvnB/kMH1rc7tAnso+STxAlOT IFQnOBLNj0RLYS/MIggAu4tQl5cHrrORwkv5pYOVKVjQ5pjsyzHqTnXotpHnufaVxHE8lm40FMT pBN5zmZ/lEpucyZhlyH2Uh93HXvYO1cGV5HYfLULt0stY8Td+GuTrdi6hJufLEy3zan9mPyFZxR /RJ5Qqe5+6hnJ2nVOAPGIBID1yjbKuZf66yaq3IkEnklci0/mUy2q1mjvUV4p/jnitbAAagnQ= X-Received: by 2002:a05:600c:c4a5:b0:483:a2ce:f461 with SMTP id 5b1f17b1804b1-483a95eb453mr15945185e9.4.1771624025257; Fri, 20 Feb 2026 13:47:05 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 03/12] xen/argo: Fix MISRA violations around function parameters Date: Fri, 20 Feb 2026 21:46:44 +0000 Message-Id: <20260220214653.3497384-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624051000158500 For the ARM build only, Eclair reports a R8.4 violation because do_argo_op() cannot see its declaration. This means that x86 is picking hypercall-defs.h up transitively while ARM is not. Include xen/hypercall.h explicitly. Eclair also reports a R8.3 violation because of arg3 and arg4 differing in name with a raw_ prefix. Because hypercall-defs.h generates both do_argo_o= p() and compat_argo_op() from a single description, it's not possible to simply rename to raw_ in the declaration, as that would force doing the same rename in compat_argo_op(). In do_argo_op(), drop the split parameter handling, and perform the 32bit range check via an explicit cast. While adjusting the surrounding logic, d= rop unnecessary casts to void * for already pointer arguments in argo_printk(). No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/common/argo.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/common/argo.c b/xen/common/argo.c index 029a82825ba8..28626e00a8cb 100644 --- a/xen/common/argo.c +++ b/xen/common/argo.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include @@ -2084,18 +2085,17 @@ sendv(struct domain *src_d, xen_argo_addr_t *src_ad= dr, =20 long do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, - XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long raw_arg3, - unsigned long raw_arg4) + XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3, + unsigned long arg4) { struct domain *currd =3D current->domain; long rc; - unsigned int arg3 =3D raw_arg3, arg4 =3D raw_arg4; =20 argo_dprintk("->do_argo_op(%u,%p,%p,%lu,0x%lx)\n", cmd, - (void *)arg1.p, (void *)arg2.p, raw_arg3, raw_arg4); + arg1.p, arg2.p, arg3, arg4); =20 /* Reject numeric hypercall args outside 32-bit range */ - if ( (arg3 !=3D raw_arg3) || (arg4 !=3D raw_arg4) ) + if ( (arg3 !=3D (uint32_t)arg3) || (arg4 !=3D (uint32_t)arg4) ) return -EINVAL; =20 if ( unlikely(!opt_argo) ) @@ -2248,7 +2248,7 @@ compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PAR= AM(void) arg1, return rc; =20 argo_dprintk("->compat_argo_op(%u,%p,%p,%lu,0x%lx)\n", cmd, - (void *)arg1.p, (void *)arg2.p, arg3, arg4); + arg1.p, arg2.p, arg3, arg4); =20 send_addr_hnd =3D guest_handle_cast(arg1, xen_argo_send_addr_t); /* arg2: iovs, arg3: niov, arg4: message_type */ --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624051; cv=none; d=zohomail.com; s=zohoarc; b=Fu9jpru8z7wjUQU7hWzLPQ+MHuf0YSO+2+Zm7IVGiLTIe1JqqfPBiuarf9EKguhY81p4TYGeweE7yqaEs35FdO0T1RkFJjJl2JzQSjTmaU/rD13bRP2at4ZTsDKhlSXb10xL1vJtMLxxX4yskc/tR4EGUtUTMTPqKeG0SCuWzIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624051; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=beuTbfe9kV1Ouyfxy/gjE8egNOMK+gVzuCqzx8daylA=; b=ZF0XqQiuawkcKF0NYw8MHoXgvAQr3n/P1IBhijUrBVms7qJstQxxFdtfOK1qiJ4L8RFEHiSkH3Q4xI8zp3fOh5B4yxp8qE1UKXmrX5Npkuyxe9H2PvkD53OWhunS4nj2nT/DqABtdr9pgryIInPK4TbuO/cxL5EDNpVB3JkuWLo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624051189271.41876792092455; Fri, 20 Feb 2026 13:47:31 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237613.1539883 (Exim 4.92) (envelope-from ) id 1vtYL8-0000lh-TN; Fri, 20 Feb 2026 21:47:10 +0000 Received: by outflank-mailman (output) from mailman id 1237613.1539883; Fri, 20 Feb 2026 21:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL8-0000kN-JK; Fri, 20 Feb 2026 21:47:10 +0000 Received: by outflank-mailman (input) for mailman id 1237613; Fri, 20 Feb 2026 21:47:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL7-0008IG-8g for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:09 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3d11e93-0ea5-11f1-9ccf-f158ae23cfc8; Fri, 20 Feb 2026 22:47:07 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-482f454be5bso33419175e9.0 for ; Fri, 20 Feb 2026 13:47:07 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:05 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3d11e93-0ea5-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624027; x=1772228827; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=beuTbfe9kV1Ouyfxy/gjE8egNOMK+gVzuCqzx8daylA=; b=BMiR/T+WEvvW5iGsKAdgfi+cPActfn8vFvDu97HWE0xiqgu3PSNY7LK2RjwCHIGzDl mmO5MGekILMGQOVadEMiwyzuSymZgpES00rTNtDjcGOvq+sP9S4JrVgxkoR8tjIuFFg6 y2ygy7gCQ/aQb9W0TAqByris1EsG8MDxDK4GE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624027; x=1772228827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=beuTbfe9kV1Ouyfxy/gjE8egNOMK+gVzuCqzx8daylA=; b=ef7zwv9kOpaDwizhAtPxmwwQIbkuW8TJR4LaD2yGYkhNU5HmQonLPJLKlnoffICbE3 WPXUYygXOjMcKiMyrRO+OPISyzgIC9Uv992lnsXyUlZmdY8UB1UcxoCQMTK5hO5I6xr2 DJO5K8asFrk1npquct2kyCNA4pAOSIDzhfgDVvQKE1bVPeEB531XuWRkOWgRwKdo80VG UVh77IfE/BCvelJgDa34p41RWpdxCxMvmtvcw2qhR0oeOSUiy1A9YHB88ePs2gLegU2P wII8af5oVmnCoaX3zNDFoYg0T9njVfXxol1pvNwfVW6E7xc2f/jpEdjIFxyscglpnSHv IDxA== X-Gm-Message-State: AOJu0Yx+ph2GtDPum6vR6IYgN/LhR9+DCXS1fzWFgoT4BoQkK1Bh1R7M BClaXq/nqbPU66r28q36nCPP1ItN0x8Qs/4VTbbawG5TDSQkNi7zIrJGbhpE7ckvp3ChMqkIMoG FWcug X-Gm-Gg: AZuq6aJ4get2Cv4QPIfRMmil837pY/iZiHLZsERPVCmMPIlMCSkOmOpOHLnPvTXidLz gKFst0iC8osqgJqOdRZrneymSHG5uL0dQBgPrRUeSzrFpWI4LCkly2HAem50ohcbam8En6lRTBW RaZI2a86HR2EICn/1SaKEKfz9r8sL8rYRI2Ybnkp/xOsaeAx5sUU11VL28QsiaLHZbofH7KHzSR JE6oRTNDFNql54fy1qrm/J/Q8UyJgX8bD/oHGerFtg86sbRJjmRGDGS0cFcxWpVdlJY4q14gs6e V4GJo0s6AmbRgRT1D9zTxdrxts/R87oreLgtcaJGJYx4Vnou1FA2rFZsfrsSlo0Fc5qCXC3WPtb SvyamgZ6PjQTJNQ+/zl3Zw5EDBIaLDmTuhCDfQtQjnf+hNLtoFhvTyoy05U7iGxqcp4kxFQ8Joc TIKLa+iZxryOjg/12dvP3LKFZGD4SQ153TCuD52K6jYhVk+5vxFZfox9JK20Z3aPP5ILjHH3w= X-Received: by 2002:a05:600c:1c29:b0:483:6d9e:e4f5 with SMTP id 5b1f17b1804b1-483a949e5edmr17807355e9.5.1771624025939; Fri, 20 Feb 2026 13:47:05 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 04/12] xen/treewide: Adjust parameter names and types Date: Fri, 20 Feb 2026 21:46:45 +0000 Message-Id: <20260220214653.3497384-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624053073158500 MISRA Rule 8.2 says that parameters must all have names. Rule 8.3 says that the names and types must match between declaration and definition. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/arm/include/asm/pci.h | 2 +- xen/arch/arm/pci/pci-access.c | 4 ++-- xen/arch/x86/include/asm/compat.h | 2 +- xen/arch/x86/include/asm/p2m.h | 2 +- xen/arch/x86/mm/mem_paging.c | 2 +- xen/crypto/vmac.c | 2 +- xen/include/crypto/rijndael.h | 16 ++++++++-------- xen/include/xen/acpi.h | 2 +- 8 files changed, 16 insertions(+), 16 deletions(-) diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 08ffcd443862..73c3be74aef1 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -98,7 +98,7 @@ struct pci_ecam_ops { unsigned int bus_shift; struct pci_ops pci_ops; int (*cfg_reg_index)(struct dt_device_node *dev); - int (*init)(struct pci_config_window *); + int (*init)(struct pci_config_window *cfg); }; =20 /* Default ECAM ops */ diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c index 4a9486750199..c0533c00c9a5 100644 --- a/xen/arch/arm/pci/pci-access.c +++ b/xen/arch/arm/pci/pci-access.c @@ -135,9 +135,9 @@ static void pci_config_write(pci_sbdf_t sbdf, unsigned = int reg, =20 #define PCI_OP_WRITE(size, type) \ void pci_conf_write##size(pci_sbdf_t sbdf, \ - unsigned int reg, type val) \ + unsigned int reg, type data) \ { \ - pci_config_write(sbdf, reg, size / 8, val); \ + pci_config_write(sbdf, reg, size / 8, data); \ } =20 #define PCI_OP_READ(size, type) \ diff --git a/xen/arch/x86/include/asm/compat.h b/xen/arch/x86/include/asm/c= ompat.h index 30ed8f2fd0dc..f12f4f24d802 100644 --- a/xen/arch/x86/include/asm/compat.h +++ b/xen/arch/x86/include/asm/compat.h @@ -16,7 +16,7 @@ typedef unsigned long full_ptr_t; =20 struct domain; #ifdef CONFIG_PV32 -int switch_compat(struct domain *); +int switch_compat(struct domain *d); #else #include static inline int switch_compat(struct domain *d) { return -EOPNOTSUPP; } diff --git a/xen/arch/x86/include/asm/p2m.h b/xen/arch/x86/include/asm/p2m.h index ef6b02ff0bb6..92be64e134e8 100644 --- a/xen/arch/x86/include/asm/p2m.h +++ b/xen/arch/x86/include/asm/p2m.h @@ -773,7 +773,7 @@ static inline int relinquish_p2m_mapping(struct domain = *d) */ =20 /* Modify p2m table for shared gfn */ -int set_shared_p2m_entry(struct domain *d, unsigned long gfn, mfn_t mfn); +int set_shared_p2m_entry(struct domain *d, unsigned long gfn_l, mfn_t mfn); =20 /* Tell xenpaging to drop a paged out frame */ void p2m_mem_paging_drop_page(struct domain *d, gfn_t gfn, p2m_type_t p2mt= ); diff --git a/xen/arch/x86/mm/mem_paging.c b/xen/arch/x86/mm/mem_paging.c index ac8d34ffa074..d4b3cb990c54 100644 --- a/xen/arch/x86/mm/mem_paging.c +++ b/xen/arch/x86/mm/mem_paging.c @@ -156,7 +156,7 @@ void p2m_mem_paging_populate(struct domain *d, gfn_t gf= n) * * If the gfn was dropped the vcpu needs to be unpaused. */ -void p2m_mem_paging_resume(struct domain *d, vm_event_response_t *rsp) +void p2m_mem_paging_resume(struct domain *d, struct vm_event_st *rsp) { struct p2m_domain *p2m =3D p2m_get_hostp2m(d); p2m_type_t p2mt; diff --git a/xen/crypto/vmac.c b/xen/crypto/vmac.c index acb4e015f511..f1f6d75f8eeb 100644 --- a/xen/crypto/vmac.c +++ b/xen/crypto/vmac.c @@ -702,7 +702,7 @@ static uint64_t l3hash(uint64_t p1, uint64_t p2, =20 /* -----------------------------------------------------------------------= */ =20 -void vhash_update(unsigned char *m, +void vhash_update(unsigned char m[], unsigned int mbytes, /* Pos multiple of VMAC_NHBYTES */ vmac_ctx_t *ctx) { diff --git a/xen/include/crypto/rijndael.h b/xen/include/crypto/rijndael.h index 4386be587851..80c612749f9e 100644 --- a/xen/include/crypto/rijndael.h +++ b/xen/include/crypto/rijndael.h @@ -45,14 +45,14 @@ typedef struct { u32 dk[4*(AES_MAXROUNDS + 1)]; /* decrypt key schedule */ } rijndael_ctx; =20 -int rijndael_set_key(rijndael_ctx *, const unsigned char *, int); -int rijndael_set_key_enc_only(rijndael_ctx *, const unsigned char *, int); -void rijndael_decrypt(rijndael_ctx *, const unsigned char *, unsigned cha= r *); -void rijndael_encrypt(rijndael_ctx *, const unsigned char *, unsigned cha= r *); +int rijndael_set_key(rijndael_ctx *ctx, const unsigned char *key, int bit= s); +int rijndael_set_key_enc_only(rijndael_ctx *ctx, const unsigned char *key= , int bits); +void rijndael_decrypt(rijndael_ctx *ctx, const unsigned char *src, unsign= ed char *dst); +void rijndael_encrypt(rijndael_ctx *ctx, const unsigned char *src, unsign= ed char *dst); =20 -int rijndaelKeySetupEnc(unsigned int [], const unsigned char [], int); -int rijndaelKeySetupDec(unsigned int [], const unsigned char [], int); -void rijndaelEncrypt(const unsigned int [], int, const unsigned char [16], - unsigned char [16]); +int rijndaelKeySetupEnc(unsigned int rk[], const unsigned char cipherKey[]= , int keyBits); +int rijndaelKeySetupDec(unsigned int rk[], const unsigned char cipkerKey[]= , int keyBits); +void rijndaelEncrypt(const unsigned int rk[], int Nr, const unsigned char = pt[16], + unsigned char ct[16]); =20 #endif /* __RIJNDAEL_H */ diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h index 90635ba0f322..ca87cd15a824 100644 --- a/xen/include/xen/acpi.h +++ b/xen/include/xen/acpi.h @@ -75,7 +75,7 @@ typedef int (*acpi_table_handler) (struct acpi_table_head= er *table); typedef int (*acpi_table_entry_handler) (struct acpi_subtable_header *head= er, const unsigned long end); =20 unsigned int acpi_get_processor_id (unsigned int cpu); -char * __acpi_map_table (paddr_t phys_addr, unsigned long size); +char * __acpi_map_table (paddr_t phys, unsigned long size); bool __acpi_unmap_table(const void *ptr, unsigned long size); int acpi_boot_init (void); int acpi_boot_table_init (void); --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624054; cv=none; d=zohomail.com; s=zohoarc; b=W5MRb9nXiHv5eV9j/n3wj3m3rl851cuH+gDmP3dWf08LqENpYol9F7p+Y0Sqfdk1TfpQ44hIvyKyu3oLVwaS3je8RTGTMkILzZS5l6TDFGgQfSoviAz42Y9oEy9OAu8v6KjI46kivyYrmKlM/PyenjLOumOquhwIOiaiHtqVECQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624054; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=++I7y0Fz5SNLOYdyOKbflTxyKYPA97MXE/g2maqbcaQ=; b=ExNKjI52VZvooy7xrS3OCtAXvE40oms8UTeo5Dd0mg3WiDvwp3E6e7odR/uQlRHHYP3p43DLSkwO5R4vwQmEBjt6p7DuzljdUK2e2rjQ98R+sbF8m/Qi1V6pj81/ENEB/xoN7xOOPSWZpIM1SgYyhKf1kI6fcoCzOQ83J92QSoY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624054745241.91283755267511; Fri, 20 Feb 2026 13:47:34 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237612.1539878 (Exim 4.92) (envelope-from ) id 1vtYL8-0000hw-BE; Fri, 20 Feb 2026 21:47:10 +0000 Received: by outflank-mailman (output) from mailman id 1237612.1539878; Fri, 20 Feb 2026 21:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL8-0000hl-7B; Fri, 20 Feb 2026 21:47:10 +0000 Received: by outflank-mailman (input) for mailman id 1237612; Fri, 20 Feb 2026 21:47:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL6-0008Ew-MR for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:08 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b3e4ef94-0ea5-11f1-b164-2bf370ae4941; Fri, 20 Feb 2026 22:47:07 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-481188b7760so21122925e9.0 for ; Fri, 20 Feb 2026 13:47:07 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:06 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3e4ef94-0ea5-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624027; x=1772228827; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=++I7y0Fz5SNLOYdyOKbflTxyKYPA97MXE/g2maqbcaQ=; b=vk25ojic1m2Jr1Uc8xYH10oJ60/hXch9uMSBQg3XYs+ArESqN1Jobwlh+i9WbcMkJC 1BWuzTsCn8SRnZw8+lv+KGFpLgQLIeEFB7BDhk1xZ47Q5EY2VneDqLVS/OwGlT5EBg0/ H+i7AaNAvsUpWWDD3kZYsFpz7bDG8v1eBNCv4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624027; x=1772228827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=++I7y0Fz5SNLOYdyOKbflTxyKYPA97MXE/g2maqbcaQ=; b=r5LEQHMP2sG3j3KAtIno4R85Q1vmMaqLlA2AnpWHljv8HBmS2ZAtx/AkYAO1cetK/g 7ushFvrZli0yccEd1HbezUJ78Di/OiBHxhoKhyaI/RN3FceIGYOyU1bDo9kmqf6IwgMJ NBE9k4Ib70wcQB6ylSAXTDpiRCaJdZ9lS4bGJJyLONv70yWaAQW2EJRZ5nPnBqiLAQxu 3GlQacUVoPCdm+RPNbMl+j23PzDzl4NhPIXnTgRohyH/TvzFi4DaHA0mHXaZmJ2S9kGd 89L8bDMSHcr/OLrIzUh1tf4I2zjyShaApaPnE3MRqpXMIPT6NF0GzX1h5jLSST+HVML+ 0bQQ== X-Gm-Message-State: AOJu0Yw9S7Auah2bvufiBVkJaPFLm8wu02NbU92xM8pmerphK7V8gCR/ WaDdKRvLwfByp4rpSHxV5RNPLP8Tb8zmfCsF5Sh+2tjht1FK/9jqrFyOIgBMwva/watqost0r26 FiZix2KTO4w== X-Gm-Gg: AZuq6aJK9wGs05svOVMGYz15WGlSaU84M3aHLBhSr3Ju5/iFFpAIUo7Dt5iApcXEi1b NjNWhsd0L+yQAA8OoiKx1HY4iWlvUDyFAPhJiDHs7h1o1/p1xnR1mma32TFJrtjchluoORIEgDc JRbicZ8tPdQUqIhVKtLrrJAebGNyzPVnDc8Yqob3tDJSgZFVSkxVVn+Jqgur8HVzU09ygrcgtDv 85tL56JNb5PlAUz665KSPY6iVzgT3ZysfQ7hHOhfs3aARnnYDrcTXOmySkkdEvWqNbaaPMAVM9U BjEnjAcojRxgfDIXBlKZYfeRuH8PqEZwPJSwND5c0JDjyq6TaCP+xS9+U/6GBR9l/6hlrjQ/dbX M0h9jgKu/g0/N3GbdHtSnjIv7U2l5gtVOzw09T4lrnnFYXi6D23dvYuwLpaU463rXx5qAD9aECM Ihx8FDVZ4/CHKwUKkJTsh0//ZixZBbyFl3a4avMkeAkYxZ96QCgxKz/nWisqFDHPAhZjsI5aw= X-Received: by 2002:a05:600c:8b2c:b0:480:1b1a:5526 with SMTP id 5b1f17b1804b1-483a95e24ebmr19094485e9.16.1771624026566; Fri, 20 Feb 2026 13:47:06 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 05/12] x86: Adjust annotations of asm-used identifiers Date: Fri, 20 Feb 2026 21:46:46 +0000 Message-Id: <20260220214653.3497384-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624055014158500 do_entry_int82() is only called by assembly so gains asmlinkage. pvh_start_info_pa and early_hypercall_insn are data used by assembly, and n= eed a SAF-1 annotation. For the remaining SAF-1 anntations on functions, convert them to asmlinkage for consistency. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/boot/cmdline.c | 3 +-- xen/arch/x86/boot/reloc.c | 3 +-- xen/arch/x86/guest/xen/pvh-boot.c | 2 +- xen/arch/x86/guest/xen/xen.c | 2 +- xen/arch/x86/pv/hypercall.c | 2 +- xen/arch/x86/traps.c | 3 +-- 6 files changed, 6 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c index 196c580e9151..5db5c7b20bf6 100644 --- a/xen/arch/x86/boot/cmdline.c +++ b/xen/arch/x86/boot/cmdline.c @@ -334,8 +334,7 @@ static void vga_parse(const char *cmdline, early_boot_o= pts_t *ebo) } #endif =20 -/* SAF-1-safe */ -void cmdline_parse_early(const char *cmdline, early_boot_opts_t *ebo) +void asmlinkage cmdline_parse_early(const char *cmdline, early_boot_opts_t= *ebo) { if ( !cmdline ) return; diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c index 7a375ad41c1c..82c2d237aab6 100644 --- a/xen/arch/x86/boot/reloc.c +++ b/xen/arch/x86/boot/reloc.c @@ -346,8 +346,7 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, me= mctx *ctx) return mbi_out; } =20 -/* SAF-1-safe */ -void *reloc(uint32_t magic, uint32_t in) +void *asmlinkage reloc(uint32_t magic, uint32_t in) { memctx ctx =3D { trampoline_phys + TRAMPOLINE_HEAP_END }; =20 diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh= -boot.c index e14d7e20e942..8d8f4a34e445 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -22,7 +22,7 @@ =20 /* Initialised in head.S, before .bss is zeroed. */ bool __initdata pvh_boot; -uint32_t __initdata pvh_start_info_pa; +uint32_t __initdata pvh_start_info_pa; /* SAF-1-safe */ =20 static multiboot_info_t __initdata pvh_mbi; static module_t __initdata pvh_mbi_mods[8]; diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c index 315e5ded05ab..8e13c2fbf307 100644 --- a/xen/arch/x86/guest/xen/xen.c +++ b/xen/arch/x86/guest/xen/xen.c @@ -40,7 +40,7 @@ DEFINE_PER_CPU(struct vcpu_info *, vcpu_info); * 0 vmcall * > 0 vmmcall */ -int8_t __initdata early_hypercall_insn =3D -1; +int8_t __initdata early_hypercall_insn =3D -1; /* SAF-1-safe */ =20 /* * Called once during the first hypercall to figure out which instruction = to diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c index 17581d232e19..b3b9a3255531 100644 --- a/xen/arch/x86/pv/hypercall.c +++ b/xen/arch/x86/pv/hypercall.c @@ -180,7 +180,7 @@ void pv_ring1_init_hypercall_page(void *p) } } =20 -void do_entry_int82(struct cpu_user_regs *regs) +void asmlinkage do_entry_int82(struct cpu_user_regs *regs) { if ( unlikely(untrusted_msi) ) check_for_unexpected_msi((uint8_t)regs->entry_vector); diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 3c01c5eb53b5..29ea6054abab 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1336,8 +1336,7 @@ void asmlinkage do_int3(struct cpu_user_regs *regs) pv_inject_hw_exception(X86_EXC_BP, X86_EVENT_NO_EC); } =20 -/* SAF-1-safe */ -void do_general_protection(struct cpu_user_regs *regs) +void asmlinkage do_general_protection(struct cpu_user_regs *regs) { #ifdef CONFIG_PV struct vcpu *v =3D current; --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624059; cv=none; d=zohomail.com; s=zohoarc; b=fydgjiYXueeS/cWteG4VNeLYYxkk6M6uSfGgNcJDG0ZahdHdHCROuYLpmeE1X8fuQ3wg7NJOCD0lH118k/+5aYXQ/9nvxi/7FKTYI7Fj8nnmN8jyRtFaoMBydx2/JFfnwjQJf/j0kUVinWUnBaKajvu/0ORSA3DdCGeR9zWuJIU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624059; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=38Q6mGCwbKjhhK8kwdPI5HfU9QB1AsZ0yVRPxRPU2XA=; b=DgiSmGWPZW0qEQqNyMa16LE6TilLPeseLW+4OuueFu0+jnUO7Gc1DhJgzTNT8F9HnYrj1lNn+MjEEvllJ5gyfDLEgZ1uthBscqiCJvjTy9opzwYXFmke48/8c6wpNWQFCk0DUOU5LbtV/GGMgiIS/PlC20wcWZg2KdxzajfWnpc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 177162405902525.407097365584036; Fri, 20 Feb 2026 13:47:39 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237614.1539889 (Exim 4.92) (envelope-from ) id 1vtYL9-0000nM-Ac; Fri, 20 Feb 2026 21:47:11 +0000 Received: by outflank-mailman (output) from mailman id 1237614.1539889; Fri, 20 Feb 2026 21:47:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL8-0000mO-Sm; Fri, 20 Feb 2026 21:47:10 +0000 Received: by outflank-mailman (input) for mailman id 1237614; Fri, 20 Feb 2026 21:47:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL8-0008IG-4a for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:10 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b433f758-0ea5-11f1-9ccf-f158ae23cfc8; Fri, 20 Feb 2026 22:47:08 +0100 (CET) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-482f454be5bso33419435e9.0 for ; Fri, 20 Feb 2026 13:47:08 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:06 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b433f758-0ea5-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624027; x=1772228827; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=38Q6mGCwbKjhhK8kwdPI5HfU9QB1AsZ0yVRPxRPU2XA=; b=I5uwAh+6sicY4jOD/nMZRlwFvDLFYB3wwyJodfcP4iGUWiFCQODI1Z/6jNVjS7Cp6a TfoSIIcNQgn8tVWRU4b2Ov+UaiulA2J5DLjiZbE6u2cs0IBkgG/2q9L+u97FZ9BVXgjR +GtSz+hLhE6DbJqIyqcmYp8TtG02CsJmrp93M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624027; x=1772228827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=38Q6mGCwbKjhhK8kwdPI5HfU9QB1AsZ0yVRPxRPU2XA=; b=Oh8QheO174nVZ3g+Z54X0Pw+SMbejOe6xQTSkr7jgHFlE3IpDul+ifZH3LPHUlrDMY i3judnK3yepxQEe1AFpRFchgpNOKMGY59DLjR/y5mxyQ7OBt/1MlP3iSpI3NQJ1G0vbb QfixbGP/CnQUF8cZiyEcrFvFbMd288IS7IzNl2ptW581OTT0sGYOLa0yhpVSID9Djl9F Tv1KKqG7lYu1R9wNYABZMYMQm3aQQL2m8n65jOiphlaYJM0FaEAFVeGGWhiLMgnx6tsg qbUoCucersE+3cTjM0ziEhQefO5GrCZjgt4AIAj1Luq7zh8QkVrLCuP3YIydlZxtl833 KMbw== X-Gm-Message-State: AOJu0YzEn8xWv7hH0yytfIEtLOEub0id7PQgkQ5MFuNDhjqVwyxDDj0h un9O2XWlQVpNbgLxSNMcpgJAdtUX3uBThOv0iXCsFYBBLprpu2jX4h1JAk/e5e24PfZac2QSU62 O9d7gQNI3hA== X-Gm-Gg: AZuq6aK/PcnT4dHqJKcMop8WMVR9YekwNIpMYuu7wrFtuv6LD9/IeIWQnJD7U94z2+G hfHZbeCWMKQqdtCoIDjMgnBU+XMC+I0i6GmpP+lW2vfBSMDTPSZ29GFRewtapEQchCxBqiNUKRa 9rqNRStA4rBmafCOdloFpOXVjaoY9H4caWr4Ft3Rek/VR+/cJznSOPNSIBi/mcB2RXydfk0rsFo SqCb7ynYCkGHNqs9Lk4s7aivVEu0FAXO1OQqTqcSwGIhO6rnbpZtxmnGiyGTT8XuZ4AJcDyS25z DDewoHqFW86qGua9sEzzyyRSHqy0m1zNA3tMIWViX2xIhzBBUWKTOxyQr/ZJz1Ey9iwzzzzMRut 02j/KGriRB7A4dzXKcS6nEDQoZL3Mq2QDV5k+84GhhO9ynz/LEZUVRjAKD5nakkHUhKB8A3mnWB 8WcYJf93C9PYtx+h0+Pmj4ngso+FnHJFjED4vdSdtRxj+qxA75wT+IQzVibW+TaOCzkLAhbBc= X-Received: by 2002:a05:600c:1989:b0:479:1348:c63e with SMTP id 5b1f17b1804b1-483a94c99admr21112605e9.9.1771624027207; Fri, 20 Feb 2026 13:47:07 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 06/12] xen: Include suitable headers to make declarations visible Date: Fri, 20 Feb 2026 21:46:47 +0000 Message-Id: <20260220214653.3497384-7-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624061116158500 A range of functions can't see their declarations, requiring the inclusion = of appropriate headers. For pv/mm.h and pv/traps.h, this requires adjustements to become standalone. In pv/mm.h, swap xen/lib.h for xen/bug.h now that ASSERT_UNREACHABLE() has moved. For pv/traps.h, pv_trap_callback_registered() needs to see a comple= te struct vcpu, and xen/sched.h is not something appropriate to pull in conditionally. stack-protector.c can't see the declaration of __stack_chk_guard, and fixing that reveals that stack-protector.h needs get_cycles() too. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/include/asm/pv/mm.h | 8 +++++++- xen/arch/x86/include/asm/pv/traps.h | 6 ++---- xen/arch/x86/mm/mem_paging.c | 6 ++++-- xen/arch/x86/pv/emul-gate-op.c | 2 ++ xen/arch/x86/pv/emul-inv-op.c | 1 + xen/arch/x86/pv/emul-priv-op.c | 1 + xen/arch/x86/pv/emulate.c | 1 + xen/arch/x86/pv/grant_table.c | 1 + xen/arch/x86/pv/mm.c | 1 + xen/arch/x86/pv/ro-page-fault.c | 1 + xen/arch/x86/pv/traps.c | 1 + xen/arch/x86/x86_64/machine_kexec.c | 3 ++- xen/common/stack-protector.c | 1 + xen/include/xen/stack-protector.h | 2 ++ 14 files changed, 27 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/include/asm/pv/mm.h b/xen/arch/x86/include/asm/pv= /mm.h index a5745908206a..11a43f15e222 100644 --- a/xen/arch/x86/include/asm/pv/mm.h +++ b/xen/arch/x86/include/asm/pv/mm.h @@ -10,6 +10,12 @@ #ifndef __X86_PV_MM_H__ #define __X86_PV_MM_H__ =20 +#include + +struct cpu_user_regs; +struct page_info; +struct vcpu; + #ifdef CONFIG_PV =20 int pv_ro_page_fault(unsigned long addr, struct cpu_user_regs *regs); @@ -26,7 +32,7 @@ int validate_segdesc_page(struct page_info *page); #else =20 #include -#include +#include =20 static inline int pv_ro_page_fault(unsigned long addr, struct cpu_user_regs *regs) diff --git a/xen/arch/x86/include/asm/pv/traps.h b/xen/arch/x86/include/asm= /pv/traps.h index 8c31d5a793c5..8c201190923d 100644 --- a/xen/arch/x86/include/asm/pv/traps.h +++ b/xen/arch/x86/include/asm/pv/traps.h @@ -10,9 +10,9 @@ #ifndef __X86_PV_TRAPS_H__ #define __X86_PV_TRAPS_H__ =20 -#ifdef CONFIG_PV +#include =20 -#include +#ifdef CONFIG_PV =20 int pv_raise_nmi(struct vcpu *v); =20 @@ -28,8 +28,6 @@ static inline bool pv_trap_callback_registered(const stru= ct vcpu *v, =20 #else /* !CONFIG_PV */ =20 -#include - static inline int pv_raise_nmi(struct vcpu *v) { return -EOPNOTSUPP; } =20 static inline int pv_emulate_privileged_op(struct cpu_user_regs *regs) { r= eturn 0; } diff --git a/xen/arch/x86/mm/mem_paging.c b/xen/arch/x86/mm/mem_paging.c index d4b3cb990c54..33929b526ab9 100644 --- a/xen/arch/x86/mm/mem_paging.c +++ b/xen/arch/x86/mm/mem_paging.c @@ -7,10 +7,12 @@ * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp) */ =20 - -#include #include #include + +#include +#include + #include =20 #include "mm-locks.h" diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c index 1faf13b962b1..c2c699fbff40 100644 --- a/xen/arch/x86/pv/emul-gate-op.c +++ b/xen/arch/x86/pv/emul-gate-op.c @@ -9,6 +9,8 @@ =20 #include =20 +#include + #include "emulate.h" =20 static int read_gate_descriptor(unsigned int gate_sel, diff --git a/xen/arch/x86/pv/emul-inv-op.c b/xen/arch/x86/pv/emul-inv-op.c index 346ac1124d7b..23d2928b00cd 100644 --- a/xen/arch/x86/pv/emul-inv-op.c +++ b/xen/arch/x86/pv/emul-inv-op.c @@ -8,6 +8,7 @@ */ =20 #include +#include =20 #include "emulate.h" =20 diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index 1d9e57ad2763..a3c1fd12621d 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include =20 diff --git a/xen/arch/x86/pv/emulate.c b/xen/arch/x86/pv/emulate.c index 0022e0f55e30..a00d1c6c82eb 100644 --- a/xen/arch/x86/pv/emulate.c +++ b/xen/arch/x86/pv/emulate.c @@ -10,6 +10,7 @@ #include =20 #include +#include =20 #include "emulate.h" =20 diff --git a/xen/arch/x86/pv/grant_table.c b/xen/arch/x86/pv/grant_table.c index 247436a0156a..1df68440a24a 100644 --- a/xen/arch/x86/pv/grant_table.c +++ b/xen/arch/x86/pv/grant_table.c @@ -12,6 +12,7 @@ #include =20 #include +#include #include =20 #include "mm.h" diff --git a/xen/arch/x86/pv/mm.c b/xen/arch/x86/pv/mm.c index 187f5f6a3e8c..3f2e9dedcde3 100644 --- a/xen/arch/x86/pv/mm.c +++ b/xen/arch/x86/pv/mm.c @@ -12,6 +12,7 @@ =20 #include #include +#include =20 #include "mm.h" =20 diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-faul= t.c index 9c6f66884675..d89306d34fc6 100644 --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault.c @@ -8,6 +8,7 @@ * Copyright (c) 2004 Christian Limpach */ =20 +#include #include #include =20 diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index 26a468108a77..b0395b99145a 100644 --- a/xen/arch/x86/pv/traps.c +++ b/xen/arch/x86/pv/traps.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include =20 diff --git a/xen/arch/x86/x86_64/machine_kexec.c b/xen/arch/x86/x86_64/mach= ine_kexec.c index f4a005cd0c2f..f9e54d86fb53 100644 --- a/xen/arch/x86/x86_64/machine_kexec.c +++ b/xen/arch/x86/x86_64/machine_kexec.c @@ -6,8 +6,9 @@ * - Magnus Damm */ =20 -#include #include +#include + #include #include =20 diff --git a/xen/common/stack-protector.c b/xen/common/stack-protector.c index 2115912c3bd0..05e57d4509e2 100644 --- a/xen/common/stack-protector.c +++ b/xen/common/stack-protector.c @@ -2,6 +2,7 @@ #include #include #include +#include #include =20 /* diff --git a/xen/include/xen/stack-protector.h b/xen/include/xen/stack-prot= ector.h index 931affd919be..65488bdabced 100644 --- a/xen/include/xen/stack-protector.h +++ b/xen/include/xen/stack-protector.h @@ -1,6 +1,8 @@ #ifndef __XEN_STACK_PROTECTOR_H__ #define __XEN_STACK_PROTECTOR_H__ =20 +#include + extern unsigned long __stack_chk_guard; =20 /* --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624055; cv=none; d=zohomail.com; s=zohoarc; b=RTVfRU29txOnHCgxD6mLKGvNVkE203Rd2GaPv+wDRnze5KtPXIg9lFMyFe5tVnu0KDf1zypy6GPElg8SiUGDOJufEr5S5m39JbrJsED6sb2nSAJ6aYhk/8M5Qv10zpn3TX2Yah9ylfmZnvUI+AIrSy+adCxGcygzSnApOMBQCBY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624055; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XZOtH6QKJjtO5cu9aMfNJQCmxs/qiZNDuJ7ZYGgpThE=; b=bE5B6W97rJHsIrJSDO6NyDBsGB9e+TiDuN+deWHWCGn8rCOEuJqmiDD+y9ijZSQatruVqh3hy/VjIaGDqZb1Yq0gYDKF0GQ56zLUfatHOs11iDuYJVD04lYeT15Rl3KCGTWmhz2UVSwi1oV5WEgR+/m+25OSxcFI6L0wkk3FvSY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624055732237.7801510448894; Fri, 20 Feb 2026 13:47:35 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237617.1539919 (Exim 4.92) (envelope-from ) id 1vtYLB-0001Yv-Rt; Fri, 20 Feb 2026 21:47:13 +0000 Received: by outflank-mailman (output) from mailman id 1237617.1539919; Fri, 20 Feb 2026 21:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLB-0001W8-F3; Fri, 20 Feb 2026 21:47:13 +0000 Received: by outflank-mailman (input) for mailman id 1237617; Fri, 20 Feb 2026 21:47:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL9-0008IG-15 for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:11 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4f27749-0ea5-11f1-9ccf-f158ae23cfc8; Fri, 20 Feb 2026 22:47:09 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-48334ee0aeaso18920445e9.1 for ; Fri, 20 Feb 2026 13:47:09 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:07 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4f27749-0ea5-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624029; x=1772228829; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XZOtH6QKJjtO5cu9aMfNJQCmxs/qiZNDuJ7ZYGgpThE=; b=FFmhL3IY2RNqLuaArvzpOVYyM94aSfmt7tTF+3HtrUkfRX8TxaBD0Q4NYkqgLfIUGb A2ujHHiktbOiffpXlqMmbUS9ZeOfWN8qdhUVucpZaHo1p/JJQOPbRv/nLCqfKV0XWGbr jLAtpjJBTk8fZIvdIhsBBlBOOkl3Ww8uGDMYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624029; x=1772228829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XZOtH6QKJjtO5cu9aMfNJQCmxs/qiZNDuJ7ZYGgpThE=; b=gbBUN78nq3rxf8SzyMjhqa2nHwfhqwyW7Fj2w+aOw/Vm82WSsOSUy+6VP/1LFYQoVT U5EPjsqMSIICdn/QJET5XS+m9h9A89YtT9MQREWGSZSGLnPOV3Fq6KxQSe0e0hyDwkWu 6jBHz4u722NQ2TZ/Z6omEHJoUUaNgFJbG3gn+MS9rCsTx6/XCLtbE1fTNoBB3v42SM1u Kwgs71XM+F6qJjQlcYABUNxSogMc605J+YonrDOZmJvGVBMT88f5APCQEZ7epcQWTAtO 6OSZ8oNT6nsR9k8+aU5ECYEdIYt1cI8s8HvxjsTawRkjdpuC8nQtAu4kBS+UMEz69a16 w5wQ== X-Gm-Message-State: AOJu0YzRINYD++V159sEYQMRwiSCfoXnmOTx3QOL1D/hViG1uEyzYI7y Dupd0gT9ADkwomDac/dV6sRX2TZzfLSl6KSYioXSYS3bGIWXovDy0vhFYOMMHmpE5f7nGSzFbPV I3siI X-Gm-Gg: AZuq6aJOVCtaXM3gEEH2TZ35noajENnfyLW7ddKnByOy6L0jKIDvWD6/vDQMy787zJ8 JI6hXGn9cEtlwpdOLklDNKCFqYLZg1lNV/1j3DM5pd2Q/aLb9Ycwl1eQ9Is0WtH1AUpu9tQpjoU c586RZUwaQPc1YR4IhzB3yVwfPV18E9UywzImHeF7rENlc7YceFUuauiw86684eVXn41azMK0TM dlY6TOWIXbiKC8ZrTAcrBodnAI5ph8QoKB2izMjc/x5p+f5OgfdJ/eYbM/Ea2uDEm1sYpPhng8z kq7POWK3gZJZHkiapAPT35V6JVkehdRgSaNWMD3RCq5aW7dq4Ijc7mgT3DEbfXdHCMovTSUp9Re Su5cBo8pJCneL7ckui2KBtryDv92C/t2Fmp64Bg7d1P1q+H3q4+CYVt+WwXrWllyhw8Ax5TroOF THY8jllhXVBRK//gzZO7ByZOQnyv3IqCJXUaUZubkII6WfqSTFLflUxqlSRKzXweG1qalldIo= X-Received: by 2002:a05:600c:8b71:b0:483:7980:4687 with SMTP id 5b1f17b1804b1-483a95dd932mr16357815e9.17.1771624027841; Fri, 20 Feb 2026 13:47:07 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 07/12] xen/vmac: Const the key parameter of vmac_set_key() Date: Fri, 20 Feb 2026 21:46:48 +0000 Message-Id: <20260220214653.3497384-8-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624057047158501 Eclair complains that tboot_gen_domain_integrity() is casting away constness (Rule 11.8 violation). vmac_set_key() doesn't modify the user_key parameter, so it can become cons= t, removing the need to cast. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/tboot.c | 6 +++--- xen/crypto/vmac.c | 2 +- xen/include/crypto/vmac.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c index 0b3d596690cc..5ae27f481f94 100644 --- a/xen/arch/x86/tboot.c +++ b/xen/arch/x86/tboot.c @@ -202,7 +202,7 @@ static void tboot_gen_domain_integrity(const uint8_t ke= y[TB_KEY_SIZE], uint8_t nonce[16] =3D {}; vmac_ctx_t ctx; =20 - vmac_set_key((uint8_t *)key, &ctx); + vmac_set_key(key, &ctx); for_each_domain( d ) { if ( !(d->options & XEN_DOMCTL_CDF_s3_integrity) ) @@ -241,7 +241,7 @@ static void tboot_gen_xenheap_integrity(const uint8_t k= ey[TB_KEY_SIZE], uint8_t nonce[16] =3D {}; vmac_ctx_t ctx; =20 - vmac_set_key((uint8_t *)key, &ctx); + vmac_set_key(key, &ctx); for ( mfn =3D 0; mfn < max_page; mfn++ ) { struct page_info *page =3D mfn_to_page(_mfn(mfn)); @@ -272,7 +272,7 @@ static void tboot_gen_frametable_integrity(const uint8_= t key[TB_KEY_SIZE], uint8_t nonce[16] =3D {}; vmac_ctx_t ctx; =20 - vmac_set_key((uint8_t *)key, &ctx); + vmac_set_key(key, &ctx); for ( sidx =3D 0; ; sidx =3D nidx ) { eidx =3D find_next_zero_bit(pdx_group_valid, max_idx, sidx); diff --git a/xen/crypto/vmac.c b/xen/crypto/vmac.c index f1f6d75f8eeb..c9914d2c7c1d 100644 --- a/xen/crypto/vmac.c +++ b/xen/crypto/vmac.c @@ -924,7 +924,7 @@ uint64_t vmac(unsigned char m[], =20 /* -----------------------------------------------------------------------= */ =20 -void vmac_set_key(unsigned char user_key[], vmac_ctx_t *ctx) +void vmac_set_key(const unsigned char user_key[], vmac_ctx_t *ctx) { uint64_t in[2] =3D {0}, out[2]; unsigned i; diff --git a/xen/include/crypto/vmac.h b/xen/include/crypto/vmac.h index 457f3f5dd6da..7574c4a3f328 100644 --- a/xen/include/crypto/vmac.h +++ b/xen/include/crypto/vmac.h @@ -161,7 +161,7 @@ uint64_t vhash(unsigned char m[], * When passed a VMAC_KEY_LEN bit user_key, this function initialazies ctx. * -----------------------------------------------------------------------= */ =20 -void vmac_set_key(unsigned char user_key[], vmac_ctx_t *ctx); +void vmac_set_key(const unsigned char user_key[], vmac_ctx_t *ctx); =20 /* --------------------------------------------------------------------- */ =20 --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624054; cv=none; d=zohomail.com; s=zohoarc; b=SkLjPFUKtI7SCq8nYLe7R5sqCmk3CuqSeVLGQzA3yW0NnIQ4xH5cnaXWaIS34UCP9auXYtskJaQD0StyWcE6FDmIqUlp+7mvTqRBtlnGKnVk/Nw8OybKn4CoFjRpLeDdAkg4dOUeqtOW8BwFEwoB5gtBdnpxzZh8XDgmlBjnAlk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624054; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0Xl/PbKeU3vXsi8lYY06npq9oqfFySBcdivOG4iOWhA=; b=SpfAr1aOYtYECI7iNk+LxhWhR2TNYswjsxedEHIDNO8B6XTKJDK3/O/gOyU6bljZMe5+bTNfxJlfWEi/MCF+z2pkez3TBf0hhmJuKzi4KlVK6m91huqr6nm9c+Gs306PjW2bDff0gK/WvKorcSaNR2LmCNioMN9NBN++8mfz7pg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624054349839.8986647421679; Fri, 20 Feb 2026 13:47:34 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237615.1539908 (Exim 4.92) (envelope-from ) id 1vtYLA-0001Mg-Sl; Fri, 20 Feb 2026 21:47:12 +0000 Received: by outflank-mailman (output) from mailman id 1237615.1539908; Fri, 20 Feb 2026 21:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLA-0001Kr-L7; Fri, 20 Feb 2026 21:47:12 +0000 Received: by outflank-mailman (input) for mailman id 1237615; Fri, 20 Feb 2026 21:47:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL8-0008Ew-Ad for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:10 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b51fcf85-0ea5-11f1-b164-2bf370ae4941; Fri, 20 Feb 2026 22:47:09 +0100 (CET) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-43621bf67ceso1666755f8f.2 for ; Fri, 20 Feb 2026 13:47:09 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:08 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b51fcf85-0ea5-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624029; x=1772228829; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0Xl/PbKeU3vXsi8lYY06npq9oqfFySBcdivOG4iOWhA=; b=ERg4En1oCz/WkmNntbMDWY53yX/uv0MGVYNMAerFvSS+8BcWmHARyQUhbltvyzqwFS GKOz8YVL0WVmrS0mZ0ur5q1w0v0sr2GTsnzGGahDi2RSMxrsEOMOesiMrY6RCmdYdQ9M jlIjcB6htKAkBARDKeyNtfLOzwmIrpaWKdHEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624029; x=1772228829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0Xl/PbKeU3vXsi8lYY06npq9oqfFySBcdivOG4iOWhA=; b=WSBRjF52E3JNx/6uSn41adDMopE7d0i6Jr37g0NS9dc9DNFXKo8Fb56mrYTWh7g3Ke pzuIP9hvtRZdy57crogE6dvflkS3SmC32twFULVHnuyVhlLkocFgcEEla/VizUQ+qZ2s D4q3slif2lFyHzdwQ/kR4msxtH7h1WqLTfzeYLMkc6sHAK8X19TKH+Or84R0G9leZVDB +fdLuxBS4GzjwSs0A3HdARP4yqia3fAu+t7UbgYbeHj9uLE2ZQG/NZctQl8nwsMdLQmp WbQSCdAnhaDZowTIiq7OF5xHb02bfn0Z9SBAaziEugofBA+L7MCAhwFLIzKxGo+3liR2 PkHQ== X-Gm-Message-State: AOJu0YwO6u1UYVBJiemEIWI1K5kpZ8LBr5hUKJDanPRWeRhNlWN+seI6 viI1cl+pNa/gWTkoHyWmp8ogxSKTSgAvKTTOT2aSIjPYWAT3+jzZaDaSShF7+8VgmqfmQkUr+Pn 9v14Q X-Gm-Gg: AZuq6aJ2tdCVyO5Krq1cPDgNooaBrvJh4O4aIcEKyUGmv8chcRpvLD3KBpahXHckWdW yqhJN3aY6yLN17uPVtPFW5VVOIgrMprp//xLF8IcdYTrhYd1dKDWFdJbw1+rrpw5rhiRYVwxTPM cb7boab4+irKj2ppl6VT3Z6N2PGMjcjBESFvxQonRX66uiRpsJ8DoYcbsvZozqwCt4Z3emQ3apU Sby8P00/7fztZB9hHnwraX0M8Rs2YKiNZzS/nK0kjMgKOXoxDc1e4WkMMTr7jHQ022IC6iqOB8Y swU/JOULuXTBzejQyhjflI35WA8VxmlLlBUdSAGBuwILVhY4DrtQaZcfY3WQ9bKnbswpl8z+BJn l4lV0wfXZa9HFirfoGB+Ekl9MD4eMND5Y0b4emXefkfFu1NCYYZ+McLaoIjvKmraaDEMt8vGSQT S1LdAmN+wXXS/aQHqjidv+7QixNlfrAdoH+7twSyebk4Az9L9npaCJheYIVT9U4a1bpe283G8= X-Received: by 2002:a05:600c:4e4a:b0:483:129e:b573 with SMTP id 5b1f17b1804b1-483a962d1d1mr17672845e9.18.1771624028447; Fri, 20 Feb 2026 13:47:08 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 08/12] arm/pci-designware: Fix MISRA violations Date: Fri, 20 Feb 2026 21:46:49 +0000 Message-Id: <20260220214653.3497384-9-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624054988158500 * Move includes inside the header guards (D4.10) * Use NULL in preference to 0 (R11.9) No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel Reviewed-by: Nicola Vetrini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/arm/pci/pci-designware.c | 2 +- xen/arch/arm/pci/pci-designware.h | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/pci/pci-designware.c b/xen/arch/arm/pci/pci-desig= nware.c index 0bd67524ac8b..6b85213f637b 100644 --- a/xen/arch/arm/pci/pci-designware.c +++ b/xen/arch/arm/pci/pci-designware.c @@ -285,7 +285,7 @@ void __iomem *dw_pcie_child_map_bus(struct pci_host_bri= dge *bridge, bridge->child_cfg->phys_addr, busdev, bridge->child_cfg->size); if ( ret ) - return 0; + return NULL; =20 return bridge->child_cfg->win + where; } diff --git a/xen/arch/arm/pci/pci-designware.h b/xen/arch/arm/pci/pci-desig= nware.h index b9deb3b138ae..bd93dab6f2f1 100644 --- a/xen/arch/arm/pci/pci-designware.h +++ b/xen/arch/arm/pci/pci-designware.h @@ -6,12 +6,11 @@ * Based on xen/arch/arm/pci/pci-host-generic.c */ =20 -#include -#include - #ifndef __PCI_DESIGNWARE_H__ #define __PCI_DESIGNWARE_H__ =20 +#include +#include =20 #define PCIE_ATU_VIEWPORT 0x900 #define PCIE_ATU_REGION_OUTBOUND 0 --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624054; cv=none; d=zohomail.com; s=zohoarc; b=nW2weOTxVnhBYp/jB8cbE9IsHKT3CVScq0m2wUGkULe0Sb6diLbHF9lUF1Ys13ydlYEixbKoi1CQUNgs1OZWvYaiAj7gssUM2US6lbg+ColVT8kEH5yXjZIG80s3y168hxH/mX1j3ekWC/laeFVzsUb2gXHuPk5yEJBi3qloLpI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624054; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5TrnZ66XZ6HFaBzMCfnoTCQeXNsoz4cCSZgGcCFs61o=; b=lO2g8uU4tqUstvddX9yWOnJLX+Nyp5AYT3Y2K8heQHE9xjs7hWlzl8lJnZHFHQdSn+RRxRvqJPq94dmx8/V3DUyky4JqyOB4dgLvip1QRqJBt9jspcCPiH3pJfM1H97PqMG1PrshSIVjnS9KNmK/UBRZGpcYLAt5t5jF7ao49mQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624054811842.4727133699137; Fri, 20 Feb 2026 13:47:34 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237616.1539913 (Exim 4.92) (envelope-from ) id 1vtYLB-0001RV-Ax; Fri, 20 Feb 2026 21:47:13 +0000 Received: by outflank-mailman (output) from mailman id 1237616.1539913; Fri, 20 Feb 2026 21:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLB-0001QX-1C; Fri, 20 Feb 2026 21:47:13 +0000 Received: by outflank-mailman (input) for mailman id 1237616; Fri, 20 Feb 2026 21:47:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYL8-0008Ew-J7 for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:10 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b54e7943-0ea5-11f1-b164-2bf370ae4941; Fri, 20 Feb 2026 22:47:10 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4837f27cf2dso21378625e9.2 for ; Fri, 20 Feb 2026 13:47:10 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:08 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b54e7943-0ea5-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624029; x=1772228829; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5TrnZ66XZ6HFaBzMCfnoTCQeXNsoz4cCSZgGcCFs61o=; b=HuudOdGd40eHvHS0yy4pLmIDMIVjjBSs4APab6PAXlwE3ZTtzKjt8ramAAi+6j4hYt QRs1qd0O8oXNmb1p9xYPXW0zMYuXmDeKCWormUGiEVIsAH4AwwjsRP/RcAUpFWc0vMTJ Lkke1/iEsUQHS/0AUFXEcnAtlJpR+AzgmOfZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624029; x=1772228829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5TrnZ66XZ6HFaBzMCfnoTCQeXNsoz4cCSZgGcCFs61o=; b=GzPbOoN37lGp8szPI6XjGt6EuoxNzVHbMNieGbQ681b/7Ey5sbnD4MwDixVGXGmu6W w2WQzA03wW77G9oBI0thX8mWMB1H2r1iRKB7HDewzbzZWwEDS+lSBgguF+X5xN1Ek35H XjC9s9Y1tYahL6E9A7Kal/veismAVfrjKAjmDFRDkPT7/TcavbXToqIxUwwYLl+BJ3lr uNSA6V/LKPqhgkgNnBwcRDtM7Ffi97n0WFhhkpKCJdmcVo/wKkixa3HAnrkoC2bLYrej kTbOR/n3AhXo+Xcgzq3qghyUYwgftOUisGFcWf8qQi8qDngmpMO/KqL1tZ6a3Re8Zlit ERmA== X-Gm-Message-State: AOJu0YzBSJYknj5424beAoBxfTJMOGYrUABFQd2pzXZjcINA1LMz71YT zjXTuSiIiMerxAhc79LHCbn5cw5KIdLyBM3SWAjJtzJM9GzSu92m/byXt9ENiTVdUbux83tjPvy Gm4MKzCDy5w== X-Gm-Gg: AZuq6aKqI4nU4GIgOwTZSiQGSfMlh1HW0xCyuq3XGo1KyMh8DwpNHnj98ofdLo7dF9W 9Fvv/c3rsxVkGdxS0PaNprezeLR5cTAsnnQZiGp9RNPUlg1gs3Ua24nS/7SH3bJwwZUtYxufgUC FIbcuYZveH4Oj9GN6Di4uMw/cUlD6wZpDvHQV1iAeL5krNF3amDDqZOu8StmUpxY4VwmQ8v2s/N qp6KerEIxXhfpTFFDmECsGMibl53jtujQ6N+eMD5slWMns+ATYje/qNA5+ix6wJ13kj9VP0w2OE n9f2uDd1WD0LyTh1B/PwMfVCA/Gl7J2rOX8FQJFIXFI0xuEEqkMwZ9xeR3iE9ZPuUAMUb2yBMDS /B5Q31FDGVtxWth/2Av3D4wZ/DnG6Xycl2GSIaFxoRjagpwSME8dLhUNMrO0YbjUoXaMAJaU92B Z4o//jN9Mlxm0HO/HA0W0Lh+v9sG40e37iOlQh4EEdRrSvgScoo/J5M2l4EuPm/BGGP7cWbAA= X-Received: by 2002:a05:600c:8b88:b0:479:35e7:a0e3 with SMTP id 5b1f17b1804b1-483a963d64bmr14245295e9.30.1771624029103; Fri, 20 Feb 2026 13:47:09 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 09/12] x86/shadow: Rework write_atomic() call in shadow_write_entries() Date: Fri, 20 Feb 2026 21:46:50 +0000 Message-Id: <20260220214653.3497384-10-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624054981158500 Eclair complains of a side effect in a sizeof() expression (R13.6). write_atomic() only evaluates each parameter once, but rewrite the expressi= on to less resemble entries in an obfuscation contest. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/mm/shadow/set.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/shadow/set.c b/xen/arch/x86/mm/shadow/set.c index 8b670b6bb555..96ba2811077e 100644 --- a/xen/arch/x86/mm/shadow/set.c +++ b/xen/arch/x86/mm/shadow/set.c @@ -62,8 +62,8 @@ shadow_write_entries(void *d, const void *s, unsigned int= entries, mfn_t mfn) =20 ASSERT(IS_ALIGNED((unsigned long)dst, sizeof(*dst))); =20 - for ( ; i < entries; i++ ) - write_atomic(&dst++->l1, src++->l1); + for ( ; i < entries; i++, dst++, src++ ) + write_atomic(&dst->l1, src->l1); =20 unmap_domain_page(map); } --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624058; cv=none; d=zohomail.com; s=zohoarc; b=REEylpXuDCyhkUiXKPuQawUhedXBf7xPAp26eD+it0hAp/OB70KxFErtmPXq3xwBiURd4UshQCbQ4lvau8HxTweG8xqXER7QAcagAbVPfYzUuuogcdYP6zuiMTCmkKt7AOMQOCXB0sFEgznOJBP3O0WOriImmayfiU9djGdJcLk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624058; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZTqLwQAs0U3ktqAPOv0GkFeeIfrNLrDf4DIWmemjfFQ=; b=FVTjepCJpM9SBYfPJ/DiaOlVsf54r7zz9m6LDvr5TpCDvvEGrjWADWAbVCHdEWFW7vnRq9SPUC8rodTFHLqE5NzigLTGLbZJ0l1beaeXrVw3GkaQu9B+omEPdpftpwFdU1cG1n1xcVBnsLBR3cWun8OZ1k1FgNYtPiUdYqse68w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624058741506.18439071652176; Fri, 20 Feb 2026 13:47:38 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237618.1539927 (Exim 4.92) (envelope-from ) id 1vtYLC-0001mn-Ii; Fri, 20 Feb 2026 21:47:14 +0000 Received: by outflank-mailman (output) from mailman id 1237618.1539927; Fri, 20 Feb 2026 21:47:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLC-0001jf-BQ; Fri, 20 Feb 2026 21:47:14 +0000 Received: by outflank-mailman (input) for mailman id 1237618; Fri, 20 Feb 2026 21:47:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLA-0008IG-If for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:12 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b5bfbbb9-0ea5-11f1-9ccf-f158ae23cfc8; Fri, 20 Feb 2026 22:47:10 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-480706554beso28511075e9.1 for ; Fri, 20 Feb 2026 13:47:10 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:09 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5bfbbb9-0ea5-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624030; x=1772228830; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZTqLwQAs0U3ktqAPOv0GkFeeIfrNLrDf4DIWmemjfFQ=; b=MzIwYoLRbmbdwpCrrCbztLj/pWlkZ9t4vfFHzj0ck/GsHrQ+fkwerOXzK3dKGYHcdU /UbtN7WFb5sOtM/u2FSQDG27a5w9E4bvakUueUVK2pL1outtQPgQ7UaPL2+Cd/dg1/Il rKpXhk8uVJwvlmOKB8W8I57Pr/+mFdGoOkCqU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624030; x=1772228830; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZTqLwQAs0U3ktqAPOv0GkFeeIfrNLrDf4DIWmemjfFQ=; b=d5Ru0EOGlSSUdHXeoasujpwK2U/7JC8Dz7MYLieEzN6wSkytWjGZZTmmFMe2DxIxDj jIvWcPDf3Nln8FyxK8rCyN0/bvIix2lK69EreEHX5b6mMJxbB1dJnwqzkv66CoV4RNQJ fnPRXUiL5Is0CrqlucD+X1AJ8bRa+UlyoLTUFj2Y+dK6nHCvaEKjEYj5AkjTPRR+DdVQ 5/8CshpFw8zFxXVBzJtkwCHeykMhG4ZfY62Ex+e18l7+eqpymz21Dku3za4OKN7Wc6fw CGdmMWMqkmRmo3mM1a9l67GMV7iaEa7aDic0JgX88xCM1Zc7bx+P+dK5emh0PkWGHcy/ jfhA== X-Gm-Message-State: AOJu0YwEp0DxA8NvlPRox6g8ZPoiEwTfjNKLPs9Su049oXvGIXBFTSDw 78upR2XSqvbzcLDu51Lr5WsDAw1uW1kKBmKMlit9oJGJP78Bbf8EyE6XtNwOW8whq+C+n5PaNel RQw8OSnbGlw== X-Gm-Gg: AZuq6aI4WT1609B3Kf/CKsizJgAismUXO4nr6tN3+vPhIDusvX/z0JUKqEE/pJLRLvv +Rp3/Li4uEpkP1c498ZtimSwtAotVtkLOIGILfmu2x/nXlV7MtSeDYb9mVi9vGaW9m4uK3JZ9Ee GFLBAfnl85Q9c04UDKgyIYRTDomEZZhRZpKNdJGIXYQ6mJjEeIpThf2ygh5bg5KUJahuEfrI+aq aN0aUEMaI8LD9pe4JzGsQRqww6fWT6Bp1/kK3dWU509x3kiD/S3uE9U56Y6VVRvU/WtDc+ualkz QNvXjTv6fVOSrrOc+rGSJ55pPIX/6b/4iJtwuy/64rcDff5hGpwRf1Argcl8rXkTVF6Cy+aHBsC CFVwhhNNc4DrEptTwBHuHo1+Qmb8AJ8zoM5rtkqIwNO1mNKi3nEbsnzc99JE/kbo11aBDmApXdU qelvh9/148pGV6FXdTEno5hpP+XApymwkFc35iPLAXnXrqAcyWoZZ6bNA1tU9jsQ4i3PVNV2E= X-Received: by 2002:a05:600c:64ce:b0:483:7432:a761 with SMTP id 5b1f17b1804b1-483a9637502mr16333205e9.24.1771624029745; Fri, 20 Feb 2026 13:47:09 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 10/12] xen: Adjust break/fallthrough statements Date: Fri, 20 Feb 2026 21:46:51 +0000 Message-Id: <20260220214653.3497384-11-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624059014158500 sh_destroy_shadow() has a spelling of fallthrough which doesn't match the permitted pattern. Convert it to a real fallthrough (psedo)keyword. Elsewhere, insert breaks at the end of the default statements. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel Reviewed-by: Nicola Vetrini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/arm/pci/pci-access.c | 2 ++ xen/arch/arm/pci/pci-designware.c | 2 ++ xen/arch/arm/tee/optee.c | 1 + xen/arch/x86/mm/shadow/common.c | 2 +- 4 files changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c index c0533c00c9a5..2b23d552bbfb 100644 --- a/xen/arch/arm/pci/pci-access.c +++ b/xen/arch/arm/pci/pci-access.c @@ -63,6 +63,7 @@ int pci_generic_config_read(struct pci_host_bridge *bridg= e, pci_sbdf_t sbdf, break; default: ASSERT_UNREACHABLE(); + break; } =20 return 0; @@ -89,6 +90,7 @@ int pci_generic_config_write(struct pci_host_bridge *brid= ge, pci_sbdf_t sbdf, break; default: ASSERT_UNREACHABLE(); + break; } =20 return 0; diff --git a/xen/arch/arm/pci/pci-designware.c b/xen/arch/arm/pci/pci-desig= nware.c index 6b85213f637b..902da19e8c98 100644 --- a/xen/arch/arm/pci/pci-designware.c +++ b/xen/arch/arm/pci/pci-designware.c @@ -48,6 +48,7 @@ static int dw_pcie_read(void __iomem *addr, unsigned int = len, uint32_t *val) break; default: ASSERT_UNREACHABLE(); + break; } =20 return 0; @@ -71,6 +72,7 @@ static int dw_pcie_write(void __iomem *addr, unsigned int= len, uint32_t val) break; default: ASSERT_UNREACHABLE(); + break; } =20 return 0; diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c index 699e8d536862..f719d9d767ab 100644 --- a/xen/arch/arm/tee/optee.c +++ b/xen/arch/arm/tee/optee.c @@ -1206,6 +1206,7 @@ static void do_call_with_arg(struct optee_domain *ctx, default: /* Free any temporary shared buffers */ free_shm_buffers(ctx, call->xen_arg); + break; } =20 put_std_call(ctx, call); diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/commo= n.c index 96986ee2553d..5834c265f76d 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1213,7 +1213,7 @@ void sh_destroy_shadow(struct domain *d, mfn_t smfn) #ifdef CONFIG_PV32 case SH_type_l2h_64_shadow: ASSERT(is_pv_32bit_domain(d)); - /* Fall through... */ + fallthrough; #endif case SH_type_l2_64_shadow: SHADOW_INTERNAL_NAME(sh_destroy_l2_shadow, 4)(d, smfn); --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624059; cv=none; d=zohomail.com; s=zohoarc; b=HBytl3MdIPPOuj6eFY8evMwmzAf7lC2aY/9iYlqopKKFGjs6IM9QQJLZB/I1aBW2oMvMcWBT/CfuUzDxEJqoydOznuQtYOvOZ2LQwnVeaDkWBXHUadZRXKS+A7KQM/2puHBMn2lPuWlvQWhM3Ta5Smu2rcQMK9RKdKryiZlcOok= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624059; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QL0YluuNljQpopZEfgU7W97F1VvgWXQ8YTIYrdrO7hc=; b=emLAJWtIrSaK7mCc1q8F4WtrPAGzK9FB/qxVtputcHqqG5OwjhN07S+NzyF2Aa6x5ggpoCYQorCSnm7th6iP5+hO+o3dVn3oPP77Nxp6zFVvPQRA8mSJxBSI2rWUO4Z7zAMJtYxjZVhVgVRICMp6aYGTahSV8N3/zdRsnBFM5gw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624059032302.7322719681099; Fri, 20 Feb 2026 13:47:39 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237619.1539950 (Exim 4.92) (envelope-from ) id 1vtYLE-0002NW-R4; Fri, 20 Feb 2026 21:47:16 +0000 Received: by outflank-mailman (output) from mailman id 1237619.1539950; Fri, 20 Feb 2026 21:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLE-0002KG-Cf; Fri, 20 Feb 2026 21:47:16 +0000 Received: by outflank-mailman (input) for mailman id 1237619; Fri, 20 Feb 2026 21:47:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLB-0008Ew-Cs for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:13 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b61d39a9-0ea5-11f1-b164-2bf370ae4941; Fri, 20 Feb 2026 22:47:11 +0100 (CET) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-436356740e6so2654077f8f.2 for ; Fri, 20 Feb 2026 13:47:11 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:10 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b61d39a9-0ea5-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624031; x=1772228831; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QL0YluuNljQpopZEfgU7W97F1VvgWXQ8YTIYrdrO7hc=; b=Q2M2FZisofsQDWxzuJLABo41tKT3ptdHqJDDaU5HpZVCoGqDc0Bm32JHdghcTbVbzE zFUGHHOxTNaAQLXZiB13yVBzhP6KhSRhxJ4B8Vte/RhZrdHRQYZhFM+nuOWj2mpEf+uK WPP6A4B43Ed1Wf48s67ZDHMHWEUcU0B3ZQT4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624031; x=1772228831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QL0YluuNljQpopZEfgU7W97F1VvgWXQ8YTIYrdrO7hc=; b=WcWZXIK1XI5IpTFiP+/cgyz7VSdaaoiUjTtY9dm0lTb1SN2bDsSWY4oN4H5jwnouYY SiGF3K/twIYDAPO/Qu6eMQcxQ66FjpFKmdlVcAHIEb2N5uKPsYg3K7oFGpEYKeXBnYkA Jl+JxlxM+zfxcTm7ZnYL6qtLVjcC93TbKCIFkoUY0NK+3JnpR38HRM/ShoxyxxlNbtVZ yvsdnXhPCEBqhYxWC56eyinwHBVVvyi7HVpZqAKVzM5z3Vw0Nz3ytqBUFLc25dGwN8yi uO7yycp3hgG++CcjmBmegTmzCverV3FGsIs1kY0Fotj6I3/yF+UDk+cvmUG6KIz6JgsA DgpA== X-Gm-Message-State: AOJu0Yx/fs0RPfQrmkzYwEsQV64oth7aGScxVBmup8YQYpAPNuaOFjjb qVhylPCbp62mAQkggJC38WLMiS3LGHf0vNc7XzKA37lquEmu6EceXiZRNGo6xIOwrkkZQZWWTrK H+I7pDaATNA== X-Gm-Gg: AZuq6aLlIHR4MJwhmMdYzJMLeUpnvc3AxqR5MfYo6TWLjyzzJrNj6OY2pkIIo4os9rQ QrujDU56iGtmWn/CCrJkaWpTHKaJh+/lLFhI6cYQmYmXSeEDFgApJZsGGGGrmM2I3DgKJgmHPE9 MLC1yFcumgmGKX64KfY3KkPMT/paimpLvcAoRPRPSPCViEMNyhmJFjFBZYgW1hf4tDQIVbSmfE+ evnPgqo5B2ly2fSe3Nguduyqkf1hP96AkMlycQUk4tTEN2GI3poEQZ9EhHuEItFgPs+5+p+ZAoU iyxwFnfUVLQzMEgwl6bwNoPOk4G2bXezPCas5NfU+fivsa0mK15Z4aJzx3TmGanI8NPGCwAJ7SR bmffEHuQw/6g57XsmlvQRjYtqS6p544baKwoDV5ntAxoLm9WZto8aBY+8ozAucVTDYSDozaTM6B 00S+HZ6sZYeF25fghn5qV+ZXodwbr2KI2zWuYE1GR74duDlrWInpK02SpuEBgtC+aybqb1ZEQ= X-Received: by 2002:a05:600c:3b10:b0:483:43da:6c87 with SMTP id 5b1f17b1804b1-483a963d603mr13512275e9.33.1771624030450; Fri, 20 Feb 2026 13:47:10 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 11/12] xen: Bracket uses of macro parameters Date: Fri, 20 Feb 2026 21:46:52 +0000 Message-Id: <20260220214653.3497384-12-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624061087158500 Fixing Rule 20.7 violations. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel Reviewed-by: Nicola Vetrini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/arm/pci/pci-access.c | 6 +++--- xen/arch/x86/include/asm/bootinfo.h | 2 +- xen/arch/x86/mm/shadow/multi.c | 2 +- xen/common/kimage.c | 11 ++++++----- xen/common/livepatch.c | 11 ++++++----- xen/crypto/vmac.c | 8 ++++---- xen/include/xen/libfdt/libfdt.h | 6 +++--- 7 files changed, 24 insertions(+), 22 deletions(-) diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c index 2b23d552bbfb..7bd6877596d4 100644 --- a/xen/arch/arm/pci/pci-access.c +++ b/xen/arch/arm/pci/pci-access.c @@ -16,7 +16,7 @@ #include =20 #define INVALID_VALUE (~0U) -#define PCI_ERR_VALUE(len) GENMASK(0, len * 8) +#define PCI_ERR_VALUE(len) GENMASK(0, (len) * 8) =20 static const struct pci_ops *get_ops(struct pci_host_bridge *bridge, pci_sbdf_t sbdf) @@ -139,14 +139,14 @@ static void pci_config_write(pci_sbdf_t sbdf, unsigne= d int reg, void pci_conf_write##size(pci_sbdf_t sbdf, \ unsigned int reg, type data) \ { \ - pci_config_write(sbdf, reg, size / 8, data); \ + pci_config_write(sbdf, reg, (size) / 8, data); \ } =20 #define PCI_OP_READ(size, type) \ type pci_conf_read##size(pci_sbdf_t sbdf, \ unsigned int reg) \ { \ - return pci_config_read(sbdf, reg, size / 8); \ + return pci_config_read(sbdf, reg, (size) / 8); \ } =20 PCI_OP_READ(8, uint8_t) diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm= /bootinfo.h index 4f2cc5906e59..b3a6b2acf3ac 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -75,7 +75,7 @@ static inline unsigned int __init next_boot_module_index( #define for_each_boot_module_by_type(i, b, t) \ for ( (i) =3D first_boot_module_index(b, t); \ (i) <=3D (b)->nr_modules; \ - (i) =3D next_boot_module_index(b, t, i + 1) ) + (i) =3D next_boot_module_index(b, t, (i) + 1) ) =20 #endif /* X86_BOOTINFO_H */ =20 diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 3bbaceec1287..9de60720db20 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -793,7 +793,7 @@ do { = \ do { \ int __done =3D 0; \ _FOREACH_PRESENT_L1E(_sl1mfn, _sl1e, _gl1p, \ - ({ (__done =3D _done); }), _code); \ + ({ (__done =3D (_done)); }), _code); \ _sl1mfn =3D sh_next_page(_sl1mfn); \ if ( !__done ) \ _FOREACH_PRESENT_L1E(_sl1mfn, _sl1e, _gl1p, _done, _code); \ diff --git a/xen/common/kimage.c b/xen/common/kimage.c index e1aec5a18a54..972301368443 100644 --- a/xen/common/kimage.c +++ b/xen/common/kimage.c @@ -491,11 +491,12 @@ static void kimage_terminate(struct kexec_image *imag= e) * Call unmap_domain_page(ptr) after the loop exits. */ #define for_each_kimage_entry(image, ptr, entry) \ - for ( ptr =3D map_domain_page(_mfn(paddr_to_pfn(image->head))); \ - (entry =3D *ptr) && !(entry & IND_DONE); \ - ptr =3D (entry & IND_INDIRECTION) ? \ - (unmap_domain_page(ptr), map_domain_page(_mfn(paddr_to_pfn(e= ntry)))) \ - : ptr + 1 ) + for ( (ptr) =3D map_domain_page(_mfn(paddr_to_pfn((image)->head))); \ + ((entry) =3D *(ptr)) && !((entry) & IND_DONE); \ + (ptr) =3D (((entry) & IND_INDIRECTION) \ + ? (unmap_domain_page(ptr), \ + map_domain_page(_mfn(paddr_to_pfn(entry)))) \ + : (ptr) + 1) ) =20 static void kimage_free_entry(kimage_entry_t entry) { diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c index 7446533c8cfb..63473925cafb 100644 --- a/xen/common/livepatch.c +++ b/xen/common/livepatch.c @@ -664,9 +664,10 @@ static inline int livepatch_check_expectations(const s= truct payload *payload) const struct livepatch_elf_sec *__sec =3D livepatch_elf_sec_by_name(el= f, section_name); \ if ( !__sec ) = \ break; = \ - if ( !section_ok(elf, __sec, sizeof(*hook)) || __sec->sec->sh_size != =3D sizeof(*hook) ) \ + if ( !section_ok(elf, __sec, sizeof(*(hook))) || = \ + __sec->sec->sh_size !=3D sizeof(*(hook)) ) = \ return -EINVAL; = \ - hook =3D __sec->addr; = \ + (hook) =3D __sec->addr; = \ } while (0) =20 /* @@ -678,10 +679,10 @@ static inline int livepatch_check_expectations(const = struct payload *payload) const struct livepatch_elf_sec *__sec =3D livepatch_elf_sec_by_name(el= f, section_name); \ if ( !__sec ) = \ break; = \ - if ( !section_ok(elf, __sec, sizeof(*hook)) ) = \ + if ( !section_ok(elf, __sec, sizeof(*(hook))) ) = \ return -EINVAL; = \ - hook =3D __sec->addr; = \ - nhooks =3D __sec->sec->sh_size / sizeof(*hook); = \ + (hook) =3D __sec->addr; = \ + (nhooks) =3D __sec->sec->sh_size / sizeof(*(hook)); = \ } while (0) =20 static int prepare_payload(struct payload *payload, diff --git a/xen/crypto/vmac.c b/xen/crypto/vmac.c index c9914d2c7c1d..c7aa1e9be3b9 100644 --- a/xen/crypto/vmac.c +++ b/xen/crypto/vmac.c @@ -203,7 +203,7 @@ const uint64_t mpoly =3D UINT64_C(0x1fffffff1fffffff); = /* Poly key mask */ #define nh_16(mp, kp, nw, rh, rl) = \ { int i; uint64_t th, tl; = \ rh =3D rl =3D 0; = \ - for (i =3D 0; i < nw; i+=3D 2) { = \ + for (i =3D 0; i < (nw); i+=3D 2) { = \ MUL64(th,tl,get64PE((mp)+i )+(kp)[i ],get64PE((mp)+i+1)+(kp)[i+1= ]);\ ADD128(rh,rl,th,tl); = \ } = \ @@ -211,7 +211,7 @@ const uint64_t mpoly =3D UINT64_C(0x1fffffff1fffffff); = /* Poly key mask */ #define nh_16_2(mp, kp, nw, rh, rl, rh1, rl1) = \ { int i; uint64_t th, tl; = \ rh1 =3D rl1 =3D rh =3D rl =3D 0; = \ - for (i =3D 0; i < nw; i+=3D 2) { = \ + for (i =3D 0; i < (nw); i+=3D 2) { = \ MUL64(th,tl,get64PE((mp)+i )+(kp)[i ],get64PE((mp)+i+1)+(kp)[i+1= ]);\ ADD128(rh,rl,th,tl); = \ MUL64(th,tl,get64PE((mp)+i )+(kp)[i+2],get64PE((mp)+i+1)+(kp)[i+3= ]);\ @@ -223,7 +223,7 @@ const uint64_t mpoly =3D UINT64_C(0x1fffffff1fffffff); = /* Poly key mask */ #define nh_vmac_nhbytes(mp, kp, nw, rh, rl) = \ { int i; uint64_t th, tl; = \ rh =3D rl =3D 0; = \ - for (i =3D 0; i < nw; i+=3D 8) { = \ + for (i =3D 0; i < (nw); i+=3D 8) { = \ MUL64(th,tl,get64PE((mp)+i )+(kp)[i ],get64PE((mp)+i+1)+(kp)[i+1= ]);\ ADD128(rh,rl,th,tl); = \ MUL64(th,tl,get64PE((mp)+i+2)+(kp)[i+2],get64PE((mp)+i+3)+(kp)[i+3= ]);\ @@ -237,7 +237,7 @@ const uint64_t mpoly =3D UINT64_C(0x1fffffff1fffffff); = /* Poly key mask */ #define nh_vmac_nhbytes_2(mp, kp, nw, rh, rl, rh1, rl1) = \ { int i; uint64_t th, tl; = \ rh1 =3D rl1 =3D rh =3D rl =3D 0; = \ - for (i =3D 0; i < nw; i+=3D 8) { = \ + for (i =3D 0; i < (nw); i+=3D 8) { = \ MUL64(th,tl,get64PE((mp)+i )+(kp)[i ],get64PE((mp)+i+1)+(kp)[i+1= ]);\ ADD128(rh,rl,th,tl); = \ MUL64(th,tl,get64PE((mp)+i )+(kp)[i+2],get64PE((mp)+i+1)+(kp)[i+3= ]);\ diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfd= t.h index fabddbee8cec..1b09bba28eea 100644 --- a/xen/include/xen/libfdt/libfdt.h +++ b/xen/include/xen/libfdt/libfdt.h @@ -230,9 +230,9 @@ int fdt_next_subnode(const void *fdt, int offset); * literal. */ #define fdt_for_each_subnode(node, fdt, parent) \ - for (node =3D fdt_first_subnode(fdt, parent); \ - node >=3D 0; \ - node =3D fdt_next_subnode(fdt, node)) + for ((node) =3D fdt_first_subnode(fdt, parent); \ + (node) >=3D 0; \ + (node) =3D fdt_next_subnode(fdt, node)) =20 /**********************************************************************/ /* General functions */ --=20 2.39.5 From nobody Tue Mar 3 03:24:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1771624053; cv=none; d=zohomail.com; s=zohoarc; b=nW0X8R7fkA5qPbVfztGncztWjLUU2PYW/I6QbHtctSmZ0Ti8OT9VlCSKIIt34hLF7bkAMmdoh862M4KcyoOz93/JK//yaJHQgv/JcnHECiTY7MVrFEp5Qb+MmJLIIqf3tiELd0Kde79FZq63JJgV9iJo49W66jyvt2Sz6kmWLSU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771624053; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wazStv22+sAAkXhUXk9SZLE13GE7UuEeUTF8Qgk68Bw=; b=OQPYkP2dYHz4nFhI3/HRkQwMA85zZicejcPwLLl8PzEelEJDtkctMCTSwYpfbqDcDRhcYEORjYCvJazQUyq1evHTKv7fFhRAREmj8JybbGnieqRpX2B77y4J3sNQ+7PxD09vvnM9c1VCpPdomBks9Zthat+xzj3I8K/IqYZHbBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771624053492979.4339912896378; Fri, 20 Feb 2026 13:47:33 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237620.1539944 (Exim 4.92) (envelope-from ) id 1vtYLE-0002Fi-80; Fri, 20 Feb 2026 21:47:16 +0000 Received: by outflank-mailman (output) from mailman id 1237620.1539944; Fri, 20 Feb 2026 21:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLD-0002DJ-ST; Fri, 20 Feb 2026 21:47:15 +0000 Received: by outflank-mailman (input) for mailman id 1237620; Fri, 20 Feb 2026 21:47:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYLB-0008IG-LP for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 21:47:13 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6834de7-0ea5-11f1-9ccf-f158ae23cfc8; Fri, 20 Feb 2026 22:47:12 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-482f454be5bso33419825e9.0 for ; Fri, 20 Feb 2026 13:47:12 -0800 (PST) Received: from localhost.localdomain (host-92-22-18-152.as13285.net. [92.22.18.152]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm28940205e9.13.2026.02.20.13.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:47:10 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6834de7-0ea5-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1771624031; x=1772228831; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wazStv22+sAAkXhUXk9SZLE13GE7UuEeUTF8Qgk68Bw=; b=sRmJDvz7AA8KjQEgnW8scWIUHxFwE1hulQAg37MKray+hg2erxodWMFHLuF/ZShj1u WaVRCrzpQdDjMxLCBAGp3eZrI6Iq5/sEVFbc6zZbqnvLRlCbxnQ08fwv75m75ITtuFvx j8KYZkbC8UqeXdb6mbVKaYTrOCjrCoFYdxb34= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771624031; x=1772228831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wazStv22+sAAkXhUXk9SZLE13GE7UuEeUTF8Qgk68Bw=; b=mCWhEbyq1JmmYgVe5Zkw3COkR5h/u07AtjBkdb+fhkWX+xeqpTBAZqUN6U5Vybx2fG HqevFpvtbqhcONko4ixOttxiMXLFjXh/cwIH7pc9gfW7Xn11RTzAEpt7OdcFmFesCJrD b7uWdwnOTU7lw5J2PwjVSNefGSnS7Xk/IznTIF2jePKnhLgYoTlrmkRBvYzNNXXZLEtu RFEXZ0uNAPOxDXSUgpMNNmO5O12/IoREAhr9hILVnMnRddAxTzAdRP/Fi+MJoJsAhg4S 1hHTbCYRT9MH8lz0SH9+DhUIW0T+LK9ImtsA0qql60HBMkMyywH5aiGZ5/4UR/Kp91R2 yOQg== X-Gm-Message-State: AOJu0YzGiC18ynmA17YwOIjN+NAPLwrn45/jf/MVdJxEogiy5OGtyFls ubX06YSYkBpvY+8SRQ5s14aZukAeB0FuuAXGWhbwHrcRwv54L/AT9HVJBxmr5OOBqRlnMTqTiue lnUrs5gO/5Q== X-Gm-Gg: AZuq6aIxtFHHoliPmnnNbF6QT02HQcyzOQFw3u49bGAw0ZZbSSdgNPcCr7kIR8rgkGY OvcHxm8bh26Zg0DodwP2BT3YVS6o/U5cg8I8TlNgAIDmNApplVME8aFAgFbP7h7Vt/sE9nG7WQd N7XYNtAhCXJNirj3PJzjOy+wiEMdvGDfJMNhb5pTn5dzNkCJu69T6JvIBNgkZp/wYYgc2pm0E/A 5axwb8yNLBt//txlN+mfyO71lhH2+/XqTVXDxv1mryGYDfrDBtdhmQVLambtB3CIi4fxteo1uaT EKdwAaWpij3BKf/HDyBMrsJdvCEKRa4wIZR1xXUyCWCZ3MQGjt4En8gc7vZqFqUKdLPVHfvyR1r 21aJMkOMltXql01KFUzSubedYF0MyR6S+brNmTdd5SlbIegskTVWHNmqcy81LUnSHXvdg1JT0oD DXuKpPJKVYN/YvwyqxQMpdTJ4qSDZEfyW9k/DyQwRhNSyJOZRL7UAvumbBrJ+uj9eehqDjaJ0= X-Received: by 2002:a05:600c:1f08:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-483a94c996fmr16228945e9.11.1771624031099; Fri, 20 Feb 2026 13:47:11 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 12/12] xen/vmac: Delete STDINT block in vmac.h Date: Fri, 20 Feb 2026 21:46:53 +0000 Message-Id: <20260220214653.3497384-13-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260220214653.3497384-1-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1771624054986158500 Eclair complains that _MSC_VER is undefined (a Rule 20.9 violation). This could be fixed by inserting an "&& defined(_MSC_VER)" clause, but the whole block is entirely useless (it comments out the include of stdint) and the top of vmac.c pulls in xen/types.h specifically. Simply delete the block. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/include/crypto/vmac.h | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/xen/include/crypto/vmac.h b/xen/include/crypto/vmac.h index 7574c4a3f328..43fd288ae3bd 100644 --- a/xen/include/crypto/vmac.h +++ b/xen/include/crypto/vmac.h @@ -35,29 +35,6 @@ #define hz (400e6) mips */ =20 -/* -----------------------------------------------------------------------= --- - * This implementation uses uint32_t and uint64_t as names for unsigned 32- - * and 64-bit integer types. These are defined in C99 stdint.h. The - * following may need adaptation if you are not running a C99 or - * Microsoft C environment. - * -----------------------------------------------------------------------= */ -#define VMAC_USE_STDINT 1 /* Set to zero if system has no stdint.h = */ -=20 -#if VMAC_USE_STDINT && !_MSC_VER /* Try stdint.h if non-Microsoft = */ -#ifdef __cplusplus -#define __STDC_CONSTANT_MACROS -#endif -//#include -#elif (_MSC_VER) /* Microsoft C does not have stdint.h = */ -typedef unsigned __int32 uint32_t; -typedef unsigned __int64 uint64_t; -#define UINT64_C(v) v ## UI64 -#else /* Guess sensibly - may need adaptation = */ -typedef unsigned int uint32_t; -typedef unsigned long long uint64_t; -#define UINT64_C(v) v ## ULL -#endif - /* -----------------------------------------------------------------------= --- * This implementation supports two free AES implementations: OpenSSL's and * Paulo Barreto's. To use OpenSSL's, you will need to include the OpenSSL --=20 2.39.5