From nobody Tue Mar 3 03:12:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=invisiblethingslab.com ARC-Seal: i=1; a=rsa-sha256; t=1771589585; cv=none; d=zohomail.com; s=zohoarc; b=ltCQHs0cCxHDZEjwVlCZ4cmWI3ubULob+/58sCwSWmWmMkvDhUjzgStgRyPB8f70GYPdVEJ3VrEbENXcEil+NFiskaH92YoYvcqhwcVuCvaNsc387IgxbQm4oiXnNNEg6djyjLW9l9eFtfcWbWL2kVwd+91KkgMvPFn0PTK+2Bk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771589585; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qtVpbKCQ3+bsYVw2O+QCWfNBAGnNce1pFTQ04TaAvzo=; b=AmZ2OLm0pAWQ2Ffx0xCRZJ0PF/KRlE89AXgf5Kq+x+aitaNnZCm2hb4OEKWY3s9g2vrdvAyfzpAVVkAyAl3b7pymOcRTZCPE/z7otHTVMZ294v1NOfZUZdHh0POavMm/lETHYCvkoOeLZOjLkIEA1Jd6GZsZMEUqmoGnEteoNlI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 177158958534226.91886103801562; Fri, 20 Feb 2026 04:13:05 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1237068.1539528 (Exim 4.92) (envelope-from ) id 1vtPN4-0002MS-R8; Fri, 20 Feb 2026 12:12:34 +0000 Received: by outflank-mailman (output) from mailman id 1237068.1539528; Fri, 20 Feb 2026 12:12:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtPN4-0002ML-OE; Fri, 20 Feb 2026 12:12:34 +0000 Received: by outflank-mailman (input) for mailman id 1237068; Fri, 20 Feb 2026 12:12:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtPN3-0002MF-7c for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 12:12:33 +0000 Received: from fhigh-b1-smtp.messagingengine.com (fhigh-b1-smtp.messagingengine.com [202.12.124.152]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d1fc496-0e55-11f1-9ccf-f158ae23cfc8; Fri, 20 Feb 2026 13:12:30 +0100 (CET) Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id 227EB7A0068; Fri, 20 Feb 2026 07:12:28 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Fri, 20 Feb 2026 07:12:28 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Feb 2026 07:12:26 -0500 (EST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d1fc496-0e55-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1771589547; x=1771675947; bh=qtVpbKCQ3+bsYVw2O+QCWfNBAGnNce1p FTQ04TaAvzo=; b=f5AsRcpXT2oeNADDjIKmfhhvM92PAY3UzoNkuVtWCn1wWRmr 3ZkHrgpmgCBHdUaT4TFfW0k4R7w6xbr2GA1RjkbenwOQ2w/I5Y3CdQQ1K3FSxxed A0OJyJE8jiV9brNoo0HL6W6OG6+jxM+yCchoroTYvVtNFpXvMOlCJ79FTrzGylUx tGsrOS56m4Kp9GvKFtQHeU2HE6WC0Ia3sOmWoO75guouVMsqomLuFswonnXqBqMT fSVcfaP4hMReYIwa8BEndtzLAomooX46QQ4S82uxLC8OCIBJ/4FRxlYdB67ycUWv 83RVPCQzJArynyYFOTvvD/oUFlyS4rZdOW/ZAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1771589547; x=1771675947; bh=qtVpbKCQ3+bsYVw2O+QCWfNBAGnN ce1pFTQ04TaAvzo=; b=gKTu6MhnzSJcUZlO4z8bbBSpYrGywHzM+iOwD9S0bkFm Cnjm0OPFM4u5m4cAOXCnLb0fx/kT8Jrudv5KId+nk/5Edfe6x2uVYpFT2xYpCehE uER/zYyXanqT6Nev97k/27VplVECv7F0EirtHDnk5oFGQo/OFPhQZUTkoSbaHd4I Ohe47qNhLx9TNmO11LnOl9WVcaFHPhvMxOeyVLz8AsUzTKsvCtOXj12fHhxL73B/ PnCDSGESvCAhprLG8wshjPz/qQ7YRONq16nuMGupveFze0teC+vFz/s8TJnam26V pr3eu7KNiR3vs5F4e6Zw8OrEL4w0dgNwTqhYDdR/fQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvvdekgeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghkucfo rghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefhudel teelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhn vhhishhisghlvghthhhinhhgshhlrggsrdgtohhmpdhnsggprhgtphhtthhopeegpdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopeigvghnqdguvghvvghlsehlihhsthhsrdig vghnphhrohhjvggtthdrohhrghdprhgtphhtthhopehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmpdhrtghpthhtoheprghnthhhohhnhidrphgv rhgrrhgusehvrghtvghsrdhtvggthhdprhgtphhtthhopehjghhrohhsshesshhushgvrd gtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony PERARD , Juergen Gross Subject: [PATCH v3] libxl: constify some local variables for building with glibc 2.43 Date: Fri, 20 Feb 2026 13:12:00 +0100 Message-ID: <20260220121220.52078-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @invisiblethingslab.com) X-ZM-MESSAGEID: 1771589587048154100 Archlinux just updated glibc to 2.43+r5+g856c426a7534-1 and that causes libxl build failure: libxl_cpuid.c: In function =E2=80=98libxl_cpuid_parse_config_xend=E2=80= =99: libxl_cpuid.c:447:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 447 | endptr =3D strchr(str, '=3D'); | ^ libxl_cpuid.c:452:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 452 | endptr =3D strchr(str, ','); | ^ libxl_cpuid.c:454:20: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 454 | endptr =3D strchr(str, 0); | ^ cc1: all warnings being treated as errors Add missing consts. Note in libxl_cpuid_parse_config_xend() non-const endptr still is needed, to be compatible with the second argument to strtoul(). Add second variable for this reason. And while at it, move semicolon to its own line Signed-off-by: Marek Marczykowski-G=C3=B3recki Acked-by: Anthony PERARD Reviewed-by: Jan Beulich --- Changes in v3: - go back to adding consts, as it wasn't about GCC after all - reduce variable scope, move semicolon Changes in v2: - revert to old standard (specify it explicitly now), instead of adjusting the code to the new standard - this way is more backport-friendly --- tools/libs/light/libxl_cpuid.c | 21 ++++++++++++--------- tools/libs/light/libxl_internal.c | 2 +- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index 8420b2465f39..14f08df33a14 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -440,29 +440,32 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_= list *policy, str =3D endptr + 1; entry =3D cpuid_find_match(policy, leaf, subleaf); for (str =3D endptr + 1; *str !=3D 0;) { + const char *endptrc; + if (str[0] !=3D 'e' || str[2] !=3D 'x') { return 4; } value =3D str[1] - 'a'; - endptr =3D strchr(str, '=3D'); - if (value > 3 || endptr =3D=3D NULL) { + endptrc =3D strchr(str, '=3D'); + if (value > 3 || endptrc =3D=3D NULL) { return 4; } - str =3D endptr + 1; - endptr =3D strchr(str, ','); - if (endptr =3D=3D NULL) { - endptr =3D strchr(str, 0); + str =3D endptrc + 1; + endptrc =3D strchr(str, ','); + if (endptrc =3D=3D NULL) { + endptrc =3D strchr(str, 0); } - if (endptr - str !=3D 32) { + if (endptrc - str !=3D 32) { return 5; } entry->policy[value] =3D calloc(32 + 1, 1); strncpy(entry->policy[value], str, 32); entry->policy[value][32] =3D 0; - if (*endptr =3D=3D 0) { + if (*endptrc =3D=3D 0) { break; } - for (str =3D endptr + 1; *str =3D=3D ' ' || *str =3D=3D '\n'; str+= +); + for (str =3D endptrc + 1; *str =3D=3D ' ' || *str =3D=3D '\n'; str= ++) + ; } return 0; } diff --git a/tools/libs/light/libxl_internal.c b/tools/libs/light/libxl_int= ernal.c index 2941ca0bbd0e..d70cfed7d88f 100644 --- a/tools/libs/light/libxl_internal.c +++ b/tools/libs/light/libxl_internal.c @@ -204,7 +204,7 @@ char *libxl__strndup(libxl__gc *gc, const char *c, size= _t n) =20 char *libxl__dirname(libxl__gc *gc, const char *s) { - char *c =3D strrchr(s, '/'); + const char *c =3D strrchr(s, '/'); =20 if (!c) return NULL; --=20 2.52.0