From nobody Tue Mar 3 03:25:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=invisiblethingslab.com ARC-Seal: i=1; a=rsa-sha256; t=1771548281; cv=none; d=zohomail.com; s=zohoarc; b=Gd8r5OAbLfuiXPb/07oxZob+LhWS7lZOKTbPmaFYgBsXOh9bIHSe0fvgmwZ/sXqfQMJaH6o7i3T3e0UFO17sLVVa6aR/r0aWg9hjpGSbYpc/Dz1sLRwNmZOLHl4yvKvI9mU+oHQ7NTyYOewji3Qx6zmS6nWzraw77kxZt3RUvSc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771548281; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hKubb8dOWuRmnUzSNPpGPvNmcUjoXCoraP1dW3dZk0k=; b=PUdUimtvwuHG863ImsoZ7VCsnrQ9OggcxuNx8onmlW8HpxGokZbmx7N0FiTIMQf2vpxvteLNIWFEOt0dph91qzQa8kIAqyu/A02nJfgmBJOdqpTMgLk2tOI7bzUF7VleIFT4VEuSljk3uCtCH4Hum6rf36MIa2zw9WfyaEqiEBY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771548281610773.5439683908695; Thu, 19 Feb 2026 16:44:41 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1236771.1539302 (Exim 4.92) (envelope-from ) id 1vtEce-0004pH-Qg; Fri, 20 Feb 2026 00:43:56 +0000 Received: by outflank-mailman (output) from mailman id 1236771.1539302; Fri, 20 Feb 2026 00:43:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtEce-0004pA-Np; Fri, 20 Feb 2026 00:43:56 +0000 Received: by outflank-mailman (input) for mailman id 1236771; Fri, 20 Feb 2026 00:43:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtEce-0004p4-1f for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 00:43:56 +0000 Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3a9c3b86-0df5-11f1-b164-2bf370ae4941; Fri, 20 Feb 2026 01:43:53 +0100 (CET) Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 2974D14000A4; Thu, 19 Feb 2026 19:43:52 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Thu, 19 Feb 2026 19:43:52 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Feb 2026 19:43:50 -0500 (EST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a9c3b86-0df5-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1771548232; x=1771634632; bh=hKubb8dOWuRmnUzSNPpGPvNmcUjoXCor aP1dW3dZk0k=; b=PhPJmpqWdGXWw/XmDL5uzUT7/7ulhjaf15ogYHYWuqm7HQVe hqdpx0CNaG5H5Oiv8Qs7JIFerWf9nnoj8+s8c85g6M2yAfcFVu2V7HQdsk8cTI2s OHXJLJGVQoRC8jAG6EH0ojG02hdTSBZiaUWxthXomlbS+vL/5c/hiC8fzTmQhL29 kgEtclVd38nkAATe7FCX+r/w6GHIiaaQ1YGfIhZLhREyWC6Z+14cwGZPt4K8NDzW JBiDx3O5MBMlpMH+yiy9trxRkZ770gzOIwi2/4WrRQIO6CG+zcFxQJMrd4mjG5Sq es/BG+O/axmWZtpO1F+jZHqPphKnlP7yvQikQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1771548232; x=1771634632; bh=hKubb8dOWuRmnUzSNPpGPvNmcUjo XCoraP1dW3dZk0k=; b=U4FfCmFIOXHlemHrHV4SGCJfM56oLzR3UO+7VSyTNW11 Ic0F48FB2r3W6tIgolKSPGowZBqovQjow5+5vwkQYFB6xVZ1wvmA/C4xweifc8T/ fXHMZHGdL7OlsCC5grcucdJGy3gc3c5H3fNaM4iUgy9L9K2jnLzMTdLN2P3PAMsR UKuWFaDmcyWyBvJPEq2LirJcCzrKOUoasYvjWyc9h8+7FLYIVNLBmZ4pliM77aj7 ZaDVIdr0dwjTR9D/pY+DGFLEGGL4rQomOC9CXUBmopXKnmIiTkqdi5lBuj3vjpXg HY2pJGKhv4ztNY44p+msZIJjYLYrRgeEmy5BRFMz1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvvdejtdduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghkucfo rghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefhudel teelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhn vhhishhisghlvghthhhinhhgshhlrggsrdgtohhmpdhnsggprhgtphhtthhopeefpdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopeigvghnqdguvghvvghlsehlihhsthhsrdig vghnphhrohhjvggtthdrohhrghdprhgtphhtthhopehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmpdhrtghpthhtoheprghnthhhohhnhidrphgv rhgrrhgusehvrghtvghsrdhtvggthh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony PERARD Subject: [PATCH v2] tools: specify C standard explicitly Date: Fri, 20 Feb 2026 01:43:21 +0100 Message-ID: <20260220004344.1980775-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @invisiblethingslab.com) X-ZM-MESSAGEID: 1771548283359154100 Archlinux just updated gcc to 15.2.1+r604+g0b99615a8aef-1, and that defaults now to GNU23 standard. This isn't what Xen codebase expects, for example libxl fails to build with: libxl_cpuid.c: In function =E2=80=98libxl_cpuid_parse_config_xend=E2=80= =99: libxl_cpuid.c:447:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 447 | endptr =3D strchr(str, '=3D'); | ^ libxl_cpuid.c:452:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 452 | endptr =3D strchr(str, ','); | ^ libxl_cpuid.c:454:20: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 454 | endptr =3D strchr(str, 0); | ^ libxl_cpuid.c: In function =E2=80=98libxl_cpuid_parse_config_xend=E2=80= =99: libxl_cpuid.c:447:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 447 | endptr =3D strchr(str, '=3D'); | ^ libxl_cpuid.c:452:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 452 | endptr =3D strchr(str, ','); | ^ libxl_cpuid.c:454:20: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 454 | endptr =3D strchr(str, 0); | ^ cc1: all warnings being treated as errors Specify GNU99 explicitly (same version as in the hypervisor, but the GNU dialect), to fix the build, and avoid such surprises in the future. Signed-off-by: Marek Marczykowski-G=C3=B3recki --- As discussed in v1, I'm changing the standard version for now. Note GCC 14 used to default to -std=3Dgnu17, so that should work too, but keep it consistent with the hypervisor. The v1 that adjusted libxl can be used anyway, but it's less backport-friendly. Changes in v2: - revert to old standard (specify it explicitly now), instead of adjusting the code to the new standard - this way is more backport-friendly --- tools/Rules.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/Rules.mk b/tools/Rules.mk index d9b9c740e964..de9100eb1681 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -38,6 +38,8 @@ ifeq ($(debug_symbols),y) CFLAGS +=3D -g3 endif =20 +CFLAGS +=3D -std=3Dgnu99 + ifneq ($(nosharedlibs),y) INSTALL_SHLIB =3D $(INSTALL_PROG) SYMLINK_SHLIB =3D ln -sf --=20 2.51.0