From nobody Mon Apr 13 03:42:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=invisiblethingslab.com ARC-Seal: i=1; a=rsa-sha256; t=1770866659; cv=none; d=zohomail.com; s=zohoarc; b=nfYFysB6fxItkPkFQKiBSTnYJm0qu/Ae/eAJ3XkTm2cP96mFDNkHFx2AZNk4bv78OUx7mj8ozW8RRps3pZk9vwqkx6G25LdLWlRYAZ93lRp4KTWbIZ/1X1i3gdDSDCJ/r7OUbAfqH2uRermiXY92yMN2DSmMHbU3JLhuhY3+m9g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770866659; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4nBuasMp4wez6QdaFSI7hhv6Ad2Ix+lQQS0JYwcUwYw=; b=L1lxyGwIfKDBVWlEWCJKPOAXhoaoCODIaKUjYRSHyd2ZuhQD0/k5mEN+L77z441jhBeQkCrPayV8531QoN8q716A+ELYq6arBA/4fviunr7kjNNzB15TJ4XKaSciEANDfDaZpFMRE19G2UM+UFJ04rKdzMnUnP7awmxYmDmfgw0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1770866659246572.8029376830264; Wed, 11 Feb 2026 19:24:19 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1228371.1534566 (Exim 4.92) (envelope-from ) id 1vqNIx-0003Xf-FS; Thu, 12 Feb 2026 03:23:47 +0000 Received: by outflank-mailman (output) from mailman id 1228371.1534566; Thu, 12 Feb 2026 03:23:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vqNIx-0003XW-AK; Thu, 12 Feb 2026 03:23:47 +0000 Received: by outflank-mailman (input) for mailman id 1228371; Thu, 12 Feb 2026 03:23:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vqNIv-0003XQ-LD for xen-devel@lists.xenproject.org; Thu, 12 Feb 2026 03:23:45 +0000 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b252689-07c2-11f1-b162-2bf370ae4941; Thu, 12 Feb 2026 04:23:43 +0100 (CET) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id CDF5AEC0728; Wed, 11 Feb 2026 22:23:41 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Wed, 11 Feb 2026 22:23:41 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 Feb 2026 22:23:40 -0500 (EST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b252689-07c2-11f1-b162-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1770866621; x=1770953021; bh=4nBuasMp4wez6QdaFSI7hhv6Ad2Ix+lQ QS0JYwcUwYw=; b=meNN13aQFaYuGgxoVX4MAy7s3F0TA+K4lTkrdR3bLFC0I3wp +HmeS89FyZowV1cfuwdl5CXj5odUCA2lC9CTN2uYoU2B98cCkE/yShgD1EnrdH0J 0LubKUzZFH5Dro4v/50Ywl+plpskQOkRwSJPYKrCJuWiUiHDxFab92BbyvVoc1vL 3Nw6E4nhaYW66LmkAO1d4QoxNxgyGpBoG3ezzoLa3m79MT9Wg+YKsVyQxlqPXBmn dRcdPFWjhZ0s0EVBcyeVn1Yq51y8Bj6t/ekLdBULLe8/oIzjLoC1uTIImRRiQrEN kS8LXpPEk7I3YnTEZQQqyQiPSnvHnTH97NpMCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1770866621; x=1770953021; bh=4nBuasMp4wez6QdaFSI7hhv6Ad2I x+lQQS0JYwcUwYw=; b=vAPaZbPl4YgySEGWl7tcW2c999PIidousiRP+MBck41c JZJl7SSFYaUlY0pxtJn7h97CYJhK3e5r5PEZIYqSjIMzHvuirqRkADKgWO6ACCYo BQ2XMTg9hP4q6BEy/DJrzhgzt0W92WQpWetZSd4ePT35htLN50N70fX69ZWFO1r9 OkBkAs8xdTF0ZOtg6RHkg8g7i88F/4is5nPTTEhPqKF/hO4R+VbqCMO0dUMdLApn tgjGcanqaovs5gFKlC/j6DSFWwLS32dQlfdj7Ci1/hhGPVxUeaP3Nw65IJKe4/1s 01P+NVz1doV+6RSSw+BMxpgjSFRGm5cf0L7lU/8Gdw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvtdegfedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghkucfo rghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefhudel teelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhn vhhishhisghlvghthhhinhhgshhlrggsrdgtohhmpdhnsggprhgtphhtthhopeegpdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopeigvghnqdguvghvvghlsehlihhsthhsrdig vghnphhrohhjvggtthdrohhrghdprhgtphhtthhopehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmpdhrtghpthhtoheprghnthhhohhnhidrphgv rhgrrhgusehvrghtvghsrdhtvggthhdprhgtphhtthhopehjghhrohhsshesshhushgvrd gtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony PERARD , Juergen Gross Subject: [PATCH] libxl: constify some local variables to appease gcc 15.2.1 Date: Thu, 12 Feb 2026 04:23:00 +0100 Message-ID: <20260212032334.1696248-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @invisiblethingslab.com) X-ZM-MESSAGEID: 1770866662246154100 Archlinux just updated gcc to 15.2.1+r604+g0b99615a8aef-1 and that complains about libxl: libxl_cpuid.c: In function =E2=80=98libxl_cpuid_parse_config_xend=E2=80= =99: libxl_cpuid.c:447:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 447 | endptr =3D strchr(str, '=3D'); | ^ libxl_cpuid.c:452:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 452 | endptr =3D strchr(str, ','); | ^ libxl_cpuid.c:454:20: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 454 | endptr =3D strchr(str, 0); | ^ libxl_cpuid.c: In function =E2=80=98libxl_cpuid_parse_config_xend=E2=80= =99: libxl_cpuid.c:447:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 447 | endptr =3D strchr(str, '=3D'); | ^ libxl_cpuid.c:452:16: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 452 | endptr =3D strchr(str, ','); | ^ libxl_cpuid.c:454:20: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 454 | endptr =3D strchr(str, 0); | ^ cc1: all warnings being treated as errors Add missing consts. Note in libxl_cpuid_parse_config_xend() non-const endptr still is needed, to be compatible with the second argument to strtoul(). Add second variable for this reason. Signed-off-by: Marek Marczykowski-G=C3=B3recki --- When I say "just updated" I really mean it. The update hit me between my CI saying "ok" and release build few hours later. I guess Xen's CI will see that only after next refresh of the Arch container (next week?). --- tools/libs/light/libxl_cpuid.c | 19 ++++++++++--------- tools/libs/light/libxl_internal.c | 2 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index 8420b2465f39..5fb580113d80 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -415,6 +415,7 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_li= st *policy, const char* str) { char *endptr; + const char *endptrc; unsigned long value; uint32_t leaf, subleaf =3D XEN_CPUID_INPUT_UNUSED; struct xc_xend_cpuid *entry; @@ -444,25 +445,25 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_= list *policy, return 4; } value =3D str[1] - 'a'; - endptr =3D strchr(str, '=3D'); - if (value > 3 || endptr =3D=3D NULL) { + endptrc =3D strchr(str, '=3D'); + if (value > 3 || endptrc =3D=3D NULL) { return 4; } - str =3D endptr + 1; - endptr =3D strchr(str, ','); - if (endptr =3D=3D NULL) { - endptr =3D strchr(str, 0); + str =3D endptrc + 1; + endptrc =3D strchr(str, ','); + if (endptrc =3D=3D NULL) { + endptrc =3D strchr(str, 0); } - if (endptr - str !=3D 32) { + if (endptrc - str !=3D 32) { return 5; } entry->policy[value] =3D calloc(32 + 1, 1); strncpy(entry->policy[value], str, 32); entry->policy[value][32] =3D 0; - if (*endptr =3D=3D 0) { + if (*endptrc =3D=3D 0) { break; } - for (str =3D endptr + 1; *str =3D=3D ' ' || *str =3D=3D '\n'; str+= +); + for (str =3D endptrc + 1; *str =3D=3D ' ' || *str =3D=3D '\n'; str= ++); } return 0; } diff --git a/tools/libs/light/libxl_internal.c b/tools/libs/light/libxl_int= ernal.c index 2941ca0bbd0e..d70cfed7d88f 100644 --- a/tools/libs/light/libxl_internal.c +++ b/tools/libs/light/libxl_internal.c @@ -204,7 +204,7 @@ char *libxl__strndup(libxl__gc *gc, const char *c, size= _t n) =20 char *libxl__dirname(libxl__gc *gc, const char *s) { - char *c =3D strrchr(s, '/'); + const char *c =3D strrchr(s, '/'); =20 if (!c) return NULL; --=20 2.51.0