From nobody Wed Feb 11 10:38:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=invisiblethingslab.com ARC-Seal: i=1; a=rsa-sha256; t=1770769075; cv=none; d=zohomail.com; s=zohoarc; b=XzNUllV23XFwIzgvdRdLuw5pDBlZKNR7l0uygg58kyfLpLdRJ7SbDMxB1mlKi9fuVsPqjxEy5PEVUTN9hNh1lmkFa+OoBu3mjoZK8COgZkmJk2BuoljiTkjVj4yjeseoSdj2AGQHDM4T8ZmF7h0NHSr3bhnG7U5SboLz+VFvpds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770769075; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NNGrw/Lk4csgCTkIVJRy7t1JGaelexmkgu1xTW5pALU=; b=Tdkf/uvb6ZVmyO8dALo9TuqToMJdiRJPUYr8JxValKJ3IljVNR6htIlIs01hDELwl541nIhNt1Z5ikTQwzdHSobcms+ddyTNN2sZC1KYuMH9m4sik8Ojbhji1IbzqYlwdp3FPzuaMnL1yPLV4PHXUMQFERdZKsS1qZBJkynft+8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1770769075559208.30168020230224; Tue, 10 Feb 2026 16:17:55 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1226922.1533289 (Exim 4.92) (envelope-from ) id 1vpxuu-0001jM-Mr; Wed, 11 Feb 2026 00:17:16 +0000 Received: by outflank-mailman (output) from mailman id 1226922.1533289; Wed, 11 Feb 2026 00:17:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vpxuu-0001jE-Hf; Wed, 11 Feb 2026 00:17:16 +0000 Received: by outflank-mailman (input) for mailman id 1226922; Wed, 11 Feb 2026 00:17:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vpxus-0001j8-LD for xen-devel@lists.xenproject.org; Wed, 11 Feb 2026 00:17:14 +0000 Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01eae877-06df-11f1-b162-2bf370ae4941; Wed, 11 Feb 2026 01:17:11 +0100 (CET) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id 52A561D00071; Tue, 10 Feb 2026 19:17:10 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Tue, 10 Feb 2026 19:17:10 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Feb 2026 19:17:08 -0500 (EST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01eae877-06df-11f1-b162-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1770769030; x=1770855430; bh=NNGrw/Lk4csgCTkIVJRy7t1JGaelexmk gu1xTW5pALU=; b=kC0fPw2zcuuW6GjFA9BTjDeV4+zb/RdtiPJycalqpc71q/h7 +qOTHJ1LizwfMhayspYbG+YiwgJ8NCysYVgfiAsUE42ZpaEFy7HM5OAZvsW9kLHm DZpvan3r3dumnIAaGEUd94bEAQcTZIJFzvLHu/W2Sppwd0famOEQ9stx8aeYmyfW PS6TLXuRYhIC2QMv02ac7dx1H5LAIGf+i6JCBFcy+MhFrDemHAT6y1yO/6s8juzF 6y8mQf+xGcy5rPmsA6NON0QZJ3G5XekWwMD5FYDXYYpfZDU0mURTafnBBJdJcCYC QfJQO4JmYgJn3fh0lo4td2KU5wnv9KnWZHivWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1770769030; x=1770855430; bh=NNGrw/Lk4csgCTkIVJRy7t1JGael exmkgu1xTW5pALU=; b=uFKApVA+tBIic7c8LfYu2QHJVj/DSgmkLlscSStU7dYV m3nJHZRNwpYWhNlZY6/0kKo31qxerX6ME8jmhSclumV1+D84ekDTiFumSdadICAF UAUiOnaK0W1W/DFZdqXSJZGMX0gKZJMG041nuYqIfsqevCAFUBbRUTKeCLCz3wLb hC2JICm7CI+nboOW4PV90Rra4HWVvaydRRuKrsyXTGwq+d18cubq8PG3vOwKqbPh BA79FGTRtHX9UsFxdZnmqEYREhoJqJ3aQxlSjG2jd1EZl3JzM/z2fEeI7KXLPpXL GfIgoiNZ9OQOPHHDeNgkSgzkGGLgOTVMyeggzQ2D+g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvtddutdekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghkucfo rghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefhudel teelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhn vhhishhisghlvghthhhinhhgshhlrggsrdgtohhmpdhnsggprhgtphhtthhopeegpdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopeigvghnqdguvghvvghlsehlihhsthhsrdig vghnphhrohhjvggtthdrohhrghdprhgtphhtthhopehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmpdhrtghpthhtohepughpshhmihhthhesrghp vghrthhushhsohhluhhtihhonhhsrdgtohhmpdhrtghpthhtohepjhgsvghulhhitghhse hsuhhsvgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , "Daniel P. Smith" , Jan Beulich Subject: [PATCH] EFI: Fix relocating ESRT for dom0 Date: Wed, 11 Feb 2026 01:16:42 +0100 Message-ID: <20260211001650.1592239-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @invisiblethingslab.com) X-ZM-MESSAGEID: 1770769076837154100 Fix calculating the table size - it consists of a header + entries, not just entries. This bug caused the last entry to have garbage in its final fields, including LowestSupportedFwVersion and CapsuleFlags, which (usually) made fwupd to detect firmware update availability, but refuse actually installing it. Fixes: dc7da0874ba4 ("EFI: preserve the System Resource Table for dom0") Signed-off-by: Marek Marczykowski-G=C3=B3recki --- xen/common/efi/boot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 5b84dbf26e5e..45015a0dd583 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -675,7 +675,8 @@ static size_t __init get_esrt_size(const EFI_MEMORY_DES= CRIPTOR *desc) if ( esrt_ptr->FwResourceCount > available_len / sizeof(esrt_ptr->Entr= ies[0]) ) return 0; =20 - return esrt_ptr->FwResourceCount * sizeof(esrt_ptr->Entries[0]); + return offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries) + + esrt_ptr->FwResourceCount * sizeof(esrt_ptr->Entries[0]); } =20 static EFI_GUID __initdata esrt_guid =3D EFI_SYSTEM_RESOURCE_TABLE_GUID; --=20 2.51.0