From nobody Thu Dec 18 09:45:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1765902791; cv=none; d=zohomail.com; s=zohoarc; b=PZMtZKiLvEB7y/u9dX6ftNj7nBqvzYvDfqBjbIQGcIjRTqhHj+mxuNf5sg6Ihp+U/jZA1vR0LQwlKhF3KzU2e1xv3CwBDEc3I6Dj1q1FCLlv5h/GvuVAaz17KwJXnhATPVnmC6HlxvPWroiGLxFGwGk0cFiEABbHNn42xAN3J3Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765902791; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mgFzPujzf54tak0q7FrhW+uWSwtYPNMPJZRSoWURja8=; b=DoULSYRmDSBsvr+GBD6a4gZvY3sXP/JUaEgk+JOpLdSKOZKqCWXEa6etocLpc/EX8uc+k53gXaaRHRqcYHuoXCti1megEWmtBy83yoaAk0dWeZi3tKJAxjtaPLZwkw3ynNPEWygU8xHatQf5NB0M8rFyKOrd27LyQ4Wv5W3o04s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1765902791382268.18313241306487; Tue, 16 Dec 2025 08:33:11 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1188081.1509328 (Exim 4.92) (envelope-from ) id 1vVXyZ-0001Qg-Eb; Tue, 16 Dec 2025 16:32:39 +0000 Received: by outflank-mailman (output) from mailman id 1188081.1509328; Tue, 16 Dec 2025 16:32:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vVXyZ-0001QY-9t; Tue, 16 Dec 2025 16:32:39 +0000 Received: by outflank-mailman (input) for mailman id 1188081; Tue, 16 Dec 2025 16:32:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vVXyY-0001Pz-2V for xen-devel@lists.xenproject.org; Tue, 16 Dec 2025 16:32:38 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4e66c2f-da9c-11f0-b15b-2bf370ae4941; Tue, 16 Dec 2025 17:32:37 +0100 (CET) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so36946905e9.2 for ; Tue, 16 Dec 2025 08:32:37 -0800 (PST) Received: from localhost.localdomain (host-92-26-102-188.as13285.net. [92.26.102.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bd994a221sm12994765e9.7.2025.12.16.08.32.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 08:32:35 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4e66c2f-da9c-11f0-b15b-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1765902756; x=1766507556; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mgFzPujzf54tak0q7FrhW+uWSwtYPNMPJZRSoWURja8=; b=OdyqZT5RzzYpa+v0CIyxPoR0KCYb6eADDuSyJn44qjmFeB44qDrjt3uIXYucZlY5Pw mlL241m5tyJHkSOK7A3bbRa6POZoTYtPw57y4yKYfy5BIUa3M/S2rH4n13jauqcXpEM5 lPf6OttoPeaRqnaIj0LYyZdfQceFY5TD1iPD0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765902756; x=1766507556; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mgFzPujzf54tak0q7FrhW+uWSwtYPNMPJZRSoWURja8=; b=v9z8L4mTk+lnvL4MnPrv3/JgNkL4ZDyPkvDjFke3BL53BOfjNGQcWD6uqLMW7vnABv GYso1fLCGzmLDNxrXZHW1tgioWaYgoT2gLLBrmSkaiQgo39pdMgBEap08igu1Q6OvR7h 1VMkKQ3arJeKQSDngfcm4ULORNesnr85qd6PaeJYcitNcnRJKPQ9h4jvShVtVMOWwT4e A2gE6cLa5MqJKb+lpKVGwk3Zoapm48SrbI9jFaF0wvuvqRZk8xLK9xbJmX+KIkiWhRSO iRfItzY9gmVUzF3WIZO4RJxMrxjFU1O+qYTRipd+tAynIP5e7uPLnIR3ZUdIIAoCJLpi CMOg== X-Gm-Message-State: AOJu0YwrAGhXUFFIjJ3YuHDPp9FX+kPRr9qNXP5MgwLS28snQnV8QW7b 6fvyNN87kx7r1tdqbW8IFd31NlQ4bbUjGbYEwuT0lfb/X8KZLPjyixUg7bB+/J+jytTIXuhbjIt OkwR1 X-Gm-Gg: AY/fxX5akFu8Qu8wVFcoHxPKs4kSpWQXofZ6y4Qe7uAHx1UiyiJ/QhJN9Vz2tiVMOtz JPZ54cuGuHZYh3e86ExNukMFcQda1S9C9cQwdAGNF5anKSQnwhd9LCRybCixbNldAR3ebydze3s AORQbG4RWPhUBy7r1/WtuEWOj55RwY7tN6BgWoL2SKzMQHja1n3HypI8BJc893bM+Im8JjBueH3 JJtXw4iwTO3n4Oh4trfY+IyMn34OcrYcZWDm1o5X6EF0Of1rrN/vZO2zbcv5t8sCQ0rGy0DzEDt z45X2lfgzzwzdXq2WloHck6huYpPI5ZzznwPHy7e15koPv5VJWxRH1ssQ5W0WOhq1Qgi08GFnjD 1BvuwIUYt90STnhwCi91YtAoqX1duZhojA0Dkibe50cB9Rjo4ujVZH6Zk7VGvXBktt4xs3euzoZ yN4Ym9VBpkYHwM3gsaVrMxyd5Imz5oGJM9HlHR8o9dqk+i/wgqFnrz4r/wOPgd8g== X-Google-Smtp-Source: AGHT+IF8/pq5lRwmiKyouqxflWlhNHwkTUT8LmvNn8ZyikT3BUT1yxWKWhQ3I1pXvzHrRZJwrUXG3w== X-Received: by 2002:a05:600c:4e91:b0:477:641a:1402 with SMTP id 5b1f17b1804b1-47a8f8ab745mr156950825e9.4.1765902756170; Tue, 16 Dec 2025 08:32:36 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH 1/4] xen/domain: Disallow XENMEM_claim_pages on dying domains Date: Tue, 16 Dec 2025 16:32:27 +0000 Message-Id: <20251216163230.2768186-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251216163230.2768186-1-andrew.cooper3@citrix.com> References: <20251216163230.2768186-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1765902792603158500 XENMEM_claim_pages can be issued on a domain in the later stages of domain_kill(). In that case, the claimed memory is leaked, as there's no w= ay to subsequently release the claim. Claims are intended for use during domain construction; to reserve sufficie= nt RAM to construct the domain fully. There's no legitimate reason to be call= ing it on a dying domain. Fixes: 65c9792df600 ("mmu: Introduce XENMEM_claim_pages (subop of memory op= s)") Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini --- xen/common/memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/common/memory.c b/xen/common/memory.c index 3688e6dd5032..ae805ccbe4d1 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1681,6 +1681,9 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE= _PARAM(void) arg) =20 rc =3D xsm_claim_pages(XSM_PRIV, d); =20 + if ( !rc && d->is_dying ) + rc =3D -EINVAL; + if ( !rc ) rc =3D domain_set_outstanding_pages(d, reservation.nr_extents); =20 --=20 2.39.5