From nobody Sun Dec 14 06:21:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1765555598; cv=none; d=zohomail.com; s=zohoarc; b=FCfzNSUILrmfgEpB/+XWroEttu1NmzVraHeLJR2gZqZExBB9PnqfDiYR6bwW71CQoATj4dNelC+o9ZOf5QDvKEIf659cSPlC9/1lU7cCLe0NhHGxWo+d8OqMzC3mxfckpJ3eHT23NB6RTW1f49x2mKYLKWSfuRRoRxt0KPBwCE4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765555598; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ilh1940cXuR+im2NE2+oUxOQVII3GAVTO2GQRPcJ7uA=; b=kzUXWfM5PBrM9j1rltAhxdb6yq8i/Fgl1YbFOV3bFJlT8zcoKuBp8RAW8QM4mGPsFMjtDoU8nX9QVrwJe7ihcwJX7NmGj4eZhsTgul8b6BAqSEGuj2QfZOcYdEVhShu2UTNkAbO269FDgtIjmkTfA/4B6ZKmBmwCss4Jm8n7Gyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1765555598667395.8489440335487; Fri, 12 Dec 2025 08:06:38 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1185543.1507651 (Exim 4.92) (envelope-from ) id 1vU5et-0001ir-Ve; Fri, 12 Dec 2025 16:06:19 +0000 Received: by outflank-mailman (output) from mailman id 1185543.1507651; Fri, 12 Dec 2025 16:06:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vU5et-0001ik-T0; Fri, 12 Dec 2025 16:06:19 +0000 Received: by outflank-mailman (input) for mailman id 1185543; Fri, 12 Dec 2025 16:06:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vU5et-0001ie-JK for xen-devel@lists.xenproject.org; Fri, 12 Dec 2025 16:06:19 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7e594cf8-d774-11f0-b15b-2bf370ae4941; Fri, 12 Dec 2025 17:06:18 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4779cc419b2so15599515e9.3 for ; Fri, 12 Dec 2025 08:06:18 -0800 (PST) Received: from localhost.localdomain (host-92-26-102-188.as13285.net. [92.26.102.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f8f3894sm38530395e9.15.2025.12.12.08.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 08:06:17 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e594cf8-d774-11f0-b15b-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1765555578; x=1766160378; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ilh1940cXuR+im2NE2+oUxOQVII3GAVTO2GQRPcJ7uA=; b=O1pql3mvvaVZWn27YFGgpZp1MEeo2qWBZBu/UCMf9uaNbzAQVzSx05OSkF6vO1/CLA 9sq2GyFAYq50ZzM7arD2r0WzStGAOHVMabc64xiNwWRphyR4DJMEzyYmGAdyzB2FThvv mf0bMfXRgi1H7AZqWM9NNE3hOBAkZhQqPIyUc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765555578; x=1766160378; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ilh1940cXuR+im2NE2+oUxOQVII3GAVTO2GQRPcJ7uA=; b=hOVknMx3ztwHtfkzrUKy1X6+ZFF423fj7IVMs3FbYyVBspWyxQm7vQN3yyRAdO9DrU +BqcDy2dXlbWysZJszwK8mNBSw73gGqCj9M4E6H+83JQ0Ag1PjGNDrKNVV+P0xXTI0AQ P0QmqV5bcM8OYPMw6GDh6uKvuxfXdqG1YMELW2a8F3FalMPVEzdQXBfP3FY2qFMh9A1C TKzs/7o+RXZomRq+WEFzMK7Wc5m6FSfId48Mq+xdqjChp69GgvFFwiFsKcO9v7z9uKZE TzO7x2m6A56FBF+kgsIuecbabG4hRsnkKLhOEB+ydU3qWl0aG8CmHa/hN2AtEUmQ/TSz 6u7A== X-Gm-Message-State: AOJu0YwZIZH/cSiprIDeAvLwJxY/0Wg6v8ZIVmVTpD14+TY/RWYJ+Jdi XrV1CtqNs0mv27HDYlHupUe7Aiys25lWyQ+9zeVk6rZ80bE+pXS4w8CaMqVKCfQmOWmK7MMOY8K gxQR3 X-Gm-Gg: AY/fxX6MXsPVg0V8IPJCx/7MST5CxVBZm2KcnAf/8ERAusUWpcIHHZw/x1wyVraiD+c taus/SSfLJt8U65EpwiUmuHsUQeCkRYUlKFPMnTPSlxghF7PVSVCH9Vz8agIXOoN/jz7xcuz7+w eoh36zgRXmMjiAyljtEvOUS/SnrETmPbUGOiiLsMLpl03Rckpj1ebSe98ihj4kLOsOxYc5QIwfN +JdJJ2gN3cyR0zAt2hqwLKZKURMUjdAsERIrCUDqjfx2Tlbkso90fmCaY9C3b4XyTcnn+ZT89kB jVEQB14AQOR5NJNluCxl51fFIw11Bw58lk4rlAqznXc2BfJwGJMiyxoNOnAeBE/FvfzLukFTDKY nzdaOu8NCiKNa64mfg2OarpJGABhE8epA2rWS4TA3LbEsYHGLvYmHE5u1R8MEKg4o5iQs7xJle+ FnrYYkXBQ5/vIYpgOGmTtbwi/i8K+9YHhFQyI1KOx0dQhc87Smte5yw3KuVd6Vu5R+e9nu9cl0 X-Google-Smtp-Source: AGHT+IGE0sVGOy54GyGnv76mv0eFlPZ/uPMhlDveanIeu0bgHvAEf/xJVeqbj+zk5DK9JT0EWPrKeA== X-Received: by 2002:a05:600c:3146:b0:479:3a88:de5f with SMTP id 5b1f17b1804b1-47a8f9174f3mr23757785e9.36.1765555577682; Fri, 12 Dec 2025 08:06:17 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH] x86/shadow: Move GUEST_PTE_SIZE defines into types.h Date: Fri, 12 Dec 2025 16:06:15 +0000 Message-Id: <20251212160615.2486055-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1765555599838158500 GUEST_PTE_SIZE are only used by multi.c, but private.h gets used by code th= at doesn't have GUEST_PAGING_LEVELS defined. Eclair notes that this is a violation of MISRA Rule 20.9. Move it into types.h with the rest of the level-dependent logic lives. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/mm/shadow/private.h | 7 ------- xen/arch/x86/mm/shadow/types.h | 7 +++++++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/mm/shadow/private.h b/xen/arch/x86/mm/shadow/priv= ate.h index 1ef908a380de..bc99e00100f7 100644 --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -121,13 +121,6 @@ enum { }; =20 =20 -/* Size (in bytes) of a guest PTE */ -#if GUEST_PAGING_LEVELS >=3D 3 -# define GUEST_PTE_SIZE 8 -#else -# define GUEST_PTE_SIZE 4 -#endif - /*************************************************************************= ***** * Auditing routines */ diff --git a/xen/arch/x86/mm/shadow/types.h b/xen/arch/x86/mm/shadow/types.h index d700d8d64c8a..13d13c52c007 100644 --- a/xen/arch/x86/mm/shadow/types.h +++ b/xen/arch/x86/mm/shadow/types.h @@ -18,6 +18,13 @@ #define SHADOW_PAGING_LEVELS 3 #endif =20 +/* Size (in bytes) of a guest PTE */ +#if GUEST_PAGING_LEVELS >=3D 3 +# define GUEST_PTE_SIZE 8 +#else +# define GUEST_PTE_SIZE 4 +#endif + /* * Define various types for handling pagetabels, based on these options: * SHADOW_PAGING_LEVELS : Number of levels of shadow pagetables --=20 2.39.5