From nobody Fri Dec 12 19:35:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1765391459; cv=none; d=zohomail.com; s=zohoarc; b=H1Vtt7UkYHcrPBtbRfuvEggLo9F3qOvpA6j1SDEDzhs0zp/mPjx/GUhLRyJfua4XPL+GWJ3rC7dGE82SQIm4r3AsRY52kxWX6Ez8p302EFv3ZQugLGq7dVw4hJx0yJ+pbik79uNwIVSDXpYpYExOacuxuuvE5yJsXfVEj+ZSOCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765391459; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ti+Hvm59056La23/HEYy2xtiFbDlfvWnYziHMb4xycg=; b=fB7LcWRW7q0954X8GVyilZWsSlbiEKl5qbAXHxBUXy1UL+KNZ0NrC4INNkFN/9y27sWOyjnXX4ytU26mtf+RVeOU31QmMdXG96+9t32cpHfOCWhI3f/zuxzRkybwthA+NASOFTiKyY9NF9mkCH8ofX0aWY0Lo2ZIQv3Ws0mAFFU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1765391459210732.0239831321858; Wed, 10 Dec 2025 10:30:59 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1183167.1505959 (Exim 4.92) (envelope-from ) id 1vTOxI-0005FK-Na; Wed, 10 Dec 2025 18:30:28 +0000 Received: by outflank-mailman (output) from mailman id 1183167.1505959; Wed, 10 Dec 2025 18:30:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxI-0005FC-IJ; Wed, 10 Dec 2025 18:30:28 +0000 Received: by outflank-mailman (input) for mailman id 1183167; Wed, 10 Dec 2025 18:30:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxG-0004rG-J6 for xen-devel@lists.xenproject.org; Wed, 10 Dec 2025 18:30:26 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ac86b91-d5f6-11f0-9cce-f158ae23cfc8; Wed, 10 Dec 2025 19:30:24 +0100 (CET) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-47790b080e4so567385e9.3 for ; Wed, 10 Dec 2025 10:30:24 -0800 (PST) Received: from localhost.localdomain (host-92-26-102-188.as13285.net. [92.26.102.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a886affb4sm1696105e9.3.2025.12.10.10.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 10:30:23 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ac86b91-d5f6-11f0-9cce-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1765391423; x=1765996223; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ti+Hvm59056La23/HEYy2xtiFbDlfvWnYziHMb4xycg=; b=rAbAuGK+pR6jmJYMG1fapUrZNKVOsnxbdrstyG5U0QLxbMhv/ml7mhFsPTXNw+UBz/ ztV3YPzBj2reYH3wW3SwJQpA8GU6jROue8lmix8/iPb/bkj2frt1I+7AEKvaZWlRWtvK +1bSmOZ484XH5iDfRMipUGdLh4I2uGeOaYzOI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765391423; x=1765996223; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ti+Hvm59056La23/HEYy2xtiFbDlfvWnYziHMb4xycg=; b=cKbxJf1lXFXYVG87f00v4BFcbSRIt4iRu+v+CFehjpPvCmM99DjCwAzUGVZ8IjXkio Fbw7XR+F4pTvgwDErsJwbxCA2nLTGGRlxS+ng6ugCwkqqYxBedVSNxzGe+lOAqA25nN+ f2EIdef3aaTO4+8wSHrnYCsfwe/49QjcwGXuPuuZNH2E8MatoAGNxsHrCLQm7E/DKrum /Bmw2/CZCkP4Hswum7vQ2BUqL+MMCPBqE3M4L2UGAizJmiVTu+hJVP0WNWA7hWXAm287 4BS51utWCJLl9fNfZQ+1i4Yon4rFB9yjuB7wmMNUG4ImN2kxcG3LaBsB24e2uCiRXz89 B/mA== X-Gm-Message-State: AOJu0Yw7d0Fh4GcU0AmFw58IiwX0S8eeYW2KnWnXfJLb7lBP7I7nB+ej 28czw/vrYATg8ntbGf/C1AFg9PzLhxfedHxDMSedINp193yC9vzMVFhNAkN2EKO0AcwczN0YAvl 3yjum X-Gm-Gg: ASbGncuc4n+jYkLbUos2/+jiIhPTMrLzk22cQLXnGU7fIv5I9KSXPlP9PjJ5rh+XZKk 2yZH8AukJdNPsARvRzJFN5rX4Kw5SZT646CTknTiC24mrCciIOUXD60eXzUQ+695t8DQeuiAty0 R8WejmMQ76C22Pz0GYklBal97oEFW8/GjMQp2ZlWUhmRuH5cABr+CxiwozyFEOPBuxLAqIIWfQL Eg/JuotCY4w0g2Fgu8etihly5Odkk2VUljO87AehB7PwwcqXQiy7CqRCdW3xVaSydP7kcw82l9N NjJLa81CZLnxP9emUUstZMv1H1v7qbI/8oAtKAYavB/CQIcu/8kxw9hxAdLnqlGo5gON+qs3gbP JX14+6/6WaHPohVW58L12q8EYk2dJUCvnh3xb9gzvbcfgwYUgJJuEJjUBGmACe5H25YYr1qWHwH RRapk4IMyuwH45qfLpnmmVHSal2i/+E9HM7lP/K6FaQbNQe2gvUCtSwAa/qlWJRw== X-Google-Smtp-Source: AGHT+IFSBGzM681v8a/IFHC4hCHLgFm92UNB1QnWymlV4pjLJLX0hFH+xN5vczoOq4b96y7TcM6aTw== X-Received: by 2002:a05:600c:1e24:b0:479:3a88:de5e with SMTP id 5b1f17b1804b1-47a8385368dmr24338165e9.37.1765391423515; Wed, 10 Dec 2025 10:30:23 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 1/5] x86: Misra fixes for U/L suffixes Date: Wed, 10 Dec 2025 18:30:15 +0000 Message-Id: <20251210183019.2241560-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251210183019.2241560-1-andrew.cooper3@citrix.com> References: <20251210183019.2241560-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1765391461121158500 With the wider testing, some more violations have been spotted. This addresses violations of Rule 7.2 (suffixes required) and Rule 7.3 (L must be uppercase). For ELF64_R_TYPE(), cast to uint32_t matching the surrounding examples. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/mm/shadow/common.c | 4 ++-- xen/arch/x86/pv/descriptor-tables.c | 2 +- xen/drivers/passthrough/vtd/iommu.h | 2 +- xen/include/xen/elfstructs.h | 2 +- xen/include/xen/sizes.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/commo= n.c index 0176e33bc9c7..423764a32653 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1961,7 +1961,7 @@ int sh_remove_write_access(struct domain *d, mfn_t gm= fn, /* FreeBSD 64bit: linear map 0xffff800000000000 */ switch ( level ) { - case 1: GUESS(0xffff800000000000 + case 1: GUESS(0xffff800000000000UL + ((fault_addr & VADDR_MASK) >> 9), 6); break; case 2: GUESS(0xffff804000000000UL + ((fault_addr & VADDR_MASK) >> 18), 6); break; @@ -1969,7 +1969,7 @@ int sh_remove_write_access(struct domain *d, mfn_t gm= fn, + ((fault_addr & VADDR_MASK) >> 27), 6); break; } /* FreeBSD 64bit: direct map at 0xffffff0000000000 */ - GUESS(0xffffff0000000000 + gfn_to_gaddr(gfn), 6); + GUESS(0xffffff0000000000UL + gfn_to_gaddr(gfn), 6); } =20 #undef GUESS diff --git a/xen/arch/x86/pv/descriptor-tables.c b/xen/arch/x86/pv/descript= or-tables.c index 02647a2c5047..26f7d18b11b5 100644 --- a/xen/arch/x86/pv/descriptor-tables.c +++ b/xen/arch/x86/pv/descriptor-tables.c @@ -216,7 +216,7 @@ static bool check_descriptor(const struct domain *dom, = seg_desc_t *d) * 0xf6800000. Extend these to allow access to the larger read= -only * M2P table available in 32on64 mode. */ - base =3D (b & 0xff000000) | ((b & 0xff) << 16) | (a >> 16); + base =3D (b & 0xff000000U) | ((b & 0xff) << 16) | (a >> 16); =20 limit =3D (b & 0xf0000) | (a & 0xffff); limit++; /* We add one because limit is inclusive. */ diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/= vtd/iommu.h index 29d350b23db6..4f41360c53c0 100644 --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -266,7 +266,7 @@ struct dma_pte { #define DMA_PTE_PROT (DMA_PTE_READ | DMA_PTE_WRITE) #define DMA_PTE_SP (1 << 7) #define DMA_PTE_SNP (1 << 11) -#define DMA_PTE_CONTIG_MASK (0xfull << PADDR_BITS) +#define DMA_PTE_CONTIG_MASK (0xfULL << PADDR_BITS) #define dma_clear_pte(p) do {(p).val =3D 0;} while(0) #define dma_set_pte_readable(p) do {(p).val |=3D DMA_PTE_READ;} while(0) #define dma_set_pte_writable(p) do {(p).val |=3D DMA_PTE_WRITE;} while(0) diff --git a/xen/include/xen/elfstructs.h b/xen/include/xen/elfstructs.h index eb6b87a823a8..8770e7454672 100644 --- a/xen/include/xen/elfstructs.h +++ b/xen/include/xen/elfstructs.h @@ -360,7 +360,7 @@ typedef struct { } Elf64_Rela; =20 #define ELF64_R_SYM(info) ((info) >> 32) -#define ELF64_R_TYPE(info) ((info) & 0xFFFFFFFF) +#define ELF64_R_TYPE(info) ((uint32_t)(info)) #define ELF64_R_INFO(s,t) (((s) << 32) + (uint32_t)(t)) =20 /* diff --git a/xen/include/xen/sizes.h b/xen/include/xen/sizes.h index f7b728ddab06..d309ebf04406 100644 --- a/xen/include/xen/sizes.h +++ b/xen/include/xen/sizes.h @@ -43,6 +43,6 @@ #define SZ_512M 0x20000000 =20 #define SZ_1G 0x40000000 -#define SZ_2G 0x80000000 +#define SZ_2G 0x80000000U =20 #endif /* __XEN_SIZES_H__ */ --=20 2.39.5 From nobody Fri Dec 12 19:35:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1765391450; cv=none; d=zohomail.com; s=zohoarc; b=c9LnqGHWyJdQayW9cwYuSHJnLoDZZdSTB3jjEJvfS9WqF4qWpK+nS55+OUNvLwbCM3f3sc54FpNasasSVPeGgKXlG5+GCNISfa7Ok0+PYZNN/jdqWC80wU0PUBNO1V9Lywu3IMuU0/KAVw6Misg+V1YK5QFj6bmQ8qqrKOHE6HU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765391450; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gXlGQkwfcCxQQOprXhg3Avtbe6KMUEWZIGR1FuxDrBM=; b=HNUQqc31b55x0DwI5ETQAFXsGj74ibpMeRgj6rfH3aZC42qXPJTeutnIgxiVpeSo5zwfI7WnUReVgzUf5+X6KqnHgQSXJNjS2GbxC0g+k2RQuN2ifCsFHbdhkzHpCUnMINqtxFcUQYA0iGmtyuUcj8rYR0bDQ/NWtIxiwyXVINE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1765391450855674.4994377201994; Wed, 10 Dec 2025 10:30:50 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1183166.1505948 (Exim 4.92) (envelope-from ) id 1vTOxH-00051L-9q; Wed, 10 Dec 2025 18:30:27 +0000 Received: by outflank-mailman (output) from mailman id 1183166.1505948; Wed, 10 Dec 2025 18:30:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxH-00051E-6z; Wed, 10 Dec 2025 18:30:27 +0000 Received: by outflank-mailman (input) for mailman id 1183166; Wed, 10 Dec 2025 18:30:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxF-0004ng-Q1 for xen-devel@lists.xenproject.org; Wed, 10 Dec 2025 18:30:25 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4b5a0a7b-d5f6-11f0-b15b-2bf370ae4941; Wed, 10 Dec 2025 19:30:25 +0100 (CET) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4779a4fc95aso7699205e9.1 for ; Wed, 10 Dec 2025 10:30:25 -0800 (PST) Received: from localhost.localdomain (host-92-26-102-188.as13285.net. [92.26.102.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a886affb4sm1696105e9.3.2025.12.10.10.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 10:30:23 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b5a0a7b-d5f6-11f0-b15b-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1765391424; x=1765996224; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gXlGQkwfcCxQQOprXhg3Avtbe6KMUEWZIGR1FuxDrBM=; b=jWpgI23WpVKistLs/0n37uNhuTJiWeNj8nnqBp7TZwKd4cb14P4cCACxhfiSV5yd/Q vU/4cXe76vAPJlax9L6rfE14OoQFzs7dgmKQ3TFezmOeW3BNkmUVupCg/KXalRCROHTb d8MuBZPSOqAUx0150oTjabgptaTKq/PB1KG98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765391424; x=1765996224; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gXlGQkwfcCxQQOprXhg3Avtbe6KMUEWZIGR1FuxDrBM=; b=XRHubag904gUhkDTtPIA8mlcFPJ5rqLhIftr6i0OGAyVUW5YJPxke7K3qfIlgOCCfD nO30FugR3juQseFERNmd6itYrusiX2WZoFRfY5Ndo6MWIVwwhQIpPvi14m9wb3/KVfeh OzsFgVI4BBgNWDjX2MZrIX7q1SadYr3WJRN5MQbOMclSoXCghYXHfQ4N7z9z+sKyXat4 3tRixgJTkmC/gPUfSppIKo30x2b4qvEqYAD+/p61jHtDKgQdkM8WmCa+3tB7RpeMRMWY VhVSQv9LifoHMnj+TAXFv5k0qElf98Lcczzk2BJNyIGamiOS5Q8NwG6Bd4poUnaPTGLp 2NCg== X-Gm-Message-State: AOJu0YzVR3Yyrerg1cJrteYYned5eCPUfbGE2SP6q3wrs7Az080YpIl0 PeuISky1J6G6ItaE3w//fBu4h8pOwLYQMC6iAzFdta9fHhskFIurDIjt4ulqry5+ODJmqM/05qG uwdKx X-Gm-Gg: ASbGncu/dFDUkjsR4OuQifAFS98L+U0FW8B4swVzIMFDf3cHMGI000E6mXwvk9w8HW+ bRDgS2lQrhjs/6Z6nexkRoU49ZCc8/4WWLPFJXMMG18nHJ/Lh+2X2qXJn509l149ISELL2TOTRH MtuMRVGTwVeXWoOh6jJPRl+ZJnTP00+EqSjR7CqQd96/KjA3gB/7grAuP/DPiZXekHx4GjxNSLg rwlxFVrrZTmM/AMU85C9jxOTlxKFCxPB9UZpH3OPBcmTaaQojjmbJk+awsE6m+o6Hr+SuVzl5VK SeU6WRsPZnx0TqbRmdu42dRPRGadFk1/9fZ6AEVlwQ7fAE/fyC2VY/V1EOtWW7+HWP0Gza7CdYH yteg/QNx2gF0EEFRBdUmOt6Gf/v9Jwp6ovmmGn10l2wCTh9Jk/NdG1qtdJ3MXg1QOCeSHZpItgo uxWucsvFlgYCgSxPHulP11vVOhHr7kL6Mdvq3aIOGjlCt7XxAQWhZ+dD0uWIfc2M087D/PdrWL X-Google-Smtp-Source: AGHT+IG6IxhUYRlqB9519aXljEJ/a6K9eF2sKqb96XyJ+RfzgRL02xBb1EsXo11siJK5f5VrHBFIFw== X-Received: by 2002:a05:600c:540f:b0:479:13e9:3d64 with SMTP id 5b1f17b1804b1-47a888cd013mr4093975e9.15.1765391424407; Wed, 10 Dec 2025 10:30:24 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 2/5] x86: Name parameters in function declarations Date: Wed, 10 Dec 2025 18:30:16 +0000 Message-Id: <20251210183019.2241560-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251210183019.2241560-1-andrew.cooper3@citrix.com> References: <20251210183019.2241560-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1765391453050158500 With the wider testing, some more violations have been spotted. This addresses violations of Rule 8.2 (parameters must be named). No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/mm/shadow/common.c | 8 ++++---- xen/arch/x86/pv/emul-priv-op.c | 2 +- xen/include/xen/livepatch.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/commo= n.c index 423764a32653..f2aee5be46a7 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -69,11 +69,11 @@ const uint8_t sh_type_to_size[] =3D { =20 DEFINE_PER_CPU(uint32_t,trace_shadow_path_flags); =20 -static int cf_check sh_enable_log_dirty(struct domain *); -static int cf_check sh_disable_log_dirty(struct domain *); -static void cf_check sh_clean_dirty_bitmap(struct domain *); +static int cf_check sh_enable_log_dirty(struct domain *d); +static int cf_check sh_disable_log_dirty(struct domain *d); +static void cf_check sh_clean_dirty_bitmap(struct domain *d); =20 -static void cf_check shadow_update_paging_modes(struct vcpu *); +static void cf_check shadow_update_paging_modes(struct vcpu *v); =20 /* Set up the shadow-specific parts of a domain struct at start of day. * Called for every domain from arch_domain_create() */ diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index 225d4cff03c1..08dec9990e39 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -40,7 +40,7 @@ struct priv_op_ctxt { }; =20 /* I/O emulation helpers. Use non-standard calling conventions. */ -void nocall load_guest_gprs(struct cpu_user_regs *); +void nocall load_guest_gprs(struct cpu_user_regs *regs); void nocall save_guest_gprs(void); =20 typedef void io_emul_stub_t(struct cpu_user_regs *); diff --git a/xen/include/xen/livepatch.h b/xen/include/xen/livepatch.h index d074a5bebecc..3f5ad01f1bdd 100644 --- a/xen/include/xen/livepatch.h +++ b/xen/include/xen/livepatch.h @@ -62,7 +62,7 @@ struct livepatch_fstate { uint8_t insn_buffer[LIVEPATCH_OPAQUE_SIZE]; }; =20 -int livepatch_op(struct xen_sysctl_livepatch_op *); +int livepatch_op(struct xen_sysctl_livepatch_op *op); void check_for_livepatch_work(void); unsigned long livepatch_symbols_lookup_by_name(const char *symname); bool is_patch(const void *addr); --=20 2.39.5 From nobody Fri Dec 12 19:35:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1765391447; cv=none; d=zohomail.com; s=zohoarc; b=WZT/BNSEWFL0oS6K4idlPXiqkEcTzVnF/MfojOMiYSTpMhS4SM4AslvMUddVD0ezoSyDkrWpcdph6vOo4aIysB37ZQJh+xvY5wdAwWtaTMt6y0pyX2iEobqnncO5de3UhIFPp5704Yit/HgilId3WfR83daVyy3IfHwsz6pW8Lc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765391447; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=K1BDD7FU2KbDO2LpONmlE2QWUa+uDn0AG5zZpbddTqA=; b=BCly/bpN3WVuEIbAp0huEqR6/oTyrUXTMECfB96Eqc549CqZ4vAzJyhzWA+lOZvqkRsCLmEiHYq6H9lpVsRBBILejLKVL+zxf3MMtDxcSXi68e4FkMUcLxWn1h+HMibm2lCiIBz1wgz0czfxEVu5bdrDLBVWB4l1mBB7omE7A+Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1765391447289592.1161925712306; Wed, 10 Dec 2025 10:30:47 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1183168.1505964 (Exim 4.92) (envelope-from ) id 1vTOxJ-0005Ik-0P; Wed, 10 Dec 2025 18:30:29 +0000 Received: by outflank-mailman (output) from mailman id 1183168.1505964; Wed, 10 Dec 2025 18:30:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxI-0005IK-Rw; Wed, 10 Dec 2025 18:30:28 +0000 Received: by outflank-mailman (input) for mailman id 1183168; Wed, 10 Dec 2025 18:30:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxH-0004rG-PA for xen-devel@lists.xenproject.org; Wed, 10 Dec 2025 18:30:27 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4bc302cf-d5f6-11f0-9cce-f158ae23cfc8; Wed, 10 Dec 2025 19:30:26 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-477b198f4bcso810175e9.3 for ; Wed, 10 Dec 2025 10:30:26 -0800 (PST) Received: from localhost.localdomain (host-92-26-102-188.as13285.net. [92.26.102.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a886affb4sm1696105e9.3.2025.12.10.10.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 10:30:24 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bc302cf-d5f6-11f0-9cce-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1765391425; x=1765996225; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K1BDD7FU2KbDO2LpONmlE2QWUa+uDn0AG5zZpbddTqA=; b=RymjeU0CRf+6FgVNSRuIM9uPnr0/8J4SW/MIQoNs7NgwYwxSJR3sBR0JzMnZWhCfpW /8t7Srly6JkHjRWKaSUjf7nErd+T/9Fd96iJkQRn9MhnUPqr5/ZqCzqdHbhQeYJIemb3 6UCDTwlUK/ndSnvQD54ekRKOumUy1pz48vzMs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765391425; x=1765996225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=K1BDD7FU2KbDO2LpONmlE2QWUa+uDn0AG5zZpbddTqA=; b=Sei6D66c3FafjTbTNzETX6bDPRJH7lvovCOI7ufvsmyjw5R/0hkqSVgw45e3ji/bSE EaGuEb6abtMM5dBUKNelJ4EO9cxLMoDCPhfkMtTpXr4f9lfZfHCxbS6D812fSdKD7jXl 7a6scEfmCz8QpqDkT0eHE3kZ/rXQdvuod/RK1YsO4YJzRX1KaTYbTJ25kLJ1Tfe6vioZ lccmJw2j3hJnna3yjKXZwS/dm3vdEQZVtjrlEdNotuSK4HOYDSqEDB5nud2OcwG+FfCP zwkJ0T4yy3sENmx4Ek0ztqRSzFvCyNz3vfG/eUH45HLmG5z10KoAaQCsGCg/5Yg1SNbH nkvw== X-Gm-Message-State: AOJu0YygC6CgT6W2l7pIR+JE/tbiJkXi4xDVadvlRB4CZUGvraIDfV0W dsDqb46T2mbxlN47KgTy2T5xhMpobjPlThcsegozvd4JiitZn0jQNU0aMq8+SNbkgj79i4Bh9Yu UXhdP X-Gm-Gg: ASbGncvCMV7+GkH0dzJzxy10MeBZ4YeLTk1rTQkq961zA1TqCGMCZvXkOxGHaKCik0i Ga9qwpEkziDYqJwXa6I3WxehGdvv4Zsigk+MCiDcU0sC0Z6jDSNbOrnNAGHp5H6Mnx5+UQNIwxM 1MMdMIWW8kuUp5lCzfsYwQtBahNg0N/UOFFg3MriSkbeIV9FzDdKMGXYC1UStjpVWwxv7WTYrLX g0MZUvGdof8AeLn64P5SYhxbjvJBKADDYN90yE5JVPcicRPSPhJbXsRpT6TqPa2f3iez4oPNdvl EsL8oa1qH9LplwQ1dQYQFaytcskFJMTQln7y0oEfiAMbi/DFbq/Gcl4vKVyx+i7rAiKJFmxzHy0 ZkegYHPAmpTzhDcD8Cl7DXau//kZfd8Kyp9DRntQspzwfCtQ611IsAfkj+/oaEPpu4lJNQzCxzX YZPoOkAlBk7r0JwMmcdjbDM83/i5WAARUU2Umv4nze96LgNCTP6McI7cqwvw+ieg== X-Google-Smtp-Source: AGHT+IEr4Y8PkStPG4zGSMxCSFZBZDTsQfD0Kyr3C/3gqLQBePGhx4GFQopxn2FsQ249G9Iwc5iwOQ== X-Received: by 2002:a05:600c:3496:b0:477:333a:f71f with SMTP id 5b1f17b1804b1-47a83790c18mr38065175e9.17.1765391425247; Wed, 10 Dec 2025 10:30:25 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 3/5] x86/ucode: Don't cast away const-ness in cmp_patch_id() Date: Wed, 10 Dec 2025 18:30:17 +0000 Message-Id: <20251210183019.2241560-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251210183019.2241560-1-andrew.cooper3@citrix.com> References: <20251210183019.2241560-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1765391449214158500 Fixes a volation of MISRA rule 11.8. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/cpu/microcode/amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/= amd.c index adabe6e6e838..2760ace92177 100644 --- a/xen/arch/x86/cpu/microcode/amd.c +++ b/xen/arch/x86/cpu/microcode/amd.c @@ -106,7 +106,7 @@ static bool __ro_after_init entrysign_mitigiated_in_fir= mware; static int cf_check cmp_patch_id(const void *key, const void *elem) { const struct patch_digest *pd =3D elem; - uint32_t patch_id =3D *(uint32_t *)key; + uint32_t patch_id =3D *(const uint32_t *)key; =20 if ( patch_id =3D=3D pd->patch_id ) return 0; --=20 2.39.5 From nobody Fri Dec 12 19:35:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1765391458; cv=none; d=zohomail.com; s=zohoarc; b=Uxqw9dAhQJmgodoCYKRt923o/qXn7JTkZc9DojP+BN84+4jnNb6yMVrMuDNniofufSeph3rOGVve7AOyNjx1YnZyw+lcmb4q2TCCecO+2AKQ699Q0omlj408LQBOX+IjIjdVwtp/K8Cj1DvSSfqP/Sp1IEG4bHnEJ1EzYxE3yTQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765391458; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xUBQ+EjjlmRnrYL1o1ghPld6WT4JV9PjEtakOWMelRw=; b=N6S75W5a4XVeatB0duQzKC4QMYWFVHtRuii0DyM1nYrLUbsln6urbQXCRfWSl+MGJ/cgjcAZP+pEGWunJxVOzKMMLEQ6D/MWJFAHDJmGYUhyc+egpxnxP8m/2gC/wZWG+vVbKbnErXgbjIQ+puNM5EkD21XajtFmsjn0N3Wf94I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1765391458262838.1580947014504; Wed, 10 Dec 2025 10:30:58 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1183169.1505968 (Exim 4.92) (envelope-from ) id 1vTOxJ-0005O3-7s; Wed, 10 Dec 2025 18:30:29 +0000 Received: by outflank-mailman (output) from mailman id 1183169.1505968; Wed, 10 Dec 2025 18:30:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxJ-0005LR-3C; Wed, 10 Dec 2025 18:30:29 +0000 Received: by outflank-mailman (input) for mailman id 1183169; Wed, 10 Dec 2025 18:30:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxI-0004ng-E8 for xen-devel@lists.xenproject.org; Wed, 10 Dec 2025 18:30:28 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4cd9e046-d5f6-11f0-b15b-2bf370ae4941; Wed, 10 Dec 2025 19:30:27 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-47118259fd8so918205e9.3 for ; Wed, 10 Dec 2025 10:30:27 -0800 (PST) Received: from localhost.localdomain (host-92-26-102-188.as13285.net. [92.26.102.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a886affb4sm1696105e9.3.2025.12.10.10.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 10:30:26 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cd9e046-d5f6-11f0-b15b-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1765391427; x=1765996227; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xUBQ+EjjlmRnrYL1o1ghPld6WT4JV9PjEtakOWMelRw=; b=VKvrRrGZiOOcN1P1IfR4SgxWwv17ROavzzQ5BFF5qTSxSU2EDC8GmD5HRVrnyigqrW TqJ05dyjFAHdyYz6wx9W3p6b9lWl/a/WRE+JRvdAioUcpY1Z3YYrxfbfCw6zNEQG+YSP IvG6O0Ndgw/Wla+ng+2dagM7/2lavTcn/vVAI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765391427; x=1765996227; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xUBQ+EjjlmRnrYL1o1ghPld6WT4JV9PjEtakOWMelRw=; b=r+Qpgbxk9GjXAHnAHn8hpO+Ub4bHacT5v+C2q63UeuSQH1g3CSdwNKipXswj/r2W2h RzG6fuhVqFd2l2f7/afy5jVXEfdxYTBfGLYt6M+2TWRZBuUaMJ9U6rmfldpMyapJw8iP c9EszjUcHUQHBZyVeL9BSM+cz+iX6NzB9JVxm3bswAJ+Z/qrV42CTE+G3TQ7Q58CMpiY 8ydToyIOkPpk3MfXuKtW4DMS17NyMp0mf+zWKxPnh5Ltn/nriw2DZ937UUcv4ND7cG6r RUGIjbfgNLcQQfVlNf44KJBJJo3ZeOpt7PANGwG9ODEx0mI9JkCUDkWmLyhQ/EBcx++N OkXQ== X-Gm-Message-State: AOJu0YyXGMgracMHzDJurux0PngcW2S8k1eoO5Dm1+imS4OKOYTHBXOa 3pboGNa70cO9pSt4l0BValYMkHff6qyQrkyW/0inoTtQ+Ssm0QUo0IGj0/JTMuJPQwwyAGU+o47 E4LL4 X-Gm-Gg: ASbGncsytfJVETsp4iy/DkFippag6dZdOo+x7DbWuvL9omf3mzGVOvNsCtNPEGevIAU +wNN++pqpmwmRNeN6OcebQba29Uu8lyd/T0xXJXpKNZMoXwDwWJPHplzuucJy7hmfwb3FwWYPdg lEjhdAUxnyyPPe19TlTk+ot5MTt4oFY/28LxodFdiVZuG9RtuWEWAQ+eDx09FKYYg3daC7zTD88 Su/p4vHXwwWkaqN5QvKW+bY/un6GiV1f1JDmr4tiIPMbLXVR1tzf7oIpU1D/SvFDGLdk0kE8Ucf Q1Bv6cou9ozTq5BHb0KPWTiuQQMjsYK60nChN/qib8bYfRkHGuoucyWMAyzNBgEmLXPZvsQHlZD yw+GhgijUn754Tql3dQul32ybjF7BxbvE+ljD+VqtJMiCJw7oyig53lU/Kxl9qyClF6fH1QLx/1 Z2NDP2a6oUigxTuVzfJghJnBO/Df+pOSoh3WcRriS9SzQDp+T31G+1d/xx5Z/fUw== X-Google-Smtp-Source: AGHT+IGHzYeimNoaPx8M3atd7epetX7tgiDEdgF73E1tDPW3yjPZvnhoUx8aBX88w2lQfEP4Yji+Qg== X-Received: by 2002:a05:600c:8010:b0:479:3046:6bb3 with SMTP id 5b1f17b1804b1-47a837aca24mr29805455e9.23.1765391426830; Wed, 10 Dec 2025 10:30:26 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 4/5] x86: Fix missing breaks Date: Wed, 10 Dec 2025 18:30:18 +0000 Message-Id: <20251210183019.2241560-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251210183019.2241560-1-andrew.cooper3@citrix.com> References: <20251210183019.2241560-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1765391459186158500 With the wider testing, some more violations have been spotted. This addresses violations of Rule 16.3 which requires all case statements to be terminated with a break or other unconditional control flow change. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/domain.c | 1 + xen/arch/x86/mm/shadow/hvm.c | 1 + xen/arch/x86/pv/emul-priv-op.c | 1 + xen/arch/x86/pv/emulate.c | 1 + xen/common/livepatch.c | 1 - xen/common/livepatch_elf.c | 1 + 6 files changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 5e37bfbd17d6..b15120180993 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -1517,6 +1517,7 @@ int arch_set_info_guest( { case -EINTR: rc =3D -ERESTART; + fallthrough; case -ERESTART: break; case 0: diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c index 114957a3e1ec..69334c095608 100644 --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -268,6 +268,7 @@ hvm_emulate_cmpxchg(enum x86_segment seg, default: SHADOW_PRINTK("cmpxchg size %u is not supported\n", bytes); prev =3D ~old; + break; } =20 if ( prev !=3D old ) diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index 08dec9990e39..fb6d57d6fbd3 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -407,6 +407,7 @@ static void _guest_io_write(unsigned int port, unsigned= int bytes, =20 default: ASSERT_UNREACHABLE(); + break; } } =20 diff --git a/xen/arch/x86/pv/emulate.c b/xen/arch/x86/pv/emulate.c index 8c44dea12330..b201ea1c6a97 100644 --- a/xen/arch/x86/pv/emulate.c +++ b/xen/arch/x86/pv/emulate.c @@ -120,6 +120,7 @@ void pv_set_reg(struct vcpu *v, unsigned int reg, uint6= 4_t val) printk(XENLOG_G_ERR "%s(%pv, 0x%08x, 0x%016"PRIx64") Bad register\= n", __func__, v, reg, val); domain_crash(d); + break; } } =20 diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c index 9285f88644f4..b39f8d7bfe20 100644 --- a/xen/common/livepatch.c +++ b/xen/common/livepatch.c @@ -1924,7 +1924,6 @@ static void noinline do_livepatch_work(void) p->name); ASSERT_UNREACHABLE(); } - default: break; } } diff --git a/xen/common/livepatch_elf.c b/xen/common/livepatch_elf.c index 25ce1bd5a0ad..2e82f2cb8c46 100644 --- a/xen/common/livepatch_elf.c +++ b/xen/common/livepatch_elf.c @@ -347,6 +347,7 @@ int livepatch_elf_resolve_symbols(struct livepatch_elf = *elf) dprintk(XENLOG_DEBUG, LIVEPATCH "%s: Symbol resolved: %s = =3D> %#"PRIxElfAddr" (%s)\n", elf->name, elf->sym[i].name, st_value, elf->sec[idx].name); + break; } =20 if ( rc ) --=20 2.39.5 From nobody Fri Dec 12 19:35:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1765391447; cv=none; d=zohomail.com; s=zohoarc; b=aJjgGpFKZupX7GiFwG5HtJs+CYQZ03uRw+qQhHtv0u/FaDMJkU0mp4+qi+AV7vT5aJWfs6nma3wHFb6IJAFNRBcZXeEtOPRBv8hXwKe5MfCvEHcFa13sXPE2yB6rTpdPctKUlrBnyEImsL9nPy/8BJN6no4qV/S2D0KNnOik+4M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765391447; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NS1EndFYbpf3vAxuQ4QceAjOVlxSaNZnyI0peaJbSIU=; b=Jg721x/idfUpLTA6o/TvxFc01vjagNbTT+x1MYmtKhW9N7kFGC0xxQzQEMYokCWv+JUNnyEeRkJDR3fY7mObz6kuzYnPSk5PIlu/wghjXp7cYS/6jaetLZhJ6IzYqreaS2MvZbmhPNH2VN3KJdyYeRPN8M+Sf3/3cqIB4+TEJBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1765391447060554.1624103815287; Wed, 10 Dec 2025 10:30:47 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1183170.1505986 (Exim 4.92) (envelope-from ) id 1vTOxK-0005pG-Ip; Wed, 10 Dec 2025 18:30:30 +0000 Received: by outflank-mailman (output) from mailman id 1183170.1505986; Wed, 10 Dec 2025 18:30:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxK-0005oR-DZ; Wed, 10 Dec 2025 18:30:30 +0000 Received: by outflank-mailman (input) for mailman id 1183170; Wed, 10 Dec 2025 18:30:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTOxJ-0004ng-E8 for xen-devel@lists.xenproject.org; Wed, 10 Dec 2025 18:30:29 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d569813-d5f6-11f0-b15b-2bf370ae4941; Wed, 10 Dec 2025 19:30:28 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-47a80d4a065so638245e9.2 for ; Wed, 10 Dec 2025 10:30:28 -0800 (PST) Received: from localhost.localdomain (host-92-26-102-188.as13285.net. [92.26.102.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a886affb4sm1696105e9.3.2025.12.10.10.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 10:30:27 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d569813-d5f6-11f0-b15b-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1765391428; x=1765996228; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NS1EndFYbpf3vAxuQ4QceAjOVlxSaNZnyI0peaJbSIU=; b=dyq2ATgaxwe7QbZherysmV565u7KHN01w4CystAmvsH6Qg3zWBOnZdOz5w6Vqf2QX7 YpnAwOJmJ2XixqzBaOWKLqDKSDCCla69OckNtdDsxJKNnKIPdrz3zDIxojy78bPDn8Wp Dh8hY+1KfkJlOhrFGfiCz5rTH/8zSTpB1kfbc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765391428; x=1765996228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NS1EndFYbpf3vAxuQ4QceAjOVlxSaNZnyI0peaJbSIU=; b=oIYWTkKaP0SoUdqOTQp74a5xYMAJryNmxb8zz0WZYLt++NfjkPEYry1idnl2Reos4X iWMDgC62TEfaX/BJVnY+6dDiAWBMlndB3gn6B26aYOVMbIkuBNIOzeqUe9YWGIvYKYgP Dv3/33zqimRDZGR8y8fQgTNCW0/MenCWH0r6ybtNFf88zBXZgS7NoRTXPtucJMTg6b/W /7v8r7Rc069DeDOfE0exzXmHsrNPFW+WjOoo1uW18jUJqbzuIzcAThieFaF25Hiz19+r 6HWeqpD7T1xQb8qticoZ3OJeHVTNrvupFwV2xitFqhXXXmMXYLaqM7pvItKr2t0Qs4P1 VXhw== X-Gm-Message-State: AOJu0Yz+nXxNXeDXE8ox6SWBhSgRYjMsoBD5J/j/cP+3tcyAtQTrhEqz 3hc51pSaIQO8m2McNHvhYBCsUOmEqPGTDqVRwOIZOvTsQRCQlglTMwtTcehH93ab61FWPt1Gcoy 45i7o X-Gm-Gg: ASbGncuQJ+X7DDiEYmmnVD2gpKCjc7BEDGBwVtEJYoKkVdWQ/Fj6kVoWeBQhAkHJW29 tzw/sDMLQbTYS4v6r4VzePbRWcYdYqwW47dTr5jp/PDiY7HwHdR5lbe9dLYABOWwgU1cuWiD4UX CDL5V7LGXjHhvGdi+4vkpDOD4cAxezDzuXn9gmUz4rOz/Tu468sGzX5bnDzBrPov53KBjGlpBX2 CxWrPSdGe/GX3xciCPbiJqcZAHQCwzvRKhdILUSmNOishQ9/hPPgHvQIl0Ls0zjfc3pU8dltMRj TEcFv5xg/u/AcUlpihY7K1e2GnP+VV2aKE+V6N7ahY2QRIDLlzcMPMRNUXm41za06itFlsnXi+G 48UZO+gzBQ2UGB9aiQqQqpOMbU1GTViZU3AzG/Xzx3z8TwvUo2X8jfGXssxitZINmpDG7d/AujZ r3BM195Ov3zCXlUegsIn6f5CWyEJjis9GoVGlXnhrodoMx6hkYUlg34xfbsHNh6oLxpkUr6QvT X-Google-Smtp-Source: AGHT+IHD0K0/goDBgvQ0eFH4wZgG9dS6dBkYuhuXnCJuEuZJfSb+0YcfcBuj17vO+utCkeybtuqlLQ== X-Received: by 2002:a05:600c:c48e:b0:46e:33b2:c8da with SMTP id 5b1f17b1804b1-47a8384857cmr31691765e9.32.1765391427782; Wed, 10 Dec 2025 10:30:27 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , "consulting @ bugseng . com" , Nicola Vetrini Subject: [PATCH 5/5] x86: Fix missing brackets in macros Date: Wed, 10 Dec 2025 18:30:19 +0000 Message-Id: <20251210183019.2241560-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251210183019.2241560-1-andrew.cooper3@citrix.com> References: <20251210183019.2241560-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1765391449257158500 With the wider testing, some more violations have been spotted. This addresses violations of Rule 20.7 which requires macro parameters to be bracketed. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: consulting@bugseng.com CC: Nicola Vetrini --- xen/arch/x86/mm/shadow/multi.c | 2 +- xen/arch/x86/mm/shadow/private.h | 6 +++--- xen/drivers/passthrough/vtd/dmar.h | 2 +- xen/include/xen/kexec.h | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 03be61e225c0..36ee6554b4c4 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -781,7 +781,7 @@ do { = \ (_sl1e) =3D _sp + _i; \ if ( shadow_l1e_get_flags(*(_sl1e)) & _PAGE_PRESENT ) \ {_code} \ - if ( _done ) break; \ + if ( (_done) ) break; \ increment_ptr_to_guest_entry(_gl1p); \ } \ unmap_domain_page(_sp); \ diff --git a/xen/arch/x86/mm/shadow/private.h b/xen/arch/x86/mm/shadow/priv= ate.h index cef9dbef2e77..93834ec55c42 100644 --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -636,9 +636,9 @@ prev_pinned_shadow(struct page_info *page, } =20 #define foreach_pinned_shadow(dom, pos, tmp) \ - for ( pos =3D prev_pinned_shadow(NULL, (dom)); \ - pos ? (tmp =3D prev_pinned_shadow(pos, (dom)), 1) : 0; \ - pos =3D tmp ) + for ( (pos) =3D prev_pinned_shadow(NULL, dom); \ + (pos) ? (tmp =3D prev_pinned_shadow(pos, dom), 1) : 0; \ + (pos) =3D tmp ) =20 /* * Pin a shadow page: take an extra refcount, set the pin bit, diff --git a/xen/drivers/passthrough/vtd/dmar.h b/xen/drivers/passthrough/v= td/dmar.h index 0ff4f365351f..11590f71a828 100644 --- a/xen/drivers/passthrough/vtd/dmar.h +++ b/xen/drivers/passthrough/vtd/dmar.h @@ -124,7 +124,7 @@ struct acpi_atsr_unit *acpi_find_matched_atsr_unit(cons= t struct pci_dev *); do { \ s_time_t start_time =3D NOW(); \ while (1) { \ - sts =3D op(iommu->reg, offset); \ + sts =3D op((iommu)->reg, offset); \ if ( cond ) \ break; \ if ( NOW() > start_time + DMAR_OPERATION_TIMEOUT ) { \ diff --git a/xen/include/xen/kexec.h b/xen/include/xen/kexec.h index e66eb6a8e593..5dd288d1a50e 100644 --- a/xen/include/xen/kexec.h +++ b/xen/include/xen/kexec.h @@ -66,9 +66,9 @@ void vmcoreinfo_append_str(const char *fmt, ...) #define VMCOREINFO_PAGESIZE(value) \ vmcoreinfo_append_str("PAGESIZE=3D%ld\n", value) #define VMCOREINFO_SYMBOL(name) \ - vmcoreinfo_append_str("SYMBOL(%s)=3D%lx\n", #name, (unsigned long)&= name) + vmcoreinfo_append_str("SYMBOL(%s)=3D%lx\n", #name, (unsigned long)&= (name)) #define VMCOREINFO_SYMBOL_ALIAS(alias, name) \ - vmcoreinfo_append_str("SYMBOL(%s)=3D%lx\n", #alias, (unsigned long)= &name) + vmcoreinfo_append_str("SYMBOL(%s)=3D%lx\n", #alias, (unsigned long)= &(name)) #define VMCOREINFO_STRUCT_SIZE(name) \ vmcoreinfo_append_str("SIZE(%s)=3D%zu\n", #name, sizeof(struct name= )) #define VMCOREINFO_OFFSET(name, field) \ --=20 2.39.5