From nobody Sun Dec 14 08:08:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=julian.vetter@vates.tech; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=vates.tech ARC-Seal: i=1; a=rsa-sha256; t=1764253926; cv=none; d=zohomail.com; s=zohoarc; b=JqrVGv9EHbrZxZv1zgzbXyvHRFHeWDaZ1BGoi9TUzjpEg/SykgWxCJ8YrTT2AN38m0o53hhWxA4ky4MXrvoqBxZbjTu/eiLy98wmAvn+pU3pOBrSrSAvpCQuk3kXtN+2TlSNCoeMw/pVmkarHb2nYdMvmXRXAfmhi4fvZOQpjOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764253926; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=c3uFUFR0gCzgbxeRaC8eh8AzjcagpaNHm32V69DFMH4=; b=YCJsjn1GdmbX0nfmwhOjrsezBc91z2sCimy4gh26CSD7KxaeFhZp79XZgJDwBwn5C+IBJ3RVi/Kvr9ovMJft0om1kmneuKEdyxAKAhCbyQzCOTY2DMKtGTfvWTMM3F9vzJEHeFN0W5yG6qLgc7JlVgzsHPaL65/CXZkqKGc9Xt8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=julian.vetter@vates.tech; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1764253926395630.7340382286213; Thu, 27 Nov 2025 06:32:06 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1174015.1498992 (Exim 4.92) (envelope-from ) id 1vOd2G-0006nm-53; Thu, 27 Nov 2025 14:31:52 +0000 Received: by outflank-mailman (output) from mailman id 1174015.1498992; Thu, 27 Nov 2025 14:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vOd2G-0006nf-1X; Thu, 27 Nov 2025 14:31:52 +0000 Received: by outflank-mailman (input) for mailman id 1174015; Thu, 27 Nov 2025 14:31:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vOd2E-0006nX-Lj for xen-devel@lists.xenproject.org; Thu, 27 Nov 2025 14:31:50 +0000 Received: from mail132-20.atl131.mandrillapp.com (mail132-20.atl131.mandrillapp.com [198.2.132.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc137c08-cb9d-11f0-980a-7dc792cee155; Thu, 27 Nov 2025 15:31:45 +0100 (CET) Received: from pmta09.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail132-20.atl131.mandrillapp.com (Mailchimp) with ESMTP id 4dHJlg26Z7zFCWb4w for ; Thu, 27 Nov 2025 14:31:43 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 8f6362d3c4404a0b9c52a02ad003c61c; Thu, 27 Nov 2025 14:31:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc137c08-cb9d-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1764253903; x=1764523903; bh=c3uFUFR0gCzgbxeRaC8eh8AzjcagpaNHm32V69DFMH4=; h=From:Subject:To:Cc:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:Content-Transfer-Encoding:CC:Date:Subject:From; b=vmz2cRPZdHh8s6FzSaIANqDQ5robFCWbT+gQqfbhDftA4/nRWohnE2BIodKt0RbTm TV9LM/GLl0p8OrISzJWGb1CxTQHogLYA8vwiuGUbdhcJiPZ9ymWVy1ctO2DtLhqVQz hG/g+zxyOCsYIPKgbYEzjOElgR6GH8QDE2uiT1PFnpsACR98HdaynSpHEzpjMbYPET rpW7RSJhHaLBavaEySukNodrH9RWHcWFuAT7At37pfVJmao4pU5ZU/A/Ev36Q9wFwp fAWV6FgAdH2Ajv8jfEA/PRr5Vu/JYHnDgPqE3m2Ue5TKbTze/rN3CzZpvHULnSC7Po Kj/c3ecv/xgVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1764253903; x=1764514403; i=julian.vetter@vates.tech; bh=c3uFUFR0gCzgbxeRaC8eh8AzjcagpaNHm32V69DFMH4=; h=From:Subject:To:Cc:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:Content-Transfer-Encoding:CC:Date:Subject:From; b=tTsz6tdXFqfJqoKID0gpMxa2eVw2LpjQYtk2xHWZCfA1j+TH30PHiSm/UiibC38yR BLmvNowTmxZGN7UPjIpQdY84WhSRJA3ESfd0ZAdAsQ/6mSj4+SoO46lMWVk2bMAdcA otIvwafiXXEkFK/6+yD4ulkpEECZCQUmoxCa5kVSjyE6oV6ad0MpfGh6E2cEQwkpFf b8wphb7rgE/IyKn1Jw4Gq0v4x/edeTUSFGpXXg605rjT6FGhZiT2YuQ70pqE6SXhLi 83JVad10UoCQp5pESnzWs5WmWp53UvBIR6vHwJGepK/CeqTOMrfI9VuTvP8xh45/z0 z4e+ZL3EiXWiQ== From: "Julian Vetter" Subject: =?utf-8?Q?[PATCH]=20x86/efi:=20Remove=20NX=20check=20from=20efi-boot.h?= X-Mailer: git-send-email 2.51.0 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1764253902022 To: xen-devel@lists.xenproject.org Cc: "Jan Beulich" , "Andrew Cooper" , "=?utf-8?Q?Roger=20Pau=20Monn=C3=A9?=" , "Daniel P . Smith" , "=?utf-8?Q?Marek=20Marczykowski-G=C3=B3recki?=" , "Teddy Astie" , "Julian Vetter" Message-Id: <20251127143136.1598354-1-julian.vetter@vates.tech> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message,=20including=20all=20headers,=20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.8f6362d3c4404a0b9c52a02ad003c61c?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20251127:md Date: Thu, 27 Nov 2025 14:31:43 +0000 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity julian.vetter@vates.tech) (identity @mandrillapp.com) X-ZM-MESSAGEID: 1764253928136019200 Content-Type: text/plain; charset="utf-8" Currently Intel CPUs in EFI mode with the "Execute Disable Bit" disabled and the 'CONFIG_REQUIRE_NX=3Dy' fail to boot, because this check is performed before trampoline_setup is called, which determines if NX is supported or if it's hidden by 'MSR_IA32_MISC_ENABLE[34] =3D 1' (if so, re-enables NX). Signed-off-by: Julian Vetter --- xen/arch/x86/efi/efi-boot.h | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 0194720003..8dfd549f12 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -748,18 +748,6 @@ static void __init efi_arch_cpu(void) if ( (eax >> 16) =3D=3D 0x8000 && eax > 0x80000000U ) { caps[FEATURESET_e1d] =3D cpuid_edx(0x80000001U); - - /* - * This check purposefully doesn't use cpu_has_nx because - * cpu_has_nx bypasses the boot_cpu_data read if Xen was compiled - * with CONFIG_REQUIRE_NX - */ - if ( IS_ENABLED(CONFIG_REQUIRE_NX) && - !boot_cpu_has(X86_FEATURE_NX) ) - blexit(L"This build of Xen requires NX support"); - - if ( cpu_has_nx ) - trampoline_efer |=3D EFER_NXE; } } =20 --=20 2.51.0 -- Julian Vetter | Vates Hypervisor & Kernel Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech