From nobody Sun Dec 14 05:55:14 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1764023781; cv=pass; d=zohomail.com; s=zohoarc; b=n2v0xuXxJ8RrQc/fDbrshEuMIMgoSI4bBgVe8uWyI97GxzAgi7Q5vIUqvxSAtjsE51d0QSTPgKWN9z7ZGwm5lmEZryaZQmIQfNYfqo0gG/AVHwWVTwKboRsTwtAjQR3hJAKZ/3ROEqkzb+Lbq2NZWt+80Qa8gtIm1LPFIwCLolQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764023781; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=khaXepjy+mj83tuBL39eaODPf2psvhrTF2r85Z9Phx8=; b=abnSS3jUYU2Nu9YZ1nIydW9afJlKbBcep5o8RJ6Nb0gSLGPRFtcKdDJoh+6+eJhVfgDcQM62s5wWPwEMtOWhnQ7LiA0QynP1//nibi8JtSvbOIxpY0/MLucFdatfE+0iis7Aa+1jGEYQ9JE/xe5QChEe1mX3hXcB22j32AFq5FY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1764023781490518.3277736320215; Mon, 24 Nov 2025 14:36:21 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1171535.1496549 (Exim 4.92) (envelope-from ) id 1vNf9x-0006Mh-GL; Mon, 24 Nov 2025 22:35:49 +0000 Received: by outflank-mailman (output) from mailman id 1171535.1496549; Mon, 24 Nov 2025 22:35:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNf9x-0006Ma-Cg; Mon, 24 Nov 2025 22:35:49 +0000 Received: by outflank-mailman (input) for mailman id 1171535; Mon, 24 Nov 2025 22:35:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNf9v-0006MK-Mh for xen-devel@lists.xenproject.org; Mon, 24 Nov 2025 22:35:47 +0000 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazlp170120007.outbound.protection.outlook.com [2a01:111:f403:c101::7]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e99a37b9-c985-11f0-9d18-b5c5bf9af7f9; Mon, 24 Nov 2025 23:35:46 +0100 (CET) Received: from BL1P222CA0013.NAMP222.PROD.OUTLOOK.COM (2603:10b6:208:2c7::18) by DS7PR12MB5958.namprd12.prod.outlook.com (2603:10b6:8:7d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.17; Mon, 24 Nov 2025 22:35:40 +0000 Received: from MN1PEPF0000F0E1.namprd04.prod.outlook.com (2603:10b6:208:2c7:cafe::90) by BL1P222CA0013.outlook.office365.com (2603:10b6:208:2c7::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.17 via Frontend Transport; Mon, 24 Nov 2025 22:35:39 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by MN1PEPF0000F0E1.mail.protection.outlook.com (10.167.242.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.7 via Frontend Transport; Mon, 24 Nov 2025 22:35:40 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 24 Nov 2025 16:35:39 -0600 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 24 Nov 2025 14:35:39 -0800 Received: from fedora.mshome.net (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 24 Nov 2025 14:35:39 -0800 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e99a37b9-c985-11f0-9d18-b5c5bf9af7f9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R6/ZhQIWZfsg+3XV83qk6mXwRFtzRW9pTfJAw3h084zYm6hfa/zQ22uLmWUw3G8BsKs27jJXrU9wQfcZpcRzJdmFYnCRmGp/BgpKxZp2wrl5MZy0Z/S0zukHXalpp+U9fuawPb9OR9OuzPbGebD/KDVKvdQrVDIwLIsvHEWljYA8dm5ff1v0JB3ZE2C9ATQUv/EQzWGfFETFz4BQybMOrT0xc16q4GVzlRPMQA4/YsWlK76uoEWjBr3SzL6D+OVS6VgKXCTJFNG5TV3N+XuqEFAu4GVGsWb37wURsS/Yv5ltmDna9kFPYCiS21Y32wkt/+UwcmegTDoW4VZKs1jD0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=khaXepjy+mj83tuBL39eaODPf2psvhrTF2r85Z9Phx8=; b=m1DxVODS1/tfk8fyQNJY4a91oBYeUulEBtUl5jAjp13dUeiQ1TYpCN8OD2AhHP1zebkejojSmkqb+F2vV3VuSmO/nieZrYR60qWsRc89wdZ14rJgOuEvGWyqQRuSuqSlq2pTEJXcpoSOz65Pu4w/79P73rL/r8IcD/BDI0613CPjDcm/LDdWSvPJ0mncHxlaBdVll9mbvTtD0kdCk15iYDOv/AMcjTabVIhTlX5xK/SnYzHPQGFlARW2BqUeMwtPRcVo1QjF9RKjoL7+mY1OaXKj5q2cGIHslXhIio/Zb1tdDp1m5AuwTxhWdHtDplHQYCnpamzFsNZCJEf/O0mnAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=khaXepjy+mj83tuBL39eaODPf2psvhrTF2r85Z9Phx8=; b=noTCTZ6a+HyE0eUCWEmvGwU1oP5ISmlZeKg63EskKidyfWaZ7YYyhYPvuT4uhO0ZYPp9bP7OKa/MmZ0pyOGQ4W2SnaWLPWfjdzA3ijhbeHk25zur5ifRV5Z9/WwcrNMXkKEshRfFAf4m5+FCR+YSPHbtN2/Ws/XuPc2RDb6rzHY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [XEN][PATCH 1/2] xenstored: Default priv_domid to store_domid Date: Mon, 24 Nov 2025 17:35:32 -0500 Message-ID: <20251124223533.31613-2-jason.andryuk@amd.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251124223533.31613-1-jason.andryuk@amd.com> References: <20251124223533.31613-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E1:EE_|DS7PR12MB5958:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b180a82-bb54-4930-dc98-08de2ba9cbeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rYFwPunk+hpUjuNhtmDRzcFPslzLkfp2lNEKm5BbNkPbenFUhARZZRCqKQhG?= =?us-ascii?Q?wN8RihFhqbjV2caK8q5nBn2/ziVAT5u4dN2semqUHO9EJN9IGwD4ubGKs5uM?= =?us-ascii?Q?8BHjd6rxzWJFoGHvrmtDPsl9RtaReJOQQTAKYyI2klohWXmMDADoMaZpXsKt?= =?us-ascii?Q?qfwLbHw6eggcJ8CYwi9AKoD9eIodlQmUQ9jcCd0BPqj5pTagHT6wAhpGM6Ql?= =?us-ascii?Q?YHgQ9YGZl4kd1GWxxSgUxIjyX8OCSoU0kFXDrbvswbBATY9cACGzSsVYA2lD?= =?us-ascii?Q?XHLsw7nhG0XuAOk7M2unhbkYi04TNOPbnOkCFioE7H3b27JqFcpaCPErWhN9?= =?us-ascii?Q?SV7+OJMRdwzieaYMFaevvErFYebMTA1rJ9w26cTbEZvYAtHRkeTLISYifvPG?= =?us-ascii?Q?OYSb1cRUG34EUUPR7hNvY0D0WmXhduaiExhUU+VHYXs702SF3+lquQJVXi/S?= =?us-ascii?Q?W0NLlsZ795VGAmfDYh/vuQUYnEKGGKqj/Wj/XOJxILyJrLmKfQmAJjfhE/YV?= =?us-ascii?Q?8FyYeWVmC0XhGke4L2agAi683tP8t7cDUBIcQPjTfgDp7uQPdlAVRFlxQ8JM?= =?us-ascii?Q?S5V09QsaE7Qdct7TRQSY512Yuhk5Twokkk++KyJqGupOVyFPd6biDfXxJy08?= =?us-ascii?Q?i20m/fHUcuLJXNHk63HNDrVFDTIiZDqU8Ca4+Eqn8dHJdWwHw9iB4MVPcKVF?= =?us-ascii?Q?X8k1ERdkIZT8uiL488yZfBhAIXaq31o802g/taaLfWKGOHY5PTOI5q1bfpqB?= =?us-ascii?Q?mabEWOeOpJ9+2eNxnhrVwGxmrJWeEfBdVxOSx3rStaRwYBFjL+t2CUlklbhu?= =?us-ascii?Q?izNP4kupo5rRk/X68Aq7HTY2Q275+Td65+fCaE/owKKTFvxiulaHlaUOcJ7q?= =?us-ascii?Q?dEMN+OIRL6kB+wUOhPtM4MqrJCvZecvrBfLqj6IDC5L3XbcspGEZRHa0dRiv?= =?us-ascii?Q?vNHP5gsNzfnEUc1CLL9ZCKcYNjrONljL6/t91gWWReOj6vIwCzmT397ukz9q?= =?us-ascii?Q?VnudDIk65curZ4/BS704RTTI5vwCJ3ThJabAIvkVfzfhyneZ/F+rjaSPpFFx?= =?us-ascii?Q?QiD52W1SnXziQcsKjjN4VmX5wyYE+/6GXOWuTtf2jU4wUuL9cJK4HKP0cqj2?= =?us-ascii?Q?9VuEM8GjBjjo6y9CUFXZw0amxG3+FMsokRBI+xs13g8B58FdqHR777NMyXWc?= =?us-ascii?Q?gbV8IU74mYYOAiPQoMHZqnAVT6iaeerGDzO+O1VB0QHXJ6Cz4+ePmwouPqga?= =?us-ascii?Q?12dY/RSNAVGYSHUalYAd39IPCoqQ6Ie24UCrPX/1FKsrlJ5zOdbjyDPw1SoS?= =?us-ascii?Q?eTfAFaaAaKxct/3EMs9CfdqxZswTEd7Bgp3bwadHSxprUKXfrftyc93o1Chx?= =?us-ascii?Q?Kq6qWeA2ASq/3V+gLbj9ipx8lb3hLIVnzPuFQlZXmXYK8rdUIMykw3oJSEKM?= =?us-ascii?Q?HeCmChtvV/6O4botfuRD7ZiHoqApWWSCSDMOspFNBLnPGn8nmpIfckwO+jAS?= =?us-ascii?Q?7jslkb/R5dM5EFa8HryAKYXtQqkSnsfsXyHN8mneIIxjwVGBCxsDxByjj5yQ?= =?us-ascii?Q?nW9SPSEXZcSJQJ629rY=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2025 22:35:40.3450 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b180a82-bb54-4930-dc98-08de2ba9cbeb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E1.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5958 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1764023782611019200 Content-Type: text/plain; charset="utf-8" On a system without a control domain, a hardware|xenstore domain starting xenstored shows: common/grant_table.c:1041:d2v0 Could not find domain 32756 gnttab: error: mmap failed: Invalid argument Could not initialize dom32756 setup_structure() does not get called without priv_domid. Subsequent introduce_domain() calls will fault when calling fire_special_watches(). Default priv_domid to store_domid when there is no control domain. Fixes: e5b0a9405571 ("tools/xenstored: Auto-introduce domains") Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross --- I didn't verify the segfault in fire_watches() in this situation, but I saw that previously when working on this. Regardless of the specific error, xenstored was not working properly without this change. --- tools/xenstored/domain.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index 5ce539d640..d504e9994b 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1388,6 +1388,12 @@ void init_domains(void) if (store_domid =3D=3D DOMID_INVALID) barf("Could not determine xenstore domid\n"); =20 + if (priv_domid =3D=3D DOMID_INVALID) + { + priv_domid =3D store_domid; + xprintf("priv_domid defaulted to %u\n", priv_domid); + } + snprintf(store_domain_path, sizeof(store_domain_path), "/local/domain/%u", store_domid); =20 --=20 2.51.1 From nobody Sun Dec 14 05:55:14 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1764023780; cv=pass; d=zohomail.com; s=zohoarc; b=EOFv1HTF958Zpbr4xi8RbNvpnlfofuEtTbVRJOKpY2dB2v93TDSjRi3lHr5Ky+eAgAytaZvrRh9HVIGpdUSDHF0XvMuKPQVlxMkOlVD030YDTodTO/oB7VyO941VFKwr4xOfEXUl5P2OI0D6M3sbsmEZTHraLpvYSf6pf8N+orI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764023780; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=a0V4XtSB4FPS0jb0XMxjmyRGmxM1LCYoYZuuHWV8i4w=; b=HSmIsfwrGqPg2aPhg68B7ljU59vPBUTqc+TqtLqzqgTjTG7lJltzi8mB3A4Q2Ndy/pcmYxS+N240e34ep7tTHgy4kVPfdXJc6buPZ0BCDW+aDRCiNNB1ZTH779fmY39RzUtQdy5quj3Y8Btz1fPQmDsrg5Emle48ERGFesCVTyw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1764023780003714.7376640711861; Mon, 24 Nov 2025 14:36:20 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1171537.1496561 (Exim 4.92) (envelope-from ) id 1vNf9y-0006a3-5m; Mon, 24 Nov 2025 22:35:50 +0000 Received: by outflank-mailman (output) from mailman id 1171537.1496561; Mon, 24 Nov 2025 22:35:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNf9y-0006Wh-1O; Mon, 24 Nov 2025 22:35:50 +0000 Received: by outflank-mailman (input) for mailman id 1171537; Mon, 24 Nov 2025 22:35:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNf9x-0006MK-5U for xen-devel@lists.xenproject.org; Mon, 24 Nov 2025 22:35:49 +0000 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazlp170130001.outbound.protection.outlook.com [2a01:111:f403:c10c::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebf6fccd-c985-11f0-9d18-b5c5bf9af7f9; Mon, 24 Nov 2025 23:35:48 +0100 (CET) Received: from BYAPR02CA0010.namprd02.prod.outlook.com (2603:10b6:a02:ee::23) by IA1PR12MB9737.namprd12.prod.outlook.com (2603:10b6:208:465::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.16; Mon, 24 Nov 2025 22:35:43 +0000 Received: from SJ5PEPF000001D2.namprd05.prod.outlook.com (2603:10b6:a02:ee:cafe::4) by BYAPR02CA0010.outlook.office365.com (2603:10b6:a02:ee::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.17 via Frontend Transport; Mon, 24 Nov 2025 22:35:44 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by SJ5PEPF000001D2.mail.protection.outlook.com (10.167.242.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.7 via Frontend Transport; Mon, 24 Nov 2025 22:35:42 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 24 Nov 2025 16:35:41 -0600 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 24 Nov 2025 14:35:41 -0800 Received: from fedora.mshome.net (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 24 Nov 2025 14:35:41 -0800 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebf6fccd-c985-11f0-9d18-b5c5bf9af7f9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CenVZ4UmQYW6KO3cqjnZkmQOSbxGegoaBgy/5l9g3c/Ov4nAODVMVdU1yIdYlg2+SNR760MHZnoC05LfOcSgjvosebaQR30O2UXPMh1c3ytMbtQbRQqZd/dLvSvwyi2OTv0wm8B2hbiUExrzrF8yt8uC+m8aAjODHPzMBwk2BwGiLDhv+8DiZnDBPjUo/z3uzs5tgip0o4VFGhnltE8VJJWdU4QbkT1tB6NW2wug7KoDJrkd84umU2SgXCfBVbEZGm6m1osxuc6VSLKNLUvGvRDm0SBISlk2ZvcLEAP+eeVv6MmvkwCRNPJiQ9AqZuT/SR4RJv7szHJIZOACKsbSfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a0V4XtSB4FPS0jb0XMxjmyRGmxM1LCYoYZuuHWV8i4w=; b=qxzhIk4cuCErrwa/gdplQTPScAHpIUpykfbBtdX4UlmRFJYkqypPrwInPwH1omdO66w8lO7CmuduHI3LEj6Uq+NImkmnuX1qcN1vlzTHZrMuNK/p9uPuGlk9S4pgSLQ0v6U+QhKRRAViXxSnTPayT5uMExeOyMl/bqQigNLn2cuCm9vQWdZ+EDmo1u/sBMM8F08RW2XO73hFcNqSUTrQXsjsbomZ9WdBeHboNsGzZya8KWR1Uwa/Aq+vxO+etGadIQIDMLGycWvZD7CiJof/Ta4VCNNJgwcJru+ziq7euBl989OKGecM8EqAHvZ4bvjS3NUckQlMDsaSVi+v0Tmx7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a0V4XtSB4FPS0jb0XMxjmyRGmxM1LCYoYZuuHWV8i4w=; b=lc/TyFA1nfAbeQiOjgbMqzFNAzs/R00s9eM8/+9BcuTkS0W6pAielpfTKAgrl84nVQ8+w5n4zWHwVdb8fIE/PdQAeLsS54T2nbMfjcxM7NA6uNWCYMWvQ102p5kcIQjGWUyr7bIkZs9588dmBlWV90fvFbEGfS0fXOVEdnoq1JM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [XEN][PATCH 2/2] xenstored: Add newline to error message Date: Mon, 24 Nov 2025 17:35:33 -0500 Message-ID: <20251124223533.31613-3-jason.andryuk@amd.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251124223533.31613-1-jason.andryuk@amd.com> References: <20251124223533.31613-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D2:EE_|IA1PR12MB9737:EE_ X-MS-Office365-Filtering-Correlation-Id: 63a11be7-de1d-4ff9-fb57-08de2ba9cd0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8Jebo6iXKgO2GYoSQ75rR9HY3f4BHEwLDx0sGZJOeXTodG+wfl+wJt/5wyN5?= =?us-ascii?Q?4SS9GptkgmKUYlqQiX+I7KVSoUxpnyzPsxBVgpdVSZb5QK7dNnQ1dmjwyBba?= =?us-ascii?Q?ogKe7yZltnePPQ4SyCaJNU/cfuE7NTdG7tyfMCPFEVAIuLv/4IfXNdo9jZ2l?= =?us-ascii?Q?Hcz8YniZiiTNUliYkuRLfkSdYL2426osSfyHc8DjHjoaouanbP0L5yVb+lST?= =?us-ascii?Q?Swj26fqg2QRPOwajy7a8Hzd9OCR2DQaf1jT0rE+s8bjGhD+fpakH2rMhQcRX?= =?us-ascii?Q?+pmUiSCJ1E4l9e+r1qcAbyd6ubkrGPfQekvonv7+lI6D05Uma/lIYwa8mD2H?= =?us-ascii?Q?3sEmG36HQzX0V8OVU9lovPTbicGOM0muIEy2/92PU6oLwysrulixRLN1Azrc?= =?us-ascii?Q?TbYhU8LefGlotjCFVDa47A0wXNr5DSWY57DYBcVwT2YJC9J0yLY1OrHiC1tM?= =?us-ascii?Q?8ODU0mPYzl1LExLD9rvuFNKSRYkMIEqiaosvOUvJNg5uug0V/bkrgK7/O+P0?= =?us-ascii?Q?IZ4z0tyKXbx2HCYkgqdjHT4qpuHX84tZooysfut7wN4NIHMPalbVVIIbIdO8?= =?us-ascii?Q?0zAMZVMq15CQv4TUIyAuh5KtvfHS8F3PJQExxjkxGaQGx1oWpmAUahWuV1DK?= =?us-ascii?Q?k3udXWClCti36cmRxkyE/vC3j9jKa/vHpYhJ2YS6OMXx/U0SAvKHptMXcPJ0?= =?us-ascii?Q?gNhKmGvdrQVd30gUfqMyc558C0Pkp1kSs0pOiemIXHIKlPlPPupmIJIkoA8y?= =?us-ascii?Q?QwKXry+7LUwnTkMFjKCikPNniEK5Qev6ZjzbijgoiZD6eoz+6zmNPyP5jcpT?= =?us-ascii?Q?YFMSCnfNtrGv3i4HYdapgEzOLSb3yfeEZT5MvLyW9Zm2slpe/f8a6lwqz2gu?= =?us-ascii?Q?M+tyuYnhQlvohcnQn8lvflpgjHISX/jVazXjKAwAFyDIDZ1hY5J+gcgwzW87?= =?us-ascii?Q?r0B7GLN8o+Prfblnuh2BANgb4OJO/c3ZnMIfsJyrhm3MZ9n24swS1MDZgmP1?= =?us-ascii?Q?9W8PrUzMbzWUobIhxSekyjuaay/Vd00R0zwLvBkU78EMUoaSB0XSWDnMLCld?= =?us-ascii?Q?0Z42N3BIryeiIyFCw6Fz25mYyz7gsb4oAb7qo1uDqn7tb/7NTiTTHjflobcQ?= =?us-ascii?Q?tFmNiH+xCROqatUSleR3MkiKq7IMwU5rjzJ8qjxmK5xJXNOkT7O/Iqq3s4cn?= =?us-ascii?Q?idZxZpyCR/q44uZh1D2ydD/HfCqgLV11I4rI4mDwACp5zlT3dpF8cGSjaxmr?= =?us-ascii?Q?HFZZb+nyp3t3ct+THWJOIlha3FLzdAfCGXaDWr5Bcd5eEfhamtVAPdbk8v7l?= =?us-ascii?Q?EMmiuoqn25p8+Jz7kK3PdPo6wBI12uaH1z/wJR3tbJjI0d2HDkdQoRtF7SGa?= =?us-ascii?Q?raQTrz1Ff2oDIijS5g0SMKD/0vrEgqFaEUtn6aJTBF1jjePFshgKCFSCN289?= =?us-ascii?Q?AICUBQYOZa5wJsfTUjQCleRwfID6zJrmwoALF0ubJtndVan+1Xaab+N8Rczz?= =?us-ascii?Q?PFmnwCyK9qJRzPuvepOsuHd6mwUqjzo/Wv1fWpV3pYq6VYmH+kw+1HIdGTs2?= =?us-ascii?Q?I7HIWDIN9ST8ZvE+8Mk=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2025 22:35:42.1438 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63a11be7-de1d-4ff9-fb57-08de2ba9cd0b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB9737 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1764023780588019200 Content-Type: text/plain; charset="utf-8" Unlike barf(), xprintf() does not add a newline. Add one. Fixes: e5b0a9405571 ("tools/xenstored: Auto-introduce domains") Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross --- tools/xenstored/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index d504e9994b..10ac1c1a8f 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1333,7 +1333,7 @@ static bool init_domain(unsigned int domid) =20 domain =3D introduce_domain(NULL, domid, port, false); if (!domain) { - xprintf("Could not initialize dom%u", domid); + xprintf("Could not initialize dom%u\n", domid); return false; } =20 --=20 2.51.1