From nobody Sun Dec 14 11:17:16 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763727772; cv=none; d=zohomail.com; s=zohoarc; b=U8bf6jw0v3Fc94FgGhe0J3p7nqsuXf3uFZPPEIA53I3YcEbw0yk7oHDKxVHY8myPaV3KjmyAHJSwJIfg5QD73TE1sL2S6NH4eNHh3N2mFwDa1TwOKriHiyOAmHcTQBe7VlOEFO45tOKN2pzxSPB9xi3nLbH4ONKVJ4f3Emy8d/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763727772; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oeDPJTEK/mbRoQ9G1reQyHyjo6pRRwMOwFAV76+b8w0=; b=h4YiLxk3Hxf07IZ6KRQqQWraTWn5Z79fdz9hi5BiS370m0ZIP1uLOeF2K76hFsYxwim/GOlPYxqFbeo2uNMnqGeXA55//BiYrV8sb6TQaAXoTN+yEZ7C1DXpgoO7prsQy+0ETMQlntXVv824VyY7ZtwmmJvuMViamARRmO6aEYA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763727772737257.98262779432025; Fri, 21 Nov 2025 04:22:52 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1169122.1494987 (Exim 4.92) (envelope-from ) id 1vMQ9r-0001gE-18; Fri, 21 Nov 2025 12:22:35 +0000 Received: by outflank-mailman (output) from mailman id 1169122.1494987; Fri, 21 Nov 2025 12:22:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vMQ9q-0001g7-Un; Fri, 21 Nov 2025 12:22:34 +0000 Received: by outflank-mailman (input) for mailman id 1169122; Fri, 21 Nov 2025 12:22:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vMQ2a-000110-Ti for xen-devel@lists.xenproject.org; Fri, 21 Nov 2025 12:15:04 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b185bbdc-c6d3-11f0-980a-7dc792cee155; Fri, 21 Nov 2025 13:14:57 +0100 (CET) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-544-9KVhRz1PNjG4B1qvQhE2_Q-1; Fri, 21 Nov 2025 07:14:53 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F29621956061; Fri, 21 Nov 2025 12:14:48 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.3]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A221C1800451; Fri, 21 Nov 2025 12:14:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D6F9B21EC348; Fri, 21 Nov 2025 13:14:38 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b185bbdc-c6d3-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763727296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oeDPJTEK/mbRoQ9G1reQyHyjo6pRRwMOwFAV76+b8w0=; b=Spl+zlBQgLZqwMCrUqPceqwgxxnt/Z267qV7KDpVeXPbhgezAsabgg33ydhrPrm/0sXwT2 P9hND5u2TVUJPwoe2eXywkxeJibM29x5d0/0T6DA+T+hOa4JYfp1Bq7hvcuUjZcCVp7i71 HqD1qdYNMMzCo4QCIFZUrRC+igcueoM= X-MC-Unique: 9KVhRz1PNjG4B1qvQhE2_Q-1 X-Mimecast-MFC-AGG-ID: 9KVhRz1PNjG4B1qvQhE2_Q_1763727289 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: arei.gonglei@huawei.com, zhenwei.pi@linux.dev, alistair.francis@wdc.com, stefanb@linux.vnet.ibm.com, kwolf@redhat.com, hreitz@redhat.com, sw@weilnetz.de, qemu_oss@crudebyte.com, groug@kaod.org, mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, kraxel@redhat.com, shentey@gmail.com, npiggin@gmail.com, harshpb@linux.ibm.com, sstabellini@kernel.org, anthony@xenproject.org, paul@xen.org, edgar.iglesias@gmail.com, elena.ufimtseva@oracle.com, jag.raman@oracle.com, sgarzare@redhat.com, pbonzini@redhat.com, fam@euphon.net, philmd@linaro.org, alex@shazbot.org, clg@redhat.com, peterx@redhat.com, farosas@suse.de, lizhijian@fujitsu.com, dave@treblig.org, jasowang@redhat.com, samuel.thibault@ens-lyon.org, michael.roth@amd.com, kkostiuk@redhat.com, zhao1.liu@intel.com, mtosatti@redhat.com, rathc@linux.ibm.com, palmer@dabbelt.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, marcandre.lureau@redhat.com, qemu-block@nongnu.org, qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, qemu-riscv@nongnu.org Subject: [PATCH v2 15/15] block/file-win32: Improve an error message Date: Fri, 21 Nov 2025 13:14:38 +0100 Message-ID: <20251121121438.1249498-16-armbru@redhat.com> In-Reply-To: <20251121121438.1249498-1-armbru@redhat.com> References: <20251121121438.1249498-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763727773368018900 Content-Type: text/plain; charset="utf-8" Two out of three calls of CreateFile() use error_setg_win32() to report errors. The third uses error_setg_errno(), mapping ERROR_ACCESS_DENIED to EACCES, and everything else to EINVAL, throwing away detail. Switch it to error_setg_win32(). Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- block/file-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/file-win32.c b/block/file-win32.c index 0efb609e1d..78961837c8 100644 --- a/block/file-win32.c +++ b/block/file-win32.c @@ -904,7 +904,7 @@ static int hdev_open(BlockDriverState *bs, QDict *optio= ns, int flags, } else { ret =3D -EINVAL; } - error_setg_errno(errp, -ret, "Could not open device"); + error_setg_win32(errp, err, "Could not open device"); goto done; } =20 --=20 2.49.0