From nobody Sun Dec 14 11:16:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763727334; cv=none; d=zohomail.com; s=zohoarc; b=T7swcIlHG8Ko75svRiHK/V5TVL8Zp+un4wibg09mMQmnA9pRPEd4vxiv/zFubCIAxnyi6SIv2koi/PR+W0gkHATVC7UxJCpN5YLSxm3kYwViY5FeZRtAUfm1QDvphcwV4UzK0RyRofJro6vjMEjJbHUPwmAhuZAfgBNwItsWrBM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763727334; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PVQXGNJdcClwDB+2E7ow8Z/C597X2bSbqnOJ1Z7jY2c=; b=SC5erVC/8L8BGM/YlOtmku73OZC8wBBLDcQ3lLfBSyNQHRAhJG6rR6CBbOaISMoG8+hBAIyj5uJ/nipWYz7DWhOnr8s/642Fr8AXG+VZ5kKhZWDKrJX4PNM6O5xCGsHImbg9in6i617S/vGe/ngF2V/YkOfq6OPMla8qxXaspgQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763727334276755.469520668496; Fri, 21 Nov 2025 04:15:34 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1168999.1494964 (Exim 4.92) (envelope-from ) id 1vMQ2d-00049P-01; Fri, 21 Nov 2025 12:15:07 +0000 Received: by outflank-mailman (output) from mailman id 1168999.1494964; Fri, 21 Nov 2025 12:15:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vMQ2c-00045Y-Mn; Fri, 21 Nov 2025 12:15:06 +0000 Received: by outflank-mailman (input) for mailman id 1168999; Fri, 21 Nov 2025 12:15:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vMQ2Z-000110-Tc for xen-devel@lists.xenproject.org; Fri, 21 Nov 2025 12:15:03 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b149dc15-c6d3-11f0-980a-7dc792cee155; Fri, 21 Nov 2025 13:14:57 +0100 (CET) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-536-KEwxzFw_O_aBSQQYGuDLyQ-1; Fri, 21 Nov 2025 07:14:50 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C1525195609D; Fri, 21 Nov 2025 12:14:46 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.3]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CDC6A18004D8; Fri, 21 Nov 2025 12:14:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C5B6E21E676A; Fri, 21 Nov 2025 13:14:38 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b149dc15-c6d3-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763727296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PVQXGNJdcClwDB+2E7ow8Z/C597X2bSbqnOJ1Z7jY2c=; b=OKaPwC7W9p+RJO3bbOhb1UhQlXWpNMaGYLocKjUa5QkEAxuUzv2zZCUX3olBhzdmiZGnv9 Z1qL6/EY4FJxL3DxUG2+5oImKuNQ7dqKC1sj37uJoJLY3g4oXkMENaRBqKKk82xwsHX/J/ BVzXPzYz8W3jKHQjvlQcMlIpYo7vDjU= X-MC-Unique: KEwxzFw_O_aBSQQYGuDLyQ-1 X-Mimecast-MFC-AGG-ID: KEwxzFw_O_aBSQQYGuDLyQ_1763727286 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: arei.gonglei@huawei.com, zhenwei.pi@linux.dev, alistair.francis@wdc.com, stefanb@linux.vnet.ibm.com, kwolf@redhat.com, hreitz@redhat.com, sw@weilnetz.de, qemu_oss@crudebyte.com, groug@kaod.org, mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, kraxel@redhat.com, shentey@gmail.com, npiggin@gmail.com, harshpb@linux.ibm.com, sstabellini@kernel.org, anthony@xenproject.org, paul@xen.org, edgar.iglesias@gmail.com, elena.ufimtseva@oracle.com, jag.raman@oracle.com, sgarzare@redhat.com, pbonzini@redhat.com, fam@euphon.net, philmd@linaro.org, alex@shazbot.org, clg@redhat.com, peterx@redhat.com, farosas@suse.de, lizhijian@fujitsu.com, dave@treblig.org, jasowang@redhat.com, samuel.thibault@ens-lyon.org, michael.roth@amd.com, kkostiuk@redhat.com, zhao1.liu@intel.com, mtosatti@redhat.com, rathc@linux.ibm.com, palmer@dabbelt.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, marcandre.lureau@redhat.com, qemu-block@nongnu.org, qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, qemu-riscv@nongnu.org Subject: [PATCH v2 12/15] error: Use error_setg_errno() to improve error messages Date: Fri, 21 Nov 2025 13:14:35 +0100 Message-ID: <20251121121438.1249498-13-armbru@redhat.com> In-Reply-To: <20251121121438.1249498-1-armbru@redhat.com> References: <20251121121438.1249498-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763727335425018900 Content-Type: text/plain; charset="utf-8" A few error messages show numeric errno codes. Use error_setg_errno() to show human-readable text instead. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- backends/cryptodev-lkcf.c | 2 +- hw/ppc/spapr.c | 6 +++--- hw/vfio/migration-multifd.c | 5 +++-- migration/rdma.c | 3 +-- net/l2tpv3.c | 6 ++---- target/riscv/kvm/kvm-cpu.c | 11 ++++++----- 6 files changed, 16 insertions(+), 17 deletions(-) diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c index 97a8a8812c..40c7bd3c5a 100644 --- a/backends/cryptodev-lkcf.c +++ b/backends/cryptodev-lkcf.c @@ -218,7 +218,7 @@ static void cryptodev_lkcf_init(CryptoDevBackend *backe= nd, Error **errp) } lkcf->eventfd =3D eventfd(0, 0); if (lkcf->eventfd < 0) { - error_setg(errp, "Failed to create eventfd: %d", errno); + error_setg_errno(errp, errno, "Failed to create eventfd"); return; } =20 diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 99b843ba2f..cdab822c88 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2699,9 +2699,9 @@ static void spapr_set_vsmt_mode(SpaprMachineState *sp= apr, Error **errp) ret =3D kvmppc_set_smt_threads(spapr->vsmt); if (ret) { /* Looks like KVM isn't able to change VSMT mode */ - error_setg(&local_err, - "Failed to set KVM's VSMT mode to %d (errno %d)", - spapr->vsmt, ret); + error_setg_errno(&local_err, -ret, + "Failed to set KVM's VSMT mode to %d", + spapr->vsmt); /* We can live with that if the default one is big enough * for the number of threads, and a submultiple of the one * we want. In this case we'll waste some vcpu ids, but diff --git a/hw/vfio/migration-multifd.c b/hw/vfio/migration-multifd.c index e4785031a7..4a855f4e12 100644 --- a/hw/vfio/migration-multifd.c +++ b/hw/vfio/migration-multifd.c @@ -725,8 +725,9 @@ vfio_multifd_save_complete_precopy_thread(SaveCompleteP= recopyThreadData *d, data_size =3D read(migration->data_fd, &packet->data, migration->data_buffer_size); if (data_size < 0) { - error_setg(errp, "%s: reading state buffer %" PRIu32 " failed:= %d", - vbasedev->name, idx, errno); + error_setg_errno(errp, errno, + "%s: reading state buffer %" PRIu32 " failed", + vbasedev->name, idx); goto thread_exit; } else if (data_size =3D=3D 0) { break; diff --git a/migration/rdma.c b/migration/rdma.c index 337b415889..9e301cf917 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -2349,8 +2349,7 @@ static int qemu_get_cm_event_timeout(RDMAContext *rdm= a, error_setg(errp, "RDMA ERROR: poll cm event timeout"); return -1; } else if (ret < 0) { - error_setg(errp, "RDMA ERROR: failed to poll cm event, errno=3D%i", - errno); + error_setg_errno(errp, errno, "RDMA ERROR: failed to poll cm event= "); return -1; } else if (poll_fd.revents & POLLIN) { if (rdma_get_cm_event(rdma->channel, cm_event) < 0) { diff --git a/net/l2tpv3.c b/net/l2tpv3.c index cdfc641aa6..3044fa4608 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -639,13 +639,11 @@ int net_init_l2tpv3(const Netdev *netdev, } fd =3D socket(result->ai_family, result->ai_socktype, result->ai_proto= col); if (fd =3D=3D -1) { - fd =3D -errno; - error_setg(errp, "socket creation failed, errno =3D %d", - -fd); + error_setg_errno(errp, errno, "socket creation failed"); goto outerr; } if (bind(fd, (struct sockaddr *) result->ai_addr, result->ai_addrlen))= { - error_setg(errp, "could not bind socket err=3D%i", errno); + error_setg_errno(errp, errno, "could not bind socket"); goto outerr; } if (!qemu_set_blocking(fd, false, errp)) { diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 47e672c7aa..c73f1cd5cf 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -1996,8 +1996,8 @@ static bool kvm_cpu_realize(CPUState *cs, Error **err= p) if (riscv_has_ext(&cpu->env, RVV)) { ret =3D prctl(PR_RISCV_V_SET_CONTROL, PR_RISCV_V_VSTATE_CTRL_ON); if (ret) { - error_setg(errp, "Error in prctl PR_RISCV_V_SET_CONTROL, code:= %s", - strerrorname_np(errno)); + error_setg_errno(errp, errno, + "Error in prctl PR_RISCV_V_SET_CONTROL"); return false; } } @@ -2032,7 +2032,8 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) reg.addr =3D (uint64_t)&val; ret =3D ioctl(kvmcpu.cpufd, KVM_GET_ONE_REG, ®); if (ret !=3D 0) { - error_setg(errp, "Unable to read cbom_blocksize, error %d", er= rno); + error_setg(errp, errno, + "Unable to read cbom_blocksize"); return; } =20 @@ -2051,7 +2052,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) reg.addr =3D (uint64_t)&val; ret =3D ioctl(kvmcpu.cpufd, KVM_GET_ONE_REG, ®); if (ret !=3D 0) { - error_setg(errp, "Unable to read cboz_blocksize, error %d", er= rno); + error_setg_errno(errp, errno, "Unable to read cboz_blocksize"); return; } =20 @@ -2073,7 +2074,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) reg.addr =3D (uint64_t)&val; ret =3D ioctl(kvmcpu.cpufd, KVM_GET_ONE_REG, ®); if (ret !=3D 0) { - error_setg(errp, "Unable to read vlenb register, error %d", er= rno); + error_setg_errno(errp, errno, "Unable to read vlenb register"); return; } =20 --=20 2.49.0