From nobody Sun Dec 14 05:54:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=invisiblethingslab.com ARC-Seal: i=1; a=rsa-sha256; t=1763579587; cv=none; d=zohomail.com; s=zohoarc; b=m5OWiKdC607NdVNs72uMiU0YabWyFEjWfzD2S5UsqA4FF3efadG3bqARByC4910+Mp/PlKV6nO3mTgaesLSMJNwiorO9kIDfhmViMDfUTmRAEr7ICYk2rZ1lsLCGjJyMWP9SzR2iHYflGoHWKA8V0DxCKh7ivpkC1x3YIC0Nr2E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763579587; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TPHRLLUj9N7LeFhs2fEg1LQrQouY7BKz7R9+rgW0YsE=; b=eVsFYcwlYEJKijsP1RIy49HHfNemy6h8J0jx/vyne+XgCPiMP3k2MYjAgw9UAC+P0aAvc+Ygmso9qZ7w9zwCe9UrrZZ2iE9uiwIHyAyGLuOhQOcVROJoOv6te8Vm/icanbt+xvHK7kGYQOhaUzgh4W4wSzeJeM7aQE3mxs6V0Lc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763579587827574.7313019198099; Wed, 19 Nov 2025 11:13:07 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1166325.1492884 (Exim 4.92) (envelope-from ) id 1vLnbi-0007Ps-MF; Wed, 19 Nov 2025 19:12:46 +0000 Received: by outflank-mailman (output) from mailman id 1166325.1492884; Wed, 19 Nov 2025 19:12:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLnbi-0007Pl-Jb; Wed, 19 Nov 2025 19:12:46 +0000 Received: by outflank-mailman (input) for mailman id 1166325; Wed, 19 Nov 2025 19:12:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLnbh-0007Pd-7h for xen-devel@lists.xenproject.org; Wed, 19 Nov 2025 19:12:45 +0000 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8a35941-c57b-11f0-9d18-b5c5bf9af7f9; Wed, 19 Nov 2025 20:12:42 +0100 (CET) Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 3B72C1D00093; Wed, 19 Nov 2025 14:12:41 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Wed, 19 Nov 2025 14:12:41 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Nov 2025 14:12:39 -0500 (EST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8a35941-c57b-11f0-9d18-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1763579561; x=1763665961; bh=TPHRLLUj9N7LeFhs2fEg1LQrQouY7BKz 7R9+rgW0YsE=; b=lVQcL7UwZaCpONrm/KSwcSoH6r613//7zdP5vNMmriwIs4CY u5K3Z/KTcrzl+9w8Z3JRYZez1gd0uoiujMZyZItm9fws/zP7hpvczvZGt2UZRcrn knuwarMLKZp3q47yolrd5jFKg/Xw+7Xo50iHBeazS4BI7Cp7geLSn21QrQDPDgN7 HfRQL5gqPr9TPULK2pYwdibIpqbIhzJLmQ9S1XCWvUw36yVBiTh4Uy2y0Dzcy1+d mbc/ZlyOdP5bn63drUP/RGKeB/Zu0eYFOXQiVi9lpHB78Wh5MjiiBgBRhGOAYZkE oWAGUxd4eMrStwqQS2NHlffd28QwHI3W6jMTqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1763579561; x=1763665961; bh=TPHRLLUj9N7LeFhs2fEg1LQrQouY 7BKz7R9+rgW0YsE=; b=fFensa4GCJYkFrjHSMzQKHmcIxC8rKFj5b54WFuxheUK T/SD+VvRvO2ROBPhb3azw1u9OkVwNmrALp94U9lQ6mxMtR+SqbhWCEaOttgexbFT 0vABzkh0HOixEbhtbNQXGmfuuZ3/jwH2hYn6pnGfk/zzKKVqpcOquClfiG0O40Vn q0VJVBNm4TA51EhS7SnE0RtP/5puQnXjz4jwlM6rrqYVApYYonJf5Bb4I7IP4i/s 3WdLZTpL1xVZcNFWrR6YinRHjaEIA5lC+sAt2fSKVw8/EPfsWrF617PidkQrgAeF Zg+hgfaT+QQZMMIYJQq6PHeYUkOah71RddsYDsLtIQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvvdehtdduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghkucfo rghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduteevffdv keduvddulefflefhveehhefgieffudffteegvdejuefgvdejfeeftdenucffohhmrghinh epkhgvrhhnvghlrdhorhhgpdhtrhhmmhdrnhgvthdplhgushdrshgsnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomhdpnhgspghrtghpthhtohephedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepgigvnhdquggvvhgvlheslhhishhtshdrgi gvnhhprhhojhgvtghtrdhorhhgpdhrtghpthhtohepmhgrrhhmrghrvghksehinhhvihhs ihgslhgvthhhihhnghhslhgrsgdrtghomhdprhgtphhtthhopehjsggvuhhlihgthhessh hushgvrdgtohhmpdhrtghpthhtoheprghnughrvgifrdgtohhophgvrhefsegtihhtrhhi gidrtghomhdprhgtphhtthhopehrohhgvghrrdhprghusegtihhtrhhigidrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH] xen: Fix EFI buildid alignment Date: Wed, 19 Nov 2025 20:12:31 +0100 Message-ID: <20251119191235.863187-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @invisiblethingslab.com) X-ZM-MESSAGEID: 1763579589414019100 Old binutils get confused about .buildid overlapping (in VA space) with earlier section. That confusion results in weird errors down the road, like this one: objcopy: xen.efi: Data Directory size (1c) exceeds space left in sectio= n (8) While the bug is fixed in later binutils version, force alignment of the buildid to avoid overlapping and make it work with older versions too. This can be reverted once toolchain base is raised at or above binutils 2.36. Details at: https://lore.kernel.org/all/3TMd7J2u5gCA8ouIG_Xfcw7s5JKMG06XsDIesEB3Fi9htUJ= 43Lfl057wXohlpCHcszqoCmicpIlneEDO26ZqT8QfC2Y39VxBuqD3nS1j5Q4=3D@trmm.net/ Signed-off-by: Marek Marczykowski-G=C3=B3recki Fixes: eee5909e9d1e ("x86/EFI: use less crude a way of generating the build= ID") Reviewed-by: Andrew Cooper , although... --- While the actual bug apparently is in binutils, the commit mentioned in Fixes: tag introduced part that triggers that bug. --- xen/arch/x86/xen.lds.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index 5d02f83a409c..967f9167f757 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -171,6 +171,8 @@ SECTIONS __note_gnu_build_id_end =3D .; } PHDR(note) PHDR(text) #elif defined(BUILD_ID_EFI) + /* Workaround bug in binutils < 2.38 */ + . =3D ALIGN(32); DECL_SECTION(.buildid) { __note_gnu_build_id_start =3D .; *(.buildid) --=20 2.51.0