From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761141732; cv=none; d=zohomail.com; s=zohoarc; b=nTSm1s0I2D/lCdhqKbVE0x6/srEQYlpVCZCiesaP5UEu7BsqfMT2sDXUOqx942hhS4qdrvpT51ImMT2AIx6st39kdhByf07AX/0L49Fc/hpG3kKbk91R0VQMgjRPhd3lqfvBsS+SqI//NjfxzrLQBd+XDeL3IlAlDizeNFYOp/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761141732; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4HjNE4Xkg6Ebkq5X/NZT8seGp5EoTUwdTjpH6KQ8QUA=; b=DR33e2aXRrKCCwWwqylBzEAe1KhvGGTTW1cJlljKc/KiWVTwBVNyYiU1p+9XLAs854J29Qooj3T7vf0twltgO6sbNjKaAwXGj0Gehi6AbGI10wFGhCeMDiMDUOu/5MdD+uThSCES1NENXOpNn4QnJChG+HtS0AXA34TqWqCKU/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761141732795973.9133907453584; Wed, 22 Oct 2025 07:02:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBZPd-0007O8-3N; Wed, 22 Oct 2025 10:02:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBZPK-0007LK-58 for qemu-devel@nongnu.org; Wed, 22 Oct 2025 10:01:48 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vBZPD-0001dz-Ko for qemu-devel@nongnu.org; Wed, 22 Oct 2025 10:01:38 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4711b95226dso58329285e9.0 for ; Wed, 22 Oct 2025 07:01:35 -0700 (PDT) Received: from localhost.localdomain ([88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47496cf3b51sm37114995e9.9.2025.10.22.07.01.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 22 Oct 2025 07:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761141694; x=1761746494; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4HjNE4Xkg6Ebkq5X/NZT8seGp5EoTUwdTjpH6KQ8QUA=; b=JcLcM1Tgs3kZGEhB6WTnuLbQB4DRoXejf9dDH1Q7Ihrb7ggxYcu+UTpKPHBfnNdlBQ Ee/M9OA9Vmwd/zkS7CUHkkoZ47fbTgGLn/+FHiNWuFXuJvkryoaJg58DSN3l00kqH5SR 7SpAckAPyCbr0RuvWKM/PWloatScKS2m6vzk7ObofGj4oCkTwrCPzd5h8vBhyXmObfYr zQblPoWFAMLeOv3JCcI0OfJusfk5Cc9BL0uPPB3r2XcjaC9Cw+7I+kXlw1Cy9KKwEawy Rxd7BjCeIPn4xgZ5wxO9pb8zekzBRMJHLSU6XE9EqddQw6KnFMeTVDtbMHSHZgzDd7km GS/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761141694; x=1761746494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4HjNE4Xkg6Ebkq5X/NZT8seGp5EoTUwdTjpH6KQ8QUA=; b=PzN65sigDkNuxJD3gJgNYpg5/T+fVVM2n4eQfmqtj9flOd4zcsm+rPyj9b8kmBIHZx tvgIT2lvqufL7fLyT1x/OGQpTb/72wqHKlj78ZpHUKtmMHClS8tCYyJhbgyDvJNhASJU IJvXfuJlUfgEYaCr5NlzjxYdtsx6yXq4s3zeh6S6FXKOtQp370snV07A7Wv6K6o2N/8+ Awit3qiF0+uLr01ZnItxCkXTVTJzeSTWMJO9T8b9bnWAwyGTd1lNSpouYMg5iGyMSNuv OTwVMsFWhnqUtcirRAgVfwnRwjKJPSuO6jl4ccZe3A3irhouOmp3gnkMogJOOAP+zXsm a0RA== X-Gm-Message-State: AOJu0Yz4u2GhZzii+xPLLjBjp6Y7XvCsUD4bY7J5am9VMZmPO0PXo8iI MquA9S5T2AVbjdkfxI2rlQjZQueSx4nwBcuVlsP9D2Qxh1b0RhZf978DjMhcZtO+zubRL+zMEu2 rvuSnPX8= X-Gm-Gg: ASbGncuCX1ccgyMepulOYJKqLK/oPMp2EZJ6Wda8ApioxEI132kqu6M6l5cGtXceiQY nVJyX2KytK5vmkFKYNRTrvrJnNj+pLL0Em93Gu+kKzquXvx0v09aZruBwJ58+NXr1jF8KC3Tqw5 1a8hM5Olz8xS8cJa3uXNmrZyDGb1TOwZ+JghHXmmg9kmEju58Pwr5l1Zv79vqPwCnl/yUAFzec+ JzKvtLA1Sq3ewcATulZHTwJjYJHFG2fh4dGM2ygHdIB1GE+dD6EC8ZeXeNbMbfcb/rnnuOKFi3l YsaupwHEvES0/RKAo6ZftOfh5jXl0loPPJ6AnLDHoHY8KyzkoQJSKKWMFt/Bugon+quLxspSaAe c2Sf3FNdMQFVd+WYm692/nIQPoYfTRyrUVcF26ivXvtmtR6adJ5mgcpPWL30jnLgel+zEEnHOtG AGbM1h7heKyG8fsI3WilW/15lILUzV/A== X-Google-Smtp-Source: AGHT+IFQ7L4fBGIJoJXHNjn08SD4wzUmt9U1mWP674dDSbDfSAlvpQwuJQwgI77QmiqDAnGzdB8FEQ== X-Received: by 2002:a05:600c:4511:b0:46e:1a5e:211 with SMTP id 5b1f17b1804b1-47117907a5dmr135379745e9.21.1761141692085; Wed, 22 Oct 2025 07:01:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Pierrick Bouvier , Paul Durrant , Stefano Stabellini , Anton Johansson , "Edgar E. Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] hw/xen: Use BITS_PER_BYTE & MAKE_64BIT_MASK() in req_size_bits() Date: Wed, 22 Oct 2025 16:01:11 +0200 Message-ID: <20251022140114.72372-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251022140114.72372-1-philmd@linaro.org> References: <20251022140114.72372-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761141733830158500 Replace magic 8 by BITS_PER_BYTE, use MAKE_64BIT_MASK() instead of open coding it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Edgar E. Iglesias Reviewed-by: Pierrick Bouvier --- hw/xen/xen-hvm-common.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c index 52e2cce397a..258014370e1 100644 --- a/hw/xen/xen-hvm-common.c +++ b/hw/xen/xen-hvm-common.c @@ -1,5 +1,6 @@ #include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/bitops.h" #include "qemu/error-report.h" #include "qapi/error.h" #include "exec/target_long.h" @@ -448,12 +449,14 @@ static void cpu_ioreq_config(XenIOState *state, ioreq= _t *req) =20 static void handle_ioreq(XenIOState *state, ioreq_t *req) { + size_t req_size_bits =3D req->size * BITS_PER_BYTE; + trace_handle_ioreq(req, req->type, req->dir, req->df, req->data_is_ptr, req->addr, req->data, req->count, req->size); =20 if (!req->data_is_ptr && (req->dir =3D=3D IOREQ_WRITE) && (req->size < sizeof (target_ulong))) { - req->data &=3D ((target_ulong) 1 << (8 * req->size)) - 1; + req->data &=3D MAKE_64BIT_MASK(0, req_size_bits); } =20 if (req->dir =3D=3D IOREQ_WRITE) --=20 2.51.0 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761141805; cv=none; d=zohomail.com; s=zohoarc; b=CVt4GlisqbKwVose592J0vVHSGB916PZae9aNSYw3+ebJl2b9htbxLX3hn0EFzQHEtHTt2Y9ednRTXIPBLvXs9ymYJGrybl7G+4qXFtFapAdmLB141HOEVfcVleHpVhMK4rrfmvEBFh8Sef1Znc1Rmv5MgSCJ3ShSAyDLkKLEh4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761141805; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qLHVl30GjqbT2sNGUrp6u7XODjWGOXYBV9cF9vJVcc4=; b=gabSto5A9kqtyDY0WzHlmVXBx+rvgmLtSDilfLcM5bIiNFdg/2Dh4DSq1UaysVnPj93aJXCmOhdUSU98ATsF6ldX6nlqY9UMAbUYPQV5yVvb1Di4toE6YgZKDFdb61WT93avY+9Pc24kUG/K61eqgJaJo6MzNBOx9twayXQ0Izk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1761141804976212.20707338268676; Wed, 22 Oct 2025 07:03:24 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1148158.1480347 (Exim 4.92) (envelope-from ) id 1vBZPR-0004Dy-38; Wed, 22 Oct 2025 14:01:49 +0000 Received: by outflank-mailman (output) from mailman id 1148158.1480347; Wed, 22 Oct 2025 14:01:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBZPR-0004Dr-0P; Wed, 22 Oct 2025 14:01:49 +0000 Received: by outflank-mailman (input) for mailman id 1148158; Wed, 22 Oct 2025 14:01:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBZPP-0003XH-GU for xen-devel@lists.xenproject.org; Wed, 22 Oct 2025 14:01:47 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a529406c-af4f-11f0-980a-7dc792cee155; Wed, 22 Oct 2025 16:01:45 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3ece1102998so5658263f8f.2 for ; Wed, 22 Oct 2025 07:01:45 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427f00ce3e2sm25403441f8f.47.2025.10.22.07.01.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 22 Oct 2025 07:01:44 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a529406c-af4f-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761141705; x=1761746505; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qLHVl30GjqbT2sNGUrp6u7XODjWGOXYBV9cF9vJVcc4=; b=TM92pJ61n1SyIS4H6ljDsqCSfzkbuENXBMiiR5esiC8Q2BpNbAHdWw5AzGgqZng7Hp 0BTd1BL5mOqrSlPasUhGX2MP+p8ndmO5fiZ6NqPO5Qqr6IP7CVeld8+SokR5VIzEJ3Z7 LdMONE/soWsbY4BF98Rm8od4+l1K78+yPCotyhK2p0r+Gn4TOQkla0CrtnPtTo+IkR5o 2PjH1eoeIcNH38e+46fBvFbUMXehBMhn/OrF7tv2AgcBxZ/FRHJRkC5Yzd2TmJm34j00 A1a+mKvsSydY6e8DqsouFeEgJ/1LXjmOr41j0fBwl1RNmTsafAntet7f8MqRiP+Wy8SR Xrzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761141705; x=1761746505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qLHVl30GjqbT2sNGUrp6u7XODjWGOXYBV9cF9vJVcc4=; b=en5UFf1YRgMug+pEcOYOTJ5LZmLlw9iFyHnW3M/Afx+Rbz4K39Zz3nrL96rIFXCVfv Gbq68MzBN162Ddy5XGVC/fSpnDoc+oRJAWwqSQOrGeRQpxUfebIsPFcmVME4wfCgjHr1 PDQeaAUhISibo78vPziVl25Cg5r22rkJ4pQBCKrcxuVtdn45X5cN8GJzTgrk2tuGRlg/ RP+LZX6jR8r3fLFiev2TNVWlIkrJjJAUUicsdstYu9g2m1Op43L3x1+pQUfIM+sVogka P3sHJXOyySsudfWMGiITdLi4Njv5thUnAaGZqoQI9C+WZtgT8vQ1sKD6AG3TSyTwimOU pNCg== X-Forwarded-Encrypted: i=1; AJvYcCV0WbH2t/kMll0NE9ULNFTcxYA8foSiU5hfAN8Rev1a0eh7P17/IJ2zI4XVKClFA5ZNlBei0mCcFgE=@lists.xenproject.org X-Gm-Message-State: AOJu0YxFtcWcs4GwI7zuueSZRnCz64+7KljUiMKWljBQ7nb3eaNo+CRy YO86e1LlhtLLSHzyvf0NrkHeb3D/2WTvQd4Ojo+2PJJCMkGqmJPyuiNdGM7yTJuhZEOvtaTrj8O 80lcspc8= X-Gm-Gg: ASbGncucK1JwiKMtw3ByWh29bLiaG2TBBob4/tkIrxMhyQgZcmq5S8i3TF2oftvYe0l NvYgmYDeykYCBjpsbhh5VSZupseTt54sjkaTgev7nLvG3fmIlHKzZVT50mQTigAnd5AGVBtayKe Gm6UHtn/FMvK3MwYPSqnNuKaADq/0NJSIcejhRUc4MSjTH7igaQT6eyYHMwTDHTFlYdPSH3OS3a 5aWe6R5wTsxV2+k2A26KSiVVU5b7v6YG13Hqou60FPWHiQ9rtDH2P8xcAlPkHqURRf8hYyTZvoA d2U0Fqk2HR6fGvv19Gu9aGbz7yuUSer7dF57lRBeu0cPoXaWSW4Vmv9ON3csTVh26+lF8Lnxaoy vBLFfTiOZjZ13aZFj9/pBu7uLa5WPn8OtQ0qHOJOHPUiIXCpjzmXbZpj4AdADzJ6fKK91dgLJU4 7lBwfun0saByY+DCIi0biwXutMc5BmXj70e2uc8GOFBCfl0NTe6XzAj01ecrO2qxFc9UZw3No= X-Google-Smtp-Source: AGHT+IGHHb6FmERd2aST6drwPR4rAF24ZKe8dRavWtQqwCKBMgkph9S4iRBPtxPC9PIdkKTi8zgAlA== X-Received: by 2002:a05:6000:420f:b0:428:51b2:18b4 with SMTP id ffacd0b85a97d-42851b22910mr3947461f8f.29.1761141705142; Wed, 22 Oct 2025 07:01:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Pierrick Bouvier , Paul Durrant , Stefano Stabellini , Anton Johansson , "Edgar E. Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] hw/xen: Replace target_ulong by agnostic target_long_bits() Date: Wed, 22 Oct 2025 16:01:12 +0200 Message-ID: <20251022140114.72372-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251022140114.72372-1-philmd@linaro.org> References: <20251022140114.72372-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761141806479158500 Both are equivalent: target_long_bits() sizeof(target_u?long) * BITS_PER_BYTE Prefer the former which is target-agnostic. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Edgar E. Iglesias Reviewed-by: Pierrick Bouvier --- hw/xen/xen-hvm-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c index 258014370e1..b40ae0b3af0 100644 --- a/hw/xen/xen-hvm-common.c +++ b/hw/xen/xen-hvm-common.c @@ -2,8 +2,8 @@ #include "qemu/units.h" #include "qemu/bitops.h" #include "qemu/error-report.h" +#include "qemu/target-info.h" #include "qapi/error.h" -#include "exec/target_long.h" #include "exec/target_page.h" #include "trace.h" =20 @@ -455,7 +455,7 @@ static void handle_ioreq(XenIOState *state, ioreq_t *re= q) req->addr, req->data, req->count, req->size); =20 if (!req->data_is_ptr && (req->dir =3D=3D IOREQ_WRITE) && - (req->size < sizeof (target_ulong))) { + (req_size_bits < target_long_bits())) { req->data &=3D MAKE_64BIT_MASK(0, req_size_bits); } =20 --=20 2.51.0 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761141736; cv=none; d=zohomail.com; s=zohoarc; b=ZXYiHxh8fSwsnAdiu1yjyJAmjhfTpWDzutfmfUwEdv9w/TF81ht1A9IbtNJOVTGt5+OCjQ9/agxFj4S/BdamQHT+aFyOtr8X9uIOZJIkDN9hoZnmi/PdHaIaXNV2WEjQsjUP6JYakhKKZILxoHgwN0KZSefD0v1dWHoZZMF2zz8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761141736; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UaZKulvsvyPazuPCESEO+VqOsAtzjlNqcxauSGwGk78=; b=Op3S+e70Tm9GMSvuXUUzZfXYlnOO4uGs2LduSXj8W83oVADEoNBIFAmCsnlQWY3SJhqXPGqVHHUH0PZnIe1MyQSVq9Uphse0mBxojoxYAViCLhR/SKs5PZ0akWZ3ciM+RbJc2dDpoYhAiSQ1rGXyGpu9/MS45yOgRGXwSRn2tg4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761141736046741.3767719666389; Wed, 22 Oct 2025 07:02:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBZPf-0007Ql-U0; Wed, 22 Oct 2025 10:02:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBZPe-0007Oy-LE for qemu-devel@nongnu.org; Wed, 22 Oct 2025 10:02:02 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vBZPb-0001fg-FN for qemu-devel@nongnu.org; Wed, 22 Oct 2025 10:02:02 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4711810948aso48991945e9.2 for ; Wed, 22 Oct 2025 07:01:59 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427f00ce586sm25929940f8f.49.2025.10.22.07.01.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 22 Oct 2025 07:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761141717; x=1761746517; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UaZKulvsvyPazuPCESEO+VqOsAtzjlNqcxauSGwGk78=; b=j0gMyBK9xpqrBn6Y+BiW4PpuLWB0zwQuMqw0vjJV9aWmY70gH7u8gvry7lP6Azaub7 5AgCacYd32DcXggTtwFLnVsPMHaIbZDmHlhhx26hL58G7aiqSSkopqjzDLcs+EANsb28 YvbbggcFbCTzmKvmu4EEvllcNiwF8zDZFJW7uwtMjlNQRGgYGY9feMfKYtioarN5BTTX Z3tlwvbRHoOJaQQw1CfTLbePtHFcgHG8UAEvLIGz9eC4Wmqi4jUVJZLjeWzu8Rphjk2A ljO8ZgryGUIwcTDUz04RaVQ2lqrIfKvs+3khvXhCqrs8287sLxAatyw0IoW6qqSXYxn/ A0Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761141717; x=1761746517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UaZKulvsvyPazuPCESEO+VqOsAtzjlNqcxauSGwGk78=; b=et3mPE5l9T9pk4r8SVFe7rbG/G4QqAdrL7Sx/BveGGY3QxoURYKpT7x8MBHbgTkUid +x7Vtk9ei07QJlPMwdHZ0GtqsETU4AuIFmdHtBpl86NCT1zvglQi33V5EJBQmvsbco0c 8yXoRqH3ATG897ZDHiPn9UCEzFw6p/aiBXeDVL7MC2TjW2lWhe+VYTp53B/bQ7DVQIcp 8RdrOGD1c/ugZkEfDz9yAEvdKKYVJ/MsoyF9tjpxmkYB8IHXbjYqYa2qPk84pmzHUahd iwQCSLxGig8hz9uNB++rWwa2lqq3kBF65mBTf9TmApUyI3MNG1d5d/wJ3exTZxoeT6OP vvgg== X-Gm-Message-State: AOJu0Yw8CHdxzAq1GJuXh0mfaGusLfiYCyRCnvmTewjI8JtG6iWf5BhB Wx6hp1jxVMfR8QzaUWomZOxGoY03zZiJlANOrbSoD+mCUWQR4C5JlwqN/N02T4cu/x7YCf8/zLG e/+wFinE= X-Gm-Gg: ASbGncuQIfQK4Da+duweuJJeH302AyKaTa4AH53IkUMTOmFd5zpoik5s0ML+v3Wuv51 kqjqravznv29ulGfqwsnEaIcXfLnZ/RM9bX5hrutLXQn5KKkUkWG2lHdXrasznhF0UNGQvieK3/ 9MbubJQbu4aOJLulqkkrShW3FPPuJqpWyuTxGFlr8p5ho7lwbvS0SObfFORMyDKuOcxC5cxjUFa z2d2Sh1GLKd3d1f1OxIM0l9nD/BXSobYlJPCYfZzuJtFoir2uxZizejmzup0zeQ7SJ5SwgtYjMe 4C9hvMAerlYXbIoCRC/T1xwQhPB0CbP2Nr/zaDKMAquryfl5xiv4c4oKB7cZoW+HtXbSvw8Yb2v FaG2ZtiPKrjhSuAsWVOVv67eNABMT0Te7JpyBAN3Prr0guYV0cqx2y+JSyADQztxUi/Bpi26gRq e5KHD7XImb0ebZw5FC2Ug+d+lw6NLuvUJ2SO1D6NSoDke3sEOcj8ArXaLLwks/ X-Google-Smtp-Source: AGHT+IFjoAyFjm2+kFm7KY2q3aB2HGmRZNUqm25Wo0zJ7cEcAB/9ey5BsxA253c/AteFX/omR4r+QQ== X-Received: by 2002:a05:600d:630a:b0:471:1b25:fa00 with SMTP id 5b1f17b1804b1-4711b25fd7cmr99064095e9.36.1761141717052; Wed, 22 Oct 2025 07:01:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Pierrick Bouvier , Paul Durrant , Stefano Stabellini , Anton Johansson , "Edgar E. Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/3] hw/xen: Build only once Date: Wed, 22 Oct 2025 16:01:13 +0200 Message-ID: <20251022140114.72372-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251022140114.72372-1-philmd@linaro.org> References: <20251022140114.72372-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761141741821158500 Now than hw/xen/ files don't use any target-specific code, we can build all file units once, removing the need for the xen_specific_ss[] source set. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Edgar E. Iglesias Reviewed-by: Pierrick Bouvier --- hw/xen/meson.build | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/xen/meson.build b/hw/xen/meson.build index a1850e76988..dcd2b7e1df3 100644 --- a/hw/xen/meson.build +++ b/hw/xen/meson.build @@ -7,21 +7,16 @@ system_ss.add(when: ['CONFIG_XEN_BUS'], if_true: files( 'xen_pvdev.c', )) =20 -system_ss.add(when: ['CONFIG_XEN', xen], if_true: files( - 'xen-operations.c', -), -if_false: files( - 'xen_stubs.c', -)) - -xen_specific_ss =3D ss.source_set() -xen_specific_ss.add(files( - 'xen-mapcache.c', +xen_common_ss =3D ss.source_set() +xen_common_ss.add(files( 'xen-hvm-common.c', + 'xen-mapcache.c', + 'xen-operations.c', 'xen-pvh-common.c', )) + if have_xen_pci_passthrough - xen_specific_ss.add(files( + xen_common_ss.add(files( 'xen-host-pci-device.c', 'xen_pt.c', 'xen_pt_config_init.c', @@ -30,7 +25,8 @@ if have_xen_pci_passthrough 'xen_pt_msi.c', )) else - xen_specific_ss.add(files('xen_pt_stub.c')) + xen_common_ss.add(files('xen_pt_stub.c')) endif =20 -specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss) +system_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_common_ss) +system_ss.add(when: ['CONFIG_XEN', xen], if_false: files('xen_stubs.c')) --=20 2.51.0