From nobody Thu Oct 30 19:06:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1760536101; cv=pass; d=zohomail.com; s=zohoarc; b=cYSKNSEFMEjQjiR8EeR7PwJJ7Bh2mHkN3yptCYKGLI1tlO+1HujIks2JbJ0Iz8wZYCqGoqSnfnRcl+3+lMPR4C+MO2efLjUHbf4xVTM6cyxrcw4OHx9LsU4udcUYa5SG7e4NftZivRJ6aBW/BvAfSuWs8aVYwqhjZfzL9GfyQH4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760536101; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9jAaEkbPMClbdXrDp068D9KRbyTHRkgW/ifsonbGhPQ=; b=Hti62iOvnq7ujEWA39tfCEsEVIhxj2OBexIFLV8/WLGE9YF95Oo1W53+5fb1CPD4DHKmx4D9AA9Bf9Yw+O1/+/aMrpqRc/BsAZzEqUyHKO8UMODIPwNw/1v4CCaF+km62lLwQhTwa89QuE+fHZbR/cMglanrcekc7sFw/ccTrYw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760536101924406.11198249068957; Wed, 15 Oct 2025 06:48:21 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1143608.1477270 (Exim 4.92) (envelope-from ) id 1v91rF-0002AX-Iy; Wed, 15 Oct 2025 13:48:01 +0000 Received: by outflank-mailman (output) from mailman id 1143608.1477270; Wed, 15 Oct 2025 13:48:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rF-0002AQ-FP; Wed, 15 Oct 2025 13:48:01 +0000 Received: by outflank-mailman (input) for mailman id 1143608; Wed, 15 Oct 2025 13:48:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rE-0002AF-16 for xen-devel@lists.xenproject.org; Wed, 15 Oct 2025 13:48:00 +0000 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazlp17011000f.outbound.protection.outlook.com [2a01:111:f403:c100::f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8efe10dc-a9cd-11f0-9d15-b5c5bf9af7f9; Wed, 15 Oct 2025 15:47:58 +0200 (CEST) Received: from DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) by CH2PR03MB5176.namprd03.prod.outlook.com (2603:10b6:610:97::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.11; Wed, 15 Oct 2025 13:47:55 +0000 Received: from DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2]) by DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2%5]) with mapi id 15.20.9228.009; Wed, 15 Oct 2025 13:47:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8efe10dc-a9cd-11f0-9d15-b5c5bf9af7f9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sfYde3y3riSFT1G65ZibNoaItQWojvQpN6IKAa9LjCMlNiCvwT+td5mgXrp9z1pybxDvUocMHJmy6wgoGlGjMenw0MMQ3PPvCM9UQNDzZGKFVvoY6Trd26Pku4HxwuPCtyVAYpp/YCF692UgMFBOkMisnbJ+Cwv+KQ0LYltDGweDXBck1Jzl2du4ejkyQhVbLtpQh04QHxz/ru6hzicKcqAhyu+Pum0psflFHl4ZzVGVn8hXcY4AYVxpiBkDpZoSCtNoeOs46iXTjQfDeJ9GFdO2bSnMKRuQSwlIG/9eMpxu+L1Qj5OaI55Yfznfz8MwwheNeXqr7GyGN98XKNcsBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9jAaEkbPMClbdXrDp068D9KRbyTHRkgW/ifsonbGhPQ=; b=bzm3zW3Hh65jYYCKm/FzFnReb3A74SjmC1gYba/XrsPIgUVL9N0ZGIp2KBuguatyFIaa6HJ2uQYKXn+35woXrx14hf/ijNUa9BH5dQa846sPTIVoxxcT/xOmNozd0ixPjliRovA0qsLiU3RLLG8ODYTczlSTvWp/zont7KhScYMhJeTLtrFP36x6KtasPZQIxpoU6QWjGBh1WvRezD5MYiVSbhfXvONgWafxzCYXsYqUufwznrV1nM9TWCOG6X950yjg+3j+BRVnWJS/OkerKcw4V5kyYEgOSh4oGZAgYwXmu2cC94vsnr3vJd5caoknyI8LPyVrAiuZzlqPAv2jVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9jAaEkbPMClbdXrDp068D9KRbyTHRkgW/ifsonbGhPQ=; b=R0jrf2QVpipJsOEpUf/huSNwwzwWO6DcMu/xVMZ5Jszluur5GKep7tjZGohjKz6xl9iUY5Mcny6zatlCnLTKmmXMcy+NC+oFRq7moTOQjra+2saAW4GKYA8sr3s01k0jHSio5LnzfC9YF/bRQ65oEYWp/CCXuIi9Kn4+HGL/J0o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: oleksii.kurochko@gmail.com, Roger Pau Monne , Anthony PERARD , Juergen Gross Subject: [PATCH for-4.21 1/6] tools/{lib,}xl: fix usage of error return from json_tokener_parse_verbose() Date: Wed, 15 Oct 2025 15:40:38 +0200 Message-ID: <20251015134043.72316-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251015134043.72316-1-roger.pau@citrix.com> References: <20251015134043.72316-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA2P292CA0028.ESPP292.PROD.OUTLOOK.COM (2603:10a6:250::15) To DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR03MB5227:EE_|CH2PR03MB5176:EE_ X-MS-Office365-Filtering-Correlation-Id: 5fdaecdc-0590-4a66-f4ba-08de0bf17168 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MlpHQ3JleXVUNGdmRFcrOFB2YitiOEVKdTBnQUx0L0ZuaDl6TzBLZ211c2dE?= =?utf-8?B?ZGoyRGFwVkNrZndpbmE5c0UzYW1iWlNLSld3UEIyT3BEY2VTQ1ppaFhieUMw?= =?utf-8?B?SkxVcFNVL3pXeVUxQ2ovU1dvb3VsWlh2QXZPRmhJUEFJYkErUjdFS0liREg5?= =?utf-8?B?SEE0a3N5TVZkem56L1hWVTcwYXErOEZvZnlrN0xOcCthdHBZN3V4MTFpZ1Zs?= =?utf-8?B?bUs5aXVWRmNQNUFtVUxEdjV1dnRYWFR6V3VDVVJwVmw2OGpIOHhManJxaEhy?= =?utf-8?B?cC9CdUVZNGl2THFhNVRTZWczS1prMm90SmpFVDRBbE1RQ1RyZGxnT3RWbVZm?= =?utf-8?B?VGVINmQvVCtaMXduMWR3Uks5SGszZlJSaFdOUnBMU0E4SUVqUEcwb0w3Tjc2?= =?utf-8?B?aGFRUHJZS1dPTlI2ZG9TTkVzdys4d2RwbUhEQkhqZ1RYMXpFOFVXM3ZXN1NF?= =?utf-8?B?UUZxQmNYTkwyNkwyL2VXcmdEVGRlbDJFdnNmcjQram9NWXlOM2w0clA2SGFZ?= =?utf-8?B?SjRvRzFHeFlXWTN4Ull5ZDdLSFVvL2IweC9NdVZuOVZFYXZuSndnR0EzSTlI?= =?utf-8?B?bnprWDB4cWpuUjJqMlgzRWJZZ0NIMm5MeGxDOExlYUpaS1A3eGlEaXBDamVx?= =?utf-8?B?SWpxMnY4R3RkM3Zrb0R4TE1yY3JtbXpuUTJHMDdMZWxDdGJTbnNDWmNHYTFU?= =?utf-8?B?Z2RBL2FHaUtoU0p0Y1N3WlBudE5oVWdIU3A3TUtJWkxKNi8zSVEyZDZoRnZE?= =?utf-8?B?aFM2eTQyM2dFOFc0VE1vMlI3NDUvMlhHOXJmVDF0d1R6S25VSC9BelZjSTRi?= =?utf-8?B?WUtLSElaRHdyZHdBK1FGcmViR1ZaNmtzQndFRjFrSHVubFg4L2VlQi9iWDR0?= =?utf-8?B?NktHZkJQUHlYTWZTbTFCWm9oT3hRaDVZSGJnQ01Wakw3MmtBSnNlQnJNdk9a?= =?utf-8?B?YklYSHJnY1ZOQkQ4bWhValIweWF0d3VOWjhNeWdnVzFjakprdjRESVZyS2ZN?= =?utf-8?B?SWowZnAzaVlPQUdiVlU1NXpMSy8vb3lJeEs3MlRUQXRzd1RHOTZxR001R0ZQ?= =?utf-8?B?Sm5wR3ExMklNNVd3d21CZXRSbm91NWpEWCs3UVFuVDczRml3SWhnWXFGN2pT?= =?utf-8?B?ZWRCaGJONjNxY3dSLzBnK3kxYzdIVDVCQWJ5YmxidDB1WlQ5TTVNNDNjZTdM?= =?utf-8?B?V2lCcGM5OUFvTGlIdjZkbVY3a1NxU3V3Q2hGeTRoT2c2ZEV5V2lIbU9wNldO?= =?utf-8?B?RmcveHZURGV1QWh4QWtrUm96VHpkUTU0YkQwWHB4a0MvOEY1Z3BtZFJZUHVG?= =?utf-8?B?QzcyQjhtdGJTMDJnTW94Yk5RNkRqN3Ftb2hoRlFmUlByVGVOSmduOEU0RFFV?= =?utf-8?B?UHZ4Y0pVbHhOa0RobDQwT2xITERUOUVuS0VWME91SXd1OHlHK25tVW5FNDl2?= =?utf-8?B?R1FyZHVjKzBxaVhhQTlxdlRTMnlOdkw2SFVmWk9mN1VmaGo2cm1UUnlrYkFh?= =?utf-8?B?cXRvUm11dlhRTUVCbzQ4TEE3anVOSFIram9JUFJNWGdqc0VXSm5kbjZkekpm?= =?utf-8?B?VEVIZ1dKMTRseW9ZT0pBb3hWTGtCVGhWU3N0Ym9WM0t1SzFFTGtjV2xGRXhy?= =?utf-8?B?bVhnbndSVnhFeUx0cHhJemh3VlJHL2gwSFJhMElBOFNKQUtqMmxhb1NycEtS?= =?utf-8?B?KzUrTy9LWUtUTEZyU091V3VZV1V3SmdEenRiT2s1VCtxVnF1MHVJQkNZRWNR?= =?utf-8?B?Ty9GVU41enlSSjgyeE5EdzFpWTJNUW5ISjVFTUg3UmRvZmtISFdXTEZYNFY2?= =?utf-8?B?LzRadkhab1Q0Zmt6SEM1aWJRQ0RvUlI4ZG5Ta2xkRDdCSndZaFYrNG1ZdjZJ?= =?utf-8?B?VHhBNTlicnV2NWxDUHVwNWw5NXFkS0xTUWtmdWFONzNUUkhwUm0wL21iMFh3?= =?utf-8?Q?T3fXqUgKxDGY0FBo2Mg3MLJwHg3MqV5T?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5227.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVN1UmpoRHpmbUkvUGRUVVpZcmRHV2VCS3ZXdTlJODM5clpRRTlJRGRSTGQ3?= =?utf-8?B?SXdMWGxwbUdRRUN3amc1MiswdEZPOGU2V3JaODVIcGUzaHFkcHA3dzJIZDFR?= =?utf-8?B?VjFTY3E5ZFV1TS91aU5tQjEzd0VFZmxjZTF4ZURLTzJUSWRuOFJVNEVndVp3?= =?utf-8?B?THRXUk9sQ3JFNC9oeXFRM0xubGtpb3FDQTljbEdWOWVHaHlVSmw1TEphTDB4?= =?utf-8?B?TnBIVE5qaHhkdFhETC9Ic3gremtBOS9CY2VXSFloekVvL0N2UkVRZUNKT0Mw?= =?utf-8?B?NUlncjNBbUlJcmdaTnFCL28xWHFVQ2xFRjJETGFMZHdSTVBnbTB5Ujg5R0tY?= =?utf-8?B?VGRHVnM1OG1reUtLOENmQXJIUXJ2S04relc3MXVJSDY3VDQrVmhQRlh0VE1z?= =?utf-8?B?VzU3Q2JXbHNkR3FaUUNWTTZPSEN3MjNyWUlidStWQkV3SUJCaS9HMjB1RXkz?= =?utf-8?B?RnhNVzA2RkZWN0VVUXpkb1BLK0VQZEVqSmJaOEJDRlNjRHFkQWFCdDJoREhF?= =?utf-8?B?dnpMOVpxeGd4dENQc1Q5UWl1cEVWWjE2bG1tUjJLZ2V6R0gwQTlVdGxCQWJn?= =?utf-8?B?Z3owZFdkcmVWZ3htMEVpWjJNeGlDVmZVdVJGK09FSEJjV3pTcFNGM1JrS2VB?= =?utf-8?B?cGZlOU1uZ1JvVFpHWk5URmFKVFhUUzg1bW5Jc0pGN1hsdFExMnEvVkg3RGRV?= =?utf-8?B?dWEzVFUzTHZWQmtVU3V5d1dYLzB6QWozN0hxOHdIVmlEVUdzVFFLWjdrUFpD?= =?utf-8?B?Y1ZacDhEOGY4YVBtS2psRWsrT1lMMElFK2NTL3RaSnNWZmJ6eWkzVFljRFIr?= =?utf-8?B?YzEzMXl6a0Q1cmNJOXkvOGZPQVFQR0FROGhSY20wZmJ4dGVNL3pZRXNMczBi?= =?utf-8?B?UkpIYllYWDIxU3doVzlzUnh4alc2KzFPSE03YTFabUNsbXJWT3F6bS9IM0Ra?= =?utf-8?B?dm5tb1hpMkdnZjQxTEU0ZWlheVJudkhMOXlEVkRzTndJWHpjR0UrWVYxSlYr?= =?utf-8?B?clEvWTNBMk43WWRlOWl1OEludFdBczhtdndrakRHQmdtdWtXemtFaXMxVTlF?= =?utf-8?B?a0t6eGRJcWJ5dzRkaENleXQ0M1lqdDVHWS9kY05VOXVPb1RKWTVvNG5EdTF3?= =?utf-8?B?bW9URlJ3cEZGQ2NzVUZaT0Y5UEIyM3BCV050K2drRjN2OFlsS1RXK285OTZt?= =?utf-8?B?YnFZVDZoYlU5UU5SdklDK2ttTXFYdGFVREEwMzJqRklNNHFjVjRyY2VPQzdx?= =?utf-8?B?NXNFSC9zZktGZThNbmJYTVlkNUZjNkhmaWlIejd1WkhuNWgzdExaMGN1d2dx?= =?utf-8?B?U090akErTUMxRjA3b2c1Uy9haUh3ZjRoUjM4N1RHYVpjSkc5L0MrYVp5Z1Vi?= =?utf-8?B?ZXRPanU2N3RtWDdhNmNScStXYjFQL0ZHWHh5a25OWHNaNkNOcXdIMTBFaDg1?= =?utf-8?B?WHlISGtaVVdxTi8rWVRvSTFOZ1FYRkhZQ1VGWTI1dWdGNFMxUHg0d05TY1Q0?= =?utf-8?B?bENqTjFhMkxuR2RsTXBSRTlhNmFLNUpNbmtCRVJldFEzdWxPR3BQQkFLcVRm?= =?utf-8?B?cEdVVWJrckxtSW5JTno5c0hGS1M1ZFcwYlFqSTJVaU5ONW9rb1h5ME9hZ2ZX?= =?utf-8?B?Wk1UdDdvSHY0ME5CbzZudVYwcUZmQVBsTW4vTWdrTFR3Nk8xNkc5ZGloS0E0?= =?utf-8?B?SUczMWZyR2Y2Wm5aZWNjcHV5OVgxbXE4MHZRcWhmdGwvc2N3UVhvUFpOUE5Q?= =?utf-8?B?UnQ4eGE0ZU1IYkQyWDFxSWZNcEcvUE5XZVZkYTFudi9DQ3d2Mnk2YzlHSVB6?= =?utf-8?B?akdBVFEwOXVSQTRHSm9sQzBCaGMvajNUOXRmaktSTklDaEZ3WDVJcmE5bm9R?= =?utf-8?B?bHh6dmNxVXBUcnRKVCs3WC9YR0VRenhkaWduNUVjWTlFUmVlTW5SL2FzVFBG?= =?utf-8?B?ekh1Q0dFbEhENFYzL1YvRzlWS2tBZGEydVVsb2tIdzU3eU8yUTBGTUlEbTFw?= =?utf-8?B?bm5CYWcrVHhtbTlKNVJ3ZXRnRGhRcVVrYlBzVXc3bDZkaklGZ0dKZExNdUZt?= =?utf-8?B?L0d6Z1J0QUxMUWRPVUhHa3NGNnR3UnJvaFlPTytBL0N4ZnNVSnJnWklzMHVx?= =?utf-8?Q?aPtA4QYBjEkx6Rt6aKc/cc0T8?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fdaecdc-0590-4a66-f4ba-08de0bf17168 X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5227.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2025 13:47:55.5420 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 71oJRwGfHZVqcm02hv/aRII8EbB82I+Ryx2oXlg+cmzt/Uw71tUEsr9DB9IpdS79UtA3csoe1gg+QLAznK4zRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5176 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1760536103882158500 It's possible for json_tokener_parse_verbose() to return NULL and leave the error parameter unset. Initialize the error token to success, and only print it if the function has actually set it to a value different than success. Reported by XenServer internal Coverity instance. Fixes: 7e95dab9eb63 ("libxl: Convert libxl__json_parse() to use json-c") Fixes: f6c6f2679d49 ("libxl: Convert libxl__object_to_json() to json-c") Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Andrew Cooper --- tools/libs/light/libxl_json.c | 6 ++++-- tools/xl/xl_info.c | 5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_json.c b/tools/libs/light/libxl_json.c index c76ae9f64a9d..a9e06b06932d 100644 --- a/tools/libs/light/libxl_json.c +++ b/tools/libs/light/libxl_json.c @@ -1366,11 +1366,13 @@ libxl__json_object *libxl__json_parse(libxl__gc *gc= , const char *s) libxl__json_object *o =3D NULL; #ifdef USE_LIBJSONC_PARSER json_object *jso; - enum json_tokener_error error; + enum json_tokener_error error =3D json_tokener_success; =20 jso =3D json_tokener_parse_verbose(s, &error); if (!jso) { - LOG(ERROR, "json-c parse error: %s", json_tokener_error_desc(error= )); + LOG(ERROR, "json-c parse error: %s", + error !=3D json_tokener_success ? json_tokener_error_desc(erro= r) + : "unspecified error"); goto out; } #endif diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 80a3b25aac81..777ff2c64294 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -67,7 +67,7 @@ static int printf_info_one_json(json_object **jso_r, int = domid, { json_object *jso =3D NULL; json_object *jso_config =3D NULL; - enum json_tokener_error error; + enum json_tokener_error error =3D json_tokener_success; char *s =3D NULL; int r =3D EXIT_FAILURE; =20 @@ -75,7 +75,8 @@ static int printf_info_one_json(json_object **jso_r, int = domid, jso_config =3D json_tokener_parse_verbose(s, &error); if (!jso_config) { fprintf(stderr, "fail to parse JSON from libxl_domain_config_to_js= on(): %s\n", - json_tokener_error_desc(error)); + error !=3D json_tokener_success ? json_tokener_error_desc(= error) + : "unspecified error"); goto out; } =20 --=20 2.51.0 From nobody Thu Oct 30 19:06:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1760536102; cv=pass; d=zohomail.com; s=zohoarc; b=XBRIyj7TjrDd3nLdRJmgyfrKu6IliwMoGc9l/11rI+ggRN0FsLKw/AWwV7iVC9GCLEJhiND46Nkp6CgguciBq7NZBbqUgXCYBptzUoWK1nMW9345buwFDmrGS4aHaV0mwcCUiXgrIi+DytTyH/kl0rtMoHoy48ooeJgENGa9LYU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760536102; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=14kYZ37eR+zBgiRMbpoPo4RJmcTjOY4j9c/vWRzOLaQ=; b=IfXQs/ETk2gFP2K6GbwkdOO1JdEH4T4+IFjB3RmreB2mOBUdPPgkgyeUsP8aQ1ohAElmVBGtg3e6ScD3GlH2fwr4U25DnrNT8MqnmhnQpSylQQYaHZiqSyPhSHpZW0aAlpi6mVPnboeYELhcAHaN7IMMxfkdq/jqlu6p6NVSBLw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 176053610297615.807899530765553; Wed, 15 Oct 2025 06:48:22 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1143610.1477290 (Exim 4.92) (envelope-from ) id 1v91rI-0002cF-7w; Wed, 15 Oct 2025 13:48:04 +0000 Received: by outflank-mailman (output) from mailman id 1143610.1477290; Wed, 15 Oct 2025 13:48:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rI-0002c0-3q; Wed, 15 Oct 2025 13:48:04 +0000 Received: by outflank-mailman (input) for mailman id 1143610; Wed, 15 Oct 2025 13:48:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rG-0002AF-N4 for xen-devel@lists.xenproject.org; Wed, 15 Oct 2025 13:48:02 +0000 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azlp170100001.outbound.protection.outlook.com [2a01:111:f403:c110::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 910a3c23-a9cd-11f0-9d15-b5c5bf9af7f9; Wed, 15 Oct 2025 15:48:02 +0200 (CEST) Received: from DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) by CH2PR03MB5176.namprd03.prod.outlook.com (2603:10b6:610:97::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.11; Wed, 15 Oct 2025 13:47:59 +0000 Received: from DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2]) by DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2%5]) with mapi id 15.20.9228.009; Wed, 15 Oct 2025 13:47:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 910a3c23-a9cd-11f0-9d15-b5c5bf9af7f9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D0BkMybkNUXFq5Ay8rwziW+NuXZuVpYfUgNaxhHlInYZhoTzv4wM5cHBEmnhFk+USr3GkixwddErAdMVHBzOqyDTzDJwErY7PoKJMqtI5+kuBI5d5BPgh40ThotC7y3sj+kqIX3HrjwdVoL98b5x3bmDEAuOP/eONJH+UEw7Wpg0T6BYrC4PfbFiJv2bXKfGU1M1vdJFXnRQdnaWWpzxlTpp4bhdJaUGwvzWfR7oQJ2yIt585HF7Jw5hV3jSTFZkj9b3FthukXX0Y5qmyox86OoNmdjErFIuqeJYhUAIpjZieNiPM7g4irBn+f4EZKdQS88yC4Bkcy+dfPv2dMEK/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=14kYZ37eR+zBgiRMbpoPo4RJmcTjOY4j9c/vWRzOLaQ=; b=aqkW27WHo3HYYjRVLSgXwv+7Gt99gyXmV7Y6uFW0qrU/QXGdQFtcZTKpTCny0WSIDmPQmuCKM+ivHUi/EHewwSu2mGmqC2VfHfva38Ni9CbumbcQL5fL7aI411dsqtJQcRDVrv/6QGayxmXm3OwIy4MkYrIaclWz+lm2aCz8EzG5FjPW6oOKOGsFPzDpKur1AKF3S5FSCp8AofLt+X3RHR3YvmcZCTUiC/aaKQnCHM8rdtgRa3hASdjwxmca/17Kdw04FJjCJXz2CePF7Fp/tMDsFT9/sahfsUUQRp3xTLiY60AsBtKhtnYzixHj6xoeknW4qBD87LoVJaWglvTITQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=14kYZ37eR+zBgiRMbpoPo4RJmcTjOY4j9c/vWRzOLaQ=; b=cN35uQB9trHvUYzFZPhN/hY3ifgohxyOP+vofVBXv5xEinc3ninIybIKelZr62MxzSVyvAcxafX0XAGDiVjK+YFjIk+H9vHmaOwyxhA9C2AlAb0e7Q0GFL3PWzBmZBW9YZzyfsWYmVCU3zjgPNVc4Dll3FuG6fRuPx0Zn7UMoeY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: oleksii.kurochko@gmail.com, Roger Pau Monne , Anthony PERARD , Juergen Gross Subject: [PATCH for-4.21 2/6] tools/libxl: avoid freeing stack rubble in libxl__json_object_to_json() Date: Wed, 15 Oct 2025 15:40:39 +0200 Message-ID: <20251015134043.72316-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251015134043.72316-1-roger.pau@citrix.com> References: <20251015134043.72316-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR3P189CA0049.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::24) To DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR03MB5227:EE_|CH2PR03MB5176:EE_ X-MS-Office365-Filtering-Correlation-Id: f294ec7c-1fb3-4c35-66f2-08de0bf1740e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z0FHU2lJcjk1OWl5MWovL3ZMNTU2bGtrbkQ1bWJVL1IzTGRoNnlZaWkzRHZO?= =?utf-8?B?Z0xGbDBBT3dVUGdkbnN5NG5KZmkwNk9JbEI5dDRtV091RlpjZzdxMTcrcVM3?= =?utf-8?B?S2xZKzFGVlRMNWFIaldXUy9JQ3doSnJ2aGcvR21FMm1KdEcweHRnRGxVdVgz?= =?utf-8?B?REZvTkhSZXQ5N21Qd2V0N1FuQkd6T2hJVndNVFFNc0RPcElkL2pFZmxPRm43?= =?utf-8?B?NnVrcWxXNzdIaDNBWnFaMTFwOUpMalM0d296UG93L3lXbzNCcFRYenMxREV0?= =?utf-8?B?TTVzbmhrK3h4RjR2b1BiRjcwd0pmZ3dJcncrVm9lTkdiVE1ESWlpOXA1MWpi?= =?utf-8?B?ZHJvbXdoc3E0UlExYk1lMTI2WUxOUEQ5Z0lWbXhPM0ZQVFhEUjZNV055dDIx?= =?utf-8?B?cWtwNHhTQkw3eWdMTmU4OWt5U0tHUEpDS0JnaHdHa09HY21xdE8wcVh5UUlM?= =?utf-8?B?b2sxbTlKaTFOc2lMOXZvSS9xSUpPZ2phOVZ4aEh2M21ndE5PeUJrS1d4bTIr?= =?utf-8?B?NVc3RVVJTXlaWEtQU28xUFdZY1VlbUttT3RLVGVwWk5CVm44NjZWRUh5Y1A5?= =?utf-8?B?TGRPeFoxVi9qbm56ZDlkY1kyWUJpaXVmUWV4NUN0aUlubVZNQ3lkVDlDajFo?= =?utf-8?B?SUw1VU1yakRodUNEQTBIOXBGeTNndlVSbUtKNnJkTkFVaVZCNlMvRmpxUWE5?= =?utf-8?B?U1lHWUpDNXdEVlAwOHp5dWk1Nk9KVEowZkQrMnpURWFkYjR0SEpMNEhjWTFx?= =?utf-8?B?cVVaMTVkeFlDaTZJZkF3TnJqSEJLNjRoSlNJTHNkRlVhdW9tZURCYitHTWRk?= =?utf-8?B?dG9MR1QvN2t4a2puQWxNWVFJVGdPODJ4U0F5Smp6eGJnOVBUam8zc1UrWU9Q?= =?utf-8?B?anlkUE9JalhNRnNnZ3FjRjlUQ3hQdE1ZdlN6QnlPd2d5QzI3aTNNaTdQb2x4?= =?utf-8?B?N2Y1U3VGa1praFhHc3dsTmVieWhLOEJQcEd2a3FYVFZ5VGY0dkVsb1prYndi?= =?utf-8?B?Unpyb0pSK05RZmhtd3h2eUdSTnFFUnIydlMvMzRTRSt0VkVLVFdWM3F0QjBk?= =?utf-8?B?YjBqZGVKdGhtMm5hall2eDNtR1VCT2JUZDF3cGpKYUVWVmFvK0hFZWZBcG5J?= =?utf-8?B?MjNhODJkUDRzVHFyMWcxRGtHN1Y4NUlQRzVzRGpGNi9KTFBqMTRFNmJGM2JI?= =?utf-8?B?d3QwalZHdEZEQU1RY0dhbkQ0eVJ1MXNxVGNqdGxaZkdNdnJiZ0h5Yml4UUEv?= =?utf-8?B?TlkxekFVWlVvNC93eUlzY0plSVpqTHlzekxxVnpFUTBaanlqcE13Y1pPaStF?= =?utf-8?B?MTFkQ01jbXhHRG5FQjVzQnQzSElkS0ZPem9qWlRMVHRkTXNsd0NXOS92RUJ1?= =?utf-8?B?bGxsME14MFc5VVluTjhYSGtsZFpHTElOaXVPazdBQUx4cFhEZHhDZTNUYzlV?= =?utf-8?B?bExzNFZCUVdDUVJVSkNKSW8vWUxTc3JrUUNHK2NHVGFIT2R1WC9rVng4UGU2?= =?utf-8?B?RkpvZ1ZDV2RNejQ1Y0hNckVTeXcrY0JPZ0NCL3lDSXY2djhyYXFkR1VYalNr?= =?utf-8?B?M1hGcG1GRi9ZL05MV0ltZG9RVGNwVEl5M2FJV1laUUpnMG1jNFVLMS9RNU9a?= =?utf-8?B?OWpGSlIrRWFhK0N2L3pUZWRhK0xhSmhjbG5CL0ZXSnozbVdVckVsV1NaSFl0?= =?utf-8?B?SE02TGNUTXRTalUzQlV1RlY5dTIzaUlEdUcrQlJCaHJzbytNMlo3SGY3VW9Y?= =?utf-8?B?WEZpbDNyWW1sUy8vbzl6OEVVRkovL01yQmlDU0FBRUFveEhCTVRTck4vQndr?= =?utf-8?B?dFVEbUFYMUlHMm9NVnR2dzdOWFg2TGVIemx2eDNDR09ZY1BzbUIzTHZoN2tV?= =?utf-8?B?RGVTYUdTeWtsT3JvQTFGbUw0R3NCbGFuYmJkcWlGblVyR2tKSjU2YXZ0U1FI?= =?utf-8?Q?8DmPNsrMR41mfm8Lc4OmnSCiOd2tKkqO?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5227.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGE1cjdMTzJuUXNHYjlkMUM4T1p6cVFKYjVleHFvSVExRGs0V21Wa09kTkZi?= =?utf-8?B?MnF6MTNCUFFHSVlkZEZSby9oQnhwRDdkaEpCbFBhN0d0aFpHMGRyWFlyc3pz?= =?utf-8?B?TkpyajJ2TCtlZFhMbFZRV0pRcisvTCtrWERHLzduUGVYRURLOEhMWFlJMDdX?= =?utf-8?B?VlVLRHkzSEdwL0RiMjRJcDdJRVR2bjZ4dkhGak5DUWRQNUhsQ2lXeklkamtm?= =?utf-8?B?Mm9EWkg5MFl5VDU3YldXNzZnM3FaeS80dnFrZWVFaENjK3YrdkFuSW84VElv?= =?utf-8?B?OEthMTJkSXk4dEE3OWJoWXZnTHhKMkw4TnpWbnBOcmhyN2VrTjRKTHBiVFBz?= =?utf-8?B?R3QrTEhJeTRQb3RONCs1dFQ1V3VlNVI2cHlVYUxBSFlGNHY3M3YwUE1FT0Nn?= =?utf-8?B?WllNWWNWSlR3RjJmQWJWNzBKVEtzUnpZY3ZNYTZOMTNUdjR4cUFUdTlJbUxq?= =?utf-8?B?aGlZNmhJSWU0MXA4QUpXNWNZWXU2Z25MVitrS252cjZrRkJVNjIveWJrZ1pu?= =?utf-8?B?K2FhS1p1eTVjWFoxVEltQVNja1RWQi9GdE1lT3UvbitCQ0d2OWovb3pYbU5P?= =?utf-8?B?TFRSWEZ3N2hlbXVVQ0VMcEV3ZEF5ZDZHZVFjODZDSks2dkEwcFRWam9NcXpm?= =?utf-8?B?c0NvdVJPMnIwNFh5WTRQZE1EQlZnQzhnT1hrOVpMeGExTCtPL1NFRDhFK3B1?= =?utf-8?B?bndCMkE0R0dnZ2pPaXhJWEQ1em5rK3NIc1F4bEg3ZzloNlJsaWd1UGZ1aHZH?= =?utf-8?B?WUNCMkowbmFhSEZFbnhUUExFYm5IUlBWY3B4cnJYV1ZYVjJiQmxSSXlFVjkz?= =?utf-8?B?RThrWTN0czQ2b2xWZTIweXRIYmE4c0ptKzlSQVdMbnFTYm9tbXNZaVVNYUUw?= =?utf-8?B?OHR1OHNwZ0s0cW9GanZpZ2VRQjZwNGhMYndhMzhWTE00QVF0YkMzYUtrNEN5?= =?utf-8?B?Vll0TGh5OWRuYjZYOXRtVUZ4SlVVSE1ob1JTUml2eUZ1cUJNL2FjWEVIejlO?= =?utf-8?B?ZTRBbFZYbEJUS0dNOUVaODNzRWNXQ3Via0gvOTRFTlByamlIT1RoWmx1M3Bh?= =?utf-8?B?ZmxEWTV2OUpoRTVXNGt4OWp0WTNjeHQ5U0pramlmUlNkeVRxN2huM2ZycTZK?= =?utf-8?B?akxOMEplaHU0V2pVSzlTYWxYYlBOVitodHUvdEFOVkpiMmhidjZxNlFVQm5t?= =?utf-8?B?SDVIRVpXQ1UrWE45NDJ4SllxK0VtS0xFWWI2ZmU0cVNwUjdhN3R0SnMrMmdl?= =?utf-8?B?cmpNYVhOVG1HT1JXRlI4dE95WWlOUHp1ZUpJTkk5RkhDb0pnajF1T1MzYzVm?= =?utf-8?B?YmpRTFd3OUdFaC9HeHRaTCtMQkkzVnpoU2ZuUVM4SzRRM20xRzE0cTgzb1ps?= =?utf-8?B?emltaXVMdDRoL2d5ZG96enVicitzSHlCeG9IODVHLzRmNmV1WTNjZzlPNHF2?= =?utf-8?B?TkxrMkNFTG9zdmZaek1GQTJEUmF1S0ZkRE5Ld3FKbTBLVzJMSSsrWVlHYmtp?= =?utf-8?B?eFF3NzM1WlZFZ0FSVWNvL0VpdCtTeWE5cGZCUzZzNDFUdmgyTUlEU01uU3Er?= =?utf-8?B?d0pOdkJBL1pvaWRXZzBveXpZVnlZRExTcTJJcDFOYktQdjVWTmRRQXpueXpF?= =?utf-8?B?RmpBYk0ybWtpMXlZYVpScVNvbEpTTkUyWlNtNklFWGtwY3B3RGVMQUttMnBx?= =?utf-8?B?R3hzcXpQN3kveEFXaU9BQ25EcXc3VldnbFI4U2hIQ0MzTUdIaEFPNEFDQWdl?= =?utf-8?B?aE5RNlR0WVRSUVhGNTZxUTFLSXI5NWU5ZGVaM3RDR0VXUlJleFkzTm5la1Mw?= =?utf-8?B?ZmJkb0g0eDJDTlcxS3pWZ1M0NFU5L0FUQXFZVzZDaUcxa1VPT1RUMkpMb1VD?= =?utf-8?B?ZURCMU1iRnhDWjZHS3ZUVERFdW4yOWRETExVaVRkcndPdHdDQ01JR2R6WGlT?= =?utf-8?B?RUFIcDRxWmFmZ2lmTkE0dFMvVnIzdE1UZ1dFbUNreXZ6NWRjTUFuY2V3SDFj?= =?utf-8?B?YnVCU2RYcnFjdkFtcjJoSFJjRDNxUjdZMDlyY2tmT1ZYN1hDdG0wNm1Ddys2?= =?utf-8?B?RTZIdW8zSm9TWHAyRy8vczBpUmZFOFJiZzR2SUFleDNZNjM1eFFkZWFVSUQ2?= =?utf-8?Q?c2jCTCJj1cqkvPUZ4dsd/V813?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f294ec7c-1fb3-4c35-66f2-08de0bf1740e X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5227.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2025 13:47:59.8105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MEEFpEFO6K5gE5pHPzx3XU4hijwEIANqJzf6cbRkaFIP5faM+dLEvmIYBocMf4xCTKTBNvS0aZEW4bCVNJhKrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5176 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1760536103866158500 It's possible for libxl__json_object_to_json_object() to not set the passed jso_out parameter, hence initialize it in libxl__json_object_to_json() to avoid freeing an uninitialized pointer in case of failure. Reported by XenServer internal Coverity instance. Fixes: 75fa670e582c ("libxl: Convert libxl__json_object_to_json() to json_o= bject") Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Andrew Cooper Reviewed-by: Jason Andryuk --- tools/libs/light/libxl_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_json.c b/tools/libs/light/libxl_json.c index a9e06b06932d..b01d86363550 100644 --- a/tools/libs/light/libxl_json.c +++ b/tools/libs/light/libxl_json.c @@ -1533,7 +1533,7 @@ char *libxl__json_object_to_json(libxl__gc *gc, { #ifdef HAVE_LIBJSONC const char *buf; - json_object *root; + json_object *root =3D NULL; char *ret =3D NULL; int rc; =20 --=20 2.51.0 From nobody Thu Oct 30 19:06:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1760536109; cv=pass; d=zohomail.com; s=zohoarc; b=iHJDj4SGfcKUxhtEhgA67yZZejgbtZOXaduvtPt22bc3hyXESNkNj4PG80qyFwxBLInIgfMOIOB8sElrPbgpK1WlYVJSBoEijcoMyIIqj+VEKiYIV+kDDj6Dv8T389+ETrjoh5iSIwXEvO0zPfQiaYtjLhhuT8hroKDwtz5ncJc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760536109; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QrHEmkaFLq+k4yjYl1wqBoURqxns2g5ZgZNwc8LrECs=; b=enjwfBU5AilvzGY6lK4WA4PsjWekpUvikRMXPVk2yZcVjoJRAB8yGVtjqe6mDDA4HlpJh9oEZyrs42uif6XnkekYhRzK/lAGeKMffVpqqZEw5i69JMHjQiofA2dR7JtMr01Dk/KTQbn5kl/U5TyywON6EUeKO69B7RlYRbsfwZ4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760536109641448.15418458976455; Wed, 15 Oct 2025 06:48:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1143611.1477300 (Exim 4.92) (envelope-from ) id 1v91rL-0002sv-EF; Wed, 15 Oct 2025 13:48:07 +0000 Received: by outflank-mailman (output) from mailman id 1143611.1477300; Wed, 15 Oct 2025 13:48:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rL-0002sm-B7; Wed, 15 Oct 2025 13:48:07 +0000 Received: by outflank-mailman (input) for mailman id 1143611; Wed, 15 Oct 2025 13:48:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rJ-0002AF-ST for xen-devel@lists.xenproject.org; Wed, 15 Oct 2025 13:48:05 +0000 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazlp17011000f.outbound.protection.outlook.com [2a01:111:f403:c100::f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92f3372a-a9cd-11f0-9d15-b5c5bf9af7f9; Wed, 15 Oct 2025 15:48:05 +0200 (CEST) Received: from DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) by CH2PR03MB5176.namprd03.prod.outlook.com (2603:10b6:610:97::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.11; Wed, 15 Oct 2025 13:48:03 +0000 Received: from DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2]) by DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2%5]) with mapi id 15.20.9228.009; Wed, 15 Oct 2025 13:48:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92f3372a-a9cd-11f0-9d15-b5c5bf9af7f9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VBmCzwRurlPgCTPrxdWfalX9AMD34lhya/slimtvZMrPuC/kWApROARAPYDqg08kYQx11UakbCmd+DVng9P0byep24LA2tRWo30znPB4Gjrk0SSw43tXJhTylKwLlIyC3UGzH03frLre8/SnG5++k47Ef7dLmnPZFkNSTqa72ZRKb3qRk3DscHBDO2mS0ZClOnlzsRSzYcZv+Q5It95nntCiaLJrbgd8NUoOlgQ/ch5/0MAIwT0eFl44rVva/RtKLay15X5gBZMzO0eYr1W4fPLczgC4F7m4RYuCY9KKaSinOBzKb1JY4fr9RAuMBII9Up3Zni3Lx/c/d8oyL4unOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QrHEmkaFLq+k4yjYl1wqBoURqxns2g5ZgZNwc8LrECs=; b=jhvPlop+nWSTPsIqXRx835a6yBU9obCaRtge8y4xwe+e7TSz4gi9BIT2NtJPb4/2urdedp4edzlJjEBkafxxb5biEv/NOOpJxFqrRFt+mqJwRXbnUVudu2hnD0mYPus0kBFynMFcQyWlvudo0OK46c4mgYS0BmqP1ttJC/nuRBre5hydBGw9lKW/WoQc3AO6td/HYP3jLTEOGMVRdP3Aro12+4OB/hK9zp/S11uz708Z/WCCP0mHnADT/zzoW5DdyU5BNdy8xYyULdeU1XCeo4r6nmi/GVx9jf08iLRB31E6D0T6IVJfFSsUwfPsmavDLQuzUJyJWEEaxijlYMtWQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QrHEmkaFLq+k4yjYl1wqBoURqxns2g5ZgZNwc8LrECs=; b=xx2pg7hvwpeLErDd0Qb6Ox+m5LtFmN4tC3+d5e+KarGGX6XXKWoOoJuziyAjO5cABXmVw881PFJRjGZ9jJV1/J0BqqUAIa3L2Esg4sraBUg6imqRW2Tk2ihjDa1AIo16UsMXLJYrX+1+Xhiwhzkk7WEelAdRGOzXpCqFDUvhe2Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: oleksii.kurochko@gmail.com, Roger Pau Monne , Anthony PERARD Subject: [PATCH for-4.21 3/6] tools/xl: check return of json_object_object_add() Date: Wed, 15 Oct 2025 15:40:40 +0200 Message-ID: <20251015134043.72316-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251015134043.72316-1-roger.pau@citrix.com> References: <20251015134043.72316-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PA7P264CA0164.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:36c::7) To DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR03MB5227:EE_|CH2PR03MB5176:EE_ X-MS-Office365-Filtering-Correlation-Id: 458125ae-9bdd-46e9-206c-08de0bf17663 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UWkyZUpyY1kxbkxxSCtIRVBGQngxclUrU2lYcjFvQTJ2cXY1QUpBTy90SkVD?= =?utf-8?B?bzJSeXBEVVJlWEtmZS9WT3FISm1BY252bmN2Mk9RbFVLdnRUT3lqUE16Rmsr?= =?utf-8?B?aml2Y3BselNaWEEvczJEQ1BOQWlzM2tSelZGNnVkWk0wNHo3ZUl0dDFpU29r?= =?utf-8?B?Y1NuQi91eDk1V3hEdkpFdVgyY3RhYi9tSElDNGQxUnZxTm13V3g2RWM2RzBM?= =?utf-8?B?ZEg4NjVtOWlJTmRvSlhQZzhNTHVKQ1R0R3IyUEhDQTRCbVFtZDJjYWsrd28w?= =?utf-8?B?QkdOMTdUOW9YOGt6VHFTRWNRK1lYdkNUNThEQzU4THRSSm15T1lLekpqbWU2?= =?utf-8?B?cjVkZlYvS0NOOXEvTjBKaEJ2cldxMm4rUGtqU0owaWdwbFlSZkxKV3hTeW5K?= =?utf-8?B?VnE5NnhOQ1Z5UENoWENZRnBFeVlqMEJTYnJ2aDgzQXFVdHBEWno1N2Q5R1U1?= =?utf-8?B?cUthWVZuYzUyNXFLWkx2ZTg2ZldCckFneFdORGNrdmUwa2I0bm5WZm9RTjY0?= =?utf-8?B?ZFlMUWdJQzNkVk14azdoZG1Ld2EzK3ZvbldCTkxZUlRUVUVPOVYranZVVCs1?= =?utf-8?B?NkFNektyL3ZMWlVHU2UxWit6eSsxbThRTnBIYy9TT3d4U2gyTFhkSEtlSmgv?= =?utf-8?B?S3IyODZNM0pjdHhoVmVodURGTlJFN0hJT3RvM3ExeEFHUmRRWFBRbSt3QUgz?= =?utf-8?B?czVXekhhWlNQUzdBYVlReEdUNUFuSTZTUlRFejQxTW82Sjk2TE1UTTgzbFZz?= =?utf-8?B?aXlrZ1cwZGRxYi85NXRDTmdzMGt1UEhsdnVNYTI0RTducFh2V3hSaldUSGJJ?= =?utf-8?B?Y2pobVZQQ0d4aWRleVloNmxVdzFwcWxYaUNrMnJkWWlqckF1a1dMaWRtdkpt?= =?utf-8?B?MGFENUdTS3pLKy9NWXlXT2xQcGR3NTU3VlB5TGhMNjNZVWRnVUhZSlBEU0lN?= =?utf-8?B?UVZwaFNuQ3NBekxscnViS1NnQUVhemNybEoxN1cyR0hMOUdyNVJHaHlaK2FF?= =?utf-8?B?S25SRXNGRnRIZTc2dmpmOWNPRktNajFZOTVYYTNqRDJvbjYyUm9Lem1iWXcx?= =?utf-8?B?YmJ5aXRCTldVY05TdHQ5U1BXcXVSdnVMQzZyNlo0NGh0RkUzVDRSTGZUNm1J?= =?utf-8?B?LzlPNHJaamJ1dForQUJDT2EwNWZ2eURsQXIzN0h0aU8wTUdqTzNvbnkyOHZP?= =?utf-8?B?N2hWb1p0NUtJU0lSSjE4L1pMZU9DSHNMV3MzRE5CZnBobmJZOU1WbDJyQzZP?= =?utf-8?B?N29XdTNtQ1N6NWgrSmVkMHFGcXpGZ1hCNnFETUNta0RxTFZJbzdLNkd5RDZ5?= =?utf-8?B?RndiT09GMDgwSnc2RnU5YjN1RE91eThWUjJqUlBVOFBjbENmUFFJVWV3NnV3?= =?utf-8?B?VkdFK015RXhYbEFyKzExZnFxd0VwZktibDJKVlRCN2tYODNFQTNkK2lJV1hL?= =?utf-8?B?VjBrQTVkbDFQT1ZEOENNRXB5SmZpQVorMEhsL29rNXQrZmVWUFlvUFdXeVBW?= =?utf-8?B?bTFTK3R3VkZsd3VHeHZUTWFGUXdmS3Q4YWpiUHkyUnBZb01pRWdBK0JoUHg0?= =?utf-8?B?SUkwWTNrc00wZ2RRREZ6ZEg0L0RyeEFnQ28zZERtTUp4UzFRSUdjSmd3Rlcr?= =?utf-8?B?cHozcWd6NmhUeFhJWG1mU3E1cTZ6bldPUUw3eHZIVFRoMVFLcDVndTVmdnJ6?= =?utf-8?B?YnplNU8rZHlJOWlndUxrVmJ3d2pweTcyYXRITU5tRHd2eGFYNFJsbXM2N1k2?= =?utf-8?B?MDNXZ1NoNUVtT1lIWktldTBCb09FUnp0RHpYUDYyWVFZVlhHZVZtUjE2cUp3?= =?utf-8?B?eHhIaTk5aGVYaHcxNWV3cERVOTc3clBMcWhaMUU5R0tFaG4rWHJDYXgvVHpY?= =?utf-8?B?dU0vdzI2clBOM3VidFFnNTNNQmozQU5ZWW9QcG1kcnZ6SUZsYW4ycTIwTWNw?= =?utf-8?Q?PNJyAlFPu8YiU9OmY7h0mtkyTr1MWFJE?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5227.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXcyOHJydndPTmRCSlpqaVMyK0FZNm9JajVTSndqWVRIQnJpbll0enY3OFhL?= =?utf-8?B?V3FwOSszbERJL2pmRGg4VDBVOXBOc3RJMTJvL2RMVWxVQ2k2eUlRV1ZVVUgy?= =?utf-8?B?RnUzZExsK1doU0pyUEV2S01IbHJLQkFSZ1dvWnNnOFdzTHFxNW85QzdsTnZ4?= =?utf-8?B?SjJKQWt3VDBaRVNlMWlFbVQ1K01leDZJUmxqQVoyR0F3Q2t0a3R2d3VhWVhn?= =?utf-8?B?T3hoMmYzaHozeGpKbjNKck5NTGxhdStGUUhRT2JEZlFHL0pxVHRLc1UvN05v?= =?utf-8?B?NXpLMEtHUlYrU0w2Wk9WRFBESUdmWU02MEdrR3ZWUEVZWHdYSHlXdmhIUVFR?= =?utf-8?B?K0RTVjZ1WFRRSWg5WjVXaFk0T2o3Yk9YSXhIZVd5RHlLU0tUQVE2eGZxdlFH?= =?utf-8?B?OWlyT2NuYWxqNWMxVEk5cTVRMlNHMnIwakdxKzhaQVVpU3FsZ2RGUHVVSHho?= =?utf-8?B?Yy9DdUpyU2ZJZ2FXMHVXTzZ5V2VTdHZSalN6bnpEZTJab29pUnZKdVJPNzQz?= =?utf-8?B?VHVnTElZMDlCSVJ0aHhjVGcrSWtlR0tEQm5pSGtMM2UweGF0UUNNUTA4QmxT?= =?utf-8?B?VUUzaEoxUUYwMUZuYkQxZmJmNmlpTkZBTzg3S2RwSmFUc0l3V2I5UmRtOElI?= =?utf-8?B?K1hYalg3RUpTWXIwYXJETjJsM3J6SGYzUm80UitZSTNJbmp0cTV3Zk5Gb2wy?= =?utf-8?B?RDVBTitZcVk3SXNQNmQrUmZiUldETDlFWVJrdDZUcytaZ0Nvd0x5UnlISHND?= =?utf-8?B?Tk12ZkszWFBjeHpCZ0RLTXZPU2pCNnk2N1hZRVBpeDZESDlXL29ESGVCemVu?= =?utf-8?B?T3J3d2x5SEd0RlF4NWFnZUIwYWw2QUppbGlORzdiOW9zRTZMSFpHQld6R2Nu?= =?utf-8?B?dVpSNWhydjNNemdUaE4rRVlqVFRVWHhKc3NxUG9uanZYbFRRaWNLcTF5RldF?= =?utf-8?B?aTZPYnU1K041SFFvY2ZneXN4OFF6VERDTXBER1NrMXpLTXFkZXFERXZRcm40?= =?utf-8?B?aDBab3dNK21STUpqYzVQOGZWZDlhWngrdXZ5VjFIWFRZa1lWYmFsbytRREF3?= =?utf-8?B?VXBLZXVycS9JRTFUeWErRk9UaVhxL0QrZC9lRm0xcG1ya1J0aHVicGJ3UjN4?= =?utf-8?B?aG1RRVMrQTJYeFpLVjJ4Rnc3dzk0c0NrM1lRMk04YUhYWkprdDYzcXdxTW5X?= =?utf-8?B?ejByNkN1em10UnZPSnlKZkNkUmpTTnN3S0haWWw1T1BvaWVjWWgya3BSYldU?= =?utf-8?B?MFc4K2JMd2Erc05kS2xNM2REU0J4K3U1ampqZ3NVNm83WHF3cUxQb2MvY1J6?= =?utf-8?B?RFlKTnJTVFNqcnJ1c2h6dmxPOXFTb0dOM2d6NHFJRzVpUzlxOGxYK1VUWDZs?= =?utf-8?B?eGFpWnVTUUo3Y3AxdWdWbmtKbndNTzVOYkxMU01IUEZ5Ym85dTRGcWY4Y1NE?= =?utf-8?B?QkVQZjVLd0hYMGdmNW1Yb3k3UHRNMy8xQmFhMEl3SlJBajQ0QmRGRTJNOVFQ?= =?utf-8?B?cnNHZEJ6K3R1aitSWnRVVmpYU3ZzcklmQjFjTnRGeUJtQkFtMmNyYWgwK3U5?= =?utf-8?B?Q0R0eGsySHFWNFQ0RTVjMGc0VHpoVktaSjMrNFZaSEEyS2Q1MHFoWmdDdFFw?= =?utf-8?B?eDU5TFNoRjhaU2FvQmVBTzNsV0F6c2ZReEJBSXBncWRPU2RzSnFiL0o1TUk1?= =?utf-8?B?dzR3YmhBVENDd1NGd0FkV1M2MjYxaC8yRFQ1R2ZCWFNPVklseGFRRVZsRFMw?= =?utf-8?B?dmNxZ3BITTdaSXFpZWE4THRwcWpRK3Zudnd5cTZJM1FOblFoRlVkdXNnUzdG?= =?utf-8?B?UkJUSXlHcmRsc0NrMSt1NHFDWEQ1WHUxZ21qNVFpZmxHK3VjUVpSVUxxQlEx?= =?utf-8?B?U1RHSGk2Ukt5Q0oybSsxNUhCaEc5WjRmYnlydlU4aFVEaHpEV2tXZTZHTC9h?= =?utf-8?B?RGFmd1laQVFMYVR1bGNjanFPWE5LVi95SDBQR04rT2lTVWxsWVgxTDU3cHFC?= =?utf-8?B?cGpaMCsrNHBBVGpsNmZ1eG5QcnU5Tmhyd3NmQjY1b1lMaTg3MUVwNlczb0ZU?= =?utf-8?B?czRRTjU1TDhUMExWc1Q0eGRVaXU4ZDhPVUxSQUpIRDJvUnFLL0lEQ0QwbXlC?= =?utf-8?Q?ad0gtVIh3DvaDT4wgB5C4iaPX?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 458125ae-9bdd-46e9-206c-08de0bf17663 X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5227.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2025 13:48:03.6348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KNTU1AgjlsaT0kW3oIy5iOrb0NBE9ePDy7frys/a7zLMJdMrggZeuLsSrn2L1fcK9+Bx9zuAfuOCxDRDeZaGzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5176 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1760536112118158500 Check the return codes of json_object_object_add() calls in printf_info_one_json(). Reported by XenServer internal Coverity instance. Fixes: f6c6f2679d49 ("libxl: Convert libxl__object_to_json() to json-c") Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Andrew Cooper Reviewed-by: Jason Andryuk --- tools/xl/xl_info.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 777ff2c64294..2048669abbd4 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -69,7 +69,7 @@ static int printf_info_one_json(json_object **jso_r, int = domid, json_object *jso_config =3D NULL; enum json_tokener_error error =3D json_tokener_success; char *s =3D NULL; - int r =3D EXIT_FAILURE; + int r =3D EXIT_FAILURE, rc; =20 s =3D libxl_domain_config_to_json(ctx, d_config); jso_config =3D json_tokener_parse_verbose(s, &error); @@ -82,12 +82,17 @@ static int printf_info_one_json(json_object **jso_r, in= t domid, =20 jso =3D json_object_new_object(); if (domid !=3D -1) - json_object_object_add(jso, "domid", json_object_new_int(domid)); + rc =3D json_object_object_add(jso, "domid", json_object_new_int(do= mid)); else - json_object_object_add(jso, "domid", json_object_new_null()); + rc =3D json_object_object_add(jso, "domid", json_object_new_null()= ); + if (rc) + goto out; + =20 + rc =3D json_object_object_add(jso, "config", jso_config); + if (rc) + goto out; =20 - json_object_object_add(jso, "config", jso_config); jso_config =3D NULL; =20 *jso_r =3D jso; --=20 2.51.0 From nobody Thu Oct 30 19:06:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1760536104; cv=pass; d=zohomail.com; s=zohoarc; b=SqwN9p1FPkRGWFNataZg3MEZctii7MS2cys4TlDGoVTpNAqHDl/GuG9Tkn7gXhAucjqtc8BwRkyoYv48Cp+/DKryuq9L92LUbLT7RRitXKBQ0WbHwPig+CWYbEjioPp/atAkJMWOous8ilA++94rVEa0AJmKXfI0IQK9ilQE1eI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760536104; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tksbA7H2lMSaY3a5c9YU6hhiTitb1FxEL7gVnxGjj7U=; b=NmPySr0gQnFjGjiAYKzCnd9rApiNsV+GWV20ChNtjAlfJ48szvNp/S9KYkbzwHbHbcgqXCwzJfsJ/75PFc0V5Jmv/MND5Fj6KBHxlUkyCwdKovNI3vGI/jMLOsNbq5I/A98dt5V7aP9hYHcIWvh5HGwU2l1COlf2l/ZLT2LnFtY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760536104778736.9603738133754; Wed, 15 Oct 2025 06:48:24 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1143612.1477309 (Exim 4.92) (envelope-from ) id 1v91rO-0003Ax-Mx; Wed, 15 Oct 2025 13:48:10 +0000 Received: by outflank-mailman (output) from mailman id 1143612.1477309; Wed, 15 Oct 2025 13:48:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rO-0003Aq-KC; Wed, 15 Oct 2025 13:48:10 +0000 Received: by outflank-mailman (input) for mailman id 1143612; Wed, 15 Oct 2025 13:48:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rN-0002AF-Kk for xen-devel@lists.xenproject.org; Wed, 15 Oct 2025 13:48:09 +0000 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azlp170100001.outbound.protection.outlook.com [2a01:111:f403:c110::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9506f1f5-a9cd-11f0-9d15-b5c5bf9af7f9; Wed, 15 Oct 2025 15:48:09 +0200 (CEST) Received: from DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) by CH2PR03MB5176.namprd03.prod.outlook.com (2603:10b6:610:97::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.11; Wed, 15 Oct 2025 13:48:07 +0000 Received: from DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2]) by DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2%5]) with mapi id 15.20.9228.009; Wed, 15 Oct 2025 13:48:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9506f1f5-a9cd-11f0-9d15-b5c5bf9af7f9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ymluJR4PiKjiUuFSOS8w2TKltw1DCPsIRqfhWGrW3w0Ymx3XmLkh9FszY9MgXtPTPhUfU3xABLcjNiONfMUudlYEPSElUynNJbF9FAPoiQUteE9wyQYcGgtHLPGpA/OSqAFKlpih31T9kpIb/h+6BYuQb17SwXc8PbgD9GmSMaIBpVN3ctbw5N3sYywBF0lRj1dd7XifB1H118jZ+VfaBJCZbsHE0JIkgPCMUJhrfzQ42y9Hr0Th+Rcal+Jh30fpkcFAZrSgKpxKWV/SdhBfKdD2zqL1Ejau5XskeJ0FGYLtzhmu1zImAi0G4obiURzJjsO/Rm3T+jH49vbD3COECA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tksbA7H2lMSaY3a5c9YU6hhiTitb1FxEL7gVnxGjj7U=; b=WhkWOnsYXmtBxI8C/0PEuamRPbu7Wo/wKCUltRUmCofoDr/hOZMAKRqI9uGNtTipS0eqE+de3gx9j/7Jp/n8NI4IYBQLOiIIOO4VhgpLlAGVUVMg4k4xEBG3ArtLAaJ+vHvXevDwDeGDbd/9N3Y7enMUg5tdj77URhbe6ZTFd6twSYDAf0GUjc5CSkSe76klcCYBwTdOuka6oujYY2vMOvMfCrXb86qBulVoN+ZQrX8DjPixS6ocFX8a0fvX5swaHXszjG6E7H3UhYRJvwmuHUlwxU3gAYXxfAU7xalzI+aRFKikM5/MyeseLK2bkKtwlT9poNOw5+yCWofPQ7zQVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tksbA7H2lMSaY3a5c9YU6hhiTitb1FxEL7gVnxGjj7U=; b=y/+k9wt0aFAy4t/iSOmuSBJ/AjkVcKlnJFUBctbrChXdTN38N5Ta9lbMS4+3w7I+h8RJ/gI8LIZE4nM4TNnk1iRVjMGBJ02xTRC54t37QfGuasJ2hjRGBoNMqLuolkrScYs5q90zBVIcjvBlycWuI69u/URYYGMyq1w6h7UTMM0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: oleksii.kurochko@gmail.com, Roger Pau Monne , Anthony PERARD , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH for-4.21 4/6] tools/xl: check return value of printf_info_one_json() in list_domains_details() Date: Wed, 15 Oct 2025 15:40:41 +0200 Message-ID: <20251015134043.72316-5-roger.pau@citrix.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251015134043.72316-1-roger.pau@citrix.com> References: <20251015134043.72316-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PA7P264CA0105.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:348::19) To DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR03MB5227:EE_|CH2PR03MB5176:EE_ X-MS-Office365-Filtering-Correlation-Id: 8df38a21-8d59-47a7-8a40-08de0bf17893 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NmxjVVZZVkpIaDd1Vmh6VWJ1ZWRIQnZrbUV4ZDdrdDdGVmFOakhoQzdPcFht?= =?utf-8?B?MWxKWEg4THVUUnM4UTZXKzVlNTJySEZ6Y0tFNjZMTlBIMlZDVTVseGZ2Y3Yz?= =?utf-8?B?YU01b1pZM0JaTzNIdDdoRnNObjlrcndLd3NVVVpuM0xzdDRQZHZINkpHUnEx?= =?utf-8?B?NmU2Z2pteldOM0FXeE5WNk5DemdGUHl1RElCenBwbXFrU2xSdW95UXJnZFlu?= =?utf-8?B?VDNuQnNScVBET29EeGk4Q0lrOE1xbFBIUFdTU254UE8rNk45OWlMbnNaY25X?= =?utf-8?B?UnI1OEpWcUxRZ3FRZ0JEM0tZK1BhelNBVk5KSWFNem1wUE04NVNJVEN0Q3hF?= =?utf-8?B?Y3pBM3hFVTRIaXkrN3NnRUdMSmxQQnRCTFAycGFYVHgwT1FXVmZVK043TUhS?= =?utf-8?B?Y3ZSZEZ0WU4zNVBtcE9HT25KSmNyZGZTN2tQSkovY0t6NXg1a1dlWmRiUFhN?= =?utf-8?B?aEFydThka1lvRzEwdzB6TXppbW5MellYVTdyeXAzS3E1NUVndzZhUEc5UEZJ?= =?utf-8?B?MzMyYzh1OTgrSGV3NktaL0JPckJKdzNvR0UwSXYva0xqOGZYMUpiU3c0ZzFK?= =?utf-8?B?S3VsckNUNXVRYnl0VGkyUTRRMWpZdVZPSmI0YnhEaDFRdlp3UFprTlh1c29Y?= =?utf-8?B?R3NFd3BkS251WHFGenMzWHNQS3l6Rmc3WEpwUytPRHNIUWlWdEpGeDBiUms1?= =?utf-8?B?R3hJblRIM2pGbzQ5YjhEN0ZzNmx0UXNhU3h0QitST0plbWdEb0pkSGdoYk9P?= =?utf-8?B?NVZoRUw4ODhFRTBhMHBNM0ZGdGFRUXlzK3VUdzNVdkM3YWRJVG55aS9qdU5t?= =?utf-8?B?ekhPUnl2cWJROUthT2d0eTNvcFpRSGRJOU9vTVhNeGF6QTg3d1dNbm9zUHdm?= =?utf-8?B?WG5iMnBiTXVOcTlZRUpVTUt5Zm8rblNidWZpdWZVWERUa09pNm1zdWlxY0hh?= =?utf-8?B?ZDhYZklYT3NpNlp3VFRFWkh3OEQra1huVkdaNnc4dElDV1lSaElHdTk3cU0r?= =?utf-8?B?ZWpkWkx1T2VvZVh3bDQ0YkRXdWxWL3Q4YXpVSkw3ZVhTUlhLdTd2TFEwM2xa?= =?utf-8?B?SjA4Zk5YNzdidGIrY2hkdDRLcTA0WXRiZmIxZEIvWkorL1BkT1FKclJzY3BK?= =?utf-8?B?YUNlUEJiNmwySTA0cTdOTlZybGNBT2d1M1NrTElIQW5TcTg0c3RyY1VOVlho?= =?utf-8?B?NDhoeWJ5QS9kVlNTYTBVZlF0NnYyWXF5TXpyRG1VUHhtZDB1bTlKTmFvd3V3?= =?utf-8?B?Qm9sVzBnYUJtbWt0Z1NKUjY5V2JyZDlhUk5SWE02VEJ2RUZaZUJ3enozNzha?= =?utf-8?B?dFBoL3c0bmptbzJzdkJ1LzNBQzBJcHpTN1pmbFVYQ01XSFZWUDdQRS9jdnVv?= =?utf-8?B?bEd3SHBmd09PZytHNVRmMGNPT2pYOUkvdzhodFo0QzFJYUNqd2J2eHFUYTZM?= =?utf-8?B?Y0ZPTzUzNEloNVdtdnlKeWpFQndkR29ubmNNc3ZsZk4vN3BReVZpRHduNit4?= =?utf-8?B?dUpoSjJ1YUhXeHdaMFhVaWFpNlNPNWtDNGpRME1CWk9rWkljMVdHWk1OV2xh?= =?utf-8?B?VnF2TTBWUTJYdXhPYmpkWUtJVUdCeTV3djlYd2dueTJTYW5SWUNzTE5zMFJZ?= =?utf-8?B?eVRzaUUwNnhhU2dpdVdxT1lsLzM0YXYzaXV5TVRkb0p4SWIzU1lwN0REQy9m?= =?utf-8?B?NGUrN21FN1VaWlR5RGRkUmQxS1BCRlQrMjRDQ1p3NU14WWFWOEdLeE04QVdF?= =?utf-8?B?T05FRHVTTi81UGl1NVdhQ252SkJXQlY0d0VpWEpDbmljR0ZaaWEwYUlYbnVw?= =?utf-8?B?cG41TDZGYVR1SFg2OHFDYjRNb1ZxOEdZVGgyVzNPMzJqcVY4TS9ZOVhqWkhh?= =?utf-8?B?UDJOY0ZJZzdJVm9hWFUwTDFvQWhPcjJKdmwvQmJnb0xhcVpLMzhod29UTVpr?= =?utf-8?Q?hlD77Z9YZA6NAz1Je6T2zlqK4SDv1eyW?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5227.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHMxM0JFZFRDM3NFVTJsTWRucWlPNGRIN0MxcFFOQ3hrM0Fwbis4VWVSVFhu?= =?utf-8?B?cVk3Q21ZQ0g0Nk53K1phc1lvMmNza3RwZStlWHErQ1lvMGhROEpYWXQzdGh1?= =?utf-8?B?OXdxbE1hS0VndVlRUEZIR2tDR1crVFNoY0MwdndpSDBVNGJYTCtRem9tMXVO?= =?utf-8?B?N0tGeVBGMGQveE94b3l1eElpOFlyTkFuVjc2YUN4cWZoU29tdUlLZkY4VDls?= =?utf-8?B?dGJNMi8vYlBWRVFySllSZlFRbmdOS25KMktBTVA4MDdzdXlKNjNxb0oraFRZ?= =?utf-8?B?SWxGV0FRc09qanp5TW5XM0RQRWJUZUZkNEk4REJrR2hFN3JEbWxMb3JiOFR1?= =?utf-8?B?NDJya2RqVFEwS2tORzlGak5rc3NmVGt3dm1MUGtYZEtYbUwxcnFpKzMvMVJj?= =?utf-8?B?WkcrbktMUzIwVDdUQTdtTWh6UytITlRyV1dRVytwSmo3QTQ0SGc0b1pjYVhR?= =?utf-8?B?ejNJNGsxR2g3MzgzS0x1YlB6eDBicldQWC9LNlZhZmVKc1YrL3VJT2tENW1x?= =?utf-8?B?b3hDSHFHa0N1Z1daUUFlLzhIT04yeDVTTXh3YWhXVVJuUkNLRDNmYlcyWUps?= =?utf-8?B?YjVDcS82bnJtRUJZZ3pqWklXMEhJVGFKVWQ1eDRCaGdheEdrdVRGY1QvamQr?= =?utf-8?B?MENEWGl5bWtUN2h2Z24xTDdHZW9xSGdEd216dkNCTndPYjhqUFI3ZlprU1h5?= =?utf-8?B?SmNLMm1NZWJoRUMxR09VR1BoUmtFMHY0Z0Z2S2hhT2xTRStlMnliU2FwaWtp?= =?utf-8?B?eW1QYkZoeklIMERhd25PNENKTnREeDQ0b2tXdVhqb3k4SVZwNTlNci9FRzJS?= =?utf-8?B?RDVuOVhib1kwSTl5VnpiT2gySGhjK0ovbUg3L2RseHJDWU1RRDh0eXpxeWpL?= =?utf-8?B?dC9ETUFhT3lGMW5wbXY4cVl3Zkx1WFo1V1pvZTlJNERwaEF5NkpySVBrZjU2?= =?utf-8?B?RjV4NUpmTXczc3JhekZEVXp4T2NFVnF2bW1GZ3Y2VEtCdUFCM2thYWlSZytL?= =?utf-8?B?VUVlL2hiNEpzN09nTUhJOVc3SEVuL1dKZFFiaHFBOTFDaFZ6RVM2UFYyMVJL?= =?utf-8?B?RC9JRGhxYVNnRWdPclptR1BzQ3RPSlQvUlBsU1NOaDViWEo3TnhEVmpGMEdR?= =?utf-8?B?WFJTWEZCdjErbUdkQWlZQ0U0aTRuYTZZcElvVWxhNmUrNnNLMlpSZU92KzNo?= =?utf-8?B?K09hZXNJQW02cFc4cmxDQXdkN092ZkQ5U1czdXgrSkhCMGFpa3dCN0xMYXNI?= =?utf-8?B?RkF1aUVqVjh4ZFRyZUJsc29iMXJoUlNhbnJDMUppTkdQNS9RK2V3MjA3aFJI?= =?utf-8?B?MGs4akU5bzlvYXdCenRRZU9GazROYlYrREJ6RkhYK0RKWUpXQzc4UHBtM05j?= =?utf-8?B?d3dvcTlNK0NTMXlTbFQrRmg0Y2N2U0RFSzhiRlhROHV0STNlZlc2azdhd2h0?= =?utf-8?B?NTFVREVlVHBFOWlFNkpIWmFTZFgvK2lTSkZLWDJkdFQzR0ZKSytNdDY1YmVa?= =?utf-8?B?UjkxVUNSSEdMcGJ3VGduMVBwZWpmMGRSbXVFby81QXRpN2oyNXBoSFN2MHh1?= =?utf-8?B?SVlDR0VQTXFGcVBuWXJZRFg4RnlUYkdBUE9qTmYrWlZCeHFndy9DbFhqU2JS?= =?utf-8?B?eFVIZE16eW5maHFBUS82L21RVnEyVFBrSWtjNFhYTTJoTFRTOUdIRUlidkpD?= =?utf-8?B?bmJMakdmZzVSM3dBTUJSdGtMZDFFRVVsSGIxcFlzZlRqR3pQb09KbStwRmdz?= =?utf-8?B?WlplcWx4M0lXVnY0aXRIenFoS0xrWnJ0UW5SYks3WGRUT3dkZ25XdWY2OGVV?= =?utf-8?B?eERpL2VDTTRTUVFkbWlFbjFYWmpLaVd3NmgxQU5UcVgxZHJCTmFYanNxeFpK?= =?utf-8?B?RzI3bU9ZVWlIZVVWWEkyNUNPcHBSL2x1VUtIWTlMbGJFeG53THQ3WjB0SG9m?= =?utf-8?B?Tm05VDVXM0pmN3JVVjZNekV2WmtXLzdETFJMcU40U2lNam9UNWFzeE1zWTYz?= =?utf-8?B?OXpkWm1lYmxkWTdxNGk1aGxhWkJ4c0JzTzc5VVZzbXJGVllUUGU3T0t2WGVK?= =?utf-8?B?Umx4dHY0NGYwaSt1SnA0V1ZKSE5zK2J3YUxVRlBpdFA0WGpib1owdHo3S3U5?= =?utf-8?Q?Lw9Sa7L50l+8cTwJeBXFxq/ow?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8df38a21-8d59-47a7-8a40-08de0bf17893 X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5227.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2025 13:48:07.2268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5713U0KRGhpbw56KBCa9c6exSAx5U7HfaGcPqTj4SHN2+T7WRzvM4/pqKFkyWnJu/FQeTRkbLh7jBCncUPaFUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5176 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1760536105882158500 And return from the function early if printf_info_one_json() returns error. Reported by internal XenServer Coverity instance. Fixes: f6c6f2679d49 ("libxl: Convert libxl__object_to_json() to json-c") Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Andrew Cooper Reviewed-by: Jason Andryuk --- tools/xl/xl_info.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 2048669abbd4..696f1f7423cb 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -585,6 +585,8 @@ static void list_domains_details(const libxl_dominfo *i= nfo, int nb_domain) #ifdef HAVE_LIBJSONC json_object *jso_value; rc =3D printf_info_one_json(&jso_value, info[i].domid, &d_conf= ig); + if (rc) + goto out; json_object_array_add(jso, jso_value); #elif defined(HAVE_LIBYAJL) s =3D printf_info_one_json(hand, info[i].domid, &d_config); --=20 2.51.0 From nobody Thu Oct 30 19:06:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1760536119; cv=pass; d=zohomail.com; s=zohoarc; b=TP2goMD/ztRMvKz/d9I0oOH0SezA2ADY0/jU9EpFhwtPhlIkQRNFWh9SLeong3Ovecwlb3/X/ozOOysrlD2fKlkerxiC9aFfNz/l3dQL3oINjKFNxI4Hj2U8j0BKYLvKcSc0FDlvAp1NOw8XYl5P2NmKGV19vlKfGrDI9HClwv0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760536119; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yAZenEHHSJc9XuumDpKzapOsydcxgd6TjINpy1Ft2iE=; b=g4OIJjyDHkbwt61V3fKAQPZlIa1kblZC7865anAFTTbGICSjrbPMkKr18aMjuO1lc0iu5uFNUXQL1VM1dAaaL2lX2XMlx37/MhlnESG+1zaXhHBTYWr03Jns7Mud6tMMFa9xZ62sDA96g5ZeWHJMlQM2jwLbb2D+Pob4yo+NpS8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760536119427293.4915887056103; Wed, 15 Oct 2025 06:48:39 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1143616.1477320 (Exim 4.92) (envelope-from ) id 1v91rS-0003VV-3Y; Wed, 15 Oct 2025 13:48:14 +0000 Received: by outflank-mailman (output) from mailman id 1143616.1477320; Wed, 15 Oct 2025 13:48:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rR-0003VG-W5; Wed, 15 Oct 2025 13:48:13 +0000 Received: by outflank-mailman (input) for mailman id 1143616; Wed, 15 Oct 2025 13:48:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rR-0002AF-0O for xen-devel@lists.xenproject.org; Wed, 15 Oct 2025 13:48:13 +0000 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azlp170100001.outbound.protection.outlook.com [2a01:111:f403:c110::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9736b2b9-a9cd-11f0-9d15-b5c5bf9af7f9; Wed, 15 Oct 2025 15:48:12 +0200 (CEST) Received: from DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) by CH2PR03MB5176.namprd03.prod.outlook.com (2603:10b6:610:97::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.11; Wed, 15 Oct 2025 13:48:10 +0000 Received: from DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2]) by DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2%5]) with mapi id 15.20.9228.009; Wed, 15 Oct 2025 13:48:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9736b2b9-a9cd-11f0-9d15-b5c5bf9af7f9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F9tktHKpTpp8m+KVrQIxfYXz+xLxjHIGP2kwPsmdlgf2C3CIjBDdycmO/pYs+mLAoScALRkkXonm4h+R2fWuM2J3r5Z2Uix5SM8ITQ7FRzNwJcXzldX/8bBawX/mg8SACFicuZDqyng57d9PsdCKJYu+rNul//5/J3PQeVJbl0KfChlXxcg+vRcmOeKqRHdeeWRMRuf0xDR8wq/X1Tk5ZL/1i+nxQmEhFv46yjVSKZaUFoMdjSJ9xRzu7nV1c/5k0erlkeDt/i6M7dIVMW2bosS680/78QZoYTeYjZ9FJJqis2uiN3k79jjd2JVcF1twFC/Dro9JIlS5f90VouuaNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yAZenEHHSJc9XuumDpKzapOsydcxgd6TjINpy1Ft2iE=; b=bukHzepcWiIfWk30DaTWs1OaVr/9pqNIsUNGSqHN+qQ2XeBgvQcIP0O95QMeuhXRoR9qVSpwA0KLyCsa81lvLtYLFa0fA3ZZgZ6w9SdU2nNZjctzkOmHC7xE0+nyYHeqK3Mx4Q+mjOjTbkrgeEk7nTUjM1zkNoSheqVtpisesp245JSKNU6AXWR39URajEtndYNfb59cYqiIxg7QDgw950shTcv70u/Z1vtFqWsaT7rp62r9E7YBB5kC648ElX1qzLSCyv9boVTyqs6GJisjCQusNguaJL7JoF8+3sXp17GniXPJr2uv0jJc26zNCjdxfMrFlNdEkMVwhOGzAP2EHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAZenEHHSJc9XuumDpKzapOsydcxgd6TjINpy1Ft2iE=; b=fIxf75mlf9MlSJJEiKYVUth3DwK0LulHHnPsEVXffvl0PmhE65LqMt6bXFhvzdPZPeEhTShcdgww0LvhhaacvaRkoCFoNpf2wAI5+hxMgyPz7Ik3BA1oIVA/oIPMUazSLq5U7dzLliybf65/8ojeVYQ9LjhOmOYS/gszsd2Xqfc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: oleksii.kurochko@gmail.com, Roger Pau Monne , Anthony PERARD Subject: [PATCH for-4.21 5/6] tools/xl: fix possible uninitialized usage in printf_info() Date: Wed, 15 Oct 2025 15:40:42 +0200 Message-ID: <20251015134043.72316-6-roger.pau@citrix.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251015134043.72316-1-roger.pau@citrix.com> References: <20251015134043.72316-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR1P264CA0137.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2ce::9) To DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR03MB5227:EE_|CH2PR03MB5176:EE_ X-MS-Office365-Filtering-Correlation-Id: f8955876-78aa-457c-6335-08de0bf17aba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZE9sQkdyRlU1WkRiVm80WW9vd2F4enR2UCtZMUJlUFJiWlR2WmtuRkxkVTFa?= =?utf-8?B?WFh4dWpTQ3JrbFdKeG1RcFdsZkNPSHVnNHpJU25pS2xiQVllREJZcW1ZUThT?= =?utf-8?B?ZDI4ZllnZ1oxWG1XK083NXYrYmxSYXNaZEM4SGhVRG9sK1pnekEwVUd1ajZT?= =?utf-8?B?ODRKRGlGMVFibGR4MGc0MXBOUHlPSDJWWVZBanljV2dyeVNZRmR6TnR6K1ZJ?= =?utf-8?B?OTZPdmQ1YUxSdlBQOEQ0bWQzdU9yRFFkN2JWWjdjYWV6WnFBUWpuMTlsRERI?= =?utf-8?B?WXRmTG5pYzNrS1JXcE5ucUhpNTA5T1ZUM0FYT3ZGTHozS1VuSkl1bUIyOG51?= =?utf-8?B?WVVtTUYwR1Jjbm82cVNnR1VVenkxbGpvSkM5YmF5RVM3QWZiWGxjSjdqbHV6?= =?utf-8?B?SEdDYUZ0cmtIVnU2L2ZCZEErdVUvZzZ0K2oza2h6NFZsU1dJaXVsZ1d1c2hs?= =?utf-8?B?c2dqTHpDanUrQjRwNUtpY0UvRjJhS1J5aDRTQW9ZNm96KzRHMjh1SzFxaU9i?= =?utf-8?B?SS9VanhlNUprdGlUU2diQjR1elhuZUF3ekxWTnluZ3JWS0dxc3pHeXJWajN6?= =?utf-8?B?T1ZsMzkybUx4RWJKdUk0WktuUDArdkVIWVQ5RkxWTm5icmFpZXZJWnozbXMx?= =?utf-8?B?cUdWczNuVEZmQzRXZ3hvbU10L1NhaGNhSzh6a3BuWkE0WXZiZkZzVjFiOHR4?= =?utf-8?B?ZTlSNXZpWklSTWNYK3VIL3MxbmxoWFU3ZWs0akQ0QjRrVkpEUjJiaWJsVG9l?= =?utf-8?B?U2pFbURDMm8rcWFTVzZlNUcreVJ6MjFvTDQ2ZFBwcGFDR2hXdVBZNEt4RWMv?= =?utf-8?B?enZKMVllVi9xdjNKVERzZkNKRFpBL25qNjVnQkYyUHF4alJlcWQzL1ZraGlE?= =?utf-8?B?STlER0VsOVJvQ0V6ZVppZkZKazQveW9uNS9TaTgwQzkwdmsrSWV5UWlxTmtw?= =?utf-8?B?TjdNeTZWUVl2aTR6MWU0REFlVlFqbTdiOGxpbk5zWXg0eXd6RDZOc2MydEFL?= =?utf-8?B?K3ZlRGRTLy9objZyeEVudHBjeEIzSFZ1SGw3K1huZ25TTUpsZWgybEJDRUNS?= =?utf-8?B?K2tyZUJMU0lOVklsaEtmTkpCazNaSVJqaWFqeGxhdHRlMU5rTUo1MS9ONW5V?= =?utf-8?B?dTZ4RldoR3d6QTNoZ1pwd3phZlBaNmFSQTg5c2RuWnpwZTVpdEVzTE1XVHVy?= =?utf-8?B?eEl1N0NpYmozYTNqSUdQVkwzVUpOcGQzVklwNW5mUjZoV0lzMWdKSDRhaTNL?= =?utf-8?B?Uk83Y0Z3aEoxWjd6bjN2OElrWE5SWW5mSW1iM3poOTBya09WN00wWHltRHh3?= =?utf-8?B?Yk1kcEIxZEFyUVI0dWpaMFpjeTJwekg1bGV2d2xTRjJqemxvUWtSYzJyZWVs?= =?utf-8?B?aURQaDVEMXlIZm5vSWh5TE1KSnV3ZXVkcUFjTUFOT1JMMzVXUDNRb01qMUgz?= =?utf-8?B?K1lwUXFGZDJYdDI0dW1EMVVSUVFhcW1SckxhY0tMMGRBV0QzcjEzYzhVblBz?= =?utf-8?B?ZWpYc2xKQVRRbkx1Mml3WlI1NVJtc1ZLL0x1QkNPVHVpL1gzVCtzSUp2dURN?= =?utf-8?B?QkgwWTd2YkhUbU5uWHNteFlUYUR0MHZJeXlsaU9MVjdlSW53ZnM1dDZjbzAr?= =?utf-8?B?V3pWZXViaHlwRlQrdWlzZk42SG5lcjdBWTgzVmxUeXhxME1KWWVrUUFWT3hR?= =?utf-8?B?R1NvcG9NOVh0S21XL290SEowa0laWkY2d25NRmtEdzZMRW94ZUNISmJlVkNN?= =?utf-8?B?TEVSRHJnV1YxTDd3MjB1VGw2bW9rK240UE5PUXlMTGJGSkdkTVg1L0FINGNa?= =?utf-8?B?Qy8yd2cxd2xoM1ZNeDFwOUhSSFJrQlRhd0tLTFp1YzVFTS9TemVTcUlYNmZq?= =?utf-8?B?V3pRaWhhbjlLRy91V3NENThCNlRySEd2eGp2SGVEMFF4QkUxc0gwZUc1Yi83?= =?utf-8?Q?VJlt/hJDdvggOz317/aoPVsKCQJ05TGg?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5227.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUxqTkw5dCtLeHRjay8ybUxsbzlMZTR6a3FQWHFncFhGb0hva3ZUK3h2NDNj?= =?utf-8?B?K1ljdUNvMlEwS3R3WW5HdXJxSDF0bktOeHlQUkd0TFk3QVE5SVducjVJS0hm?= =?utf-8?B?Wk9pYlVtZHI0akE0Y3hWRGRwOGJTWHRzdHRJcmhPbVFaNERnbTJhYVZMaWZq?= =?utf-8?B?Mzd6NDBSazNSbG5mVjVOaUdUbDRHQjV4eXB4ZmxpczFKbWdMejk4cFpaUkxD?= =?utf-8?B?Nk5rVk5pTEUzZjErK3dqM0ZmUGQxSEYzbkYzakd5RVJxMEZuVDY3eHBzbzZo?= =?utf-8?B?aUcyNzJnZmNXZmU1U1BGb3VQR1dIL05MZWx4WVBOeTYyay8vanVhSFdMTG1J?= =?utf-8?B?eUhIZEtDK1RsUmh4akdiWHViVm80dTdRVE9ESUlhOHB6dmtxSllNdU1kSDB4?= =?utf-8?B?M3JwVEJOV0doV3lMOGQ3em5vUXNYLy9pQUFNd0cvMHozMzRrcTBPVlJOeW1h?= =?utf-8?B?aUduaVJEblBmWXR1MSsxanA1UEVZdlpnM0lkajF3dS9OVG54Mkp6aE9ROWMw?= =?utf-8?B?cUxHS0hZM2Vxdks0bGowNmJ3UnlzOVkrNk8zYkJmUXBRVDVXbHpYODNnZ29T?= =?utf-8?B?ZW91YndqcDN2YXoyQy9MTTlPRzE3M2wybXVRc2YyaVRONGFrRTZLNmVRZ1NL?= =?utf-8?B?YUxGNkF2M3FxQisyS0cvL2tWUGg3TE1WaU1CTmR5eXdXd0huQy9sTWRidGxQ?= =?utf-8?B?MFkzWUxSS1U2YXBTeXJtSFRwS3cxNVlYbFdhblE2c2F5L1A3djRDWVlFaDNB?= =?utf-8?B?R2hKejNrSXp1R2dBVk5OWFhTTm12YTBFT2d0VkF2d3RtRmErOGs3VHNvWGFy?= =?utf-8?B?aGlGTlAwVlZSR0pFbjA2MUtWNlBHR09rb0pqQlEzUjg3dDZWcUxMSFFGYldy?= =?utf-8?B?T3ZSYmhoZlN6VkRIWFNSenkvYXhoODNLVGljb0VBSjZNK0xKVVlDdERBM1Zm?= =?utf-8?B?Nkl3c2haczZKK3hvaUJUK01ORXFLZ3cwUmFXMzN2ajdjdmMwT0JlODBadkh2?= =?utf-8?B?eitGQ0pXVWxpdDRsSjh6SGlHVWhRREVlVVJIT2cvbVRPcnVuc1ErcWhpTGxm?= =?utf-8?B?NWh4eU91S2t5SS9Md3pRdG1iTUxkcHBsQ3hSMDNwcEhOY0toR0dMNk44WHJE?= =?utf-8?B?Z0tPczdMcmk0YUdWdysrUWNYZU1uTU5CcC9kbjM2WXVwc3ZGMHNUN3RHNXhp?= =?utf-8?B?Yll2UElzcE9SL0RMRTQ5R05NOWpjb0ZXUU9aM01xdmp1YythdUp1ZFk3Sk5I?= =?utf-8?B?aWVISmd2QjhtNFNlQnZNYSsybE9PdnFldERPZFIvL1ZXa0Z3amV5aWMwZFR6?= =?utf-8?B?LzViNkRPdkJ2TGkxNFA2MnpjWWRxUzE3dEorRXJSNmtMVzBsWWNud01yaWJK?= =?utf-8?B?YzdTMkQ4SXJrWXFDdkZFeDB6dUV1THpybTNxUVpLei9oWTF2VmZCeEtIMGQ5?= =?utf-8?B?cVlnbUNON3lETVROYTJBaHJDQ1JaalVUb2xzT1JaMGxJVENPL3RqdW5JeVd6?= =?utf-8?B?UkRzWjhuRVpRY3drcExqWlFFVTMvTjFiNnl0L0NmT1Y0R28vdzVPZTRtSnYy?= =?utf-8?B?c1VQWitLc203V1IyVFlxcnQweS9pT2JCQTFNVjhRaWtKVTRYZ0hyUEs4Sjha?= =?utf-8?B?Nkk5RmxjVDVqYVBBQ3Jha2ZOSVFqRnQvMWNDWTJYU0hNOVduRkVSRXA0TTFV?= =?utf-8?B?eHpIOGRiZVV5WHR2elVXTmJodnpaRTVkak9tV0FpS0JuVlYwYXJ0N21aMExj?= =?utf-8?B?eXZDNElvR0YralhWSEJrR1RjNWdub085WUhPS1MxZ0F4R3gxdnNyOHU3S3o1?= =?utf-8?B?TjI2aW5KQ3YxWUFCWTM1VE9WOGZyK1lRYkV1WTJLTlFzOHUyeCtIMHQ5dFVr?= =?utf-8?B?MDJuWjRQcTNHWk5ROXdjbzRaT2J5dkh1VWtVN1NDMkJwNkRqKzlnVk44MU5z?= =?utf-8?B?akd4d3JGUlY0M1hlY2o4dGtPTkFyMEJ1U3A3YlkxNXhWeldHY2thNlJGQzh6?= =?utf-8?B?dDRGZzBCdzJacTdrYVRlZkJuc3lkVmJRL1JNK2RuQzE1ckpTVXA4RXJ2V2Z6?= =?utf-8?B?cGxXZEU0UkRxUE1STUhsZTJmYUk3YlJoeDVRV0FIUDEwU3doYStZV2x0bGFP?= =?utf-8?Q?Wh7nwSKChmFScnIt95r5qXUsA?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8955876-78aa-457c-6335-08de0bf17aba X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5227.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2025 13:48:10.8355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gbCkNFXp3pN4FnVqUEI3/rhpGDbNnTtNrktaxVIh8bSZwt8puIy5EPLyWxYewRbQOG0qT35O0U8LDenxb7g55Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5176 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1760536122186154100 printf_info_one_json() won't initialize the passed jso_r parameter on error, and hence the usage in printf_info() needs prior initialization, otherwise an uninitialized pointer is passed to json_object_put() on failure. Reported by the internal XenServer Coverity instance. Fixes: f6c6f2679d49 ("libxl: Convert libxl__object_to_json() to json-c") Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Andrew Cooper Reviewed-by: Jason Andryuk --- tools/xl/xl_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 696f1f7423cb..0314ce7d4c22 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -155,7 +155,7 @@ void printf_info(enum output_format output_format, #ifdef HAVE_LIBJSONC int r; const char *buf; - json_object *jso; + json_object *jso =3D NULL; =20 r =3D printf_info_one_json(&jso, domid, d_config); if (r) --=20 2.51.0 From nobody Thu Oct 30 19:06:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1760536113; cv=pass; d=zohomail.com; s=zohoarc; b=HBVXp5DY7H/vRqNh1a4hnHFfYmqbCtSoFeEnBHx3SWhg+3T2DHBaHHwTQVlfVtak/bZk2ZOvST0VujswtuTGA0qwHwNRUpuWUZheHvfB3OfhMzrwQ3Ci3hoYW1r0ptL4Y5ckqjEdBP55CL8r+qC9naSYCjfS8PjVpT12+ir3sos= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760536113; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=C4ISnr9KPhzDl9r+JqhO5V5YHuJZe//Ip5X1jvyo0Sw=; b=bPIV1JkrblPL3eYvlTs15mOJvaxhcba6TCDVFEULjluIc46cn1aEZCX2p88hw3qF86y0nYd7CZhJsjOn+ALih/P9CW2aor5huDcbk092VFZ2rtK4cHbe1rn5Kf+He/luVhqNYv+byiUAuCMssLQ9zE6lDTXaDkAm661n7qos+4I= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760536113540668.2080702764229; Wed, 15 Oct 2025 06:48:33 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1143622.1477330 (Exim 4.92) (envelope-from ) id 1v91rY-00040E-Bd; Wed, 15 Oct 2025 13:48:20 +0000 Received: by outflank-mailman (output) from mailman id 1143622.1477330; Wed, 15 Oct 2025 13:48:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rY-000403-7J; Wed, 15 Oct 2025 13:48:20 +0000 Received: by outflank-mailman (input) for mailman id 1143622; Wed, 15 Oct 2025 13:48:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v91rW-0002AF-Pc for xen-devel@lists.xenproject.org; Wed, 15 Oct 2025 13:48:18 +0000 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azlp170100001.outbound.protection.outlook.com [2a01:111:f403:c110::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9aa4074e-a9cd-11f0-9d15-b5c5bf9af7f9; Wed, 15 Oct 2025 15:48:18 +0200 (CEST) Received: from DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) by CH2PR03MB5176.namprd03.prod.outlook.com (2603:10b6:610:97::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.11; Wed, 15 Oct 2025 13:48:15 +0000 Received: from DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2]) by DM6PR03MB5227.namprd03.prod.outlook.com ([fe80::c9a0:563d:c344:aec2%5]) with mapi id 15.20.9228.009; Wed, 15 Oct 2025 13:48:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9aa4074e-a9cd-11f0-9d15-b5c5bf9af7f9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dtGd03Tg07zBTGw4RZ5REucuXaHIFf2aHMQxpq1dqtTYDIiIum7ebUpWtj5auj6f6i+gW3ih/QFDjdHT4p08brERvUAhjAL9MzjLCoWceIHNqGsJ1h47T7M+QWwn7XKmmspZmyJ3QA7BdgrqUajMAqHhU3EfWaUCGDh9/0SUXymjNKnFVDGXnsTH1Xuely6H9HAcB/zj5yvPywjD5g/JrTu8b81QX92vSkpjswJQeNvCaI57LPC82CdT2Jf4XPzPg0ZtfwbyewRzJNuOI3ERds62veHZoxB/xm5Mw5wnhtOgRF8UYVtl2FZU4xywbzrLAhWsKPpmqXZatGxa7/FaiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C4ISnr9KPhzDl9r+JqhO5V5YHuJZe//Ip5X1jvyo0Sw=; b=f2T9LdamLEsTArjCLFIJnreEvivzK4ADFzt/l6lLtt0AzV57+gOAQOby2BMwWuQdm4J5C78N/bwoYdm/LzewX0y5lf9zhTI+oIII5vUE7At8IrVJSmDrWwsTMBB+opbp/DwC3DYXBs7FL9o8XAz2QCl6DXLM88KUbP8m0we5cUHSGPk2D+xzRT4BMBnC6yO4oRX0gilVOOdzXbm7eodgX8OL/QRhZyJBfMUWESPouAzAINzqxWEp0vevxwuFbiZZRR+pMSKL8in3ZW5te7PlERtEALSIWv4Am8WZ+bNyGoWPT4SaqTPdDoEnYfonTplmKUPvOiank2f0yxKDe4cLIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4ISnr9KPhzDl9r+JqhO5V5YHuJZe//Ip5X1jvyo0Sw=; b=G2bU7O9w5+HHo0ckjwxJ2O7R5Nc5bY5790WJCGecYUayLPhOqUzuFTyUdMUCkT5r2N7KdAnxPFsr9xGsP0b08fufJ1f/Tom1Ng3IWFoKW/F64CG0U9H7ce+AABzP2g9V+N85rHLhJPxRJKKkO8iAxiJW+2nU6uLV0kyuzjo3AdM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: oleksii.kurochko@gmail.com, Roger Pau Monne , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH for-4.21 6/6] github/coverity: switch to building with json-c instead of yajl Date: Wed, 15 Oct 2025 15:40:43 +0200 Message-ID: <20251015134043.72316-7-roger.pau@citrix.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251015134043.72316-1-roger.pau@citrix.com> References: <20251015134043.72316-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PA7P264CA0179.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:36f::11) To DM6PR03MB5227.namprd03.prod.outlook.com (2603:10b6:5:247::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR03MB5227:EE_|CH2PR03MB5176:EE_ X-MS-Office365-Filtering-Correlation-Id: a0ad7add-996f-40d8-c213-08de0bf17d48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZENQNnhlUS9XbWVBWUlHQ2szbzc2aXpIWmlsbHdnTHViSk5uS2lsVTJrczVW?= =?utf-8?B?U1NSQnFIcjE5MVZOc2ozN3JjNjlSZzRDQlJ5S1RyeGdwNmMrVGxYWG1RbEQ3?= =?utf-8?B?Z2ZuRUIzWCtERHpqMHRRVVl5czZhSTVCNGRxYUhzMCtBSDdiWWJpNVE1aUxt?= =?utf-8?B?UWVNOUtjLzRPckdlei9xMGVyQThDN3VIWXFSQWJKQmR2SXhBamZ0WHlMWm0r?= =?utf-8?B?YTlXMFJUR2J0Sk1WUU82eUdPTlRZSUtqWFhrYkRtWThJb01qMSs5d1BCcEpz?= =?utf-8?B?NHBBV0hDd1RVS2FuRmtxekQ3anJhYzJUSzFmVGpPNktXV1VvNjNwa1cyZi9E?= =?utf-8?B?SzN4c01VMjU5OGlUQlBObkFMaERIUXZvZXp6aU9uZytTeCtKSUZkV2VOVjQz?= =?utf-8?B?RVRMUVp1QzVITDhneVZUejk0VjhPRTlkMXhyS0hRUTlUalFwSGtBSk9FYWMr?= =?utf-8?B?ZjVUWnZGOTZZVWthNXNxc1RIQ0g3VnpiaC8rU0FMTkpsS3lwblJsbE5pL1Fa?= =?utf-8?B?Ymd6c2dzc3JDTzF4ZTRBeVhMVXMrdm1GVHVnblo0Qi94YVFWUkd2SUxLSDV6?= =?utf-8?B?T1FKaXNIQXpWa0d6YUZ6aHVuRU9LbTU1V0M0Vi95UWxGWTlxMnFWQmNWcG9H?= =?utf-8?B?V0VWTUszUllsdWcxVnV1VnZ6dUVIWkxBa29sQ1dYaE5GVm0xVVJjZU9QYlg5?= =?utf-8?B?aHFQcmZTMGExMTh5OEoyUmNGeVFyYXVtcU5Dalc2aDljdzFMRkphaVh5ZzVG?= =?utf-8?B?TE5SWjRKNkVYN1p0eVU4TlROY2hwQktadDU4MVVRdUxTekNVMmYvbGJNMUVO?= =?utf-8?B?Y05helRaVVhpajl2NkVlK0kvZVlxUkgrNy9uWXRWbU1DNHZVTlo5eVFuRENK?= =?utf-8?B?eXNPc051UU5hbHprWDRCVmErT1pBcFNkcDdXbUxGK0QxM1NuSGZxLzMxTXRm?= =?utf-8?B?aCtsbW9UT012Z0JnaWtaelE2RzJ0RzljU2w4cW5wOW9jUlVTaW5oNnRtRUk2?= =?utf-8?B?WEZIUGgwSm1MUVNRNFlYUzF1MkozOTV2ekhOWm9oWHdxSnNWc05sWHZuZ0xE?= =?utf-8?B?Tm1QaXdFTFZmWjZWMms1RjhVUGU0NEJ6OVFvM3E3bkJGT3lpcGFNQmlWQmtR?= =?utf-8?B?VEFnMkVoNGROQU9DQ2Y0TFB6T1R3OVNDR1YvWGVBVkZ5UUNuNEl1Q3JwUGJ2?= =?utf-8?B?aWJHLzc1WCtYSkUwNEJSQUZHY1BOUUpNNDd0UDJQNnRlMXdHVkU3RmJvTnFp?= =?utf-8?B?RUFrVXBySWRlSEcyRmdiVlJqNGRESmtIVm1VN3FqNENoNHJzMTNxUC82dFcw?= =?utf-8?B?dnBkZmpjbC9FblAvTjFVOWI4K2NJUm9yNytyTTRMOFZma2VieWZINm9ZMkdv?= =?utf-8?B?TUVxeCtCc3NmUjJiOE53MHdENThQclpDZmlIaFM3NmovbUhFN3NDRTY0R2VQ?= =?utf-8?B?UGE1QlJBcjg2OEFxaU03b0lDKzRrM2hUWDkrcW8vaVZFZ0U2bTFuVFdYQWUw?= =?utf-8?B?QTkycDJ0bkgvaVdteGhNOHhkYjdQVXgvY0xMWTZVdEhTSFY0U0FJM2grNXhh?= =?utf-8?B?NURUUEIvdG1WNHVvQjIvQ1dDTEhGa1dqYnVIamVJcHdjT3ltM01TNUxqdzZ2?= =?utf-8?B?QWxWS1U4UnhRRFV5SHBkZ1ZOd3FPb0tnUWkxdmRGUm9nYkRGQjZpU04veGFE?= =?utf-8?B?MS9CcTJiM3FvT1p5U0x6aVVVSnZUZVlQN3o3a1hEbUZYUnZ1TVFmMlV1OTJW?= =?utf-8?B?bitUM01hOXZleS9udmw4MjBDYTVKQkl6UnBHODZEVENHaEhmMjJxMnpLRjZt?= =?utf-8?B?SnNZMlI4Q1JiMjBwelV2Q1c5Q3VqU1RTY3ZGKzVXb21rR3dXVDg4eFBmcFpU?= =?utf-8?B?L2E2VDBCVFJRY2pJNnVYaWExNmJ2NDZFcWR3RlpYMkN4elN1UEUzNkhjVVlm?= =?utf-8?Q?rq8PBuV4TCMsfyU68IWTGeXrUxv1e98+?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5227.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sm5tYTZQS3AwLzNOZzdJQU9WV21yVWdkczUwa1YzTlhvM0pRR0hKa3NKOGRN?= =?utf-8?B?UXFpQmtYY1VxT2FrUnRhVkVoMUVPa1B4cm8rekdVcTZmTUZQVmJNcnRSTjMw?= =?utf-8?B?ckg1emx3RWlDd1NQcEFpZDhjY0J3bGx1bC80bk5aTytaOWdOczNRVFdkWUJo?= =?utf-8?B?NmVOK0hlSVRkaHMrMG9CMkVqdzJCNnJidTQrb25kU2txZ3FOZ29YNkFuMklU?= =?utf-8?B?R3pQY3ZZVytsSW5lUDNYTitLdjNRSitwWU5xSmMrM1EyeUJSYkhPcDFIKzNS?= =?utf-8?B?Qkthb1lCRGljbDJNSFlZQ1Z4Z2ZNTHFIdTBScFUrcnNteGFWVCtnODhITENY?= =?utf-8?B?SThiV1ZweDJYa3RsalNUUVVjVW5OSXNqUEFQT05Bc1lrb1dUdmtOejdsQlh6?= =?utf-8?B?VElzK1pUK3BTUzBRK1J2V0kraGVvN2tEeWNBaFVIOHMwYnlUeFNJNHk4SGYz?= =?utf-8?B?cmlQZ243YlpZNEU3K0dILzhaUm9qZ3I1YlplUFVGV042RUdWanJ3QXNYWlhx?= =?utf-8?B?WWNpWEdNcWNEQi9NbjVoVUJjdW1MN0xXS1A1VWRZTVZJdllhLzJlVEJENWVQ?= =?utf-8?B?WnpTZVlKeXVOT0F1OENCTHBtbVhNNkZLQlR5WkFsMGx1NFJhZFZlTzM3bkdF?= =?utf-8?B?aklGNnJiQWp5N3EvTWhLSklpdmxLcWN6RjZ4RXMvbWxNUVJuMXE3cG9EMGNP?= =?utf-8?B?UmFlbi9vcXJMZFFzMnBhWjc5TnJEUEZiTUxGbEtNckhoaW5aV3VrM3hPS0Mr?= =?utf-8?B?RHI1NWJLVzVMcVZ3b0sreGhobUpWK1Z3dkRuaEY1NkNSd2hXVEd0MVpvUTRP?= =?utf-8?B?TEE0TmwyUTZzVnBmb0hXZ1BHMUt6dlp4RzFvV05TK3VQd0Z3SVB4cWlRN0cw?= =?utf-8?B?OWcrbkFDcFI2NWxDTFhFVzhqb0s4YnlEa3NobERMRUM0Yjk4ei9CWHlMM0Ni?= =?utf-8?B?OE1LNzI1SEJTR3Z3b21LYTVtMXJiem00RUtaczFXUVI3NzhOcWN6ekJlcXhq?= =?utf-8?B?Ynk2S1liRVdsSm1jcFFUeGk2ZHBnWU10N2hCbGpqWWNRamNrL0JDZWphZVUw?= =?utf-8?B?clRZZXZNRmFnNFJDamFIQTcrVGt3ZnErVFJvVUxWaWc3TmwxWWhmaUtybFh0?= =?utf-8?B?dUtyc0V5cFVnWWVHazhBZERLYnpYc2JTU1hBenI1N1lLc0RNOHByVFYzM3Bq?= =?utf-8?B?MnU2ellXdWgzK29DVWFqY0VpMGZTbXRqY3VmbTVCWERaUlB2cGR6a05QNnND?= =?utf-8?B?VFg2eTFLZlBraHdhUXV3NVlKWTcxT3dRb1F5TzBFUlREMFVJN3FoSTY5UWhx?= =?utf-8?B?eHltWlRBTGxzdSsyVFRjWmQ2VHJPOFRicTk1OE1CUEpqbHdHYXlPZk5obGE0?= =?utf-8?B?cEkwZE1CNTNHK05jUCtFbTRwSno0QkphMnpnQlZDaCthbzlaNHRISG5uWTlF?= =?utf-8?B?R1RWczl3NWNCTHlvUitoZkxPTnlTNVZTQ040VnI0MWU3UWY5ZXRsUXVSYzR1?= =?utf-8?B?RGVzdWdwQ3AwV0VnVmFoellvQUxzZGk3WFZhQVhXcUVkTXJZRXl1MDVqVVdJ?= =?utf-8?B?d3JaM3FmNDU4Y0xIQnhRVkdyWFFMYjJ2eENPRkx2SDlqbHBOY3N5MFczM2JH?= =?utf-8?B?WXpaRnhObGo5ZkhYNi9zLy9zbm5Jcm1sbzVQZXpkclNoeGdpdGsxN3lJbCti?= =?utf-8?B?SjhnU3A2WnRtcXFmN2lhMUczUlpLN0tSSWFQQkxiZXAvbEgxcm1OVWdPVXdu?= =?utf-8?B?cnRLSkRzOXprekVLaFJRNG5aNEdTZnJHdUxDdFNOUFJPRngwQVFVNmhlYzR4?= =?utf-8?B?Z2Irb1ZYL01YVWxuaUdKUTlabFZZMk8wN0gwL01qdVBLa1NkQ1BCVWdoSktP?= =?utf-8?B?OWF0N1VUTVE0S3JWK1J1R29MeEF2V3ZBNmRZUkZMcDFZRlE4R1JGa1h2NzlU?= =?utf-8?B?U2RReG1hbm5nNm1zeXVLa25oVVMvNTM5bU9rbzNaM3JtYlFjb3JnWTdVbUZN?= =?utf-8?B?MFlaaDU3OUk2anJJS1NEU1kzeWhuWll6SzhyeEE2cWpCbE9tUnc4dnlrTW1O?= =?utf-8?B?ZlRJbGcvN3FST25yd0ZsRjJxVTQ5elljTFBOR3UwL2hGTGJLOVFCaEE2Nk8r?= =?utf-8?Q?afC0s807WiLygpskbB5a3SmfK?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0ad7add-996f-40d8-c213-08de0bf17d48 X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5227.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2025 13:48:15.1300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8VGxbYYIcliSOtGZPamznn+r8GZoWGER4LfUbQtLUMOWXhbv8958SJQxXfBHKwOh7V32WzTmPXHvmtJKsNBZ5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5176 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1760536113953158500 Switch the json library used by the Coverity runs. Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Andrew Cooper Reviewed-by: Jason Andryuk --- .github/workflows/coverity.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml index a6c2819b0a24..a9a971f6a1e5 100644 --- a/.github/workflows/coverity.yml +++ b/.github/workflows/coverity.yml @@ -20,9 +20,9 @@ jobs: iasl \ libbz2-dev \ libext2fs-dev \ + libjson-c-dev \ liblzma-dev \ libncurses5-dev \ - libyajl-dev \ libzstd-dev \ ocaml \ ocaml-findlib \ --=20 2.51.0