From nobody Thu Oct 30 18:25:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1759655970; cv=none; d=zohomail.com; s=zohoarc; b=hdiwhfgjQT52w9TPtlzHmviuZ41X55RN2xQ6VU+XhKsw8akuFkUpqKm6TU2EhE3a+d4rNm4v57pzd/Jcv6zoZRs2PJsHheUDtK0m0olxvv3KImb358tdskqXBMvhGqxIzkX/DyB8uinAaZ7xTOifFz9z2dGanNhinwvzv/KU1Vs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759655970; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+AiHD+yuxp0p/FZBZl4MKBM0GEgTQxDyMDQgOxsgIMA=; b=EqMiJQEgrFZVKSNbSp+N3zHB3Sf1+rX14JuMJD7GnlI8tzHtlfRPGsRvEDlbszAtQoFDohWxMiY1KLAFo1tt6Mq2xqRjYp3kQUENUlg1rKx50uxfy5nLOKoi9xx4nAneUUslNkwk/44sw0z+4cxd1Az5EhCsBlCH4h/jV7GNVmg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759655970666882.4334171869782; Sun, 5 Oct 2025 02:19:30 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1137551.1473591 (Exim 4.92) (envelope-from ) id 1v5KtH-0005dW-Pf; Sun, 05 Oct 2025 09:18:51 +0000 Received: by outflank-mailman (output) from mailman id 1137551.1473591; Sun, 05 Oct 2025 09:18:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v5KtH-0005dP-Mg; Sun, 05 Oct 2025 09:18:51 +0000 Received: by outflank-mailman (input) for mailman id 1137551; Sun, 05 Oct 2025 09:18:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v5KtG-0005dJ-U3 for xen-devel@lists.xenproject.org; Sun, 05 Oct 2025 09:18:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d35909f-a1cc-11f0-9d15-b5c5bf9af7f9; Sun, 05 Oct 2025 11:18:49 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 795A921D61; Sun, 5 Oct 2025 09:18:48 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4448313A39; Sun, 5 Oct 2025 09:18:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SONBD/g34mjcewAAD6G6ig (envelope-from ); Sun, 05 Oct 2025 09:18:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d35909f-a1cc-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1759655928; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+AiHD+yuxp0p/FZBZl4MKBM0GEgTQxDyMDQgOxsgIMA=; b=H+f1egBW2XSbcAQF6oE9eyGpuEd9KvASLzEqdn0BcQlhK2667pHPhIKT4nx5kA2aVE7NRV zzO3uBXJqxzzyfpnjZ7aW6Jb8oc4Day+Ws/A7y4TlVCCnWH3fHh//fpWurya0J6LfP7m4s AqHyMGb4CWKssIomoTwxQcuCjWiVtDk= Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=H+f1egBW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1759655928; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+AiHD+yuxp0p/FZBZl4MKBM0GEgTQxDyMDQgOxsgIMA=; b=H+f1egBW2XSbcAQF6oE9eyGpuEd9KvASLzEqdn0BcQlhK2667pHPhIKT4nx5kA2aVE7NRV zzO3uBXJqxzzyfpnjZ7aW6Jb8oc4Day+Ws/A7y4TlVCCnWH3fHh//fpWurya0J6LfP7m4s AqHyMGb4CWKssIomoTwxQcuCjWiVtDk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Anthony PERARD , Jason Andryuk , Oleksii Kurochko , Luca Fancellu Subject: [PATCH] libs/guest: don't use unsigned long as type for PFNs Date: Sun, 5 Oct 2025 11:18:45 +0200 Message-ID: <20251005091845.3725-1-jgross@suse.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-1.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:mid,suse.com:dkim,suse.com:email]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[suse.com:+]; FREEMAIL_CC(0.00)[suse.com,vates.tech,amd.com,gmail.com,arm.com]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-Spam-Flag: NO X-Spam-Level: X-Rspamd-Queue-Id: 795A921D61 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -1.51 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1759655973822116600 Content-Type: text/plain; charset="utf-8" Declarations of xc_dom_console_init() and xc_dom_console_set_disconnected() in libxenguest.h don't match their implementation in the library. Use xen_pfn_t for PFNs in the library to fix that. Fixes: b6fc307b0b00 ("libs/guest: Set console as disconnected on resume") Fixes: 971b7d5ecbcd ("libs/guest: Set console page to disconnected") Reported-by: Luca Fancellu Signed-off-by: Juergen Gross Tested-by: Luca Fancellu > --- tools/libs/guest/xg_dom_boot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/libs/guest/xg_dom_boot.c b/tools/libs/guest/xg_dom_boot.c index f51b6a78c8..beeb4a7255 100644 --- a/tools/libs/guest/xg_dom_boot.c +++ b/tools/libs/guest/xg_dom_boot.c @@ -430,7 +430,7 @@ int xc_dom_gnttab_init(struct xc_dom_image *dom) =20 static int dom_console_init(xc_interface *xch, uint32_t domid, - unsigned long dst_pfn, + xen_pfn_t dst_pfn, bool clear) { const size_t size =3D PAGE_SIZE; @@ -451,14 +451,14 @@ static int dom_console_init(xc_interface *xch, =20 int xc_dom_console_init(xc_interface *xch, uint32_t domid, - unsigned long dst_pfn) + xen_pfn_t dst_pfn) { return dom_console_init(xch, domid, dst_pfn, true); } =20 int xc_dom_console_set_disconnected(xc_interface *xch, uint32_t domid, - unsigned long dst_pfn) + xen_pfn_t dst_pfn) { return dom_console_init(xch, domid, dst_pfn, false); } --=20 2.51.0