From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220532; cv=none; d=zohomail.com; s=zohoarc; b=lcm8g2R9y6sltzhuC8l6PBGKTBqq6al9RUsmgfc5JhtD9MnHPpJkajENRuykfPAFD3EisZs+PZTMxVdXN/t/5i/STlSyyM+UqwkUX9Fh3N9hkng7jd0OfXQgEefI/LRwew+hhS8iOpDgHSAYnJEelGwHwi9VkbPZOLZ+J1vLe28= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220532; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=I6r7ywVdtgg6puBO7GNeh9QBn+ePwbPPQeAATrRMKjs=; b=SNNN4EwJHnvXxoYnY8RHylU5EPy1eNgPjSo1y1EgWeBFYGxm4D8SQcKU+nG5lHWFqU+/vR1iXJ8pxmLXkG62GpcV1WYlRJ1Ftki36ImyUF9Qf06N+HbZ6Ugs2yMKG1k0k0FmOcmhv0yczAAQQ3iYK6LhjxzJqnv/PuEz5GhkO/E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220532043581.3339985825896; Tue, 30 Sep 2025 01:22:12 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133829.1471880 (Exim 4.92) (envelope-from ) id 1v3VcD-0007RA-PW; Tue, 30 Sep 2025 08:21:41 +0000 Received: by outflank-mailman (output) from mailman id 1133829.1471880; Tue, 30 Sep 2025 08:21:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcD-0007Q9-K6; Tue, 30 Sep 2025 08:21:41 +0000 Received: by outflank-mailman (input) for mailman id 1133829; Tue, 30 Sep 2025 08:21:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcB-0007Nm-SF for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:21:39 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a6cdbe9-9dd6-11f0-9809-7dc792cee155; Tue, 30 Sep 2025 10:21:35 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3ee64bc6b85so4950395f8f.3 for ; Tue, 30 Sep 2025 01:21:35 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb74e46bcsm21770765f8f.8.2025.09.30.01.21.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:21:34 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a6cdbe9-9dd6-11f0-9809-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220495; x=1759825295; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I6r7ywVdtgg6puBO7GNeh9QBn+ePwbPPQeAATrRMKjs=; b=gyS8IQ83XQePL0dmCrxB+R3Bmw9kUZDIfcsteCVOK8lm6GRlqlmiw+Mf7C0Hz4I55t ylbLgBdrh2JNCagOn0TJVnkcvwIQYzkrza5CkyTlLmEwcdi2gDaEQ7ngmjpfkt2hhdB6 SdEOejxAzSy8xMTTbQibEhl9MgIw4rrgRKMCceHyhlUt8cycWE8XLW0OY4i2JeIIddC6 8jxyPu4x1Qtm8w1iWQ/rVhKB/pqcQMGqN4Iek6paE5U7P2vmI8/PdlpjTpfPjIXKYZlR WEDCwYVIhhTljiE7qIz6xgLk0hbvQ9Bxv/JuWZvuyVY+ygHnUuwAYsklPAGV1qubJSsX U4Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220495; x=1759825295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I6r7ywVdtgg6puBO7GNeh9QBn+ePwbPPQeAATrRMKjs=; b=DE91NMU7iWi6eyGvKkr9MCaPg6bBol+QPSdbldESQ1qoSW8JrdqUB4KzsDtMJAA4IW R6pdAv42CIVug8HErxivmeR5kGMTkkmBfTkIjvY77cR4NvGpbfw0jm18g8LoV4se1vph G+UvcFC9oRHWYTaNUcjo7ZOteQ//nKrlY+zNqnyTfJBjoUYlHQzuA/yI+9Rr6HyMN8+e 8CpbFR71WcjFZCO5VOyANQDIYXqtSXFaZQtrO7jbl3ih3GiGD0Fl/MmH1LdunhjNsz2L XySksmSwGz5PGYQO6pv0g+4T7ftkTSr4mhToXM3xxfAC0rvHJdQztPy/wy13atmgYMzv ApeQ== X-Forwarded-Encrypted: i=1; AJvYcCU2L2ueVekOZ7zkzZOc/DdIzyTUPVB+FgVdKrXFuSyEUdCkNAp7GqafVN4ckoA9bWEIKDYIv54Y2Uk=@lists.xenproject.org X-Gm-Message-State: AOJu0YzOQgC2pCXWPuPzcrYgheJrqK01vloJpCoIdVjXVOEDAcZdnjto mRFPCqcR/svm8/3aR2kw+6cqIce2CPYLLRHGXKrAnZ/eZtP+0ADqvGdLaiV1RQ/biZk= X-Gm-Gg: ASbGncv2LJ9yqlPCu21VYJw+gPGrK1CB6LMXNezDFKEU3RVlMiMvMlEUzQTw6C3jdLX TQMXxo3S/6JUALD6PURcTEKF7iB10wQBxewzokqqmcbvHZy1zwIv05cBREq017a3GYckXBzHxGt Kj6dcuiVVimBngimIjl9OuYrM/kguaBlrjkRY70ftQ4I7KPlYrnQ+g3xunwALOfKQaVgYP+9DDx VouVSJy/Ei3m2P950zlb8HW/p2Y9bW7AVN9fvDUixTurJTl+JlIqVzfq/M7YBTFET3VXgb72Y+q LF3oHW40a4kmSBAVCsVchYJn+YQ+4wLLx88NBE4HCeRMboVik2wMvQ4Efrnlww4NPcrDsc/Nlsy pMN3rRksr10us8wReYgYrjfjlrfUlYptEd7PaRn0evOb5d62rq+yhjblA68cYHy/TaADXNEHCT4 1BsDkwfDjnNYO7bVgNxOBB6JX6dFa86h4= X-Google-Smtp-Source: AGHT+IFpI3GL5cse+8n+ih1oF0AV0V9hqADSW+14D/yEjGe7vAb5o0N9WY3TIiFao6rN6HuitLNGGw== X-Received: by 2002:a05:6000:2089:b0:3eb:5245:7c1f with SMTP id ffacd0b85a97d-40e429c9c58mr19095049f8f.2.1759220494580; Tue, 30 Sep 2025 01:21:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 01/18] docs/devel/loads-stores: Stop mentioning cpu_physical_memory_write_rom() Date: Tue, 30 Sep 2025 10:21:08 +0200 Message-ID: <20250930082126.28618-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220532455116600 Update the documentation after commit 3c8133f9737 ("Rename cpu_physical_memory_write_rom() to address_space_write_rom()"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- docs/devel/loads-stores.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/loads-stores.rst b/docs/devel/loads-stores.rst index 9471bac8599..f9b565da57a 100644 --- a/docs/devel/loads-stores.rst +++ b/docs/devel/loads-stores.rst @@ -474,7 +474,7 @@ This function is intended for use by the GDB stub and s= imilar code. It takes a virtual address, converts it to a physical address via an MMU lookup using the current settings of the specified CPU, and then performs the access (using ``address_space_rw`` for -reads or ``cpu_physical_memory_write_rom`` for writes). +reads or ``address_space_write_rom`` for writes). This means that if the access is a write to a ROM then this function will modify the contents (whereas a normal guest CPU access would ignore the write attempt). --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220530; cv=none; d=zohomail.com; s=zohoarc; b=aamKeoktHSmlQwdxMwmDjheqONesrfRTKfUYDXhHBLUBZTFsNk1LYc3jdM9OUNfvFtSZEYeZHjlcOiZYxNDjrjEXXa3uTF5Bzt8B8MRBcw/zvkmVy8XHa3Oq4w/bErxoZQRfzF837fY7CnXNbgnWmlmQRipYn3ZbddavVaOmUzA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220530; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=g6Y+9YynyQUWZr+3xZXfGIWc6Jhbj4AT6sZ58oDn40Q=; b=EtaA9IAKoQD2GpN/3CBAFS4Bo2kZ35jjON66jTbBKi7MbCNgAj471Z2zP0H5Vu6ZFz3wI+1g/oZPN159QzUrYaykG/G3MLKpN0ki+Q/fktJI/LkcV/Pd/X5fAIBFRM0MW4c57rpPHhI2G409FRENd6V4HlGmF0kzg7pVzD8Vey4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220530820874.102759759386; Tue, 30 Sep 2025 01:22:10 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133830.1471889 (Exim 4.92) (envelope-from ) id 1v3VcE-0007aq-7D; Tue, 30 Sep 2025 08:21:42 +0000 Received: by outflank-mailman (output) from mailman id 1133830.1471889; Tue, 30 Sep 2025 08:21:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcE-0007ZJ-26; Tue, 30 Sep 2025 08:21:42 +0000 Received: by outflank-mailman (input) for mailman id 1133830; Tue, 30 Sep 2025 08:21:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcD-0007Nn-1f for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:21:41 +0000 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [2a00:1450:4864:20::442]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7da6eb91-9dd6-11f0-9d14-b5c5bf9af7f9; Tue, 30 Sep 2025 10:21:40 +0200 (CEST) Received: by mail-wr1-x442.google.com with SMTP id ffacd0b85a97d-3f44000626bso3412264f8f.3 for ; Tue, 30 Sep 2025 01:21:40 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb72fb1a3sm22070432f8f.10.2025.09.30.01.21.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:21:39 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7da6eb91-9dd6-11f0-9d14-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220500; x=1759825300; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g6Y+9YynyQUWZr+3xZXfGIWc6Jhbj4AT6sZ58oDn40Q=; b=Y+cM7YYeLTxfQkqKS2tGafYM6ACeJL+5PwfoYXtJvCjlfoIMGKEdpb3xw4rI9JfvwV TZhmcVCz0WZmFjmEs6HN31nEu60M9XrIFy7R4qiKpbfqfXU6abVQY7iqw5OnqqyKq/21 NiHL1x4v3rJEgbgJd1ErF0lOtTnq/3teCHJzgc23ZQUeo+ScJr8gSMUS35bfoL66L7Lx zlGU6s98FZtAAqNteP+H9LMFUDnSUGSDcrd7AARTQNqgce3V3VoLI3+zgrK+h2/kpQ7M /fmkR0OztvcIaMrEEqLNKg4XC1oj/2TXNgrq8CvAovUp/6gyrJZY2TkqEBi9aRajO+7I UR5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220500; x=1759825300; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g6Y+9YynyQUWZr+3xZXfGIWc6Jhbj4AT6sZ58oDn40Q=; b=cfdZ5eSGtrsGd3C6KuPMN6YFp8vGDVYqlPMFCsURDrG02rT4AaYNEfeWkoiUvGi8WG vlt0PNlFwvWIf5S6Ls5/sBe6mi1K6FUPtRYfKB9SDNBKIbISo4DwT58VUaWDnjhj7JKY PYlgO5meUqUPp5F9UGm3L+kqlvcozkyec5GKReWQSWlIuPykUpJBHZ2PrDHqK6zBqPzo 5ElwLLzFsA0wt+YiBbktKPYgIW8aorMBKZage8h6omyZXFy8/lR6clSMdQe34B3/odnX CXA6VoxKO24Ph/7LJV8eIg7lQRjaw2ta9taLarTHm90fNmFgeyyHFcBTBMoAXjIaWe4Y XBiQ== X-Forwarded-Encrypted: i=1; AJvYcCVGW2YeVGD+EV41LobJFQbX62997gaC619aPkNjtg2ESNoHZxGtD8/xNZ2PsD+eaXg5IGaP8+hwlUM=@lists.xenproject.org X-Gm-Message-State: AOJu0YzI8J7Y6SIWs0lZH/PLsEs7ZUqgyyfk/99OS6Ud8fChSeneB4aA e5JucdrWkjKDINdy5k0jg1SXhVGK1z6Ekw9ET6BEgEfjkiivBekCNwq1WbjloHdqEMo= X-Gm-Gg: ASbGncu+8Jqs9p41sZnKrwd2S2o12XvXk7a3bOGka0fUorY/aLnIaJ9kuwq5DPQvTog b5AQToqbKnw37nRYvO1bAc/mqdaKeYbZnp8cDCXpJ2Zswa/LbU93PIBWNWZfN3L3rjM8Qxa9EsG DIwhrjElIvFMjtyxQ5DkSVy3WJNI14Q5j8WNotllAnvfxg2wxqTG1p9jofruu6TOvtsvBzsI9IV cxlSk9ClOq3BqpEzGMGrmBMkx58HfMSLRIn7RPxyEbGqRTU5zI5/7cnLYWvKvQzBjWgSNXQb3j8 0iv0ZiXnKF+jIHeNmjrk2PqrzXSNn162utoIsqSZPrOOo59DEIUFunxZt8l2lVsWXYAiZ4gsgKZ cj9mO2Z0pq7xKO4/INKG3dugO70+LloQBUetLYzdbM8KBLqZY8pQAfhK2pKaMIkBex6tWFyLrNI yisFY7a+jr7we7jlRAqkxX X-Google-Smtp-Source: AGHT+IEvqZbVxTkOzuE7/OdSy85DpVZk0C8frEdFACso26c6+h9s7puUVSPKjShsswhtViU8Ba02iA== X-Received: by 2002:a05:6000:18a7:b0:3e9:d0a5:e436 with SMTP id ffacd0b85a97d-40e437371acmr19688375f8f.23.1759220499859; Tue, 30 Sep 2025 01:21:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 02/18] system/memory: Better describe @plen argument of flatview_translate() Date: Tue, 30 Sep 2025 10:21:09 +0200 Message-ID: <20250930082126.28618-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220532331116600 flatview_translate()'s @plen argument is output-only and can be NULL. When Xen is enabled, only update @plen_out when non-NULL. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- include/system/memory.h | 5 +++-- system/physmem.c | 9 +++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/include/system/memory.h b/include/system/memory.h index aa85fc27a10..3e5bf3ef05e 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2992,13 +2992,14 @@ IOMMUTLBEntry address_space_get_iotlb_entry(Address= Space *as, hwaddr addr, * @addr: address within that address space * @xlat: pointer to address within the returned memory region section's * #MemoryRegion. - * @len: pointer to length + * @plen_out: pointer to valid read/write length of the translated address. + * It can be @NULL when we don't care about it. * @is_write: indicates the transfer direction * @attrs: memory attributes */ MemoryRegion *flatview_translate(FlatView *fv, hwaddr addr, hwaddr *xlat, - hwaddr *len, bool is_write, + hwaddr *plen_out, bool is_write, MemTxAttrs attrs); =20 static inline MemoryRegion *address_space_translate(AddressSpace *as, diff --git a/system/physmem.c b/system/physmem.c index 8a8be3a80e2..86422f294e2 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -566,7 +566,7 @@ iotlb_fail: =20 /* Called from RCU critical section */ MemoryRegion *flatview_translate(FlatView *fv, hwaddr addr, hwaddr *xlat, - hwaddr *plen, bool is_write, + hwaddr *plen_out, bool is_write, MemTxAttrs attrs) { MemoryRegion *mr; @@ -574,13 +574,14 @@ MemoryRegion *flatview_translate(FlatView *fv, hwaddr= addr, hwaddr *xlat, AddressSpace *as =3D NULL; =20 /* This can be MMIO, so setup MMIO bit. */ - section =3D flatview_do_translate(fv, addr, xlat, plen, NULL, + section =3D flatview_do_translate(fv, addr, xlat, plen_out, NULL, is_write, true, &as, attrs); mr =3D section.mr; =20 - if (xen_enabled() && memory_access_is_direct(mr, is_write, attrs)) { + if (xen_enabled() && plen_out && memory_access_is_direct(mr, is_write, + attrs)) { hwaddr page =3D ((addr & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE) - a= ddr; - *plen =3D MIN(page, *plen); + *plen_out =3D MIN(page, *plen_out); } =20 return mr; --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220525; cv=none; d=zohomail.com; s=zohoarc; b=IgDNBhSrvVkHsFkFNNMBAHLBqOhEIwY2yNNepi35QxQc7JSJRnlWRj96e4ZMEcCoAXEDJUu/kXHiVJSL8xZsVCzoUZsn+S6TdQnCTk5GhZ60ABS3nrCHstk+uOgvF4+PcCAC9+r8tszvKvpC/JvLxgIQCwkVdt576lRoXojpIlc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220525; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uVuWODNllLBcWHkHdEzk+20qcWtQ6YA1oYWBzMhXpCQ=; b=cmK7izBZZVKetSKhQSFaHLjX6OLwZwlnDkxxPHU7ePWtaA2S4gVr3G6YK1lu9lVpMlsB6ltc25xW/OolDxiquYpb1UQoKY06DZI8ClxjmYiZRtTc4tnBzUjPiHusRt8SOFE9sQKYj9JEA1ODsemKs5LSHoYETgVUEPrZQjU/jeg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220525801895.174921105308; Tue, 30 Sep 2025 01:22:05 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133831.1471906 (Exim 4.92) (envelope-from ) id 1v3VcK-00087F-DR; Tue, 30 Sep 2025 08:21:48 +0000 Received: by outflank-mailman (output) from mailman id 1133831.1471906; Tue, 30 Sep 2025 08:21:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcK-000878-AP; Tue, 30 Sep 2025 08:21:48 +0000 Received: by outflank-mailman (input) for mailman id 1133831; Tue, 30 Sep 2025 08:21:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcI-0007Nn-Ee for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:21:46 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 80e55687-9dd6-11f0-9d14-b5c5bf9af7f9; Tue, 30 Sep 2025 10:21:46 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-46b303f7469so38468355e9.1 for ; Tue, 30 Sep 2025 01:21:45 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e5c3cad50sm8272675e9.3.2025.09.30.01.21.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:21:44 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80e55687-9dd6-11f0-9d14-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220505; x=1759825305; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uVuWODNllLBcWHkHdEzk+20qcWtQ6YA1oYWBzMhXpCQ=; b=oigqoUBh0Kir4Us1OzG1+OnIJdK5wmw/a9qhXj5kjyJCs5G9IlrhRS7vKrDoPU9wY8 Jj9jsGGShHfKuVNxLbokezI2AFcvbSdk8rhKLSNk8Ocf6E3QzAp005zVfg/Xqcpbofje c4CGAJZg6ny7f6U4Qe1D0RKc4KuiTv7pLHTWWoT7S9BHJTDT/xod+ijb81nfkRplWTJi IS3IXfmEH3tNY4d65xgPRQ7FAgZlKAjaDiyVJP1e2BWjuQqWwKuZfAbHSsrg6dn6T/cp UNUybVYx7CFroUn/mpiFaUtgj0aX4VvaJt6Z6lbhfwG+g6ZNQAVPO0tNT4o2MiVyr1jz KoUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220505; x=1759825305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uVuWODNllLBcWHkHdEzk+20qcWtQ6YA1oYWBzMhXpCQ=; b=OYAtEYRnmo7fdvvYR7y51kPqDt+uoBUaNvCSOpHyjqV0AcyX7OkgKyga3R/+dXIZT+ oIo/cVhyH9bqb7Dt/u+k5RPet7O+siosOpGWVd5B5LOi6EyNdwCJMtyHCTAyDZA+o9F/ 7tgFLyLitLCQTTjiC9ON7YekIeL4vDx1cKYUjCR5KTW7O5QKB1yYEX5PwQ2l9q2KboTP sf12InpHReMMRmI6nP0ErRDA1vtLMbcw8wu9U+O1Z2ozyNdFz1s8ZF22xwCKS9w95eoA Ib/c74mMONA3+Ul+HnIvHlohmkIrKN/kT7n8/UZc+ohNrdaiBX1yLLxzhcgGXMAkeMzR B+gw== X-Forwarded-Encrypted: i=1; AJvYcCUDrl7Ztkck6WStfB3tNw4AbmuXb3Cr+N/dogrVQj5lsoiE3edvsaST7+88MuSlZ3aj04o9MNPlBXI=@lists.xenproject.org X-Gm-Message-State: AOJu0YyJ5rYrOiS8i8GXCXxmtPlTfAKoeGa3wUcDM62HbvH0zkGOFH/0 JZkNKMaN86N3NimYiDXRArk/XVPuNO+gglQqEcrzRZ1sDfp2d5Ty8r09WfxOlklHd5c= X-Gm-Gg: ASbGncvEMZG92zz9unm7X0z5JVoEJ73Ani/vLBJPLWuyAClOvxxXrp6GlnwOGorplA7 D/7mxDGAR0LatTjrnuIOYiTQ8O5Rwa8Dwe3EFNqYf3fIRxPZE+mVgMA07Ukt2UQfdE1i6vmgOO/ dbjaxJm+PAprGvzeTL+vF4Ecz04/IyeCvK5yi8MO7zoUp7JrCPcEXjFMJE5m6HTXyCW+jGHmeRB DFguTgaMtyop+h0OGoXvQxsSODQgKQyW5n7c42MDGmdwDWBUaVGA9BKgRVbkJNlktODPMgUfBSy DSH28ZYjP/1i3kPhHfNnAGPvb0dMVSFHo3uMNeVbZ2xpELJtUUeSLhUBLHrVT8qyuXfcE7Af6iP S6JtQlRAlfrLOg2m+E1Hr5aTNC1KBeAZi++VeMhU0B52oW7NI7t4LIiReTXAy7TqgpPbY8s2XkK 2KI4E+l/d1MiMImt2UY/QuPRa3yV6+fZY= X-Google-Smtp-Source: AGHT+IEnN1+Dj0G5eE22oo/LVcWK6MF1t2TvnNSxkl29p00iMJks8dqgYIqx9W0IIiNQ+maQ1TKmXg== X-Received: by 2002:a05:600c:1e85:b0:45d:d5df:ab2d with SMTP id 5b1f17b1804b1-46e32a03456mr188255845e9.26.1759220505370; Tue, 30 Sep 2025 01:21:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 03/18] system/memory: Factor address_space_is_io() out Date: Tue, 30 Sep 2025 10:21:10 +0200 Message-ID: <20250930082126.28618-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220526254116600 Factor address_space_is_io() out of cpu_physical_memory_is_io(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- include/system/memory.h | 9 +++++++++ system/physmem.c | 21 ++++++++++++--------- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/include/system/memory.h b/include/system/memory.h index 3e5bf3ef05e..546c643961d 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -3030,6 +3030,15 @@ static inline MemoryRegion *address_space_translate(= AddressSpace *as, bool address_space_access_valid(AddressSpace *as, hwaddr addr, hwaddr len, bool is_write, MemTxAttrs attrs); =20 +/** + * address_space_is_io: check whether an guest physical addresses + * whithin an address space is I/O memory. + * + * @as: #AddressSpace to be accessed + * @addr: address within that address space + */ +bool address_space_is_io(AddressSpace *as, hwaddr addr); + /* address_space_map: map a physical memory region into a host virtual add= ress * * May map a subset of the requested range, given by and returned in @plen. diff --git a/system/physmem.c b/system/physmem.c index 86422f294e2..84d7754ccab 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3359,6 +3359,17 @@ bool address_space_access_valid(AddressSpace *as, hw= addr addr, return flatview_access_valid(fv, addr, len, is_write, attrs); } =20 +bool address_space_is_io(AddressSpace *as, hwaddr addr) +{ + MemoryRegion *mr; + + RCU_READ_LOCK_GUARD(); + mr =3D address_space_translate(as, addr, &addr, NULL, false, + MEMTXATTRS_UNSPECIFIED); + + return !(memory_region_is_ram(mr) || memory_region_is_romd(mr)); +} + static hwaddr flatview_extend_translation(FlatView *fv, hwaddr addr, hwaddr target_len, @@ -3755,15 +3766,7 @@ int cpu_memory_rw_debug(CPUState *cpu, vaddr addr, =20 bool cpu_physical_memory_is_io(hwaddr phys_addr) { - MemoryRegion*mr; - hwaddr l =3D 1; - - RCU_READ_LOCK_GUARD(); - mr =3D address_space_translate(&address_space_memory, - phys_addr, &phys_addr, &l, false, - MEMTXATTRS_UNSPECIFIED); - - return !(memory_region_is_ram(mr) || memory_region_is_romd(mr)); + return address_space_is_io(&address_space_memory, phys_addr); } =20 int qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque) --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220535; cv=none; d=zohomail.com; s=zohoarc; b=LT0w/OMVp+9s+OEDpgdAT62Qet3BrtrgGGdFq2ekBcK6L/4G6lY/FFgOI76oJsc01d8WpFehctIpp7jee0As2PVTepqd5xVp+k6qkqvZ2sydtL1gqaFKesOQe+sGKrCcHzmw6w8B/zxLHTqL/+/TMZ3KBXf4F9dGY7GI3Khxh+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220535; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jPaFfZE+Vm6W3t7QC31lKwf41cuqTfJ0BWTKMrsHvkU=; b=mpCGh994svC36wem+UxxGeZhQd0PvNwvB5VGeCOK1owQnOBVNVsxqg4OiPnR1V5PnalvNWAj1Rn1Y5wNCyzjeBaqQ8hscfUiDP8W6+h5tPfOq+GMuM03q+NLxraZVttgIzCRGnp+8iMYgEC2OTJgRRRBEx83YqCdW69DqMuF7nY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220535043517.7250757612951; Tue, 30 Sep 2025 01:22:15 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133834.1471915 (Exim 4.92) (envelope-from ) id 1v3VcP-0008U6-Km; Tue, 30 Sep 2025 08:21:53 +0000 Received: by outflank-mailman (output) from mailman id 1133834.1471915; Tue, 30 Sep 2025 08:21:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcP-0008Tv-Hx; Tue, 30 Sep 2025 08:21:53 +0000 Received: by outflank-mailman (input) for mailman id 1133834; Tue, 30 Sep 2025 08:21:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcN-0007Nn-QA for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:21:51 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 841659e9-9dd6-11f0-9d14-b5c5bf9af7f9; Tue, 30 Sep 2025 10:21:51 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3c68ac7e18aso3798086f8f.2 for ; Tue, 30 Sep 2025 01:21:51 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fc5602f15sm21609359f8f.39.2025.09.30.01.21.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:21:50 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 841659e9-9dd6-11f0-9d14-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220511; x=1759825311; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jPaFfZE+Vm6W3t7QC31lKwf41cuqTfJ0BWTKMrsHvkU=; b=mG0+b/VURtvrMm/lC9C4YR0fWETRSotoiXmjoEiR8HEpQfE0oGlzA6p34Yi1/fvw3T f8uBL3+UbGwfacsykLe82zJIZEGi76RE2352SNv3IFB1SkKTHaT+J10Tr+r6ijo1OXvp v1OjuWmO2aW0xCqayOsYgYl3R5JMCHbvuuQYNiwVN0N+BFkJCaG2CNHPEGi7zXssZ2jO eaVGyf7KBxfzQ/qwVefJletBVUZMr7jQLHWzXqhFDgFioV4JRdOerxaJ9+Aqk/gqBfKA kd4sof/eSGiAAlQrBWy9HFksct1Kj9sLGWK3iD9XmMu/MIT00dgA8jS9jYtf2qX8TPvX K2lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220511; x=1759825311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jPaFfZE+Vm6W3t7QC31lKwf41cuqTfJ0BWTKMrsHvkU=; b=VSFybwbKHWv65+0Vhk5LuvH2FtTbS4olcw4rvpeDl3F7PsN//157zZemEPNrIJ+2qt nkFCYC/prMeikmZd3Uz+11MfJieUFGY8sZmnjyV9+ZgBaxMLlVSDyngklOKDIEdDwZeR zF2MEQDvyGzcVLvEEyB46dCT2WmsfpCKOq1f98tfJU4FEw8NrQlmbksHM1Ty6OD4+RrL 7jSbCSmM9vZjW1yy+U9MGWj0p3kcWUXpNJVSZTIBYIeM23D9cGa5zdgKaI8RmGewRKLd XJ90v7BaLD9wfkUH7hh7rygSz3W9LDxxzeacAlomm3rfXB1w7d5Q2WLh05DnrBhQ1Prk u9YA== X-Forwarded-Encrypted: i=1; AJvYcCUeU1vVRWDgZ4WGJRpC36tR5Hu5vmlDIe38cF7BsfPBt5xawJmWisvA9ydQ2jSsEcV5bgz7CU2aCcM=@lists.xenproject.org X-Gm-Message-State: AOJu0YyDLp+pyETzZuOS/71cVhAiUNNPrMlkLdMeFeeqwx9k7L6xwWyh nEK5yMFa2DVVIK+MqX32y7qAVGV72VWajemB5YfTKGyCJdzFqeZ7gDVa4ZuUe3LoyHw= X-Gm-Gg: ASbGnct7/zH0guN24g3BI/v87zOHuRQkOlhbryG9ei5AKnI+Hh6wOthYJ6Dr/MhB+9H 5EqqanQBPa/CwuaVYCjOmAdKBVqRpx4scgFsQCIyz/mqCGHoLYG6TDzP3LUPPRwetutxZGR0yIR 9GQfHt46QPP+MhlgJTIexw5fNAbV7xUt1Ypa6altSjP8JAgFPnh6jktM5nXcBnQI3pyoe+QxAbu tAzekf9fpDI9LfVKzcWrgVXkr/fefb4mPtRIcxPFeE1iIdVxn++5Fx0z6GLtZWHtZzvZL2+SV4x DgSSYUY26xEYEakG4PEilKoStWBH/Xb53AVReoVGpQzl2GEBz6LJJLMULpFBFbwXJ0MJjqzJfxo zO1XWKgvdvfnSDgH+6TnPWUVCr/lXaJ889n9ss3wIaIDcPxLUsglufIgJdbYx8Laz0W8l1HW6bC hyrSUtWRX/weBxo7xTr02u X-Google-Smtp-Source: AGHT+IEB8eNGO8ibaj4OUUkCL1Gk/lot4nZRiwg5YPnw3XMPBC9mULq1peqy0gUd0OsdrauuTBslPQ== X-Received: by 2002:a05:6000:2511:b0:3d8:3eca:a978 with SMTP id ffacd0b85a97d-40e44682229mr16305754f8f.21.1759220510700; Tue, 30 Sep 2025 01:21:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 04/18] target/i386/arch_memory_mapping: Use address_space_memory_is_io() Date: Tue, 30 Sep 2025 10:21:11 +0200 Message-ID: <20250930082126.28618-5-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220536410116601 Since all functions have an address space argument, it is trivial to replace cpu_physical_memory_is_io() by address_space_memory_is_io(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/arch_memory_mapping.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/i386/arch_memory_mapping.c b/target/i386/arch_memory_ma= pping.c index a2398c21732..560f4689abc 100644 --- a/target/i386/arch_memory_mapping.c +++ b/target/i386/arch_memory_mapping.c @@ -35,7 +35,7 @@ static void walk_pte(MemoryMappingList *list, AddressSpac= e *as, } =20 start_paddr =3D (pte & ~0xfff) & ~(0x1ULL << 63); - if (cpu_physical_memory_is_io(start_paddr)) { + if (address_space_is_io(as, start_paddr)) { /* I/O region */ continue; } @@ -65,7 +65,7 @@ static void walk_pte2(MemoryMappingList *list, AddressSpa= ce *as, } =20 start_paddr =3D pte & ~0xfff; - if (cpu_physical_memory_is_io(start_paddr)) { + if (address_space_is_io(as, start_paddr)) { /* I/O region */ continue; } @@ -100,7 +100,7 @@ static void walk_pde(MemoryMappingList *list, AddressSp= ace *as, if (pde & PG_PSE_MASK) { /* 2 MB page */ start_paddr =3D (pde & ~0x1fffff) & ~(0x1ULL << 63); - if (cpu_physical_memory_is_io(start_paddr)) { + if (address_space_is_io(as, start_paddr)) { /* I/O region */ continue; } @@ -142,7 +142,7 @@ static void walk_pde2(MemoryMappingList *list, AddressS= pace *as, */ high_paddr =3D ((hwaddr)(pde & 0x1fe000) << 19); start_paddr =3D (pde & ~0x3fffff) | high_paddr; - if (cpu_physical_memory_is_io(start_paddr)) { + if (address_space_is_io(as, start_paddr)) { /* I/O region */ continue; } @@ -203,7 +203,7 @@ static void walk_pdpe(MemoryMappingList *list, AddressS= pace *as, if (pdpe & PG_PSE_MASK) { /* 1 GB page */ start_paddr =3D (pdpe & ~0x3fffffff) & ~(0x1ULL << 63); - if (cpu_physical_memory_is_io(start_paddr)) { + if (address_space_is_io(as, start_paddr)) { /* I/O region */ continue; } --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220535; cv=none; d=zohomail.com; s=zohoarc; b=Kc9U9CdAXb8r2mitj++ukHvda6wlMa+nJzvtorOpofwf3pxW8XSvRfirpTF5QrBKFLC8VHXNTYawUOID4h7Cf+Mqz+VXhaNtOd28cQnKGF42mCZLeDAPa3qGNXYfZD2ymadQ4b9nPAMYwGPlA8xFeZkBu5qpGWASxpTTSFQpVtE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220535; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TmN6KZRBDFIwLcWnEVDqbz1WHRvv8u+lRYP5Aq5aiQ8=; b=f4flvOoRILsB3hBXqwbUJd7q/pWfmIxisZQsNRsPUID5IkbbODgHT1w0kTWfgKOO411LPEAs0OB/enL29sMxRTT7Nu4iXpGNGbPsjQV/FfqWcEfZ4clU59WKOrF36o71tGSJGmoZRgKT6/FT3cqO81P+vvAAXFbalMgjw+ityVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17592205354051021.3852109036264; Tue, 30 Sep 2025 01:22:15 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133841.1471926 (Exim 4.92) (envelope-from ) id 1v3VcT-0000Qv-Ub; Tue, 30 Sep 2025 08:21:57 +0000 Received: by outflank-mailman (output) from mailman id 1133841.1471926; Tue, 30 Sep 2025 08:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcT-0000Qk-Qb; Tue, 30 Sep 2025 08:21:57 +0000 Received: by outflank-mailman (input) for mailman id 1133841; Tue, 30 Sep 2025 08:21:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcT-0007Nn-4t for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:21:57 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 87494397-9dd6-11f0-9d14-b5c5bf9af7f9; Tue, 30 Sep 2025 10:21:56 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-46e2e6a708fso36248755e9.0 for ; Tue, 30 Sep 2025 01:21:56 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e56f65290sm44620345e9.13.2025.09.30.01.21.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:21:55 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87494397-9dd6-11f0-9d14-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220516; x=1759825316; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TmN6KZRBDFIwLcWnEVDqbz1WHRvv8u+lRYP5Aq5aiQ8=; b=Ae14vR7/JPhbxTl8racrKMnzXpba7ajvr0ekXTb9hzMu4IctZDkBAOr6vRYPyBStn7 47wbUiYVrPugbEaK4Qpc6m5MAJfwmnE/nOLyRpdG/3jFJOLS8LNTRIfsfC1Ou4aIYVtj sgwySGDNSYT3NMv2ZDQHoYasUiMflZ4X5GUe8thvEJP0SI6jk3wXDZ2FeT8BErCTRKJt KMb7Yzgze+sbJBjQj5HItt/Vm5Asb8tFfZFbbwH7M2xP8+e+QQvu2AewEg+FEFQw174C wVwZMVKcAcc6I0Fe8f/OMeDFKOn2mbWmDBMRTE8fFkPcMNLgjcRqyszD+uVD2i8B8+Ip MD9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220516; x=1759825316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TmN6KZRBDFIwLcWnEVDqbz1WHRvv8u+lRYP5Aq5aiQ8=; b=HurSdeEQGng3G27bjnGZcysbVyYcK4K1ToxuTWDzlQ6L/wQcj+1+rv6A9KAVMQGrtL e6/vF0a9mhh73xK/EtJIzQN3BefQ426/j/jL8ZShFWQ6fUh4EML6KcoPuUOq7RW8LXcd mUld6Ww2I3C1beUw19Mp5KHbwGuOhyruZKSdPikRo2rya3W81N4nwcHp8ij3xWyDPFwd +RSGECghc+kbqieVhf2ztb8ktzs1tNVRj5oEgHfc0R6d8YQ4FmNpEjkw1ODUOONeUejN yeIVoMUUloBRw1Ft2qtjhNFOrOW85ro6mnAM1o+GEFDY2KAMIELz2/6INuTFmtfzetWu ZJnA== X-Forwarded-Encrypted: i=1; AJvYcCXef4yNFiHpnBikLdU9BIn5IF8jBRoE0gQ+rinmFIQW27L9+6bYgV14d9hdqZD+HzLHZCofcvaDF7E=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzyje0AmrYxRaW5hX4G5S7I0E7ggomSn5tlm3H9zvu0zX24eiBc F3P+Z3v0aMG1qC2aa1Btbkchl/PqG/6fJgzPTmD10Og3qQ5RlxeO/ddGbus0704eTZ4= X-Gm-Gg: ASbGncuqJbH7wkXq01IPPqCc5mqd1a3x4msKHq6ngeUo0OUClqdbc8DQ5LxTm3d9spR GWr05sMC9qbPpf39DxbPgNDdQIGMKWFm6A4VT1E8xayXu5SfUiykyWRZsB+GltYg8wmLh46HIs/ 702yhq9iPzhV8WLOrbV4larqQGsd/sJiCfzDZDHlmhmEnb8dvCVRyXTTyX1QFCpJyqo5Qr84IZM xwYoxKl/FJpvyiEnwA9tLRrd+m9Jlu3gq+0KWFQJp7B3aso9RKsaEOwa51J9Iq2HIaw9/JsAjEr 8Cnj0wG5D7IJNde/WBf1ILDob7gAiCvVZmM/5vzMiLbNUBeZbjSsvsCRnPlflSHkdf4pD6o5iA3 Apd8s+68XM6PxHvL+yd87WDkxDYjRXvgKeZjAXSciECbMYwVdfmmfyjrP/nNLxpSqBcUFQDY641 g7VSAhkwt4Af/7uM608en7z9vQz7/Fcno= X-Google-Smtp-Source: AGHT+IFRoVQqdg8pFriDfOKg6AJHeYajBA5OHZoOOnjeKEw77YQUzMpfQKsIByPubJl8mIXC2txRhQ== X-Received: by 2002:a05:600c:8b16:b0:468:7f92:5a80 with SMTP id 5b1f17b1804b1-46e329fbd2bmr146354195e9.27.1759220516099; Tue, 30 Sep 2025 01:21:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 05/18] hw/s390x/sclp: Use address_space_memory_is_io() in sclp_service_call() Date: Tue, 30 Sep 2025 10:21:12 +0200 Message-ID: <20250930082126.28618-6-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220536380116600 When cpu_address_space_init() isn't called during vCPU creation, its single address space is the global &address_space_memory. As s390x boards don't call cpu_address_space_init(), cpu_get_address_space(CPU(cpu), 0) returns &address_space_memory. We can then replace cpu_physical_memory_is_io() by the semantically equivalent address_space_memory_is_io() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/s390x/sclp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 9718564fa42..f507b36cd91 100644 --- a/hw/s390x/sclp.c +++ b/hw/s390x/sclp.c @@ -16,6 +16,7 @@ #include "qemu/units.h" #include "qapi/error.h" #include "hw/boards.h" +#include "system/memory.h" #include "hw/s390x/sclp.h" #include "hw/s390x/event-facility.h" #include "hw/s390x/s390-pci-bus.h" @@ -301,6 +302,7 @@ int sclp_service_call(S390CPU *cpu, uint64_t sccb, uint= 32_t code) CPUS390XState *env =3D &cpu->env; SCLPDevice *sclp =3D get_sclp_device(); SCLPDeviceClass *sclp_c =3D SCLP_GET_CLASS(sclp); + AddressSpace *as =3D cpu_get_address_space(CPU(cpu), 0); SCCBHeader header; g_autofree SCCB *work_sccb =3D NULL; =20 @@ -308,7 +310,7 @@ int sclp_service_call(S390CPU *cpu, uint64_t sccb, uint= 32_t code) if (env->psw.mask & PSW_MASK_PSTATE) { return -PGM_PRIVILEGED; } - if (cpu_physical_memory_is_io(sccb)) { + if (address_space_is_io(as, sccb)) { return -PGM_ADDRESSING; } if ((sccb & ~0x1fffUL) =3D=3D 0 || (sccb & ~0x1fffUL) =3D=3D env->psa --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220543; cv=none; d=zohomail.com; s=zohoarc; b=b8LqUWZLq8kTYtISG4lsx5OqBLN5TOvY8euljFD0hJJTcKuy6e7KFMC92zLQtJLU1yzai6zfbX7oWl2n8ieHLXdOuWcGiJQYHmaKvf5kA3vscEh7Cd8Phg1OyTa5oTxrIRxJszWcrlTVHliYAXMQTy8Ek60y3wAa07J2rT4Yt1M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220543; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rlQqoXg6at6m3NCWUmLz6YxBYJSCTlYqTL2bdBtbhz0=; b=FbeZvvx6++9fTQpm8bSRADr6H91/aYy5moVymEh9pGmcFTodklfbPtSR/pFX3p338RnB0QE4ldmMM2elcnkNCNcYHh/D2CcHpbAt6v93jc7wBACUgsfdWp27f/U57I83gYfPNKRejfRILe0h+jFmIef43uZPEOiYJ6pI7lXi5kI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220543764532.4745213575719; Tue, 30 Sep 2025 01:22:23 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133853.1471937 (Exim 4.92) (envelope-from ) id 1v3Vcb-00017z-G0; Tue, 30 Sep 2025 08:22:05 +0000 Received: by outflank-mailman (output) from mailman id 1133853.1471937; Tue, 30 Sep 2025 08:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vcb-000171-AY; Tue, 30 Sep 2025 08:22:05 +0000 Received: by outflank-mailman (input) for mailman id 1133853; Tue, 30 Sep 2025 08:22:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VcZ-0007Nm-OK for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:22:03 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a696d84-9dd6-11f0-9809-7dc792cee155; Tue, 30 Sep 2025 10:22:02 +0200 (CEST) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3f0ae439b56so3302790f8f.3 for ; Tue, 30 Sep 2025 01:22:02 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fac4a5e41sm22972926f8f.0.2025.09.30.01.22.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:01 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a696d84-9dd6-11f0-9809-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220521; x=1759825321; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rlQqoXg6at6m3NCWUmLz6YxBYJSCTlYqTL2bdBtbhz0=; b=aCqALJArECxjIi6VpSWLtjAGn5iXR3I1ZRNnK1fFpf4L45np3+8XqigkkzuUHn3hW0 zA8J9tOT+IHFBf8DN9ynl5hjEaYTypeu7lywEKt+vqH+/HnTfloKIa2oLa+3nfH2qPbB ynL5Ejl7A/sfvAWbFWimwzqwBkEfq7XzMp9WVUdZzwHGgebT8MzqS8EK6xpAsFvb5bBz elGwurk2TQOvsnMGhCFJVPgJSTvWsyS7+ABbCV9lCxA83oLvf85+EbGJPCfdBqjCz5Tw Y1gulr6LmnctvlTOkAY5XvyBxt4f0mFZPIy9PKMM6O32Q+BtWXsqFzrgKNSU52QoepU3 33bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220521; x=1759825321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rlQqoXg6at6m3NCWUmLz6YxBYJSCTlYqTL2bdBtbhz0=; b=JX+1vkdiYpbHAcYpTr9XxetBjG/h9Ftoci3IXN3PABs263H1iOBpWlP9VlQ8xk/EBy lpofyhzb3tNGueeeL1k6K5e8rj9/tX0MqpKgsBNjqfciQ9WtzY0XgDngUSdojiOa2hlL rE4azQxYXLVTMSgMCTF9q9LAqqOnVud4r5ICcyhAKkF6MEAq0YVO9OgwkU5T4jXz5eJz MI4UnrUfIfk2qrdRHf6A4VGj+gDPlNXNW07XI01SRPTWvSAIV2yLwdi5CbnhATrN480Q 4wHwJMPQy4Z/i2huxMyl1Yhmx7KIyZz+wx+FrV1g3bTyygvSv+nRe6IGIAYRXbbf+kwt IY/A== X-Forwarded-Encrypted: i=1; AJvYcCWGCDgmZ5XzgRYzmvdrJNypjS1awIOJon68Ary30c4+EpCFwqXuiPi0JSmz912HEkO+u96vTg8bho0=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxl+Xu7+K05/5Egxq2Ut+0J7WHl9ZzaCtu2jNv+wUCtFU8x+1mP 7soNy80xuLrYU9Fn9kMe8Vku8XBfsIuEw3iHxh7bUokb5qMip3d6nDgyNbk22U5hBr0= X-Gm-Gg: ASbGncvSc5AkQqtWNdvYprZarT4PWP2qp/OZXOfomd1aMIFysQVJNqT+moiAinqVfJG e++i48BwVUK+n6go5C73r69rxKOXnTC6eyi81Wk/gS0IdzkHvdnmUMEigbjn3FM9rd0jQe8xE1j o8+H1PCP2/3z5a2OYASTe3TDMWrZUzlyTM9rsJygpY8XcWGLd0ZSh1U375f3CPxN8hh5faoSE/U /uTK/sJo45+tWhM55NmI1/FDCJXtOvcgbp3WJ7GqVVfRjBC6aurdyl6pHnu0q7DeiXABbQo4a5/ yKGz0AnWwaKMw29otjRhY+LkkbnxfWA0jZxIY+xj1aZFJswIXnIO/WPUU7OyOT4cSS6+Hw8TWlM SxYk2qFQnprXA1u3p7+/q08jD4eU3cv/2mBE67PrIikThWD2CPL7G2lTK2lDztADp/twrlLmui3 EIRHTguzGXZurpBcKFE+9A8V1MhDmJ72Y= X-Google-Smtp-Source: AGHT+IGxp9mmy7B4YaVXtK8axEEppjEFlOJUhOlUxG1XXBFZ2PBviuJyAi3OzbI29QHLpWomSM6JGg== X-Received: by 2002:a05:6000:22c2:b0:3e7:ff32:1ab with SMTP id ffacd0b85a97d-40e4b294f33mr14571301f8f.50.1759220521460; Tue, 30 Sep 2025 01:22:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 06/18] system/physmem: Remove cpu_physical_memory_is_io() Date: Tue, 30 Sep 2025 10:21:13 +0200 Message-ID: <20250930082126.28618-7-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220544559116600 There are no more uses of the legacy cpu_physical_memory_is_io() method. Remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/exec/cpu-common.h | 2 -- system/physmem.c | 5 ----- 2 files changed, 7 deletions(-) diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index e413d8b3079..a73463a7038 100644 --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -149,8 +149,6 @@ void *cpu_physical_memory_map(hwaddr addr, void cpu_physical_memory_unmap(void *buffer, hwaddr len, bool is_write, hwaddr access_len); =20 -bool cpu_physical_memory_is_io(hwaddr phys_addr); - /* Coalesced MMIO regions are areas where write operations can be reordere= d. * This usually implies that write operations are side-effect free. This = allows * batching which can make a major impact on performance when using diff --git a/system/physmem.c b/system/physmem.c index 84d7754ccab..dff8bd5bab7 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3764,11 +3764,6 @@ int cpu_memory_rw_debug(CPUState *cpu, vaddr addr, return 0; } =20 -bool cpu_physical_memory_is_io(hwaddr phys_addr) -{ - return address_space_is_io(&address_space_memory, phys_addr); -} - int qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque) { RAMBlock *block; --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220543; cv=none; d=zohomail.com; s=zohoarc; b=GIiow6UpfOeXwBxqwQqxB1mWlYgJ7mr/qwFDeoPz+BAYy/0V3TcjgF11YeEF3JtK2abXndY9S88KwVnjWQ9nZ+UXuF8Lj0lNqbfTw41Pr7OfXH7eOko4dwPmqPdqDunikxNi9+0n0HG87R624wrMzFanfPK6WuOnfV9qWAVGEbc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220543; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YkYmQo8nriy/yGfh4HWmKxNmJbyJBkEcEbiWP0BNxvs=; b=Kl/NadyP5ftQeMouruudtNxtXfVXgD+unxUN1WM4g0t/Ovtm1qA00/t0KdX9VoPQBOnFc97wlNbhervQv02okPK59Y+gGYpjVk+wOHFZ0GqIOotQ3HNOJALb+lMqBN0y0HI6rnxKlmQoDZJgcLGug51dsxSngPdyz2scnRpfq1Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220543675748.979260503334; Tue, 30 Sep 2025 01:22:23 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133866.1471946 (Exim 4.92) (envelope-from ) id 1v3Vch-0001nz-Mp; Tue, 30 Sep 2025 08:22:11 +0000 Received: by outflank-mailman (output) from mailman id 1133866.1471946; Tue, 30 Sep 2025 08:22:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vch-0001nq-H3; Tue, 30 Sep 2025 08:22:11 +0000 Received: by outflank-mailman (input) for mailman id 1133866; Tue, 30 Sep 2025 08:22:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vcg-0007Nm-31 for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:22:10 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8dabc4a3-9dd6-11f0-9809-7dc792cee155; Tue, 30 Sep 2025 10:22:07 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3ee64bc6b90so3554851f8f.0 for ; Tue, 30 Sep 2025 01:22:07 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fc6921bcfsm23056408f8f.43.2025.09.30.01.22.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:06 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8dabc4a3-9dd6-11f0-9809-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220527; x=1759825327; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YkYmQo8nriy/yGfh4HWmKxNmJbyJBkEcEbiWP0BNxvs=; b=dNxCbGWbONCGtrKZUodXj6K1M4g6+5J8ZprI9GH3rCZ5/GIsijAuZsw4hEuF/2olLF q0UeB8RsY9hYrG/wJa2DomCym4XFYDvkLx34/1Ecv746CNTuNWv8xqR6WM/uKeCMogo8 fDSO/1ku1HsBGjVdToADxNVB2ATJG8YDyaSUXCZ9fIzC9QMEiXCv4VkNloQ1jS2UX1gn 5AoBoyS+63azvRpM6IGdzbGAX/SzUpBlFWtAo7RHWGtDHG1AhQocV1PLfsT9JFC0zvWC Ow3c0IhX1Bnt1Jxds33/dbKYkoTDJSV+BRnHadouZE6DLheIFzdd1GSYn7gQPJGVdaRx kL5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220527; x=1759825327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YkYmQo8nriy/yGfh4HWmKxNmJbyJBkEcEbiWP0BNxvs=; b=FhGyJVtNv9By/IgE/ASKWJR7J889IZ4SBGV/JRu/pcO3we7tyPu7BtlcVWWAgMu/5Z vbcje32pnfZPYJvBOqunlk52JF4Ywg4HtzJe9gs7W1kmhtgS+9JvHnbbEo7Og3ToDC2D D2T4+8/nhfLiDUjEzjOkj0wAjJ1p1LlBJ1vRMiVcfzpR2OF4xEDAKZoa10Yp5K2yzpcg Qg7NZUEbk3mo2ElIkuHeilkqjv75YA1N3eHkfT5zWiKrVHSaKl+ToK3JDT8eKtlHX/B7 /6hnmpkdk8FyNerdyzub4BlBXiAzb8W1B3FpivpMDWZR1Z8X7fJdtgcXbSe6c7+gaEpL NKgw== X-Forwarded-Encrypted: i=1; AJvYcCV99CW27X1yQxYWx93zXMQRfMf1s298X8yWzXM2hc5LgXbi1xfXuwW2k6mDhROKk02RIOy3tCiD5C8=@lists.xenproject.org X-Gm-Message-State: AOJu0YyDP0h8/ue4iYI7JVchzkL7RzF9y6FIS/f9ddF09KdUolVTN+Fi s724Uk0gOgv3BPbRN4Er2Fyy/9DPUyq2cb5Y5FmiHuPoKJmXgpgrKwtyjVGumCpsG7E= X-Gm-Gg: ASbGncstcq66Ve8yge6MhsvBKuVHL9AL+jdQMOhCkCswD+UCRBdqp8iYPkhrqKQ/6w3 i/czrNnzZLgnsiEbVx9/faMtHbhqDJ01tgnFa10061All+WIbjJe5QdHvums6BfVW1zaPnrfmQN v6Ce4h1O6zjkrFCECa/eDrljKC+3/ALwEiaPv8BqeJQ5FlZ6CT9/nqrOD49JrBCkNfxXqY7tMM+ JAFpo0xGGNBDOS5zwzqifA2nTcKAr8w+VzJfAqhd27MUUEQYOSRPOgNb0kgUkYzcmtlWK07fqf2 SYTXDpxeJBVADyVxmpDDUKwfqhOnXoJZF9OZ/tjiKKwPORQ93ysYCI5rL6PbqysOx3O6/kezZBA ChSeEzhsSUpjKQkTZPS1CehZwj6qvhhm2Y7XYCd7rQfBzaVo6UoUqUnW041JOa1EOy/2ucj5sXD joXfyvHf0kfE0mSO9yqXHOc4OCK4/Dg61M8t0CpjbmqQ== X-Google-Smtp-Source: AGHT+IHzRQHYpgb/DyIfYTEXGiArYWqeYdxWvyGmM8w8s+84+M4R5T3PN9QeVLlNgQQ0W4P8WfSxtg== X-Received: by 2002:a05:6000:26c9:b0:3d2:9cbf:5b73 with SMTP id ffacd0b85a97d-40e46515110mr15910423f8f.6.1759220526791; Tue, 30 Sep 2025 01:22:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 07/18] system/physmem: Pass address space argument to cpu_flush_icache_range() Date: Tue, 30 Sep 2025 10:21:14 +0200 Message-ID: <20250930082126.28618-8-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220544555116600 Rename cpu_flush_icache_range() as address_space_flush_icache_range(), passing an address space by argument. The single caller, rom_reset(), already operates on an address space. Use it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/exec/cpu-common.h | 2 -- include/system/memory.h | 2 ++ hw/core/loader.c | 2 +- system/physmem.c | 5 ++--- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index a73463a7038..6c7d84aacb4 100644 --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -156,8 +156,6 @@ void cpu_physical_memory_unmap(void *buffer, hwaddr len, */ void qemu_flush_coalesced_mmio_buffer(void); =20 -void cpu_flush_icache_range(hwaddr start, hwaddr len); - typedef int (RAMBlockIterFunc)(RAMBlock *rb, void *opaque); =20 int qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque); diff --git a/include/system/memory.h b/include/system/memory.h index 546c643961d..dfea90c4d6b 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2977,6 +2977,8 @@ void address_space_cache_invalidate(MemoryRegionCache= *cache, */ void address_space_cache_destroy(MemoryRegionCache *cache); =20 +void address_space_flush_icache_range(AddressSpace *as, hwaddr addr, hwadd= r len); + /* address_space_get_iotlb_entry: translate an address into an IOTLB * entry. Should be called from an RCU critical section. */ diff --git a/hw/core/loader.c b/hw/core/loader.c index 524af6f14a0..477661a0255 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -1242,7 +1242,7 @@ static void rom_reset(void *unused) * that the instruction cache for that new region is clear, so tha= t the * CPU definitely fetches its instructions from the just written d= ata. */ - cpu_flush_icache_range(rom->addr, rom->datasize); + address_space_flush_icache_range(rom->as, rom->addr, rom->datasize= ); =20 trace_loader_write_rom(rom->name, rom->addr, rom->datasize, rom->i= srom); } diff --git a/system/physmem.c b/system/physmem.c index dff8bd5bab7..e0c2962251a 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3215,7 +3215,7 @@ MemTxResult address_space_write_rom(AddressSpace *as,= hwaddr addr, return MEMTX_OK; } =20 -void cpu_flush_icache_range(hwaddr addr, hwaddr len) +void address_space_flush_icache_range(AddressSpace *as, hwaddr addr, hwadd= r len) { /* * This function should do the same thing as an icache flush that was @@ -3230,8 +3230,7 @@ void cpu_flush_icache_range(hwaddr addr, hwaddr len) RCU_READ_LOCK_GUARD(); while (len > 0) { hwaddr addr1, l =3D len; - MemoryRegion *mr =3D address_space_translate(&address_space_memory, - addr, &addr1, &l, true, + MemoryRegion *mr =3D address_space_translate(as, addr, &addr1, &l,= true, MEMTXATTRS_UNSPECIFIED); =20 if (!memory_region_supports_direct_access(mr)) { --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220800; cv=none; d=zohomail.com; s=zohoarc; b=GOdjwabxIRdta3w97S7+2h8uYqzmgJFfn7qMgbjW5FfZr+e0PzZBeA1pS1PHC15PntWcGmdodMED0Fxie7+giKY75lFyaQR25Gvnpl/Yczm9NOmDc5OLTePVdy1dGINR6oFYQFHvQog56SOs+BBFOoxFPeJMOAEh7molpjN0b+0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220800; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8QFdShgwZbpOIuoiHkRuMdwMlUbV145lKXZsf/3KvUE=; b=fCejE/qsRidmFanGdzKp6FedX6C9W3NNIxlR3KKaDQ78RatM+WKUniO7TKgTTPXVwDxqi5tyQx8qc7dQLTp+Npv7UmxvNRhP5YI5t1LG7+xyj0OX9gQ16aiwCA18lE+6duFGyuOlF3aX5LNhQsaIfW2aQc7TPBH9HYOkT9gUVuQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220800462691.3608229594158; Tue, 30 Sep 2025 01:26:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133949.1472056 (Exim 4.92) (envelope-from ) id 1v3Vgh-0006oC-3O; Tue, 30 Sep 2025 08:26:19 +0000 Received: by outflank-mailman (output) from mailman id 1133949.1472056; Tue, 30 Sep 2025 08:26:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vgg-0006md-Oq; Tue, 30 Sep 2025 08:26:18 +0000 Received: by outflank-mailman (input) for mailman id 1133949; Tue, 30 Sep 2025 08:26:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vcp-0007Nm-41 for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:22:19 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9155b3cd-9dd6-11f0-9809-7dc792cee155; Tue, 30 Sep 2025 10:22:13 +0200 (CEST) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-46e42deffa8so47193365e9.0 for ; Tue, 30 Sep 2025 01:22:13 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e5c4dd9e4sm7814745e9.10.2025.09.30.01.22.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:12 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9155b3cd-9dd6-11f0-9809-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220533; x=1759825333; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8QFdShgwZbpOIuoiHkRuMdwMlUbV145lKXZsf/3KvUE=; b=NwL/kfbewah3Lc3tgY1eciku0lX97KGreL8vii1VmWd+3/wr5tbA3vMa3MEEMnaS85 e0WubKOQd+WLTQJo4FiXgfXrCVMxF8k/H6watxUHGs1hlkvlP0DDDtJfZx0KnNxDgry+ bB36RWaPNhddA3B/wsmQa24/ZYUgIDBFI9xDMqmCZormiM+N6yXoxbjmvZUoHOdhk7tB h5O27zG4WV9zvTYScm/e039cR8mkAbGbdhRxbDBANH8pmBkqPW3MWi1jDFer4b9QbJER wNpkVr08A9qGS2npRTMxRT7r/KrUeFvhMJxIiCsM5ojw8xU8IPpoLxv49jSvXOIsMvn3 yYFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220533; x=1759825333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8QFdShgwZbpOIuoiHkRuMdwMlUbV145lKXZsf/3KvUE=; b=GHXYC6gUFzT7epSqBppbosRcIVcrln4y2mULVqo+32e7FGe23ufOBfnBlgSEPA9tIH 8wCydvawdmS59kZQURyQ1yrvUTZsLVC51Z7Wxn8cpt6fU6Qh1Qk4AIMPX1f7ffHHXPBk 2L7aUwDKA3c3neQdbp523MLvvii60QX+8pavRiSNgqO5bgDa4anh3jvGfWfqbZ+FumES BKwgNmze56orL++tCGdEEt0Q9v881dScL6InIY/RUCbJK2sOfB+Vt2uDghD+5RKeS2Ld EgK2ELpRBM9MF91yaI0maDOCuVAVFVQSeCLskKAgU5TyKeJ4Rth/v871pI6/XI/mUZ5M dFrw== X-Forwarded-Encrypted: i=1; AJvYcCVyXmjfdCCCRFSAn6hE03WBOZ+sAZU5rHi0iIPbChKovpTKyfthzHkF9Q42EL2LM8eU4B/zdfWuntY=@lists.xenproject.org X-Gm-Message-State: AOJu0YzgUHDumzU5jVTAJmXOiPR48b8U+HA4r2I1SEIORDlHiCviqhkt M/xs4HqNWWygNjQ5ZFX7G8IhwLQC5yaiEsatbf82OaTJMZdT0BhNN7mQYqW//z4RF1Y= X-Gm-Gg: ASbGncvP8fM8ssERGyOpLQ/mZZEDVq6ZogpV5Q5O3r3b9RHcllAvzeTMMrXyKMWMJhr WfEhMEFqZUPeAHBkN7pgGH9odzTSsizA6qkfjTQFVRaXs8/pHCX5LzYfvQS0zezJXwWRTbVk8RM 6JHAqdf1pF8g9LhMIipDYL6scFrQLp5qXQJd8TE7RsgG70pAFcFeadpCnlWyY8IrIt7OnW6emp7 Z/878Hiydra80Du+kW9X0OrjDmf9cfnS5SodAoZAc0pximqBIy2IByL3gGfJlcoi7oOobEFCgic X7B/3XrfzYACTQZJYy+j8yIydPuQaSNZpSn8eTQ/KzV7REKdHCfbm5wXe/P8X78t1alNqpTSXsK RxEbH3xFadtf45o+96DbEWEOAm6CiNFSc992GLpXGntF5wjVzzBGWdB0A1URXC7B/h7HE4MLgGV gpvndQeBjDTLi25Le1UwiinNJFlAr7tRCPvDcORFWlFw== X-Google-Smtp-Source: AGHT+IGBMYpWSXfOX3el6uig3+R7ujcKxPeYiLaNhqcFnuUIbzB/w07fZP+NVrmJYAyBxxupmR40fA== X-Received: by 2002:a05:600c:1d14:b0:46e:432f:32ab with SMTP id 5b1f17b1804b1-46e432f395cmr126597005e9.33.1759220532938; Tue, 30 Sep 2025 01:22:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 08/18] hw/s390x/sclp: Replace [cpu_physical_memory -> address_space]_r/w() Date: Tue, 30 Sep 2025 10:21:15 +0200 Message-ID: <20250930082126.28618-9-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220801993116600 cpu_physical_memory_read() and cpu_physical_memory_write() are legacy (see commit b7ecba0f6f6), replace by address_space_read() and address_space_write(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/s390x/sclp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index f507b36cd91..152c773d1b4 100644 --- a/hw/s390x/sclp.c +++ b/hw/s390x/sclp.c @@ -319,7 +319,8 @@ int sclp_service_call(S390CPU *cpu, uint64_t sccb, uint= 32_t code) } =20 /* the header contains the actual length of the sccb */ - cpu_physical_memory_read(sccb, &header, sizeof(SCCBHeader)); + address_space_read(as, sccb, MEMTXATTRS_UNSPECIFIED, + &header, sizeof(SCCBHeader)); =20 /* Valid sccb sizes */ if (be16_to_cpu(header.length) < sizeof(SCCBHeader)) { @@ -332,7 +333,8 @@ int sclp_service_call(S390CPU *cpu, uint64_t sccb, uint= 32_t code) * the host has checked the values */ work_sccb =3D g_malloc0(be16_to_cpu(header.length)); - cpu_physical_memory_read(sccb, work_sccb, be16_to_cpu(header.length)); + address_space_read(as, sccb, MEMTXATTRS_UNSPECIFIED, + work_sccb, be16_to_cpu(header.length)); =20 if (!sclp_command_code_valid(code)) { work_sccb->h.response_code =3D cpu_to_be16(SCLP_RC_INVALID_SCLP_CO= MMAND); @@ -346,8 +348,8 @@ int sclp_service_call(S390CPU *cpu, uint64_t sccb, uint= 32_t code) =20 sclp_c->execute(sclp, work_sccb, code); out_write: - cpu_physical_memory_write(sccb, work_sccb, - be16_to_cpu(work_sccb->h.length)); + address_space_write(as, sccb, MEMTXATTRS_UNSPECIFIED, + work_sccb, be16_to_cpu(header.length)); =20 sclp_c->service_interrupt(sclp, sccb); =20 --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220789; cv=none; d=zohomail.com; s=zohoarc; b=dxaQpBtuipYpJ8ESibnBBFOEOsLd/v2fz6xf+N2zFYV4mDp3v6Y/xLJx+g4eOO9XCvqG+OtRn3Ee+22KbvbAsRgOPcmV1JAcYKSbp4Yy1QO9K4y51iGdwTvOgEl8KjvLlkXZz036lBNC+d27Y3UecCA8550aO6z/dSuoYRV6whA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220789; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2kEeDKj/VliAI89NHWLpYrYcoI7vlOg/a8aX+CJnHKA=; b=b+/yjAHhU9d/HtwKMz9Q/jwF2KtsmNIZiWkd3/ad1z2jxpZ8vFOVtIkuYX34brRKept0lfczcB22jUnZLd+UxdThaJ2IfRKXl7TP/6dVmTfspAn1HHhtfXHwLWTXFFbSiBtDMLxcPaYoG7mGvngjXfM6jCgiL9sWE2/YdANQ46k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220789551598.726397913126; Tue, 30 Sep 2025 01:26:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133941.1472046 (Exim 4.92) (envelope-from ) id 1v3Vge-0006I0-8u; Tue, 30 Sep 2025 08:26:16 +0000 Received: by outflank-mailman (output) from mailman id 1133941.1472046; Tue, 30 Sep 2025 08:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vge-0006Ho-4c; Tue, 30 Sep 2025 08:26:16 +0000 Received: by outflank-mailman (input) for mailman id 1133941; Tue, 30 Sep 2025 08:26:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vcr-0007Nm-4e for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:22:21 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94701ed8-9dd6-11f0-9809-7dc792cee155; Tue, 30 Sep 2025 10:22:18 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-46e4f2696bdso31581035e9.0 for ; Tue, 30 Sep 2025 01:22:18 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb871c811sm21599810f8f.15.2025.09.30.01.22.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:17 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94701ed8-9dd6-11f0-9809-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220538; x=1759825338; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2kEeDKj/VliAI89NHWLpYrYcoI7vlOg/a8aX+CJnHKA=; b=lfW1GHFZ4K9+Z1nAe/QhLaTxvPBOdoWoMTno6KJZ856BGI7l6BZN4JFDNMm5OQMmWX txsEpl9yGsmbUzNFLq+6XwgnHH2UsmxIZabAbMD5kIC0SelSJA3fNtri1KJhiYqnKnEi +QCga/eDtKe3ePKGNFGSK99/3xCzI8SqkcfJJxx1DiJItfaxT2Xl0LMoB3deOImNdeft /xOe9JzDppZO2p/z3DHZ+TR71hXV1HFDR2uFWV1BAo1pR7Obgh6zHy4yjkFx715Le8mH 1SbU7Xe5uelKS2ca7jlp2txHW4gKCzjfxCGR2gzzUHDTAqt1JpjdlyzSIVrZs/BN87/J PTvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220538; x=1759825338; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2kEeDKj/VliAI89NHWLpYrYcoI7vlOg/a8aX+CJnHKA=; b=iPgrQ0UCminCcA1C+hxRd8fEtCB/JU7OghTy0sk4r+gO2Gx+AkRhsv6hW2It8mEVpt 0iJ+P6lb/ywrO80O+jkbSwbno8HlXsjeOm9XXFN3TCmbc/MX0pEQpqXZVP0TySCy7X2B D2pnrWdSgJEWg/A/+TDirJINpBHruK+oJYyuKwVuq1sd2z9N6gaWjKU0HXmPZNlGLe1S Zt06jffrFSGDH0EpB6DikmrONPzo0TV4IWai0W8BABoCyGyapO4mBpFG6HYoahlA/npc qPF8wR1DrwD/2bFeTHv8PxrqxS4XPvvXFBISD1Je44OneqdMHOeYbukRhZJi5b0/fv6w 9QQA== X-Forwarded-Encrypted: i=1; AJvYcCUj7/JpQhjpBOkDY/wW9V9kRgxaHx5l/P2ZVvs73VsMLjgBbGqnJ+ltitLyEBRPoCmaY3C5xzEz4mE=@lists.xenproject.org X-Gm-Message-State: AOJu0YxQ1PiERUF82uNfuX6WqQOsvUHXshWtCNgNwkFohWs7OeINB/Bk mpK5n+X/Ucw8ktGz+jbJ7ZSUNinAFZYwhQHE1RQm0nHHpj7X77LffNmNuPGvZqjeXfE= X-Gm-Gg: ASbGncvP0t24frZENPnJaDaSwwxuCifqjmDjWzpZSD9GQwEF0kA/R6e+lT82t7ZG9mZ rLnX7KnWUm62YzG1xcTqHEQg+BNSLf+6Un9bWeHfI4KCrCC+C4Cpl3FazCDBm4TGRKfMC8x2GyP 7X4fvkGnkdTtgmeQttJuJfGk2fNO/CHzZeuHte8YZyAQrcWJHOLNUnl1NZIqFXn2RYSG6jSakSO D7n4P4bAT1dkxn64PR8F9LjUWlL6rztiWyYdL6FsaiOnE1QLZi1KsAEmf+6lh53PFKQX1icsihx q0jk9fPcFkZt+MDuQwJQUvZLXvl7rlYOvwtECyMxXfebHmudxR6G9/tOiK3Fa51qC2SmI6I7tA7 amn/8+oM5c6K9uksinxPNaQUU7k3dqt6/IQuAl2u5gcC2Uhe0+6Fn07pwmt3lxaZjEuh/PjqBUs uExphBK835+IZ74D9HI0qECu5xQnlV0PQ= X-Google-Smtp-Source: AGHT+IE8kOnIri7d9kIT89vkssg0QjxuyhNQyNkBu4zqQAFaAaCY/pGZVE1XfJtvAVhQrg/vBoJaIA== X-Received: by 2002:a05:600c:1386:b0:46e:1b89:77f1 with SMTP id 5b1f17b1804b1-46e329e28f8mr169270875e9.9.1759220538270; Tue, 30 Sep 2025 01:22:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 09/18] target/s390x/mmu: Replace [cpu_physical_memory -> address_space]_rw() Date: Tue, 30 Sep 2025 10:21:16 +0200 Message-ID: <20250930082126.28618-10-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220790039116600 When cpu_address_space_init() isn't called during vCPU creation, its single address space is the global &address_space_memory. As s390x boards don't call cpu_address_space_init(), cpu_get_address_space(CPU(cpu), 0) returns &address_space_memory. We can then replace cpu_physical_memory_rw() by the semantically equivalent address_space_rw() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- target/s390x/mmu_helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 00946e9c0fe..4e2f31dc763 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -23,6 +23,7 @@ #include "kvm/kvm_s390x.h" #include "system/kvm.h" #include "system/tcg.h" +#include "system/memory.h" #include "exec/page-protection.h" #include "exec/target_page.h" #include "hw/hw.h" @@ -522,6 +523,7 @@ int s390_cpu_pv_mem_rw(S390CPU *cpu, unsigned int offse= t, void *hostbuf, int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *host= buf, int len, bool is_write) { + AddressSpace *as =3D cpu_get_address_space(CPU(cpu), 0); int currlen, nr_pages, i; target_ulong *pages; uint64_t tec; @@ -545,8 +547,8 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uin= t8_t ar, void *hostbuf, /* Copy data by stepping through the area page by page */ for (i =3D 0; i < nr_pages; i++) { currlen =3D MIN(len, TARGET_PAGE_SIZE - (laddr % TARGET_PAGE_S= IZE)); - cpu_physical_memory_rw(pages[i] | (laddr & ~TARGET_PAGE_MASK), - hostbuf, currlen, is_write); + address_space_rw(as, pages[i] | (laddr & ~TARGET_PAGE_MASK), + MEMTXATTRS_UNSPECIFIED, hostbuf, currlen, is_= write); laddr +=3D currlen; hostbuf +=3D currlen; len -=3D currlen; --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220677; cv=none; d=zohomail.com; s=zohoarc; b=LM22oEHzqrzSxvtnJsxMx6RiidtUpoBe7NZta4N8RPCoGspU1wQAI0NJuU6w4QDizFEi9DSfw89cQ6f3jhlnOOyyqcMCCyGTI9YIdAJeJMaiwbXf7WXsfHqAelIT5tRVUc0/6HM7+d9WIL/5qsgY4b9yP/DJdQNRwz7dMrsq/tI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220677; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DbEYNZgIU6LqvkF49qge8kIj2C3i6K2S813tsyxbWwg=; b=N2FS64Hsv4kGB1Qx6n1Fp9sBFEAR3fVIp2oN7LndRDfACLgRwLSP8oAsaHMXfS1p4+fZXBmR4vMbCxMPS1CAx6qX/tua6KgMMZjmVPZG+tE5XBGWMZE//f/C1B/Ie93Y6g/GfDgoOeXOviBv4Szf1eHFC65w7Tx9FJVyslqyJMo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759220677322333.52451794693525; Tue, 30 Sep 2025 01:24:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VeF-0000dM-EL; Tue, 30 Sep 2025 04:23:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3Vdx-0000Nf-RX for qemu-devel@nongnu.org; Tue, 30 Sep 2025 04:23:35 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v3Vd1-000138-6n for qemu-devel@nongnu.org; Tue, 30 Sep 2025 04:23:11 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-46e384dfde0so57979025e9.2 for ; Tue, 30 Sep 2025 01:22:25 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2ab31e97sm259738545e9.14.2025.09.30.01.22.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220544; x=1759825344; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DbEYNZgIU6LqvkF49qge8kIj2C3i6K2S813tsyxbWwg=; b=S9B/JSOT6cQ0bUUtvtegSZls5Elu4+Y3uDHtJypldq/v2AtHDO5BB5dzQ1Dv8WeBG2 GonIzetgG5kiI41qpVfl7oEzJ7uYi48LNTy1wWDdJhzzhkerEeje0ra6PmJoXZfgiTVC LL6xfiQEVdJh5yfRN5mlHeS9svYB/4VGRh/MXdW79RMFQwArqMTkvhngNMxkBWDWVgxU qbLz99YebYsgI8ItEsFM4Q5lgafi6M56cQUV0Hx2w4ckuBeBenBP8B2sWAGPfPuAOOL6 fFxfX80b3wi14aVDoO227Hd86q1Z25LudgH8asgok9z0FwO1FRxjYxlkW5HjPBr++sPv mcrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220544; x=1759825344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DbEYNZgIU6LqvkF49qge8kIj2C3i6K2S813tsyxbWwg=; b=TwtwwspyvCWigo8ex+12IWdXIOzryppQbLQUVV0G7hUVpBk8L+7c5HXUDbwSOlRHKJ QBqvT09ssFcNezS9uhuW0Ukoain7nxJZsov6jflpOXS3nw7Zo6LNp9AJWwRZuon70bgy bO1buQtQ1DTTSIBRZ5oGj+hGzMUJlUGzIdLT89gR5MnW6gLn40CpWC6/QHOKJldjw75Q e+Uyy1cccc0JfhOuScTZrJf/zHeIoOXWfkJneQxcekmAIBMrSM+tmnz7341jYIFKNB+1 dcGpf+G7DS515H4UrF8I00a+PwVg5GR2+AU20sLWO4mXq0OKvZRHHw8jJ9/767yyjMg1 OwLA== X-Gm-Message-State: AOJu0YwhINuDVDqsUKazj35ltUYEYRHH78kppzRnLB6G2FuIyKoPyOHT 6gDLkHIaIryVK9chBqX+QsPXdOLGV5b+31hYg3wp4nrTDyOiuNyjUa8JJ/KuFNMw9FIOcFc8AT2 L1f85XpO3Pw== X-Gm-Gg: ASbGnctA/2imjOwbPx+iJxSOBB4nPIqygTYX25kzn87gcW2iccDbkzlQS/SlAn7+U/D 85YCj/BFYkLRdtFOhwhuS5h8TvuQAS1QacLCW0aQxvoeATZ5HWOvMdABX/5kJ8UGR+xIB1Z3V/T udB4cmbywk8nyMVsQbF9aKuI/s/VGB+PNcPlq7fv2AFLhBu9f79NEOhfELAEn9T/nVJ8O2L+u2G 3aZh+b4zIFtuiHAVArS0trDaYFVJh+cbwIk6vaQPzgf38krW1I4rGPB7bB/cSQy/iY+WhI4sdMC Pu5QiM+CIp6HJNWdtNnOqmjIRzAIW04fl+sPd/O94mPEwQIGhX5OdqgLeh4S/WUf4t2jAa4gWbR uWipm64jE3xXfuUIZ9BUT973G81TeZMj2Kbx5SV5UPqRdykwo60RjLmBJl1pQlhysc/QiBNMdGE 3VG6+dRyHCxCRb73HZkkMBltp6kgE5Kbg= X-Google-Smtp-Source: AGHT+IHMDbDhZ1qtfUqSvwy3OGcigy6OI6LXsB/syBvCuQ6w6sDdxi+R3qorHEXGNas+XOrL9i5DRg== X-Received: by 2002:a05:600c:4fca:b0:46e:4ac4:b7b8 with SMTP id 5b1f17b1804b1-46e4ac4ba51mr119307915e9.25.1759220543603; Tue, 30 Sep 2025 01:22:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 10/18] target/i386/whpx: Replace legacy cpu_physical_memory_rw() call Date: Tue, 30 Sep 2025 10:21:17 +0200 Message-ID: <20250930082126.28618-11-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220678432116600 Get the vCPU address space and convert the legacy cpu_physical_memory_rw() by address_space_rw(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/whpx/whpx-all.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 2a85168ed51..82ba177c4a5 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -788,8 +788,11 @@ static HRESULT CALLBACK whpx_emu_mmio_callback( void *ctx, WHV_EMULATOR_MEMORY_ACCESS_INFO *ma) { - cpu_physical_memory_rw(ma->GpaAddress, ma->Data, ma->AccessSize, - ma->Direction); + CPUState *cpu =3D (CPUState *)ctx; + AddressSpace *as =3D cpu_addressspace(cs, MEMTXATTRS_UNSPECIFIED); + + address_space_rw(as, ma->GpaAddress, MEMTXATTRS_UNSPECIFIED, + ma->Data, ma->AccessSize, ma->Direction); return S_OK; } =20 --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220760; cv=none; d=zohomail.com; s=zohoarc; b=OQh4yzUw2QgewRfRKsqA/f+gJtDeGH7PfoOr2CTXdMQ2DwDWifLZ1VgFsgRAjcdLMFfGsVHehp9gCJVe/O85sRqVZwqH+ZPLr9VYtsj5pitlq+wKX3Ez+QOqchUtE4e7Z3Oj/8vnJrSd9vNQ+3Ys8K+tcnn9AKq6QpwET7S7O3k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220760; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=onCfEhinWarPReSMP2g+nvBYz1NYywUR3fuXcFIYVYM=; b=I14UDNe0lcczlZ+pVNrCfYrRlPjeFTmU7aRnoiNUvI44e/KeFWYUlGWqoszELL9vlN88S4CuytX4TU3rtAsIyiPTj7vR8sv09goqsNg3Eo75sko09YOzFBD/WR+dwgWtFO3DlXywpTeGeK6OgJQv5gvZOIKGnG839wDOjf5OI3U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759220760332679.5043869571174; Tue, 30 Sep 2025 01:26:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VeE-0000dL-AK; Tue, 30 Sep 2025 04:23:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3Vdw-0000NY-Rl for qemu-devel@nongnu.org; Tue, 30 Sep 2025 04:23:35 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v3Vd9-000149-0a for qemu-devel@nongnu.org; Tue, 30 Sep 2025 04:23:20 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-414f48bd785so3014681f8f.1 for ; Tue, 30 Sep 2025 01:22:33 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e572683ccsm47008715e9.22.2025.09.30.01.22.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220549; x=1759825349; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=onCfEhinWarPReSMP2g+nvBYz1NYywUR3fuXcFIYVYM=; b=i4tQgF7hYrGuZ60RQAURVSNyvx0BrFL2D6boTJfPkWQ1J27F2P0dDbb0amjvHG92l6 cuqr3thBOuZsoUqT7COVg0+FwO/dYy+athglfxg8DLMdcA/RsO59DndYeTvTeeW5Xs5t 3P7KT+jpvzgzcjJo5jLfNwoE0WJvn+1K2waINscKD9wFIiTkJQIJLU3jjylFgXTOgxwu zPbRXFrDrdYGhcWdFCVVVuMemgkg2wQ5ntYmDeRfOnXhwCErV8SaFF+G0g+Tn1dym8q+ enjR4aLVaqq/wjlzRDSUrcF9tlnhvIafjN8AnOuOT//58bUbQCsO7jF/zBUzBip02JsG X3fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220549; x=1759825349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=onCfEhinWarPReSMP2g+nvBYz1NYywUR3fuXcFIYVYM=; b=Z9o1MX0caoSpv2sSfHBcWfm1dmATeU07nsX4jt+VMO3k32KeEAg7OUkzUZ7qcHdUSN aG2TKLmuTphkSZxD43u/VF8/J07OmzDp9ECubeacBrb9j5TK6L46H0ZcNY7SutV9Jhkb SGJ2uo05QvC+oAAvKLTxGnpCsEQt6IC7YLSgyymi8vMCa0n9IamCiQPuk9QZRoq2o20o nkzRTmmWaG2L3hPWZo6NKlgzovup41z3Tq2J0W+CN21xgEWX/qC5U+EBrV5Vhq1pqGqf qZGXhbJNqcBF8vQOa5QgcmveB75dcxtfQXLzvBewx3Wgp5kV5kMIrdGp8/og3vOmpCxe S+JQ== X-Gm-Message-State: AOJu0Yx8YS81yeGZJflNTFme9TitnX2dCYht2jgnLScRaPI044c2TxHR sA0W9plFfQfjM8S9DPfTyBtNw1F/LdvBrf+N6WOoq3kAuP7l7K7CLqK+Wx+ZGw/zgZXKgAs0ZZE fZ/uKiyQbBA== X-Gm-Gg: ASbGncsqH+GyGg496RoFxeeb8S+4gxjnNozJW0IZFsLQiWUjJ4djDOEJCoLgVEuoXpi dxoxqLh/07MGfbVC0DvL8XtHQzIywgTJZ+DBwhXNauz8BOunVYOM1KFrNkyCYUJRBUOnB60t/iE omxlsjAS5oEnbUIHcF4WHoPgCwg6Ow+PMJfuiaX7NInCWcCxoDvcLQDjN09BdvGLfkz+Ze+4zrM anONEb3at1ST5OqRavJtoekjobU2nFQhVruv4c4R1MYcDCSPtV5fkAoMKV9Wd7DWYMjuaZs/y3T UA5YOr+LZZ1wGdhPXK+hdN8wWK19gO/cf6MB6q90Y0YsuqvRM4ulTWFtI40Pd/uZCRxhgu9uLj2 P7FgqryuyfC56UEGnXufLpNyMoFi6sefRi/TkNhzZaIOYb9mDdcMhKKlpB+m1Bd+StPbUpPhCpK /00m0YFMVnuP0JJedhok1rMpiaiM+tBYY= X-Google-Smtp-Source: AGHT+IGEB7zt4QY7wj3rTZFjv9pmOMXqLorCZDEnNJaXiQGRhxTkEhGFSRSSrKDdM5xt6JNSxZxslA== X-Received: by 2002:a05:6000:18a7:b0:3e9:d0a5:e436 with SMTP id ffacd0b85a97d-40e437371acmr19690967f8f.23.1759220549024; Tue, 30 Sep 2025 01:22:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 11/18] target/i386/kvm: Replace legacy cpu_physical_memory_rw() call Date: Tue, 30 Sep 2025 10:21:18 +0200 Message-ID: <20250930082126.28618-12-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220761595116600 Get the vCPU address space and convert the legacy cpu_physical_memory_rw() by address_space_rw(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/kvm/xen-emu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/i386/kvm/xen-emu.c b/target/i386/kvm/xen-emu.c index 284c5ef6f68..52de0198343 100644 --- a/target/i386/kvm/xen-emu.c +++ b/target/i386/kvm/xen-emu.c @@ -21,6 +21,7 @@ #include "system/address-spaces.h" #include "xen-emu.h" #include "trace.h" +#include "system/memory.h" #include "system/runstate.h" =20 #include "hw/pci/msi.h" @@ -75,6 +76,7 @@ static bool kvm_gva_to_gpa(CPUState *cs, uint64_t gva, ui= nt64_t *gpa, static int kvm_gva_rw(CPUState *cs, uint64_t gva, void *_buf, size_t sz, bool is_write) { + AddressSpace *as =3D cpu_addressspace(cs, MEMTXATTRS_UNSPECIFIED); uint8_t *buf =3D (uint8_t *)_buf; uint64_t gpa; size_t len; @@ -87,7 +89,7 @@ static int kvm_gva_rw(CPUState *cs, uint64_t gva, void *_= buf, size_t sz, len =3D sz; } =20 - cpu_physical_memory_rw(gpa, buf, len, is_write); + address_space_rw(as, gpa, MEMTXATTRS_UNSPECIFIED, buf, len, is_wri= te); =20 buf +=3D len; sz -=3D len; --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220798; cv=none; d=zohomail.com; s=zohoarc; b=ZlXEMfa7+QtOw44UtGoX+BjLcUy0xom0lwO5ooBT7l0f1ge74fhU4e/BNiCYMvB9/T4lgiotvQZaYwC/LwEfC6nkNJzu0LMN5kc67PUXY/W7hmyPUEoO94cA9q1p/Ihyp7psbnByNc/BSEAhC+xe2kCGeiRXRpRYkDqn+/WZvrU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220798; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QtU1C0M8U0OTbHcI2E95ZD2Zrsmz5/OESKETD6NudSM=; b=Hx32TVNJ4S3wtlb0aiFCHozqEyASy4nCaVl1ga4eild8Fmp3CiJxcDBlHjdd9uSlzAC0H8uK0nw9fmDnCL2JtkSG7nm5qjbuIT9sAZGu2fMvsQ1uWxNu0jceZ7AD1e8XwgWXsw324UyQVD8kq3MdyMhIBieF/jhSL0Y73UcQ4Ac= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220798102712.485707858481; Tue, 30 Sep 2025 01:26:38 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133960.1472066 (Exim 4.92) (envelope-from ) id 1v3Vgj-0007OP-RN; Tue, 30 Sep 2025 08:26:21 +0000 Received: by outflank-mailman (output) from mailman id 1133960.1472066; Tue, 30 Sep 2025 08:26:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vgj-0007Nx-HG; Tue, 30 Sep 2025 08:26:21 +0000 Received: by outflank-mailman (input) for mailman id 1133960; Tue, 30 Sep 2025 08:26:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vd6-0007Nm-Jl for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:22:36 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9e04926c-9dd6-11f0-9809-7dc792cee155; Tue, 30 Sep 2025 10:22:34 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-46e52279279so14718645e9.3 for ; Tue, 30 Sep 2025 01:22:34 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb74e46bcsm21775814f8f.8.2025.09.30.01.22.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:33 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e04926c-9dd6-11f0-9809-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220554; x=1759825354; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QtU1C0M8U0OTbHcI2E95ZD2Zrsmz5/OESKETD6NudSM=; b=btkaxKle6qF/ovKjiGQ9wY2p1NyTjGlhcKZIT4HUSFB/5stuQuAyytPlWH0PNgC2tG va+MiOuTIc8vyLC3B4xqPTeIrOBNoNt3Rfx6pqfgswmp1uGQ9lE7tlU1QDPKWkVgRJEX G+lA7yo8oKD786ssLnijCzOC9loxrH303xJ6IpMeCV9Jo1yoF6M2LG29mwQ67e9aNDiN 0Kfe+sjdNqtLScP5S62urALa63yemJdsXX6d7S58vJnTquaT2BnZdsKfwKpJfr7EGLhE 2Ck6D9klD++sTnPzcdjiYmDcftYZgAlth8Y7o7sFvNA0nY3AafUB5kXtc9v6BToHZrgn wVHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220554; x=1759825354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QtU1C0M8U0OTbHcI2E95ZD2Zrsmz5/OESKETD6NudSM=; b=w7sfMN5PK2kGGVaQXYZ1PQrMVk0SLkVFs4sNLMRrcRDcN/TiyHkECQDlxR8dieBpPS QJoEoVMlL0Ei5Ak/lBzyQIdkaAaBbgfnWISXADQx+xIUrLjriAxA45Rk1qhznWGt6wE+ ZcV79pbOxKuspF1Jao3gK24qbSzQ/uZwqkaBFggs1kkUedKJkH1WwYoXOhl8ja+C6QaS rF2OSyQRZ3foOKgrQzZriVTzMlzjIxATo0SXSnYtKqxC9caRiHfAMwM6GFwgi4PY1qG0 ZKmOyjmHtxXWNT07zZPdwBcV06h6YpOe4/dhFeDYZUANPdZ3N13Yb6DUmYnueNl34buw NUjg== X-Forwarded-Encrypted: i=1; AJvYcCWQn7J6DUALMXcm6QD2Ik4ZDLbg4DqelREFSX0Qxo+3iqBCWT4FFaMINs18+mq7Khfn7MYOluyPlOk=@lists.xenproject.org X-Gm-Message-State: AOJu0YzvIEW1Ma5rylneO3MrGMwkDhoZgMRl/m+kzXUvyd80RvCmVt+p Odqt7cyFeCpIQH+bUi/Xn2SF5hV08UbYd4eKSIZLuxKw3ThELy9AbB5j1ubewXE8W1stb3eNacl 4sFkgzExZDA== X-Gm-Gg: ASbGncurI1V6BDtisA0J6nO+ZUC+Bj++zeIXBrH0/wK/el5V567M7sJKstd3CAivmhR xhD42bJDp4MTijAVB+FXXSrqEkzyp52n+ek4QnUsHQ76CO5qJblx+mzHUPqF9NCjxg9XsLegzyB lCg2mB0WcR45mOgu1As3xQ1YVAqCfm6DoUi3/UqQ/IOXvpAMlLtu8Ib3QhQ27ifwOJE8TGjC6Gp JDKYESC8xFx3jIgq8G/j39tLLkbotrXW3TSE7RQEhDFzb8fVWWjvZcRH0Cxm6sz49V3kJEFgwL7 iGZcntjiDAY9s3eYTJcww0BTNB1FOwCPEAkP/ayDe4Gc8ESmD8pYatR3MaegypQXMCYM7yezhWq gCIHtLxYe9VRdEneFSnOC42Iu5QG4imihPWIdNrtcdrT8Ou8rd+75tGcWEypjbP6baBeLFC1yJs b3rTBB6QmIEIuU6HoDlPmQkDq2DvPZMgU= X-Google-Smtp-Source: AGHT+IHFPJkofYr79h9pu+6ONde86qKMR3dCMR8GX+HG+gEgb0uWvZOFxlaIJxTQ7PTY8pGPvnTorQ== X-Received: by 2002:a05:600c:81e:b0:46e:1a14:a81b with SMTP id 5b1f17b1804b1-46e32a1a396mr111982275e9.36.1759220554357; Tue, 30 Sep 2025 01:22:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 12/18] target/i386/nvmm: Inline cpu_physical_memory_rw() in nvmm_mem_callback Date: Tue, 30 Sep 2025 10:21:19 +0200 Message-ID: <20250930082126.28618-13-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220799951116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/nvmm/nvmm-all.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index ed424251673..2e442baf4b7 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -15,6 +15,7 @@ #include "accel/accel-ops.h" #include "system/nvmm.h" #include "system/cpus.h" +#include "system/memory.h" #include "system/runstate.h" #include "qemu/main-loop.h" #include "qemu/error-report.h" @@ -516,7 +517,9 @@ nvmm_io_callback(struct nvmm_io *io) static void nvmm_mem_callback(struct nvmm_mem *mem) { - cpu_physical_memory_rw(mem->gpa, mem->data, mem->size, mem->write); + /* TODO: Get CPUState via mem->vcpu? */ + address_space_rw(&address_space_memory, mem->gpa, MEMTXATTRS_UNSPECIFI= ED, + mem->data, mem->size, mem->write); =20 /* Needed, otherwise infinite loop. */ current_cpu->vcpu_dirty =3D false; --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220793; cv=none; d=zohomail.com; s=zohoarc; b=hEuLvqmm8ijFXfMDnLw+1jwjPQnWd0szTrH6EGyGOV3QdxS/6aXkTwmFPwimxuTv+eWNiCx0dvAVZPfOiN1jUuJusnpDYTl3PyTeWGyhErwZYGr0+sLtqMI82eYDr5eVnaDMJkAr4kA2MSl2pClGLyaK7d90fPwwpldquMJT9Cc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220793; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=U9bErLRqv9kjbdzs2kwz9FzL8C8SAPMQ12Esuz3D9Fo=; b=PD1DSoGcA0oO6I2MHElq3km9Xh0vyG9NHiJn1j+/dnHKcc122CcmgdY9Yn1rQvUtLQStVjHengFEsngWYK9X+9UEorDl8Gp1YDe8B/D129yqcMpG5eo/W5YhTisOzytFUDJfz9pm76V/8FD4Ggx4rYtZ2JkMr1fv1hkctbfiGLg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220793711102.01088444126947; Tue, 30 Sep 2025 01:26:33 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133930.1472033 (Exim 4.92) (envelope-from ) id 1v3Vgb-0005ps-Vk; Tue, 30 Sep 2025 08:26:13 +0000 Received: by outflank-mailman (output) from mailman id 1133930.1472033; Tue, 30 Sep 2025 08:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vgb-0005pc-PB; Tue, 30 Sep 2025 08:26:13 +0000 Received: by outflank-mailman (input) for mailman id 1133930; Tue, 30 Sep 2025 08:26:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VdB-0007Nn-Kt for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:22:41 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a1971d11-9dd6-11f0-9d14-b5c5bf9af7f9; Tue, 30 Sep 2025 10:22:40 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3ecde0be34eso3285326f8f.1 for ; Tue, 30 Sep 2025 01:22:40 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2ab4897bsm257449245e9.17.2025.09.30.01.22.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:39 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1971d11-9dd6-11f0-9d14-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220560; x=1759825360; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U9bErLRqv9kjbdzs2kwz9FzL8C8SAPMQ12Esuz3D9Fo=; b=EEHPjFd5YP/c1It0p0gAQmYOFqqn6Yici7VxcUYzqFhfKEn2b5XrzE952uEr8fk/lU wvznNQJcxYgiVbM/2nDu5jMyLmjuHxS20DA1JEy8/L02IWvmlSkmvrPrAFuGDt3F5W3B Pm6sYbmCg2GFNqIV6+Wy02uDGrEB/y8Vlq+LnUNhR6B7+ojbpPmYrbZbRSQDA/kKQHCz 5vjrQy0xFhQJTihxk7Mh4cwVATDiGxLtEnp4k931QkmYEu0LkaGRn53oD5AeDa+k7XGu Qf3GD99p3oRVo56QI9GoU+humhq9yqcs8I3OUfHMRWY+88k1cpnj574MFdxDW5Ci0MNx EsNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220560; x=1759825360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U9bErLRqv9kjbdzs2kwz9FzL8C8SAPMQ12Esuz3D9Fo=; b=f31LaguS1YrW957NZGHZ4s1BwYROyP7456b+xKif3Estb/rINHDzDV3BvohB0ifby1 jfaf7iNcsEyskcvy+V9tLXtfld8T6RwB3PkMucDu7HJ2n4dCGfenAvgtaO2gBebrpcrs ZNQabtjTgRwa+DFSHuZwfPD71c0MFKKBoztxTI44RI6pUlqVnqi6gjDWEi6panPPJKpw Z55XqfxfvJzN+Cy0Tdn+6VnjHZOaKmL8D7SmrUTt1JPb5ghGu8LWH35r14fB3JPRqhYT tAnlOr13KeTU4llxhrBO4vwCAnPnOmCmmGYckT9ULVYxi1h+HbioJUWCBXEldUu2qKpa 6Yxw== X-Forwarded-Encrypted: i=1; AJvYcCXKT8hUgDoOySATjQT5V2VgE89UaB8tqDkb+rclN18Kd5AI6/AzJpDz4vxmtWaXNeXkaeyAZuNeI/A=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxs2iCm8TZ0rzJ//eCgWl7u+JMivATe2ukEFuGas6EATe1XczI0 ITIW+mpjoI2FzYaXrve4pEOuCpMFEi40HlRzXqFhAyzBfQBVu1GW65/6iCz+CbSdISQ= X-Gm-Gg: ASbGncu1kOT6UbXMo6wZW8PjYSZQPJF7vc0xteJEf3x/a7cHVRJgDYbXi2l7nt8Ioe5 eb1/b4V6zFNmO+Yfgd7MZmPWVEjRXqlO6Y08mxv9cgfO/viYf8ZIZP6vHmF+VOOM0SvLvP6nLp6 xy0TxM5MFzgS9Sz/ad0qAAAXVNs138UW2Le8abTtoObs5N5oS5do5FhfQBSAK4tk8/gIUonERV5 251Yrhep/6gEmhjTXWH9HSAqNl/ZFZS4goq/5AEAL1mXOIhVkUKmhnbnlR/wK749zQPbVpzHbL4 coGy7scQjlnBvxsuU1Z+ImoYMWjsYTy7IFudNuvqekP+6agrSXglVhiPGPccjc5pXKXaDJKRHy6 /hpmvSt4WQn3U1SVg/v2VqLSUHZekka/ctu0xHtGwUYajtjODLY2W6GgTbnmVWq3AhxGszubMw3 ebOUa6WiqwfkmUMSt1NX1oZAzqUT+YuLc= X-Google-Smtp-Source: AGHT+IFKquQgcsAUg0Wckpi3Q1uVvpKK2LWW0oi9N9Q9t0bhLrHk1BTizML0eTatl5XEnZE1L5+HFQ== X-Received: by 2002:a05:6000:40c7:b0:407:d776:4434 with SMTP id ffacd0b85a97d-4241227789emr2953961f8f.30.1759220560163; Tue, 30 Sep 2025 01:22:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 13/18] hw/xen/hvm: Inline cpu_physical_memory_rw() in rw_phys_req_item() Date: Tue, 30 Sep 2025 10:21:20 +0200 Message-ID: <20250930082126.28618-14-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220794007116600 cpu_physical_memory_rw() is legacy, replace by address_space_rw(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/xen/xen-hvm-common.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c index 78e0bc8f644..52e2cce397a 100644 --- a/hw/xen/xen-hvm-common.c +++ b/hw/xen/xen-hvm-common.c @@ -12,6 +12,7 @@ #include "hw/xen/xen-bus.h" #include "hw/boards.h" #include "hw/xen/arch_hvm.h" +#include "system/memory.h" #include "system/runstate.h" #include "system/system.h" #include "system/xen.h" @@ -279,8 +280,8 @@ static void do_outp(uint32_t addr, * memory, as part of the implementation of an ioreq. * * Equivalent to - * cpu_physical_memory_rw(addr + (req->df ? -1 : +1) * req->size * i, - * val, req->size, 0/1) + * address_space_rw(as, addr + (req->df ? -1 : +1) * req->size * i, + * attrs, val, req->size, 0/1) * except without the integer overflow problems. */ static void rw_phys_req_item(hwaddr addr, @@ -295,7 +296,8 @@ static void rw_phys_req_item(hwaddr addr, } else { addr +=3D offset; } - cpu_physical_memory_rw(addr, val, req->size, rw); + address_space_rw(&address_space_memory, addr, MEMTXATTRS_UNSPECIFIED, + val, req->size, rw); } =20 static inline void read_phys_req_item(hwaddr addr, --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220722; cv=none; d=zohomail.com; s=zohoarc; b=RPke9z908dcJFhTBQwg/+H1b7HuO84Fd9P3oAVs16KD9TElDdr+9ymidXbTLPYcGyf9MdG6qbU1Z4vU3egmoUCTlVpST0Biw5h/EPMq5qxfRqIRz46D/nmSbUDBru/kWwyte+lQgoywHbnEsi7m0QimDq3DUkSzCTycLTBT5BgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220722; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LWuKL8TfgkuOIExpLDHpPzfjXl06+qaviUFlhAaNsvY=; b=eTZ07kJQXKtX6jDVAoBBU5f7wClGp6+rkGmGOsTmEJPV9+JO5dlPi0m/SwixcMW8tEx3WCg7+xst9QLX7ZjohaHAjKHMbqBnPGkTWe1RMKjuewHFn3gmUBkGFQ1m9lElSi5XsJci0VJZXpxIm5Fuzh3ugIQ6kzUTRAuDYM0ZpRQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759220722974187.58973397370585; Tue, 30 Sep 2025 01:25:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VeG-0000hF-UA; Tue, 30 Sep 2025 04:23:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3Vdw-0000NU-S7 for qemu-devel@nongnu.org; Tue, 30 Sep 2025 04:23:35 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v3VdK-00019M-Qc for qemu-devel@nongnu.org; Tue, 30 Sep 2025 04:23:26 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-421851bcb25so959312f8f.2 for ; Tue, 30 Sep 2025 01:22:48 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fc7e2bf35sm21817486f8f.53.2025.09.30.01.22.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220565; x=1759825365; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LWuKL8TfgkuOIExpLDHpPzfjXl06+qaviUFlhAaNsvY=; b=V8rsKghz50z50vBCT1LEQU+km7CKxX83Fh+XGmFw0m6A8RY68XuyaumIOyIrWfYucj PjxHKzl4y3eM67kIaBeWuYdVbyjx/dOcpHNlJwHRowxbgwzX0qLluJLBGTP7mG33SwzQ 5YPPpAiKaWyb86ZUyda/U3+DtRphUHYYXLGkqkXi2uymHBM/bKlLcu83cqJsNsHR5lhw 64gzxZpGu6AljCRLj5XPYvOLNYKM4N+t5qCgznYP6Q7guqOSoSKke425oreYcs9dEhDR 7cqabZM/Cl81ZF+T2F0Kq1ULMzDn5gG+JHVN+JpktH+adxcmkIMK3bF6cqUcuU8Pwm7F vy0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220565; x=1759825365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LWuKL8TfgkuOIExpLDHpPzfjXl06+qaviUFlhAaNsvY=; b=ZfgOEmprhK5WmKxfIeV/dzBMLYXnPSaaA9aDKQidCd1obAZuRM5Gxkt4qPVwswlKK+ bf//W5bhbQE0x8BaR7tDOYvV2JgC6/bUOJVP0rUGZA+jO4uLKxzmMKhACGWe7rgM3idp MraIfOCFxVOfnR+ljl03WcinMPWHJ3vsugn7S8zr1SiWlANHePP/RtjNQEecDJdxcWxF 3ZMrrCVit2gFs5jyolDVm+YIqjmcVIHxhojLUsAzf92pUslsU4NDV4//QlYwkjvyL3vc +eIR2NfPLYth9i3TpmoefltjduHRl0FD4npSoeo5+XgycP9jdeu68K8dOmfV0A9+RlvN ytHg== X-Gm-Message-State: AOJu0YxZpmzkWJ4Qo7RSxChKAxQuVaVHmGLbg+kebrESYBsfZXWNjSb6 HANK1nVrjdajshfVzOPtsiL9LH5kCQXIVj+2pVFe/kpHv94I1QmL7fzRgX7tAinjG1tG+5PXvci 2EqZYTJjnPQ== X-Gm-Gg: ASbGncsGCBVeL6iSniUvDCF+tgXaveV6hUEjquWf7aWcrzS9rQ5o6Y5xAxgU0qf1LK0 Nh58eUqta3cm9ptgWPJeM/XbELQET63pX5BiXivHlJwHY1acqjVRpmFgVxfJU0NtyFtIbwfIQkl ZfP7w4KGrt7uHsDVr5LN9GMTLZn4asKu/DiAmDjvXnQgK4+mAICPcnTxl+kRuGtmyQrrDOK4uI6 GN6IwzIaL0PwMJdL+YNGhIRBje/p38kSpyfE/SAfSJvQMKgo/br4iXebjYcOvVAVs6naS12lKCR tcY42BWZuCyky/z0+CTOMPhX59UpQKt8MWsfz64kHnRqK1OE33StPHCus/sEgVdw/QwmalpDtl8 qdKfT1ZGTsqHeIzic5X3YXGqK2kaDv3nDis3XSJva+Nm2joc9GHkjW1RywgixC3+ElTmnBiZT8T rAX9R7b55oV/4tOv3AZ7Dn X-Google-Smtp-Source: AGHT+IHE0WytwIozDLwCH/1E/tGTnOI9D8efEv7Y9aQk+zHE6qo+2lNsAzNshhN1K4J4d9d9Usou1Q== X-Received: by 2002:a05:6000:240c:b0:3dc:1473:18bd with SMTP id ffacd0b85a97d-40e497c348dmr17529188f8f.3.1759220565490; Tue, 30 Sep 2025 01:22:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 14/18] system/physmem: Un-inline cpu_physical_memory_read/write() Date: Tue, 30 Sep 2025 10:21:21 +0200 Message-ID: <20250930082126.28618-15-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220725077116601 In order to remove cpu_physical_memory_rw() in a pair of commits, and due to a cyclic dependency between "exec/cpu-common.h" and "system/memory.h", un-inline cpu_physical_memory_read() and cpu_physical_memory_write() as a prerequired step. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/exec/cpu-common.h | 12 ++---------- system/physmem.c | 10 ++++++++++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index 6c7d84aacb4..6e8cb530f6e 100644 --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -133,16 +133,8 @@ void cpu_address_space_destroy(CPUState *cpu, int asid= x); =20 void cpu_physical_memory_rw(hwaddr addr, void *buf, hwaddr len, bool is_write); -static inline void cpu_physical_memory_read(hwaddr addr, - void *buf, hwaddr len) -{ - cpu_physical_memory_rw(addr, buf, len, false); -} -static inline void cpu_physical_memory_write(hwaddr addr, - const void *buf, hwaddr len) -{ - cpu_physical_memory_rw(addr, (void *)buf, len, true); -} +void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len); +void cpu_physical_memory_write(hwaddr addr, const void *buf, hwaddr len); void *cpu_physical_memory_map(hwaddr addr, hwaddr *plen, bool is_write); diff --git a/system/physmem.c b/system/physmem.c index e0c2962251a..033285fe812 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3189,6 +3189,16 @@ void cpu_physical_memory_rw(hwaddr addr, void *buf, buf, len, is_write); } =20 +void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len) +{ + cpu_physical_memory_rw(addr, buf, len, false); +} + +void cpu_physical_memory_write(hwaddr addr, const void *buf, hwaddr len) +{ + cpu_physical_memory_rw(addr, (void *)buf, len, true); +} + /* used for ROM loading : can write in RAM and ROM */ MemTxResult address_space_write_rom(AddressSpace *as, hwaddr addr, MemTxAttrs attrs, --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220788; cv=none; d=zohomail.com; s=zohoarc; b=FtlykmxuaIgG8jrlHpf8QE4CYonkx6I6GaxVHOLUX2KKX6xaCKufn//734UxSO6LP9F6DiR8dhYS27WppaFu2foWJOnZ2BFdQG6Q3nyTJVAobKt8XAXpzrlR4cgpR/FMY6mE47QeJZ9MQ3vVxGJsyoRFHSHS5SGg5jUQ1NHwX8s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220788; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=v5u2B/lBOO+ZT0vBm0zXHtehU3SXYck4J+kjqZup+Gg=; b=QduUszie20F/+k0/p9WYKvWaro58TCUDea3j3lOOHTJndB6PgCmxSZ7/FYT9XiO0mEYSVfCocYPFaOiEX5PGVj8GFucdyyrUFR1XJP/aysv4JUme71fGzrx+M5qSncBzem4KclfRbzuwwz/cyKey1ZmvjylD34KXTCuKbl1zXr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 175922078805153.47753735965364; Tue, 30 Sep 2025 01:26:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133912.1471997 (Exim 4.92) (envelope-from ) id 1v3VgU-0004PC-TV; Tue, 30 Sep 2025 08:26:06 +0000 Received: by outflank-mailman (output) from mailman id 1133912.1471997; Tue, 30 Sep 2025 08:26:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VgU-0004Nw-Kn; Tue, 30 Sep 2025 08:26:06 +0000 Received: by outflank-mailman (input) for mailman id 1133912; Tue, 30 Sep 2025 08:26:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VdN-0007Nm-71 for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:22:53 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7f9bd95-9dd6-11f0-9809-7dc792cee155; Tue, 30 Sep 2025 10:22:51 +0200 (CEST) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3f0134ccc0cso3832225f8f.1 for ; Tue, 30 Sep 2025 01:22:51 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-41855fc661esm13882477f8f.45.2025.09.30.01.22.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:50 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7f9bd95-9dd6-11f0-9809-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220571; x=1759825371; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v5u2B/lBOO+ZT0vBm0zXHtehU3SXYck4J+kjqZup+Gg=; b=awB4yGMJ8RK5hj/xpKCvMXzqVagZ1MtHZMipLtt/5JsP8xSjsr9+k2W+MseYj5UInP eMh+icZLHPvinrfDLEbYgXm4kiqH0EHBd69y5qdhXRQ7hZs2cMYrHeEMsEDQfikBcK4X TLstJSfCZEMz4j+oKeR45m1QMiY00h5n/bLKAwbiLyrLfaIYB/e5cYt21vDxOWW8NTDg Urqy65zYUYwBFJenM414YVoxUuDaEM99bDlmUzMM2lIPft0ELUGjr/IyQBtt5jap2Uxj /0woNtM/V2Od5+1rhZFfFvbi1ZzY1uI4vaeNcVsCybiqzC0osgQcnTjRrAblVxEgQbam swdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220571; x=1759825371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v5u2B/lBOO+ZT0vBm0zXHtehU3SXYck4J+kjqZup+Gg=; b=skmEL4flF0ahDTZo7IRsOHSYVF9GxkowOJaww1iFunUB0AMPuxhFpvDm4ODXkiS1yd /gc6cXxHPkoSvqfmkLfP5tW4i7nOHOgW093ONzsxnbn8LFkGFj4GzNs3BeTnYwx+5EEp uyur/TR0R2+0tF845plu0ljt1NTSq4eePsDzP4FIGj1nrKRYDZIg4HGw4KSvAA/naLuO oAHmZhcJscd2H+046Lp8UaviWe1krcYBJSbQ6cUdMKSrtHWNnmUdtuJBbQRZfD/GC81W jfU0uV20o5AFMaunaya3bWRUvzHxhNDAaY2i3Zbi9hCOEY9UBzwO1Z957ocS408d9M0B bKGg== X-Forwarded-Encrypted: i=1; AJvYcCVsHXL3iq562iJKw6oLzTywBmrboo9ZElozBRGsP6XUSrRPzmuGPsC1QpwOzLHk022oBgIF1wgN23I=@lists.xenproject.org X-Gm-Message-State: AOJu0YwTaWdsca5kjAcku4cEb30yR/YmRf8ryKfL5T1Kk0aKTPERWi8g dLmV3cfiRibMP+uDmd/8S1wXc1c+NjP598l0bHpIeteMxbdCbaPJpngQ8kSHXZ4FX6o= X-Gm-Gg: ASbGnct1DojOcN5YzNYCTty3RN7nJGEAkTqUjiBW5nNRlQgv31I4CHF4am1mKDN7wZR m0/boOmJLBSzIlmAoPZfIZNB2AAQVorkbZtNNYxfVs5iOLlLAD5O9Vkx9B1ZyY7A2INqhSwBzsx 9B0rKX1gDfQjqmO/L7MvsMGpLYHA0Ql5tXGwHqM6uJuvt7ylxdLPAUeVrWa0Sc0PYso90AUoHjd tNgcGG2XqKWNcJiQ8pYgATh6LO+Imiblxv9QZ4Q3OKAsGZnjAh8gH4umx93vRKvPnaK/FNV8DNp cyLWBWB2zLnkVB4FLd0i2+M/tAsGxZ6K0QWfJxHqzLp0uZ3lWJjmnzQtQWBqPgw8McBToIzZqZu LHYPnD1lM4DpKHvZ6/XyIRD0Nw3fPpurOTrvpBgJJ9MewohOdGertlTAnKLczDuvob7rqq23oLt 3WDa85FedEdEOiSqDSwfr6 X-Google-Smtp-Source: AGHT+IF27z6BNMVinFPf1IUIruLrE/uTdfyqnRZ7rQ19Ax6aGtKGHkRUD8xTP4t1vKCXsfORDSUoIQ== X-Received: by 2002:a05:6000:2507:b0:403:e61e:82e6 with SMTP id ffacd0b85a97d-40e4b1a07admr17394709f8f.46.1759220571045; Tue, 30 Sep 2025 01:22:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 15/18] system/physmem: Avoid cpu_physical_memory_rw when is_write is constant Date: Tue, 30 Sep 2025 10:21:22 +0200 Message-ID: <20250930082126.28618-16-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220790040116600 Following the mechanical changes of commit adeefe01671 ("Avoid cpu_physical_memory_rw() with a constant is_write argument"), replace: - cpu_physical_memory_rw(, is_write=3Dfalse) -> address_space_read() - cpu_physical_memory_rw(, is_write=3Dtrue) -> address_space_write() Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/coccinelle/exec_rw_const.cocci | 12 ------------ system/physmem.c | 6 ++++-- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/scripts/coccinelle/exec_rw_const.cocci b/scripts/coccinelle/ex= ec_rw_const.cocci index 1a202969519..35ab79e6d74 100644 --- a/scripts/coccinelle/exec_rw_const.cocci +++ b/scripts/coccinelle/exec_rw_const.cocci @@ -62,18 +62,6 @@ symbol true, false; + address_space_write(E1, E2, E3, E4, E5) ) =20 -// Avoid uses of cpu_physical_memory_rw() with a constant is_write argumen= t. -@@ -expression E1, E2, E3; -@@ -( -- cpu_physical_memory_rw(E1, E2, E3, false) -+ cpu_physical_memory_read(E1, E2, E3) -| -- cpu_physical_memory_rw(E1, E2, E3, true) -+ cpu_physical_memory_write(E1, E2, E3) -) - // Remove useless cast @@ expression E1, E2, E3, E4, E5, E6; diff --git a/system/physmem.c b/system/physmem.c index 033285fe812..51abc4cae96 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3191,12 +3191,14 @@ void cpu_physical_memory_rw(hwaddr addr, void *buf, =20 void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len) { - cpu_physical_memory_rw(addr, buf, len, false); + address_space_read(&address_space_memory, addr, + MEMTXATTRS_UNSPECIFIED, buf, len); } =20 void cpu_physical_memory_write(hwaddr addr, const void *buf, hwaddr len) { - cpu_physical_memory_rw(addr, (void *)buf, len, true); + address_space_write(&address_space_memory, addr, + MEMTXATTRS_UNSPECIFIED, buf, len); } =20 /* used for ROM loading : can write in RAM and ROM */ --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220708; cv=none; d=zohomail.com; s=zohoarc; b=Eez5VXWsOUg2WQAuNKLIC488i1sqCy/zYQY5Ho9x4mGnJfj0HLURUpXUXxLeL3fAxPzs/azeeAik/CnJJZtuUMJ62BTQ1F6sLxIXTAhdTFvJeYKvp+1zOV+nZBCkUw7ShlXKMBsK6n7BJdbB0WzqHSU/WTw116gWsv6bJjxuP0c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220708; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=w+NTzU/IHsRou1TdenwZChnEmNZiK1YgxaNrzj3kN60=; b=N9EJoVENkzHi+PtjTgNeEWHPaY5iuknzMIaI/7GX4kT4K+OdzXa2HrZ8jOj1AAENj3XyfhBxuK2tJsxcL1pCDo4g8DA/WWMmC6Dq9smTYf2FiVTrqyDgh/XBZjdoV/+RQ10SogXASnJ9UaQ9Qc1c7P7vIUj8TYjmpxbZ+ziAINI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759220708560917.2714962923224; Tue, 30 Sep 2025 01:25:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VeS-0000uR-Up; Tue, 30 Sep 2025 04:24:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3Ve6-0000Q9-Ea for qemu-devel@nongnu.org; Tue, 30 Sep 2025 04:23:41 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v3VdU-0001ET-Pa for qemu-devel@nongnu.org; Tue, 30 Sep 2025 04:23:35 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-421851bcb25so959462f8f.2 for ; Tue, 30 Sep 2025 01:22:58 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2ab31f1dsm257299105e9.13.2025.09.30.01.22.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220576; x=1759825376; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w+NTzU/IHsRou1TdenwZChnEmNZiK1YgxaNrzj3kN60=; b=cyOvLoKobdu9y47zyQRojkNNMFuD6VdGV/WjupHLR2YTyCSnxEkAbbxvJult0I/obM sLzbZcIWcK+ka4M/HH+D22PIxV6DlnO3umLZsjObmzxiZFMb6hXVQetaOIWbgrGR2Ylx orkjPtKVb+SIyED8H+ZTlRRPwABy/qDWP6fEuxKIwqL48RNLN1lGIpR+tvslPU4Gnhs4 nvJYBGOyGTrKMnRnAWLWrUcW4uO9W4sBbDVliKsBvcx/MBKfeGjOThaYBgfTQUQkQSjo OqFeej/rujzsHyt18UhqRzgJTTLetvkjrhi4xDUMLHMKhYojuiQ1l1OBloXR3mF+mlD6 OWlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220576; x=1759825376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w+NTzU/IHsRou1TdenwZChnEmNZiK1YgxaNrzj3kN60=; b=IDlVXiac/0d2m0VOS+CYp1xjKPvdrNy73bIgIGvVSMrHJknW4gzH2N+xQoeI+U5t71 1ZwzB3RB1+17THyDxFt5JGe4aYZ49WP9H4XazuDC+Yu2WXmqPNxH/PBaCiOnx5vf0Nc1 SVy15E1YdVDNfh/pSDsYXFpVAkMFng03/LRiz9vE2KvZXR0JRY9GRp/u3mj0FZFXqyI1 dyvYIr0X1LzOBpYkkqG0zqJmUn/9ejZWQTov1tfap3Fyhp3SEQUK1Ulg1rUAncZuSPDi NV2N6i97BQrSnSE+AVplUgbPQEdUmQyN0K/jBd3dHUs8/aO/gJB+3e+5XZ31NGt1DZcD sVEg== X-Gm-Message-State: AOJu0Yz/6+aLUKJmJIzTmoxNNM9bWso9eubPT4fIYFO6h/2lPVEjvszR TI4IdlBp1GHkl0Zy0xIyDjii4IYL1YSOa7Zi9ntXhB1E5nDsoPG5CbxzMOMNsmAi1UtDdjcrDFl cKvyWiWByQA== X-Gm-Gg: ASbGnctUyZXu4Iip28ACHdwfwcejvdKVJdLNEzN/ZBboIiUqsCRVJalzvPVn+0kdzpF 2vwcIWlNI1r6cR742ySCCXcBehHLSVlQpcmyqt7n1132OCS1bTDYoN60qABjTQ6xvgKChowCYtS NeZngR9XUcj09XJzdev8n+nq+Dwc+Xa+CTtLj8O9PkKaoijGS42YfUVmBzRvoQFmzFL0v9VOJki SKdhgVXm1JpnT/UTSPqmt+Nrzs3kROW5s0uEV0sl0MSFVN6IuJqzWJJgnfYGEiwFdt1rq6JKVQM f8raKyz9iCMCE4DXwF+Q5/LFtmRmTa163eEQrXbhaiQkXz5YdJ67cEsIPjTX5X+4mho3i945enE fgnedru/z1keEOZy9AYM1XFUvUWz2p9alv+grSjIANdrmFFrIR3c8dIiMDxQcWVKh/5Kzp5aZXb TiQnRAuZspY5f9vSBFlgAq X-Google-Smtp-Source: AGHT+IF6MOWO4c82B+adWYsw2taxPQCQZ7xaYbsT9FR7waxJpKF5wSL8PK2fRqDT9d11Kh1Y1Hd+uw== X-Received: by 2002:a05:6000:2509:b0:40d:86d8:a180 with SMTP id ffacd0b85a97d-40e4a71159emr18168445f8f.20.1759220576446; Tue, 30 Sep 2025 01:22:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 16/18] system/physmem: Remove legacy cpu_physical_memory_rw() Date: Tue, 30 Sep 2025 10:21:23 +0200 Message-ID: <20250930082126.28618-17-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220710933116600 The legacy cpu_physical_memory_rw() method is no more used, remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- docs/devel/loads-stores.rst | 4 +--- scripts/coccinelle/exec_rw_const.cocci | 10 ---------- include/exec/cpu-common.h | 2 -- system/physmem.c | 7 ------- 4 files changed, 1 insertion(+), 22 deletions(-) diff --git a/docs/devel/loads-stores.rst b/docs/devel/loads-stores.rst index f9b565da57a..c906c6509ee 100644 --- a/docs/devel/loads-stores.rst +++ b/docs/devel/loads-stores.rst @@ -460,10 +460,8 @@ For new code they are better avoided: =20 ``cpu_physical_memory_write`` =20 -``cpu_physical_memory_rw`` - Regexes for git grep: - - ``\`` + - ``\`` =20 ``cpu_memory_rw_debug`` ~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/scripts/coccinelle/exec_rw_const.cocci b/scripts/coccinelle/ex= ec_rw_const.cocci index 35ab79e6d74..4c02c94e04e 100644 --- a/scripts/coccinelle/exec_rw_const.cocci +++ b/scripts/coccinelle/exec_rw_const.cocci @@ -21,13 +21,6 @@ expression E1, E2, E3, E4, E5; + address_space_rw(E1, E2, E3, E4, E5, true) | =20 -- cpu_physical_memory_rw(E1, E2, E3, 0) -+ cpu_physical_memory_rw(E1, E2, E3, false) -| -- cpu_physical_memory_rw(E1, E2, E3, 1) -+ cpu_physical_memory_rw(E1, E2, E3, true) -| - - cpu_physical_memory_map(E1, E2, 0) + cpu_physical_memory_map(E1, E2, false) | @@ -81,9 +74,6 @@ type T; + address_space_write_rom(E1, E2, E3, E4, E5) | =20 -- cpu_physical_memory_rw(E1, (T *)(E2), E3, E4) -+ cpu_physical_memory_rw(E1, E2, E3, E4) -| - cpu_physical_memory_read(E1, (T *)(E2), E3) + cpu_physical_memory_read(E1, E2, E3) | diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index 6e8cb530f6e..910e1c2afb9 100644 --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -131,8 +131,6 @@ void cpu_address_space_init(CPUState *cpu, int asidx, */ void cpu_address_space_destroy(CPUState *cpu, int asidx); =20 -void cpu_physical_memory_rw(hwaddr addr, void *buf, - hwaddr len, bool is_write); void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len); void cpu_physical_memory_write(hwaddr addr, const void *buf, hwaddr len); void *cpu_physical_memory_map(hwaddr addr, diff --git a/system/physmem.c b/system/physmem.c index 51abc4cae96..000bde90c2e 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3182,13 +3182,6 @@ MemTxResult address_space_set(AddressSpace *as, hwad= dr addr, return error; } =20 -void cpu_physical_memory_rw(hwaddr addr, void *buf, - hwaddr len, bool is_write) -{ - address_space_rw(&address_space_memory, addr, MEMTXATTRS_UNSPECIFIED, - buf, len, is_write); -} - void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len) { address_space_read(&address_space_memory, addr, --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220778; cv=none; d=zohomail.com; s=zohoarc; b=CwMlVFr/1GYtUA4LtZSb5QUfVWl8X5piR3WBFKNh0HcnB4+TTMyqxWlF6U32rhZP7Qw/kJsCreR/AVr2Jw69iGKxqIgwkyKhkIdcvvpN1MuT+hkI9IzyjeyeYnI/1X6N7V1XZ7LvoYl09FpzJEBB5KNL18YznFRUPOoiFNKc264= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220778; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=72P8ycFgSBQVWBZ3tJbVWDsHTvBRP8LSmdHVD/So9uo=; b=IrILcSuDxLd52ihVNlwpRTTjSBqN+i6xA6GW+KSgLpf6KVXan9Ez3ajpW0MPFYMy3iocqw39odTb7LlH6grqkiFa4NuvgIrdCBKsWcsPObrI6q6Ij8NQCU86n27OIZfw2fT7XHC3S3BItzdFX9WU7jluO5yKDrrHEyt4FYSm2cs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220778074256.59233011212166; Tue, 30 Sep 2025 01:26:18 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133902.1471967 (Exim 4.92) (envelope-from ) id 1v3VgS-0003j0-G3; Tue, 30 Sep 2025 08:26:04 +0000 Received: by outflank-mailman (output) from mailman id 1133902.1471967; Tue, 30 Sep 2025 08:26:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VgS-0003it-AP; Tue, 30 Sep 2025 08:26:04 +0000 Received: by outflank-mailman (input) for mailman id 1133902; Tue, 30 Sep 2025 08:26:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VdW-0007Nn-TQ for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:23:02 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae7d968a-9dd6-11f0-9d14-b5c5bf9af7f9; Tue, 30 Sep 2025 10:23:02 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3ee13baf2e1so4389325f8f.3 for ; Tue, 30 Sep 2025 01:23:02 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb72fb21esm21742490f8f.7.2025.09.30.01.23.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:23:01 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae7d968a-9dd6-11f0-9d14-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220582; x=1759825382; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=72P8ycFgSBQVWBZ3tJbVWDsHTvBRP8LSmdHVD/So9uo=; b=BwcWYdnAKol/338lhKXf71n0HYv/xU94CMdkDxqXQ0rueCgSfaYVxwOxa8ge8uBXQm BuM1JwJE95+vpAEunhQWk/5x/8HfyUYZh815h4wmMO7SyoFGvWTEgOQdrDZsXCDbJg3P QjRyk4iyh6j+3MpeAABeqa+xHc9XL4PLopalad6OSI9k5l/PFK99STiRK6O6fvUqTkSb gYAZoGFjqiKXJ8T37BH338F9ta16n+iC2HE7P6gwqmpu/ptjcRwIUwjPN4ikvwtOGziB mN6UXSUxgVJugZZHAecCsaU7aR4w02bEW5BS50FsoDB//u2kETXy83rhEfmS4D/zcurj SWCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220582; x=1759825382; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=72P8ycFgSBQVWBZ3tJbVWDsHTvBRP8LSmdHVD/So9uo=; b=hMdrsqCqfM3cZ+8CPT/W9Q3TnGjdU7pflbYeQRDuampeZGIvJMXF45L5PH8W7ffBT7 MikaCLhhs2m6uYv7YEkQHP1rCqeqL8ocD0WjCKxNY/zUf4mrxmG/kc1mHFYxg4oFbF4s HeYzPNlb7KDGALq/a9jUhJmluUgga0rBOlJkHNG4TbjCaNNt0KyC5tPaHdL/3elOtcRy NJtBqtilbSg+uRRLfPYqQWENc69U+8t7wQNKkpTn9tWN1R/hUMNjx6womBwnVgaGJUS8 uiV+qjFJiWj5ccO2HTlgdWiEPe1ETiSSQojVWioU0/7UbvJPlCw5L2/HxKJOaUWH28ai VUeQ== X-Forwarded-Encrypted: i=1; AJvYcCXibgvEnR7Pj2N0u/5ChTHvMGPltFUhYl48o4aTbyn1SZVkQl+N29CUjOqHtoW4D9FI1GHS7OVoO5M=@lists.xenproject.org X-Gm-Message-State: AOJu0YxEChA3/AV5csHtsdg+Wxqx/fa6sj/qt+mOTRCiZ1u2AAKlurlI pGChnFufQNgco7OFKh10uJxFuWTvXqrcCWpdeGgnM4vWnk2BFzQMhECa4VwW7SZsntA= X-Gm-Gg: ASbGncuvtE1mXmMQxQDqHIHukiQbqesDt+GX2h58JwAzDeu0hbZ03gxJlax03sL2IYB uYGmo0zwJgWcWbxDSSjnndw0udYOqsOafQXRAaucT6/iEN72VQI7l19ToDTfGQ+oXIrsgJBEWy1 3O+ZTYiJjIAEdKylE8IWqnFa+QObzQJnY6fV4LCmm2ce7KQVt/BDZdakukIN3kTb7RzZhWP6iWK emm4qvnqKluRubq/D+GKZxS8cKG8k9BuTNdRpoF5FY7V8OZXeNuI62qmQf8GiJKU8stwMFw6SNY IUshi6g8oHPdcPIjgXp4KOq0yG4W/5SdRiAN1eqM75LeyiwkmB3KBQaUgl+U+plEjCI8VIgnbyS GRDqVz2DM5jQHI3vrSPMzATRILXBOOw8Lx4MHqb6FbOIHH5o/IepOzwbWILEVdcu4b/lTp5A28v 3Q2fFIWvy/a/DILec/nxG9 X-Google-Smtp-Source: AGHT+IG0fDZU6KltrERn3higtjD7tJ2dh/0k92N8Tps8ggqNo2HbrRNaueeSukMTmfKt9k8lWLLnpA== X-Received: by 2002:a05:6000:3101:b0:3e7:492f:72b4 with SMTP id ffacd0b85a97d-40e4be0c940mr16811180f8f.42.1759220581872; Tue, 30 Sep 2025 01:23:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 17/18] hw/virtio/vhost: Replace legacy cpu_physical_memory_*map() calls Date: Tue, 30 Sep 2025 10:21:24 +0200 Message-ID: <20250930082126.28618-18-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220779739116600 Use VirtIODevice::dma_as address space to convert the legacy cpu_physical_memory_[un]map() calls to address_space_[un]map(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/vhost.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 6557c58d12a..efa24aee609 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -27,6 +27,7 @@ #include "migration/blocker.h" #include "migration/qemu-file-types.h" #include "system/dma.h" +#include "system/memory.h" #include "trace.h" =20 /* enabled until disconnected backend stabilizes */ @@ -455,7 +456,8 @@ static void *vhost_memory_map(struct vhost_dev *dev, hw= addr addr, hwaddr *plen, bool is_write) { if (!vhost_dev_has_iommu(dev)) { - return cpu_physical_memory_map(addr, plen, is_write); + return address_space_map(dev->vdev->dma_as, addr, plen, is_write, + MEMTXATTRS_UNSPECIFIED); } else { return (void *)(uintptr_t)addr; } @@ -466,7 +468,8 @@ static void vhost_memory_unmap(struct vhost_dev *dev, v= oid *buffer, hwaddr access_len) { if (!vhost_dev_has_iommu(dev)) { - cpu_physical_memory_unmap(buffer, len, is_write, access_len); + address_space_unmap(dev->vdev->dma_as, buffer, len, is_write, + access_len); } } =20 --=20 2.51.0 From nobody Sat Oct 4 22:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759220789; cv=none; d=zohomail.com; s=zohoarc; b=AqK7rP13tfQuZK8dL8aoY3rjeUvbyarFNslZhcAXcN+2vlmgQWhey8XECuRN+xu5xz5k54H6I67FHFYr9BOQqZyq4WMcjBMuzRjbPsEUyEDewd+z4XtbnMe7zsFbAZ+53CEKGSmvKTCN0xO1MW0a818YiR28qhnvwpN8Ptuc+YU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759220789; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+R20KfaeepivX48ztS5Qk+Utu4Wf2nP4nwxC8R0e4a4=; b=V6G+G1uzcfaABlis3k53h+4pZgVxD/SADuKa9RzAV/eur4Vx58EK55wCUEWRkhz3lE/0NQoe/YJDrjv4uYP2xKqLg5qwWuEsau3ZfuJ3mtWxnCPPSLAdlM5ycXylEzNANZLn4J9nuZp6h/gEnbSmAg5rK8SZNvu9zO5ZmNslvQ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1759220789212967.327890908812; Tue, 30 Sep 2025 01:26:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133919.1472016 (Exim 4.92) (envelope-from ) id 1v3VgZ-0005HL-BO; Tue, 30 Sep 2025 08:26:11 +0000 Received: by outflank-mailman (output) from mailman id 1133919.1472016; Tue, 30 Sep 2025 08:26:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3VgZ-0005Gy-64; Tue, 30 Sep 2025 08:26:11 +0000 Received: by outflank-mailman (input) for mailman id 1133919; Tue, 30 Sep 2025 08:26:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Vdd-0007Nm-B0 for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 08:23:09 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b197e6de-9dd6-11f0-9809-7dc792cee155; Tue, 30 Sep 2025 10:23:07 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-46e4473d7f6so24843515e9.1 for ; Tue, 30 Sep 2025 01:23:07 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fc82f2965sm21484653f8f.55.2025.09.30.01.23.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Sep 2025 01:23:06 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b197e6de-9dd6-11f0-9809-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759220587; x=1759825387; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+R20KfaeepivX48ztS5Qk+Utu4Wf2nP4nwxC8R0e4a4=; b=XsLGFzWQTOCJYDfyRB1ZDBDRURr/nK7iRq+id4fav97QU/FyV44/btlMMGnv9IGtw+ UhgDRpOlZv4aZDxGfQtR/seRHmYD3ei0P8fh59PwyCiZUrc6sbEA5hcY8EqabSheI9PG LVeISu8DHegvqU8w/JbvUDLnQzjFeCSs52sAPh1vMgSMOi10IX2sLNTi/spPr9q6Dqzn poQpGfvfGo8YgSbCIEynUQ0Y8JKOQdfNfvxovXxGV/FskzPhOzTW5Gbce5kSmguNvaNb 6y34WRMg9DaMBZ2C1phR9LBhd6xF1aP0kAb4uu71MA6ZQy9fnAxM5WAu2yasAfiwQpAP 55ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759220587; x=1759825387; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+R20KfaeepivX48ztS5Qk+Utu4Wf2nP4nwxC8R0e4a4=; b=QalbMQ5CSoRONE+Wb0KlbQFr+jD0QIYnTqIO+ytw0GzH9+GTF3nWHtnP247TACyaZE WiA0FG3cHdo73Tb3skYV4NQC3smG4dCxeYb+zeaaYyLM8aR3eqXHupNboL4t8eIIhiKl Hid4XbNLQSz1fZ2N0i0FvdVGvf3vVW7Hrs2Dw8sy54ZuQb9Cily8T/wuv0svvMGdw6Su vD2K60QXmlhPhDsQjlmGlpVtUTsRaNEZ0LHL7niegBqv8iKfSaZEujXdUPuJR8YsvS09 FhyYBvCmkB/UbfNWLClkTxC7iBZYG7TOJcC80150CR5KHGdlZNw7YUnFOjHU7so1ITWi r3cw== X-Forwarded-Encrypted: i=1; AJvYcCXVNkJ0n08NBo9wLu1krtlwuTGKD0okPHC3aLi7MLF0KDOoLcPl2SQ0d5s/OHXPp+Ro+jj10t1z1No=@lists.xenproject.org X-Gm-Message-State: AOJu0YwKg/ZrOxQPW2+HJOpe/OqzH7pZe9cMRTOALFJI12NNAg1x2iA9 FcUNpuzFdFrWhzqcRmngPujNZHXeDAlTIR2OnIFfPfVmskv500pOrKEBcbzr3uM6jJE= X-Gm-Gg: ASbGncuGcEaD6R7E3fYVqiTY3sJ4H8w56YwnmSe2+2s/NQGCyPwPebClANBny+Kof+H ubTYz+BHyaT4BnakvQhLqlkXrnKpTvF72qjaA5cGBRZAZ46wL5RGf8SERzkYJ5RZq84V8TSVCzx o+3sLuVbncIIVWB1Ek969yu/Gi2DwK1F3Bkr8PTof7WlpjppKl1UGq4NKFzAv0q0Ffa+s7GBxWR aLFvv8P7cB5RG/rSYLRpTdwdQs2pRgtExHGtK7cc1R+5hNISp1SMa+cOIWx4LSWjQJn4ou4ZiP8 +COrhB0EL36MPxzicFald7MjHztp760pHouJfOk4VzI709uhnFNsVFkjSWhGZ82sbi/JNZvmH53 5OayJ96I6mEN+MjQwkCIrPwoFzL+NoZ7DwxiU3zcKw5fQEHOA/qkSy+p3aAeaGWlIS0kxzXQBzy PPTO21GOBb7E5EWJNEqd9iatp4N6u5bUc= X-Google-Smtp-Source: AGHT+IGvdNJkPsXhO7mhTBAmSS24HJr1NcQFoKlHMGEeSQcfQp9VTD/G8Mg1Kg5Mqclxy+K9+gFIZw== X-Received: by 2002:a05:600c:4e8c:b0:46e:477a:16cc with SMTP id 5b1f17b1804b1-46e477a1b4emr94534015e9.24.1759220587242; Tue, 30 Sep 2025 01:23:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: Marcelo Tosatti , Ilya Leoshkevich , Reinoud Zandijk , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , David Hildenbrand , Halil Pasic , kvm@vger.kernel.org, "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Stefano Garzarella , David Woodhouse , Sunil Muthuswamy , Richard Henderson , Stefano Stabellini , Matthew Rosato , qemu-s390x@nongnu.org, Paul Durrant , "Michael S. Tsirkin" , Christian Borntraeger , Anthony PERARD , Jason Herne , Paolo Bonzini , Thomas Huth , Eric Farman Subject: [PATCH v3 18/18] hw/virtio/virtio: Replace legacy cpu_physical_memory_map() call Date: Tue, 30 Sep 2025 10:21:25 +0200 Message-ID: <20250930082126.28618-19-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930082126.28618-1-philmd@linaro.org> References: <20250930082126.28618-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759220789846116600 Propagate VirtIODevice::dma_as to virtqueue_undo_map_desc() in order to replace the legacy cpu_physical_memory_unmap() call by address_space_unmap(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/virtio.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 9a81ad912e0..1ed3aa6abab 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -31,6 +31,7 @@ #include "hw/qdev-properties.h" #include "hw/virtio/virtio-access.h" #include "system/dma.h" +#include "system/memory.h" #include "system/runstate.h" #include "virtio-qmp.h" =20 @@ -1622,7 +1623,8 @@ out: * virtqueue_unmap_sg() can't be used). Assumes buffers weren't written to * yet. */ -static void virtqueue_undo_map_desc(unsigned int out_num, unsigned int in_= num, +static void virtqueue_undo_map_desc(AddressSpace *as, + unsigned int out_num, unsigned int in_= num, struct iovec *iov) { unsigned int i; @@ -1630,7 +1632,7 @@ static void virtqueue_undo_map_desc(unsigned int out_= num, unsigned int in_num, for (i =3D 0; i < out_num + in_num; i++) { int is_write =3D i >=3D out_num; =20 - cpu_physical_memory_unmap(iov->iov_base, iov->iov_len, is_write, 0= ); + address_space_unmap(as, iov->iov_base, iov->iov_len, is_write, 0); iov++; } } @@ -1832,7 +1834,7 @@ done: return elem; =20 err_undo_map: - virtqueue_undo_map_desc(out_num, in_num, iov); + virtqueue_undo_map_desc(vdev->dma_as, out_num, in_num, iov); goto done; } =20 @@ -1982,7 +1984,7 @@ done: return elem; =20 err_undo_map: - virtqueue_undo_map_desc(out_num, in_num, iov); + virtqueue_undo_map_desc(vdev->dma_as, out_num, in_num, iov); goto done; } =20 --=20 2.51.0