From nobody Sat Oct 4 23:38:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1759205792; cv=none; d=zohomail.com; s=zohoarc; b=lb6lozzrijYg48P3tDEYIer7iA90BlCxHvLIRyZ81/JB0SOI9CfQEt0KfyVNOlu46C5MYzUCokBvFhUPgwTH/j8TkY0HuRvfYVRA6OVGy4Z/95PEHCHk2SE/8f739re6iez4ni5uc7hLm/SvXPni4Fy2YNRSRVRiewcIAMVvfhw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759205792; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JRsfrHQBMjnrXhlxfeiXrXfyISPq/9LUWh417J9QSAY=; b=EPAJRL4R3cqqSopO5BR9JcteRtGJvNE5VM2vvQv75iUWIUoDFv/VwMTfXFyoHqDfTlmybC2q1meKy40PQxpDQ1T83+sr7Mh17FelcJhnhl1WjtCUUy+2L9Z3SIqbyM+O4o8fMvjQCrc5rcsRjpNOkIODjfxkY7yZLmc+qpiSidM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17592057922831018.246987744583; Mon, 29 Sep 2025 21:16:32 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1133506.1471658 (Exim 4.92) (envelope-from ) id 1v3Rmb-00039d-Gq; Tue, 30 Sep 2025 04:16:09 +0000 Received: by outflank-mailman (output) from mailman id 1133506.1471658; Tue, 30 Sep 2025 04:16:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Rmb-00038l-35; Tue, 30 Sep 2025 04:16:09 +0000 Received: by outflank-mailman (input) for mailman id 1133506; Tue, 30 Sep 2025 04:16:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v3Rkt-0006gD-1o for xen-devel@lists.xenproject.org; Tue, 30 Sep 2025 04:14:23 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f0d7c145-9db3-11f0-9809-7dc792cee155; Tue, 30 Sep 2025 06:14:21 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3ee13baf2e1so4220066f8f.3 for ; Mon, 29 Sep 2025 21:14:21 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb74e46bcsm20884752f8f.8.2025.09.29.21.14.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 29 Sep 2025 21:14:19 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0d7c145-9db3-11f0-9809-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759205661; x=1759810461; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JRsfrHQBMjnrXhlxfeiXrXfyISPq/9LUWh417J9QSAY=; b=HmQDEgd0WLroLb9N28GnwNptCIEWEgi1qt+7DGtYwOs0AymCIuxDUB3KwrhmrW9Vq+ L+Kwbw5MN+9fd3uHtxJr1hpIp7QmTkNRuLDLTLgZ3ywCl9gz9TZS/hQev0YInkWcDOIl BXwaSjXLJ9pRMI7FRVXZJ+zAUy+yA76DhNeEdhFKEm95OYL7+1JDRjR6zUfLq6HIPjJA kQcfJbQURI8sM8GkXrrjGr60P8fIkD8GHhIqP6gFtgbnzNuhuaicuS3N7RLJF2UlnwEd PYhDABqv1EeOWccjhZyfWWCxYQLwiyZE3EdNoEDnqlHlNTVdyYeqfkKw+1/cstIX30UR Xk2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759205661; x=1759810461; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JRsfrHQBMjnrXhlxfeiXrXfyISPq/9LUWh417J9QSAY=; b=VpqKDAO7gIG+cOedTEefgOIuOxTmnHYDKiq+HMFlzPgQ7ArjJOnzuouKGz/sEhjzZA Yn5e+dYy1Ixh5HNbW6GJhDTGFkQCfz8rKvwX7+1XZ+6iC3Ux4FHtCZ88q5Y3qH8mJD8L buJ4XVUcT8oMIu28AbkmrD3SxHA4yPw2p86Ojlj6qlA7aEd34zDAPVEzcx18AKtAT9au INPzHsaLkMjBUo2p3yd6XOFeSqYPT+ebBjMNdF0ogP7RWIbmf+7fuZPia8p2IQz928Mm +4SkDFOEFO8cJgkqavRo7RL8E2YPblAaqC3/WgTDr3ejBhq+Vrq+6YoD1qlb9axutrTF AqpA== X-Forwarded-Encrypted: i=1; AJvYcCVTdjiKXyym8DzfWx+cBqetmIkqFK4O0qyUVW0DNpDJ641YYRXWDWlUqFB+CsoDCrWYYj37DliEZ8E=@lists.xenproject.org X-Gm-Message-State: AOJu0YzWCuByY3ZzVNEvqq2GA46NEB0t6FjRn4na2p8gKd41ZrhkUxAa oNwjxJPbTWheE9nKQY4RszEnE+iLUfkIM7GEwaFIj6mqz/eJa/YONCW46o0eyjpYtJk= X-Gm-Gg: ASbGncu66iWtkpyq60BMRlfdw9AwbRs1Qf7F320AkVNAvBrIHYIaqOzK+xSsMgKRLkU fb8J4Scj4PdpIX/xfSNXzoHcXZNbcT5KjGAsDJjP07t5xWtqMEtFAYAUJpnYDLu4y2TcGmUExL3 DLpxR8KqECQj6Ody7h1L9iBggoQdUmacrXgLiWvB5PYbWIknKNd2U6V40JDG6ZO6BTpbT/KRVpQ TDMRVSejE4q65wvVpYjlhiHzvJBdncpy6SPa/Vpjl8Gofp5N5dtF4QAGXwOdvb2feWD7SDajxR+ xZDcglIC0scs2TZZK1K8qbvCuLzel6GIYe0sdLuZsu7E6sre14HNCgiuEGuFGX1ZYOa+R24s3iR yiP4ZzARyl1b3Rn88+k+huStB9Xg3U30viRRJmeE/DuK3mw/RgXZ52beLTlO5X6uD38iakkkGBK xBzCrxpNf3nT47J82Y2dC6ruClKyDDjhY= X-Google-Smtp-Source: AGHT+IEAmcRaAQ7y3JKYkZc+1B3lBRPGfbSyTbOeVCtcFaGQrh4be0IXziHu3DKBh/h2DslEMGPKwA== X-Received: by 2002:a05:6000:2dc9:b0:3eb:c276:a362 with SMTP id ffacd0b85a97d-40e3d69c099mr16747038f8f.0.1759205660946; Mon, 29 Sep 2025 21:14:20 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jason Herne , Stefano Stabellini , Stefano Garzarella , xen-devel@lists.xenproject.org, Paolo Bonzini , Ilya Leoshkevich , Anthony PERARD , Paul Durrant , Eric Farman , Marcelo Tosatti , Halil Pasic , Matthew Rosato , Reinoud Zandijk , Zhao Liu , David Woodhouse , Christian Borntraeger , Sunil Muthuswamy , kvm@vger.kernel.org, "Michael S. Tsirkin" , Peter Xu , Thomas Huth , qemu-s390x@nongnu.org, "Edgar E. Iglesias" , Richard Henderson , David Hildenbrand Subject: [PATCH v2 09/17] target/s390x/mmu: Replace [cpu_physical_memory -> address_space]_rw() Date: Tue, 30 Sep 2025 06:13:17 +0200 Message-ID: <20250930041326.6448-10-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930041326.6448-1-philmd@linaro.org> References: <20250930041326.6448-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1759205793246116600 When cpu_address_space_init() isn't called during vCPU creation, its single address space is the global &address_space_memory. As s390x boards don't call cpu_address_space_init(), cpu_get_address_space(CPU(cpu), 0) returns &address_space_memory. We can then replace cpu_physical_memory_rw() by the semantically equivalent address_space_rw() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- target/s390x/mmu_helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 00946e9c0fe..4e2f31dc763 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -23,6 +23,7 @@ #include "kvm/kvm_s390x.h" #include "system/kvm.h" #include "system/tcg.h" +#include "system/memory.h" #include "exec/page-protection.h" #include "exec/target_page.h" #include "hw/hw.h" @@ -522,6 +523,7 @@ int s390_cpu_pv_mem_rw(S390CPU *cpu, unsigned int offse= t, void *hostbuf, int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *host= buf, int len, bool is_write) { + AddressSpace *as =3D cpu_get_address_space(CPU(cpu), 0); int currlen, nr_pages, i; target_ulong *pages; uint64_t tec; @@ -545,8 +547,8 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uin= t8_t ar, void *hostbuf, /* Copy data by stepping through the area page by page */ for (i =3D 0; i < nr_pages; i++) { currlen =3D MIN(len, TARGET_PAGE_SIZE - (laddr % TARGET_PAGE_S= IZE)); - cpu_physical_memory_rw(pages[i] | (laddr & ~TARGET_PAGE_MASK), - hostbuf, currlen, is_write); + address_space_rw(as, pages[i] | (laddr & ~TARGET_PAGE_MASK), + MEMTXATTRS_UNSPECIFIED, hostbuf, currlen, is_= write); laddr +=3D currlen; hostbuf +=3D currlen; len -=3D currlen; --=20 2.51.0