From nobody Fri Oct 31 04:01:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1756425280; cv=none; d=zohomail.com; s=zohoarc; b=ZXCRbd1OywrJSNyeO82lQ8bTEBAaJtOMk55RqLZZQ/GRd8yIKSpJFdA3pJlfVdIQmjVjOr5SbB4P7hnbt3kcftb7/r/9FdlxbFV1Hi+CjG2EQBqgIdfsMhIiwv0pdS1shuvafZWdCzlGD8nERTngFoz2dHX6reQz6ESbE0yt4dk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756425280; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nO3uRTV+51tCmahHSzswC5+DP1xOPTW2iImj0Yua62E=; b=MAyU7B5az8DFJeWR3ug8MZUyffdIew/i2bLgkffvm56NwL9MLe1H7cMY05De6sr74J3Aj11HgZK8Y0i90to9PDuf8/Bo0efO9oTa6RkEAUXpRpkRPBi5gEFrRa2MsjJn8HunFhY43E6EFaAKTXcCRDZxAO8UQY+9dbnRooMynoQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 175642528075995.19531019358578; Thu, 28 Aug 2025 16:54:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1100185.1453831 (Exim 4.92) (envelope-from ) id 1urmRn-0006aM-Gb; Thu, 28 Aug 2025 23:54:27 +0000 Received: by outflank-mailman (output) from mailman id 1100185.1453831; Thu, 28 Aug 2025 23:54:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1urmRn-0006Y0-0f; Thu, 28 Aug 2025 23:54:27 +0000 Received: by outflank-mailman (input) for mailman id 1100185; Thu, 28 Aug 2025 23:54:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1urmRl-0006Ai-6y for xen-devel@lists.xenproject.org; Thu, 28 Aug 2025 23:54:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1urmRk-00B9uc-2H; Thu, 28 Aug 2025 23:54:24 +0000 Received: from [19.12.91.86] (helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1urmRk-006h91-2H; Thu, 28 Aug 2025 23:54:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From; bh=nO3uRTV+51tCmahHSzswC5+DP1xOPTW2iImj0Yua62E=; b=fO+Lv+KaTvVTuj8aoVRYxR7D8+ kOvMvcGsxYEW8MWnnt7FuhFH0ElFBVQgc0Tdmv2sbPmJOOzJhxUg/mCRXao7d7vn4FAjcEhZQqPC2 H3ss4UsB6IE8JDePJwjJUKnyXMrSE186HXqA3TCH+JMQH3yT60ompIeBJXjKwp/21qzI=; From: dmukhin@xen.org To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v5 11/15] emul/ns16x50: implement put_rx() hook Date: Thu, 28 Aug 2025 16:54:05 -0700 Message-ID: <20250828235409.2835815-12-dmukhin@ford.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250828235409.2835815-1-dmukhin@ford.com> References: <20250828235409.2835815-1-dmukhin@ford.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xen.org) X-ZM-MESSAGEID: 1756425282172124100 Content-Type: text/plain; charset="utf-8" From: Denis Mukhin =20 Implement put_rx() vUART hook for placing a character into the emulated RX FIFO from console driver. That implements physical console forwarding to the guest OS over emulated NS16550. Signed-off-by: Denis Mukhin --- Changes since v4: - new patch --- xen/common/emul/vuart/ns16x50.c | 48 ++++++++++++++++++++++++++++++++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/xen/common/emul/vuart/ns16x50.c b/xen/common/emul/vuart/ns16x5= 0.c index d57695564329..1fb65370d464 100644 --- a/xen/common/emul/vuart/ns16x50.c +++ b/xen/common/emul/vuart/ns16x50.c @@ -804,13 +804,59 @@ static void cf_check ns16x50_free(void *arg) XVFREE(vdev); } =20 +static int cf_check ns16x50_put_rx(void *arg, char ch) +{ + struct vuart_ns16x50 *vdev =3D arg; + uint8_t *regs; + uint8_t dlab; + int rc =3D -EBUSY; + + spin_lock(&vdev->lock); + + dlab =3D ns16x50_dlab_get(vdev); + regs =3D vdev->regs; + + if ( dlab ) + ns16x50_debug(vdev, "THR/RBR access disabled: DLAB=3D1\n"); + else if ( regs[UART_MCR] & UART_MCR_LOOP ) + ns16x50_debug(vdev, "THR/RBR access disabled: loopback mode\n"); + else + { + struct vuart *vuart =3D container_of(arg, struct vuart, vdev); + struct domain *d =3D vuart->owner; + uint8_t val =3D 0; + + rc =3D ns16x50_fifo_rx_putchar(vdev, ch); + if ( rc =3D=3D -ENOSPC ) + val |=3D UART_LSR_OE; + + /* NB: UART_LSR_DR is also set when UART_LSR is accessed. */ + regs[UART_LSR] |=3D UART_LSR_DR | val; + + /* + * Echo the user input on Xen console iff Xen console input is own= ed + * by ns16x50 domain. + * NB: use 'console_timestamps=3Dnone' to disable Xen timestamps. + */ + if ( is_console_printable(ch) ) + guest_printk(d, "%c", ch); + + /* FIXME: check FCR when to fire an interrupt */ + ns16x50_irq_check(vdev); + } + + spin_unlock(&vdev->lock); + + return rc; +} + #define ns16x50_emulator \ { \ .compatible =3D "ns16550", \ .alloc =3D ns16x50_alloc, \ .free =3D ns16x50_free, \ .dump_state =3D NULL, \ - .put_rx =3D NULL, \ + .put_rx =3D ns16x50_put_rx, \ } =20 VUART_REGISTER(ns16x50, ns16x50_emulator); --=20 2.51.0