From nobody Fri Oct 31 03:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1756242571; cv=pass; d=zohomail.com; s=zohoarc; b=dHG+l4QtKp3rvo+NaWOX47aOW9o7ip7SZBx309pHHaiyK6Id5yuROVXMkHZBIeOIy6TAB0tHLVXXkJR/S2hzsWRt8ea+4TD8QCVu5inFO1Jz3SWId0+h+ZgwequrJomUKgoRf1cihw/K7jO/h1PJ798ojBuvIacuIecTJK+9BaA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756242571; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hb8jV7y+eU28UgOgIGo2GBFOvkJDnI7mqTnXWpd85l4=; b=C8WXpKtqcCEQAM84VRk1GxlYfF48LYJhAY6iSumeXqpXIkyKnZvBtgnS1gUM4Ew3i759IvIYXCrxOfNiAdElQl+z1bI2XANULATMdnjh7r30/2RagLADQ/fYHIpc06G1/nzm3AmE4NTM9TD8ayAJ/pjVgQaj7pC5EOLVPAzkags= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756242571760559.7857613823979; Tue, 26 Aug 2025 14:09:31 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1095130.1450254 (Exim 4.92) (envelope-from ) id 1ur0ul-0006ix-BV; Tue, 26 Aug 2025 21:09:11 +0000 Received: by outflank-mailman (output) from mailman id 1095130.1450254; Tue, 26 Aug 2025 21:09:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0ul-0006iY-8d; Tue, 26 Aug 2025 21:09:11 +0000 Received: by outflank-mailman (input) for mailman id 1095130; Tue, 26 Aug 2025 21:09:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0uk-0006HZ-0i for xen-devel@lists.xenproject.org; Tue, 26 Aug 2025 21:09:10 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2062b.outbound.protection.outlook.com [2a01:111:f403:2405::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e73480df-82c0-11f0-a32c-13f23c93f187; Tue, 26 Aug 2025 23:09:08 +0200 (CEST) Received: from MW4PR03CA0268.namprd03.prod.outlook.com (2603:10b6:303:b4::33) by IA0PR12MB8863.namprd12.prod.outlook.com (2603:10b6:208:488::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Tue, 26 Aug 2025 21:09:02 +0000 Received: from MWH0EPF000989EA.namprd02.prod.outlook.com (2603:10b6:303:b4:cafe::6c) by MW4PR03CA0268.outlook.office365.com (2603:10b6:303:b4::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.20 via Frontend Transport; Tue, 26 Aug 2025 21:09:02 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989EA.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9052.8 via Frontend Transport; Tue, 26 Aug 2025 21:09:01 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 26 Aug 2025 16:09:00 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1748.10; Tue, 26 Aug 2025 14:09:00 -0700 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 26 Aug 2025 16:08:59 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e73480df-82c0-11f0-a32c-13f23c93f187 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Plf6Jy8QQxDrgVSnHUYKyyiTd0jotDC3rleISMSWL8+P4w/0LRtQAHBZtu1IcFGXT81V1SN8Om8HStKqjW0WvaswRYrO7OPWRt00xiD23hUoyBnXCxHHuj4LzqFECbvwXhq7OZFGvMHEHaPjT7iANClaLRI3pYMOG6w1++V1XY5bKQGAHN7mmqJoAoi81IsIgXIfDSxbSZhgMO37TFw5Ph2rH8lK9487ZhF/g7gvGrZaDOW4lYZhbG7d7c50Fh3SRlpQWg/Ez2YkSx6GicfwyGxlknk3w31urTczJDvvcpwAF79qNovLWab98Cph4Y45r2L6oFD5vxq7TJ0Sl7vznQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hb8jV7y+eU28UgOgIGo2GBFOvkJDnI7mqTnXWpd85l4=; b=gLoRlQUUh+db+AfD5GbIAs7Amy3QHM9nIlboHyBfMToYKmGofjZQG04fjbsoOX4l97pnNM115QgnLT9xLIAby/zsd0stvq0L3bKTZ8FowEhI2DLjBTj/pvI2i+1yMkUp43mCElTDX+IBdK6EsHvfnt3QvC+rJyHzvj0w8tBgwQc4aivPA57BvQ/giLmHmpGQHmyLLkfDX1qTywd18eTVsTNsgaDqBP9SHZA0C5I6l9Xt3DSc73YMbyVGkzhWgjjAvUYlbatP0DefM1r9otxbL6wEPU/PNZtt7e9CuU37kSmzy0qMWF8y7p8gFGiXhdp65Z7H7IEt7fhj/PUisdNGcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hb8jV7y+eU28UgOgIGo2GBFOvkJDnI7mqTnXWpd85l4=; b=lL9RSeuxzyshbCrAt3+6DtSy6r0HcJMLbZPxjwbyfE+rN/KFyVdJBIS5M3eCPb/3wZMIcmNHrUarkdK7YmN9B8X4cyqwe20Td2ZU63/PrDUzvTXR84SfyLhapcF921uGbf/TdInxBJrolFDShc3GVKiCj+Ecj6nBYRgSC75zZns= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD , Juergen Gross Subject: [PATCH v3 1/8] tools/init-dom0less: Make handles global Date: Tue, 26 Aug 2025 17:08:40 -0400 Message-ID: <20250826210847.126015-2-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826210847.126015-1-jason.andryuk@amd.com> References: <20250826210847.126015-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EA:EE_|IA0PR12MB8863:EE_ X-MS-Office365-Filtering-Correlation-Id: 51b61009-9641-4a8b-a72e-08dde4e4c819 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hL7Fht0hLaEufo1NfQexMRzkIY4HseO+Bm511mNDBL1pHhsN8ihnBcGMIjPa?= =?us-ascii?Q?aXhiqdM1ESRNNjSqx1pokgmGoVO3vjzQdwaGuk0bN7oZc5/VEqi4Sq7C0mMy?= =?us-ascii?Q?4E9hfCrfdggML/SX/dzcAMfmRHh5NTwpZUsP66VJNjsbMsP9GnIY5L20EAZ0?= =?us-ascii?Q?gjzZgzxCKHgBS7+UMTDOApJLkbG48Efxy9mNjhZTeeRLD+D9unCyXWCDoQIH?= =?us-ascii?Q?sq8ybBbI8ZChEEoLs3fKChR8o1JZVVyMU8bv4/65iXJf/JV0I2+g+VTT3IVc?= =?us-ascii?Q?2IVg2vAJ15rMCiY2UBZEwMqQH7syigGQt+EDjy9y8sHj+S9APvT3Z2lQGC8g?= =?us-ascii?Q?eyewxcV+UaaLbCf72TGLIT7dNypAuRQg0RT6yLoJeuxSzIfDxAv3H2kwj91d?= =?us-ascii?Q?NIyWGBe9qGipzWAJjqsdWuNzqodozPeXr6UN+/kuQfeZEE1qpL4iQ9Kfi4cG?= =?us-ascii?Q?+icRKJOEpyx6bUTjS0OafblETZbaDmAxQImMAllTETB+ANj4gR014jS55dKR?= =?us-ascii?Q?5fntoHRUM5PDVo+1tUfkED68iAm3nixuPjMVK2YSyEPQuyHrI7O9x3U+kHFw?= =?us-ascii?Q?LcJBVRFb9tl+93ogTZC2nucyipke8AMALFSrug/y7W5mI22mo/sGTpoi6wUV?= =?us-ascii?Q?4q3WRgdCxjqMFONPfDhZWrmXZsRSUwAcvyQpFowOcKASv8bKCI5MNdUagSdX?= =?us-ascii?Q?S9gEPs2I9FqkuxC/h3MkibYeJWjLklVP6a3UAvt173uXf0UZGsP9Hf0uwaus?= =?us-ascii?Q?S27bav375jFvr8s3I1EbYwJoQiPyKphh/FhPnGuSZBC53CEDdWIl8OFfCy0c?= =?us-ascii?Q?jxwAbBLEiWLdmf37X8wppgaCKof0soQ4BiAfwB05ueqji0tkr3yMImvyDgf9?= =?us-ascii?Q?94o6FD1CFloRv3i2+TCjjX+KvsAUdIhMsFGNohStkBrOCRSS4Rsk9nUKuluT?= =?us-ascii?Q?rZjPMaimf9Xck964oCdXvecoIEG1MDtQ4UOzsbyWlYMAiw/2ThDj3vlAiJH0?= =?us-ascii?Q?FSrMhyvRHiosN/+4S6gqRMEXwhD+Sh/8vzpvLwaXG1dGJjjRueRMeyX6HI6o?= =?us-ascii?Q?HO+ko82J2iBVcP7kw1fiFO5aXEhVD19OxpY+n8eYpOLQ2kPdc1UMt6iE4yeC?= =?us-ascii?Q?4xagbKprBoYBls0FXS5yvvG/OhOv7JTpw3DL1/UvZcEpwdPBkSX1FVy8vfMC?= =?us-ascii?Q?D13HYjfxun6HU6DMFUKcuJHYNY3nwEWEgkZdgkL4RXQiI8QrcmZos0W9i5fO?= =?us-ascii?Q?JNaex7AsXTxiiVk9QxOiYQQlmcbkYO8M8qqb9Bi5Yv3IdK1u7n0ZRP5L08MT?= =?us-ascii?Q?RdOcncSUySb/SF7wmGKhaKdM5slihSGOUIlilVjf/ZoediAVsiWx2vgTCLTz?= =?us-ascii?Q?83wheVx2Q8zznTU8uP5OzWPb83BJQIW9B6/R4pZ3WQY4tHn+m6fucLcKsI4P?= =?us-ascii?Q?E8UHa/BuskjCdSNSwu7QiGSIolPG9BEKCRBjPnTxwDPouvF+jH467EDAGkvo?= =?us-ascii?Q?pSaSJ4nyu2LyLkYRvCusenJeUfkhTkr7dBjt?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 21:09:01.5946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51b61009-9641-4a8b-a72e-08dde4e4c819 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EA.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8863 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1756242574362124100 Content-Type: text/plain; charset="utf-8" init-dom0less passes the assorted xen library handles from main downward. This is a little excessive in places with 4 handles passed into configure_xenstore(). Replace the handle passing with file-scoped variables. The xenstore helpers are not changed. This keeps their implementation common with the libxenstore functions that take a handle, transation, and then additional arguments. Suggested-by: Juergen Gross Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross --- v3: New --- tools/helpers/init-dom0less.c | 37 +++++++++++++++-------------------- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c index a182dce563..0b0be08449 100644 --- a/tools/helpers/init-dom0less.c +++ b/tools/helpers/init-dom0less.c @@ -18,8 +18,12 @@ #define XENSTORE_PFN_OFFSET 1 #define STR_MAX_LENGTH 128 =20 -static int alloc_xs_page(struct xc_interface_core *xch, - libxl_dominfo *info, +static libxl_ctx *ctx; +static struct xs_handle *xsh; +static struct xc_interface_core *xch; +static xenforeignmemory_handle *xfh; + +static int alloc_xs_page(libxl_dominfo *info, uint64_t *xenstore_pfn) { int rc; @@ -43,8 +47,7 @@ static int alloc_xs_page(struct xc_interface_core *xch, return 0; } =20 -static int get_xs_page(struct xc_interface_core *xch, libxl_dominfo *info, - uint64_t *xenstore_pfn) +static int get_xs_page(libxl_dominfo *info, uint64_t *xenstore_pfn) { int rc; =20 @@ -111,8 +114,7 @@ static bool do_xs_write_vm(struct xs_handle *xsh, xs_tr= ansaction_t t, * The list was retrieved by running xenstore-ls on a corresponding * domain started by xl/libxl. */ -static int create_xenstore(struct xs_handle *xsh, - libxl_dominfo *info, libxl_uuid uuid, +static int create_xenstore(libxl_dominfo *info, libxl_uuid uuid, uint64_t xenstore_pfn, evtchn_port_t xenstore_port) { @@ -235,10 +237,7 @@ err: return rc; } =20 -static int init_domain(struct xs_handle *xsh, - struct xc_interface_core *xch, - xenforeignmemory_handle *xfh, - libxl_dominfo *info) +static int init_domain(libxl_dominfo *info) { libxl_uuid uuid; uint64_t xenstore_evtchn, xenstore_pfn; @@ -258,13 +257,13 @@ static int init_domain(struct xs_handle *xsh, return 0; =20 /* Get xenstore page */ - if (get_xs_page(xch, info, &xenstore_pfn) !=3D 0) + if (get_xs_page(info, &xenstore_pfn) !=3D 0) return 1; =20 if (xenstore_pfn =3D=3D ~0ULL) { struct xenstore_domain_interface *intf; =20 - rc =3D alloc_xs_page(xch, info, &xenstore_pfn); + rc =3D alloc_xs_page(info, &xenstore_pfn); if (rc !=3D 0) { printf("Error on getting xenstore page\n"); return 1; @@ -299,7 +298,7 @@ static int init_domain(struct xs_handle *xsh, if (rc) err(1, "gen_stub_json_config"); =20 - rc =3D create_xenstore(xsh, info, uuid, xenstore_pfn, xenstore_evtchn); + rc =3D create_xenstore(info, uuid, xenstore_pfn, xenstore_evtchn); if (rc) err(1, "writing to xenstore"); =20 @@ -310,7 +309,7 @@ static int init_domain(struct xs_handle *xsh, } =20 /* Check if domain has been configured in XS */ -static bool domain_exists(struct xs_handle *xsh, int domid) +static bool domain_exists(int domid) { return xs_is_domain_introduced(xsh, domid); } @@ -318,11 +317,7 @@ static bool domain_exists(struct xs_handle *xsh, int d= omid) int main(int argc, char **argv) { libxl_dominfo *info =3D NULL; - libxl_ctx *ctx; int nb_vm =3D 0, rc =3D 0, i; - struct xs_handle *xsh =3D NULL; - struct xc_interface_core *xch =3D NULL; - xenforeignmemory_handle *xfh =3D NULL; =20 /* TODO reuse libxl xsh connection */ xsh =3D xs_open(0); @@ -355,9 +350,9 @@ int main(int argc, char **argv) continue; =20 printf("Checking domid: %u\n", domid); - if (!domain_exists(xsh, domid)) { - rc =3D init_domain(xsh, xch, xfh, &info[i]); - if (rc < 0) { + if (!domain_exists(domid)) { + rc =3D init_domain(&info[i]); + if (rc) { fprintf(stderr, "init_domain failed.\n"); goto out; } --=20 2.50.1 From nobody Fri Oct 31 03:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1756242571; cv=pass; d=zohomail.com; s=zohoarc; b=jEOoYBY+M8+D7UXCSKNhmAxae9lPS7liRmi/5k++j7geFMPCOF7lVvAndNOLkzdvmDr1HmYk3bxYYt9TWq60ioJI5eZQ5sKfjfONd5aLpT2i7A2Q6b+0emRt/X1oyO2yUNMaleEPxg+hpeZbh6p4b6fY7cvikwK8+tqHbrZAcak= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756242571; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Zh8RyeKz1ZM0/lFRJbJVe9Xi6LtsKXP+OxMCeZpnpeU=; b=P0Z2hApv3g7Yt6Lz1Hoq0fGN1hJhIafgv50vS0GZxiM2A3D0OUPhbe2SKMyglcCwrnu6k0+gYLhSyEQRBFMmHoavhB9a3T/TuSiRkEprV0QZFvgbCw4vZHHiouhiqz9wPl4cqtVVTWW+N7eVkCY9nhgH7xP4/YqqzAd7nhGoPaU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756242571178986.3311786192747; Tue, 26 Aug 2025 14:09:31 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1095133.1450280 (Exim 4.92) (envelope-from ) id 1ur0uq-0007JC-CR; Tue, 26 Aug 2025 21:09:16 +0000 Received: by outflank-mailman (output) from mailman id 1095133.1450280; Tue, 26 Aug 2025 21:09:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0uq-0007Iw-5z; Tue, 26 Aug 2025 21:09:16 +0000 Received: by outflank-mailman (input) for mailman id 1095133; Tue, 26 Aug 2025 21:09:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0up-0006z4-FF for xen-devel@lists.xenproject.org; Tue, 26 Aug 2025 21:09:15 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20622.outbound.protection.outlook.com [2a01:111:f403:2414::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea50d56a-82c0-11f0-b898-0df219b8e170; Tue, 26 Aug 2025 23:09:13 +0200 (CEST) Received: from BY3PR05CA0006.namprd05.prod.outlook.com (2603:10b6:a03:254::11) by BL3PR12MB6593.namprd12.prod.outlook.com (2603:10b6:208:38c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.21; Tue, 26 Aug 2025 21:09:04 +0000 Received: from SJ1PEPF00001CE2.namprd05.prod.outlook.com (2603:10b6:a03:254:cafe::8) by BY3PR05CA0006.outlook.office365.com (2603:10b6:a03:254::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.12 via Frontend Transport; Tue, 26 Aug 2025 21:09:04 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SJ1PEPF00001CE2.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9073.11 via Frontend Transport; Tue, 26 Aug 2025 21:09:03 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 26 Aug 2025 16:09:03 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1748.10; Tue, 26 Aug 2025 14:09:03 -0700 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 26 Aug 2025 16:09:03 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea50d56a-82c0-11f0-b898-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vkyTdFAn7KprzTPkuvHbOTpnEZhoznnBGyVwyAin0D8h8iQ6AiKrmNbdmbN/8kUDkGS5pgBTbYf+r/3paVfxjCRTG5ekbelHPsMrkOzhpM+6FPDw3C7NpoRJZbBhMyMojy10Pc1LhM86BAhW9XTvgBKHw0fn3RnWpIVMy0G79SxjYQzUmK98KCGr2u/jdAxyWJ3BvDTFGXBTj5YMkjv+xcx6CQe+c7Az59z9uM25gvVW7jwhJ7DEFJxPx21LpN4grduD5ayR8Q+1XUJhshUMAojFutgc7t6Lpdapudr8UeBdDbKl5OBMBCIxYRCGAIRsRn/p04zcK7doTOZh85moGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zh8RyeKz1ZM0/lFRJbJVe9Xi6LtsKXP+OxMCeZpnpeU=; b=Hwhf+/NaN+gyGEdIUowDyaAY0VF53uTpeB8IJzDLvGeSkz9NGQqUN93dUyNgY3xrbJgfcZ7C7CVihNF5Lh44Gf9mK+YOpiLGQTtB5lNiypruFWQYKlfaE7WqraaiC093FBsXnIslVFBFpnD2mf2WeIQ/SPjCwc6mfCx5efoZRE+uFmU0v2jKGpJBvGvft3ACCRAqp0RXQgBsrkx0ImWI4xH0aGBP21ELZRJuSCcvIyEoEa6MpPm8noy+id54CzPXJ1pn03qJip1E4t6qZ3iz6d7ShsfGmOVWx8e1qqvhfddiPPbOcdGJGTrG70hOHJNnLNDHh5xnSHdfBHPj1Mo9SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zh8RyeKz1ZM0/lFRJbJVe9Xi6LtsKXP+OxMCeZpnpeU=; b=ET+7LMP/cNLqDLZ3Mn+MxvUPcGpjtojs/BcR/NwWVESMYKjox2I0K6rbhjH80P6WllcloKwXw40CwWYv5AicMaRYXmUWEHVzpxFMsXqAusCTGcdYsf2ATWOn3cAYim0ZGNeYIAWPO+GiTAJxgV8AL84TwRaEu+yii2dACqeYanE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD Subject: [PATCH v3 2/8] tools/init-dom0less: Factor out xenstore setup Date: Tue, 26 Aug 2025 17:08:41 -0400 Message-ID: <20250826210847.126015-3-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826210847.126015-1-jason.andryuk@amd.com> References: <20250826210847.126015-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE2:EE_|BL3PR12MB6593:EE_ X-MS-Office365-Filtering-Correlation-Id: 66d20738-c757-4f14-af5b-08dde4e4c967 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XE00tK+IQAjAgwwtUoNRXIvuWXR3w4460zCE0Ym19haPbsjHTIRqnzop2ues?= =?us-ascii?Q?jOEyDryjFrO+7manQu6A9jmL+163Mfn3ZezMAqTjXWT8yXQxh6rRweBhx3Xm?= =?us-ascii?Q?HtGJqtJVfw3Z36gXmn4LuvM9QYF8PgletWvT60XSc1+ybk0mJqetbE3JX1AH?= =?us-ascii?Q?Z/Tr3OqR8FaGqlUf1UfhR+p7yq3R+fyTEIF1fHGlfMgIKzoxOCf6HkkuSil0?= =?us-ascii?Q?nT3RboIqJlGcDhJgCCPLKIZ9neyHSdOZ9Azs9OOAVUDQi+p7FHDxuqZ//TtI?= =?us-ascii?Q?USCXP9RmrD6qWdJwvaULsRRTKL3QUOc2/QClW7uN4e/YgKnHnKJ5ifL36sVN?= =?us-ascii?Q?l5YqdW2RC08BehTRXTAq9PQ3PDm8FmryqKaRfRo02FjPm/V9ASshbx6ASsbN?= =?us-ascii?Q?6sPkvIGgLo8MGkyC7NxamljRO6oxnL2O/A0Zke9yXoI0MoUFv/2Hrh7C0ysc?= =?us-ascii?Q?HhQ3l9uswY/Ij07tkdjSxv1n4/p16BGU9Ygu1SCaZ4dSGc203RwQS8DT7GRz?= =?us-ascii?Q?Fi1eGN++cAhVolhBD1WE+4yPnYrSg6yKewW4ZnCECDZyuvA3ZVkYQqqG7RST?= =?us-ascii?Q?FznhqvLpuXB697T71ZkzqKAkYjU3LjCpSmCPBQ9by0HkvioVZKTrXgu9b2Ip?= =?us-ascii?Q?XtKHpeiXhqvc9inIKiLFjjM5R6MbG9de24+0V++xEU9gK2muX479aESYiwmW?= =?us-ascii?Q?LheEaSgMOxL9pFek4OXUtzs4gNQelIAN5DoRYGyETnCzObzgNa2VK/+AxcwL?= =?us-ascii?Q?3ikw8W9Sb2w3yuUgh79PWIadRaux6YTnXEZvW3EdqqUB51TKXO6hiaxyorfq?= =?us-ascii?Q?/T5+0g/+yBL8d/C4GRZ/a+mWpTLSvrcZc8PJ1NiN2QvFfnFSIMGk1B9/g1M7?= =?us-ascii?Q?G0RuOB8TFEPp1M8kKvXf7gFbBWx/qKilOb932gf8MbzMigMWh7AtabzRC5aK?= =?us-ascii?Q?tLxaJ79auxubQ3XSgkVab5Hrc2trfo/4bG+8RilV5S/ySKEkTiVCbYvgSoSC?= =?us-ascii?Q?/J6mkK43olUsynpdnphTiEvvpvJ7lN4DzIorOlI4Lo+uIkYxRP6nNbX0lVmM?= =?us-ascii?Q?bcNKGKXU88lNXWfDTXnjtKcPoth70UCNgHuatfub0uRNw7R/hUK3Deva55S8?= =?us-ascii?Q?JlX4x69RdOH88NuMxG8bh8nbhMQFJ5RxXcZeqdDLjv7K9Qv+2c0RFPaob7wN?= =?us-ascii?Q?V1H8K/ZvxxiMJ9Htp9ThsS2q9N2TYTRMTK3peNEoUB/LuI0wHkQpPt9EymvK?= =?us-ascii?Q?6h53cs2OFcN12OpnylBqMqkZs3dNRAhkhLHj3v2sFB3GXlQMsFnjArRXaKgA?= =?us-ascii?Q?Nb1oZMYdhsvYMH+h4G6wm4OqIyMSql+iZOAfcBLW6rtLRFlqHPACcUXdL9wH?= =?us-ascii?Q?2TLAuNsxa6x5x0rdIcUOGgjS0/OnDAVyV034OWMZmuLJtXUXLwlHFhEejYzz?= =?us-ascii?Q?wcuTYcziwYwgpzRClWkRAz8+xYag5OY5PaIwtyBXreRxt6BL1zk9vItRe7wu?= =?us-ascii?Q?86vP41tGp8y8N0wYT0Io0a2+tRwMJg/Oibqh?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 21:09:03.7822 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 66d20738-c757-4f14-af5b-08dde4e4c967 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6593 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1756242572502124100 Content-Type: text/plain; charset="utf-8" Factor out the xenstore setup code into configure_xenstore(). This is in preparation for handling already-introduced domains. Signed-off-by: Jason Andryuk --- v3: Remove handle passing --- tools/helpers/init-dom0less.c | 39 +++++++++++++++++++++++++---------- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c index 0b0be08449..8de8e44ad3 100644 --- a/tools/helpers/init-dom0less.c +++ b/tools/helpers/init-dom0less.c @@ -237,40 +237,40 @@ err: return rc; } =20 -static int init_domain(libxl_dominfo *info) +static int configure_xenstore(libxl_dominfo *info, + uint64_t *xenstore_evtchn, + uint64_t *xenstore_pfn) { - libxl_uuid uuid; - uint64_t xenstore_evtchn, xenstore_pfn; int rc; =20 printf("Init dom0less domain: %u\n", info->domid); =20 rc =3D xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN, - &xenstore_evtchn); + xenstore_evtchn); if (rc !=3D 0) { printf("Failed to get HVM_PARAM_STORE_EVTCHN\n"); return 1; } =20 /* no xen,enhanced; nothing to do */ - if (!xenstore_evtchn) + if (!*xenstore_evtchn) return 0; =20 /* Get xenstore page */ - if (get_xs_page(info, &xenstore_pfn) !=3D 0) + if (get_xs_page(info, xenstore_pfn) !=3D 0) return 1; =20 - if (xenstore_pfn =3D=3D ~0ULL) { + if (*xenstore_pfn =3D=3D ~0ULL) { struct xenstore_domain_interface *intf; =20 - rc =3D alloc_xs_page(info, &xenstore_pfn); + rc =3D alloc_xs_page(info, xenstore_pfn); if (rc !=3D 0) { printf("Error on getting xenstore page\n"); return 1; } =20 intf =3D xenforeignmemory_map(xfh, info->domid, PROT_READ | PROT_W= RITE, 1, - &xenstore_pfn, NULL); + xenstore_pfn, NULL); if (!intf) { printf("Error mapping xenstore page\n"); return 1; @@ -281,16 +281,33 @@ static int init_domain(libxl_dominfo *info) =20 /* Now everything is ready: set HVM_PARAM_STORE_PFN */ rc =3D xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN, - xenstore_pfn); + *xenstore_pfn); if (rc < 0) return rc; =20 rc =3D xc_dom_gnttab_seed(xch, info->domid, true, - (xen_pfn_t)-1, xenstore_pfn, 0, 0); + (xen_pfn_t)-1, *xenstore_pfn, 0, 0); if (rc) err(1, "xc_dom_gnttab_seed"); } =20 + return 0; +} + +static int init_domain(libxl_dominfo *info) +{ + uint64_t xenstore_evtchn, xenstore_pfn =3D 0; + libxl_uuid uuid; + int rc; + + rc =3D configure_xenstore(info, &xenstore_evtchn, &xenstore_pfn); + if (rc) + return rc; + + if (xenstore_evtchn =3D=3D 0) { + return 0; + } + libxl_uuid_generate(&uuid); xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid)); =20 --=20 2.50.1 From nobody Fri Oct 31 03:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1756242570; cv=pass; d=zohomail.com; s=zohoarc; b=FXvG6WdVV+hiON7iOqDrbE/87jNv1K72/bAt5lLkyWnZFnxRk1F4jdKn+A4bE89Jv8Eo2AtexGwLkw27a25i0DjldBb2GYW5cgvlWwIMiqGmNZugtt/OxysAcFe45Q+Fxupkk6layu4SCEE3cuVWSVU3WTzXvkXuv0A3WmBxAsQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756242570; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O1nbcQMEjUBeFeC495BtfRnJCx+JGQKE9Ow3xrFdZyA=; b=L4hVDNcQR73DkKQu6421SBuy3kqNlYhEQDAU2dtFi92fcozH4p/EGPh9El0dUBTjlTukzRQYHImjzyrrmWcEytrOLeUWpu7MzKn6oEtWYiKVlzaQLGcRDV+CcMVkYRPcznotLPLkDGdTNmqMoAM+Vsv0oe4qC0Q7T/orIWaOjoo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756242570342664.2428604351384; Tue, 26 Aug 2025 14:09:30 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1095129.1450239 (Exim 4.92) (envelope-from ) id 1ur0uk-0006KP-7r; Tue, 26 Aug 2025 21:09:10 +0000 Received: by outflank-mailman (output) from mailman id 1095129.1450239; Tue, 26 Aug 2025 21:09:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0uk-0006JU-2c; Tue, 26 Aug 2025 21:09:10 +0000 Received: by outflank-mailman (input) for mailman id 1095129; Tue, 26 Aug 2025 21:09:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0uj-0006HZ-0i for xen-devel@lists.xenproject.org; Tue, 26 Aug 2025 21:09:09 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20604.outbound.protection.outlook.com [2a01:111:f403:2009::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e743e1f7-82c0-11f0-a32c-13f23c93f187; Tue, 26 Aug 2025 23:09:08 +0200 (CEST) Received: from BY3PR05CA0007.namprd05.prod.outlook.com (2603:10b6:a03:254::12) by CY3PR12MB9554.namprd12.prod.outlook.com (2603:10b6:930:109::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.20; Tue, 26 Aug 2025 21:09:05 +0000 Received: from SJ1PEPF00001CE2.namprd05.prod.outlook.com (2603:10b6:a03:254:cafe::68) by BY3PR05CA0007.outlook.office365.com (2603:10b6:a03:254::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.12 via Frontend Transport; Tue, 26 Aug 2025 21:09:05 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SJ1PEPF00001CE2.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9073.11 via Frontend Transport; Tue, 26 Aug 2025 21:09:05 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 26 Aug 2025 16:09:04 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 26 Aug 2025 16:09:04 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e743e1f7-82c0-11f0-a32c-13f23c93f187 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cNMaNmKhwa2ssg4KDbuKe0xaCNuCDW1jtZPx5qh/iONpalsAkCRgwui9qG36waMy28JrGOgsHyanAy8TI0CP1b3kWGUXDMQYh4Zu5uxFZ+TwvN3yboI7wFgoQF4cajh7R8prLL/WMpx7Yb6FO4gxrTgZLpWcpYGW1GZq/a7qIsqF55P/piqnWIoSdfDH6VBokelaHE22gFevS1coQw3mnOV6wGuKjDpk0ZD6OrEgjT61QFOmbpyvJJRgH+nAcZ1jx8y0mztDIMHptTnWWorkZvRh1MPBUw9BSIK1j6k6aX5n3/eXryZPkwenRNcV9UcOJLnCs5vP9EUy87kxfnVEVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O1nbcQMEjUBeFeC495BtfRnJCx+JGQKE9Ow3xrFdZyA=; b=wXoPzQ2JzGgDMrkHE0GL4WUQTxXTVmg1rRrG89iak1XbfQInHr2QYMImRW64Oo+YB3mI91FbKjNXejDp3npgYxcp2KFZOn60SiccgAX9G8k0dyxOeU2uPq1yyF037+Ba/s5RQhCNX565IMr7GxEAhmgl5bNozGRDC9P6ETzM+CDafxifJ5YaVwWC47NhFOMoRv3FLFnjD+h6t+6cCKV2zjKKPnv6wUt5kBCt3pQUr1UrRbGCLqFQ4cRuiUpGl2LcGAXV+6Ceud+9ZH21Ylo54XO4dNOHhyhBa2xwBVyvoB/S2D9BzXkvsaVmUzJLtiLCEBq1pWvBNxgJfPerNstRqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O1nbcQMEjUBeFeC495BtfRnJCx+JGQKE9Ow3xrFdZyA=; b=yBHDim6UbAwtKXv3akA7YM4AqJB0bbRGR+sYVn6qWLkO3pIiyObhU1sRNGdLvGo7O0FHYre6BHz1nGSp8zVSACKX4IL8vGc2sqs0N8q0sd/mjwMG7uVf+hzzjDfoHOqrd804fvDS7ByAlfce0c605cOj2YUu4HCRO4WmxO+5YhQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD Subject: [PATCH v3 3/8] tools/init-dom0less: Only introduce un-introduced domains Date: Tue, 26 Aug 2025 17:08:42 -0400 Message-ID: <20250826210847.126015-4-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826210847.126015-1-jason.andryuk@amd.com> References: <20250826210847.126015-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE2:EE_|CY3PR12MB9554:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d03469f-37ed-4b66-5a12-08dde4e4ca81 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?z/RCuerTPypvrsqVfQbz1lcJlku0auAyoz2wIcIoPdUZs++hVlybkBGAuORW?= =?us-ascii?Q?jJf91bqNLZwlTy/u/CL055SusKcO1deI38S1kI57Vfle4mXT7lgCpN57We2s?= =?us-ascii?Q?Gk9XnyYwmgfbmmOlsL1Hi7Df3OoCmEyy7yNQ68DYc+D9T/YeUqXMU9HFR/T5?= =?us-ascii?Q?KYFA4FsbCWArFr8dHlmhmtW1ccUbNbTZTDM54mVQm+snaDZhU2ccynQpOyXR?= =?us-ascii?Q?kiApE25FpEbd6Tv/mHMHUD2QGO0V4ST9NbNldNPBdyYzL0wcxuQlbgGVT9PD?= =?us-ascii?Q?LDxfeQnQ42J7tImYsh3XSS9wJWGIvBvpDoIzXpf0uHtr1z9JzvPp7y3W2QMQ?= =?us-ascii?Q?HVLPKMciqspnvHpV8PtRSVCFn4OPfmBLM/W7jmo8raWIBWfGTAebhEtKC4LQ?= =?us-ascii?Q?gZJxStbUbhi34EkYhMr/A72vfUmyQ+cwtriCM0vQlNHJr/Y2i7hpgi0H1F3Q?= =?us-ascii?Q?ZydmsXD7UNIFPg/PwWc2DIGyQpZd0SUjl2Sh45EPnFnryc7Rbx7A27HXInse?= =?us-ascii?Q?HHmZeiKLKIyoy6lDqiZp1syHTtV0ap4UtY2kKNfl5TzSU8HwU33FmXR1/KsJ?= =?us-ascii?Q?/RSbmbiyzvmmbCfx4QvzUef29JjQQ7eqDXaTob3EWX+PrmHdr42kIlBOqnjD?= =?us-ascii?Q?ynAIhBxo6uYEECfyMJgdZDPxi4pPWjXsYDsY1Pr6uZ+/lQ9VBJM5F4nc7a5i?= =?us-ascii?Q?BgGtcYUj9f8sbY1s2WmJdFXPy38Jou5RLMl6CEgaB7PULkgwOAz4/bRGYZav?= =?us-ascii?Q?+lpicGCuT06EVz88cCEhS29lXQVgw8FB5BA/Hz2zGkBr7nsXCifus3FxVWfC?= =?us-ascii?Q?RGpxR6yp41qRM9G0CVarjorD8gjx9z5v8tpBW9zAtHOKtUvWm7cIONBr9jnY?= =?us-ascii?Q?M3y1AkK3bEPBAOAwHI08qxlpAB2CQ2mItuXFxMd/VeA8uWMOgYg6vucvdhhj?= =?us-ascii?Q?XM66DhH/Z4byzojmiEfieuH5LYsT7wzegPIIqtp88/rmP5WJ/tAT5dqFhpOX?= =?us-ascii?Q?AfTSTSD5ld30kwUCphxHuf1UJTNm2w4LYPlMgngambGiL19L6icBoX1/bd15?= =?us-ascii?Q?ltGUCgyrWPvFkHWgmVdBBn4rXSHCWfXC7kO75nqWUo1sj3l1qoSl6S5X4lDn?= =?us-ascii?Q?w7H6/JQ7G8xvJzJU2jGenJI52lSF0uxiKcP87rnrj39UpHCvrjush1nq1TQO?= =?us-ascii?Q?RJK1u2wJWgme1vMEydp27EmKxptBXWMGvFqnu3bSxCH+p9Sau0UzADtkZf7b?= =?us-ascii?Q?/LRHBTxE+Gw0jKPbUsHwk9RSYUc7GDur0lTwIWkev8NuDVC7T9voG5wfPveO?= =?us-ascii?Q?DDybruWlujDwfgqCcimvqjEtWrfHgGcdawYLvH78AUyBAnHBxm5+0fiTJPot?= =?us-ascii?Q?JlHyCdBnhRIwcTavyM2UJz617lYamyAzLM5gbZv4edK/jkbG3ec9+6Fg5DNF?= =?us-ascii?Q?JZUZYA2dbycrY3C9K7zufy91DNWzwm8/8vKrTecmIZkOb/1H7NoXiTFd0z4C?= =?us-ascii?Q?aF/7afEozqommJhym51sn9diPItjeS+zW+s5?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 21:09:05.6275 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d03469f-37ed-4b66-5a12-08dde4e4ca81 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY3PR12MB9554 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1756242572360124100 Content-Type: text/plain; charset="utf-8" In preparation for supporting already-introduced domain, only call xs_introduce_domain() if a domain is not already introduced. Their xenstore entries will be written, but the xenstore introduction is skipped. Signed-off-by: Jason Andryuk --- v3: Reordered --- tools/helpers/init-dom0less.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c index 8de8e44ad3..3906c4b61a 100644 --- a/tools/helpers/init-dom0less.c +++ b/tools/helpers/init-dom0less.c @@ -319,9 +319,13 @@ static int init_domain(libxl_dominfo *info) if (rc) err(1, "writing to xenstore"); =20 - rc =3D xs_introduce_domain(xsh, info->domid, xenstore_pfn, xenstore_ev= tchn); - if (!rc) - err(1, "xs_introduce_domain"); + if (!xs_is_domain_introduced(xsh, info->domid)) { + rc =3D xs_introduce_domain(xsh, info->domid, xenstore_pfn, + xenstore_evtchn); + if (!rc) + err(1, "xs_introduce_domain"); + } + return 0; } =20 --=20 2.50.1 From nobody Fri Oct 31 03:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1756242577; cv=pass; d=zohomail.com; s=zohoarc; b=Y0MbAZwEs/W7Pbq1vynZOmquTteYtQs0Sq8Y7SAyLc6ikPbLuo/655tKGgJeRdovoPoj9HugSULT18kefxDNDyreoLA5Lf/8t5b9MZvWd3vYn+/XRCIOpPewfNB9dXDWana/4QXwRi5xPI+xhwzx27rRFnoAUA6do9S/pfj0xEM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756242577; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uzDGiHAVkJNpJC5uvjQt5odWyjWh55jkKFPNsbwPekg=; b=DXlv8bMWRW4avlsDNeIQrkSOuM0bdKBuQiK4imTxAm3vh53aFhHyz3xsasgiwA3dDvi6rX7H4IjQg4nhaN9psNSqDQRnEJu+CriZhdUIuc4cwMoAGDNkphB0U9MmsztAHvvxkF8DbaYmNPODJVoFT9N+mpRke+ShzuUOPD7R3Nk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756242577765871.3233189767114; Tue, 26 Aug 2025 14:09:37 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1095134.1450294 (Exim 4.92) (envelope-from ) id 1ur0us-0007nK-Ra; Tue, 26 Aug 2025 21:09:18 +0000 Received: by outflank-mailman (output) from mailman id 1095134.1450294; Tue, 26 Aug 2025 21:09:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0us-0007n1-NE; Tue, 26 Aug 2025 21:09:18 +0000 Received: by outflank-mailman (input) for mailman id 1095134; Tue, 26 Aug 2025 21:09:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0ur-0006z4-96 for xen-devel@lists.xenproject.org; Tue, 26 Aug 2025 21:09:17 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on20619.outbound.protection.outlook.com [2a01:111:f403:2406::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7e23995-82c0-11f0-b898-0df219b8e170; Tue, 26 Aug 2025 23:09:09 +0200 (CEST) Received: from BY3PR05CA0017.namprd05.prod.outlook.com (2603:10b6:a03:254::22) by PH7PR12MB7330.namprd12.prod.outlook.com (2603:10b6:510:20d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9009.14; Tue, 26 Aug 2025 21:09:06 +0000 Received: from SJ1PEPF00001CE2.namprd05.prod.outlook.com (2603:10b6:a03:254:cafe::c) by BY3PR05CA0017.outlook.office365.com (2603:10b6:a03:254::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.12 via Frontend Transport; Tue, 26 Aug 2025 21:09:06 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SJ1PEPF00001CE2.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9073.11 via Frontend Transport; Tue, 26 Aug 2025 21:09:06 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 26 Aug 2025 16:09:05 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 26 Aug 2025 16:09:05 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7e23995-82c0-11f0-b898-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nrmole8tNjK5U2NTpcnCCBcoVgfG9yQAj1ennxuw9MT/+Bv1iceWuzeWailhyMN9hP1z49Jhp9JUeu6+UBEugFySD1HNNaTzjEcGhzFKC0YcPbu1pMfpTN3jiYDmkHFWekwcUDlSIMhJuEBkdZFZccmoniIpOZGOvT8l3L+KoN0We+bPRvjQcabWumJLMNgXIvfXUiZ6Li+JehlHo5S+WK0XBaKsue7Cblc1MhY7Iblr292eXVnXl6HENwQd/PwGUpMsk5g3qcPVelAc3gjy+YyAkLlqX9gWGzYDzjknDPtTow4g4gzOd60XKcFUD18TOiCVICAb/yZRLqtzgbLDNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uzDGiHAVkJNpJC5uvjQt5odWyjWh55jkKFPNsbwPekg=; b=ndekwmTYHOg/DI7VZ+4Zk8etT6nJpanzWfiQ4TaFZ7UIghxNrTX7u2gsVhnTzYlxF50+Glx+tAQfkEgNEIIOq9jNtaa5bTTRVCf2LLJDYkbYe6p8852dL+Z+XdyIphb0WX64sJq3oSU74QoYgWzwb8imsDuim+WhsmjMb8Tfh+xmum1gOhLzL62nTLpUFlsLXKIm/KhXyxYoy4Ug+Q9ZvfoveHz74VVfC98wbBJk8A44T6fLBoQ25m7YocGd9sihQlT9VLaA9NaGGpmT6WahiVbcqZEwHDMyz6W8WgfvSf7pwl36852cj3dXNBgAiJjl33iXMDtnGm03jho0ZGIOHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzDGiHAVkJNpJC5uvjQt5odWyjWh55jkKFPNsbwPekg=; b=l2IdRh75+bx1DRyVZYAVSxQ6GYvxG349Ml1rMXGN4rPLf+fHGwQuGMr1KIxx2siUrmd4B3GcsQr4jvyV8/UdEWMvSsi30N9pkocdX/OaGr2hgSrrbibsNPdWiDtZGk9p4SPNeOsSlMy80UsZFc9Vu6mQ4WKwytI5W8PmPBH0Yso= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD Subject: [PATCH v3 4/8] tools/init-dom0less: Switch domain_exists to check xenstore name Date: Tue, 26 Aug 2025 17:08:43 -0400 Message-ID: <20250826210847.126015-5-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826210847.126015-1-jason.andryuk@amd.com> References: <20250826210847.126015-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE2:EE_|PH7PR12MB7330:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b7660a6-6657-4480-26ed-08dde4e4cad1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aaKThxY3Ik79VNrV5Wk77Kpm09H5RGFhe/J5eJCs/uZWiLE79b9fOYtPdH4i?= =?us-ascii?Q?Tgi/6d3gTeA2cb3Y36bbFXlLtQphzqgiry+wuyGnnSCZaRmXd+iFGQKGw98q?= =?us-ascii?Q?lH/5RteXsSzBvHC7DCIk6fAP+0dyRBD4pEfChqpwEipmNe1maiJS+KWmTNPq?= =?us-ascii?Q?m77rt4hD2y+/JeG6qqVnjGnNdcekGe6gLG7EcguB/IPdGiQuN56hDgSsJkFL?= =?us-ascii?Q?4/3lPQLrAZ69gnX8bxA5aSP0EqkscDdQ0QTAChuQwp4e165emoUmO1VUJm4Y?= =?us-ascii?Q?DRpyDSSf/cDqbWzPcxJhx+k29jql7bY82euH+7Hx/6ZXwuSPe1ZsEI6K2daZ?= =?us-ascii?Q?WjRlMKU/57DqG1EVBMg9l6WFtf5ec3JuwzzGwHAXuf1Zr/HS4ZJXvnXTcs5v?= =?us-ascii?Q?tqrCAzyzfcCLz8PSn5CKvA4xUoFi29XUNxOWLLEkWFy7bPB192Rgxdqd2Jfn?= =?us-ascii?Q?clvPO1RVVFhXUbxDxCydAY0zINTxG/l3mDnMK6NDBnKNI41ilScxxDDFaG7J?= =?us-ascii?Q?djUniZOgaW+gBHdRpIpun8buldIAFMLVa9vASCqthpQQYnU2L84giXGOIgNB?= =?us-ascii?Q?BhlWmi2IWVFlnqer91AFxq8MxqBdn8t+LUkoMXyO+X2hh7S0fwFMM8xZx+hl?= =?us-ascii?Q?C4+S4UDHCPyIGdCR5dh2kJmGA/lWyXrN18un/6VHemd4QgqY5xdCtedm7SMz?= =?us-ascii?Q?lXRy/0K8VR10IU8JhmDqoM8Q5wLsSrMvFt2D/wIq2jTh1LVXJvZr5ZwETe2X?= =?us-ascii?Q?44xNcZYrohU2XUOw5rR2IkZCMlslPFVqMTcPCTKvosEsI+bUcsgGuXmk79jB?= =?us-ascii?Q?42WbSG3ZRHUrEzcAyp071VNNJr3NchGOZ5wU5BLng168IfCzbuSTaGTx4r65?= =?us-ascii?Q?e6fqs1XKl/Ye63XOJvBx3Ex4VoW/gcfMApxy3BJ16vQACDiGzaSWVW3B2fFq?= =?us-ascii?Q?zomXl0Iq8Qa84nzTp3Sk8vMsKwZEsoJxVBGNOxuhNibao8wACzhHhiizHd2C?= =?us-ascii?Q?pw75E05TSsatoBvmLZz5ggBk5TirEP2oFM4ZKtYVKVrO8W1lLnSiL3cfZEud?= =?us-ascii?Q?XpyPqjI1WPVPib8q7vXIXTQOJWsBa11R24C3StcfoPKl6ESp5pNgwVPQ+DrH?= =?us-ascii?Q?OLwWSYmt4u0O7KNyaQnBXLeIfQbfb+BzS+XgvomesFUecc4HGBOFimS+ZjYe?= =?us-ascii?Q?Kc6H49NUTx8IakI42oGm4h5q8n/sQDCFotLhOjCJy2ySwAUtFFwol/uokjxL?= =?us-ascii?Q?Bklibt5a36sA3ryFEKzHyLnsVWWLkH4NFIZjMaCJUGaRjw6fDyEiuFKiPj5J?= =?us-ascii?Q?SJHA3gCuiXbq9wh6JjI9tlLwmcoItVNlr5ApLhY4yd/4m8O2hUSo5yl9YpDs?= =?us-ascii?Q?SxhwfwEaH+UieKWndQtPLdNF0R40oqYzGrcw01lxDjS3SUYguWj254t57aTa?= =?us-ascii?Q?V7I4o+B4bVGUbJUE9GDUVbGp6T4IBCXnFCZ1/14ZKYcJD58UsTku4cGLu/RZ?= =?us-ascii?Q?QNsROHHyznwpCXdKY7Q6ch/9hH6LZ5wKJVp/?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 21:09:06.1491 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b7660a6-6657-4480-26ed-08dde4e4cad1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7330 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1756242580540124100 Content-Type: text/plain; charset="utf-8" Previously, the xenstore "introduced" state was used to avoid running init-dom0less twice on the same domain. With xenstored auto-introduction, that can no longer be used. Instead check of the domain's name has been set and use that to determine whether or not to bail out. Signed-off-by: Jason Andryuk --- v3: Move xenstore reading into domain_exists() Reorder --- tools/helpers/init-dom0less.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c index 3906c4b61a..eb793c7aab 100644 --- a/tools/helpers/init-dom0less.c +++ b/tools/helpers/init-dom0less.c @@ -60,6 +60,19 @@ static int get_xs_page(libxl_dominfo *info, uint64_t *xe= nstore_pfn) return 0; } =20 +static char *do_xs_read_dom(struct xs_handle *xsh, xs_transaction_t t, + domid_t domid, char *path) +{ + char full_path[STR_MAX_LENGTH]; + int rc; + + rc =3D snprintf(full_path, STR_MAX_LENGTH, + "/local/domain/%u/%s", domid, path); + if (rc < 0 || rc >=3D STR_MAX_LENGTH) + return NULL; + return xs_read(xsh, t, full_path, NULL); +} + static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t, domid_t domid, char *path, char *val) { @@ -332,7 +345,13 @@ static int init_domain(libxl_dominfo *info) /* Check if domain has been configured in XS */ static bool domain_exists(int domid) { - return xs_is_domain_introduced(xsh, domid); + char *name =3D do_xs_read_dom(xsh, XBT_NULL, domid, "name"); + if (name) { + free(name); + return true; + } + + return false; } =20 int main(int argc, char **argv) --=20 2.50.1 From nobody Fri Oct 31 03:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1756242580; cv=pass; d=zohomail.com; s=zohoarc; b=U6K/bbrl9zvX4ZHM5cKc56XTJXnE8NYDxKJY25La2clckAhmvS5JuBSaX0R6ngQm1XHNvvJKyrgBf2Zs+3zBkQK/YyHFPbzP4EsCtqArS9xeq1cVwDQ22iLirHUw28mCG6WgFXvA8XWH6nh/YCCA0/3xJh04i40Z/RDBcS7KUqY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756242580; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kx6d34oYfnXViK0Sv04HljBO4lYFdDa8TSdzHSfLUho=; b=HA3sJDo7hJOpdePF9q8qHT7CVYboQVfTeYzqimscE0BQeJvf2kjGHCSyW+LD0kdl11aw8vPWutfGhBhI1z+kA4/fiiq58yALI9oN16M0vaUt/tDErYhdo+rkvQ3kAA71NwutNlwMRGAu8NM2TOhUaqeg20ZhJqa6OyWojN5fILk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756242580167645.996967070298; Tue, 26 Aug 2025 14:09:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1095132.1450275 (Exim 4.92) (envelope-from ) id 1ur0uq-0007F8-0O; Tue, 26 Aug 2025 21:09:16 +0000 Received: by outflank-mailman (output) from mailman id 1095132.1450275; Tue, 26 Aug 2025 21:09:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0up-0007Ex-Rl; Tue, 26 Aug 2025 21:09:15 +0000 Received: by outflank-mailman (input) for mailman id 1095132; Tue, 26 Aug 2025 21:09:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0uo-0006z4-Qg for xen-devel@lists.xenproject.org; Tue, 26 Aug 2025 21:09:14 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20621.outbound.protection.outlook.com [2a01:111:f403:2415::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9e779fd-82c0-11f0-b898-0df219b8e170; Tue, 26 Aug 2025 23:09:12 +0200 (CEST) Received: from MW4PR03CA0244.namprd03.prod.outlook.com (2603:10b6:303:b4::9) by SA1PR12MB7272.namprd12.prod.outlook.com (2603:10b6:806:2b6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.21; Tue, 26 Aug 2025 21:09:08 +0000 Received: from MWH0EPF000989EA.namprd02.prod.outlook.com (2603:10b6:303:b4:cafe::52) by MW4PR03CA0244.outlook.office365.com (2603:10b6:303:b4::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.13 via Frontend Transport; Tue, 26 Aug 2025 21:09:08 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989EA.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9052.8 via Frontend Transport; Tue, 26 Aug 2025 21:09:07 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 26 Aug 2025 16:09:07 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1748.10; Tue, 26 Aug 2025 14:09:06 -0700 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 26 Aug 2025 16:09:06 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9e779fd-82c0-11f0-b898-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mtnb+36F+PKJCuv41WOE5CV/4oQCwPSayAGOZ8oI5Yh1OlQudsn0olfTU4QcjxXYS+cNlm58CUJ2b7HM1o9vCGceOb/AlDIQQKYHgerjfqA+dyEztwp56ood7wZq0qUaLvTa8VfuZ7yWWuMoPYp73Yi1Y6huZByLpCurvshBD0g4e8hzxEDXsym/67zoz5gJGHYiKsmhb3fSIPPpWZ0myPMDo0RtsCBEJ5oC1VEXFQX7U9Te+p1udnVmxn52dcdJ+j5vcvrczJgwkRYOfagvAizJeICStMwi1Wx4JDpC1keQqo1++6zRF+eG07ns6x4inO9gwfD5DWwAu+PJKicllQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kx6d34oYfnXViK0Sv04HljBO4lYFdDa8TSdzHSfLUho=; b=Cb/LMQ0jEpvfn86xykziFoXXjU2d1AL95lv/uzrgXYo8/cj04bwPAgaFzjK76LEuw8byc6lFYDVvqWwD81QezrVAc74USoc6WNg7Zp9KCSZjyKOo0GAkFIJKvnB3VMCIRCBTQyntvzmbL10sn7S6D/yFPui6nvSHXH4dx1sZgNPQTMKuACkg8lq/v+La5Z07HkIXP8hP6awHaMCGlQ9/5aHqhB2dmx8oXrX3wLmB3sXriqf5oit1JukF/Rzwvxw0NsGMCjsl8mNiAk/zeACjnt9yW3zvdXvy9m+S06LfPm/BlRRjezZuHWDUoGCFVCHaR5dANuxIvktujmzzqtFoPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kx6d34oYfnXViK0Sv04HljBO4lYFdDa8TSdzHSfLUho=; b=CnxE2YWXq/dvxv0uXd0wRjXzhElL2Olbh7mECBQtoEne2E/StuUwuopfUijWe9ebh24n3dKiieokfEcQUaHwCfbFQhq74chNLaocnLaKU9Xsd2Xhw7S/SmZ1QrhmgtYJ6k0hhl48FMSoZxiW4o8viBqfVjeYXLgQpZeHnK5cadM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD Subject: [PATCH v3 5/8] tools/init-dom0less: Use introduced to determine no-enhanced Date: Tue, 26 Aug 2025 17:08:44 -0400 Message-ID: <20250826210847.126015-6-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826210847.126015-1-jason.andryuk@amd.com> References: <20250826210847.126015-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EA:EE_|SA1PR12MB7272:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c153865-c21f-4867-01f1-08dde4e4cbea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DevOs+34sWBhz5ldjCTN7HZvZ+G1EeQE/xeAtdylv54kotTyIeNV1cOFAt8m?= =?us-ascii?Q?4lyTro8mkN1r4Df9v3v38gJuqlVeMkqjawUnlasE+AyiAk3aXpyGn8fEf4TL?= =?us-ascii?Q?AbkdB7XHOUDySWeR82ccmQ1AQGnmaQpNdbhlr9L3Y1rx2LzvT5UQj+Rj4bdP?= =?us-ascii?Q?VykLPM2359czOK1zz+ZaHJUMEA/tW1GnvTdpLdDEDbHcW3rC0ev1HoZGsCfp?= =?us-ascii?Q?Xk+XoEQs1zZNoOHlEYil/42CV1+0vIVln0DS7cw9JithWa8fwGwv9EhBo2qi?= =?us-ascii?Q?w+C0n2tmtbYQ+N4K2+oYN1HORfm/dfjj/X1fAmPDCsRTmz/TVhJb8hnsPzF3?= =?us-ascii?Q?RtlqvwDMtrA8MuJGTZ2lC3RNoAZyin2YAkjWtuBjmg7h5QzDJlFpCOvltE0v?= =?us-ascii?Q?FMNWHYWNQg3glhgVaksJH7nrKlpFlMc21p0arZ3iLMRfyZrHCiDiY/H6AcXX?= =?us-ascii?Q?4ub+KlX7iHWhfWTFlqwMq27pbmGW1R7/jnt8ihI23F01MwWOHoNOPAEgAv7y?= =?us-ascii?Q?wqPSMDHGuCpusP0migT3Wy2xBIlAAy+ZcZWPNWs0D0i3tUB26bsz1I/NsgMa?= =?us-ascii?Q?rqKJXtDqS33GtYowS7xOEw5xicbrBOPpp9lQY5HoHDYQw+ZbZIt90FJ5wkKW?= =?us-ascii?Q?d/nZqMZA71eq3riNUtl4p0C4lC0Oe8G5YyP3p4n1Pt7iRj/ifSS5tLXP457z?= =?us-ascii?Q?DfG/SECyL461ZwFn7GgCaT8Zq9XCMeXnrPU4agFyHQseY8vWPnL6sJqhedCe?= =?us-ascii?Q?I716Gx+st5rNBtKHMfQN6dUAUx+nUhR9ASlupzL4YCAJAHCG5Wkn6LNUCi+P?= =?us-ascii?Q?ma1DtQitI2SenY8499O3YNBSIrxlP8O8LQB5+h4HBsYZkQrXfefucSr+EOCQ?= =?us-ascii?Q?rz9bm9Kb7nKrarml6yuOw+yxIWNzWBBzHO15lDDyd5NTx5VtRLBYLMQGx88i?= =?us-ascii?Q?pZn53SGU0vkaXHRlx9NMQhdLY1wNkPQ7Y80MjgLKVZ+bLtrJ1hXYEyi+xt3k?= =?us-ascii?Q?ye/7PUgfAu/oAaUAbBhoTfxjB6g71Y6lrE2+Rg3T74lfCuCvd/9Am5N82c18?= =?us-ascii?Q?/4412iCYnhNkRQtQ7txcrtqLT/ed3t4yUHnp825KQ3qIHuTO0N8LjHITJ2R6?= =?us-ascii?Q?+kptYHq+zXV8hPY6UjpLswyCUBvsOvxfkagRGeeKFMqNS2D5+B0idwHRQsPu?= =?us-ascii?Q?FTKWMZrWWNw2KnRb0Xd9TQS8qOyqw1ILoiBrDy7dh+ddGomZlJNookkgQ12x?= =?us-ascii?Q?D8etVd5aV+qblQbtXBQaZZasJ7areUtR2+U5vFdDgOkKRCO0Ru83NXiBBw85?= =?us-ascii?Q?+lFLAoSDypOYFXI7BRp2KrPWLQS2xVbDRaPnjbbfUseCdL9Wq9DmZr4ad/ZU?= =?us-ascii?Q?+vSD5KqDoeCMdMCAW2meChkqiUsu6hTuB9uIn4D8tFYQtiJPZeg5ATtps7cY?= =?us-ascii?Q?aFDGTdBtoUUcsoirVcWmhGL9rKC3XVdynncznSjd9KKpRoKS7qdlvAR/0hs1?= =?us-ascii?Q?Qm9c7LeVey8ifLtMXwWpiDpxXogwtfLQZKzU?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 21:09:07.9925 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c153865-c21f-4867-01f1-08dde4e4cbea X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EA.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7272 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1756242582422124101 Content-Type: text/plain; charset="utf-8" A hardware+xenstore domain will not be able to read HVM params, and init-dom0less reads HVM_PARAM_STORE_EVTCHN to determine whether or not a domain has xenstore. xenstored had a similar issue, and it just tries to map a domain's reserved grant, GNTTAB_RESERVED_XENSTORE, to see if it is accessible. If successful, xenstored introduces the domain. Use the existing introduced state to determine if init-dom0less should try and read the param. If already introduced, initialization (and reading the HVM_PARAM) is skipped. This allows for running init-dom0less from a xenstored+hardware domain. It relies on the local socket xenstore connections being considered privileged. oxenstored has not been updated, so the exist code remains for backwards compatibility. Signed-off-by: Jason Andryuk --- v3: New --- tools/helpers/init-dom0less.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c index eb793c7aab..a4de40aeac 100644 --- a/tools/helpers/init-dom0less.c +++ b/tools/helpers/init-dom0less.c @@ -309,16 +309,20 @@ static int configure_xenstore(libxl_dominfo *info, =20 static int init_domain(libxl_dominfo *info) { - uint64_t xenstore_evtchn, xenstore_pfn =3D 0; + uint64_t xenstore_evtchn =3D 0, xenstore_pfn =3D 0; + bool introduced; libxl_uuid uuid; int rc; =20 - rc =3D configure_xenstore(info, &xenstore_evtchn, &xenstore_pfn); - if (rc) - return rc; + introduced =3D xs_is_domain_introduced(xsh, info->domid); + if (!introduced) { + rc =3D configure_xenstore(info, &xenstore_evtchn, &xenstore_pfn); + if (rc) + return rc; =20 - if (xenstore_evtchn =3D=3D 0) { - return 0; + if (xenstore_evtchn =3D=3D 0) { + return 0; + } } =20 libxl_uuid_generate(&uuid); @@ -332,7 +336,7 @@ static int init_domain(libxl_dominfo *info) if (rc) err(1, "writing to xenstore"); =20 - if (!xs_is_domain_introduced(xsh, info->domid)) { + if (!introduced) { rc =3D xs_introduce_domain(xsh, info->domid, xenstore_pfn, xenstore_evtchn); if (!rc) --=20 2.50.1 From nobody Fri Oct 31 03:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1756242700; cv=pass; d=zohomail.com; s=zohoarc; b=ipnC6CBOz5Jqh8HzI5841kUkJFmIzujEEUpkh3sR5bk7VzIcWNlbKz/7lXoeYxG2Z+ucYKsVrAjMCdjEdNIUXqPnmVyOuWhIl5o8gcYcOoFDzCXUqgmrN5G5HEcBA5wW/sWZlaRHYnIy4nArqhCz11nkNKJrNYwwnOcaW0aNDO8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756242700; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vmz6tXiI9igMexXwJMlZ7JfZtLtNIFmz/j0H60IpHMU=; b=Sszux0GAQX7LVHC6VRI4FXgjJZQXYAXOpBp0OGmA90ddXly+EGp2DLv8OPwC76HBhOVYYYjpMsnLn02t4Oiqj//KYlVKygvo2w6t7djel8re+NmuVWSWB7TlxWzYeacqZQcZE8Pk8lyBjOrX0acYLeC943ED74XdMQ5i5C8ibYc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756242700037693.6113123404475; Tue, 26 Aug 2025 14:11:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1095131.1450264 (Exim 4.92) (envelope-from ) id 1ur0uo-0006zG-MZ; Tue, 26 Aug 2025 21:09:14 +0000 Received: by outflank-mailman (output) from mailman id 1095131.1450264; Tue, 26 Aug 2025 21:09:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0uo-0006z9-Jf; Tue, 26 Aug 2025 21:09:14 +0000 Received: by outflank-mailman (input) for mailman id 1095131; Tue, 26 Aug 2025 21:09:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0um-0006HZ-R9 for xen-devel@lists.xenproject.org; Tue, 26 Aug 2025 21:09:12 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061a.outbound.protection.outlook.com [2a01:111:f403:2009::61a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9ac253b-82c0-11f0-a32c-13f23c93f187; Tue, 26 Aug 2025 23:09:12 +0200 (CEST) Received: from BY3PR05CA0010.namprd05.prod.outlook.com (2603:10b6:a03:254::15) by DM4PR12MB5817.namprd12.prod.outlook.com (2603:10b6:8:60::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.14; Tue, 26 Aug 2025 21:09:08 +0000 Received: from SJ1PEPF00001CE2.namprd05.prod.outlook.com (2603:10b6:a03:254:cafe::2d) by BY3PR05CA0010.outlook.office365.com (2603:10b6:a03:254::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.11 via Frontend Transport; Tue, 26 Aug 2025 21:09:08 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SJ1PEPF00001CE2.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9073.11 via Frontend Transport; Tue, 26 Aug 2025 21:09:08 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 26 Aug 2025 16:09:08 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 26 Aug 2025 16:09:07 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9ac253b-82c0-11f0-a32c-13f23c93f187 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TmXnxjrb5hHVt3v1GJGOt/pBc0m86jlBPRuqMoD3I7ePzwNTwj2rwGr0SZJy2bDM5PQhpwSF5ifmhiJ7niZhNfo8uVQd5ddNmD40ZsVU3p8lAysNJPoSATFZBaHwW9Z4Ag4S1RUOmK/FpYa0/POc2QxsHvkYdkuu4WqlSZlEEBBkTvr4hIJHvi22ahUMItau7MKP4UbDmA7xYljRpTvB7xyziesa6RLTzI4KJB4MmSMjcGsV9EQjQAwkPAEwXI7a9EofPWzl8g21jXXSt+Z50+rqDyz0OMDpNq9jdkMYffM1Kv6Xms0BEd13yNQCFuc+JnlUVBWTr6d5CZ/a9KGlkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vmz6tXiI9igMexXwJMlZ7JfZtLtNIFmz/j0H60IpHMU=; b=KXRR2LQM6N3otoCvC/1Imtn3oyq3tHsDLIO0XeU1if+9pq0X31n0QK8AVUgz7rDCcQldxXL9lhOJn+VL2bJpEFcsD6K+SOMr+SrO2broHlalls4prK624uh/SORIguv0yE9lBNjperbaUoqOg+DtLE2hDY/jGx93cSi4lqGtT6c6N359CLPfIr3N9+Pl+d09XWquS+NlU9J6+ikYXJkX297mY1I2nR9lr7wPjFOTkre1X2UIXcZXSn0TO2iw33CLYG1TBnhdWhwUrAJhLnNQV4/bzC4pjm/A4MvEliA/7K5o3cs76gOXU5Z7O/GlIwGFOELDzL0Zt2xuGjzTMVgyIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vmz6tXiI9igMexXwJMlZ7JfZtLtNIFmz/j0H60IpHMU=; b=Beba4b0C5Bi0C8s7eY8y6UWU5yPSkeXyWb7yF4brzab8JCL1dtE6E922am+yXFuxkV6eGWCqvle7zZQRgaarny3SbeSJJMe3kTkJzj4nYXfrkoLktGQ3StEsyjVsoMzKgQRyHUKxqGcu5mB40/Q5IN8TUA9Iv7Y11W+99COIpf0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD Subject: [PATCH v3 6/8] tools/init-dom0less: Remove use of err() Date: Tue, 26 Aug 2025 17:08:45 -0400 Message-ID: <20250826210847.126015-7-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826210847.126015-1-jason.andryuk@amd.com> References: <20250826210847.126015-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE2:EE_|DM4PR12MB5817:EE_ X-MS-Office365-Filtering-Correlation-Id: c6c03ee5-2f4a-42e7-9d0c-08dde4e4cc3e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ESVW05TuJxS+tLR1qKzNP1eMkfiPwld6YVqN067Sp9PnsgIug1qUU70FwVet?= =?us-ascii?Q?vF8Mg5iRbOTrNbB9YQRJf2mlo+c/9leg7SZb0/6rkYsm5gmD8rI1AZ6vHXhc?= =?us-ascii?Q?6/TP0na7HwtuC0sbuCVu6dQCbl6xrVGTj9BnvIAzakcJFr3PWvlh3G8vzsmi?= =?us-ascii?Q?BR9wZXbf8pWbNmGfhB8w4mTVOn9T2COWCjYs2soVLFDz03qX5RbP/7wvvyHB?= =?us-ascii?Q?x4TEPNV/LztFCdgE0piLaHpCf54xJL7mMHAkK3mH1ucPEkxRC//84YM2cmHp?= =?us-ascii?Q?hnq0FzVkU68IZzpPRPVzLZhM8Xc5q1Mz+jzHimfRoVEhpvxrzfsTHkkC/H28?= =?us-ascii?Q?XycbUJCo519IylNdjo0cxtwzcZz9uK0LRxQwOz4GNDCj/urEabIyLm5RhJTo?= =?us-ascii?Q?kIysxuzbWG5nD0U6mwkTIhEm5pzwPMsKwCbY3POXlKkphOR5ZH7xYMPNA9sx?= =?us-ascii?Q?ktYbF3HcwTfL0xa58G7t8nkQepNEde64rcEprpbn6DSullDOTtnRfQKJKb36?= =?us-ascii?Q?yRS+9LXy6GFD0z4E3n/+bYTOTBh77gJZ7Df0ALdrw0u/JoVa467zQJco5eXP?= =?us-ascii?Q?ShGHKPz39M0rodawwzwDPBTBEtlmf+aqgm9mYCvqi2Rw0Cr+QrgUeiFhUtaa?= =?us-ascii?Q?hpw7V4PzcjiG/E0ZFvYt6kaeI0Vvf0faOr3oOWJjCtZRzRU1EU4/JN/STAmi?= =?us-ascii?Q?f0kZuzC/EhELKceX3FgO/Dq/iWJCoLFvra/yGGtYJwztRkAC6G8IXh/6vshh?= =?us-ascii?Q?Axl1sU1o8gQb4R43goUGGW0PNzItJ8xxhRXAVvpclyKPHEuIXHnrVvoMvdNq?= =?us-ascii?Q?snQKOl5nf9zVPdWzwnLnmotmyoYmLntsmRcHpTxKSH/49m5oSjkwstjvNVfq?= =?us-ascii?Q?075pXfK+9x7Fb7uMuOw4P+85AEWdmpmC/jkicjWJKO/PBMGNEihELqz/eyz3?= =?us-ascii?Q?LRd6r0McyJ5NbDclhA8zfojJDFVZLdH6ODxjkC9mH6IvhO/qSvqogQccIj16?= =?us-ascii?Q?1rYf1c2LH9WcDoCRycMBNmSS3VBX4qC9ewpx7wArfqvzu6Vhb3BaUF9I5sQi?= =?us-ascii?Q?hSZXLf2SMsQuHQIygr0z02QuAv6FVBvYtSpP5ZuHYm6q0R/bH3SgkXFxCEIr?= =?us-ascii?Q?FwV71feUiJR9V+OD87H2OlnG4jJRqUdR4RhWFOr3oJwQv/7sMqbFZ8Fuy9OQ?= =?us-ascii?Q?zMTEQewQaqrY61lSvWG851yq8JY/fOFE5yXboTI8jHcWEtULmOWsFYDP57+j?= =?us-ascii?Q?LgaJvauYYffHbqy6uUH5ZIs46pTogoqD+uTxSWlu+zsVanZY1j0sMZwJmzjD?= =?us-ascii?Q?Stht/8U80NtEuSRfQYUpOn4cwrvAtjHwcctJ9ixEyEi84ua4UY+7rHz0IytD?= =?us-ascii?Q?X367j/HtPg1bJkFteQdj19Bo4HVRrIIvxRdGUZauCy0CC/31/nRxMzrmFO/K?= =?us-ascii?Q?OZFqYc7RRnsfLj4Yy4iAxv9u1bhZ9ecXns6pJWYzvTBJouecZLOpUq6QcNX9?= =?us-ascii?Q?3ywwgnWGtLBEBMHakeIgmwVkMisTD42aLeHh?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 21:09:08.5455 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6c03ee5-2f4a-42e7-9d0c-08dde4e4cc3e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5817 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1756242701854124100 Content-Type: text/plain; charset="utf-8" err() is fatal - print a message and exit. We want init-dom0less to continue on as much as possible, so replace with returning an error. Signed-off-by: Jason Andryuk --- v3: New --- tools/helpers/init-dom0less.c | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c index a4de40aeac..d08b0b1362 100644 --- a/tools/helpers/init-dom0less.c +++ b/tools/helpers/init-dom0less.c @@ -300,8 +300,10 @@ static int configure_xenstore(libxl_dominfo *info, =20 rc =3D xc_dom_gnttab_seed(xch, info->domid, true, (xen_pfn_t)-1, *xenstore_pfn, 0, 0); - if (rc) - err(1, "xc_dom_gnttab_seed"); + if (rc) { + printf("xc_dom_gnttab_seed"); + return 1; + } } =20 return 0; @@ -329,18 +331,24 @@ static int init_domain(libxl_dominfo *info) xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid)); =20 rc =3D gen_stub_json_config(info->domid, &uuid); - if (rc) - err(1, "gen_stub_json_config"); + if (rc) { + printf("gen_stub_json_config"); + return 1; + } =20 rc =3D create_xenstore(info, uuid, xenstore_pfn, xenstore_evtchn); - if (rc) - err(1, "writing to xenstore"); + if (rc) { + printf("writing to xenstore"); + return 1; + } =20 if (!introduced) { rc =3D xs_introduce_domain(xsh, info->domid, xenstore_pfn, xenstore_evtchn); - if (!rc) - err(1, "xs_introduce_domain"); + if (!rc) { + printf("xs_introduce_domain"); + return 1; + } } =20 return 0; --=20 2.50.1 From nobody Fri Oct 31 03:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1756242571; cv=pass; d=zohomail.com; s=zohoarc; b=ZIwffCXlQfJV3fiDBJvID/qU1VS1eNy2KJc6RetpY6Ih0KzGmzjisZ+s19j+K77o/bf7t+IwSzQknuUuoPq1nmP3kG5Tbysjr7/ELS59l6iC02cqpCedldfFr1EuPRM1I5xYlbnbKwGFSY2VJ+OwucZ5zIAHfs1f+4YKnWqAZeA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756242571; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IZbY69DMqrM0tK6H3yhGR3gho187BPnTnu5vuJ1naLY=; b=eG4B7z5t5xjryYrsMZsAsJk3GmWosobXldlDUeYbhW8xQzJUoYlm4yLHw0lTw8+Wh+/cCnwe5ngewKLhAADn79rQ4rcog6KITKXogQns80OE+xy7JoB9m+cYWlYrIedxmdsb1cM+PETOJHZVaD5sNHMljR6Lj51SIpMildljTGY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756242571168298.4498812926946; Tue, 26 Aug 2025 14:09:31 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1095136.1450299 (Exim 4.92) (envelope-from ) id 1ur0ut-0007qh-79; Tue, 26 Aug 2025 21:09:19 +0000 Received: by outflank-mailman (output) from mailman id 1095136.1450299; Tue, 26 Aug 2025 21:09:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0ut-0007pf-1y; Tue, 26 Aug 2025 21:09:19 +0000 Received: by outflank-mailman (input) for mailman id 1095136; Tue, 26 Aug 2025 21:09:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0us-0006z4-Jo for xen-devel@lists.xenproject.org; Tue, 26 Aug 2025 21:09:18 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20631.outbound.protection.outlook.com [2a01:111:f403:2414::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec62b11a-82c0-11f0-b898-0df219b8e170; Tue, 26 Aug 2025 23:09:17 +0200 (CEST) Received: from BY3PR05CA0009.namprd05.prod.outlook.com (2603:10b6:a03:254::14) by CY1PR12MB9602.namprd12.prod.outlook.com (2603:10b6:930:107::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.20; Tue, 26 Aug 2025 21:09:13 +0000 Received: from SJ1PEPF00001CE2.namprd05.prod.outlook.com (2603:10b6:a03:254:cafe::dd) by BY3PR05CA0009.outlook.office365.com (2603:10b6:a03:254::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.12 via Frontend Transport; Tue, 26 Aug 2025 21:09:13 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SJ1PEPF00001CE2.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9073.11 via Frontend Transport; Tue, 26 Aug 2025 21:09:13 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 26 Aug 2025 16:09:09 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1748.10; Tue, 26 Aug 2025 14:09:09 -0700 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 26 Aug 2025 16:09:09 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec62b11a-82c0-11f0-b898-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oHySlXxqNmM1s62brizEOcGayhRh+wwqZxdVUg6xXO5PNVjHuSNbzlvkbiWbWZq6BBZexDMHBIyOSmJFS9UF95t5lPFJGWxcw+SEz8/Ly86UaevhMYzN8Ver9M21doiozPOjX2qRy8tZbR8War1UTDykPiJ70Of3/bGLao/kBPGZYtoI7OFKJJQeCNs0U7vrz0kkriEoVb4jsFQCZ5pX3jLUljny5LKGByyBXS+cQc756bQhfyhT3PFa0DRQQ6Ld8Rb+W8quaKVlS9qvLRab4YdO0TVWrtE23VrFUyFAZQFqlset3FLQmsp6WKwdCf1s5C79NDONddxwAuRa/j1kFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZbY69DMqrM0tK6H3yhGR3gho187BPnTnu5vuJ1naLY=; b=BlrLlnDuiqg7k/MwdvhIacp2x8vHbS87Juw43zvKjj3FPAShoMEeVeFQgVbwdSk00JvEODK0UmG2nAU9m1tbeWN0DlTg6aVBDZqu611hYHrwMYteVkSUc1jVNoaqY6/7mOC6rF95rkODPACxXJLin/H0XqYEqn1VCt/IWZ7QYvDqfl9VNT9Uwx7gBTV7G9+NuRcJFf3joEWaZyStFBMdsHrL8lTPVd15hcXrzt6dBz1QWNc0PnPSUT2ECAL7e/2jr60F6r7ErPJmcqNc1YK/X82UHXGvMJG88uhB90RRoBvvLAYolD6pVQkpY+sBAjU4wUc3SY4sMiayXjtGFpvcBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZbY69DMqrM0tK6H3yhGR3gho187BPnTnu5vuJ1naLY=; b=lJobdyhDvWrckjr+PUtncrKlU+tnfMSGXLO90qCcRKw8n2NBsrX9LUYznIHkw36AGImku++IZcZCe5Yf88sUrxZBkIaMtZa0IvB0PkdCFVpy8BxO0Mzwd+xknjdpTRQ/1ICFNgJcwQ+Oi8kZhBIxaiA7hiErul5qqc2g3NBIPy8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD Subject: [PATCH v3 7/8] tools/init-dom0less: Continue on error Date: Tue, 26 Aug 2025 17:08:46 -0400 Message-ID: <20250826210847.126015-8-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826210847.126015-1-jason.andryuk@amd.com> References: <20250826210847.126015-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE2:EE_|CY1PR12MB9602:EE_ X-MS-Office365-Filtering-Correlation-Id: 77675c30-0ab5-4da9-e533-08dde4e4ceed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4QOwJ9WhhVgdkKYI0cf8yXqP8eLmYiVXMKKDQwfoURXtP0fcM3ociF6SU5H9?= =?us-ascii?Q?7qHjIYxR6jrLFLuXyZbZZ7S0j9geXVSADO6QRAEnTn79GQUayxkW4Wz4Bs1g?= =?us-ascii?Q?MDqgUuR6VB/ScGGrxc7l8x5xI4Ietz3NH/6H6mObe4iZbJgrPwzdtbJJVdQS?= =?us-ascii?Q?WvoLZt+SnPOv9Bu4WZZC2e+6JdFtxGf6Uh0DOPLp/2AtXY/7TROJVMvT2zi2?= =?us-ascii?Q?4no1sd+LEtM80jNBndUBSXo4PbeRvd0fsBnXChwFKtlF2XMn3BUnckVx1jYC?= =?us-ascii?Q?1JezpnxJI8qVJgfMNWtCH3U3ddX5Om4M6W1fjrC2Bi7YeQ6klrOA9vLWuuzc?= =?us-ascii?Q?sILTcF9IsVKpkVaJE8vHCHDnBGMSHfXVUgZs4XQc/tgeQTg/r68vJjPj2wPA?= =?us-ascii?Q?GTTkjkNY9o84Tc3sJvgs5XdVkmNfA48pxeDhQU26Y3PxDDL9dNaMVJu3i1UL?= =?us-ascii?Q?pX/47fFrH+bTzUP/xTqIjT2vdU64DDtDywuwGy45mh6JUKcpy+gmQicta/P7?= =?us-ascii?Q?RRbCtLv8SwDXDlTUrlltQVSb2NN4m9qNz9Bb/Qwmeum3ISAzMxGr1fJecSmF?= =?us-ascii?Q?4uxV5TBdwUJPpwhbTFXYwOU8dINWqwqCh/JS/RzneYset38N4fJQGKRleOLH?= =?us-ascii?Q?ODyeZ0zx48IbyA7ENO429p+I0vSooFLPnJs2hHnFY3055ZKQPU9t/EklaEtL?= =?us-ascii?Q?KjxuJc/QZ+URPkrtS6pczAaK3l8WTcnUtniOOvSSjV2+4DU81/Ont6g3T5k/?= =?us-ascii?Q?1T9urIk+JEHx4VcAfXCl9p8rV8qGcpCtT01mF83FV9Qj3ueSAGJgjEStny4i?= =?us-ascii?Q?2PGWf1Cs8VvTIOAuiY6vyQk79JsQwo/f6vdGKUP5ZhCKxdRUCSd6WiclIM4J?= =?us-ascii?Q?gcidD2ha5w3TFxMK+AX1vbVxyoA9pG/SptVEZi5mobQ1HkC3fqZIJ44fGBqD?= =?us-ascii?Q?Eztl/J97eONJruXQ/0/YLcoOa5MYh2vkFhhC6TgpEIS/qQ5YUjBERhD+fabE?= =?us-ascii?Q?PzV84YQkNk54p/1hZ3BYu8PFu09kQhViioyNyXYucDrk3njYOHtW5b8SUOVe?= =?us-ascii?Q?kJy2KNGEsWxra+/ZP6VnmLH9q5ZzqwZrM6KP7cagUEuH5CgnrFfi+TThBYxI?= =?us-ascii?Q?X9pNKC46hIwV3eQUGHGh0VQo49IG7HqWm4Fse1wM9MQ2MPTWJi2Ueuh3OAYk?= =?us-ascii?Q?sFhe6JCgtMSxrsEDy5m7IQkVzpkphvvPkASMzu5iL2Xw9c2o0vn0gQB2/L8i?= =?us-ascii?Q?wUi8bY1PmDBDFi7avFCl/S8i3oeKUEI7+QEDo9Lf3IH7HT4y+O5HoYSRz3Re?= =?us-ascii?Q?AUQYybIfxZ7PWdnGNWPK7JtAgAbY1EP7uZPLfUXgQCu359eVnX4X1MCXzLWa?= =?us-ascii?Q?Ie/vRIfFN9wkFkFXiYX3IJVJE/11hboIoIDujC5D2rhaLO6Nj4mpU7/+XU2t?= =?us-ascii?Q?RV08jMHlO9ZLrPUhD8uwrHkgj+SxuhQ5okNgC/QvWQBsGKQZ8n/I5bKXTxNT?= =?us-ascii?Q?WHD1Zqvf+tMpgtYzn4wePsVGMqyX4kfN8ELM?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 21:09:13.0501 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77675c30-0ab5-4da9-e533-08dde4e4ceed X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB9602 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1756242572160116600 Content-Type: text/plain; charset="utf-8" An error on one domain doesn't apply to others. Continue the loop over all domains if init_domain() fails. There is a mix of positive and negative errors. 0 is success, so just check for that. The last rc value is used as the exit value, so clear it before the end. This avoids a stale rc value indicating failure. Signed-off-by: Jason Andryuk --- v3: Use !=3D 0 since there are both positive and negative errors --- tools/helpers/init-dom0less.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c index d08b0b1362..ce70ddee29 100644 --- a/tools/helpers/init-dom0less.c +++ b/tools/helpers/init-dom0less.c @@ -406,12 +406,14 @@ int main(int argc, char **argv) rc =3D init_domain(&info[i]); if (rc) { fprintf(stderr, "init_domain failed.\n"); - goto out; } } else { printf("Domain %u has already been initialized\n", domid); } } + + rc =3D 0; + out: libxl_dominfo_list_free(info, nb_vm); return rc; --=20 2.50.1 From nobody Fri Oct 31 03:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1756242580; cv=pass; d=zohomail.com; s=zohoarc; b=Nf6fKaZFAwuPDaRMgClQ4qDvpv5Yq++9iTMJ6iZ448YWh/l5zdipGGVU5f4zTY1svSIiDEU9HAUJaHyS7Q6AsKSbLQe1OuEflILzHWWX1+eudmOhXCqar6MDRsudb4ZAboSjoU3Op5ICel//pBT67yGjjN6PhN8wD5sZ9wG/Jww= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756242580; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9F+/mzfDnNswEGDX88fLVWONwAPU8XRv8UZTYl3/UxQ=; b=B4qo9H0kcwt55yKANsD9QvafVwNed4rAWFULHmnBpp0Ex9u3LqaOPSRsWaGx6A2Xq6rYEA7IKTHfsZdeLTAGcVsciUHdYize8cIRr9vZjXAWWauf/59mvacHYUiY5RTh7Dmg/11cnIpQn7rk7+NUWm0zEQTWFNsw+kGlcXdRpDc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1756242580150227.87193375556944; Tue, 26 Aug 2025 14:09:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1095138.1450314 (Exim 4.92) (envelope-from ) id 1ur0uv-0008N1-L5; Tue, 26 Aug 2025 21:09:21 +0000 Received: by outflank-mailman (output) from mailman id 1095138.1450314; Tue, 26 Aug 2025 21:09:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0uv-0008Mq-FE; Tue, 26 Aug 2025 21:09:21 +0000 Received: by outflank-mailman (input) for mailman id 1095138; Tue, 26 Aug 2025 21:09:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ur0uu-0006z4-5M for xen-devel@lists.xenproject.org; Tue, 26 Aug 2025 21:09:20 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20617.outbound.protection.outlook.com [2a01:111:f403:2409::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed42067b-82c0-11f0-b898-0df219b8e170; Tue, 26 Aug 2025 23:09:18 +0200 (CEST) Received: from MW4PR03CA0255.namprd03.prod.outlook.com (2603:10b6:303:b4::20) by CH3PR12MB9315.namprd12.prod.outlook.com (2603:10b6:610:1cf::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.14; Tue, 26 Aug 2025 21:09:12 +0000 Received: from MWH0EPF000989EA.namprd02.prod.outlook.com (2603:10b6:303:b4:cafe::e) by MW4PR03CA0255.outlook.office365.com (2603:10b6:303:b4::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.20 via Frontend Transport; Tue, 26 Aug 2025 21:09:11 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989EA.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9052.8 via Frontend Transport; Tue, 26 Aug 2025 21:09:11 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 26 Aug 2025 16:09:11 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 26 Aug 2025 16:09:10 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 26 Aug 2025 16:09:10 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed42067b-82c0-11f0-b898-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iVhBjMxN8i8evB/4Nb9TiqtUcWwOAB+5AM9lk0MkC0iJhI2NwPvIaKvXYH/tSrRMy8ubdZNNbKU2GvT11M/F6K8T62Ykon04rLiOoZbDnTQieFY9HqvAhpGOa2Wz31XxdkU35CowP92gFyZn2jpM2zm0qUq2yT2211r5nSqx+6QTQgvW1YolTb2E/0cB/kZQs0oAO8cVvMttxqXa+zQAJRO+3lSuwe3LP6mKzrGJMELji/D7ZrJKQ3q8gANiuABX671562Bt2Cz5bfrdUaunEB5Yna47oHOkRcBS5f8+C3ehClk2ISC3ozO/eEqb3wtqUQVyKGJvvMHuGPc+Qm44Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9F+/mzfDnNswEGDX88fLVWONwAPU8XRv8UZTYl3/UxQ=; b=gmOk9YNNE4SNi4RCszvsIP18gXxIKEHIocbibauifWIqJcoBJYrJ7Is8P9oycsTwSPF/bC+a5w2Mcs0OcqfqQrL2kG3F1LdxP4TfzdY2wiMJBHlT92RavwALGokW8LCQ9+FCN6ogA3X3erHRGcp+UY1KqigA1n4rF9WM4orPVk5n+tcxrvZlx28YYF4QVhMcHP0njjxoaUgq1AouHhB9qTQSzrIIRPSpJQtnu/FWk5tavJI6usRUdLispUG69E9y2kdCxQNV2SM7FvOR05is5JBXFG3TCBLu5drbgB1WWr71qKaDFYXoxA86kZa4CaBlH7xfLxzZmHfa8zTs0RVpeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9F+/mzfDnNswEGDX88fLVWONwAPU8XRv8UZTYl3/UxQ=; b=VQTp6Gl6HQ1kon5cyKofYDwAR4a+yytFSOBoc6aL40QMENERaPh4PftXkXjfQcUp8ZqonGrnl2mEQ9duzVbns1nju9CnZIX1+cq01CwH1gBXkZdKSup11iA92qhjBXydejOfUsHrSpOMvCYOblx1zjBi6xlqH32Vod1F7DI8SDw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel Subject: [PATCH v3 8/8] xen/dom0less: store xenstore event channel in page Date: Tue, 26 Aug 2025 17:08:47 -0400 Message-ID: <20250826210847.126015-9-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826210847.126015-1-jason.andryuk@amd.com> References: <20250826210847.126015-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EA:EE_|CH3PR12MB9315:EE_ X-MS-Office365-Filtering-Correlation-Id: 1493181f-1f82-43a2-ab12-08dde4e4ce0d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/MYVNB9SKxzBOsMnX0reLumPgpDkNbd57aiDW9BQHwSvg6rc2Z00K1VkIPFH?= =?us-ascii?Q?nhfO7HYiQ/B7lUKy8OwrX1vheYvypd8WzBErY1qTsXxbJ8ttTCPDC7kbEkcD?= =?us-ascii?Q?psyGLlz11J1h8zh2onmEXmGdxJcpL7nkmHBvPNCXOztV1IqLkwtSElurQWgN?= =?us-ascii?Q?CNd40/7p8C0MOUh3qDr1UCEts52aUMJXN1B4dLQbl+g4feWM1iSpDMAE4QGX?= =?us-ascii?Q?NVCGpx1kPbkG69l7nWXfBsMXX5GfvBazhLXdbvfV/PTe5tDIZEWdLQaxwjGs?= =?us-ascii?Q?PaL0H8VsxyfWBILmyhW3OX3WOc9agFk0Wh15qZilBPX3n+1c2J7jzvaX/o/B?= =?us-ascii?Q?kgAeehkQwQnbv1UHGfupLnsqw88tTThPTn7nfDiKmcy/Kyk2mjbDJkms27/u?= =?us-ascii?Q?66qD6xrsZQSwZpwJxgFy8oS8GCcEkDkZGupN2EAtfaaDmESK4roAIDF81C0G?= =?us-ascii?Q?bkTU42jpPbCjU7qVm+eCsuPfaDYQeo0I8+7Vp4ISs10faO/PcK05H7tF91gF?= =?us-ascii?Q?GKVw1E291Bd9se7Sdvj/9oEjYX+iHf07qjBr7L1o9W6ASwJaHGMIGLwei2Jl?= =?us-ascii?Q?TFlo/78YMqmLc60rZcDMsc0wR58eJizC82qv5/G5ftAIqer5QuO7iPlPWjdw?= =?us-ascii?Q?sXtubfUALqLar99xb1PhpepohtSeNaHj0H8VMYkTOL57HTTQGRcbYCDGRclD?= =?us-ascii?Q?Si3qpzoLhSJ+CK4wX+YmxIgNcB/mIPTBWOtbWU6QGsG+gR2qJjYDRCtVkJ6M?= =?us-ascii?Q?MLsejvyzwXSHNMaNxN7lNInsVI7M9J4BuA3xGpraRs5gAxWN57vnqrTJlt5m?= =?us-ascii?Q?gPMHn4ajocx1Cqp+Y1Q28SfCu5QzC1mDkhc2J13Ckw5CNdFMWBJOFdBqLdqN?= =?us-ascii?Q?7rpGy9+MPHU+DMK8j2MnUvirN1vFtko1JkGQrPl7Q5jht1Yu6RKojlmoYeBu?= =?us-ascii?Q?I09Uhi/MxT1VfpZWPFh2ahFQjTp2TOtUZG2bg4mXgLGT+BCZT68KHW1qwp0p?= =?us-ascii?Q?1CnLp4F/RlF82rDANaqnNDnvukTxqsgabSvITuWftQySWwhKWmhT1VqGJ/YI?= =?us-ascii?Q?o0+Z2ITYWJlINVla0eK1xwbvt53mXZ5FKK2a5D5MlXuYdYcp+ayH/9DL3jc+?= =?us-ascii?Q?1WZ9VKqqjxWAUYdwycLutqu9Y+dMIJkgith75osV1d+72LsP6NhTd//BU0uj?= =?us-ascii?Q?fjZ3ajyWQ4ddTMs7sNCgkZCpfEmoPyN2x1vYe8U9UVxVVscspMietd6xVJM4?= =?us-ascii?Q?jLLOFtL9r2SBqNPo6SuqyoT+OYCT8ltHyNhfIkhPEcV3R4hDyCqXUw1yuels?= =?us-ascii?Q?tah3j5My4UBfX817sfuJWYaFmWanRNuNUGvAQ30nQh98QMvbhZOQM6z9p3td?= =?us-ascii?Q?DSnLatI+cE4UTQmF4nFMe2fVvuIa4oCPU39CfCOQgzFzwRk2Jpvuy71e4/oQ?= =?us-ascii?Q?NW/Qit2Ej4iQVsxBFBxmEme+3ZIBXiOV3AlHsCX3dP55pwhs4TfiSjn8Fopb?= =?us-ascii?Q?s5aZwh5DCrmzRsy+qWVI6qQ8XSzPb3wUadci?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 21:09:11.5818 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1493181f-1f82-43a2-ab12-08dde4e4ce0d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EA.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9315 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1756242582257116600 Content-Type: text/plain; charset="utf-8" Write the associated event channel into the xenstore page so xenstored can read it. xenstored can map the grant by the reserved grant table entry, and then read out the event channel and bind it. This eliminates the need for an additional mechanism to discover the event channel. Signed-off-by: Jason Andryuk --- v2: No change This should go in after the init-dom0less changes so init-dom0less is ready for xenstored automatically introducing domains. I'm looking for feedback. This is ARM-only for the time being, but that is the only in-tree user of this code. From the perspective, it is okay to go in. If we want a cross-arch approach, a common function to write to guest physical addresses would be needed for additional arches, but they aren't available yet. Oleksii added a function pointer to dtb_load() and initrd_load() when moving dom0less to common, but I think that isn't necessary. Just having a common helper would be sufficient. copy_to_guest_phys() or something_copy_to_guest_phys() could be defined or a wrapper for ARM's copy_to_guest_phys_flush_dcache(). Other arches could need to implement it when using dom0less. I'm not an ARM expert, but Stefano said copy_to_guest_phys_flush_dcache() is not necessary since this xenstore page isn't expected to be accessed without caches enabled. --- xen/common/device-tree/dom0less-build.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/common/device-tree/dom0less-build.c b/xen/common/device-tr= ee/dom0less-build.c index badc227031..1a40f68837 100644 --- a/xen/common/device-tree/dom0less-build.c +++ b/xen/common/device-tree/dom0less-build.c @@ -26,6 +26,7 @@ #include #include =20 +#include #include =20 #include @@ -120,8 +121,14 @@ static void __init initialize_domU_xenstore(void) =20 if ( gfn !=3D XENSTORE_PFN_LATE_ALLOC && IS_ENABLED(CONFIG_GRANT_T= ABLE) ) { + evtchn_port_t port =3D d->arch.hvm.params[HVM_PARAM_STORE_EVTC= HN]; + paddr_t evtchn_gaddr =3D gfn_to_gaddr(_gfn(gfn)) + + offsetof(struct xenstore_domain_interface, evtchn_port); + ASSERT(gfn < UINT32_MAX); gnttab_seed_entry(d, GNTTAB_RESERVED_XENSTORE, xs_domid, gfn); + access_guest_memory_by_gpa(d, evtchn_gaddr, &port, sizeof(port= ), + true /* is_write */); } } } --=20 2.50.1