From nobody Fri Oct 31 11:35:16 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1755764569; cv=none; d=zohomail.com; s=zohoarc; b=TWlexqAsmbXrEszFly3gUE84K/Bh/Nxz0anA61Sl0nQo+PUf9t68tvNpPtaXCOEcPzyjc0v2FpUZ56qZKYgWMe4fXgRTW1Wj9snKTIT8l0qLmGcwiNTkUmni97cRvqR0sOI5cR+iy+aG3R0EiEu7x1TsycX94J+HtMgXCDiNovw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755764569; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WyvgiHGFdcanw0/STMlXUJNb0LhNUwAiWqxt0oleFks=; b=Y/y+EEvlzfHDCGLEhJtLfkYcNAQZ13havnPU+6BRDZcG5/npMY7PDBodfK5W94968bv3BWvrfgUCte38Y5CP801YR8q014xS/W2OdDzdowhr5yN6DNMAsYY8qBWU54yvMbnJveppiJ8Wlg82ECFRLspOAlM4FI5exMGfmc9vjWU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1755764569581122.74609767812956; Thu, 21 Aug 2025 01:22:49 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1087922.1445751 (Exim 4.92) (envelope-from ) id 1up0Yx-0002WM-AD; Thu, 21 Aug 2025 08:22:23 +0000 Received: by outflank-mailman (output) from mailman id 1087922.1445751; Thu, 21 Aug 2025 08:22:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1up0Yx-0002WF-6x; Thu, 21 Aug 2025 08:22:23 +0000 Received: by outflank-mailman (input) for mailman id 1087922; Thu, 21 Aug 2025 08:22:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1up0Yv-0001aA-St for xen-devel@lists.xenproject.org; Thu, 21 Aug 2025 08:22:21 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f5568de8-7e67-11f0-a32b-13f23c93f187; Thu, 21 Aug 2025 10:22:21 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4D4611F7FB; Thu, 21 Aug 2025 08:22:14 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C35AD13867; Thu, 21 Aug 2025 08:22:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GCSGLjXXpmhzEwAAD6G6ig (envelope-from ); Thu, 21 Aug 2025 08:22:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5568de8-7e67-11f0-a32b-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755764534; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WyvgiHGFdcanw0/STMlXUJNb0LhNUwAiWqxt0oleFks=; b=WmaiKfCQLW3guThatF6dgda2Za5HiKKUN05xkDa9YXeEbh3ayHPQOb5c9On+vEuNYZs2Oo 16wMW6cx8wtZk1Hv40CDEs3bz8HyW2ay6Vui5qp5GRORU/yzniTKgHNveshlx21agLTsIM VzNsMdaPbPidMlpeFxFxpX4IU+Tz2G0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755764534; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WyvgiHGFdcanw0/STMlXUJNb0LhNUwAiWqxt0oleFks=; b=kJUj0aJ4gbbRW81Ud2K0bz5BIKn3jfRNS2B+WeR3HzjDHj/68JjaUbs+w0mQ87nwM+YQL+ oIAAxplVxebCmwBQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755764534; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WyvgiHGFdcanw0/STMlXUJNb0LhNUwAiWqxt0oleFks=; b=WmaiKfCQLW3guThatF6dgda2Za5HiKKUN05xkDa9YXeEbh3ayHPQOb5c9On+vEuNYZs2Oo 16wMW6cx8wtZk1Hv40CDEs3bz8HyW2ay6Vui5qp5GRORU/yzniTKgHNveshlx21agLTsIM VzNsMdaPbPidMlpeFxFxpX4IU+Tz2G0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755764534; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WyvgiHGFdcanw0/STMlXUJNb0LhNUwAiWqxt0oleFks=; b=kJUj0aJ4gbbRW81Ud2K0bz5BIKn3jfRNS2B+WeR3HzjDHj/68JjaUbs+w0mQ87nwM+YQL+ oIAAxplVxebCmwBQ== From: Thomas Zimmermann To: simona@ffwll.ch, airlied@gmail.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com, geert@linux-m68k.org, tomi.valkeinen@ideasonboard.com Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, Thomas Zimmermann Subject: [PATCH v6 04/25] drm/gem-shmem: Compute dumb-buffer sizes with drm_mode_size_dumb() Date: Thu, 21 Aug 2025 10:17:11 +0200 Message-ID: <20250821081918.79786-5-tzimmermann@suse.de> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821081918.79786-1-tzimmermann@suse.de> References: <20250821081918.79786-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Level: X-Spamd-Result: default: False [-1.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid]; RCPT_COUNT_TWELVE(0.00)[21]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; FREEMAIL_TO(0.00)[ffwll.ch,gmail.com,kernel.org,linux.intel.com,linux-m68k.org,ideasonboard.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLqirfcw6gnbcr9a9yhi49fhi6)]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-Spam-Flag: NO X-Spam-Score: -1.30 X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1755764570926124100 Content-Type: text/plain; charset="utf-8" Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/drm_gem_shmem_helper.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_g= em_shmem_helper.c index 5d1349c34afd..b90096ad82d8 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -518,18 +519,11 @@ EXPORT_SYMBOL_GPL(drm_gem_shmem_purge_locked); int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *de= v, struct drm_mode_create_dumb *args) { - u32 min_pitch =3D DIV_ROUND_UP(args->width * args->bpp, 8); + int ret; =20 - if (!args->pitch || !args->size) { - args->pitch =3D min_pitch; - args->size =3D PAGE_ALIGN(args->pitch * args->height); - } else { - /* ensure sane minimum values */ - if (args->pitch < min_pitch) - args->pitch =3D min_pitch; - if (args->size < args->pitch * args->height) - args->size =3D PAGE_ALIGN(args->pitch * args->height); - } + ret =3D drm_mode_size_dumb(dev, args, SZ_8, 0); + if (ret) + return ret; =20 return drm_gem_shmem_create_with_handle(file, dev, args->size, &args->han= dle); } --=20 2.50.1