From nobody Thu Oct 30 22:42:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1755686817; cv=none; d=zohomail.com; s=zohoarc; b=Io4xGyzBrC34JVkTOJ6Kmo4TEdlAJjBWN8QmIyWJAA73G5oYc1DAHTznTZJN9Z44pxwBvbIZ/7MqUIquMT5ejIqSYfxa3Ehxn/l/oWCiaN2gpQ9itnFFlcp3ZbXSv/CoT6dOHN866WXX2+5gTjCZfqT7FUQWz4ox/8/K4EedXiY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755686817; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S+9WzjEJVK6MpKC6Xk2m9qDPN9nowHIKblDbMTPY+l4=; b=kr2P1vCi8Ekho01kwtmrpdDCoUf9M7NjuZ72k6YtJlmcnoN9ElJW5FsVeHiyMEs9kXlKsdoSfq6Z629l1FiVUHqC4XG+7VJrAUgWOG1bxORX6AJz4jw47PuNeFE2BGX3LjFyNlb2N1hqFP6Oaj2hXLODYdGHfD3xPg/MV9Ls4Lk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1755686817893567.0206890934179; Wed, 20 Aug 2025 03:46:57 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1087296.1445375 (Exim 4.92) (envelope-from ) id 1uogKo-0004hH-3K; Wed, 20 Aug 2025 10:46:26 +0000 Received: by outflank-mailman (output) from mailman id 1087296.1445375; Wed, 20 Aug 2025 10:46:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uogKo-0004hA-0R; Wed, 20 Aug 2025 10:46:26 +0000 Received: by outflank-mailman (input) for mailman id 1087296; Wed, 20 Aug 2025 10:46:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uogKm-0004h4-FP for xen-devel@lists.xenproject.org; Wed, 20 Aug 2025 10:46:24 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8a5170c-7db2-11f0-b898-0df219b8e170; Wed, 20 Aug 2025 12:46:22 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9602E1FD4E; Wed, 20 Aug 2025 10:46:20 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5CD1E1368B; Wed, 20 Aug 2025 10:46:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XBygFHynpWiSFgAAD6G6ig (envelope-from ); Wed, 20 Aug 2025 10:46:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8a5170c-7db2-11f0-b898-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1755686780; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=S+9WzjEJVK6MpKC6Xk2m9qDPN9nowHIKblDbMTPY+l4=; b=MOYCY2YTBWyjpicvAhEJs9asxfQqKnCKcgNc+ZlJdlLMXCIqnHCmL/7naRQRqZQMWtDcBw USJIwBvSyP6pr61yXqY5s/cE5nUcYxmJJ3AtE/GjifFlWx9lxamzyM31b77Jg2QyIV5RQr qTeojizx8W1Jk8Ow/I9/BjuRZ2rDaRc= Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1755686780; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=S+9WzjEJVK6MpKC6Xk2m9qDPN9nowHIKblDbMTPY+l4=; b=MOYCY2YTBWyjpicvAhEJs9asxfQqKnCKcgNc+ZlJdlLMXCIqnHCmL/7naRQRqZQMWtDcBw USJIwBvSyP6pr61yXqY5s/cE5nUcYxmJJ3AtE/GjifFlWx9lxamzyM31b77Jg2QyIV5RQr qTeojizx8W1Jk8Ow/I9/BjuRZ2rDaRc= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH] tools/xenstored: fix possible NULL deref Date: Wed, 20 Aug 2025 12:46:17 +0200 Message-ID: <20250820104617.5268-1-jgross@suse.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email,suse.com:mid] X-Spam-Flag: NO X-Spam-Score: -2.80 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1755686820849124100 Content-Type: text/plain; charset="utf-8" Avoid dereferencing NULL in introduce_domain() when called during live update. Coverity ID: 1665111 Fixes: f78895ad78c9 ("tools/xenstored: Read event channel from xenstored pa= ge") Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- tools/xenstored/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index 694d68670a..5ce539d640 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1032,7 +1032,7 @@ static struct domain *introduce_domain(const void *ct= x, if (!interface && !restore) return NULL; =20 - if (interface->evtchn_port) + if (!restore && interface->evtchn_port) port =3D interface->evtchn_port; =20 if (new_domain(domain, port, restore)) { --=20 2.43.0