From nobody Fri Oct 31 04:01:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=proton.me ARC-Seal: i=1; a=rsa-sha256; t=1755037874; cv=none; d=zohomail.com; s=zohoarc; b=dWWHf8TJYW3/e3JrM0NoHR1UEvUaQGEt0ulgw4gmqEPKmOZ3eCCg8UfLWLv/P3sfNCF/RSbOlX2ESVFDcHGGVajxtm8+VcqKDEaBuxn+E5fz73eLVgKApPKaroMRlIqkwSx1mNKI67HZ60246luG5fH10MjVvGNw0v2ZRvg4SyA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755037874; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=erBCuTXJ+KpM9oo/ZWWMqnMJkUjUreb879bOnDUb9wU=; b=NGftYy3gtYXyAekGEr8Z7KygTDcYbyCI3GozO7oXGkzXjrkrTZ/7i84esDLwjcXGn6Id0+XTsg6rt2VG1mrgmOKK24nG9AkK+Bv/yXBTMukpDu+ZFWfy6tY97aLkPi49uv+MRwfEdKwiqdMBdzX620I+smX9mhGwaqUS7J+G/lQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1755037874174406.77724058769616; Tue, 12 Aug 2025 15:31:14 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1079225.1440218 (Exim 4.92) (envelope-from ) id 1ulxWC-0004VG-Oe; Tue, 12 Aug 2025 22:30:56 +0000 Received: by outflank-mailman (output) from mailman id 1079225.1440218; Tue, 12 Aug 2025 22:30:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ulxWC-0004V7-Kd; Tue, 12 Aug 2025 22:30:56 +0000 Received: by outflank-mailman (input) for mailman id 1079225; Tue, 12 Aug 2025 22:30:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ulxWB-0004TJ-AC for xen-devel@lists.xenproject.org; Tue, 12 Aug 2025 22:30:55 +0000 Received: from mail-24417.protonmail.ch (mail-24417.protonmail.ch [109.224.244.17]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 004180df-77cc-11f0-a328-13f23c93f187; Wed, 13 Aug 2025 00:30:51 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 004180df-77cc-11f0-a328-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1755037849; x=1755297049; bh=erBCuTXJ+KpM9oo/ZWWMqnMJkUjUreb879bOnDUb9wU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Ok5S+wc0JVKKpeGNj2t1l3g0uuSPnHZMeL9svUalPghjB6l+uzLNYrLT2jkehgygT WLv9B8eoOXvaST0XjqBofiRqbdjZu4KwmZcyiNW0dFx8ktW/Z7yBXy2MPdH1yM/rQ4 gf9rJj54qxHJgSiZVXlWonhnJgsY4qTGD/OJkrmSwk03L95qDsxjJva+n64viuE3QO t9Jy5RZVOZmBXE7s+TrwjnD8EE1mugIo+HepJ1opBHUiOj6V2YA+F7nnBVbtWFPJhK YlWpUUP52rTGsUL3uWvjs3K7X6GWQhb0FlabhV8igjtJH2dYKJs+sYNESucKgkdQ2K yqX9KPz5ksxSg== Date: Tue, 12 Aug 2025 22:30:45 +0000 To: xen-devel@lists.xenproject.org From: dmkhn@proton.me Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v16 2/4] tools/include: move xc_bitops.h to xen-tools/bitops.h Message-ID: <20250812223024.2364749-3-dmukhin@ford.com> In-Reply-To: <20250812223024.2364749-1-dmukhin@ford.com> References: <20250812223024.2364749-1-dmukhin@ford.com> Feedback-ID: 123220910:user:proton X-Pm-Message-ID: 460210e60e2ec9f441bd75331994d95f23f96e88 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @proton.me) X-ZM-MESSAGEID: 1755037874649116600 Content-Type: text/plain; charset="utf-8" From: Denis Mukhin =20 Move xc_bitops.h to common tools location to be shared between the toolstack and unit test code. Adjust the guard in xen-tools/bitops.h Correct the #include directives and comments referring to the old xc_bitops.h in the toolstack code. Signed-off-by: Denis Mukhin Acked-by: Anthony PERARD --- Changes since v15: - n/a --- .../ctrl/xc_bitops.h =3D> include/xen-tools/bitops.h} | 6 +++--- tools/libs/ctrl/xc_misc.c | 13 +++++++------ tools/libs/guest/xg_dom_elfloader.c | 3 ++- tools/libs/guest/xg_dom_hvmloader.c | 3 ++- tools/libs/guest/xg_private.h | 2 +- tools/libs/guest/xg_sr_common.h | 3 +-- 6 files changed, 16 insertions(+), 14 deletions(-) rename tools/{libs/ctrl/xc_bitops.h =3D> include/xen-tools/bitops.h} (95%) diff --git a/tools/libs/ctrl/xc_bitops.h b/tools/include/xen-tools/bitops.h similarity index 95% rename from tools/libs/ctrl/xc_bitops.h rename to tools/include/xen-tools/bitops.h index 4a776dc3a57f..681482f6759f 100644 --- a/tools/libs/ctrl/xc_bitops.h +++ b/tools/include/xen-tools/bitops.h @@ -1,5 +1,5 @@ -#ifndef XC_BITOPS_H -#define XC_BITOPS_H 1 +#ifndef __XEN_TOOLS_BITOPS_H__ +#define __XEN_TOOLS_BITOPS_H__ =20 /* bitmap operations for single threaded access */ =20 @@ -81,4 +81,4 @@ static inline void bitmap_or(void *_dst, const void *_oth= er, dst[i] |=3D other[i]; } =20 -#endif /* XC_BITOPS_H */ +#endif /* __XEN_TOOLS_BITOPS_H__ */ diff --git a/tools/libs/ctrl/xc_misc.c b/tools/libs/ctrl/xc_misc.c index 33e87bac2868..10ddf85667a9 100644 --- a/tools/libs/ctrl/xc_misc.c +++ b/tools/libs/ctrl/xc_misc.c @@ -17,8 +17,8 @@ * License along with this library; If not, see . */ =20 -#include "xc_bitops.h" #include "xc_private.h" +#include #include =20 int xc_get_max_cpus(xc_interface *xch) @@ -94,11 +94,12 @@ xc_cpumap_t xc_cpumap_alloc(xc_interface *xch) } =20 /* - * xc_bitops.h has macros that do this as well - however they assume that - * the bitmask is word aligned but xc_cpumap_t is only guaranteed to be - * byte aligned and so we need byte versions for architectures which do - * not support misaligned accesses (which is basically everyone - * but x86, although even on x86 it can be inefficient). + * has macros that do this as well - however they + * assume that the bitmask is word aligned but xc_cpumap_t is only + * guaranteed to be byte aligned and so we need byte versions for + * architectures which do not support misaligned accesses (which is + * basically everyone but x86, although even on x86 it can be + * inefficient). * * NOTE: The xc_bitops macros now use byte alignment. * TODO: Clean up the users of this interface. diff --git a/tools/libs/guest/xg_dom_elfloader.c b/tools/libs/guest/xg_dom_= elfloader.c index f17930d98bf7..8531e90f8e21 100644 --- a/tools/libs/guest/xg_dom_elfloader.c +++ b/tools/libs/guest/xg_dom_elfloader.c @@ -25,8 +25,9 @@ #include #include =20 +#include + #include "xg_private.h" -#include "xc_bitops.h" =20 #define XEN_VER "xen-3.0" =20 diff --git a/tools/libs/guest/xg_dom_hvmloader.c b/tools/libs/guest/xg_dom_= hvmloader.c index 39e1e5f579a7..0f569c20c522 100644 --- a/tools/libs/guest/xg_dom_hvmloader.c +++ b/tools/libs/guest/xg_dom_hvmloader.c @@ -24,8 +24,9 @@ #include #include =20 +#include + #include "xg_private.h" -#include "xc_bitops.h" =20 /* -----------------------------------------------------------------------= - */ /* parse elf binary = */ diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h index d73947094f2e..285229cf82a3 100644 --- a/tools/libs/guest/xg_private.h +++ b/tools/libs/guest/xg_private.h @@ -28,9 +28,9 @@ #include =20 #include "xc_private.h" -#include "xc_bitops.h" #include "xenguest.h" =20 +#include #include #include #include diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_commo= n.h index 2f058ee3a6ff..2e583f2eac72 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/guest/xg_sr_common.h @@ -2,11 +2,10 @@ #define __COMMON__H =20 #include +#include =20 #include "xg_private.h" #include "xg_save_restore.h" -#include "xc_bitops.h" - #include "xg_sr_stream_format.h" =20 /* String representation of Domain Header types. */ --=20 2.34.1