From nobody Thu Oct 30 18:36:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=proton.me ARC-Seal: i=1; a=rsa-sha256; t=1753897284; cv=none; d=zohomail.com; s=zohoarc; b=EY6q2pcuuEmCIuTg1il0zQyBTcnYZ/iiDcrLYwC6xMbHBNjGG98fOvNfGIJl6kQqQwRWR3p8kJFRoberq2ms671Pq+K6WrzfS1rZY39VgNebEyN/m1Fz6bF7rNLCeD90cNhQDCukUr0Lwgl8ijr20GHfB5R11bOF993TPb4mbDw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753897284; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6IoFL5uAkQfnWnRYhUejLyPar5+5hevp9Aaid6prlB8=; b=OUt8Xvdz0/6P+xvwMpOvS/tOjM7J27egKshAC4jxrnbgtzQRVlsWEwZ8afgqD1SJLAlMUU8/lC/IuXHYozpEiqhzXxY6mE9ATsNrr8ZZEX3oEC9GpzxwZUD2IF3jNY5dr00kfFTuVcOxrCOsxwjHZEUFHWz8bJvo6GSSuDQfYE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753897284810940.6004847946513; Wed, 30 Jul 2025 10:41:24 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1064316.1430008 (Exim 4.92) (envelope-from ) id 1uhAnY-0007Ar-CP; Wed, 30 Jul 2025 17:41:04 +0000 Received: by outflank-mailman (output) from mailman id 1064316.1430008; Wed, 30 Jul 2025 17:41:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uhAnY-0007Ai-9T; Wed, 30 Jul 2025 17:41:04 +0000 Received: by outflank-mailman (input) for mailman id 1064316; Wed, 30 Jul 2025 17:41:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uhAnW-00076c-Ez for xen-devel@lists.xenproject.org; Wed, 30 Jul 2025 17:41:02 +0000 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5aba231b-6d6c-11f0-a320-13f23c93f187; Wed, 30 Jul 2025 19:41:00 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5aba231b-6d6c-11f0-a320-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=l3unisoyd5cyfexynlziec4see.protonmail; t=1753897258; x=1754156458; bh=6IoFL5uAkQfnWnRYhUejLyPar5+5hevp9Aaid6prlB8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=YNKUUeBqQx+S+pHKYDQJe/UyGUO0PkaE9TtWBAbZkd21FwVvWVraqi+873XKVsGyy Xg51+42U4DuVsxhwuBZ/s1FwB0whJCmtNQbVgj6HexAA8LCreYwoTAlkcTgphO3L8Y IAOmsrcgjic9XE5qJl2rInRt5Yw0TaThriD2YXN54WM3Io+dSbp1lTFR7N0Bi8y3YT PIOon9JX0YCglI8/nn2jYRX2bn3sFkSs0v80+xBqYsV18zbyhQo5SvYIt808ZbOW0Z AOk/mkHsCPpPIpOBA20RHn3I2uoIU8KJKhASjISUpB5W/fSjEa1175SPQCNp5F4D8i tQVLpvIt1e7bQ== Date: Wed, 30 Jul 2025 17:40:54 +0000 To: xen-devel@lists.xenproject.org From: dmkhn@proton.me Cc: alejandro.garciavallejo@amd.com, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v13 1/3] xen/domain: unify domain ID allocation Message-ID: <20250730174042.1632011-2-dmukhin@ford.com> In-Reply-To: <20250730174042.1632011-1-dmukhin@ford.com> References: <20250730174042.1632011-1-dmukhin@ford.com> Feedback-ID: 123220910:user:proton X-Pm-Message-ID: 48b423b939c28f77ac7a5cde6ee6cae6fa4fb8dc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @proton.me) X-ZM-MESSAGEID: 1753897287118116600 Content-Type: text/plain; charset="utf-8" From: Denis Mukhin =20 Currently, there are two different domain ID allocation implementations: 1) Sequential IDs allocation in dom0less Arm code based on max_init_domid; 2) Sequential IDs allocation in XEN_DOMCTL_createdomain; does not use max_init_domid (both Arm and x86). The domain ID allocation covers dom0 or late hwdom, predefined domains, post-boot domains, excluding Xen system domains (domid >=3D DOMID_FIRST_RESERVED). It makes sense to have a common helper code for such task across architectu= res (Arm and x86) and between dom0less / toolstack domU allocation. Note, fixing dependency on max_init_domid is out of scope of this patch. Wrap the domain ID allocation as an arch-independent function domid_alloc()= in new common/domid.c based on the bitmap. Allocation algorithm: - If an explicit domain ID is provided, verify its availability and use it = if ID is not used; - If DOMID_INVALID is provided, search the range [1..DOMID_FIRST_RESERVED-1= ], starting from the last used ID. Implementation guarantees that two consecutive calls will never return the same ID. ID#0 is reserved for the first boot domain (currently, dom0) and excluded from the allocation range. Remove is_free_domid() helper as it is not needed now. No functional change intended. Signed-off-by: Denis Mukhin Reviewed-by: Alejandro Vallejo --- Changes since v12: - updated comment for domid_alloc() and commit message - added Alejandro's R-b --- xen/arch/arm/domain_build.c | 7 +- xen/arch/x86/setup.c | 7 +- xen/common/Makefile | 1 + xen/common/device-tree/dom0less-build.c | 15 ++-- xen/common/domain.c | 2 + xen/common/domctl.c | 42 ++--------- xen/common/domid.c | 94 +++++++++++++++++++++++++ xen/include/xen/domain.h | 3 + 8 files changed, 124 insertions(+), 47 deletions(-) create mode 100644 xen/common/domid.c diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 463ae4474d30..789f2b9d3ce7 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2050,6 +2050,7 @@ void __init create_dom0(void) .grant_opts =3D XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), }; unsigned int flags =3D CDF_privileged | CDF_hardware; + domid_t domid; int rc; =20 /* The vGIC for DOM0 is exactly emulating the hardware GIC */ @@ -2074,7 +2075,11 @@ void __init create_dom0(void) if ( !llc_coloring_enabled ) flags |=3D CDF_directmap; =20 - dom0 =3D domain_create(0, &dom0_cfg, flags); + domid =3D domid_alloc(0); + if ( domid =3D=3D DOMID_INVALID ) + panic("Error allocating domain ID 0\n"); + + dom0 =3D domain_create(domid, &dom0_cfg, flags); if ( IS_ERR(dom0) ) panic("Error creating domain 0 (rc =3D %ld)\n", PTR_ERR(dom0)); =20 diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 1543dd251cc6..2ff7c28c277b 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1047,8 +1047,11 @@ static struct domain *__init create_dom0(struct boot= _info *bi) if ( iommu_enabled ) dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu; =20 - /* Create initial domain. Not d0 for pvshim. */ - bd->domid =3D get_initial_domain_id(); + /* Allocate initial domain ID. Not d0 for pvshim. */ + bd->domid =3D domid_alloc(get_initial_domain_id()); + if ( bd->domid =3D=3D DOMID_INVALID ) + panic("Error allocating domain ID %d\n", get_initial_domain_id()); + d =3D domain_create(bd->domid, &dom0_cfg, pv_shim ? 0 : CDF_privileged | CDF_hardware); if ( IS_ERR(d) ) diff --git a/xen/common/Makefile b/xen/common/Makefile index c316957fcb36..0c7d0f5d46e1 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -11,6 +11,7 @@ obj-$(filter-out $(CONFIG_X86),$(CONFIG_ACPI)) +=3D devic= e.o obj-$(CONFIG_DEVICE_TREE_PARSE) +=3D device-tree/ obj-$(CONFIG_IOREQ_SERVER) +=3D dm.o obj-y +=3D domain.o +obj-y +=3D domid.o obj-y +=3D event_2l.o obj-y +=3D event_channel.o obj-$(CONFIG_EVTCHN_FIFO) +=3D event_fifo.o diff --git a/xen/common/device-tree/dom0less-build.c b/xen/common/device-tr= ee/dom0less-build.c index 6bb038111de9..f4b6b515d2d2 100644 --- a/xen/common/device-tree/dom0less-build.c +++ b/xen/common/device-tree/dom0less-build.c @@ -833,6 +833,7 @@ void __init create_domUs(void) { struct kernel_info ki =3D KERNEL_INFO_INIT; int rc =3D parse_dom0less_node(node, &ki.bd); + domid_t domid; =20 if ( rc =3D=3D -ENOENT ) continue; @@ -842,13 +843,13 @@ void __init create_domUs(void) if ( (max_init_domid + 1) >=3D DOMID_FIRST_RESERVED ) panic("No more domain IDs available\n"); =20 - /* - * The variable max_init_domid is initialized with zero, so here i= t's - * very important to use the pre-increment operator to call - * domain_create() with a domid > 0. (domid =3D=3D 0 is reserved f= or Dom0) - */ - ki.bd.d =3D domain_create(++max_init_domid, - &ki.bd.create_cfg, ki.bd.create_flags); + domid =3D domid_alloc(DOMID_INVALID); + if ( domid =3D=3D DOMID_INVALID ) + panic("Error allocating ID for domain %s\n", dt_node_name(node= )); + + max_init_domid =3D max(max_init_domid, domid); + + ki.bd.d =3D domain_create(domid, &ki.bd.create_cfg, ki.bd.create_f= lags); if ( IS_ERR(ki.bd.d) ) panic("Error creating domain %s (rc =3D %ld)\n", dt_node_name(node), PTR_ERR(ki.bd.d)); diff --git a/xen/common/domain.c b/xen/common/domain.c index 5241a1629eeb..12fbab01cd8e 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -1473,6 +1473,8 @@ void domain_destroy(struct domain *d) /* Remove from the domlist/hash. */ domlist_remove(d); =20 + domid_free(d->domain_id); + /* Schedule RCU asynchronous completion of domain destroy. */ call_rcu(&d->rcu, complete_domain_destroy); } diff --git a/xen/common/domctl.c b/xen/common/domctl.c index f2a7caaf853c..5509998aa139 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -51,20 +51,6 @@ static int xenctl_bitmap_to_nodemask(nodemask_t *nodemas= k, MAX_NUMNODES); } =20 -static inline int is_free_domid(domid_t dom) -{ - struct domain *d; - - if ( dom >=3D DOMID_FIRST_RESERVED ) - return 0; - - if ( (d =3D rcu_lock_domain_by_id(dom)) =3D=3D NULL ) - return 1; - - rcu_unlock_domain(d); - return 0; -} - void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) { struct vcpu *v; @@ -423,36 +409,18 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u= _domctl) =20 case XEN_DOMCTL_createdomain: { - domid_t dom; - static domid_t rover =3D 0; + domid_t domid =3D domid_alloc(op->domain); =20 - dom =3D op->domain; - if ( (dom > 0) && (dom < DOMID_FIRST_RESERVED) ) + if ( domid =3D=3D DOMID_INVALID ) { ret =3D -EEXIST; - if ( !is_free_domid(dom) ) - break; - } - else - { - for ( dom =3D rover + 1; dom !=3D rover; dom++ ) - { - if ( dom =3D=3D DOMID_FIRST_RESERVED ) - dom =3D 1; - if ( is_free_domid(dom) ) - break; - } - - ret =3D -ENOMEM; - if ( dom =3D=3D rover ) - break; - - rover =3D dom; + break; } =20 - d =3D domain_create(dom, &op->u.createdomain, false); + d =3D domain_create(domid, &op->u.createdomain, false); if ( IS_ERR(d) ) { + domid_free(domid); ret =3D PTR_ERR(d); d =3D NULL; break; diff --git a/xen/common/domid.c b/xen/common/domid.c new file mode 100644 index 000000000000..e727dcaf0793 --- /dev/null +++ b/xen/common/domid.c @@ -0,0 +1,94 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Domain ID allocator. + * + * Covers dom0 or late hwdom, predefined domains, post-boot domains. + * Excludes Xen system domains (ID >=3D DOMID_FIRST_RESERVED). + * + * Copyright 2025 Ford Motor Company + */ + +#include + +static DEFINE_SPINLOCK(domid_lock); +static DECLARE_BITMAP(domid_bitmap, DOMID_FIRST_RESERVED); + +/* + * Allocate domain ID. + * + * @param domid Domain ID hint: + * - If an explicit domain ID is provided, verify its availability and use= it + * if ID is not used; + * - If DOMID_INVALID is provided, search [1..DOMID_FIRST_RESERVED-1] rang= e, + * starting from the last used ID. Implementation guarantees that two + * consecutive calls will never return the same ID. ID#0 is reserved for + * the first boot domain (currently, dom0) and excluded from the allocat= ion + * range. + * @return Valid domain ID in case of successful allocation, + * DOMID_INVALID - otherwise. + */ +domid_t domid_alloc(domid_t domid) +{ + static domid_t domid_last; + + spin_lock(&domid_lock); + + /* Exact match. */ + if ( domid < DOMID_FIRST_RESERVED ) + { + if ( __test_and_set_bit(domid, domid_bitmap) ) + domid =3D DOMID_INVALID; + } + /* + * Exhaustive search. + * + * Domain ID#0 is reserved for the first boot domain (e.g. control dom= ain) + * and excluded from allocation. + */ + else + { + domid =3D find_next_zero_bit(domid_bitmap, + DOMID_FIRST_RESERVED, + domid_last + 1); + if ( domid =3D=3D DOMID_FIRST_RESERVED ) + domid =3D find_next_zero_bit(domid_bitmap, + DOMID_FIRST_RESERVED, + 1); + + ASSERT(domid <=3D DOMID_FIRST_RESERVED); + if ( domid < DOMID_FIRST_RESERVED ) + { + __set_bit(domid, domid_bitmap); + domid_last =3D domid; + } + else + domid =3D DOMID_INVALID; + } + + spin_unlock(&domid_lock); + + return domid; +} + +void domid_free(domid_t domid) +{ + int rc; + + ASSERT(domid <=3D DOMID_FIRST_RESERVED); + + spin_lock(&domid_lock); + rc =3D __test_and_clear_bit(domid, domid_bitmap); + spin_unlock(&domid_lock); + + ASSERT(rc); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index e10baf2615fd..8aab05ae93c8 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -38,6 +38,9 @@ void arch_get_domain_info(const struct domain *d, =20 domid_t get_initial_domain_id(void); =20 +domid_t domid_alloc(domid_t domid); +void domid_free(domid_t domid); + /* CDF_* constant. Internal flags for domain creation. */ /* Is this a privileged domain? */ #define CDF_privileged (1U << 0) --=20 2.34.1 From nobody Thu Oct 30 18:36:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=proton.me ARC-Seal: i=1; a=rsa-sha256; t=1753897282; cv=none; d=zohomail.com; s=zohoarc; b=dhZUHVBeRloGqmNg4BmmPcumvtSlgRebo1vD7AMgaBHS4LyIJ6C+qTXxuMniBrK6D8kqqtRapN/OoddzyqpDMLKbkwVKd9QshCjC1n4KnMBz4kGRrV+290MbOi1fVaTT1EMhnDnsPEld6ddpERU7XMZRr2DAOvg3BRh7F2M87eo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753897282; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lpJc4gic0ghzKZPEoCaNvipF3P9S33+QEIexX7Dzotc=; b=EVwuFcPVgRGGVsfZtwrinlxYfqsQPTtsqKlQYJy9v8Pwf8lNZOF5XtoI8+1F5YTE7AZ/5LVtxKwY9PVILl7YiY7KhuqcPxe1LDnQDkiN7y+6QPKzG1oAeKSI6IFP0ulqwzrfUW6N5rZWN6A698d0nfWIIRfYKzDejb8pq8+VNZs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 175389728274878.95185940914655; Wed, 30 Jul 2025 10:41:22 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1064317.1430018 (Exim 4.92) (envelope-from ) id 1uhAnc-0007Rm-Jp; Wed, 30 Jul 2025 17:41:08 +0000 Received: by outflank-mailman (output) from mailman id 1064317.1430018; Wed, 30 Jul 2025 17:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uhAnc-0007RR-FD; Wed, 30 Jul 2025 17:41:08 +0000 Received: by outflank-mailman (input) for mailman id 1064317; Wed, 30 Jul 2025 17:41:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uhAna-00076c-BD for xen-devel@lists.xenproject.org; Wed, 30 Jul 2025 17:41:06 +0000 Received: from mail-24418.protonmail.ch (mail-24418.protonmail.ch [109.224.244.18]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e0da714-6d6c-11f0-a320-13f23c93f187; Wed, 30 Jul 2025 19:41:05 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e0da714-6d6c-11f0-a320-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1753897263; x=1754156463; bh=lpJc4gic0ghzKZPEoCaNvipF3P9S33+QEIexX7Dzotc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=AM6E+dF7Qn9Dz73Jrk4hQlPhH0tkqsHoeRoAYTghcRdgK3WUZBSHCB3KYolM51YTz D7nDP4yxl2wW8L9x7+i2Nz5X5IQM2z+xdf4kIUNn9zWw0AZcNP2r8OMMHkRGdYjg83 jc2WuAUPCOKrwGRwZf+/VzsgPoMk+aeW0UqSNJ0CZh1An5VMXKiMKLbLcBVi9lauGL 5EyRMiVJ5LEIo49Cer6Ycfy+yn0r6w+KUXwHHq+9TyUmJaGoDP3wdvY0klQxSzVB7m 1PqrMMmERD/s90R8e+XWkTrfU5aLgfdteUsnC1LT+x16B9xRg4oiWgyiqqZSX8sFAy SIEOsPwlxXZIg== Date: Wed, 30 Jul 2025 17:41:00 +0000 To: xen-devel@lists.xenproject.org From: dmkhn@proton.me Cc: alejandro.garciavallejo@amd.com, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v13 2/3] tools/tests: introduce unit tests for domain ID allocator Message-ID: <20250730174042.1632011-3-dmukhin@ford.com> In-Reply-To: <20250730174042.1632011-1-dmukhin@ford.com> References: <20250730174042.1632011-1-dmukhin@ford.com> Feedback-ID: 123220910:user:proton X-Pm-Message-ID: c98280da7433993f217e93f9b5ccb327aee63ba8 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @proton.me) X-ZM-MESSAGEID: 1753897285163116600 Content-Type: text/plain; charset="utf-8" From: Denis Mukhin =20 Introduce some basic infrastructure for doing domain ID allocation unit tes= ts, and add a few tests that ensure correctness of the domain ID allocator. Signed-off-by: Denis Mukhin --- Changes since v12: - fixed Makefile - dropped unused symbols/includes from the test harness header - s/printk/printf/g in the test code --- tools/tests/Makefile | 2 +- tools/tests/domid/.gitignore | 2 + tools/tests/domid/Makefile | 48 ++++++++++ tools/tests/domid/include/xen/domain.h | 126 +++++++++++++++++++++++++ tools/tests/domid/test-domid.c | 78 +++++++++++++++ 5 files changed, 255 insertions(+), 1 deletion(-) create mode 100644 tools/tests/domid/.gitignore create mode 100644 tools/tests/domid/Makefile create mode 100644 tools/tests/domid/include/xen/domain.h create mode 100644 tools/tests/domid/test-domid.c diff --git a/tools/tests/Makefile b/tools/tests/Makefile index 36928676a666..ff1666425436 100644 --- a/tools/tests/Makefile +++ b/tools/tests/Makefile @@ -1,7 +1,7 @@ XEN_ROOT =3D $(CURDIR)/../.. include $(XEN_ROOT)/tools/Rules.mk =20 -SUBDIRS-y :=3D +SUBDIRS-y :=3D domid SUBDIRS-y +=3D resource SUBDIRS-$(CONFIG_X86) +=3D cpu-policy SUBDIRS-$(CONFIG_X86) +=3D tsx diff --git a/tools/tests/domid/.gitignore b/tools/tests/domid/.gitignore new file mode 100644 index 000000000000..70e306b3c074 --- /dev/null +++ b/tools/tests/domid/.gitignore @@ -0,0 +1,2 @@ +*.o +test-domid diff --git a/tools/tests/domid/Makefile b/tools/tests/domid/Makefile new file mode 100644 index 000000000000..08fbad096aec --- /dev/null +++ b/tools/tests/domid/Makefile @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Unit tests for domain ID allocator. +# +# Copyright 2025 Ford Motor Company + +XEN_ROOT=3D$(CURDIR)/../../.. +include $(XEN_ROOT)/tools/Rules.mk + +TESTS :=3D test-domid + +vpath domid.c $(XEN_ROOT)/xen/common/ + +.PHONY: all +all: $(TESTS) + +.PHONY: run +run: $(TESTS) + $(foreach t,$(TESTS),./$(t);) + +.PHONY: clean +clean: + $(RM) -- *.o $(TESTS) $(DEPS_RM) + +.PHONY: distclean +distclean: clean + $(RM) -- *~ + +.PHONY: install +install: all + $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC)/tests + $(INSTALL_PROG) test-domid $(DESTDIR)$(LIBEXEC)/tests + +.PHONY: uninstall +uninstall: + $(RM) -- $(DESTDIR)$(LIBEXEC)/tests/test-domid + +CFLAGS +=3D -D__XEN_TOOLS__ +CFLAGS +=3D $(APPEND_CFLAGS) +CFLAGS +=3D $(CFLAGS_xeninclude) +CFLAGS +=3D -I./include/ + +LDFLAGS +=3D $(APPEND_LDFLAGS) + +test-domid: domid.o test-domid.o + $(CC) $^ -o $@ $(LDFLAGS) + +-include $(DEPS_INCLUDE) diff --git a/tools/tests/domid/include/xen/domain.h b/tools/tests/domid/inc= lude/xen/domain.h new file mode 100644 index 000000000000..e5db0235445e --- /dev/null +++ b/tools/tests/domid/include/xen/domain.h @@ -0,0 +1,126 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Unit test harness for domain ID allocator. + * + * Copyright 2025 Ford Motor Company + */ + +#ifndef _TEST_HARNESS_ +#define _TEST_HARNESS_ + +#include +#include +#include +#include + +#include + +#define BUG_ON(x) assert(!(x)) +#define ASSERT(x) assert(x) + +#define DOMID_FIRST_RESERVED (10) +#define DOMID_INVALID (11) + +#define DEFINE_SPINLOCK(x) unsigned long *(x) +#define spin_lock(x) ((*(x))++) +#define spin_unlock(x) ((*(x))--) + +#define printk printf + +#define BITS_PER_LONG sizeof(unsigned long) +#define BITS_PER_WORD (8U * BITS_PER_LONG) +#define BITS_TO_LONGS(bits) \ + (((bits) + BITS_PER_LONG - 1) / BITS_PER_LONG) +#define DECLARE_BITMAP(name, bits) \ + unsigned long name[BITS_TO_LONGS(bits)] + +static inline int __test_and_set_bit(unsigned int nr, unsigned long *addr) +{ + unsigned long mask =3D 1UL << (nr % BITS_PER_WORD); + unsigned long *p =3D addr + (nr / BITS_PER_WORD); + int old =3D (*p & mask) !=3D 0; + + *p |=3D mask; + + return old; +} + +static inline int __test_and_clear_bit(unsigned int nr, unsigned long *add= r) +{ + unsigned long mask =3D 1UL << (nr % BITS_PER_WORD); + unsigned long *p =3D addr + (nr / BITS_PER_WORD); + int old =3D (*p & mask) !=3D 0; + + *p &=3D ~mask; + + return old; +} + +static inline void __set_bit(unsigned int nr, volatile unsigned long *addr) +{ + unsigned long mask =3D 1UL << (nr % BITS_PER_WORD); + unsigned long *p =3D (unsigned long *)addr + (nr / BITS_PER_WORD); + + *p |=3D mask; +} + +static inline void __clear_bit(unsigned int nr, volatile unsigned long *ad= dr) +{ + unsigned long mask =3D 1UL << (nr % BITS_PER_WORD); + unsigned long *p =3D (unsigned long *)addr + (nr / BITS_PER_WORD); + + *p &=3D ~mask; +} + +static inline unsigned long find_next_zero_bit(const unsigned long *addr, + unsigned long size, + unsigned long offset) +{ + unsigned long idx =3D offset / BITS_PER_WORD; + unsigned long bit =3D offset % BITS_PER_WORD; + + if (offset >=3D size) + return size; + + while (offset < size) + { + unsigned long val =3D addr[idx] | (~0UL >> (BITS_PER_WORD - bit)); + + if (~val) + { + unsigned long pos =3D __builtin_ffsl(~val); + + if (pos > 0) + { + unsigned long rc =3D idx * BITS_PER_WORD + (pos - 1); + + if (rc < size) + return rc; + } + } + + offset =3D (idx + 1) * BITS_PER_WORD; + idx++; + bit =3D 0; + } + + return size; +} + +typedef bool spinlock_t; +typedef uint16_t domid_t; + +/* See include/xen/domain.h */ +extern domid_t domid_alloc(domid_t domid); +extern void domid_free(domid_t domid); + +#endif /* _TEST_HARNESS_ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/tests/domid/test-domid.c b/tools/tests/domid/test-domid.c new file mode 100644 index 000000000000..d52eaf5f1f55 --- /dev/null +++ b/tools/tests/domid/test-domid.c @@ -0,0 +1,78 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Unit tests for domain ID allocator. + * + * Copyright 2025 Ford Motor Company + */ + +/* Local test include replicating hypervisor includes. */ +#include + +int main(int argc, char **argv) +{ + domid_t expected, allocated; + + printf("DOMID_FIRST_RESERVED=3D%u DOMID_INVALID=3D%u\n", + DOMID_FIRST_RESERVED, DOMID_INVALID); + + /* Test ID#0 cannot be allocated twice. */ + allocated =3D domid_alloc(0); + printf("TEST 1: expected %u allocated %u\n", 0, allocated); + ASSERT(allocated =3D=3D 0); + allocated =3D domid_alloc(0); + printf("TEST 1: expected %u allocated %u\n", DOMID_INVALID, allocated); + ASSERT(allocated =3D=3D DOMID_INVALID); + + /* Ensure ID is not allocated. */ + domid_free(0); + + /* + * Test that that two consecutive calls of domid_alloc(DOMID_INVALID) + * will never return the same ID. + * NB: ID#0 is reserved and shall not be allocated by + * domid_alloc(DOMID_INVALID). + */ + for ( expected =3D 1; expected < DOMID_FIRST_RESERVED; expected++ ) + { + allocated =3D domid_alloc(DOMID_INVALID); + printf("TEST 2: expected %u allocated %u\n", expected, allocated); + ASSERT(allocated =3D=3D expected); + } + for ( expected =3D 1; expected < DOMID_FIRST_RESERVED; expected++ ) + { + allocated =3D domid_alloc(DOMID_INVALID); + printf("TEST 3: expected %u allocated %u\n", DOMID_INVALID, alloca= ted); + ASSERT(allocated =3D=3D DOMID_INVALID); + } + + /* Re-allocate first ID from [1..DOMID_FIRST_RESERVED - 1]. */ + expected =3D 1; + domid_free(1); + allocated =3D domid_alloc(DOMID_INVALID); + printf("TEST 4: expected %u allocated %u\n", expected, allocated); + ASSERT(allocated =3D=3D expected); + + /* Re-allocate last ID from [1..DOMID_FIRST_RESERVED - 1]. */ + expected =3D DOMID_FIRST_RESERVED - 1; + domid_free(DOMID_FIRST_RESERVED - 1); + allocated =3D domid_alloc(DOMID_INVALID); + printf("TEST 5: expected %u allocated %u\n", expected, allocated); + ASSERT(allocated =3D=3D expected); + + /* Allocate an invalid ID. */ + expected =3D DOMID_INVALID; + allocated =3D domid_alloc(DOMID_FIRST_RESERVED); + printf("TEST 6: expected %u allocated %u\n", expected, allocated); + ASSERT(allocated =3D=3D expected); + + return 0; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ --=20 2.34.1 From nobody Thu Oct 30 18:36:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=proton.me ARC-Seal: i=1; a=rsa-sha256; t=1753897289; cv=none; d=zohomail.com; s=zohoarc; b=fJ77YZVXLQYqz1MM8wiAI+kG6ntYRoF55rtNkh0ip+FMbAVCc8RmEtB4dSZ+M8cWr12nNneUJQE3cYiQ0pq+ZUdn+GSa+ifZFFcvpQ3VAj5osf2lmRozlxI/eTYaiWtJrqdwnbOdoVxXp7LIaXRQ51+u+Suj37Ri09gUSI7JOqQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753897289; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cOJp9/TT9teYJtKcMJEIwPElIEvwJ0QU1V6DnZCzFaY=; b=hm+/j/670iCODhsGQqAKMFCuYAu5G3d1B391+8FbsnKx+lR3rleF/KvjI/efwdzsE7SnfCYxi5+jUmXYODHjlTIFi1R4ml2lE130mVDffU9Xk96UHsjx2Ah+tQUxwKAi/2YoqEfASUgL11ZVbfH75DBmzPn6tXbmRE4LOOeC+bc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753897289817941.9378372347152; Wed, 30 Jul 2025 10:41:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1064318.1430028 (Exim 4.92) (envelope-from ) id 1uhAni-0007mN-QF; Wed, 30 Jul 2025 17:41:14 +0000 Received: by outflank-mailman (output) from mailman id 1064318.1430028; Wed, 30 Jul 2025 17:41:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uhAni-0007mC-Ma; Wed, 30 Jul 2025 17:41:14 +0000 Received: by outflank-mailman (input) for mailman id 1064318; Wed, 30 Jul 2025 17:41:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uhAni-0006wr-2t for xen-devel@lists.xenproject.org; Wed, 30 Jul 2025 17:41:14 +0000 Received: from mail-10628.protonmail.ch (mail-10628.protonmail.ch [79.135.106.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 626abef9-6d6c-11f0-b895-0df219b8e170; Wed, 30 Jul 2025 19:41:12 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 626abef9-6d6c-11f0-b895-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1753897271; x=1754156471; bh=cOJp9/TT9teYJtKcMJEIwPElIEvwJ0QU1V6DnZCzFaY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=d51yxQ0Ll3qkFVm/TQABF+9jry1j4NWN6pKbOFf6gKMH1ABQyWvHW82Y5boQ3IV4N OGPR4+Lrgm8At3k6ENC+1nmbXEpHq0uZrVgefdyWRQUk/Ga3MI/K4zDSMxVBHDDbmv Styc6yJ2JVzm7iKTk8eh7ObzmTjS2YJKfgwsMiUTvvNIHg/ZK2+ARTld0Yp8Nlz//a gK9AbSaJYj+5Vn5lHHOp5XehOLxk0XSN/a6xcWQbSu03La7l1HtSRjrBHovTrx+lVn gae8t1mvRWVNsFBhSF35Tx7Q5F14XrHXgqRBKLLdR1qLIpR7VBVjbC7n0Aprrk0Go3 iLjo/5WdrAS4w== Date: Wed, 30 Jul 2025 17:41:05 +0000 To: xen-devel@lists.xenproject.org From: dmkhn@proton.me Cc: alejandro.garciavallejo@amd.com, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v13 3/3] xen/domain: update create_dom0() messages Message-ID: <20250730174042.1632011-4-dmukhin@ford.com> In-Reply-To: <20250730174042.1632011-1-dmukhin@ford.com> References: <20250730174042.1632011-1-dmukhin@ford.com> Feedback-ID: 123220910:user:proton X-Pm-Message-ID: 8694e1a1eccb0df379012085a56cc309dee21075 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @proton.me) X-ZM-MESSAGEID: 1753897290761116600 Content-Type: text/plain; charset="utf-8" From: Denis Mukhin =20 Use %pd for domain identification in error/panic messages in create_dom0(). No functional change. Signed-off-by: Denis Mukhin Reviewed-by: Alejandro Vallejo Acked-by: Jan Beulich --- Changes since v12: - n/a --- xen/arch/arm/domain_build.c | 6 +++--- xen/arch/x86/setup.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 789f2b9d3ce7..02a15d160962 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2084,14 +2084,14 @@ void __init create_dom0(void) panic("Error creating domain 0 (rc =3D %ld)\n", PTR_ERR(dom0)); =20 if ( llc_coloring_enabled && (rc =3D dom0_set_llc_colors(dom0)) ) - panic("Error initializing LLC coloring for domain 0 (rc =3D %d)\n"= , rc); + panic("Error initializing LLC coloring for %pd (rc =3D %d)\n", dom= 0, rc); =20 if ( vcpu_create(dom0, 0) =3D=3D NULL ) - panic("Error creating domain 0 vcpu0\n"); + panic("Error creating %pdv0\n", dom0); =20 rc =3D construct_dom0(dom0); if ( rc ) - panic("Could not set up DOM0 guest OS (rc =3D %d)\n", rc); + panic("Could not set up %pd guest OS (rc =3D %d)\n", dom0, rc); =20 set_xs_domain(dom0); } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 2ff7c28c277b..a740c6f60c63 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1084,7 +1084,7 @@ static struct domain *__init create_dom0(struct boot_= info *bi) =20 if ( (strlen(acpi_param) =3D=3D 0) && acpi_disabled ) { - printk("ACPI is disabled, notifying Domain 0 (acpi=3Doff)\n"); + printk("ACPI is disabled, notifying %pd (acpi=3Doff)\n", d); safe_strcpy(acpi_param, "off"); } =20 @@ -1099,7 +1099,7 @@ static struct domain *__init create_dom0(struct boot_= info *bi) =20 bd->d =3D d; if ( construct_dom0(bd) !=3D 0 ) - panic("Could not construct domain 0\n"); + panic("Could not construct %pd\n", d); =20 bd->cmdline =3D NULL; xfree(cmdline); --=20 2.34.1