From nobody Thu Oct 30 22:45:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753487993; cv=pass; d=zohomail.com; s=zohoarc; b=K6NMFrAbZCWV4AVdaDikJ0EkRtbqLyLiSa3v7a6pUpM00NKaxpW+PKV8RenYDrt5rxg5JShKtDhJb0i6ma9JJ1/ozPGo5ej9+l8ICsKmYIHwaIK5Hiaa9gaNe0T5W9TFh+Vd/B/cXo4tQIcTbBLErMPbdbvE3FwIqewiAQFqFFw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753487993; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AREAC1SCEzA+WwtsK+zwuoyjXAwPYcG9bspmaJd2m8M=; b=bFO34SJmUqHS9epbjbE50114iMS/AS5Mu0vHMI4+wzN3NYbVNGsKgoOetg33HTL9C1HlQN39q5kaUb0G5WW1qEZ7V3UbijeQKnklrXoDAUDUX9FQoOLY0spyQHaQzFy5D3LDFAv5DmkZP5sbivj51xPUOhReV2c7rsQH3+ElCqQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753487992906223.0528447854349; Fri, 25 Jul 2025 16:59:52 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1058719.1426237 (Exim 4.92) (envelope-from ) id 1ufSK9-00083q-CH; Fri, 25 Jul 2025 23:59:37 +0000 Received: by outflank-mailman (output) from mailman id 1058719.1426237; Fri, 25 Jul 2025 23:59:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ufSK9-00083e-98; Fri, 25 Jul 2025 23:59:37 +0000 Received: by outflank-mailman (input) for mailman id 1058719; Fri, 25 Jul 2025 23:59:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ufSK7-0007YZ-Tu for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 23:59:36 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062b.outbound.protection.outlook.com [2a01:111:f403:2415::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69205144-69b3-11f0-b895-0df219b8e170; Sat, 26 Jul 2025 01:59:34 +0200 (CEST) Received: from BN8PR03CA0016.namprd03.prod.outlook.com (2603:10b6:408:94::29) by DS7PR12MB8202.namprd12.prod.outlook.com (2603:10b6:8:e1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Fri, 25 Jul 2025 23:59:29 +0000 Received: from BL6PEPF00020E61.namprd04.prod.outlook.com (2603:10b6:408:94:cafe::a7) by BN8PR03CA0016.outlook.office365.com (2603:10b6:408:94::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.23 via Frontend Transport; Fri, 25 Jul 2025 23:59:28 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BL6PEPF00020E61.mail.protection.outlook.com (10.167.249.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 23:59:28 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Jul 2025 18:59:28 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Jul 2025 18:59:27 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Fri, 25 Jul 2025 18:59:27 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69205144-69b3-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pAjxj6Us9duQDCI4DlijVmIjDbXlSWG1CkR8qFJ3iuc8AByiyDEpYtAm0Qz7+R+Wk4PgzRsFcFqA3c4FvX9X6aVL8dC4BgDUYtBCqa9FFgPWEclZ+samOOOXq3gnvQSOKsBuzCOvdW1fggMX/pSfFnu5NObTcpWYs3Bzjd9AL7lKYZsNtQs+B+PWMLf8QSNFZHDSGO/I+bXnm41pxHdmSa5MLfPikx5e2ifTTNV+3utty0FH335ZniXAA9KLK0fLT2l6G1s0W49eyZThqFQjcyZi5O15QhGpbFHXR4hIc7HlFE2AEOCmDi14PI2Y6Eq2Icgb/dG/kZbPnBDp3BLL8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AREAC1SCEzA+WwtsK+zwuoyjXAwPYcG9bspmaJd2m8M=; b=W/JVZgoqeRV1jh9+w9Rq+D7Z/cX3fDfs+HMl8HOOEL3NklwKZ08pLx9+U1f7lleayIX1+fpNYDM+bjGpRI3oKCQY9F5CijwAi0/HEI5dLF3/Fad/i4p+rjc5livm4UUoNSoXMAPrKblyZoxOhzMyVt7ComOkuChY/Awm3YtjS/X34A+R9YL+WbvcZ7eJZqX1N5jEWk/7gWNKqClw5eH0miqt0h4hUHRBPMmQFJ9Zqpftx5d4bdUrufsTcpdCpO0oD73Yi1yUtViLQpwsvEtHbWDoTjF4Rse9FWbBTW2kkko7ryCPCMivUIooiszycG1mSAUXv2U6kKp+lpy4JfwHvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AREAC1SCEzA+WwtsK+zwuoyjXAwPYcG9bspmaJd2m8M=; b=qqKKTija580/KUoV6InW4iHk/wu0J0/iO1qEXOYuhyyl71EiDVFRO6KQaHU1dfjxrj6Va4NV27M119hTU0mlr0oYOfn1db/qkGGPv37G7HrphQXpHBQW0vkKceF4s4YupprZ53edO05e2eHC2Oc29SxdxiBq2zajZeaVFSJqgJI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD , Juergen Gross , Julien Grall Subject: [PATCH v5 02/11] tools/manage: Expose domain capabilities Date: Fri, 25 Jul 2025 19:58:49 -0400 Message-ID: <20250725235858.666813-3-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725235858.666813-1-jason.andryuk@amd.com> References: <20250725235858.666813-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E61:EE_|DS7PR12MB8202:EE_ X-MS-Office365-Filtering-Correlation-Id: 88f4f6be-3057-4d38-006c-08ddcbd74a72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8HyAyxs6xZ1ybZhPyUgLVGCY7gcXMB7QPfzx9NOqN6qhc6eIJrzmNym8O8Ud?= =?us-ascii?Q?lwU//OjZjhr7Ipke8FTeWNz5WZEc3DbEF8wd9s57mBdNy+47N5GmhJhzXT6s?= =?us-ascii?Q?xfs0FGG812Ejod12m0ZaX4XpcJoFE3IwyyVKi3PG6ao90ucR+cyYPFtv6Y/8?= =?us-ascii?Q?KwK/faI2/lZ9+dmZ1WF1y3jVBih6M/LQ43pICeb1dimQFGB8Ft5qCj+MaC83?= =?us-ascii?Q?4swWe2kvPFueR1Xhtm138oVGYjbrggfZAcUL0xP66B7TAKeYgRY5P874JXCY?= =?us-ascii?Q?iTog56GDIKXogp8sMBpyENbHoKavsUJVJaeq/HwjyBiHL9WpNt0ORkGJqbEC?= =?us-ascii?Q?eJ+6Gwf5p+wBJ05S4Oun7eS0nsaUjD9RBSjkEjZp2LZ/MRlemg3QEzWwhvvq?= =?us-ascii?Q?uPTaGUUanZWBqADKSeaJpZ9j48qqNGxDXuvrzZF6HuhRcvj+dT5j6WqUa82J?= =?us-ascii?Q?nWoFbAAEeN5oVLLHNDNe7puI9PUYt2+itErgjF3+QUcLaZII09PMzsv8UZYv?= =?us-ascii?Q?KM/qSwZ88ukWWw/PKBTjDPjzH3VUj6Q+guBGf8bjiABgS18OpnCy78c6Toxb?= =?us-ascii?Q?OWRVy6cg0yCfW2mY2kZkAWSGQGZ+iZoPEA/gPUNxhkcteK1e95XTaB2aO7N6?= =?us-ascii?Q?HPnG57iudOnxsfH6k/1RCuZpZh/ZrWhJJ9DA35CpNunk5k291I+tjncfIdmF?= =?us-ascii?Q?O10bz6YmtSHIR9IsNMf4KlqTyG9WkqHw5KFOBDlrMlVxrux3QTLvybWvEu3P?= =?us-ascii?Q?h/MhQ1pVf5UvFJJOLfZH86mUynzQbyPn7XIO0qkGPX8Qt1CgMxQYG92jEhv6?= =?us-ascii?Q?VZY4xum4KogN6jPy2u1wWS3nJdQAFiow7JPCE9Krbf1oTlEeu4NvYI9/S4+A?= =?us-ascii?Q?XSCpejz9DQfEwET+1DWgTD6gQRHSWzpIko+woeCr0oBvOmvxgjPqq+IQ1qaW?= =?us-ascii?Q?D2sHqKNAfQ5gUEYlyuNhEqk8xQOcbUVR//4TG0LKwufrubycnwHht7vQGUHu?= =?us-ascii?Q?PCGXK7AJPefCVtFbLHlE/+zubC9e3rrcmohkH9TcVfaw9W/qbR/M1LSmA5un?= =?us-ascii?Q?1aFal/o8ODM2fcEblJR5et6VHmACHyPH508zpF0Maxtgjx7vdICxFNMBWvjM?= =?us-ascii?Q?shIIn7cpzfU5NxbF+r09SEbQumZ+GG5BVpDbUTQKWj8lORWq8/Zmiah5dXY1?= =?us-ascii?Q?TEtfLpVjNKzpVS+M8xolSafaRsHP02Nzcpi/YQP1DmuQEofJaTjn4T2Q1ceu?= =?us-ascii?Q?D4VH7QcVEZ+4NH+akoQbXFYV/n9C+7CtJdWGzAOtkwNcZpoCNkHVEqFyyehe?= =?us-ascii?Q?2KTctAQIgb3XM8q45/KiJu4r8eoFGuIfW5pLQS2EjMVARvHzJ0rYMb0O9ZRw?= =?us-ascii?Q?hSSWVGwNHM9g6QDBhLJ9OTI++As3BRFSL4Vrc+CAoPCVBzCu1LQc1EalC1Vv?= =?us-ascii?Q?94fboR0EXct9GrAdEOok8PuS9caYll1bNUMlzPZ4FCoMkpZUb1fweybjiEOy?= =?us-ascii?Q?0tbIQJF4IpwRbxADfCtxs/y/xxt/BOcXbZf+?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 23:59:28.3438 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88f4f6be-3057-4d38-006c-08ddcbd74a72 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E61.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8202 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753487993880116600 Content-Type: text/plain; charset="utf-8" Add an additional "caps" argument to the libxenmanage functions to obtain a domains capabilities - control, hardware, and xenstore. Update the xenstored callers at the same time. Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Acked-by: Anthony PERARD --- v2: Add Juergen's R-b --- tools/include/xenmanage.h | 14 ++++++++++++-- tools/libs/manage/core.c | 21 +++++++++++++++++---- tools/xenstored/domain.c | 8 ++++---- 3 files changed, 33 insertions(+), 10 deletions(-) diff --git a/tools/include/xenmanage.h b/tools/include/xenmanage.h index 956b7a0a44..6fc0d9fe24 100644 --- a/tools/include/xenmanage.h +++ b/tools/include/xenmanage.h @@ -45,6 +45,12 @@ int xenmanage_close(xenmanage_handle *hdl); #define XENMANAGE_GETDOMSTATE_STATE_DYING 0x0004 /* Domain dying. */ #define XENMANAGE_GETDOMSTATE_STATE_DEAD 0x0008 /* Domain dead. */ =20 +/* Control Domain capability. */ +#define XENMANAGE_GETDOMSTATE_CAP_CONTROL 0x0001 +/* Hardware Domain capability. */ +#define XENMANAGE_GETDOMSTATE_CAP_HARDWARE 0x0002 +/* Xenstore Domain capability. */ +#define XENMANAGE_GETDOMSTATE_CAP_XENSTORE 0x0004 /* * Return state information of an existing domain. * @@ -59,7 +65,8 @@ int xenmanage_close(xenmanage_handle *hdl); * Return value: 0 if information was stored, -1 else (errno is set) */ int xenmanage_get_domain_info(xenmanage_handle *hdl, unsigned int domid, - unsigned int *state, uint64_t *unique_id); + unsigned int *state, unsigned int *caps, + uint64_t *unique_id); =20 /* * Return information of a domain having changed state recently. @@ -73,12 +80,15 @@ int xenmanage_get_domain_info(xenmanage_handle *hdl, un= signed int domid, * domid: where to store the domid of the domain (not NULL) * state: where to store the state (XENMANAGE_GETDOMSTATE_STATE_ fla= gs, * nothing stored if NULL) + * caps: where to store the capabilities (XENMANAGE_GETDOMSTATE_CAP_ + * flags, nothing stored if NULL) * unique_id: where to store the unique id of the domain (nothing stored= if * NULL) * Return value: 0 if information was stored, -1 else (errno is set) */ int xenmanage_poll_changed_domain(xenmanage_handle *hdl, unsigned int *dom= id, - unsigned int *state, uint64_t *unique_id= ); + unsigned int *state, unsigned int *caps, + uint64_t *unique_id); #endif /* XENMANAGE_H */ =20 /* diff --git a/tools/libs/manage/core.c b/tools/libs/manage/core.c index 8fb421df41..2fabdecaab 100644 --- a/tools/libs/manage/core.c +++ b/tools/libs/manage/core.c @@ -92,6 +92,7 @@ static int xenmanage_do_domctl_get_domain_state(xenmanage= _handle *hdl, unsigned int domid_in, unsigned int *domid_out, unsigned int *state, + unsigned int *caps, uint64_t *unique_id) { struct xen_domctl *buf; @@ -130,6 +131,16 @@ static int xenmanage_do_domctl_get_domain_state(xenman= age_handle *hdl, if ( st->state & XEN_DOMCTL_GETDOMSTATE_STATE_DEAD ) *state |=3D XENMANAGE_GETDOMSTATE_STATE_DEAD; } + if ( caps ) + { + *caps =3D 0; + if ( st->caps & XEN_DOMCTL_GETDOMSTATE_CAP_CONTROL ) + *caps |=3D XENMANAGE_GETDOMSTATE_CAP_CONTROL; + if ( st->caps & XEN_DOMCTL_GETDOMSTATE_CAP_HARDWARE ) + *caps |=3D XENMANAGE_GETDOMSTATE_CAP_HARDWARE; + if ( st->caps & XEN_DOMCTL_GETDOMSTATE_CAP_XENSTORE ) + *caps |=3D XENMANAGE_GETDOMSTATE_CAP_XENSTORE; + } if ( unique_id ) *unique_id =3D st->unique_id; } @@ -142,7 +153,8 @@ static int xenmanage_do_domctl_get_domain_state(xenmana= ge_handle *hdl, } =20 int xenmanage_get_domain_info(xenmanage_handle *hdl, unsigned int domid, - unsigned int *state, uint64_t *unique_id) + unsigned int *state, unsigned int *caps, + uint64_t *unique_id) { if ( !hdl || domid >=3D DOMID_FIRST_RESERVED ) { @@ -150,12 +162,13 @@ int xenmanage_get_domain_info(xenmanage_handle *hdl, = unsigned int domid, return -1; } =20 - return xenmanage_do_domctl_get_domain_state(hdl, domid, NULL, state, + return xenmanage_do_domctl_get_domain_state(hdl, domid, NULL, state, c= aps, unique_id); } =20 int xenmanage_poll_changed_domain(xenmanage_handle *hdl, unsigned int *dom= id, - unsigned int *state, uint64_t *unique_id) + unsigned int *state, unsigned int *caps, + uint64_t *unique_id) { if ( !hdl || !domid ) { @@ -164,5 +177,5 @@ int xenmanage_poll_changed_domain(xenmanage_handle *hdl= , unsigned int *domid, } =20 return xenmanage_do_domctl_get_domain_state(hdl, DOMID_INVALID, domid, - state, unique_id); + state, caps, unique_id); } diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index e1d5e8d614..f119d714ac 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -667,7 +667,7 @@ static int check_domain(const void *k, void *v, void *a= rg) unsigned int state; uint64_t unique_id; =20 - if (xenmanage_get_domain_info(xm_handle, domain->domid, &state, + if (xenmanage_get_domain_info(xm_handle, domain->domid, &state, NULL, &unique_id)) { unique_id =3D 0; state =3D 0; @@ -700,7 +700,7 @@ static void do_check_domains(void) struct domain *domain; bool notify =3D false; =20 - while (!xenmanage_poll_changed_domain(xm_handle, &domid, &state, + while (!xenmanage_poll_changed_domain(xm_handle, &domid, &state, NULL, &unique_id)) { domain =3D find_domain_struct(domid); if (domain) @@ -829,7 +829,7 @@ static struct domain *find_or_alloc_existing_domain(uns= igned int domid) domain =3D find_domain_struct(domid); if (!domain || !domain->unique_id) dom_valid =3D !xenmanage_get_domain_info(xm_handle, domid, - NULL, &unique_id); + NULL, NULL, &unique_id); =20 if (dom_valid) { if (!domain) @@ -1377,7 +1377,7 @@ int domain_alloc_permrefs(struct node_perms *perms) domid =3D perms->p[i].id; d =3D find_domain_struct(domid); if (!d) { - if (xenmanage_get_domain_info(xm_handle, domid, + if (xenmanage_get_domain_info(xm_handle, domid, NULL, NULL, &unique_id)) perms->p[i].perms |=3D XS_PERM_IGNORE; else if (!alloc_domain(NULL, domid, unique_id)) --=20 2.50.1