From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410538; cv=pass; d=zohomail.com; s=zohoarc; b=MRkqpLePZ9TGm04MF3zUniC9a5hf0R1XbhBhfja+d3+3sIrwYKlHDZUwT2lnSt7AyVIHjd1Dj7JbyDEHJIcslYyKsX0GIel5xTlNyoTbr0BTS96tFqerZkblwTJuhrk+YI8Y0ub2cJUvI7KcM6gzKMJ3jx/Km0bcVVZZtqB1q5Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410538; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wQE7SFtI6hT+kIWQ8NrT26YUgIJRLT0BB8RPA/WB9bs=; b=XPyPIEqWX1wdzPTcL5MzDSmSDVwSoU9szirHSaR4IxD/DdB7Ly97gYeUjS/vMb8wXBqlwLwNCQVrOgLCoX6NEfNZbwI6J47/rP1hiJ4xwZODGt1m5DDoHOpPRk+ofpkIhHpFz6I7uinNX7Jha37zyIqWOxZFbaAFaCOmO3JO+eg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753410538098490.08230152109934; Thu, 24 Jul 2025 19:28:58 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056825.1424831 (Exim 4.92) (envelope-from ) id 1uf8Ai-0000vl-UV; Fri, 25 Jul 2025 02:28:32 +0000 Received: by outflank-mailman (output) from mailman id 1056825.1424831; Fri, 25 Jul 2025 02:28:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Ai-0000ve-R0; Fri, 25 Jul 2025 02:28:32 +0000 Received: by outflank-mailman (input) for mailman id 1056825; Fri, 25 Jul 2025 02:28:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Ah-0000gX-Oo for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:31 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2061f.outbound.protection.outlook.com [2a01:111:f403:2408::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0cd18709-68ff-11f0-b895-0df219b8e170; Fri, 25 Jul 2025 04:28:29 +0200 (CEST) Received: from MW4PR04CA0255.namprd04.prod.outlook.com (2603:10b6:303:88::20) by DM4PR12MB5770.namprd12.prod.outlook.com (2603:10b6:8:61::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Fri, 25 Jul 2025 02:28:25 +0000 Received: from SA2PEPF000015C7.namprd03.prod.outlook.com (2603:10b6:303:88:cafe::a6) by MW4PR04CA0255.outlook.office365.com (2603:10b6:303:88::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.23 via Frontend Transport; Fri, 25 Jul 2025 02:28:24 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SA2PEPF000015C7.mail.protection.outlook.com (10.167.241.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:24 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:23 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:23 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:22 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cd18709-68ff-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UKg02909wsniTSUxvaSiK7+nNetEh5xkdfyTGoPVbY5wnO2XJgsejpMd8u9wet8BrNW9zTbNeALX8OGUrlJCf2ydKbs7GOMzwoYywXHWwITljBUsehFRWXJTN8l2lrraAATNVLrfVq5y+94fu0EGkj5XiaylBXcOXmKm27Ds4mAcSW7Rf5ED0SoefFz4+H7uUmCsRZ4IKFdaVo9poQFaLZ0osDj1weaVJk4pWQNoJpsGc0ZfNd4EbF1bcK8Fc2BJM0mcnC6nbA2vor5ZMoKQDu167hwuXBh3aoBJ4my7DZGMk66RNwj8sCNKyfvGR1hM0114wPn46V+r5Annr2hX8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wQE7SFtI6hT+kIWQ8NrT26YUgIJRLT0BB8RPA/WB9bs=; b=S9keDzl9Hd0ccHTyEkn7Gv4hj9Ilg7TP16OVPtjV8ooie/2Umr6As/1NK2zH2ot4EQx/mtpVNxriKZZWTtNp2NoFqu+8Nejc3TAElPqUwjL1Vd/05dl0K8YBCNLmBNBJDjQQnqorDrDbCkLVDks+6Oefl2t96OUcTBfK5USXR/Uaue5NFoWUjtd+b3bpiLIlNX/Oeh85s3LFFLnzxSZFekjjn1lpd0bZGSE6ziYQwcV55EsFmDr7RtyE4YNwdaqHA2iJJqjwTYllNPcABbADIRm+UfPF0weQ/HC943IhRTvZm/CUJ700lzJhhjJYiN4Dz9BxPMwc2qcspt47DX/H5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=temperror (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=temperror action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wQE7SFtI6hT+kIWQ8NrT26YUgIJRLT0BB8RPA/WB9bs=; b=yCKTqHXRY1GbsH7IrYciQa3inV8KDdaMxGyqaWs7LYq5DGJVQCFLLD/Rmi5u8P9+1FE9HxsPgo29qDKwniPBHNZoOyArn56Go3B9pwVApF4/RpnrBktyFYDfsHAShtuEVNW5IbSMzi9EqXJ0ZCmeb8ycoBukX7UKGuw8HueVmcU= X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=temperror action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of amd.com: DNS Timeout) From: Jason Andryuk To: CC: Jason Andryuk , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , "Julien Grall" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , "Juergen Gross" , Stefano Stabellini Subject: [PATCH v4 01/12] xen: Add capabilities to get_domain_state Date: Thu, 24 Jul 2025 22:28:01 -0400 Message-ID: <20250725022812.466897-2-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C7:EE_|DM4PR12MB5770:EE_ X-MS-Office365-Filtering-Correlation-Id: e92a10d4-3a20-4d11-ac7d-08ddcb22ee30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bQHU3lMadAgYswqJz2DSF4JRUKDhB8xzsl5pziAsIKzqM7mnnapD0c6P/yhS?= =?us-ascii?Q?qp7DprRj+Vdwb+n2NdN5Asdqurv+rQlmXtsgHRqCmBnjYaCNWmq1kCYqF1V+?= =?us-ascii?Q?xbpHQmplJtpFouTfWZR7M8voLNQXI4cW4ZDncz3cMFOt9l0DBvS6I1W59m8Q?= =?us-ascii?Q?MA11op0A8gUTA/droy7bkFqxDz2PLpcRIj6VDb5ubT5YLPac7s7BY23XFUXT?= =?us-ascii?Q?qy5jro7raCWTGhW/r7T9r0klCHgPE5M80XmlWXM6KwqeHPyz9ozpmOEdnFYg?= =?us-ascii?Q?x17pPTXZJ0oQL4NhEXHDQPqH7ESPG23NYqzChR4rwTPH05RKBnZbchwucj/Q?= =?us-ascii?Q?LXEXTPL1tDaSxdT/3OTjp4G1aTegjz/ywOKoEV5Cgm8UmQN1MHcb9MszdGgJ?= =?us-ascii?Q?jGePYJLI7hsJeSuTNMlULeRnDu+0BTzCi3u9TavCS9aMTgd5q2HyckIGPy0H?= =?us-ascii?Q?2u/Ol/536AcY/IOzZ4a0OrneyzGQKW7KYiERi9xZCGjhycha1tApU4XTv+d0?= =?us-ascii?Q?h3UJVteGXszYHxJNWfd1BsWPPESMiE8Fda/ppprb0vlinyQGpMo9JrdwDerh?= =?us-ascii?Q?YffNpD+BnuxLv8dQEup5rzio3+aJZK8OfPeVWteWNFQHRoz4RCNjJIhn1a82?= =?us-ascii?Q?tmo4tm6yp20Yl8MDyx13XTzcPqLRgdv1JwAijhywrCNJEOXN0FzeblRop+Ai?= =?us-ascii?Q?oOKDpQByk6q3QSJvgsFNHNe1MeNjlRnJUYX9IU50MupYG9H0d44zGKhvCvRY?= =?us-ascii?Q?4YxUdk2ym32/KjY31jj5U2Bttv/Pej705gGgmq8P1DQhfDyIHY5a75vN2xqJ?= =?us-ascii?Q?NY/aqswaw2HBJmyixyfHq4I4N5x0PkfNKpaQVzARPbXyF+XBaDKWJfBc7HJg?= =?us-ascii?Q?yZ67v2CoRhWB0Dv/Jsu79xxWTH0CleTtac32frJhNunmb91E1bIEbw4lDqbT?= =?us-ascii?Q?3+qynvdHGQWoKdthnxbOmVX0qZNYxLPvVJoAhgba9IbSHnPbKB/Bqn7nwfr/?= =?us-ascii?Q?Vrwej2SG0gYlpuvyRh7Or5ktos+mdqNa5HkEOf2aLpWVeLwxuca8UvuITqAL?= =?us-ascii?Q?6kICL//xAad3gI6aELkGjxIXY9QPrXeXuWVtHlHkVDR6Jzm/ac2NgrlwJhNs?= =?us-ascii?Q?sLjBMWzRuonGtwl49cttFuYw4AV1eixriqJuOcMJCGRrzj3hKVtGCI6mSjst?= =?us-ascii?Q?78LZ4CkkGGDutDgM9oUUN8LokDQSzMPOdYuFkrwmXCvAk0GW3b65Ngpkg9dG?= =?us-ascii?Q?yEgOebGrndWIg41Uwxm909y7ykpuFTFv9ecZshKONMEyb7aHGddJC+swmfk0?= =?us-ascii?Q?e3wbCrEJUQBxK2Hc3VdF423K+9ntEo6k1bFonaR+qOLm5ezkZNdTQLGZA0Gi?= =?us-ascii?Q?QuFUJbpabmSJxKb2Y+lssm1aTrSh5lFlNE9ksQkTT9eJp3WXTqcsRLtRUetY?= =?us-ascii?Q?COhEqYBbgsczAZQg9QUM4psqci0f7ZOaPxoQM+LlZ2tpFxpec7oZGZI6jNma?= =?us-ascii?Q?6jbDctlHC5i4/LAAATixlxVkuDzTQ/on5o4W?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:24.1303 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e92a10d4-3a20-4d11-ac7d-08ddcb22ee30 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5770 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410539098116600 Content-Type: text/plain; charset="utf-8" Expose a domain's capabilities - control, hardware or xenstore - through stable get domain state hypercall. The xenstore domain can use this information to assign appropriate permissions on connections. Repurpose the 16bit pad field for this purpose. Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Reviewed-by: Stefano Stabellini --- v3: Add Stefano's R-b v2: Init info->caps =3D 0 Remove stale comment on caps field Add Juergen's R-b --- xen/common/domain.c | 10 +++++++++- xen/include/public/domctl.h | 7 +++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 303c338ef2..3c65cca5b0 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -195,6 +195,14 @@ static void set_domain_state_info(struct xen_domctl_ge= t_domain_state *info, info->state |=3D XEN_DOMCTL_GETDOMSTATE_STATE_DYING; if ( d->is_dying =3D=3D DOMDYING_dead ) info->state |=3D XEN_DOMCTL_GETDOMSTATE_STATE_DEAD; + + info->caps =3D 0; + if ( is_control_domain(d) ) + info->caps |=3D XEN_DOMCTL_GETDOMSTATE_CAP_CONTROL; + if ( is_hardware_domain(d) ) + info->caps |=3D XEN_DOMCTL_GETDOMSTATE_CAP_HARDWARE; + if ( is_xenstore_domain(d) ) + info->caps |=3D XEN_DOMCTL_GETDOMSTATE_CAP_XENSTORE; info->unique_id =3D d->unique_id; } =20 @@ -205,7 +213,7 @@ int get_domain_state(struct xen_domctl_get_domain_state= *info, struct domain *d, int rc =3D -ENOENT; struct domain *hdl; =20 - if ( info->pad0 || info->pad1 ) + if ( info->pad0 ) return -EINVAL; =20 if ( d ) diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index a69dd96084..0c75d9d27f 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -1265,8 +1265,11 @@ struct xen_domctl_get_domain_state { #define XEN_DOMCTL_GETDOMSTATE_STATE_SHUTDOWN 0x0002 /* Shutdown finishe= d. */ #define XEN_DOMCTL_GETDOMSTATE_STATE_DYING 0x0004 /* Domain dying. */ #define XEN_DOMCTL_GETDOMSTATE_STATE_DEAD 0x0008 /* Domain dead. */ - uint16_t pad0; /* Must be 0 on input, returned as 0. */ - uint32_t pad1; /* Must be 0 on input, returned as 0. */ + uint16_t caps; +#define XEN_DOMCTL_GETDOMSTATE_CAP_CONTROL 0x0001 /* Control domain. = */ +#define XEN_DOMCTL_GETDOMSTATE_CAP_HARDWARE 0x0002 /* Hardware domain.= */ +#define XEN_DOMCTL_GETDOMSTATE_CAP_XENSTORE 0x0004 /* Xenstore domain.= */ + uint32_t pad0; /* Must be 0 on input, returned as 0. */ uint64_t unique_id; /* Unique domain identifier. */ }; =20 --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410545; cv=pass; d=zohomail.com; s=zohoarc; b=XS/I2+gZixTnMoKHMtlYPETrvTtkXmWJZf2BkjlQR5JFC3O58CU4dn98DGMzHjFzEX0OTzgHq5E0Cdjk4EqIm9M7X2gpH/RAPNvLM803q/T5MMHBbLDqT78QaXEyZ2tcCbDjwPhjzmhjvjcXrRXK9QDqR1Z6DmrrzHO4en7yQws= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410545; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AREAC1SCEzA+WwtsK+zwuoyjXAwPYcG9bspmaJd2m8M=; b=e0hxdJj+H02kyckDeblqjbx9pGP0lzmA4SgiSGw9eGCCgYOgrCVJ5gBqjM6/7fDv5VhPoN2qCBvRk5zs7I9B9HQfMkh9IdT8wTn3TaWtyJGbfmCRTzX6E31MgUT6gvgJp7yOHXcn9t0rhrvp3J3Qb0XjlY4uDdzrAFhbAW3acQ0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753410545888746.620079878518; Thu, 24 Jul 2025 19:29:05 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056826.1424835 (Exim 4.92) (envelope-from ) id 1uf8Aj-0000yU-8X; Fri, 25 Jul 2025 02:28:33 +0000 Received: by outflank-mailman (output) from mailman id 1056826.1424835; Fri, 25 Jul 2025 02:28:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Aj-0000y7-2t; Fri, 25 Jul 2025 02:28:33 +0000 Received: by outflank-mailman (input) for mailman id 1056826; Fri, 25 Jul 2025 02:28:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Ai-0000gX-0B for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:32 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062e.outbound.protection.outlook.com [2a01:111:f403:2416::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c9515d6-68ff-11f0-b895-0df219b8e170; Fri, 25 Jul 2025 04:28:30 +0200 (CEST) Received: from MN2PR10CA0034.namprd10.prod.outlook.com (2603:10b6:208:120::47) by DM4PR12MB8559.namprd12.prod.outlook.com (2603:10b6:8:17d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Fri, 25 Jul 2025 02:28:25 +0000 Received: from BL02EPF0002992B.namprd02.prod.outlook.com (2603:10b6:208:120:cafe::60) by MN2PR10CA0034.outlook.office365.com (2603:10b6:208:120::47) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.22 via Frontend Transport; Fri, 25 Jul 2025 02:28:25 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0002992B.mail.protection.outlook.com (10.167.249.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:24 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:24 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:24 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:23 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c9515d6-68ff-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rRIzwpfIZrRHdhmLKPljrMH8RPLjhATDGk58E/FkcjQ8vW9cA80UKAtnEUxRx6MP9TPWjDnuUmrTEoD1Y4xQ3B+Dwz8NzU9EHvbgr2yNzmMYLkLYssu1HzEar00e2dLPWQGVwdWcFXoI0wVMhQxdz24J1nTAkSwZIdxt4QU6vrOzur5/vQ4ThSv0rcqvlQQkfp7oYw+bNE0yRcLtlPW1WSMVX1cthiDlvF4bpDYuhLM+QaBdRpRAPOG4CscBT2fdW8LHvs70MLRT32Gp8+SevdVRvMZebNW+lOUY4MGX6bAHno3Wh9dCWP3zK4nSoEUHJ3zIgHiFwENMeUZ2ZC+xMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AREAC1SCEzA+WwtsK+zwuoyjXAwPYcG9bspmaJd2m8M=; b=ho34A+KzLzQy7caPkQOb8oE0ZXt4hYNsK4pOtrKdNwWtTozkHzK/ittllyXr6dV/h3Yw8OeD5OzebZ6dG2C2m0KWaqAqel65OaTGmORtV7uNigCaRd+RKWJp40lQA2CBlNFNlw3QrNybd8J/EgfLKJPWGESBsPWv8Mv2D6B3ot6gVa5w+ogEcSyee3cbzyaEeWmHo75speL9gd8rIkaDx6SEvTLr13vGKCZgnaz6SamP6lN3q7IHF1LCBWT4O3lpZtR7eqjZi0Zzbr6FPNQ+U7l038kDq9h6GPoyWG72ki9pMxyI9EqqXUR1oioku1Nie3lRhjPs5nM2mx+/QWV5Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AREAC1SCEzA+WwtsK+zwuoyjXAwPYcG9bspmaJd2m8M=; b=JnQckSsTLlAZgW/Cyb6+/jrQOgxwiqhT7KpatG29bMbHsst4jxh1bAijwK/fY3SvSxPM1m3kLKGxcobNz38oJ2RIUmrUfxodBcoWdnxXR0kM3UGp5OePA3vXUyw4p8f16nkRP69iA0SviTUprntwubP9EYIApTKXpujDLgX38hU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD , Juergen Gross , Julien Grall Subject: [PATCH v4 02/12] tools/manage: Expose domain capabilities Date: Thu, 24 Jul 2025 22:28:02 -0400 Message-ID: <20250725022812.466897-3-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992B:EE_|DM4PR12MB8559:EE_ X-MS-Office365-Filtering-Correlation-Id: c6e8317d-7300-46dc-4191-08ddcb22ee9a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CSMHlPIJgbk/sCkOlwrEXYs/jlplO36Mx5CP3pGASzhGnrJYOjTjy88vgEGE?= =?us-ascii?Q?xhpv+WZKqRX6MUmDLuAYK5KutvDGreCfH1ZlvITE0La21ECzhoyYmwfHuapf?= =?us-ascii?Q?GjIVm3Ywqf4+9TwqWTRj3OZnXJMDwYGvJvBwVanSAMxI5OP0LYpfVLq9Kqzx?= =?us-ascii?Q?HzkukNbtE8QhrQl3tN4CCv4RnIHM63MAqIF3Q7q3JEc29voJhkhD3UHhBMHY?= =?us-ascii?Q?T0LD46s8OfNSAncLR+i7114GZLg01q4h3R5nXzVOwv4xWkcNKR/pVaLW44uI?= =?us-ascii?Q?WEFW16pWJLiWvrbneLS0Ysbiq2Thgoj8PELoNJzd21AV5qGDI/rsxpdi11vL?= =?us-ascii?Q?eWDxE7OkKvy/qXsERr7E3Hr7dRiHB6yLWEr6fjmA1XmB9gZhC2J1kRyKvBf8?= =?us-ascii?Q?nUQwJnLskU8vMfHtFO7rKXgYvcXbvHdLua0+wGMtIjBp/A7u39dL8Wio+Eds?= =?us-ascii?Q?4D63SP6T/RNWiPKqjMsLnYz0KyWaQLFlpfYZ0QzIUaqmO7J0JGjtQO2tncWA?= =?us-ascii?Q?eL83pExlOqqoS5aKdX0GbtKNRyEuSUdHcQZIHvz3x+40QffRpIwq7yCA/s9p?= =?us-ascii?Q?sAMZ/Ym7cZiq/3bnruOjoKF21oy8c7pdTcE43qgJJjhPxNGiBOK1/V9WcBPK?= =?us-ascii?Q?CtvIwa9MdYekEEegcETNaR1PbBTtL2SIyHEJajRDBAu4GdRD0Dv/hyQTaXe7?= =?us-ascii?Q?FR06ysEgAVidK5IdjK6N9a7tJ9WF4RS7k9jQ1H9G4fxNMASYncxoYMuA9ZbH?= =?us-ascii?Q?YtFwA+GhcjGb9nL/J9tfPU6Ix7/vpcwIZ2fLLi5JO+E68RQdroCnJLI5EQ0V?= =?us-ascii?Q?PGV5c3iVUbI/0I+ZcM0PAgKg8uo/cY5rNOttpeffVaHA7V8/4jWDx40Cn0uL?= =?us-ascii?Q?FNcL1OY7+iA5x5FEgKvxkB99fPFMKcANGzi8LFMiFtzP2wi24lh/dizzgqGF?= =?us-ascii?Q?tsTNJY/vvbH5oONkTBJC2wwkZGq9AlgCvAuA9SJ9jlMq1L4lWDZqvZ3n2e0S?= =?us-ascii?Q?tdvH06oQ4eqyuOez/PzgjdY4VwvRLgJMxSYRaeFWmeDkz3QyUsGYGCbC3Qzl?= =?us-ascii?Q?s+NkLV8f8t4qoN4wkXrbjlpGwHPCpiDIPlNiqnMnzIYO57w4CrutGPvAsJBr?= =?us-ascii?Q?FMWyJbCTbQdxxs4EFEaEIHJZ4GOgEuH+S9Yw+hn0+Z9JGMLRCS9O3IK+PMLx?= =?us-ascii?Q?HBFmHDFZ1jJHrA4TelXcKjGXxe2v746T3/9hF2wl/01oRRY1CbQLNluvTm3S?= =?us-ascii?Q?yrWUczb0z1cUBZB14dwrcfNtw6ba2ITGP308Ok/9kcHQAUEjrHXd0o2FDaY2?= =?us-ascii?Q?y7ZMGWXxm/bUudwhxuY+PdeKSgQwdm2a0McVQ/nqeMLd9Mjci0/hvwB9Y6tO?= =?us-ascii?Q?sOsLmQX+gyt79uhpvA/3T2fbfI2/0CBKnQYapBKbjlLJfVfV4r6K30UM+jvM?= =?us-ascii?Q?kLApAUxNeJXeNTdhNJJhP2TXkcJH+J9pXrtzKZKOREplMi5yI3kfB+F7k5vJ?= =?us-ascii?Q?bNg3DfJxdevnCX2jPYZ0a/IcjRAb3VWltwsX?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:24.8459 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6e8317d-7300-46dc-4191-08ddcb22ee9a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8559 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410546824116600 Content-Type: text/plain; charset="utf-8" Add an additional "caps" argument to the libxenmanage functions to obtain a domains capabilities - control, hardware, and xenstore. Update the xenstored callers at the same time. Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross --- v2: Add Juergen's R-b --- tools/include/xenmanage.h | 14 ++++++++++++-- tools/libs/manage/core.c | 21 +++++++++++++++++---- tools/xenstored/domain.c | 8 ++++---- 3 files changed, 33 insertions(+), 10 deletions(-) diff --git a/tools/include/xenmanage.h b/tools/include/xenmanage.h index 956b7a0a44..6fc0d9fe24 100644 --- a/tools/include/xenmanage.h +++ b/tools/include/xenmanage.h @@ -45,6 +45,12 @@ int xenmanage_close(xenmanage_handle *hdl); #define XENMANAGE_GETDOMSTATE_STATE_DYING 0x0004 /* Domain dying. */ #define XENMANAGE_GETDOMSTATE_STATE_DEAD 0x0008 /* Domain dead. */ =20 +/* Control Domain capability. */ +#define XENMANAGE_GETDOMSTATE_CAP_CONTROL 0x0001 +/* Hardware Domain capability. */ +#define XENMANAGE_GETDOMSTATE_CAP_HARDWARE 0x0002 +/* Xenstore Domain capability. */ +#define XENMANAGE_GETDOMSTATE_CAP_XENSTORE 0x0004 /* * Return state information of an existing domain. * @@ -59,7 +65,8 @@ int xenmanage_close(xenmanage_handle *hdl); * Return value: 0 if information was stored, -1 else (errno is set) */ int xenmanage_get_domain_info(xenmanage_handle *hdl, unsigned int domid, - unsigned int *state, uint64_t *unique_id); + unsigned int *state, unsigned int *caps, + uint64_t *unique_id); =20 /* * Return information of a domain having changed state recently. @@ -73,12 +80,15 @@ int xenmanage_get_domain_info(xenmanage_handle *hdl, un= signed int domid, * domid: where to store the domid of the domain (not NULL) * state: where to store the state (XENMANAGE_GETDOMSTATE_STATE_ fla= gs, * nothing stored if NULL) + * caps: where to store the capabilities (XENMANAGE_GETDOMSTATE_CAP_ + * flags, nothing stored if NULL) * unique_id: where to store the unique id of the domain (nothing stored= if * NULL) * Return value: 0 if information was stored, -1 else (errno is set) */ int xenmanage_poll_changed_domain(xenmanage_handle *hdl, unsigned int *dom= id, - unsigned int *state, uint64_t *unique_id= ); + unsigned int *state, unsigned int *caps, + uint64_t *unique_id); #endif /* XENMANAGE_H */ =20 /* diff --git a/tools/libs/manage/core.c b/tools/libs/manage/core.c index 8fb421df41..2fabdecaab 100644 --- a/tools/libs/manage/core.c +++ b/tools/libs/manage/core.c @@ -92,6 +92,7 @@ static int xenmanage_do_domctl_get_domain_state(xenmanage= _handle *hdl, unsigned int domid_in, unsigned int *domid_out, unsigned int *state, + unsigned int *caps, uint64_t *unique_id) { struct xen_domctl *buf; @@ -130,6 +131,16 @@ static int xenmanage_do_domctl_get_domain_state(xenman= age_handle *hdl, if ( st->state & XEN_DOMCTL_GETDOMSTATE_STATE_DEAD ) *state |=3D XENMANAGE_GETDOMSTATE_STATE_DEAD; } + if ( caps ) + { + *caps =3D 0; + if ( st->caps & XEN_DOMCTL_GETDOMSTATE_CAP_CONTROL ) + *caps |=3D XENMANAGE_GETDOMSTATE_CAP_CONTROL; + if ( st->caps & XEN_DOMCTL_GETDOMSTATE_CAP_HARDWARE ) + *caps |=3D XENMANAGE_GETDOMSTATE_CAP_HARDWARE; + if ( st->caps & XEN_DOMCTL_GETDOMSTATE_CAP_XENSTORE ) + *caps |=3D XENMANAGE_GETDOMSTATE_CAP_XENSTORE; + } if ( unique_id ) *unique_id =3D st->unique_id; } @@ -142,7 +153,8 @@ static int xenmanage_do_domctl_get_domain_state(xenmana= ge_handle *hdl, } =20 int xenmanage_get_domain_info(xenmanage_handle *hdl, unsigned int domid, - unsigned int *state, uint64_t *unique_id) + unsigned int *state, unsigned int *caps, + uint64_t *unique_id) { if ( !hdl || domid >=3D DOMID_FIRST_RESERVED ) { @@ -150,12 +162,13 @@ int xenmanage_get_domain_info(xenmanage_handle *hdl, = unsigned int domid, return -1; } =20 - return xenmanage_do_domctl_get_domain_state(hdl, domid, NULL, state, + return xenmanage_do_domctl_get_domain_state(hdl, domid, NULL, state, c= aps, unique_id); } =20 int xenmanage_poll_changed_domain(xenmanage_handle *hdl, unsigned int *dom= id, - unsigned int *state, uint64_t *unique_id) + unsigned int *state, unsigned int *caps, + uint64_t *unique_id) { if ( !hdl || !domid ) { @@ -164,5 +177,5 @@ int xenmanage_poll_changed_domain(xenmanage_handle *hdl= , unsigned int *domid, } =20 return xenmanage_do_domctl_get_domain_state(hdl, DOMID_INVALID, domid, - state, unique_id); + state, caps, unique_id); } diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index e1d5e8d614..f119d714ac 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -667,7 +667,7 @@ static int check_domain(const void *k, void *v, void *a= rg) unsigned int state; uint64_t unique_id; =20 - if (xenmanage_get_domain_info(xm_handle, domain->domid, &state, + if (xenmanage_get_domain_info(xm_handle, domain->domid, &state, NULL, &unique_id)) { unique_id =3D 0; state =3D 0; @@ -700,7 +700,7 @@ static void do_check_domains(void) struct domain *domain; bool notify =3D false; =20 - while (!xenmanage_poll_changed_domain(xm_handle, &domid, &state, + while (!xenmanage_poll_changed_domain(xm_handle, &domid, &state, NULL, &unique_id)) { domain =3D find_domain_struct(domid); if (domain) @@ -829,7 +829,7 @@ static struct domain *find_or_alloc_existing_domain(uns= igned int domid) domain =3D find_domain_struct(domid); if (!domain || !domain->unique_id) dom_valid =3D !xenmanage_get_domain_info(xm_handle, domid, - NULL, &unique_id); + NULL, NULL, &unique_id); =20 if (dom_valid) { if (!domain) @@ -1377,7 +1377,7 @@ int domain_alloc_permrefs(struct node_perms *perms) domid =3D perms->p[i].id; d =3D find_domain_struct(domid); if (!d) { - if (xenmanage_get_domain_info(xm_handle, domid, + if (xenmanage_get_domain_info(xm_handle, domid, NULL, NULL, &unique_id)) perms->p[i].perms |=3D XS_PERM_IGNORE; else if (!alloc_domain(NULL, domid, unique_id)) --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410539; cv=pass; d=zohomail.com; s=zohoarc; b=kJzC2qhWmhXm5vnDLUNB80vx3rvlqNEQ1c0lAM1g9MM257+KuvgHNcZ5oYYFyoP1oOgOUzZJet84BrmW/mISwn6r8t9PNnekg2TMNEBoVbQ67eBU5g31Q7yGh2VStPEVqpPdKgBxY7KJcj4XWjYRytKVswR1M3ANTieirzVRw8A= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410539; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=P7V3nt4OkeSNPSJ4nHqixXneapfe/i7O8Q64iPvkpFA=; b=L5qbIflNZSVb0TFFIC5c73+qyQ8hHQOF2n2cHIv3QtRFREWgCi3/FooBmX22Z8LPWIp4nXE9QF7M6Vv563ZF0pNwInn/BoMTnHMGxN4DPP7JO92m8LTXgFOiCBgRhRCZmHWiPHiYjwTc9JV9j8TdIEQHMnMKVZw+P266kAcqieE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 175341053914755.919980355054236; Thu, 24 Jul 2025 19:28:59 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056827.1424851 (Exim 4.92) (envelope-from ) id 1uf8Ak-0001NI-ES; Fri, 25 Jul 2025 02:28:34 +0000 Received: by outflank-mailman (output) from mailman id 1056827.1424851; Fri, 25 Jul 2025 02:28:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Ak-0001MQ-9F; Fri, 25 Jul 2025 02:28:34 +0000 Received: by outflank-mailman (input) for mailman id 1056827; Fri, 25 Jul 2025 02:28:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Ai-0000gR-Sa for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:32 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2060b.outbound.protection.outlook.com [2a01:111:f403:200a::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0def454e-68ff-11f0-a31e-13f23c93f187; Fri, 25 Jul 2025 04:28:32 +0200 (CEST) Received: from MN2PR15CA0005.namprd15.prod.outlook.com (2603:10b6:208:1b4::18) by PH0PR12MB7930.namprd12.prod.outlook.com (2603:10b6:510:283::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Fri, 25 Jul 2025 02:28:26 +0000 Received: from BL02EPF00029928.namprd02.prod.outlook.com (2603:10b6:208:1b4:cafe::43) by MN2PR15CA0005.outlook.office365.com (2603:10b6:208:1b4::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.22 via Frontend Transport; Fri, 25 Jul 2025 02:28:26 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF00029928.mail.protection.outlook.com (10.167.249.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:26 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:26 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:25 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0def454e-68ff-11f0-a31e-13f23c93f187 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PMHteKIi6r8JKnFvta5BqWWS4d/co5wW4mqV//wOtJoy6TUN7DRf1YLo5Pw0GFMEYA2I4TnjM3aJDVE7FOsEzslINa6YC6QYmNOJ1bHQo6i7IqQQkmYITeMhEyvxJg3rUfK4T5VZh4x53f2oGZc1BHkEdtTiUVjfVlztKJq/QJrL8KsAyEzlCrQseSkogV8EiMpC6nz20f6bmfLp7Ssn4ca3g4zuUytT4e0xI5F1yXHxpt8oN9WqowL1rd/49kTXZL1y4bOYYEaOG6zhs8M2/dk/G0IOYm6pEaM//lbA5bPqpQXAdLHjKTVEKE5fVJi+kxTswhjG0KydMsRJOqZR5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P7V3nt4OkeSNPSJ4nHqixXneapfe/i7O8Q64iPvkpFA=; b=BRN0ch15ZGLTfVuWmxXcVf+buQAhYvGBjEkpA/XjCmpk5ZdffxI7PD4CEdjIgJ8smozxAt4mN499a6q8gfaNqwUhU7xMKxIp9q1btB/OT7SnLj0zH8+7ZdFx15jIlCHcCF19SvyaQxt3rieERq73RQZVL8DgYWte7soL8hzNMD6NTkaGBwt6MMvoSdzpnrwSPCsE8GPuaUU/NxId+v8oljbtRxkI60hy0fFqCS7zUlIMDZt+gjj/UFTleaWhyUfRBsvGYEAt1k5JF2bpMz9kvI8wBtJUEW3Yk/RHdWFYb+00ZerYRjBLZEv5snzrlQ0APsP0CGCkprbUb/CfTxfliA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P7V3nt4OkeSNPSJ4nHqixXneapfe/i7O8Q64iPvkpFA=; b=fjcZgSblD3KfNtlOreI/WMXY+SWkTXPoRcyPh5ZWRxGYn2ZrVdoDPa4Ge95AhmJ0QaE3/UFmvXzBFmHHhhBRq8JBoXps/s0JN0QzRHWP9YX44fednTxPZNwsHgAToUDi2wLB9ianOQ+7AAF+bAFTCISktPrxkgU8FLetkLbtOdw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross Subject: [PATCH v4 03/12] public/io: xs_wire: Include event channel in interface page Date: Thu, 24 Jul 2025 22:28:03 -0400 Message-ID: <20250725022812.466897-4-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB04.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029928:EE_|PH0PR12MB7930:EE_ X-MS-Office365-Filtering-Correlation-Id: 22cc1978-fa2b-4052-713a-08ddcb22ef8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?TBT53ROuF2XAofdFSfs8P7UJw8lUkWukL/RpVMe/9Fg68X6VKD2hoPqrTcwP?= =?us-ascii?Q?YtsFvEVketTeKdwJ2gIqyvPLDVL2Ve0LJNEtnJrt1yD0daKXu7lRR/vWvPeE?= =?us-ascii?Q?62KjUqJk3or6pZ1GU0+cqXc5ClTJ/8ne8h7M/vYncMcFV0HrkzDLmDfEwbhR?= =?us-ascii?Q?QDUxojUHZEZQQqDFp4Vst9DdvMnB4e9IGPXQvMS7J+ODk3/tW3PhCfFcWy+/?= =?us-ascii?Q?1sG1oidc2P3u9d8iuF9MjXGf9a4UglmsipeX4uWpT2g1SMQv3lMXHkfE7KEZ?= =?us-ascii?Q?J6FCgkbal7rrq0ibuXywdtp1/vpM1GRVhRHbZ5Aw03itO5a0i0/bQmljIwVF?= =?us-ascii?Q?9onCv+H54KTlliCsvdUFkDqWuzCh0xMZtwtUhFTUeCVA1THwOu6X2+dq6hfk?= =?us-ascii?Q?uyjQaBz29u4VOCEiI/dlSoVElp4VgviGy1IAicDDPDi/NsX+LytyNWn2Jam4?= =?us-ascii?Q?vYhGYF+COH2vtrOFna6QgX0+TpuZGENLiPTqHiJl/dOtBDGG37ioLWR6P1qo?= =?us-ascii?Q?cqgpC1OiOP+xs+ldOEsoge8wsyFdSvnLk4pUTQqlpyL4xPJx7gpG5dCjTIky?= =?us-ascii?Q?lThFiZpMOT5vXkMVxYt7EkeUFYtPQs8wnLfc2EBd3HagIgmWUI7gZlpgYguQ?= =?us-ascii?Q?NEwC8jXTobwMET1tu3vNmpZJk0D5F6TkBgbD2BUjK+IqNmjyz9FRZBzBFywV?= =?us-ascii?Q?v3nuJg0E+IK/r/g8/F4v8IAsHYeqpWZDBSnCoGT0IMroJfC2sG/imXjgtX+m?= =?us-ascii?Q?vcpHKpF9bLcO2/XnhtJkyvhMS+90Ver8A7OcX1HYhy0GjhIyVi4q+cX5Ineh?= =?us-ascii?Q?/BSifEXzw5dpbZIQ3KwlpY1NNeHGzeiQMZJ/BMK82x7s32eTjUd3s0btDKrC?= =?us-ascii?Q?vXfFMFOj8gTmo+TycTrs4CLP0nE+zZGai6XE0NaF1LL3KdCYX+945q5BdagY?= =?us-ascii?Q?KClF7IaRAG4PUnhftFxzXJ5YhA3VGjvJbOv9QkLUegLFuIqw77ma+BeD3+v2?= =?us-ascii?Q?sMa5+sDFbOBL15GID5oEtMW++EilbkzKhfk55mUzvb0udmI7MR7XCTTGwd6y?= =?us-ascii?Q?+j6PSpOLqGP9UTHGLqT0jBv/Zutf+6Ec2Zn4KK7mipYqtkXLAlHvQETvRA6p?= =?us-ascii?Q?qV9T062EWRiV5FDjediO85RLB92WRkhvouwCGDlOyJkL5/qUIkBj/7AKyVDH?= =?us-ascii?Q?cwh7BeAt87Tnhc+Z3GPISYkAqN+aHFc5jmufIvxAGjGMvR9upmp+CaCGnpz8?= =?us-ascii?Q?YQQEGsU714SSRKRd8I5HeSrONHjb1T1U2opmLsi53jvb2ctkaWM80fyyh6rw?= =?us-ascii?Q?/0olWIR0vhA2pWzMnehjQPT+077IPf+YgdAjtnsLbukEg4ixEBn/zfKPvzSg?= =?us-ascii?Q?+VAWe09EywTxpYdUk2+LppA/qFD1w14g0sQ5UjZkOOLU+jUy+6pxol9x2a/q?= =?us-ascii?Q?GPBwmwpyUwwUSTSbdes9Z5fc8xVHHJFAokBEd1lesnvI9A/T/ejDbdAneXq4?= =?us-ascii?Q?nNABo3QACBuNQfloyemWfG+JwiyoWmioCb2G?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:26.4268 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22cc1978-fa2b-4052-713a-08ddcb22ef8b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029928.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7930 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410540924116600 Content-Type: text/plain; charset="utf-8" Include the event channel in struct xenstore_domain_interface. This way the toolstack or xen can communicate the event channel to xenstored in memory xenstored already needs to access. xenstored maps the grant with the well known GNTTAB_RESERVED_XENSTORE index, so no further information is needed. Suggested-by: Juergen Gross Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross --- v2: s/domU/domain/ in comment Add Juergen's R-b --- xen/include/public/io/xs_wire.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wir= e.h index e92a87a07b..d2e2b8b9eb 100644 --- a/xen/include/public/io/xs_wire.h +++ b/xen/include/public/io/xs_wire.h @@ -110,6 +110,7 @@ struct xenstore_domain_interface { uint32_t server_features; /* Bitmap of features supported by the serve= r */ uint32_t connection; uint32_t error; + uint32_t evtchn_port; }; =20 /* Violating this is very bad. See docs/misc/xenstore.txt. */ @@ -134,6 +135,12 @@ struct xenstore_domain_interface { #define XENSTORE_ERROR_RINGIDX 2 /* Invalid ring index */ #define XENSTORE_ERROR_PROTO 3 /* Protocol violation (payload too long) = */ =20 +/* + * The evtchn_port field is the domain's event channel for xenstored to si= gnal. + * It is filled in by Xen for dom0less/Hyperlaunch domains. It is only us= ed + * when non-zero. Otherwise the event channel from XS_INTRODUCE is used. + */ + #endif /* _XS_WIRE_H */ =20 /* --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410542; cv=pass; d=zohomail.com; s=zohoarc; b=d82XMxLQjYGUKUlHWZEi1JuyVFMYQG4XFZirCSVlNfdxA07L8sxDgM4XmiroU3Ql0n494AtD9AbF5pnCIkD0f3TIlBV32GKDk419tuW+KR7/ae5GtsSbmYURy4ylbWvsDGF7kfFqRGbB3hERKjTYKWO4eUX8dNjjQeJ7/igOoUA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410542; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dsQY3CEOxMXmJwgGeLeDonCu0Zez5UFFVJskUGMmihQ=; b=K+VeSYR90NyUJwz5mIzi/N7rY3TepcQOXxAc3AQsXFhUEv/24MqWW13Zs40q26UEREGel1p9m1jZBlFSml17mfzZqwsSf5fDdZnlMRA20XR9g+68H1RF0TAb+eipUU9JI3gfBxZqd1xspr/ISvv6IrdzkNWOmmmF004fHcMSSAA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753410542904559.8001482376195; Thu, 24 Jul 2025 19:29:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056831.1424861 (Exim 4.92) (envelope-from ) id 1uf8Am-0001eo-N1; Fri, 25 Jul 2025 02:28:36 +0000 Received: by outflank-mailman (output) from mailman id 1056831.1424861; Fri, 25 Jul 2025 02:28:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Am-0001eT-Iw; Fri, 25 Jul 2025 02:28:36 +0000 Received: by outflank-mailman (input) for mailman id 1056831; Fri, 25 Jul 2025 02:28:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Ak-0000gR-Su for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:34 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20619.outbound.protection.outlook.com [2a01:111:f403:2414::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f64acbd-68ff-11f0-a31e-13f23c93f187; Fri, 25 Jul 2025 04:28:33 +0200 (CEST) Received: from MN2PR15CA0017.namprd15.prod.outlook.com (2603:10b6:208:1b4::30) by SA1PR12MB7151.namprd12.prod.outlook.com (2603:10b6:806:2b1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.25; Fri, 25 Jul 2025 02:28:28 +0000 Received: from BL02EPF00029928.namprd02.prod.outlook.com (2603:10b6:208:1b4:cafe::26) by MN2PR15CA0017.outlook.office365.com (2603:10b6:208:1b4::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.22 via Frontend Transport; Fri, 25 Jul 2025 02:28:28 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF00029928.mail.protection.outlook.com (10.167.249.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:27 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:27 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:27 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:26 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f64acbd-68ff-11f0-a31e-13f23c93f187 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yf5zhsUBEUZmzi6ic9In5NG8Bs0KH3q6wkTH2cWDlimepqhoOOEStQ8Y+rAWqejjULax+U0reAwtppMZbwD8n0jAZovQ+OeOo3zhs9QeCvgPwoLsPoMhpH4mJE8BV4FT+/PN/qcvz39KWn9wpKihzcM3ONPKTz6707MuCTrd2TkYagUe8RX83UxPOvfT8Af779ba/43Wjb6PpHTZ+dT+HoUtpHQo8b/BzHKlHIWbcFZCRF62hQMxXP2NIl7ua5XKZ6lbiyjHGjxC8PHB0RefLRGP07I6bpjBgTmZUN2cdMFvfmPD9ZqT25b8lQpogxVItpfiZcn4ONs3HTTuKqcHOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dsQY3CEOxMXmJwgGeLeDonCu0Zez5UFFVJskUGMmihQ=; b=ZJGfRSXqw0q8nFwjS97kliI+v1/RCejT/pBWrgQ3eXtXcLEmgJEGf9vB8AZdOlVZr1J1yH8dJrnah8/QuxXQ13wtYWDm3WBBWr3f7APsjkDh+NpdiS7jPEoTC9/zNfZfEwwFSHgxVTOmnfx8eRXQrVDMVzF5zG6qqy8cxqMmFoNe96f2Cj6FtSHPQjUSJAVRH/duDK1cu0CYFpXpBOoecbKEdpv7ZNWn9Gn/DUtE7tXdAXQPUFvoya4rB+Uxb1W16sLlO0d8kIiyKzhe0/U8zXk3B0c+jwlV8gmfweem2GvJChTkY9vl4MO/xnqVmQQctp5a/m5WUkTEKjgHV/EfIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dsQY3CEOxMXmJwgGeLeDonCu0Zez5UFFVJskUGMmihQ=; b=2NFl7LBE4ijEdNXG/6ZyuWs4NobE4zP/lYcyUUx3ocAHbY/NCrDqbVRnf73/c7qUyPodyTINnLJ350c6rUTKEAc0BCO+z9v+GFpreF+rNU1/ZOW/RjVG2U9mYFSW+FeCtA+8OUhhqr3kj2lOyC9KnzhHwqI4ZASvB4qPEXqhZjk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel Subject: [PATCH v4 04/12] xen/dom0less: store xenstore event channel in page Date: Thu, 24 Jul 2025 22:28:04 -0400 Message-ID: <20250725022812.466897-5-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029928:EE_|SA1PR12MB7151:EE_ X-MS-Office365-Filtering-Correlation-Id: 37f22048-1462-424b-3d9d-08ddcb22f07b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EqO0lRWQPv6YyUOdd0tMk2RuRMum5aK5+LM5+eTfy4DVxaNm/etcGzRFKIHB?= =?us-ascii?Q?7m/I0bchneF/PfIZVZueNKjdjRS9i/2NzEF6mIOLQx3n4uebTlg3lEoAABDM?= =?us-ascii?Q?EwoQEHvk/laNCd5hZQAliUV+oPuDpllmwfJG6fu8G+8GdVetylVhDrFBiZaz?= =?us-ascii?Q?96aKqo7iNgaXKasEqK+smxKcEmGcT0uT90jqJn09NANznG2wbjzEF8K1N96R?= =?us-ascii?Q?O/oeQq9hE9M7BxqhiNfHugsSIxXjMLHTHWZiMbLMOjxv3PXXfuhsSu3YdMD/?= =?us-ascii?Q?kjGt3ODpyq7v3+0cQraap+DG6WoIz9HahjHmHeTxIYT/rZEUk1lGVQVZLKkv?= =?us-ascii?Q?qbOMb5Gk+wgfai03lmrdAx0RmFrS+4tSo2l8tWV0Q/3IbIdjXNaTcvq/YyDI?= =?us-ascii?Q?PK4nfWXdiwVt3xHIw3v9o1+cp3CGABIeEqJzNXyjP08NxVIVmxLcIsfv17dq?= =?us-ascii?Q?nFpPE5sw/VjWPHEHVAu+V0gL9saXhDfSTm4mmCBENVlxAY/5xc2X5RFaspFo?= =?us-ascii?Q?+PEMhOcF8E5jE/MbXSmkgCBiLJiQcAkGojboL3DT/UegyY9JT/WhujZLhJ4p?= =?us-ascii?Q?DkJU9sq3/ahIpPQKHbQrgxEzk82vVpF5r1gHw9TK3UqwF+vY0qWFLtoef4nK?= =?us-ascii?Q?sopNmq1F6E0A66R55hHV+urwZdaTnP8BRtS0eyc5ZlApQNtNtGYQA7g0J8+n?= =?us-ascii?Q?EsDh/ZBUXCjsS66Nxsv3BwNW7xpqmtkT5p0YYMmyfHCn3lxmvYEBoRZNQN6U?= =?us-ascii?Q?V4QwgZ6c+8ubLJ64yM6u4Q9+oyBK22JtAbSeBPUnnaMNSNACOGDqnSsdtu6Y?= =?us-ascii?Q?Zn43D4y4y7t5NBiTNZshn5HnaMIUUgQn5uYrBbSKKqSZmEHMywHG6pG3jHuZ?= =?us-ascii?Q?KFafxjZksOaNVgRp48bA91Sp1Ibn1KiJoxHVECUS4U7kLjsajVTVhmMDoFfn?= =?us-ascii?Q?WzjYNG1y4UlHLfK+daG+0tGDn9GPcTem1Y+L9nTk/UE1413FAfYCYitmqnWO?= =?us-ascii?Q?tKRqCzZKdbFIa1TNyAFXWGdVPCrQ+RQKgZQQRTWpUQEFt/id0hU9kRmpRKF7?= =?us-ascii?Q?dpvs6R9Skjv7OMTiFwJEyInSpXuJKkerNaTLFNgjY2SLveKRU/y62ebn+aD4?= =?us-ascii?Q?u6u+HGZaSt80jGeOfvHg64EyWxzsaBBlTo67skauO/Us1DwmktXwwxRVzcWp?= =?us-ascii?Q?ziNuJbhlwlTMDGz4OPc0ZYsG981OjJp/lG5dCHLnJuLth6TDJRpxM/LS2Q9H?= =?us-ascii?Q?TFFoVvf/432XRo0apgebvpASJ32LX+YanP06BcNwLmaaK5jq4Mj2kuAi0KCg?= =?us-ascii?Q?YesC6XAIHak9qXv09LlWB8A3+BAmXW7ywMRlzzpeV5ipuBVVCGLrP4UN+XK9?= =?us-ascii?Q?pdZGmARpRBfMM36Kc5jTsFgnliiP+c1NDF4+09x0vHKoyo89jfdgSURMrzJ9?= =?us-ascii?Q?hb+dmZ42ckZMbDe9DkosCGAFwj3DJVg8/bKc+fdDLsbCK1Aud3FKrF9NtRNv?= =?us-ascii?Q?7+zWi/3toceH9N4UZpBPvxMRyi8jcy8gZm+a?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:27.9979 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37f22048-1462-424b-3d9d-08ddcb22f07b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029928.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7151 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410544998116600 Content-Type: text/plain; charset="utf-8" Write the associated event channel into the xenstore page so xenstored can read it. xenstored can map the grant by the reserved grant table entry, and then read out the event channel and bind it. This eliminates the need for an additional mechanism to discover the event channel. Signed-off-by: Jason Andryuk --- This is ARM-only for the time being. A common function to write to guest physical address will be needed. --- xen/common/device-tree/dom0less-build.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/common/device-tree/dom0less-build.c b/xen/common/device-tr= ee/dom0less-build.c index 6bb038111d..a96089d9bb 100644 --- a/xen/common/device-tree/dom0less-build.c +++ b/xen/common/device-tree/dom0less-build.c @@ -26,6 +26,7 @@ #include #include =20 +#include #include =20 #include @@ -120,8 +121,14 @@ static void __init initialize_domU_xenstore(void) =20 if ( gfn !=3D XENSTORE_PFN_LATE_ALLOC && IS_ENABLED(CONFIG_GRANT_T= ABLE) ) { + evtchn_port_t port =3D d->arch.hvm.params[HVM_PARAM_STORE_EVTC= HN]; + paddr_t evtchn_gaddr =3D gfn_to_gaddr(_gfn(gfn)) + + offsetof(struct xenstore_domain_interface, evtchn_port); + ASSERT(gfn < UINT32_MAX); gnttab_seed_entry(d, GNTTAB_RESERVED_XENSTORE, xs_domid, gfn); + access_guest_memory_by_gpa(d, evtchn_gaddr, &port, sizeof(port= ), + true /* is_write */); } } } --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410539; cv=pass; d=zohomail.com; s=zohoarc; b=BIHnA3PGdc0X6xeOa+0kCSmXHK7ShfEAru9w2zHSrVOO6GKNCJhd8wy7exQePEEMH10p4kV7CuXfBvcH6I1t/nQ2IRb1eNO+RBv6gVts4bCNcBZ1osHR978LM4LaAmkjt4ZVCEAw5cgyZ2CdHMRGOyGQe13MD7cQ7MGYdY9Ga7c= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410539; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Nvm7hSgNOA3RlYxZdittdf56SFkDqdFCtu34s3PU7g0=; b=VbcLmEaO6EOk9kN3uE/aQ/bfHHGXXoVG5Yt/UamWd60OEShcRGJI3sUm10OuwM6BC8WyRzUVg73+PLeimjL+6NKnOD8n/vMaH+0zhkArs4kVkw7M8F9GI9Ym1dmegYbyQKg0ZBNXQatoYmKZwTQB0wFx+EHS6ZyrZCcaJOXNN7s= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 175341053919246.14983491751855; Thu, 24 Jul 2025 19:28:59 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056832.1424871 (Exim 4.92) (envelope-from ) id 1uf8An-0001u4-VD; Fri, 25 Jul 2025 02:28:37 +0000 Received: by outflank-mailman (output) from mailman id 1056832.1424871; Fri, 25 Jul 2025 02:28:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8An-0001tr-S5; Fri, 25 Jul 2025 02:28:37 +0000 Received: by outflank-mailman (input) for mailman id 1056832; Fri, 25 Jul 2025 02:28:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Al-0000gR-T9 for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:35 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20619.outbound.protection.outlook.com [2a01:111:f403:2414::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f9535fd-68ff-11f0-a31e-13f23c93f187; Fri, 25 Jul 2025 04:28:34 +0200 (CEST) Received: from BL1P223CA0007.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::12) by SA0PR12MB4413.namprd12.prod.outlook.com (2603:10b6:806:9e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.29; Fri, 25 Jul 2025 02:28:30 +0000 Received: from BL02EPF0002992E.namprd02.prod.outlook.com (2603:10b6:208:2c4:cafe::d6) by BL1P223CA0007.outlook.office365.com (2603:10b6:208:2c4::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.21 via Frontend Transport; Fri, 25 Jul 2025 02:28:29 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0002992E.mail.protection.outlook.com (10.167.249.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:29 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:28 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:28 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:28 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f9535fd-68ff-11f0-a31e-13f23c93f187 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y1Tw+DarVDWINqQDZpvie1Ve+DhLw2uBVGOvNmXaBbC6j4P7EIo0+bGWhhZa+m7LxhrnuC7Xe/irm0wxGNWYGJwifuOt+YZKPQsiR0j9UVcmBKVYJQB/6xMmWqGg7M3iKZMxxrNHLsaQGNnkgfF6zJ2Xa9Xrk78bi/rsW7SfIKd28eBn/YeVUShaVwjPZm2TthXgpS+U6abegvvpqL8Uczu2LtIV0wx/UpjwiUPT41+YnFHPjTRj05pDy2qas8nyE/cRal75y8XKW47ukpCjAZarIqc/PhhI4OoWjWgKfS1RL8TMGd/RS9HbGnE6b3oSzx6WRRE160pnPph5SbydkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nvm7hSgNOA3RlYxZdittdf56SFkDqdFCtu34s3PU7g0=; b=vEgKyOA46hVP1spoXdu+TKg7Lu9zNdNs1XVToWaYID8YF1A3yXYIDLybQ2ZbwU5yRJKdY5qD1yV+4ferzfmlmxUBkbPkbX/GW0eXw8EdCMgA829tKwnNuveR+dM6ESI3iEcqheh4Hvkq9aDCcUtEvDLQj1hEWG/7Adr4NU0eg8YLLSaNcZCuv1FM/lMS2Y2qiNwnnCCRSlIrTZDKzc8qzZHkmFxKq4YsHa4Z/+655sUgBQSkmdyRfT1NDRogsZ7hmslF1ux1sgi+KWr59F3vnV7gmg1zLVfToE3afUlbbbYb6857Hu4dxe0bwAQbvflO1UAdFgj2prNqt1wGukk94g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nvm7hSgNOA3RlYxZdittdf56SFkDqdFCtu34s3PU7g0=; b=YHxo3HIeAxyaHemY0z//bwI9e0MQp2X1phk5oBtm43Jai1Zqa35AhXuCVoGzqvF2tQ7IbMBzj7rvS3WZJERWawP4MSE/boeBPtHHvl55Y14psmuFUOo2osZZXhAhA+GaDckFKBF7aUM5206Rlf1smdsjhR9KTA9y0C4l4ofDzNM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH v4 05/12] tools/xenstored: Read event channel from xenstored page Date: Thu, 24 Jul 2025 22:28:05 -0400 Message-ID: <20250725022812.466897-6-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992E:EE_|SA0PR12MB4413:EE_ X-MS-Office365-Filtering-Correlation-Id: 21219bde-2800-4bf6-d591-08ddcb22f118 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kl1mLGnSN3k5CmXz7Sp2d6tdJUMkbY9Zl+sHf3X5VmgHxGS4eQxX+2QZ4Xqq?= =?us-ascii?Q?R7/fQa5axAb8m5QV5zaIOv338mzmV25tlOeGWMTqRMs7ic+wlgnoA/ptOJd+?= =?us-ascii?Q?LoCVNmfMrfNwdqOWMewM/2qY7vfUjCEveDHqnzLq+ECq2FhyDNrIG+u/AKtm?= =?us-ascii?Q?GE9iRnqnSygxL7169ICSYxGZCp1kMUnBDc0Q5ljFi7Y1hfkM7yoVDJZvbRWp?= =?us-ascii?Q?NbizrbGj519eea1tcm+MebkiwjCMsOkZgVNbNs/2N72JpqjnOjYrwMrjZxiQ?= =?us-ascii?Q?uPymXVDUjSUBBBAXWiBh8g0XfzdB7s0CKlve7vN4Is3rTH3tw/TRJ5X412Xd?= =?us-ascii?Q?R6w+1ljs6wUiBD+UC4G3YbiGdD5CMzaEjvSmDJeZLuNM33qphI5UllVXyxWf?= =?us-ascii?Q?acAEKErYJ8i/UaaEDXBIDhxdAhSmzG3RKIM3lAfZQyRONRsyLwy1WlvuRyFd?= =?us-ascii?Q?c1ywF4JP85ZiRelnonshoCzp4aoQOK/8/08BwHE3BdGAtawQVwcOoAC1x8n5?= =?us-ascii?Q?YMD6ss07LYwfYSwW7EjfHuJrZvKVK1H3gB91+9jtEqKv1Tw6vAJrhnOmCIpN?= =?us-ascii?Q?cdKftLyEGD34LWpJeLXRobUzMadzEcMAbeBW+uKuG/upjaKorV+mGK00melq?= =?us-ascii?Q?0I06zitTbAv+tVzZ6psAqgnDK41skgN2C7ISOdw4F2YsSPuc/9pr09r8iHr2?= =?us-ascii?Q?3GoIn4+aQgD0AeREZNiuVHYLMjdMCmMA668id7yt8zEXE13KLsuQ5qGZmr2W?= =?us-ascii?Q?gSZytHXKtRYkB/OVBMRaGkHx+clIsXetsu0fIxpC6J14fGbCYSnNbNiNQZOJ?= =?us-ascii?Q?EKgDDQxCdFliV0+Lg0H2/cS1pnOM/ntAMXP+JSVZZsVMDl15diKiJtJ6QVSE?= =?us-ascii?Q?Xe1/lcvEoLxU+fyH7ytNgWXp2IV7DvGtv8R/9O7fakz/2z55w+0YvtF3zpgA?= =?us-ascii?Q?SHgsp8UgXzdMGulQRBCjeYLHSi6IAhQERO6LUtsl7NwbsSQX916LzilMGJQo?= =?us-ascii?Q?7TVOucZdp43ku2lzHKOwmKK4VYW4AZmr86ihU+f+SNfckpAHocg2RtfbYUsn?= =?us-ascii?Q?lUoFA/BxKomNT/InD4oFZf1SxBV6qsWrVtr/ZZ7c6N+VRMDqZgB+PbiqsA3Q?= =?us-ascii?Q?DravCryoEJ83Os4P6IdyFBqRQ+q+aSQAJY2ody0ueipXDf2lS36PSMrbvULO?= =?us-ascii?Q?OdR6+u2OdVhhdg8/tK0//O9T+BPEJoF5HsBNWVaIjpbkEYnNJPQpXY/7b+CD?= =?us-ascii?Q?xFdy08wUPiN5IKidMqPDvJC4HE9VyK0JbPgaOUwLJktCxQ4QyDB5+M7XbthB?= =?us-ascii?Q?I+ickl6lNV5B+7qsOpfCoaATFgQRaGBViQ+K9q8wsFZBFf6F5idaClFdmAJm?= =?us-ascii?Q?EzSJYR1EDQvssTRir3hPNh/VGiPwFEO4ExIOsXuCi0ttWtx4n4VVXSacT0GS?= =?us-ascii?Q?stIoqinH/X/Vk4iOBCA7jpdP6k88e6ynIpKxU2ID86cPWV2lQZ35nOn/2CmP?= =?us-ascii?Q?7/ofHO5hhDzhUs6qPn4SqJbIIdXrR37wGnG1?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:29.0317 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21219bde-2800-4bf6-d591-08ddcb22f118 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4413 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410540806116600 Content-Type: text/plain; charset="utf-8" Make introduce_domain() use an event channel from the the xenstore page. It is only used if non-zero. Otherwise the passed in event channel port is used. The is useful for a xenstored stubdom to configure domains autonomously. Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross --- v2: Remove iface_port variable. --- tools/xenstored/domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index f119d714ac..1241f8c73e 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1024,6 +1024,10 @@ static struct domain *introduce_domain(const void *c= tx, interface =3D map_interface(domid); if (!interface && !restore) return NULL; + + if (interface->evtchn_port) + port =3D interface->evtchn_port; + if (new_domain(domain, port, restore)) { rc =3D errno; if (interface) --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410543; cv=pass; d=zohomail.com; s=zohoarc; b=OMkYoeFl8uNpbRBfYWKzAStNw6hhT/wgN4VD0Sz6OhB+zNHysXpeWf74JCwpp1DU/RlF7+ntZBJfMBaKluvjnXtbgRc/gkD6QhRMeceMouYo5ygAkT0JfeL9O7KfHjxEIKeBgf3tWzMRixyzomTUW6Zluzwg9cc80Kd0jz5MIuo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410543; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sGYc+CzgLIdlHzSBks2AkycShqESzRnLK23aeY0dc18=; b=PlRflFPhHjaHxhQcMf7qkq6aBZK5r5feFYbIK0GFe0ghekLwL7sf8zYnT3lezSZgsJ2HuCXPUSLtAMbOV0ovUeaAqaIGqSGktp/AuGRhjmK81z+RQmHTTxIsdrVAvq/5hEiX/DUMeyomknXmSvu67D1pUbEjC7bQ7SwzwsYsnvE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17534105438689.194487822641577; Thu, 24 Jul 2025 19:29:03 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056833.1424876 (Exim 4.92) (envelope-from ) id 1uf8Ao-0001xE-AG; Fri, 25 Jul 2025 02:28:38 +0000 Received: by outflank-mailman (output) from mailman id 1056833.1424876; Fri, 25 Jul 2025 02:28:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Ao-0001wT-4o; Fri, 25 Jul 2025 02:28:38 +0000 Received: by outflank-mailman (input) for mailman id 1056833; Fri, 25 Jul 2025 02:28:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Am-0000gX-RW for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:36 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on20620.outbound.protection.outlook.com [2a01:111:f403:240a::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10737a31-68ff-11f0-b895-0df219b8e170; Fri, 25 Jul 2025 04:28:35 +0200 (CEST) Received: from BL1P223CA0013.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::18) by DS4PR12MB9818.namprd12.prod.outlook.com (2603:10b6:8:2a9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.22; Fri, 25 Jul 2025 02:28:30 +0000 Received: from BL02EPF0002992E.namprd02.prod.outlook.com (2603:10b6:208:2c4:cafe::93) by BL1P223CA0013.outlook.office365.com (2603:10b6:208:2c4::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.22 via Frontend Transport; Fri, 25 Jul 2025 02:28:30 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0002992E.mail.protection.outlook.com (10.167.249.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:30 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:30 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:29 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:29 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10737a31-68ff-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JcqYwpQ+nQt4RD56CJeq0KPcaPrtOUUkWMEBd+BDt+imRpcBuQijHfKgbuDt/c2rMwqKotR3IVfLueoDgcmS8RuPYk+4Fwq51HBS12KZ3NvtVEOXXTBVcd2grNzlgzWeq1c+Pug/GePvyPotLN/UyLfyxtJozMSn8bDRDMuBY4zJrTNKbZi2axIxLl+LPWI3LlgLhdiLKT2eAuv005igJZXaXJMIkmjGBGMRdAOZzBJdKnyeRo/HIdxwMkMC5jsEMa9/FGVx28d8yJmP/UDYQ+eEAf0TwoLUbSk/nKSqEDkE2Hvoc1Aa+nM+WQ1S8BKVO9LT6a121b3bKZRh15DR6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sGYc+CzgLIdlHzSBks2AkycShqESzRnLK23aeY0dc18=; b=Edhb32DHO9GhCtYRNNtirvLJJEJSBrvsj7pn2zaAv2fqHXDc6qRVLHR41aubBZxp2v2K2XHKGtjTzwjD3cgkBjHxZaWEyzxfCZGlu+27LLXrDBOEBsSzgRKHOb8kGKP2duSavZd7OIejiRqWPktVx4qiF4LAkj/EwMcsVjO/UggUZU4QwBdPN0NGzo83kOXxCtuCutArU9AfGarY4YxN7K+iv3tbNiMF+6w03d+8r5mhLerMFUm/5nBnFiilxbIveZ2pfLNRAsRDvwU0epUHomwEM4scQ1YYKnLpws+dW0XQgogWdLwLDCCUAtaqL/ExrA/6CCydk5eYRt9QjBvgdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGYc+CzgLIdlHzSBks2AkycShqESzRnLK23aeY0dc18=; b=rWfKgQX8WlO7QoOk2aFnPyAk9H9IWS9dVAXAJZ9zhaNzLP+NpXZhJK3WzhR0Lzpwsi1YCftSHpV0g+b9g/f7hA4jAfdnhAxTibFVyOUUbEoQNblL9njYVBYMM91FYo1UarFVkwVMTzpgoGpThY+e27ogMV2Joh3xOJ6GExD2b3s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH v4 06/12] tools/xenstored: Add get_domain_evtchn() to find evtchn Date: Thu, 24 Jul 2025 22:28:06 -0400 Message-ID: <20250725022812.466897-7-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992E:EE_|DS4PR12MB9818:EE_ X-MS-Office365-Filtering-Correlation-Id: f8735f0c-b543-4e95-6661-08ddcb22f22a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?X83vXQJ+xwEScIVs74IgxPRFaYX6vzkaWYrnDwsg7eKxmhiZJl6OkgfYSysy?= =?us-ascii?Q?7JZcaNUhtFOBgcEIT8R5Ah9FaqD6r+d+UgMUkZE8EfTxkVAK/mcAw3jcX+f6?= =?us-ascii?Q?oiRubXcWHnd2zsP+5jjZ4lcqG2DAX51vVgMtcjHTSrDG+c66UM2wCvhSq48R?= =?us-ascii?Q?LCi/tiA5d2gDstb8LpXdqkK84jF7Z8ECvHpBc/nMwEJY1ZtGXAuIWfZj/Tk9?= =?us-ascii?Q?g4WuisGCgEt3yl2ieHv6iiyGKj+9E7WzrQG//P/PXdmqkUuNaViE0y8ZyHUd?= =?us-ascii?Q?JRCUrwQbO6zyFKTrVDPnaS3kDvWzM+rMpauwnfTGJW2NjqrrqIepyntrwS5Q?= =?us-ascii?Q?HYYBNh+Ziy6+psbj8MCJmtkBsO4TeMK31Tj9DRnGpWh17UQQHzZkAE/AVP+3?= =?us-ascii?Q?dk1zB+C2q6oIfdX+btsYjVeHJkopTFPIkibgFoKY+2lhbj2GP2STdMxlcETS?= =?us-ascii?Q?cJgx18wM+nDbY2tNXhL+j/FdlayliccuXujnXPA3gK0/UEmwk4HGMX11xTsE?= =?us-ascii?Q?Bw9GdUYU6x+PWzCISLg4I5FzGzeSdmuI0xV97PHmS3ZhiKUccEls2YUTC3fx?= =?us-ascii?Q?huczVN+uskknr4sbNdGA05MLyOyz5xBAMES8T4pPc+6IkXmhQMA3cz/bRGrw?= =?us-ascii?Q?r1IMcCWcKIy4KXhMFHVMl4u5YIn+R/gDwVcSQxJzs+bXqxLNayPfw/MlgjAE?= =?us-ascii?Q?OW+jge9DLXgWYnpQjGd8owC2m5NnfrtIlwkBi6FgYTvl5e7lhsDSNuXINeHp?= =?us-ascii?Q?AM/cONtab0NGWuKknjrqVvOTPtMVIEF08CxVosZ7ffJjbaCO2PsyYMdxE0/M?= =?us-ascii?Q?1MbjWdVSUWFQc+pzdUjbwDIEK2B8xidlHQlx3vr/odiDKC4ANVWneKMsrdWH?= =?us-ascii?Q?12vkP/si2m1ndakAzRvgFVy8EPKsZWx4KvCbJ8tPbu8hArvWVW9C04qRRK8z?= =?us-ascii?Q?CrpHc6FeNLyjDBlgWGvIbY/bwJInu63+EfhJH/LuAV5jj8UnW4Osm+2lT2D3?= =?us-ascii?Q?W+xN7o5cvAN88fvh896u8OUuaE70WyiMr6VgMhyB0wuz+JR2bej6N5U+qV2K?= =?us-ascii?Q?8S/RwjaMGY22/rgmEKAM6qBN+j/oxQbzfSq3sWJ0/5jLbih8asBUjiJPjrQi?= =?us-ascii?Q?u05EAO9VytMAwjzC+JNwluGwqlq7AjLNQSu8ebifeftt6EgoT2eN8vgTSM4s?= =?us-ascii?Q?oxiD2g4PE/MA/uAhJSly2Yt/EGpTftxx4c2Me9Lu1oghsr/qWNaf1rLN2W4m?= =?us-ascii?Q?sqiVZY1AX9xcrMR4HXHb3QlF9m74KyYqI7ZNGBY88cORLoHQLuAfsycxASeZ?= =?us-ascii?Q?1FFYu1Pml/IGRtE7TIcr3EgJaMRu4/z8Ye5wNqTubLYgwET9AkW4nPZLk5wV?= =?us-ascii?Q?lBQ+FDWxMgdthuFS4G3WKU4tq4+Lwq2hPQPixOsJ2tKknKFIDh6oPUwqoRge?= =?us-ascii?Q?U9rYHqoKAkyL6oKEte/l8m7yf4fpjbu1KNcz7IwRUVbC+7BBnj78JQ/hXR0x?= =?us-ascii?Q?NHTccIKxZpKkeHg/MtuP1Vtmphiwyb0kJf2i?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:30.8231 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8735f0c-b543-4e95-6661-08ddcb22f22a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR12MB9818 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410545041116600 Content-Type: text/plain; charset="utf-8" Add a helper to lookup the event channel for a domid. This hides some of the differences between dom0 and stubdom xenstored. It highlights the different meanings between get_xenbus_evtchn() in a stubdom, where it looks up dom0's event channel, and dom0, where it looks up the local event channel. The default return 0 will be fine as any other auto-introduced domain will needs the event channel populated in the grant. Signed-off-by: Jason Andryuk --- tools/xenstored/domain.c | 38 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index 1241f8c73e..1c52254ba8 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1251,12 +1251,41 @@ const char *get_implicit_path(const struct connecti= on *conn) return conn->domain->path; } =20 +/* + * dom0 xenstored (posix.c) uses get_xenbus_evtchn() to lookup with + * XENSTORED_PORT_DEV. + * + * minios stubdom uses get_xenbus_evtchn() to look up dom0's event channel + * from the command line (--event). The stubdom's own event channel is + * returned directly. + * + * Any other existing domains from dom0less/Hyperlaunch will have + * the event channel in the xenstore page, so lookup here isn't necessary. + * --event would not be set, so it would default to 0. + */ +evtchn_port_t get_domain_evtchn(domid_t domid) +{ +#ifdef __MINIOS__ + if (domid =3D=3D stub_domid) { + return xenbus_evtchn; + } else if (domid =3D=3D priv_domid) { + return get_xenbus_evtchn(); + } +#else + if (domid =3D=3D xenbus_master_domid()) { + return get_xenbus_evtchn(); + } +#endif + + return 0; +} + void dom0_init(void) { evtchn_port_t port; struct domain *dom0; =20 - port =3D get_xenbus_evtchn(); + port =3D get_domain_evtchn(xenbus_master_domid()); if (port =3D=3D -1) barf_perror("Failed to initialize dom0 port"); =20 @@ -1271,11 +1300,16 @@ void stubdom_init(void) { #ifdef __MINIOS__ struct domain *stubdom; + evtchn_port_t port; =20 if (stub_domid < 0) return; =20 - stubdom =3D introduce_domain(NULL, stub_domid, xenbus_evtchn, false); + port =3D get_domain_evtchn(stub_domid); + if (port =3D=3D -1) + barf_perror("Failed to initialize dom0 port"); + + stubdom =3D introduce_domain(NULL, stub_domid, port, false); if (!stubdom) barf_perror("Failed to initialize stubdom"); =20 --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410655; cv=pass; d=zohomail.com; s=zohoarc; b=SDOEl4A2Ht8Rarlb1PL85ovaFGhr4zZyZyWXN6sT7h+J8r6zA569TFL7U0Iq8+j+syENPeQSBRBhiW4RA+WPlx14Nd/JQsZ7NrgrfNRJHiIuIw/mcx5lifPCCAL9gpL2MCWetpgYTkYNTqZRQRo0QUdAqttX2/olAwT7Dl3Gjls= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410655; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2QNNUmmRfhx/RPaCto+6O8xWC7p6XSqNEoTe97aqWYM=; b=jHNU1ehGJ/H85159myzFNY6ICapBnraLAMRFDWMidkcxmBVfAoyIWMX9vHgMC+GlkY/mKv+xZ/VpEisb/xr0idt+YVHY9TLX7YetesprPyHL5HULSzWtgRj7S9gnPCt48EtG7e+/La+/Ve3dXHDVlxoNPTBs6ez46i9gkUT31LE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753410655173661.4667085220127; Thu, 24 Jul 2025 19:30:55 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056866.1424896 (Exim 4.92) (envelope-from ) id 1uf8Cq-0005hW-5f; Fri, 25 Jul 2025 02:30:44 +0000 Received: by outflank-mailman (output) from mailman id 1056866.1424896; Fri, 25 Jul 2025 02:30:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Cp-0005hF-UD; Fri, 25 Jul 2025 02:30:43 +0000 Received: by outflank-mailman (input) for mailman id 1056866; Fri, 25 Jul 2025 02:30:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Ao-0000gX-KV for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:38 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20626.outbound.protection.outlook.com [2a01:111:f403:2418::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1112f7ec-68ff-11f0-b895-0df219b8e170; Fri, 25 Jul 2025 04:28:37 +0200 (CEST) Received: from BN9PR03CA0607.namprd03.prod.outlook.com (2603:10b6:408:106::12) by SA1PR12MB9516.namprd12.prod.outlook.com (2603:10b6:806:45b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Fri, 25 Jul 2025 02:28:32 +0000 Received: from BL02EPF0002992D.namprd02.prod.outlook.com (2603:10b6:408:106:cafe::fd) by BN9PR03CA0607.outlook.office365.com (2603:10b6:408:106::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.21 via Frontend Transport; Fri, 25 Jul 2025 02:28:32 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0002992D.mail.protection.outlook.com (10.167.249.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:31 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:31 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:31 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:30 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1112f7ec-68ff-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UOXPDk72ANfvIPGHJfGMq+ylzc98siDphFG9s+ZnpL7KPcXtuESZkm9p7AdQl1mcymCahIjftnkV+khnbDdTxqLfFvnfrcTjMrwq5pHJugpp1Vu8He/dLOber5uMqd4MqBQta3UN8Za0q35KP1iY3MrjZ1M4oDnjAGncdY96t7oumbUPobTSgB7+y6WX2/JGJLJSSoOg5VVBy85dLSkXiH0W5+z2sd5R2npCzuE8vybQmCgzy7kDLtlZ4D9zL1cOMYn/zonF1mrDGI0ul3FqgjuwJO6MEqyFwetWej/6lKRp/AV30X0ISJnslSGJI622uIJMlUT2XMEw65H54wBnrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2QNNUmmRfhx/RPaCto+6O8xWC7p6XSqNEoTe97aqWYM=; b=TY2vnEAbE5yk5agLLvMwNz3ZwdxE7Q1LpULSMdZJUMJ9gk6LXBQvc2fHO7yTsZLB1MxhxIUdKVrJsc3SrFuogVU6CG3ge/XQdYM7ui98ynhlT7MQWx8G1LrXbE2Ex5ezmWxWsYdR1EO6AiIAa2ikfrjrByXb9Lr8BS9LfUSrA3U6R+S3BXtkVGl/g4Yq71TUnLi28B26npTPzwMm06RNiNJNGVVF9I+kDf4y3is59L71NW4T/urRwGnm0+kPsRmQKxq1mruuYpxJtFw5ssFPOTz0tcJi8DPYwQDgqWBCuQvHlt9u4rPtEkdIZ9nUWeHjYDR0FfTnt3zwPPUbK1mgqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2QNNUmmRfhx/RPaCto+6O8xWC7p6XSqNEoTe97aqWYM=; b=P9kdOI5EcI2u+v1Xxdi9+H5JdHcwwpJzI0KWr9AjHjIngkFp+/6Q8z4xFeonMK8t3PLSnb4BI+vYPjgMlNkoQ5dmO9vggBVFoo/XtlIspsHg3Jc+xQJ61sKEjWIFBHayMhEzqWR/uVb6ql7GxgsQORKSaJdaZa6I1tQS8dX8ASU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH v4 07/12] tools/xenstored: Auto-introduce domains Date: Thu, 24 Jul 2025 22:28:07 -0400 Message-ID: <20250725022812.466897-8-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992D:EE_|SA1PR12MB9516:EE_ X-MS-Office365-Filtering-Correlation-Id: 5da4682e-7dee-4039-2b36-08ddcb22f2c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HA1S54X5vx7I3QOqh7lhknSoU9z5341wmb4m6hze4KBxb2JrGU8v4ahKcB+Z?= =?us-ascii?Q?r2D8oiJCjtRGV46cZkeIeZZVkxrm25EjYt3vxNhMnSyYCvMHJjVvN+aSgFQb?= =?us-ascii?Q?Ja5hxTzrfm2bZuAeWKPHMbkBJrWddtNFnydOIuyWKeJD53TjYWnMOYeUvHe2?= =?us-ascii?Q?bZL62dbLffNwa3ofjtBLsA1qtnlVgWM8rROJ/bw5SrVCDTVGv48ETesjHVZa?= =?us-ascii?Q?AIfm3TwFY0GMOms26mDSUdnCsKNXVVGA45tFfbE6jiFN1hu76bss6lpPGG/6?= =?us-ascii?Q?WC2tRaoQVMjRAL7yOF42i/mj+Dn4ETrBvy/NS+Y0ZOCBJREKM3r6+Qtwnqjp?= =?us-ascii?Q?sCy8iia7B4A0CUVHJ7rsTTrmcLMvVxA4fevWLbTLNQ1yKUVCGHpbwfyd9MnM?= =?us-ascii?Q?nbwA4Hbz0FFKC1ESC0Ziicqel4KrBmggHCvISyoB4rZKbHCXb2pZUvQHJrx9?= =?us-ascii?Q?BafCXbIrbTNZfzxLmNwdGPL9fIZ2XCQ09KVkTL11s3oLuBLx3A5LykLkkXwW?= =?us-ascii?Q?VWigp6/IW+eujnGxS/1YrH110ikBHeJcuNI8+gnxVlKArnsdGz4/7i/MjeXD?= =?us-ascii?Q?J3Bz/GT08fbquFvcnqzW7BSq6W0sQtIXcAiYJlwLkI9L2FQhg1PBjPsozXAs?= =?us-ascii?Q?vpmRCUMyA542v51ADcq/yEjIqNjVVuy4dG16lqwahdUWNZVhwBhIXArE8EDV?= =?us-ascii?Q?Bq8WuvrFJHYire7cGgRfDsFhxTf/nlPkN/zKLVuGefImu4cAssaBJ+zMt0sU?= =?us-ascii?Q?DOI8Z+Hqbtg0y4+pzZBDUJk2fCcnqZtT8LAlqn7LseMuQMOoI7SIy/LIEnnl?= =?us-ascii?Q?+1+6LNnE35HEotbc+gtOhT68CFqJgWwcooGCxON8KG4z5na9GtT/Doi0gxc/?= =?us-ascii?Q?QFHscYCyI1iJwjYfzbn6mX7vNN/qgc3FLy4nt3olkE0ZrI7ev9kHzo+f646B?= =?us-ascii?Q?PtI3p+BfTgTwVT5KrlsmMMNXwQdnX8N4vSlPpuYahmsaPiD8cvhtG+Cws1cS?= =?us-ascii?Q?e7guhZ7OAccDR3+OlUK6B7FEbFkkTXoUJb1rpZcmdFKe8o3uGdK2RGkRDuCh?= =?us-ascii?Q?Z7Vr+IOZTg+AUHvkhjpZT7qgRxN9DuJ3yQJJM1tTN0sk/qJOfNM0bqGXJSXY?= =?us-ascii?Q?i2NeBlWW1aWxfuaH9S2dnvcOmS85+Tab7cJuI+s4f8oIjXDt+kwBdJxN8BWO?= =?us-ascii?Q?s3QfQLwkFXbZfnffyLKHlOjAruN8R0JjhlZh32F+fuNAXSwGVcc7CrYDnmv1?= =?us-ascii?Q?Fr+xh2eXp7Eyx5nVMG7D5it6Cj054wec3Dect59gdOSH835H+eYZKb8bNzXa?= =?us-ascii?Q?HJ7j0TfPjSb+WYH0l8dFOe+BVxDqxvE/TPMernsuUXTQcbE9AyclqVITLEFI?= =?us-ascii?Q?9uIBUlTZDdVOsxhmoCq5lNzwTpRCB+2+fLrDbwV1m5S7j2L3Kc5O6KIveHn4?= =?us-ascii?Q?XhCN1vnjcRgHCutwq1yg+Q4jRZoAy15wytXCl1vV95rZZ19DTsOwUL+ugpt+?= =?us-ascii?Q?/JnLVpguCc+YAKuUXmb2N9MWKLpYVhAxkKSQ?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:31.8261 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5da4682e-7dee-4039-2b36-08ddcb22f2c3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB9516 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410656107116600 Content-Type: text/plain; charset="utf-8" Replace dom0_init() with init_domains() which uses libxenmanage to iterate through all existing domains, storing them in a list. The xenstore domain is introduced first, and then all the other domains are introduced. The xenstore domain needs to be introduced first to setup structures needed for firing watches. dom0_domid is updated with the xenstore domain, since it really indicates the local domain. priv_domid is set to the control domain. This makes it limited to a single domain. These features let xenstore automatically connect any existing domains, which means it doesn't need to be done manually from init-dom0less. For a legacy dom0, the result should be unchanged. For a late xenstore stubdom it should also be the same, but priv_domid would be set automatically to control domain (which default to 0 normally). Always signal the event channel for initial domains. This gets dom0 (a local xenstored domain) to connect. Also always write XENSTORE_CONNECTED since we know we are connected at this point. To support ARM dom0less domains with xen,enhanced =3D "no-xenstore" a failed introduce_domain() becomes non-fatal. Normally, HVM_PARAM_STORE_EVTHCN is used to identify . Signed-off-by: Jason Andryuk --- I noticed domain_conn_reset() isn't called for the stubdom, so I added the ifdef to special case it. I haven't tested with a stubdom yet, and I wanted to be conservative. Ideally it would be dropped - the issue would be if the stubdom queues requests before xenstore is in service. --- tools/xenstored/core.c | 2 +- tools/xenstored/domain.c | 83 ++++++++++++++++++++++++++++------------ tools/xenstored/domain.h | 2 +- 3 files changed, 61 insertions(+), 26 deletions(-) diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c index 37e4dd5a5b..c2f8d20211 100644 --- a/tools/xenstored/core.c +++ b/tools/xenstored/core.c @@ -2757,7 +2757,7 @@ int main(int argc, char *argv[]) /* Listen to hypervisor. */ if (!live_update) { domain_init(-1); - dom0_init(); + init_domains(); } =20 /* redirect to /dev/null now we're ready to accept connections */ diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index 1c52254ba8..e9e45ed8e8 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1280,41 +1280,76 @@ evtchn_port_t get_domain_evtchn(domid_t domid) return 0; } =20 -void dom0_init(void) +void init_domains(void) { - evtchn_port_t port; - struct domain *dom0; + unsigned int *domids =3D NULL; + unsigned int nr_domids =3D 0; + unsigned int domid; + unsigned int state; + unsigned int caps; + uint64_t unique_id; + int introduce_count =3D 0; + + while (!xenmanage_poll_changed_domain(xm_handle, &domid, &state, &caps, + &unique_id)) { + nr_domids++; + domids =3D realloc(domids, nr_domids * sizeof(*domids)); + if (!domids) + barf_perror("Failed to reallocate domids"); + + domids[nr_domids - 1] =3D domid; + + if (caps & XENMANAGE_GETDOMSTATE_CAP_XENSTORE) { + memmove(&domids[1], domids, (nr_domids - 1) * sizeof(*domids)); + /* + * Local domid must be first to setup structures for + * firing the special watches. + */ + domids[0] =3D domid; + dom0_domid =3D domid; + } =20 - port =3D get_domain_evtchn(xenbus_master_domid()); - if (port =3D=3D -1) - barf_perror("Failed to initialize dom0 port"); + if (caps & XENMANAGE_GETDOMSTATE_CAP_CONTROL) + priv_domid =3D domid; + } =20 - dom0 =3D introduce_domain(NULL, xenbus_master_domid(), port, false); - if (!dom0) - barf_perror("Failed to initialize dom0"); + for (unsigned int i =3D 0; i < nr_domids; i++) { + evtchn_port_t port; + struct domain *domain; + domid =3D domids[i]; =20 - xenevtchn_notify(xce_handle, dom0->port); -} + port =3D get_domain_evtchn(domid); + if (port =3D=3D -1) + barf_perror("Failed to initialize dom%u port", domid); + + domain =3D introduce_domain(NULL, domid, port, false); + if (!domain) { + xprintf("Could not initialize dom%u", domid); + continue; + } + introduce_count++; =20 -void stubdom_init(void) -{ #ifdef __MINIOS__ - struct domain *stubdom; - evtchn_port_t port; + if (domid !=3D stub_domid) +#endif + domain_conn_reset(domain); =20 - if (stub_domid < 0) - return; + if (domain->interface) + domain->interface->connection =3D XENSTORE_CONNECTED; =20 - port =3D get_domain_evtchn(stub_domid); - if (port =3D=3D -1) - barf_perror("Failed to initialize dom0 port"); + /* Notify the domain that xenstore is available */ + xenevtchn_notify(xce_handle, domain->port); + } =20 - stubdom =3D introduce_domain(NULL, stub_domid, port, false); - if (!stubdom) - barf_perror("Failed to initialize stubdom"); + free(domids); =20 - xenevtchn_notify(xce_handle, stubdom->port); + if (introduce_count =3D=3D 0) + barf("Did not initialize any domains"); +} =20 +void stubdom_init(void) +{ +#ifdef __MINIOS__ mount_9pfs(); #endif } diff --git a/tools/xenstored/domain.h b/tools/xenstored/domain.h index 844ac11510..6a78f06935 100644 --- a/tools/xenstored/domain.h +++ b/tools/xenstored/domain.h @@ -84,7 +84,7 @@ int do_reset_watches(const void *ctx, struct connection *= conn, =20 void domain_early_init(void); void domain_init(int evtfd); -void dom0_init(void); +void init_domains(void); void stubdom_init(void); void domain_deinit(void); void ignore_connection(struct connection *conn, unsigned int err); --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410661; cv=pass; d=zohomail.com; s=zohoarc; b=KKkjZGeO3eKzPQ4LVtqN3prVfzmkxicwLqZc4yG/TWRYLmRQpvKj6pSFPGN9dDzQs2G5Tb4IeowMEnjARL5f91AucMh48G6kFPdAs/eS+yrDKpJpYgbPg5gk1Zjo0JF39+2LzNU5zXwXB5VGQsbk3y7qmAOFAdpxMS4bmDgF9Go= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410661; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZxtOPcbtCIz2ATDGfljtgRclBt/eYKldV3W5vT0cVdU=; b=STKMCckzsRtQwvpoqXcXSzcxp+w9PXshiCBSZ/JyIUWyMlYWQlvQ7AeY58YhZLTWeUD9esmyV7wrbzcIkdgyyLqmiJDEZYY0Ng8N/1f0FSIaYdUz63aa2iIOz+D8pld99lDQDcO5yn3tpbV6U3RIsUl0fnkG3Jv9NEWtUjE7Vik= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753410661888257.0524589217298; Thu, 24 Jul 2025 19:31:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056884.1424936 (Exim 4.92) (envelope-from ) id 1uf8Cv-0006sO-Dl; Fri, 25 Jul 2025 02:30:49 +0000 Received: by outflank-mailman (output) from mailman id 1056884.1424936; Fri, 25 Jul 2025 02:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Cv-0006rU-5g; Fri, 25 Jul 2025 02:30:49 +0000 Received: by outflank-mailman (input) for mailman id 1056884; Fri, 25 Jul 2025 02:30:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Ap-0000gX-DZ for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:39 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062c.outbound.protection.outlook.com [2a01:111:f403:200a::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 113bd977-68ff-11f0-b895-0df219b8e170; Fri, 25 Jul 2025 04:28:37 +0200 (CEST) Received: from BN9P221CA0004.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::12) by IA0PPFF4B476A86.namprd12.prod.outlook.com (2603:10b6:20f:fc04::bea) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.26; Fri, 25 Jul 2025 02:28:33 +0000 Received: from BL02EPF0002992A.namprd02.prod.outlook.com (2603:10b6:408:10a:cafe::2a) by BN9P221CA0004.outlook.office365.com (2603:10b6:408:10a::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8943.31 via Frontend Transport; Fri, 25 Jul 2025 02:28:33 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0002992A.mail.protection.outlook.com (10.167.249.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:32 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:32 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:32 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:31 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 113bd977-68ff-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QI/oWD/3oMYpsHc05vNTzAOwDOXGCe55KmHShvvHDhTphMHS2Xjv9nci+nPaqM7mPY/+OLs33rEJpY+HE2HqblfCnyfqRsGuWNYFn8THtqjqTlXqbfU6iANP2wwrY9bWg9gf1X4LivHtoPPQLExMTE+vaUnu7N5hHG/UB+fs8FKzntbdYFDAbl+Xc8ttyv+GSPF6H9trUD9lv9UD7XH/WjfZ2FDw+pPcgPNoCLT5BkVRFf1mfO1RmA2gf9yWkiT3PeQN2DqncrlM3l0LAxaPp9TOLqj6KtUxI27cncHNxsoDzDk/W1TD0yb6g0oipj1QAozO1Z64LHn1LQXE/5sJYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZxtOPcbtCIz2ATDGfljtgRclBt/eYKldV3W5vT0cVdU=; b=WH1pXcvzsxj1XGkQg5js7s71ZoQNjxF7kbKu1Mv1i1Zyn/qEW0ZbljpeIofX3lOrQLUepbT7LAnVDmYlhTa1Cg5X1W0V4jJ3GFBX+xRRhRTmd4H4s9303/ldfPv5u/JzlAXW5cA2Mrr39VqsC6UIAqDxq2P8eDLh+06D1zTyWnWTihm1ERnL67NedxcUw3WOw7OjG2wz+Qee+RmXcLSk4XxHSzq8QLgYIOA6D65XT5XBUf5xjZrbrRB48DXh1HC9eI/ahw2xIap6zZKlPePb63WopDrblNLoUjbrWyCkDMLPBq9vVm1aKeQ9G6Km4FwpLf6NMaXbeoV8aes0LRiVLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZxtOPcbtCIz2ATDGfljtgRclBt/eYKldV3W5vT0cVdU=; b=jLQBWzp6YI4wT/54vMm/SoxFV33l2KQW9XTuFNorQpdw85mYF8UPTmOWK5emfjMoEEVYpbMjVIBGIS9NJllXsWugeE6dhgprQobigrgN9mAIXVWzWj80orTR3/yezH+Qcvapqpfyc2AjkXmLtjGmEiksOwKrYJypiTJZA2/CpvU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH v4 08/12] tools/xenstored: Remove stubdom special casing Date: Thu, 24 Jul 2025 22:28:08 -0400 Message-ID: <20250725022812.466897-9-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992A:EE_|IA0PPFF4B476A86:EE_ X-MS-Office365-Filtering-Correlation-Id: 9af7e407-2262-458d-20e0-08ddcb22f372 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HbI9TL8p6/pDrA0nBhMcW/UWX7bXLQ0GCJRp1GqPArF9a8YbvSw6N/Z5RbYc?= =?us-ascii?Q?poZxI85Hnnsx/q/XnE4QKs57FM/1dZTUZQfYmqUCmmRDrDFmijNQh1acFttJ?= =?us-ascii?Q?ZPnlHbOjSLIVYXjUknmvpqI+e7W2817jCtKci4tY0sEIcTL8fBbBsPxJx93+?= =?us-ascii?Q?qaMAhpH3TN1aIO72d0HcvQnOA5vf/nJn+yRX0CXdd5QDhtq0HWAa7IxsD+bj?= =?us-ascii?Q?Ltp4enNz6U941y4CrXbWk+H7dasnGZu/7eTZB+1Tzz0/ETZHfFXJtGs3fy1W?= =?us-ascii?Q?unDwI/wOcvKL97nwRJ803fCl6o7mB5xxTgWtIgLn1afkSV9sJM1XmrcmmBYP?= =?us-ascii?Q?UJwZWXAEa3FttMvhrzcRctjIocoo8ncsCEzc36W2tnzCzBzNu/sGoHVhDrsd?= =?us-ascii?Q?k/LhA1Z/OvGLC2wvoOAzE8+jgj3770LHdcrnZy5UPJarsS589oLGlbUWNSzp?= =?us-ascii?Q?l+ss6SkwdAuZVsCQ8lNyroYn5M0K4Dr/rHKbaR9w4gWR+UGnGE+IABiE2eG/?= =?us-ascii?Q?BU1aD0iMaqAuqQDqRdYcfu8i68+dRTfamDBIkj7+sJkjfOnFmYrjMihaUx5X?= =?us-ascii?Q?AfkI05xP6r+hcBsyaL4WWfq1B71V9Ow9X4mx6cEHfsboSIiQeV/RMJJOpcKr?= =?us-ascii?Q?Ee+S9eh+Qa99z/OoNymY2nRbSA1SR9iJwKxHHJN/+N0aqrbFFPJ/Oi8Ghe9+?= =?us-ascii?Q?req8qDxTQ3DwdnPNFAY76I13JbPw8VKHwxtfKc7Gc2FV28GH+EHR/amEQOzw?= =?us-ascii?Q?ls7MgPiHwo5cD+mCXZv2SHSsoS2ZoNtiwQZZi20gF9n5C05r4jVb6UffX9J5?= =?us-ascii?Q?vW04ArJgbdH8uRNwV+exA9TYRHJUEyY7cUrBB5rTJG35T7FalUWbGNOCdng5?= =?us-ascii?Q?vrOyBmpdqd00OyTY+QtTnwocI9/NZEU/x3KkCa1lfwmw6PH3fQ/K5hMBUc8E?= =?us-ascii?Q?jETtE4l+0HfE42VERVdumCreTranWJwkeXjd3rKDT7a4IsZrEj3Z9m9nQnnh?= =?us-ascii?Q?GF5EEfn0oY7uYCFR1/D8CDcevgaqRA/qafmx+ySMSx4+NzJFEX1fYlKBs1+8?= =?us-ascii?Q?xxFJ0Y5BPcZUUXPw+MQq3nPkRXZezIQvR8oYceFa5ccPWOe2wx+zZWG9Sr/a?= =?us-ascii?Q?42+vM7sQkPnEFc5mGyLMc607aCuu6XREIQh6RdPtrTNyAvDhB8t7aX4D8/nw?= =?us-ascii?Q?G22Pzcel9dlPTODbppNXFL6PNm/3Wz6+COz36yndKBDBHHrKiEdSoM7fS5bZ?= =?us-ascii?Q?ImYst2WgyMIAmcVSgRvRnq6cb+2WD8zP0Llr1QKBasATGDz0gnTRYn+Z4SVG?= =?us-ascii?Q?tu5Rb7Y9ev0/dCSZnPqLWXm6uEtVkrkY/0OMtJoaRUnrqSZBYGdwye9gTbsA?= =?us-ascii?Q?oUva1XeUG7GrfQc9IXa2U+AEbtxxfRqbE3256DG7TbeaxOYUer8OCCXcFhKM?= =?us-ascii?Q?W7985h3S2vbvKRsFW44w+BRAgmu/PZc/UMiwWXs3nkNZjLdG8q8/P9bEsky4?= =?us-ascii?Q?hv7jSeDqjmfDWacUpdmge72vYM5RxCT862/G?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:32.9711 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9af7e407-2262-458d-20e0-08ddcb22f372 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PPFF4B476A86 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410664275116600 Content-Type: text/plain; charset="utf-8" posix.c and minios.c implement the same named functions serving slightly different purposes. For xenbus_map() posix.c maps the local /dev/xen/xsd_kva minios.c maps dom0 via grant and there is open coding for stub_domid in map_interface. Change xenbus_map() to map the local domain's interface. The default grant table mapping is performed otherwise. Signed-off-by: Jason Andryuk --- tools/xenstored/domain.c | 5 ----- tools/xenstored/minios.c | 4 +--- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index e9e45ed8e8..ac4ac72f99 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -506,11 +506,6 @@ static void *map_interface(domid_t domid) if (domid =3D=3D xenbus_master_domid()) return xenbus_map(); =20 -#ifdef __MINIOS__ - if (domid =3D=3D stub_domid) - return xenstore_buf; -#endif - return xengnttab_map_grant_ref(*xgt_handle, domid, GNTTAB_RESERVED_XENSTORE, PROT_READ|PROT_WRITE); diff --git a/tools/xenstored/minios.c b/tools/xenstored/minios.c index a229954cf4..34f655f20a 100644 --- a/tools/xenstored/minios.c +++ b/tools/xenstored/minios.c @@ -48,13 +48,11 @@ evtchn_port_t get_xenbus_evtchn(void) =20 void *xenbus_map(void) { - return xengnttab_map_grant_ref(*xgt_handle, xenbus_master_domid(), - GNTTAB_RESERVED_XENSTORE, PROT_READ|PROT_WRITE); + return xenstore_buf; } =20 void unmap_xenbus(void *interface) { - xengnttab_unmap(*xgt_handle, interface, 1); } =20 void early_init(bool live_update, bool dofork, const char *pidfile) --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410658; cv=pass; d=zohomail.com; s=zohoarc; b=nHOiRtiBaHPjQmxmX19F4tHPRz/AhNxkixGRV9cxGS/hOdBSLAiAtpbCNWK/1sF39YRHgx1BadPKW4V5I2zzEu5jmM9c8Hn5TtXw4AC7gH94jmYECqFj4Cp5EzFZuLeu0smUs0/slrfkpCy8aU2oFnEDYXNv/iVydMKDy9SHjSw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410658; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QlugRIedb5kUb20fgbK5OIj3tsxnkaC/u/n2bSU12Pc=; b=H96nwmISChR+ax3rOhxVoqsGYouKxktYN+qAxzDGxQkImV5JbW580TSjQ10qDXqW0hcCV2y263xS2JBn8IyYKplrUQZrzDReS+/tNPJXeXpwm5HhYBEM7hd7aFTBAdtzgmU+2X9/397FEFqaZcAVWkjnrBJ31Elamo3MbKBjoDM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753410658119829.3699595463102; Thu, 24 Jul 2025 19:30:58 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056863.1424890 (Exim 4.92) (envelope-from ) id 1uf8Cp-0005fU-PK; Fri, 25 Jul 2025 02:30:43 +0000 Received: by outflank-mailman (output) from mailman id 1056863.1424890; Fri, 25 Jul 2025 02:30:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Cp-0005f4-Lz; Fri, 25 Jul 2025 02:30:43 +0000 Received: by outflank-mailman (input) for mailman id 1056863; Fri, 25 Jul 2025 02:30:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Aq-0000gX-SV for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:40 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2062f.outbound.protection.outlook.com [2a01:111:f403:2408::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 11e3694b-68ff-11f0-b895-0df219b8e170; Fri, 25 Jul 2025 04:28:39 +0200 (CEST) Received: from SA9PR13CA0109.namprd13.prod.outlook.com (2603:10b6:806:24::24) by DS7PR12MB9475.namprd12.prod.outlook.com (2603:10b6:8:251::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.22; Fri, 25 Jul 2025 02:28:34 +0000 Received: from SA2PEPF000015CB.namprd03.prod.outlook.com (2603:10b6:806:24:cafe::9f) by SA9PR13CA0109.outlook.office365.com (2603:10b6:806:24::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.6 via Frontend Transport; Fri, 25 Jul 2025 02:28:34 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SA2PEPF000015CB.mail.protection.outlook.com (10.167.241.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:34 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:33 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:33 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:33 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11e3694b-68ff-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PTH05AP4tQb74sN15EEE8/zVz0UKDB4tpZ5YE1fOA0A8XGgUqAVwZlvTDfqFUFmQc5GL5musBhXBIM98uN+D+7kE3SLm1Nv5taVXZN2cR4qt850ImfNrEQKFULGWPM7N5M2QPzs1+JwVk60pasWg/gU9uvsexyTiijJFIfoO3Ownu6cL8YKjJsvTd4TNE0bM1PlTFkFNG/uL2fG3k8H/3Lh2kXSvhrVLEWhsFDM4XUkB+YmN3Z7Ea8RLWyDZPkRe/N5lhRRgyPKR5jPx6AMg1RYFfRejb+U0mBN7eSz6V/+tS/qGrnjt635u8FYqaE84PpeQFRdVT/EOnKZ0A6YSkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QlugRIedb5kUb20fgbK5OIj3tsxnkaC/u/n2bSU12Pc=; b=LZD+vz9Z1H+pwz/cQ2Nsecz1/77WhoDpb1odmfcbvfQnwvfUmWWsP6CeIed2ChhpEoGyiZPKpbnEeUsl7sjOH5jozrIbc3QLWuzy+RiesZwP5NfEEu7xrtURBDVuVc1d+0re5L2H1E5g7JUW6Qr124lAuqJ8HRQkLBP79L62gLYo3sBmFbiMWjSJjygl3wBX030A0XIhBSD0Cy51vFVbewiP6xrAgCbh2tPt/Sw4sDIV5HJtILqNDfxEA3W6c2QvVgjjgp3FOQOIg9jVNPGB/yH9Ys9GFlEM+ou13fa0v2xKvT9Bf+pPy2iS/lfPj3HFmwCcVWvQkYoHcWwkgqtZWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QlugRIedb5kUb20fgbK5OIj3tsxnkaC/u/n2bSU12Pc=; b=V7XulosiiXJfxxk93x9Jjhrb5v8sU+3dftRx9qwB9Curiz5Qdyqp5d/YIQv39uOYv9kA66LBRsBWZJiPpflM8YLKH9SXuBcwW2IsJy4l8ar4ehp6i1YugMqVsZRUNGRuIPPcy5hIw13l6bDig50hN0oSyZ/qL3qDLqnIzjTuWu8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH v4 09/12] tools/xenstored: Use priv_domid for manual nodes and permission Date: Thu, 24 Jul 2025 22:28:09 -0400 Message-ID: <20250725022812.466897-10-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CB:EE_|DS7PR12MB9475:EE_ X-MS-Office365-Filtering-Correlation-Id: cf41198b-5266-4921-f224-08ddcb22f42a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Vj43dZRcyN+6F52LqMK2scNd4Lgz8VvBW/p/Vw/LEi05smkoSkcQaLhAxiOE?= =?us-ascii?Q?CBOoVoToEvpTVi0snp5otJuw9qWZsRnMXWwyI0wx5HBAe5TdbU6h9ALrQXeb?= =?us-ascii?Q?qBpemerDQGE7qD0GcHA8u0pUWAvmBc61X4E2iO+KfvKSBpo+2uXFFzD7ZjAU?= =?us-ascii?Q?hbGSuAlfFf1LVs9wDOdFLRYuNd8PiTmsfu14NGDpBXo/3vGJgWy3rRveGD1v?= =?us-ascii?Q?uFOOLjHysFi+aRPpT/Yh5cVkAMeyvrgeQhluxh4wC+FEItqbjwEamraII65S?= =?us-ascii?Q?b0phZrx/SankR7ZmIPntmeQQ38zMC9XH8iXuXNjaa7mFUgyFtFJfn8aiC5W7?= =?us-ascii?Q?7KDdEoLXge3DNqlh/YJ0tizAi/BvtkAEeqKJ/NvMzSzbeIhpU9wyfe8/v5TT?= =?us-ascii?Q?i809WNBghIm0sC6sbJXd0ZYwQ/XOv3jJGR2Qf1ELnGPrONfVzZ4FJ5JOVViy?= =?us-ascii?Q?kWebKE/uWKLc1ZyUV9QyewMhIjZmwrGEcse0q9y0Sg2Y7ym/rUr8x3nERr8O?= =?us-ascii?Q?Zy4GLzgEy/9KcSS5vfuh0P+3L4P49in2USA35lb0nSwl6FEo/SAEcljRmXFK?= =?us-ascii?Q?xAR2kHtQjN1Pf+Fu8BU6qKEVIkM1sGAVirf7VfqbhC03bJAtHIBiiLumfHPu?= =?us-ascii?Q?2oN1cONNWrKG1EWiZ6ubYS+tNCn32zJ7KEeG2vsqhueux04IkP6n5z6H3d7Z?= =?us-ascii?Q?18BVbEI/HJ6KXRkfn1mUJWaMIgShwEnlbWnsK67IneddPpngYZk7R3gIdYa8?= =?us-ascii?Q?o20i3D7gpE2EVXU6UmbG245yDoy6SMdoUL/yJA+J0C7Lx+BsJ42ibrBhBHQ+?= =?us-ascii?Q?pVc808BZVLWOJ3ebDOGogvTVIHbeBEJj/3oUY4WKIXRa1g6grXVnOqswCGuF?= =?us-ascii?Q?b9uzO9jTnFHEIZhws8/+mdC//bVn1wgM1NXCNQILYV66X3Q0Myo3O2Awx262?= =?us-ascii?Q?e2te22Sfd4tmtHpmxGlOlWXm2Qgab/8pYOhzRWXqG6OR+Nzz5DIOnyTotr3W?= =?us-ascii?Q?1F00xNc1F+SvMKwMn08Z6LTfQGNvdIyqLXQ+SOcAMDaa19vnk2cA0/pnDctU?= =?us-ascii?Q?Us5TlCdLCg+TWWNBhq7SYQSmGN+TaU74kJE40AFwg20Y/j6Ob4apVZIL1VVY?= =?us-ascii?Q?qm9zwA5uZ4QXh26zQG0Rc583OQLllEHWdhUZzui8fSdo8ii8Cykv9peAXrmP?= =?us-ascii?Q?jJg4Q079FZB0bSwOwYmzfivvdB7p3E6Qf5C/IkVSDnwAo8oqnV7o6TCcv71M?= =?us-ascii?Q?EKiK/3Gw/SPMHvAhHuGiEW5YLHdw3/U3clGsfmqDtRXzaw9CjJNue7ybhfp6?= =?us-ascii?Q?EGc6IDbqckQoAIWS3q8rtCp+NNXS2w6884hwHwocH49Ggvl2PH4BGkeKaSKe?= =?us-ascii?Q?ZkhZ4WSrnTpHtk7ZhrdqNleXpakMnkBi17+h88lp3VcR9+ZYZYVLvai5g8S+?= =?us-ascii?Q?T8X6yIRgG/lgrO1Z9PlHgIrIp1xbMhxYmXJGwgP+s9pRahyxZIUFjw1z+bg7?= =?us-ascii?Q?YcN7Z7kcqmZpV4gd1Gp1xzBn/aSfTKMIVKtH?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:34.1599 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf41198b-5266-4921-f224-08ddcb22f42a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9475 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410659989116600 Content-Type: text/plain; charset="utf-8" Usually, priv_domid =3D=3D dom0_domid =3D=3D 0, and that is what is expecte= d. If we rename s/dom0_domid/store_domid/, it seems more likely we want to actually have the priv_domid as the owner. That leads to follow on changes to ensure that the priv_domid is created first. Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross --- Will this blow up if priv_domid doesn't exist? Maybe it would be better to just create these as store_domid. --- tools/xenstored/core.c | 4 ++-- tools/xenstored/domain.c | 15 ++++++++------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c index c2f8d20211..19edd75bc3 100644 --- a/tools/xenstored/core.c +++ b/tools/xenstored/core.c @@ -2266,7 +2266,7 @@ struct connection *get_connection_by_id(unsigned int = conn_id) static void manual_node(const char *name, const char *child) { struct node *node; - struct xs_permissions perms =3D { .id =3D dom0_domid, + struct xs_permissions perms =3D { .id =3D priv_domid, .perms =3D XS_PERM_NONE }; =20 node =3D talloc_zero(NULL, struct node); @@ -2317,7 +2317,7 @@ void setup_structure(bool live_update) manual_node("/tool/xenstored", NULL); manual_node("@releaseDomain", NULL); manual_node("@introduceDomain", NULL); - domain_nbentry_fix(dom0_domid, 5, true); + domain_nbentry_fix(priv_domid, 5, true); } } =20 diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index ac4ac72f99..dbeacaa93e 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1009,7 +1009,7 @@ static struct domain *introduce_domain(const void *ct= x, struct domain *domain; int rc; struct xenstore_domain_interface *interface; - bool is_master_domain =3D (domid =3D=3D xenbus_master_domid()); + bool is_priv_domain =3D (domid =3D=3D priv_domid); =20 domain =3D find_or_alloc_domain(ctx, domid); if (!domain) @@ -1032,13 +1032,13 @@ static struct domain *introduce_domain(const void *= ctx, } domain->interface =3D interface; =20 - if (is_master_domain) + if (is_priv_domain) setup_structure(restore); =20 /* Now domain belongs to its connection. */ talloc_steal(domain->conn, domain); =20 - if (!is_master_domain && !restore) + if (!is_priv_domain && !restore) fire_special_watches("@introduceDomain"); } else { /* Use XS_INTRODUCE for recreating the xenbus event-channel. */ @@ -1295,17 +1295,18 @@ void init_domains(void) domids[nr_domids - 1] =3D domid; =20 if (caps & XENMANAGE_GETDOMSTATE_CAP_XENSTORE) { + dom0_domid =3D domid; + } + + if (caps & XENMANAGE_GETDOMSTATE_CAP_CONTROL) { memmove(&domids[1], domids, (nr_domids - 1) * sizeof(*domids)); /* * Local domid must be first to setup structures for * firing the special watches. */ domids[0] =3D domid; - dom0_domid =3D domid; - } - - if (caps & XENMANAGE_GETDOMSTATE_CAP_CONTROL) priv_domid =3D domid; + } } =20 for (unsigned int i =3D 0; i < nr_domids; i++) { --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410664; cv=pass; d=zohomail.com; s=zohoarc; b=RvQy88XdwlocPp6Lkn4yR/qMgDQRngv0EA4mIFeW54wxYX9qOgD1B9E2uJT97ComUUaTN78dc9/qZocHGGP+dBbsXZZ8t/yIuBRvUk7BkVhVzRERErB3pQMSgk3798/9qlcnSjQs5I8QCgFbcjPMIFwXzAxpyZEAY+7kQQIDg80= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410664; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oUm4Zo+YCS52ak4UX9+eKTXCeD8AZGfnkh5ga1K9MFg=; b=m46p8Bpe9J9foqSuEaxi6+nGUVE6NMkuPCoZZN669D6CL1fGHkN40UzmWdspPXY8qvPSUSTUtn2n34CQuMS0uXny4ibcVONxwVp3c7xWIczETL966jkoODhRBzR3DcyWXHQdwIkycuyN/ZOL8XKYxVJ7riqAFihUex8jiHm/BBY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753410664284139.33542702361217; Thu, 24 Jul 2025 19:31:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056870.1424910 (Exim 4.92) (envelope-from ) id 1uf8Cr-0006AI-BM; Fri, 25 Jul 2025 02:30:45 +0000 Received: by outflank-mailman (output) from mailman id 1056870.1424910; Fri, 25 Jul 2025 02:30:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Cr-00068I-7G; Fri, 25 Jul 2025 02:30:45 +0000 Received: by outflank-mailman (input) for mailman id 1056870; Fri, 25 Jul 2025 02:30:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8At-0000gX-Su for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:43 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2061f.outbound.protection.outlook.com [2a01:111:f403:240a::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13b0b6e6-68ff-11f0-b895-0df219b8e170; Fri, 25 Jul 2025 04:28:41 +0200 (CEST) Received: from SA9P221CA0009.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::14) by LV8PR12MB9359.namprd12.prod.outlook.com (2603:10b6:408:1fe::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.30; Fri, 25 Jul 2025 02:28:36 +0000 Received: from SA2PEPF000015CC.namprd03.prod.outlook.com (2603:10b6:806:25:cafe::18) by SA9P221CA0009.outlook.office365.com (2603:10b6:806:25::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8943.30 via Frontend Transport; Fri, 25 Jul 2025 02:28:35 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SA2PEPF000015CC.mail.protection.outlook.com (10.167.241.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:35 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:35 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:34 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:34 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13b0b6e6-68ff-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b8QE7tDa03sri4DyIIGuDXg6pyhnUUWJwA7C+NHtSwTvEXRFPqHD4EZ2ELtCJF7ePH3Lp3E0ARVCLSzBT07oHbjcliol8QxHQmkv8c3X3h3ffmc8QjjdiBJrXpHc6BrixpUnbiKAxLc9Dx/uiiC4OCXnt9rE8ELCHGqusmOv8QrFC36E7OAxang2D2+J5V6RESke8ULPWnm1AjoamkY5Y1Y30UQyUfScTcWSDXdci/YbmV3vfrA6VXDEjKbCyt6efJJceeStU3WuJ4kUGuydN9+TDvCGXSVz/tNXOPI8htNcdnOArF2t4OygtgGSjhx5KnblA+czgtZOM1+XIC5eQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oUm4Zo+YCS52ak4UX9+eKTXCeD8AZGfnkh5ga1K9MFg=; b=SwhdaBiclOPMzMlTdSHIHtgoOc9GXFe3H6uoihrAE1KOSdjD6M/vp2u6t1JvXuivBPEMaS5mv1LqLfiMWSHKNbkT+S50LZP0IkGYRux5uvp7zDx0PddXuxTHy5U61JvwnmfayT2U7xRaKhA+xVo0qfpO3577vkuKxJKVvYJ3/Tkn7bq0fOjGhBjzH+wccBBduwCHn6EvKvfFuequBPKvxB+EnABYuzEdOtg2PEshbEs86KUg1b6NLLxqy8V88W4UOmAaESmq1bQ2VBszpCgdO04EtUnTAs1/9eln5gO2bSxNLmfre4zf3Tggi730nZyc334OX4ysyEJIluWFBk5Rwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oUm4Zo+YCS52ak4UX9+eKTXCeD8AZGfnkh5ga1K9MFg=; b=5Pug9M1ZEDh6NK+f0xifwDOtdsSF7/404C1kwGMQts914v3daX5G6uo2FMF6C3HBX1wwOyTg+PsgC+PvHilehQrr17pgZ1wC1hccrYcIQZCqNdfvjG6OqXbDCvrKAkoPAOzlXU6tZDGkjgrECKT0k5kjqgGEhfJ0mxBb1GyQp/s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH v4 10/12] tools/xenstored: Rename dom0_domid to store_domid Date: Thu, 24 Jul 2025 22:28:10 -0400 Message-ID: <20250725022812.466897-11-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CC:EE_|LV8PR12MB9359:EE_ X-MS-Office365-Filtering-Correlation-Id: cc893761-b70e-474b-ea88-08ddcb22f4ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|30052699003|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?q5E+U3Hmbk0pK+e7fWbEoQtEhFVIw/TrJ3Hl7nZ+gnHySSQ/LZAVvwi5Q5vp?= =?us-ascii?Q?vnUmys5o0oh+LKdChdzpDkCWhdTJzPvw66I3S+XA/ynOLuifnfA5LtGaMwFM?= =?us-ascii?Q?WOcbyt6GP1cUaOeZ9QTh0xwpk7z6nd36cQIMBSKisfuag4WNTRdpuHH9F6Gb?= =?us-ascii?Q?3imvrDjv37n5t35VGDiAoGS8UlMKXGr3uCMIdDrHRiGhbCktcN3bnXvjYO4P?= =?us-ascii?Q?QF5EWC5XSZKTktDBfNizW7hxGQB/K8EoWxFs2TanLU01sSnKuTuJExV0BzhD?= =?us-ascii?Q?c0KshmYeCmmE35AUEpHnxqThpupXWqkA2EpoJMWFao1FH9WWLCtC0crcHjUH?= =?us-ascii?Q?HWiCasoDSjEDbyE7O9q9H9eI/v9Eva1VuSO5qx4lzH9ghfW4bBwaH16e80tv?= =?us-ascii?Q?PEFnw40Y8NnVTKTv/aFXJtDNSfvLUfT6deNk53wsmLo5XnKYF/St1ocfrJcm?= =?us-ascii?Q?7aehkREuvcNmXkUpbndtJfSTNmUK+CIITtO2nUh+r6wh03oFGEaGgXlOU3on?= =?us-ascii?Q?JkTYjjraAWX+KHCukd/ifMP2cW/Ei5LpJJq4lbxQIwJylTHe8W9JpIrWua/A?= =?us-ascii?Q?YUAavdMeE3JAQ7wwtSuOGbk3mV/1NHh5yyv4LkW7ANAUZAoZwFFBiqcUDsFv?= =?us-ascii?Q?2FLDsaz1FnBaitISaNq9bvG3AFjMXSv50hCfU/UrI3FqKKsoD560GvViX4yN?= =?us-ascii?Q?IjD0VZz2eUL3q5lFpsfU5GILVl3ZkQzGsyw3CJLXsCO36QwUM3JV+N5LMF1p?= =?us-ascii?Q?5LSJbPw7oDa/5kLsj09UtxNC0tAh2he+3tceOcr+sy82m4OWc5FOtIJVIaC9?= =?us-ascii?Q?Me/bon7id22lZ6CI2Wv8YeneyZq4ZBs5o9mZrOe1FggHxiq0FAJBChd4NGuT?= =?us-ascii?Q?KpVbJBclz/d58GrJ5JtO+IN/C669ewh0KOQv5kTihjFywGtOCpoT7dy6dnyc?= =?us-ascii?Q?+ZYqpZIEk/WKykr0Yd4zKdWFMytqfbFeIMZa6xfdizBNoHE1jyO4+pYeaBF+?= =?us-ascii?Q?sYQOuYwM9C/3jqY2V5l+PJ4XbgoZJJfVliudYLf9FQrXRq/vuxdKw3cQ2Umb?= =?us-ascii?Q?bkJ0RgLLbz3yOaIz+1yVydWUGyIyiO5+G4xEGfmYygENXXYHiZJcWrmuCinc?= =?us-ascii?Q?Xl9Eo9jgEUk+RdzDIXrYvmVr3aoYVa9KgsyIpNEowZsEV5cJj29OrtocGuLM?= =?us-ascii?Q?vSe2noYIHXLCZO83+r+qouDHvIAe3ljVjcjLp1pQrq+8Yehjm8AguQSDq5Gl?= =?us-ascii?Q?jYqV9+M8QgXFcUqGPt9RJRp10OTQqyWzchAv4XlfUvGd7/J0lf47NgxRZHKv?= =?us-ascii?Q?7iTPYpjksJb4CdUcjFoiUZw2a3inaJyeEn1HwPiyB9qTYzQ4yKzlyA6ZzZKi?= =?us-ascii?Q?2ZgRSopSldfj0DJAEnOzgDWYskMl9ejbHXcvqQ6Nn6V/Y2T+/bmAKEwGeM/H?= =?us-ascii?Q?HtYLBzE4hY/yDa7LzcJfTFEXFwv+WsvZCkHXdP0qMtmMZLM1+kWf9Jqf16MW?= =?us-ascii?Q?C7tTrFrQdff/HLF2uAzhdA9/KWpLfeCx5R5l?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(30052699003)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:35.4181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc893761-b70e-474b-ea88-08ddcb22f4ea X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CC.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9359 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410666073116600 Content-Type: text/plain; charset="utf-8" The dom0_domid variable is misnamed and conflates purposes. If we have xenstored running in a Linux domain that is not dom0, this variable controls the lookup of /proc/xen/xsd_kva and the event channel. One implication of this change is that the xenstore domain is not privileged by virtue of considering store_domid as privileged. Rename to store_domid to better show its purpose. No functional change. Add a description of the -m/--master-domid options while doing this. Signed-off-by: Jason Andryuk --- tools/xenstored/core.c | 9 ++++++--- tools/xenstored/core.h | 6 +++--- tools/xenstored/domain.c | 8 ++++---- tools/xenstored/posix.c | 2 +- 4 files changed, 14 insertions(+), 11 deletions(-) diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c index 19edd75bc3..981907ec28 100644 --- a/tools/xenstored/core.c +++ b/tools/xenstored/core.c @@ -2536,7 +2536,10 @@ static void usage(void) " allowed timeout candidates are:\n" " watch-event: time a watch-event is kept pending= \n" " -K, --keep-orphans don't delete nodes owned by a domain when the\n" -" domain is deleted (this is a security risk!)\n"= ); +" domain is deleted (this is a security risk!)\n" +" -m, --master-domid specify the domid of the domain where xenstored= \n" +" is running. defaults to 0\n" +); } =20 =20 @@ -2564,7 +2567,7 @@ static struct option options[] =3D { #endif { NULL, 0, NULL, 0 } }; =20 -int dom0_domid =3D 0; +int store_domid =3D 0; int dom0_event =3D 0; int priv_domid =3D 0; domid_t stub_domid =3D DOMID_INVALID; @@ -2733,7 +2736,7 @@ int main(int argc, char *argv[]) dom0_event =3D get_optval_uint(optarg); break; case 'm': - dom0_domid =3D get_optval_uint(optarg); + store_domid =3D get_optval_uint(optarg); break; case 'p': priv_domid =3D get_optval_uint(optarg); diff --git a/tools/xenstored/core.h b/tools/xenstored/core.h index 1ba9592d16..d44cca8454 100644 --- a/tools/xenstored/core.h +++ b/tools/xenstored/core.h @@ -364,7 +364,7 @@ do { \ trace("tdb: " __VA_ARGS__); \ } while (0) =20 -extern int dom0_domid; +extern int store_domid; extern int dom0_event; extern int priv_domid; extern domid_t stub_domid; @@ -381,11 +381,11 @@ uint64_t get_now_msec(void); void *xenbus_map(void); void unmap_xenbus(void *interface); =20 -static inline int xenbus_master_domid(void) { return dom0_domid; } +static inline int xenbus_master_domid(void) { return store_domid; } =20 static inline bool domid_is_unprivileged(unsigned int domid) { - return domid !=3D dom0_domid && domid !=3D priv_domid; + return domid !=3D store_domid && domid !=3D priv_domid; } =20 static inline bool domain_is_unprivileged(const struct connection *conn) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index dbeacaa93e..d9144e97a1 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1139,7 +1139,7 @@ static struct domain *onearg_domain(struct connection= *conn, return ERR_PTR(-EINVAL); =20 domid =3D atoi(domid_str); - if (domid =3D=3D dom0_domid) + if (domid =3D=3D store_domid) return ERR_PTR(-EINVAL); =20 return find_connected_domain(domid); @@ -1267,7 +1267,7 @@ evtchn_port_t get_domain_evtchn(domid_t domid) return get_xenbus_evtchn(); } #else - if (domid =3D=3D xenbus_master_domid()) { + if (domid =3D=3D store_domid) { return get_xenbus_evtchn(); } #endif @@ -1295,13 +1295,13 @@ void init_domains(void) domids[nr_domids - 1] =3D domid; =20 if (caps & XENMANAGE_GETDOMSTATE_CAP_XENSTORE) { - dom0_domid =3D domid; + store_domid =3D domid; } =20 if (caps & XENMANAGE_GETDOMSTATE_CAP_CONTROL) { memmove(&domids[1], domids, (nr_domids - 1) * sizeof(*domids)); /* - * Local domid must be first to setup structures for + * priv domid must be first to setup structures for * firing the special watches. */ domids[0] =3D domid; diff --git a/tools/xenstored/posix.c b/tools/xenstored/posix.c index 6037d739d0..d0622dc05f 100644 --- a/tools/xenstored/posix.c +++ b/tools/xenstored/posix.c @@ -266,7 +266,7 @@ static void accept_connection(int sock) conn =3D new_connection(&socket_funcs); if (conn) { conn->fd =3D fd; - conn->id =3D dom0_domid; + conn->id =3D store_domid; } else close(fd); } --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410659; cv=pass; d=zohomail.com; s=zohoarc; b=id+g6DFCzPV22SnlFRDanZLLNEVIeoLpaey49oUBiAb7nXfv3PUYUb2Almv4jsioQx+WiG0e4hITz06IDLuivu49vzHFKDK7pGh1YKddx5hDvuKywt+JpCtVJRs007VxetEm1HHpUunevakV0LuLtiprZ9WIoAMKr6PblNeBhJg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410659; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IY46yUzC/+71M6lchNLsMz+T9eDvpji2uNrFCavqT2M=; b=DzAyPoKlJ1Ady1GJc5yQ4WCUJCrwGLnPdmqrlq8r3kdgmu2iY6m3uUs70RJD8vBDF8Q9mkJ6P6HI+a9OevZoIwzX2ov+OhI0LYDtxA8AIIdOHsJl7ki6GUdSu54TX7sTAR7O9R6r9XrHf9ANW31IHA9LLwCVOXsE6cxb3RJJFIA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753410659496560.1561611158434; Thu, 24 Jul 2025 19:30:59 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056872.1424915 (Exim 4.92) (envelope-from ) id 1uf8Cr-0006C1-Mb; Fri, 25 Jul 2025 02:30:45 +0000 Received: by outflank-mailman (output) from mailman id 1056872.1424915; Fri, 25 Jul 2025 02:30:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Cr-0006BS-FL; Fri, 25 Jul 2025 02:30:45 +0000 Received: by outflank-mailman (input) for mailman id 1056872; Fri, 25 Jul 2025 02:30:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8As-0000gX-Dn for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:42 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061f.outbound.protection.outlook.com [2a01:111:f403:2415::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1335860d-68ff-11f0-b895-0df219b8e170; Fri, 25 Jul 2025 04:28:40 +0200 (CEST) Received: from BL1P223CA0006.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::11) by LV3PR12MB9402.namprd12.prod.outlook.com (2603:10b6:408:213::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.30; Fri, 25 Jul 2025 02:28:36 +0000 Received: from BL02EPF0002992E.namprd02.prod.outlook.com (2603:10b6:208:2c4:cafe::d7) by BL1P223CA0006.outlook.office365.com (2603:10b6:208:2c4::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.21 via Frontend Transport; Fri, 25 Jul 2025 02:28:36 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0002992E.mail.protection.outlook.com (10.167.249.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:36 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:36 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:35 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:35 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1335860d-68ff-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uc7X4h6bffmnRKhrO8Zl7p5gh2AEWnZRsQi0WTfiE8KkcJFS5ylUMX3ghLlTx64ClOqXIE9pbgzuvEABiGoMgOEVXvDBQQgqXvPBv3yF05yL08x+zrWJS8mxLjsCFG5fifQlv2jkSJ/4Uan+x3NTYOmeYuSLmk7sb7juTjUwaNw0ivRiD5tFp9SAF9QMMlhFf3+CnwUs4OsHeUCc6xICqaDgIO5tDvg/LCEOfL/T8/Jf6wpEYhr3dqYEtj4rwfl46loNOs2UO9gNvCz/MifzqeJO+SwezIuR1xYAfzyA+ELQd0I8orkC/E2glpbo/IIWLtq/S2pP/i0yPc/NyOItog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IY46yUzC/+71M6lchNLsMz+T9eDvpji2uNrFCavqT2M=; b=Gs4dAq1Xg1mXPDLZCEv2sppKH5t8RuY6oRjzcFZgtSRwYYGx0n0zAynaTHpN/GCnMU/z2e9zcwIQYyThUC81mbFMsDAqFPv4UeDK9bEXuqS6h6IJ738PCryyGuO8T9dPZyRje7wCu9ojriwXkv+p0vVWvQS4V1iYfVBsJSS/DTfw/i7cRZYKoVgjWsIFfCgZC9Fkb513kYz5UAOUbb+Gv8PRXjh75lDYAtlvlsmhDG4P35UlWCd02IX4YgEKxtS03G7E1AA48CsN1qvcU2yX/idjKkrCi0e/cmReNR49yi98ktkt/Xj9xEasWLz6IUDpliZ0vdfhQEs1/bX13vWPrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IY46yUzC/+71M6lchNLsMz+T9eDvpji2uNrFCavqT2M=; b=nzuUf0IoiNK6Mdv1z3oC24Jp9/ZMzdOWhqgK+WFPktysm0hbBby7jq8QTGOkUvgBfpt6boQpPCVmlrgWIG1eLooolECj71/uNTBfwh/I9Bx2aPtHVsXkcyHEIYGkV9uJxMmliTl6RiFGT30kiFhKqsH9dyJY/baXpQ7c8ZNtfDk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH v4 11/12] tools/xenstored: Rename xenbus_master_domid -> xenbus_store_domain Date: Thu, 24 Jul 2025 22:28:11 -0400 Message-ID: <20250725022812.466897-12-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992E:EE_|LV3PR12MB9402:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f2be8c7-05ed-4f86-aad6-08ddcb22f582 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IKjNFiylx+tOAjb5Bf+/whC8I8bn7JSxNQHdPFMprnacu1eATBYiN2igfYz5?= =?us-ascii?Q?2Ajo0oUCZEcx+ywBFzjCktcCHYO3DJOVrYDF5ksK9A7b4UupHjb1qBeQ2yV3?= =?us-ascii?Q?rLjhyBz0Xt6IuTKJ7qjMLvCHF2y4PgPqQ+n15gNXRkWSMgmmxjzPrij46yia?= =?us-ascii?Q?kWkNCLS/mxL5TLgqr3PSugDgk5TEgh2mM0BKCVgLIFLGZUZzkbFg0lsk1k4J?= =?us-ascii?Q?uL1T11A62fYiBnTg+lSJP4NPfgHhwUP1VEfX0z/3kjEDNvLGK01+ViwgUa1T?= =?us-ascii?Q?DEA4Ttbzuu4+Cgr5sWlxHRQJTHe09AkO/7sCgLsltFjtVgK5S8Ndr8nHIOaD?= =?us-ascii?Q?3umQtlyAB3ZKCPHaksLfhOI5C5lmR91XNB31ZNQNlRLBzuikcc4e7Lk2zu2h?= =?us-ascii?Q?0/uETBABJpZq+oD/GKOfv3+paegq8wA/qU503+MD3nykAh2p1RpsuuvEmuFy?= =?us-ascii?Q?KGIaxurG4W+BtnnlvKrrZ69KmDMe2I80P3llOTF8jJzh9DMHpBS8H7qzFxnU?= =?us-ascii?Q?FL4Tu7VO+ruqoVvVbzN1W0qxdBU2zKHhXsbAXhY/SGsjOwr6xymSlqKjQsMB?= =?us-ascii?Q?UbBDh9rRpLSnt6RZ3w9gwTjtXuV1MatKDsjQ+2iaYSdiFWADA9RZinzvW8fr?= =?us-ascii?Q?2fxr92T36+ka2rnG/Qzkk/e0UlTYZ+X0p/MhQqc5ulUTVZo1yf+xJ+/fc3l3?= =?us-ascii?Q?vN1w2H37XAi8x/4vn89cZXUCwDF/DimtQDjHjWTgnomhSPLbIGT3gbPTq1UK?= =?us-ascii?Q?8Q+htI8q6ykw4csbh4tuSjgusTFpLYf7gZbXbFNEcIX+hSMnixIljevPxLv2?= =?us-ascii?Q?ODZ3MyDBybAzHB7m3pplPVoWm0wzzN9zhh2GsbgGVyxPIW3y4at+F3cRJuHT?= =?us-ascii?Q?ztCQJA46xqdR/tlQVJ3aJ0GoRZ1rKZFdesNfoWtNDiupfTVnXfVJiutRJ10K?= =?us-ascii?Q?3eoUbtWIoPoGZWkKQc7XGrYtinxNy8bSkvRjW0x8Gwjlhg4aKoomclUXbblV?= =?us-ascii?Q?KBKu1gkbpAG/QotSAjZRHIyhpr0vxz5JslIS4GFa2hS8VnRWwJtsHQT/ZLT7?= =?us-ascii?Q?ZaXqexZkXo/QjcPyefmcfyYaSvf5ZzziTcny2KfXPYtOBR9Nqhz7ckrWBpIe?= =?us-ascii?Q?Pdq/O7G4e+qIXo7R/5p0b2CLzoG6d8F48+YSF/UriCiVuST1aMfQGtu7MkeZ?= =?us-ascii?Q?jA84XmztgeLVP3MnliFfsTD0ORm7FGuj3yzceGQCuxIVXuW6iMW+W9d5FHp2?= =?us-ascii?Q?+Jx0wWaMn+dO7XNAeyW9tEVTd6x4sMK3kyI5xFK3+C+gHz32mBFSZO7xtsFR?= =?us-ascii?Q?uLUqfeCHuXfBAwbUOcJ3GEpitzHNWmz/NrVdUFFH2caig3EXNpYTv4sOvzVZ?= =?us-ascii?Q?9nyNoWbVhliMtbfgTZ8fXLypdMYFUYKUQgr7JzxCU+SzzY5REbQ2xfeEcrsC?= =?us-ascii?Q?qixH3sz29hoU0TlZSROmAJ7/gxxjhjg1Me1tZ0T8sxV9aj1zyfDP59BRK3yx?= =?us-ascii?Q?XmltsvbwFmOiw4x315Ez6ZmoZB+AJMSc9+Ug?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:36.4357 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f2be8c7-05ed-4f86-aad6-08ddcb22f582 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9402 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410659935116600 Content-Type: text/plain; charset="utf-8" Rename the helper that access store_domid accordingly. While doing this, rename the is_store_domain variable. No functional change. Signed-off-by: Jason Andryuk --- tools/xenstored/core.h | 2 +- tools/xenstored/domain.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xenstored/core.h b/tools/xenstored/core.h index d44cca8454..3e209893f3 100644 --- a/tools/xenstored/core.h +++ b/tools/xenstored/core.h @@ -381,7 +381,7 @@ uint64_t get_now_msec(void); void *xenbus_map(void); void unmap_xenbus(void *interface); =20 -static inline int xenbus_master_domid(void) { return store_domid; } +static inline int xenbus_store_domid(void) { return store_domid; } =20 static inline bool domid_is_unprivileged(unsigned int domid) { diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index d9144e97a1..f1527a6db7 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -503,7 +503,7 @@ static const struct interface_funcs domain_funcs =3D { =20 static void *map_interface(domid_t domid) { - if (domid =3D=3D xenbus_master_domid()) + if (domid =3D=3D xenbus_store_domid()) return xenbus_map(); =20 return xengnttab_map_grant_ref(*xgt_handle, domid, @@ -513,7 +513,7 @@ static void *map_interface(domid_t domid) =20 static void unmap_interface(domid_t domid, void *interface) { - if (domid =3D=3D xenbus_master_domid()) + if (domid =3D=3D xenbus_store_domid()) unmap_xenbus(interface); else if (domid !=3D stub_domid) xengnttab_unmap(*xgt_handle, interface, 1); --=20 2.50.1 From nobody Thu Oct 30 18:37:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753410669; cv=pass; d=zohomail.com; s=zohoarc; b=K7Zo0EHQsF7yHggGULQFs/ScpjKLlGG9RJZCojVtzgY2rrcwf21TUqFoSuiwIsELjIROQJNmvS5Bqw7la6Q+y782LFGw0PxXgjJAUv8l49QyVlLk7phd/g9KH3iW6OhXIQsuu1FA+YTrPs83n3D8jqViM8v+UDBMBpdNYBSqL9Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753410669; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HXAy8+XrxvcI4+I3pip5hEDLU6VX5kM2jBwL5ALEmE8=; b=jb3BCWwI9gQ6WhE2QsN9De5ZE+nl54W0cyLVgTzz6qAvNct9BAW4po5gsToH6vHlf2UTB45nCNDxV/AVSlOBZpkkMqeeeQQ9hPxWoHxR1hF1WAtR2We3Y/3wIo/9ZOyW/1RE03nkKqMT4KzXNsbqwK+ZCRn9TQAoIyWYL+0mmT4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753410669760909.4435714893524; Thu, 24 Jul 2025 19:31:09 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056883.1424931 (Exim 4.92) (envelope-from ) id 1uf8Cv-0006pg-0y; Fri, 25 Jul 2025 02:30:49 +0000 Received: by outflank-mailman (output) from mailman id 1056883.1424931; Fri, 25 Jul 2025 02:30:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Cu-0006pW-Sv; Fri, 25 Jul 2025 02:30:48 +0000 Received: by outflank-mailman (input) for mailman id 1056883; Fri, 25 Jul 2025 02:30:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uf8Au-0000gX-T7 for xen-devel@lists.xenproject.org; Fri, 25 Jul 2025 02:28:44 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20620.outbound.protection.outlook.com [2a01:111:f403:2416::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 149f716a-68ff-11f0-b895-0df219b8e170; Fri, 25 Jul 2025 04:28:42 +0200 (CEST) Received: from BL1PR13CA0028.namprd13.prod.outlook.com (2603:10b6:208:256::33) by DS0PR12MB6464.namprd12.prod.outlook.com (2603:10b6:8:c4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Fri, 25 Jul 2025 02:28:38 +0000 Received: from BL02EPF00029929.namprd02.prod.outlook.com (2603:10b6:208:256:cafe::94) by BL1PR13CA0028.outlook.office365.com (2603:10b6:208:256::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.6 via Frontend Transport; Fri, 25 Jul 2025 02:28:38 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF00029929.mail.protection.outlook.com (10.167.249.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Fri, 25 Jul 2025 02:28:37 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:37 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Jul 2025 21:28:36 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 24 Jul 2025 21:28:36 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 149f716a-68ff-11f0-b895-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FlvwsQ+5SuwL3xlYTH50vXRP3ELsRtkrZXfykGQ4AJkRe6yL/ioI3B2UZCBPuFMof3RMJ6GVws0xyLXOxuz6S+C4AxmoC2HlTmjFT6KhhHL2Kx2a6oWDemylWxN8zvCov6d8pyCixwEl0HRQcYauDjdXsi0WUGjj7pu3LPMEnr34hV9I48mVG2WQ4D8xCGVCCtSVM82v1r+lKlMIeWgYWLejAdIWvlfk78LwMLGWIUw9bavxxkAxcvMm3UckdkrJryQ2UfvagumB7z9hvjOo36OSDN4ZZPamfiXVsTQ96zpd4ZxgaZ6gtk744F/dEH5dgKTZcSVwPCnZftZSmEAweg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HXAy8+XrxvcI4+I3pip5hEDLU6VX5kM2jBwL5ALEmE8=; b=dqs6PfvMAxpRhBufOZ7oKmzJAG7hwYUBaQ12SFF0POH91Shz55HgSjgkgsLRRFpgMnuGKAg5rJDwazF4PZ3oxn6yR846yS3TdYsfR6ZJ6369yu6nWBgVO08gLJu7fXIwKIfesEuW9k55L3iq+GaoB4FBcbf4kPUCWyzVBRGuGcP9n0gWW9yC+FZxojeQrtFqu8oxiVzh/32zq1zGbDfMkFCeN5b41rwLxNbe2OzP5oa0oecPJTEfIBznt4u1z7CEfKT7OMLzEkT9LYqJWVuJfHrQMGb7SE/53fJvnk6TqR+wS+J85qmJULMFObvKnyeQ2Ayll0b0wvKcGlBBZSnfag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HXAy8+XrxvcI4+I3pip5hEDLU6VX5kM2jBwL5ALEmE8=; b=Q3LLKSUrMRIJdGZ0LMaxIJKD2gnh2V5XnRzuUAFUBJMKSPc8+C2GWCHJiS5akIxDQ1lsiKoPA8nzJNVdora7hC//tuNjTf+LFkNrZ4lBb5qJ7Wiq0pU6KndUMpwG0qDBUATF8l4PZBDgOGiqNhHmaCoZTeMgOfombu42LzXZPv0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH v4 12/12] tools/xenstored: Remove hardcoded implicit path Date: Thu, 24 Jul 2025 22:28:12 -0400 Message-ID: <20250725022812.466897-13-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725022812.466897-1-jason.andryuk@amd.com> References: <20250725022812.466897-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029929:EE_|DS0PR12MB6464:EE_ X-MS-Office365-Filtering-Correlation-Id: c5e31e40-50dc-430c-e4cf-08ddcb22f629 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?snwcDH2Q50IwDMWmBdsJu5DRTX7LQonk+bUmPj95DNrAHXnO4etiZy0ZFCpr?= =?us-ascii?Q?i1iyDmWkz3mXl92XEZISXoUZPcTO9gKZgORTEfL8xf5tCLbjKgtlGsX4WOV7?= =?us-ascii?Q?4VoXF0KDfFOOE8aLdi+ZaIH7vtkFWFfukjwBgxdBmN1zIAjklglnhoQ1oJEF?= =?us-ascii?Q?SkIZL/M9FIUliyNECTXMbee5uHO8odwwaSVJx5/x6JfI5Jdtj9zUnxyS7mNf?= =?us-ascii?Q?faolTXfYwRekt37kXdP338AiwqhFYn4jHOm11zh8iqUeJa6klpbYTN3BXlJq?= =?us-ascii?Q?Jvgq1B8JnjqVTi4x7THEco2sbrsZS/kAHe3FXJBft7O8VjpwMLCRFv2IQhFv?= =?us-ascii?Q?YNZBvG+m5DoKbSA/wtSDjp7+gGnF5maP3cw74iVv0LalfHtPF5Si3cnw67yy?= =?us-ascii?Q?YahU66Pn6JD5YfwI/bJ2z2P7Aj9CUEiB5rjvXl2rLEXq5rq+bUy05n1PSvJJ?= =?us-ascii?Q?r7eGFrhE4da6CgPi1NAvY9OHMUuw7UkGmBGYkFlbiBW3m60GwjzNv/f4ixgZ?= =?us-ascii?Q?vjYjd260Zl63OtQMD0m0q9qOLrfQoA6YZPjrMDKDCNAXc9/r5+4fzNAY1MO4?= =?us-ascii?Q?H+gb270x69Ev9jFyg4iyIYc59S8xRMqMADiGQQYUZD1kB2LBTq0iKPYRJUP4?= =?us-ascii?Q?YEUhuRzfF4YGUPOWxn/H66tzbSYDbHSt6DnzGJ+gqRq+yngE0InO9dYwuExQ?= =?us-ascii?Q?Lo3QzySQpTVGYEoSXp9zQJv8r0EbDOG7kSoQH0cDeEBZG/FOupLY3SMlrxWX?= =?us-ascii?Q?7/Byrb2uS2p84GYdoCNmBwU6Jz+cza/FmWehZQRZlDXz2GGstx8dgAdw+iht?= =?us-ascii?Q?7C8BhPm/8qh45gde9kKKj3BbYqqi4N26y2RCT23wVUrNBzQkshhXrti2SARJ?= =?us-ascii?Q?F5DHeRY0/lXbJGSIJhv2/FZA3X69yhzoJC9cF52LJB0+WY6F9PsemmvESDza?= =?us-ascii?Q?WOKGuYg+Nnv8DLMWJRfjflDMkBDTYgLW3+UaG6oORR35fAofsBi26gB9/0NH?= =?us-ascii?Q?A/wfqwFc3ib3Jz8gqa+3ni9nIP2T6EHOIGibrfbPHyxmUn2i/8lB7cZ28QAK?= =?us-ascii?Q?1j46YAmb3Cn1ty43msqlpsAqkPwD31Alphr7lwJR+Ashumsbj5r1iwNpWqYn?= =?us-ascii?Q?rLG1XVHr67zoLULyX45c9nT/oiIBVc/3PM6mRu+ta+ZLZEkdPPGbT2LeTyvB?= =?us-ascii?Q?WtrcH1PYKHuB7r/SCYFNemAVa4eH+roBfTAo2Odu43ulup1UgxWz4s6RC8vG?= =?us-ascii?Q?01AlRIusEtfUIADkW3xfjVDY7ZRILRUtED7eniVcyoEk6IoICpdDcGEAU2FX?= =?us-ascii?Q?zXIQ87etOXmHFCLzkLDWfHNTjmeeVRn/biGVB0x2oLP0YwS0wFPScDw6Tw0L?= =?us-ascii?Q?uYmUgwh1JWgG5PrjoaUIhIaQCSwZ0d0TNHUQQeLY3QgJsltZeOLfM5OYozZM?= =?us-ascii?Q?nQbOYnAMsGgK9zbFKXC5S06qu8wgJDseXX8jz9GjkxviFGy6Kpo92mFYxFW7?= =?us-ascii?Q?+KePlGsGXiiPHhZwtJiQL5e3Cf6r5Yv8W9xu?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 02:28:37.5294 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5e31e40-50dc-430c-e4cf-08ddcb22f629 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029929.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6464 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753410670202116600 Content-Type: text/plain; charset="utf-8" Update get_implicit_path to return the correct value for a non-dom0 xenstored domain. Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross --- tools/xenstored/domain.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index f1527a6db7..ae59b6e60b 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1238,11 +1238,13 @@ static int close_xgt_handle(void *_handle) return 0; } =20 +static char store_domain_path[] =3D "/local/domain/65535"; + /* Returns the implicit path of a connection (only domains have this) */ const char *get_implicit_path(const struct connection *conn) { if (!conn->domain) - return "/local/domain/0"; + return store_domain_path; return conn->domain->path; } =20 @@ -1309,6 +1311,9 @@ void init_domains(void) } } =20 + snprintf(store_domain_path, sizeof(store_domain_path), + "/local/domain/%u", store_domid); + for (unsigned int i =3D 0; i < nr_domids; i++) { evtchn_port_t port; struct domain *domain; --=20 2.50.1