From nobody Thu Oct 30 22:39:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1753374208; cv=none; d=zohomail.com; s=zohoarc; b=LWtBMoxdC3uhvDnlEgtdbkO2ceF7fOnlOLOwc1pdMda+a9dz1FlRaVMH/znCnnhf6vsvrYFGVu+YZg8gxJBt5Kg+yczGEUY769MP/9Zf7D33rTDTkRZ8nlDTfo1E7/ZfVvNwA8nIhEgyvDyLbMl5iyTbYO+5sdwwH7tzYSXpuyc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753374208; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dlmGeXFYLb39H+GEEKv36aG5ffX0auy3m86JuL+WpVY=; b=LhdZIzH97UTiRjmWP9vFlUiniLUGJiKET/9cP7l4l1rjXvRABOH5rYpu/MZ/ix6C4UEuswYzKBpeTBhPDVn4ES+F3oIftb4VfeQ+vSuw+8ydck25agcfXcu0MU7kyrcX+zrNE4kmECGjfgG4lQzXxnVXvn+yJDHUNsFLrVc0S2I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753374208736743.62027894594; Thu, 24 Jul 2025 09:23:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1056345.1424595 (Exim 4.92) (envelope-from ) id 1ueyj0-00009E-70; Thu, 24 Jul 2025 16:23:18 +0000 Received: by outflank-mailman (output) from mailman id 1056345.1424595; Thu, 24 Jul 2025 16:23:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ueyj0-00008i-2E; Thu, 24 Jul 2025 16:23:18 +0000 Received: by outflank-mailman (input) for mailman id 1056345; Thu, 24 Jul 2025 16:23:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ueyiy-0007fi-95 for xen-devel@lists.xenproject.org; Thu, 24 Jul 2025 16:23:16 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 80793573-68aa-11f0-a31e-13f23c93f187; Thu, 24 Jul 2025 18:23:15 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3a522224582so602247f8f.3 for ; Thu, 24 Jul 2025 09:23:15 -0700 (PDT) Received: from localhost.localdomain (host-195-149-20-212.as13285.net. [195.149.20.212]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b76fcc2bc8sm2615965f8f.72.2025.07.24.09.23.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jul 2025 09:23:14 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80793573-68aa-11f0-a31e-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1753374195; x=1753978995; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dlmGeXFYLb39H+GEEKv36aG5ffX0auy3m86JuL+WpVY=; b=LprrL5Bp80PwkABcHSE9Pmpl4qiqkOiFtxK0/ybOlWtyhlvVBtqNml4M6Ou+xqVGVn RwFwZtC2rZnyYYTFyBvusWbrkMvATmBOA8IoWBdwoQEm0FE4DlMfSb8TWxINWM+VV/Fv 3LAbyWty4mj3zydLoGjM7n0G5fZleRfb9/bXg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753374195; x=1753978995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dlmGeXFYLb39H+GEEKv36aG5ffX0auy3m86JuL+WpVY=; b=tliONApLbBOCvNkuwycUTSaF6kwN/9Wu0JXa5t/yABJxngLsPAhRr8SxR6jbd0+4qb cE9wSxkO00ul/9S+6yXqM5/EEPSLHeq7bDRJAmzieILZPXMCavb6/XhTvHsLnB/WmfKT GSV64dWaRkGOZ3l8iGf9o00TlCflko9ieAIDzTN/TaszMyhjROutT8G3AbwZPLYmnyPP iUHXATHm66nP/MkGk+dd2hcqeH46U0E7lzGdJrhrxtAQxTiclPnfaWlVp6L2oV86lD91 tmKPc7HuYPHFV+sG4Oy5ujI5nuafDhJN3ELsdiy6KD2M3Y1/u9824aP4MNgL29IstZcx sYfg== X-Gm-Message-State: AOJu0YyIaGXN0OPwxcfZXfimyoHqjmFE1J1KvexJVAzzumHeSAi6G8DU ecEyuJkkOd93X4a+oQVhw2m3pOaFAtqbidP/O4uNVdtXv37Q7DJNnZfnNxo56iw0tDyuicpKeUK k6wC1cV9nXg== X-Gm-Gg: ASbGncvfP8k0RSl0P1oyP2M1Ztw0UUBh+fqz5o3ZHqY1NJajAmoD7uXjt7xNmSvxhxz YNMx9vkTUveheaDVm7hmbL/a6yAGRMm5YmJgJuXNmakp4MXE9P07luyQquOdBJKVFQvxMGzTPBt PdFmwY7CaHTqye7JIYVKE/bjkM/ADo+KSqxhNSPbrEKpf4w/rTVeXrJWOXLXIbqef+0z1lmvHI8 6PJ8qiMnO11eYCojLLcX2kIAokYBM06H42O0CnOZbk8rS6QHwdVVEUidfIRNKAtReP8ml3jXLDX BV7a0bm+FDPHDav8QXJ7J6TmihxELm67HvLKiId9BuyIo+/SAgAlCVR3XYiYH/Eu+raJpzqFBdZ Cbjo3OUcYWDvYUWPAqJn6dw6QCXX+aGKAxQxSzAoD6iKCzYhSyf/Xuyg5vHIt7ZGPQU+2rH2jhm 8c X-Google-Smtp-Source: AGHT+IGlciWHsJdS5c5LMXfknK7zCMqqgaqPs/pTnB1/yRAM/VEU09Qs12PGjwmaiiYsFkCGj3qHAA== X-Received: by 2002:a05:6000:2209:b0:3b5:e6bf:5e0c with SMTP id ffacd0b85a97d-3b768ef952bmr6253895f8f.31.1753374194954; Thu, 24 Jul 2025 09:23:14 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Carlo Nonato , Marco Solieri Subject: [PATCH 4/4] tools/libxl: Remove unconditional XEN_DOMCTL_set_llc_colors hypercall Date: Thu, 24 Jul 2025 17:23:06 +0100 Message-Id: <20250724162306.2978741-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250724162306.2978741-1-andrew.cooper3@citrix.com> References: <20250724162306.2978741-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1753374209954116600 Hypercalls are not free; cache colouring is an experimental feature, and ignoring an -EOPNOTSUPP is bad form. Now that Xen has been fixed to initialise colouring information correctly f= or domains, xc_domain_set_llc_colors() only needs calling for domains with explicit configuration. Rearrange the logic to avoid the hypercall in the general case, leaving a comment explaining why it is performed so early. Fixes: 748bd725fbec ("tools: add support for cache coloring configuration") Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Carlo Nonato CC: Marco Solieri --- tools/libs/light/libxl_create.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_creat= e.c index 4301f17f901a..4042ae1a8957 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -699,19 +699,21 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_co= nfig *d_config, /* A new domain now exists */ *domid =3D local_domid; =20 - ret =3D xc_domain_set_llc_colors(ctx->xch, local_domid, - b_info->llc_colors, - b_info->num_llc_colors); - if (ret < 0) { - if (errno =3D=3D EOPNOTSUPP) { - if (b_info->num_llc_colors > 0) { + /* + * If Cache Coloring is wanted for the guest, it must be + * communicated to Xen prior to allocating guest memory. + */ + if (b_info->num_llc_colors) { + ret =3D xc_domain_set_llc_colors(ctx->xch, local_domid, + b_info->llc_colors, + b_info->num_llc_colors); + if (ret < 0) { + if (errno =3D=3D EOPNOTSUPP) { LOGED(ERROR, local_domid, - "LLC coloring not enabled in the hypervisor"); - rc =3D ERROR_FAIL; - goto out; + "LLC coloring not enabled in the hypervisor"= ); + } else { + LOGED(ERROR, local_domid, "LLC colors allocation f= ailed"); } - } else { - LOGED(ERROR, local_domid, "LLC colors allocation faile= d"); rc =3D ERROR_FAIL; goto out; } --=20 2.39.5