From nobody Fri Oct 31 04:01:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1753193243; cv=none; d=zohomail.com; s=zohoarc; b=Ukwkyi+KIsdu79o0b6HjGVmCpUgIGXAtKN7wRGk/bBYic2RSTfDHRa6Ab82Gt4mLKKdpSTW1+F0McVDBowDGbE8Z3sjp2A9GKlimgddVQgKuBGR3culs16XfbSqZ2bSMQVBEWNsRV3lbkYcztyGuLsVixidRY3ULHg+zoibH7J8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753193243; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UEcsRHIDGTA5aOeJJG/B8yR+BciXZq054xn8sSP9ApI=; b=W198nm1zq50S4gSHVyQ22cr8VR2y6tm1ZEC4ukrYbw0VLVwZwAMUz+YG7S1x35+60djDFfl3qI8dGl0ozT8gR/21A4Mubf+d26L2Xe+IGJ9P/hpI0vmSimtaVYWwshpboX4hiOh41wjl3RBa+Wv545x3xARsMkXPBq3vNd+XGN0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753193243460736.7950955676647; Tue, 22 Jul 2025 07:07:23 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1052683.1421461 (Exim 4.92) (envelope-from ) id 1ueDe2-0006nF-Jd; Tue, 22 Jul 2025 14:07:02 +0000 Received: by outflank-mailman (output) from mailman id 1052683.1421461; Tue, 22 Jul 2025 14:07:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ueDe2-0006mz-Ee; Tue, 22 Jul 2025 14:07:02 +0000 Received: by outflank-mailman (input) for mailman id 1052683; Tue, 22 Jul 2025 14:07:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ueDe1-0005Q3-0i for xen-devel@lists.xenproject.org; Tue, 22 Jul 2025 14:07:01 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22b44331-6705-11f0-a31d-13f23c93f187; Tue, 22 Jul 2025 16:07:00 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F021C211A8; Tue, 22 Jul 2025 14:06:59 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C68F013A32; Tue, 22 Jul 2025 14:06:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ktrtLgObf2jTIAAAD6G6ig (envelope-from ); Tue, 22 Jul 2025 14:06:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22b44331-6705-11f0-a31d-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1753193220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UEcsRHIDGTA5aOeJJG/B8yR+BciXZq054xn8sSP9ApI=; b=e0l5xblAWqYqqgs4NpIozYs553ooN/tLVfq4OpQxZfac/F0yGAVGFVCcLfu39DA0XlUzBQ VABDYnSyUetijL9Jfibv+Mz7+yTZqUjoROE9KNL/xuSd7FusaU8VdUxOF3Q62OzBDpf3G/ 8u5iL1BL67ZqU6nIxBJmrLIXKd5iW3s= Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=gwXXJlJc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1753193219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UEcsRHIDGTA5aOeJJG/B8yR+BciXZq054xn8sSP9ApI=; b=gwXXJlJcCAkY+2EOyJlF9cS3bQwOOAPoYrjcOjiBFmiX6ImkiF2GQR6OBlpdSwiJml771s 0cqUtS+ORIu+HltNbC8zIDUqh2SkuVUB9qlxlGc3t5FyH5S61KBjwcUAKcDA3VuqqUh4G4 IDJhRzEdIgYq95Z8Gx5M3XFz97Ev+V0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH 5/7] tools/xenstored: support SET/GET_FEATURE commands Date: Tue, 22 Jul 2025 16:06:26 +0200 Message-ID: <20250722140628.28947-6-jgross@suse.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722140628.28947-1-jgross@suse.com> References: <20250722140628.28947-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Level: X-Spam-Flag: NO X-Rspamd-Queue-Id: F021C211A8 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCPT_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[suse.com:+] X-Spam-Score: -3.01 X-ZohoMail-DKIM: pass (identity @suse.com) (identity @suse.com) X-ZM-MESSAGEID: 1753193244675116600 Content-Type: text/plain; charset="utf-8" Add support for XS_SET_FEATURE and XS_GET_FEATURE to xenstored. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- tools/xenstored/core.c | 4 +++ tools/xenstored/domain.c | 60 ++++++++++++++++++++++++++++++++++++++++ tools/xenstored/domain.h | 8 ++++++ 3 files changed, 72 insertions(+) diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c index 37e4dd5a5b..3022efdce1 100644 --- a/tools/xenstored/core.c +++ b/tools/xenstored/core.c @@ -2031,6 +2031,10 @@ static struct { { "SET_TARGET", do_set_target, XS_FLAG_PRIV }, [XS_RESET_WATCHES] =3D { "RESET_WATCHES", do_reset_watches }, [XS_DIRECTORY_PART] =3D { "DIRECTORY_PART", send_directory_part }, + [XS_GET_FEATURE] =3D + { "GET_FEATURE", do_get_feature, XS_FLAG_PRIV }, + [XS_SET_FEATURE] =3D + { "SET_FEATURE", do_set_feature, XS_FLAG_PRIV }, }; =20 static const char *sockmsg_string(enum xsd_sockmsg_type type) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index f6d24bc13a..3969b82967 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -1244,6 +1244,66 @@ int do_reset_watches(const void *ctx, struct connect= ion *conn, return 0; } =20 +int do_get_feature(const void *ctx, struct connection *conn, + struct buffered_data *in) +{ + const char *vec[1]; + unsigned int n_args; + unsigned int domid; + const struct domain *domain; + unsigned int features; + char *result; + + n_args =3D get_strings(in, vec, ARRAY_SIZE(vec)); + if (n_args > 1) + return EINVAL; + + if (n_args =3D=3D 1) { + domid =3D atoi(vec[0]); + domain =3D find_or_alloc_existing_domain(domid); + if (!domain) + return ENOENT; + features =3D domain->features; + } else + features =3D XENSTORE_FEATURES; + + result =3D talloc_asprintf(ctx, "%u", features); + if (!result) + return ENOMEM; + + send_reply(conn, XS_GET_FEATURE, result, strlen(result) + 1); + + return 0; +} + +int do_set_feature(const void *ctx, struct connection *conn, + struct buffered_data *in) +{ + const char *vec[2]; + unsigned int domid; + struct domain *domain; + unsigned int features; + + if (get_strings(in, vec, ARRAY_SIZE(vec)) !=3D ARRAY_SIZE(vec)) + return EINVAL; + + domid =3D atoi(vec[0]); + features =3D atoi(vec[1]); + domain =3D find_or_alloc_existing_domain(domid); + if (!domain) + return ENOENT; + if (domain->introduced) + return EBUSY; + if (features & ~XENSTORE_FEATURES) + return EINVAL; + + domain->features =3D features; + + send_ack(conn, XS_SET_FEATURE); + + return 0; +} + static int close_xgt_handle(void *_handle) { xengnttab_close(*(xengnttab_handle **)_handle); diff --git a/tools/xenstored/domain.h b/tools/xenstored/domain.h index 8bfaca8f90..94481fdcc0 100644 --- a/tools/xenstored/domain.h +++ b/tools/xenstored/domain.h @@ -82,6 +82,14 @@ int do_get_domain_path(const void *ctx, struct connectio= n *conn, int do_reset_watches(const void *ctx, struct connection *conn, struct buffered_data *in); =20 +/* Get global or per domain server features */ +int do_get_feature(const void *ctx, struct connection *conn, + struct buffered_data *in); + +/* Set per domain server features */ +int do_set_feature(const void *ctx, struct connection *conn, + struct buffered_data *in); + void domain_early_init(void); void domain_init(int evtfd); void dom0_init(void); --=20 2.43.0