From nobody Thu Oct 30 23:06:16 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753143731; cv=pass; d=zohomail.com; s=zohoarc; b=YOZ12O6LDtEAbImoxfE0HcXfqskBE6c0F5VRok7kfT0Km4sOkhBJPcmw8Zpu1XR9y9uonaVJK+u5cIHQEVBv7BHsb+jiDwKB2cC4rNrnwiSPVJamj5mMMOqDXU6Omh8VodDJeCwAIkkFzlxXISfpquBM25xV9R72IZc1Is4LWPo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753143731; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=c75uJqg5nhBagpJJavUDY5wwNsouTt9h+tnycF+katg=; b=IQHyiWezvCJUOExu8B9m2sc/pAOKYeShipbtu0dXjXeACVzCaBgqSMUbglQxMGrS3pz+eCLkoRACK0UTsL0h4Y5MoQki8gIw9GXkmIe+JLZv8y/t9Ae2JVZKGQ3oj9LYfOONk5WKWFNFu5Ae3wrlbLlE/n0IAMiY2UomjQ5bGVg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753143731374973.6322794288768; Mon, 21 Jul 2025 17:22:11 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1051889.1420348 (Exim 4.92) (envelope-from ) id 1ue0lY-000814-4o; Tue, 22 Jul 2025 00:21:56 +0000 Received: by outflank-mailman (output) from mailman id 1051889.1420348; Tue, 22 Jul 2025 00:21:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ue0lY-00080w-0n; Tue, 22 Jul 2025 00:21:56 +0000 Received: by outflank-mailman (input) for mailman id 1051889; Tue, 22 Jul 2025 00:21:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ue0lW-0007zp-O4 for xen-devel@lists.xenproject.org; Tue, 22 Jul 2025 00:21:54 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20627.outbound.protection.outlook.com [2a01:111:f403:2415::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ddcc4017-6691-11f0-b894-0df219b8e170; Tue, 22 Jul 2025 02:21:52 +0200 (CEST) Received: from SJ0PR03CA0029.namprd03.prod.outlook.com (2603:10b6:a03:33a::34) by MW4PR12MB7288.namprd12.prod.outlook.com (2603:10b6:303:223::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.30; Tue, 22 Jul 2025 00:21:43 +0000 Received: from SJ1PEPF000026C8.namprd04.prod.outlook.com (2603:10b6:a03:33a:cafe::72) by SJ0PR03CA0029.outlook.office365.com (2603:10b6:a03:33a::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8943.29 via Frontend Transport; Tue, 22 Jul 2025 00:21:42 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SJ1PEPF000026C8.mail.protection.outlook.com (10.167.244.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Tue, 22 Jul 2025 00:21:42 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 21 Jul 2025 19:21:41 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 21 Jul 2025 19:21:41 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 21 Jul 2025 19:21:40 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddcc4017-6691-11f0-b894-0df219b8e170 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IPWJPRB8lWOPhgNff8bfhtvl0CxJHW7fX0GfBJWGMv4Ju78ELkhCv5iMIuJ7jiRHi3AWlzbZbRpwb3jietcoatRvCl4oJaT3CqHVQzHgtQvuAW//wT1yeiSOV52s/D9NIxAKZ97TMzEd99BsNGLGhDVLBi9ynhfRVmFXfiW8QTLegkBDZCAiAmmGL+wrPIiiYaM5xsYudEGE0uPv5psILiVdW/XuyTjqcON2QlBBw9wkaSuny74c+Yuf2nN1W9zK2FxmVzArLF+9jCdi12wAgJoySRvC/EFbWY/UAVgD2Jd6KZgMNbv7W1KZ6R7USMWq63BZ8UJtIUAuu3Ntdy13pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c75uJqg5nhBagpJJavUDY5wwNsouTt9h+tnycF+katg=; b=TNe7/XmThPcF/nym2FURsfsvziVcWYxMP1SL2tuvDZwk7hf4bVOT+lUUBFdRlpMOWldHu6t/KAMmGAUOJhzbpDfrOTnNCWu9p2Bl5Bu/XKj8g4D+xDHKEqsOEuUmG77bzmJGQcb2CAkBHknN8VP0Wt0IHLdE6+u1yQ1qeiaqad4+ASlosaypPMmOXCrlsB5pfWUeptt30+vkr75+GCX6nAJWXPRQTnD3ty8hAdCRAGTlwIPAM5KKKCTfm4oEL9P4zsM5JD60DehbBIkuiEFr8Y0vBqm2ghmGCgtGymV9+ZJVKl19GCsR3aTr2Br3b5etL2ZIXy9SGqwVdzg6WXg+bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c75uJqg5nhBagpJJavUDY5wwNsouTt9h+tnycF+katg=; b=wwapfVguBZUuSkWyfwCWhQ/nb4ytdeeiTYWZydQo8mdbawfjvcRik2x9PF8/ZmJOY60T+BIVyzXwj75iXpGzrJ1nlrWA3NeIYWcZf47wGYTajfp2BA8sDQO/bra+fRN6BPmsT7YRcirLMn5GFt8rkDzR2JqARtyYhX2fJCtLQYY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , "Julien Grall" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , "Juergen Gross" Subject: [PATCH v3 1/2] xen: Add capabilities to get_domain_state Date: Mon, 21 Jul 2025 20:19:57 -0400 Message-ID: <20250722001958.174294-2-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250722001958.174294-1-jason.andryuk@amd.com> References: <20250722001958.174294-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C8:EE_|MW4PR12MB7288:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e28da7b-8f04-4eb9-6f9f-08ddc8b5bc0f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?U3zbhWCMV+WKSlccFtvwkoASXH8v6saHlNHl+6HoTS2iSliI5MMPKGUJPrIK?= =?us-ascii?Q?HQasje/bvtY0UrIy/OsdiO73gf9llLDY/pkxxul4WZbh/SY/UlGh1rVFV4d0?= =?us-ascii?Q?GraeaCgX2wkieBos0+vxd/nT+mvYHB2ksqDNJjq15mDjs4XB+95703zWkrf5?= =?us-ascii?Q?NZJCz9f4SzzZZ3ALXFWlv+QMZ4AOKBYBTykbe5M3Pm9APB3aAFzl5StGK6dF?= =?us-ascii?Q?v7KFz34DxyYNfIDLF/KQ9djNCdbDuEKqqyOSz/lGfi0X23oqPet/a8cREqcc?= =?us-ascii?Q?/Il3K8dfAqBhfVIhqQrC361mo7K3dP8BvUstYw2M1spepcF2j39o484FiPRA?= =?us-ascii?Q?in8b3QHjRbuVADB4fE15Ob90/aNmQB2uqp/AihLkYyGAT8Sayu7lvn5nAMc9?= =?us-ascii?Q?fxW/plbQIHXJmbizbhpqaaG9kq2KEWHkux4G+zllWGOaO7UechYCeoUiEFQn?= =?us-ascii?Q?jAkE4Q5AQH8F6WagFHOZo1jtU9adrxFg/GqVVqA8RxJ0LDMI3tSl3sqHY2aT?= =?us-ascii?Q?VGF5G9/nYyFvo6JEk43o/vtVCKHJ9YlhCs0Z3P/MxS/cGt4hb9YocrnD+vbC?= =?us-ascii?Q?4qtjibuL6R3IbYT8yhfY0HdVZibiR2w6GujFvWF8T/7UDj3nG+qp1jP/+5jp?= =?us-ascii?Q?NNhsyDlpr4JVcGDrJFguyraDvoaX/rIc4FWEqj775zBI1rLIGurpdq8HcUlc?= =?us-ascii?Q?YuldYvXomXliuja+g6FjbrgmoocZEiIgoUgquGgSdF5r8tQ9UGBe1k4IK/DX?= =?us-ascii?Q?Ek0RAXch1FZ0vi1sn+i+3vlGITRfsTA5+KoA80YKiOW118/kUWoVZQOo4wEZ?= =?us-ascii?Q?MtSabfO80o97WcmwUImMfiYkNSk73PXXC79pEsO23H9xlKXI1E4ck/dUvxZy?= =?us-ascii?Q?ywIRwQBU0m4rYX9BY31taszaEzeMVAIXFqQxPKFJopGljyoV4OYKmm0BfDAq?= =?us-ascii?Q?+dRrQFOXnuAp1ot2VLCKAom+rXafofCojJBVVVMAY/Zt6Jk3gWnLYIwEcpJM?= =?us-ascii?Q?37DmvkvJy1y21TrFBepEtDLK/0CShmGgAVEF7iorbI2sC4M90Ri4vhADbCE0?= =?us-ascii?Q?VnqQbOxZ7bF48K4CkNd9xbDTvI85QDD5EAre6Y0TCrL+NozlE2q8WwuOz1oj?= =?us-ascii?Q?xBuOkAMjuOgdrTIl7CHtS3BBHZAF/yyGxHx1bZLi34sbdh0wd5ahnnQ9vWxt?= =?us-ascii?Q?dA266zDyMcaIvpj2Xvq4hNhhfllGT7pffBwUyDcNAAjlxHePlKMLe167vpuD?= =?us-ascii?Q?ZWa6JKHMChpE3bPbq0miiXZ6Oolmzwet3Zh7wa4tU1IE1iJZp4FoSFsjvlOf?= =?us-ascii?Q?flz/HgUD5oCys9MS2JXHaOJNjKPSpMZsDwwhA3FNaSJagNfQZrq1fJRooDL0?= =?us-ascii?Q?r4mwGuw3Fwu6vVTsYX3Yl9B09VYD8nomBFpl/IE77ehoWhy9E4ugn7pnkk/0?= =?us-ascii?Q?IzwslWPhKnvBlSstsj1xkRdB2Cl9G63+13SgfS5KnSUQ1myk0k7Qz4SKWbjM?= =?us-ascii?Q?OzER1E3lgWRa51me0uQyIDUzFz1c1DDzxONE?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2025 00:21:42.4900 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e28da7b-8f04-4eb9-6f9f-08ddc8b5bc0f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C8.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7288 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753143732257116600 Content-Type: text/plain; charset="utf-8" Expose a domain's capabilities - control, hardware or xenstore - through stable get domain state hypercall. The xenstore domain can use this information to assign appropriate permissions on connections. Repurpose the 16bit pad field for this purpose. Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Reviewed-by: Stefano Stabellini --- v2: Init info->caps =3D 0 Remove stale comment on caps field Add Juergen's R-b --- xen/common/domain.c | 10 +++++++++- xen/include/public/domctl.h | 7 +++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index c347de4335..bb33b1f1c7 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -195,6 +195,14 @@ static void set_domain_state_info(struct xen_domctl_ge= t_domain_state *info, info->state |=3D XEN_DOMCTL_GETDOMSTATE_STATE_DYING; if ( d->is_dying =3D=3D DOMDYING_dead ) info->state |=3D XEN_DOMCTL_GETDOMSTATE_STATE_DEAD; + + info->caps =3D 0; + if ( is_control_domain(d) ) + info->caps |=3D XEN_DOMCTL_GETDOMSTATE_CAP_CONTROL; + if ( is_hardware_domain(d) ) + info->caps |=3D XEN_DOMCTL_GETDOMSTATE_CAP_HARDWARE; + if ( is_xenstore_domain(d) ) + info->caps |=3D XEN_DOMCTL_GETDOMSTATE_CAP_XENSTORE; info->unique_id =3D d->unique_id; } =20 @@ -205,7 +213,7 @@ int get_domain_state(struct xen_domctl_get_domain_state= *info, struct domain *d, int rc =3D -ENOENT; struct domain *hdl; =20 - if ( info->pad0 || info->pad1 ) + if ( info->pad0 ) return -EINVAL; =20 if ( d ) diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index f1f6f96bc2..136820ea5b 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -1269,8 +1269,11 @@ struct xen_domctl_get_domain_state { #define XEN_DOMCTL_GETDOMSTATE_STATE_SHUTDOWN 0x0002 /* Shutdown finishe= d. */ #define XEN_DOMCTL_GETDOMSTATE_STATE_DYING 0x0004 /* Domain dying. */ #define XEN_DOMCTL_GETDOMSTATE_STATE_DEAD 0x0008 /* Domain dead. */ - uint16_t pad0; /* Must be 0 on input, returned as 0. */ - uint32_t pad1; /* Must be 0 on input, returned as 0. */ + uint16_t caps; +#define XEN_DOMCTL_GETDOMSTATE_CAP_CONTROL 0x0001 /* Control domain. = */ +#define XEN_DOMCTL_GETDOMSTATE_CAP_HARDWARE 0x0002 /* Hardware domain.= */ +#define XEN_DOMCTL_GETDOMSTATE_CAP_XENSTORE 0x0004 /* Xenstore domain.= */ + uint32_t pad0; /* Must be 0 on input, returned as 0. */ uint64_t unique_id; /* Unique domain identifier. */ }; =20 --=20 2.50.1 From nobody Thu Oct 30 23:06:16 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1753143724; cv=pass; d=zohomail.com; s=zohoarc; b=dl2t0dFFjnMItYRwDoJEmWxoS8cR7CBsArzi9z1r8lHbPG2PK+PGKxcQ6VxY4awehQRig/mzTxVtkB1PTvj5L5A/hKsHOKxXWd0wOATszsp8vG3iBy9jjqX7QVMd3O/dz1C+QK/KIAQtbdEig0CnnkMLx1+CN5hptlGHuX4Nsc8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753143724; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zsySDYkOolkoADalZ9dV3T28Txw0iA1RiUk37Ldbnck=; b=l04DbLHf4ty7gZK3jb+4mUEBQGbtOo5aIAzAG9JXtcn9OVN+x16tjjSVWlPLIFn6AGDXKzMGTEK9DXumylVUx9Vmzs5QAtW1p9skNVmFAV/YE9ww6BIUkGfzNlYh0NBG6/wM85on6Eq0Sgybt8RmE+k9PB4EHZuAY9phlDqznAQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753143723983190.97686096998962; Mon, 21 Jul 2025 17:22:03 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1051888.1420337 (Exim 4.92) (envelope-from ) id 1ue0lU-0007l6-SR; Tue, 22 Jul 2025 00:21:52 +0000 Received: by outflank-mailman (output) from mailman id 1051888.1420337; Tue, 22 Jul 2025 00:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ue0lU-0007kz-Pj; Tue, 22 Jul 2025 00:21:52 +0000 Received: by outflank-mailman (input) for mailman id 1051888; Tue, 22 Jul 2025 00:21:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ue0lT-0007Wn-Nz for xen-devel@lists.xenproject.org; Tue, 22 Jul 2025 00:21:51 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062b.outbound.protection.outlook.com [2a01:111:f403:2412::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc0ff7fe-6691-11f0-a31d-13f23c93f187; Tue, 22 Jul 2025 02:21:51 +0200 (CEST) Received: from MN0PR04CA0030.namprd04.prod.outlook.com (2603:10b6:208:52d::29) by SA3PR12MB9178.namprd12.prod.outlook.com (2603:10b6:806:396::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.30; Tue, 22 Jul 2025 00:21:44 +0000 Received: from BN2PEPF000044AC.namprd04.prod.outlook.com (2603:10b6:208:52d:cafe::d1) by MN0PR04CA0030.outlook.office365.com (2603:10b6:208:52d::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8943.29 via Frontend Transport; Tue, 22 Jul 2025 00:21:43 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000044AC.mail.protection.outlook.com (10.167.243.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8964.20 via Frontend Transport; Tue, 22 Jul 2025 00:21:43 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 21 Jul 2025 19:21:43 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 21 Jul 2025 19:21:42 -0500 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 21 Jul 2025 19:21:42 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc0ff7fe-6691-11f0-a31d-13f23c93f187 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gFjdgDHiHs1tUzCoeYYsqPszXyxR9OdaV1Gn0dpoIqsdnc1Ketzp/hmPoBY8NTDgWQ8ZMp/jDG84CQAM0l7kMKffQkpoUiXtck9bCMR8Df9O5qO4pGMzqZBx3h4tC9h45mqsUhQJqi2+fCT9q74bhoXO9j45VWOTKg0rwSicoMjBQBZR4vgHvN2mJGmn3EKkegBlexdEWNbrQrwhUc5NkO7rdpd7qq7SZ4RwRjNQMjwlWmZibgaj71MUZkUAf7emvhSzpqshCxKWNGtCS0bmAEgVAF7gttzqt+qUb5Uim9mmfMpYau3uEmHif75pb6zj117jexTsudCYNGrmB29U8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zsySDYkOolkoADalZ9dV3T28Txw0iA1RiUk37Ldbnck=; b=hlD74L/dmQQ9fTFt+NbAtexE/tVA3gtF2uqvbG4/8NO4gc8u5949VugELa3BjLtEka68WfP2CIYKf7IHoro3VGbEY+vPKzSDkjrY2lvSB6A5ycG3ZDwacvq85f/Nl7FtBU3PmakdYE/GRaTQUaGSqViI8DEBFSY7vxtZul/CR892qAM2ShhIYWwW0EiY8ZBM40Y9Y5+tmzCpS7mVB81v/pNGxRW1XR/5SEHF9FXLz1Czp67hZXW7S15jgqxC/1yJZH9h8OkF7T05+bwhM+FDRpTObhmC0R/DlSiYzP6QNM8MviDqouaAMYN0ihj0s62YoOD7FowZvGKVjvDEUXgSUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zsySDYkOolkoADalZ9dV3T28Txw0iA1RiUk37Ldbnck=; b=r2A7A6ij2g8ox7zz2gbpS4zfkBWfdW0DVKFN5Gjzq4laPaLR6f79fui25C6mFxbHwzYtQGhVA5hPZQOk8Hb5yq74KyP4Jojgk+W2zmN6ba8EGe0izCDr/SAOcidbAv6SJbj+UdSZRccF1aukFenIZ5ofAysAmPAWPQtZnxnV5NU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD , Juergen Gross , Julien Grall Subject: [PATCH v3 2/2] tools/manage: Expose domain capabilities Date: Mon, 21 Jul 2025 20:19:58 -0400 Message-ID: <20250722001958.174294-3-jason.andryuk@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250722001958.174294-1-jason.andryuk@amd.com> References: <20250722001958.174294-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044AC:EE_|SA3PR12MB9178:EE_ X-MS-Office365-Filtering-Correlation-Id: 0afff553-3b3e-4a5c-12d1-08ddc8b5bc7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IRI62enX/JNZTidcFo9vOdutIXrP+PF5qh7asKBtkXQcIk5tHVIqrDUNf8V4?= =?us-ascii?Q?LS4zw8QVzp+UoO32mRfseK4Wvl1oYsVBR8ODaVGv4CAzkcxmanY1nFxCCj0W?= =?us-ascii?Q?ZoS36IewrmKbNpnMr4uRSiqCosrRbLHEI2wfXzwfUrQLAgjP/FibBoGeN/Dy?= =?us-ascii?Q?XakIeHa4TP3ZUnnWOORmSlXVKFPXzQmuqh6CyPcsE5ph84v3bIa4TfXI1yql?= =?us-ascii?Q?BI7VrwGZVke4GZG0wDA8i/gALhVQhWuusRW73++Jte5wFvY8EbC7IOXDZMMo?= =?us-ascii?Q?IegDTmc+jsnkIBZOK+QGnBV0YrJgsEiwOHyCgLqoLULsEuNhZ4RgCfXx7ZSW?= =?us-ascii?Q?seKDpm/gVZ6bEphi4YT9rNosI30nBhdaV3hvL8xTDqVFUOBADrvdKG0j5PNx?= =?us-ascii?Q?OmYt7o/yHL9bzN875dFXXwccPly1qXqkusIY1yHaFHi5qAnO2r7QWKEo7fRW?= =?us-ascii?Q?R29pKBHqCfo6B+227OVxH5/VO0ZAtB9E0t8gm20uldmTme2WmAniu9HVMIgU?= =?us-ascii?Q?ZdfPanx0OFLN7AYfwOnJ8crTIn5n4ZPH7Nteijltl9PxI0Se4zM/FstAS4+R?= =?us-ascii?Q?m8vYeQAIdVkmlc69V66sYXqVsaWaNNhriIywMQGFRy73+K7zu3J5WfPrzM2b?= =?us-ascii?Q?xFzJ8KKDA1IyLDEtFKoLH3gvi4dD0V+o5UZCCApVjtrYUpnjXmea1/ACnkQI?= =?us-ascii?Q?FoEExAVL+tkBZxgg8yjZF5w8qKLWv3ZXtLhaxThjpeN/b5SyoJhwnEBsUTHL?= =?us-ascii?Q?/RirREbhsgdb9QiAcMeYyMUce6mtmpop5p0oMzCYELs2CxaDyucKS+FKjzq9?= =?us-ascii?Q?RgPPKGl7AWbFaZTk3H/HRugW/HCqiXB+THjrguOE1RDcSucHRmX7v/5izvAA?= =?us-ascii?Q?R7a2b28I8wQhw/j5T8HnwVQAHm4DBVeFkfMHAuUH99ivcpLwjQJm8akoHvle?= =?us-ascii?Q?QyKDWonOmdqRmBEfYg53+sFC8G+KR3ptn54Hqo+J+PuiAFlWvHOS84cOJLeH?= =?us-ascii?Q?11RAfCf/gPe4XVFlXfh5mNr7N8Ywxww4ovlXiZJhijIo2vE/14hI9TRsrQyW?= =?us-ascii?Q?OObNWXmut7SrADy38D940e4FMGu/bQuOkUMoel/cf5HbBQEjUtYKqUWjEdEL?= =?us-ascii?Q?GN32gq5uH/mJvonG8VbXJuq5E9QzDBHRmgbX9Pp5qjcglPm0yCiWnNpgr09n?= =?us-ascii?Q?IUz/1p7cDd4gyJX94r8tAeGSQLqbKNkv4nrvQRQAMSkvlPwcX8C3WFb56C2l?= =?us-ascii?Q?hqAPBtmw7SNictXwCkmnki6VhB6zVhsbCC7kwBWargjTnOGv/aLN+gXsnnD9?= =?us-ascii?Q?AjKxws6v6/2Oo9TPdx3Zmf+20JN6iVMas1FjZNZzDSJ3qw/oCkROpoEKnjbt?= =?us-ascii?Q?MV9ntrWbpQaNimD3pH5NeaZxp0mE8KJSKjvCOM6I7qKDsxZu9eQaOCvhWj4w?= =?us-ascii?Q?AD9KhCEb3QqMgrapOoNtTrJfoh9Iri2+fNUdc4rbT67lQDgJs7s2vxOc4Vt3?= =?us-ascii?Q?JRk/lI4KlTDHVUhzUASpQ9uvQRktC8MJHXph?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2025 00:21:43.3066 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0afff553-3b3e-4a5c-12d1-08ddc8b5bc7e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044AC.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9178 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1753143726303116600 Content-Type: text/plain; charset="utf-8" Add an additional "caps" argument to the libxenmanage functions to obtain a domains capabilities - control, hardware, and xenstore. Update the xenstored callers at the same time. Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross --- v2: Add Juergen's R-b --- tools/include/xenmanage.h | 14 ++++++++++++-- tools/libs/manage/core.c | 21 +++++++++++++++++---- tools/xenstored/domain.c | 8 ++++---- 3 files changed, 33 insertions(+), 10 deletions(-) diff --git a/tools/include/xenmanage.h b/tools/include/xenmanage.h index 956b7a0a44..6fc0d9fe24 100644 --- a/tools/include/xenmanage.h +++ b/tools/include/xenmanage.h @@ -45,6 +45,12 @@ int xenmanage_close(xenmanage_handle *hdl); #define XENMANAGE_GETDOMSTATE_STATE_DYING 0x0004 /* Domain dying. */ #define XENMANAGE_GETDOMSTATE_STATE_DEAD 0x0008 /* Domain dead. */ =20 +/* Control Domain capability. */ +#define XENMANAGE_GETDOMSTATE_CAP_CONTROL 0x0001 +/* Hardware Domain capability. */ +#define XENMANAGE_GETDOMSTATE_CAP_HARDWARE 0x0002 +/* Xenstore Domain capability. */ +#define XENMANAGE_GETDOMSTATE_CAP_XENSTORE 0x0004 /* * Return state information of an existing domain. * @@ -59,7 +65,8 @@ int xenmanage_close(xenmanage_handle *hdl); * Return value: 0 if information was stored, -1 else (errno is set) */ int xenmanage_get_domain_info(xenmanage_handle *hdl, unsigned int domid, - unsigned int *state, uint64_t *unique_id); + unsigned int *state, unsigned int *caps, + uint64_t *unique_id); =20 /* * Return information of a domain having changed state recently. @@ -73,12 +80,15 @@ int xenmanage_get_domain_info(xenmanage_handle *hdl, un= signed int domid, * domid: where to store the domid of the domain (not NULL) * state: where to store the state (XENMANAGE_GETDOMSTATE_STATE_ fla= gs, * nothing stored if NULL) + * caps: where to store the capabilities (XENMANAGE_GETDOMSTATE_CAP_ + * flags, nothing stored if NULL) * unique_id: where to store the unique id of the domain (nothing stored= if * NULL) * Return value: 0 if information was stored, -1 else (errno is set) */ int xenmanage_poll_changed_domain(xenmanage_handle *hdl, unsigned int *dom= id, - unsigned int *state, uint64_t *unique_id= ); + unsigned int *state, unsigned int *caps, + uint64_t *unique_id); #endif /* XENMANAGE_H */ =20 /* diff --git a/tools/libs/manage/core.c b/tools/libs/manage/core.c index 8fb421df41..2fabdecaab 100644 --- a/tools/libs/manage/core.c +++ b/tools/libs/manage/core.c @@ -92,6 +92,7 @@ static int xenmanage_do_domctl_get_domain_state(xenmanage= _handle *hdl, unsigned int domid_in, unsigned int *domid_out, unsigned int *state, + unsigned int *caps, uint64_t *unique_id) { struct xen_domctl *buf; @@ -130,6 +131,16 @@ static int xenmanage_do_domctl_get_domain_state(xenman= age_handle *hdl, if ( st->state & XEN_DOMCTL_GETDOMSTATE_STATE_DEAD ) *state |=3D XENMANAGE_GETDOMSTATE_STATE_DEAD; } + if ( caps ) + { + *caps =3D 0; + if ( st->caps & XEN_DOMCTL_GETDOMSTATE_CAP_CONTROL ) + *caps |=3D XENMANAGE_GETDOMSTATE_CAP_CONTROL; + if ( st->caps & XEN_DOMCTL_GETDOMSTATE_CAP_HARDWARE ) + *caps |=3D XENMANAGE_GETDOMSTATE_CAP_HARDWARE; + if ( st->caps & XEN_DOMCTL_GETDOMSTATE_CAP_XENSTORE ) + *caps |=3D XENMANAGE_GETDOMSTATE_CAP_XENSTORE; + } if ( unique_id ) *unique_id =3D st->unique_id; } @@ -142,7 +153,8 @@ static int xenmanage_do_domctl_get_domain_state(xenmana= ge_handle *hdl, } =20 int xenmanage_get_domain_info(xenmanage_handle *hdl, unsigned int domid, - unsigned int *state, uint64_t *unique_id) + unsigned int *state, unsigned int *caps, + uint64_t *unique_id) { if ( !hdl || domid >=3D DOMID_FIRST_RESERVED ) { @@ -150,12 +162,13 @@ int xenmanage_get_domain_info(xenmanage_handle *hdl, = unsigned int domid, return -1; } =20 - return xenmanage_do_domctl_get_domain_state(hdl, domid, NULL, state, + return xenmanage_do_domctl_get_domain_state(hdl, domid, NULL, state, c= aps, unique_id); } =20 int xenmanage_poll_changed_domain(xenmanage_handle *hdl, unsigned int *dom= id, - unsigned int *state, uint64_t *unique_id) + unsigned int *state, unsigned int *caps, + uint64_t *unique_id) { if ( !hdl || !domid ) { @@ -164,5 +177,5 @@ int xenmanage_poll_changed_domain(xenmanage_handle *hdl= , unsigned int *domid, } =20 return xenmanage_do_domctl_get_domain_state(hdl, DOMID_INVALID, domid, - state, unique_id); + state, caps, unique_id); } diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index 5ca40e7d6b..1241f8c73e 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -667,7 +667,7 @@ static int check_domain(const void *k, void *v, void *a= rg) unsigned int state; uint64_t unique_id; =20 - if (xenmanage_get_domain_info(xm_handle, domain->domid, &state, + if (xenmanage_get_domain_info(xm_handle, domain->domid, &state, NULL, &unique_id)) { unique_id =3D 0; state =3D 0; @@ -700,7 +700,7 @@ static void do_check_domains(void) struct domain *domain; bool notify =3D false; =20 - while (!xenmanage_poll_changed_domain(xm_handle, &domid, &state, + while (!xenmanage_poll_changed_domain(xm_handle, &domid, &state, NULL, &unique_id)) { domain =3D find_domain_struct(domid); if (domain) @@ -829,7 +829,7 @@ static struct domain *find_or_alloc_existing_domain(uns= igned int domid) domain =3D find_domain_struct(domid); if (!domain || !domain->unique_id) dom_valid =3D !xenmanage_get_domain_info(xm_handle, domid, - NULL, &unique_id); + NULL, NULL, &unique_id); =20 if (dom_valid) { if (!domain) @@ -1381,7 +1381,7 @@ int domain_alloc_permrefs(struct node_perms *perms) domid =3D perms->p[i].id; d =3D find_domain_struct(domid); if (!d) { - if (xenmanage_get_domain_info(xm_handle, domid, + if (xenmanage_get_domain_info(xm_handle, domid, NULL, NULL, &unique_id)) perms->p[i].perms |=3D XS_PERM_IGNORE; else if (!alloc_domain(NULL, domid, unique_id)) --=20 2.50.1