From nobody Fri Oct 31 04:01:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1752586223; cv=none; d=zohomail.com; s=zohoarc; b=baliAyBQcCysQbW9gXr5pqjIUQ1FW5ySKt/w6B1C6bsbHIcBfLqC5k9tb9gkeWKEOBHUerfCaqAvopzgVwem1Q6bv/+3rYj6HrQ8TdtJJzaVEpKHSirJGwnmeH6qfJEVOjFwIX/2XbjCNB2pA0K4M9t1wN6aU3WtPJmNEh128sw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752586223; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ycMxB7C6V9MFY6iKdrBuAK81Hin6bWQs2JTEO7PYpys=; b=ExYT7HpbtuD28wBiVadfNwt0ZgvOG53YIhQl8IHQOgtlqEeN8U4zSemz+p25HRJLlwf20yYqj5MWJDXNn1kpSD/JSrTbQWEh28M+tSZYEzS9blnru69ar51hEyb3n0WhRFlpzNqCXEzh3+jMpyKYbt4yCUQJJQIMCHolx/JuO4w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1752586223486205.84803653927872; Tue, 15 Jul 2025 06:30:23 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1044135.1414267 (Exim 4.92) (envelope-from ) id 1ubfjU-0003Bz-Sk; Tue, 15 Jul 2025 13:30:08 +0000 Received: by outflank-mailman (output) from mailman id 1044135.1414267; Tue, 15 Jul 2025 13:30:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ubfjU-0003Br-PJ; Tue, 15 Jul 2025 13:30:08 +0000 Received: by outflank-mailman (input) for mailman id 1044135; Tue, 15 Jul 2025 13:30:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ubfjU-0000p6-4O for xen-devel@lists.xenproject.org; Tue, 15 Jul 2025 13:30:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2a07:de40:b251:101:10:150:64:2]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1838779-617f-11f0-b894-0df219b8e170; Tue, 15 Jul 2025 15:30:05 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EE8DC1F769; Tue, 15 Jul 2025 13:30:04 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B51FE13A68; Tue, 15 Jul 2025 13:30:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qfKzKtxXdmhGNwAAD6G6ig (envelope-from ); Tue, 15 Jul 2025 13:30:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1838779-617f-11f0-b894-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1752586205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ycMxB7C6V9MFY6iKdrBuAK81Hin6bWQs2JTEO7PYpys=; b=qqG6dvE7L1PDj++98MXqGAx0S7cMJxl9K6qe5gXUiQJaZG2N+vIuoXh1FO9KrxRHDvRtr4 XOgfOcSftBy1DhQ0Ku3dQb3Uy05lgjXoRwfG57ieVoTVLErKKemZOWdUpRDhBV1X28laSZ +bQFeGCMQKAeaC7GrHKw+aHXXFjRzzw= Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1752586204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ycMxB7C6V9MFY6iKdrBuAK81Hin6bWQs2JTEO7PYpys=; b=kkmlP9MVsCHJRKFCUH9ZVd4oSIdSs5Gn3UWppI4+dwSycpDZVLX4Ti7Wxe1LoIkx8imK7s /TU46f/wnH3E5uNsdb4ssw5/pARLU7DMvO/pWah8jXnsPVQzK63rqJ1bR23k9R/Ha16Hih v8j1hGkWJH3nmh3ZcMVXZfcWfCkfgTQ= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, Juergen Gross , Jason Andryuk Subject: [MINI-OS PATCH v2 04/14] kexec: restructure building the start info data Date: Tue, 15 Jul 2025 15:29:26 +0200 Message-ID: <20250715132936.2798-5-jgross@suse.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250715132936.2798-1-jgross@suse.com> References: <20250715132936.2798-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[amd.com:email,imap1.dmz-prg2.suse.org:helo,suse.com:mid,suse.com:email]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO X-Spam-Level: X-Spam-Score: -2.80 X-ZohoMail-DKIM: pass (identity @suse.com) (identity @suse.com) X-ZM-MESSAGEID: 1752586224473116600 Content-Type: text/plain; charset="utf-8" Instead of setting most of the struct hvm_start_info fields first and then building the leaf data, restructure kexec_get_entry() by using an opaque "next" pointer where the next leaf data will be stored and handle that leaf data together with the associated hvm_start_info fields. This will make it easier to add new data items without having to rewrite large portions of the function. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- arch/x86/kexec.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/arch/x86/kexec.c b/arch/x86/kexec.c index d0af460d..29f8aa81 100644 --- a/arch/x86/kexec.c +++ b/arch/x86/kexec.c @@ -215,6 +215,7 @@ void kexec_set_param_loc(const char *cmdline) =20 int kexec_get_entry(const char *cmdline) { + void *next; struct hvm_start_info *info; struct hvm_memmap_table_entry *mmap; unsigned int order; @@ -229,16 +230,17 @@ int kexec_get_entry(const char *cmdline) if ( !kexec_param_mem ) return ENOMEM; =20 - info =3D (struct hvm_start_info *)kexec_param_mem; + next =3D (void *)kexec_param_mem; + + info =3D next; memset(info, 0, sizeof(*info)); info->magic =3D XEN_HVM_START_MAGIC_VALUE; info->version =3D 1; - info->cmdline_paddr =3D kexec_param_pa + sizeof(*info) + - e820_entries * sizeof(struct hvm_memmap_table_en= try); - info->memmap_paddr =3D kexec_param_pa + sizeof(*info); - info->memmap_entries =3D e820_entries; + next =3D info + 1; =20 - mmap =3D (struct hvm_memmap_table_entry *)(info + 1); + mmap =3D next; + info->memmap_paddr =3D kexec_param_pa + (unsigned long)next - kexec_pa= ram_mem; + info->memmap_entries =3D e820_entries; for ( i =3D 0; i < e820_entries; i++ ) { mmap->addr =3D e820_map[i].addr; @@ -246,8 +248,10 @@ int kexec_get_entry(const char *cmdline) mmap->type =3D e820_map[i].type; mmap++; } + next =3D mmap; =20 - strcpy((char *)mmap, cmdline); + info->cmdline_paddr =3D kexec_param_pa + (unsigned long)next - kexec_p= aram_mem; + strcpy(next, cmdline); =20 if ( kexec_add_action(KEXEC_COPY, to_virt(kexec_param_pa), info, kexec_param_size) ) --=20 2.43.0