From nobody Fri Oct 31 03:57:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1752586892; cv=none; d=zohomail.com; s=zohoarc; b=IXmz7N+5VtSrNKCu0kNQjCjUc4eSQgfKC1U3AKhv6/tX15/OB1Gruox3O0kdF3yZrlZqa0/aCrfPPC3/1fSEqWp74DqRHyrG1Rm0pPXwuMI/QJnQF7n2f/bvgWijTCjKe7iI+fu49k8N/03v1kPwv9PYOpclwhbdqdkadv1sjPo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752586892; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GLfH1LKxnn3oOigKVk3XV6ShMXvMzS6b7PXnQ2kQXXs=; b=f68VAz95D1G96BNkiqjdzU5AJk4hqTLz4B/AG5/iDKzS0vk+C+EAW6rpKj7b/YFkAoHCaIAGEhVvlu5DYXhWj0Jw5Q10G8aIPL5naNEnpmQ0ozjQGPX6HUOrxf8vpKA5cZcdvpqTZARtN8fw3MviLgVFCsNT1XVlZ37jXx9q48w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1752586892231516.1858679086031; Tue, 15 Jul 2025 06:41:32 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1044281.1414351 (Exim 4.92) (envelope-from ) id 1ubfuD-00028x-JT; Tue, 15 Jul 2025 13:41:13 +0000 Received: by outflank-mailman (output) from mailman id 1044281.1414351; Tue, 15 Jul 2025 13:41:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ubfuD-00028q-GY; Tue, 15 Jul 2025 13:41:13 +0000 Received: by outflank-mailman (input) for mailman id 1044281; Tue, 15 Jul 2025 13:41:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ubfk6-0000p6-4B for xen-devel@lists.xenproject.org; Tue, 15 Jul 2025 13:30:46 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8ecb76c-617f-11f0-b894-0df219b8e170; Tue, 15 Jul 2025 15:30:44 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4D18721239; Tue, 15 Jul 2025 13:30:44 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1D93113A68; Tue, 15 Jul 2025 13:30:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KgO3BQRYdmiXNwAAD6G6ig (envelope-from ); Tue, 15 Jul 2025 13:30:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8ecb76c-617f-11f0-b894-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1752586244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GLfH1LKxnn3oOigKVk3XV6ShMXvMzS6b7PXnQ2kQXXs=; b=p/7QFB4nJJxHcGoO0p90ZsKb8AQ/FSSiNolqN547AV75koHJ6BbNHONl0s8FKPY8SE2pJD 2BInMhZvaBE+aSacd8h0k1od6iUxKwCLJ/txB40uX9bJu7NlItJIxT4LUX/UreB545gOq+ MQdF0loPTarsPNO7ErzDs6qoyH05vL0= Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b="p/7QFB4n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1752586244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GLfH1LKxnn3oOigKVk3XV6ShMXvMzS6b7PXnQ2kQXXs=; b=p/7QFB4nJJxHcGoO0p90ZsKb8AQ/FSSiNolqN547AV75koHJ6BbNHONl0s8FKPY8SE2pJD 2BInMhZvaBE+aSacd8h0k1od6iUxKwCLJ/txB40uX9bJu7NlItJIxT4LUX/UreB545gOq+ MQdF0loPTarsPNO7ErzDs6qoyH05vL0= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, Juergen Gross , Jason Andryuk Subject: [MINI-OS PATCH v2 11/14] gnttab: remove gnttab_alloc_and_grant() function Date: Tue, 15 Jul 2025 15:29:33 +0200 Message-ID: <20250715132936.2798-12-jgross@suse.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250715132936.2798-1-jgross@suse.com> References: <20250715132936.2798-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.com:+]; RCPT_COUNT_FIVE(0.00)[5]; DBL_BLOCKED_OPENRESOLVER(0.00)[amd.com:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.com:mid,suse.com:dkim,suse.com:email] X-Spam-Flag: NO X-Spam-Level: X-Rspamd-Queue-Id: 4D18721239 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -3.01 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1752586892874116600 Content-Type: text/plain; charset="utf-8" The last user of gnttab_alloc_and_grant() is gone. Remove gnttab_alloc_and_grant() as it is doing more harm than good. It is hard coded to only grant access for dom0, which is not really clear from looking at the function name. It would be possible to add a domid parameter, but given its now 0 users, there doesn't seem to be a real demand for that function. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- gnttab.c | 13 ------------- include/gnttab.h | 1 - 2 files changed, 14 deletions(-) diff --git a/gnttab.c b/gnttab.c index 5b04ab01..6bac0905 100644 --- a/gnttab.c +++ b/gnttab.c @@ -149,19 +149,6 @@ gnttab_end_transfer(grant_ref_t ref) } EXPORT_SYMBOL(gnttab_end_transfer); =20 -grant_ref_t -gnttab_alloc_and_grant(void **map) -{ - unsigned long mfn; - grant_ref_t gref; - - *map =3D (void *)alloc_page(); - mfn =3D virt_to_mfn(*map); - gref =3D gnttab_grant_access(0, mfn, 0); - return gref; -} -EXPORT_SYMBOL(gnttab_alloc_and_grant); - static const char * const gnttabop_error_msgs[] =3D GNTTABOP_error_msgs; =20 const char * diff --git a/include/gnttab.h b/include/gnttab.h index 974cb89d..108c4425 100644 --- a/include/gnttab.h +++ b/include/gnttab.h @@ -4,7 +4,6 @@ #include =20 void init_gnttab(void); -grant_ref_t gnttab_alloc_and_grant(void **map); grant_ref_t gnttab_grant_access(domid_t domid, unsigned long frame, int readonly); grant_ref_t gnttab_grant_transfer(domid_t domid, unsigned long pfn); --=20 2.43.0