From nobody Fri Oct 31 09:27:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1748955152; cv=none; d=zohomail.com; s=zohoarc; b=NUjratxQhvMnTWg49tP9L1zIq1mU/+ukTiVN/bOmH+ZLyBOLFJXYQ6og2VzEThDhlvxXjMj6LYycjZbeYG48WthxVD+Dh2o7vo3BTRtmM17e0vW6IPQBfpGeLEzmlptMu8Qlqo0XVCfsnTnj1fa4UtcxA7MWwP96xXMedsKU39c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748955152; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EjLawBkFdZCmVWxeleotfU9HS3zYkrhDKjmwvUJc1RI=; b=h84UJ8XsWULfgFjEasY8g6vTZDIyM85kT+oC0N2UYgzQTW7oNJKL1//7FfltUlkN8Mnd+n7kC9daPOF5sIc3ec6lqJWCbhMsndgidn3olfG/dBPfxI029KeI7HHQnXOIGUWIie+/3W2Izu7ET3b6tTp56G3lXwROSj/vO0uIIXs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1748955152597680.0440648836526; Tue, 3 Jun 2025 05:52:32 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1004348.1384077 (Exim 4.92) (envelope-from ) id 1uMR7t-0004NZ-Qh; Tue, 03 Jun 2025 12:52:21 +0000 Received: by outflank-mailman (output) from mailman id 1004348.1384077; Tue, 03 Jun 2025 12:52:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uMR7t-0004NS-OB; Tue, 03 Jun 2025 12:52:21 +0000 Received: by outflank-mailman (input) for mailman id 1004348; Tue, 03 Jun 2025 12:52:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uMR7r-0004NK-SM for xen-devel@lists.xenproject.org; Tue, 03 Jun 2025 12:52:19 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9540f2e4-4079-11f0-a300-13f23c93f187; Tue, 03 Jun 2025 14:52:18 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-451d54214adso22204515e9.3 for ; Tue, 03 Jun 2025 05:52:18 -0700 (PDT) Received: from localhost.localdomain (host-92-26-98-202.as13285.net. [92.26.98.202]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe6ca46sm18586919f8f.31.2025.06.03.05.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 05:52:17 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9540f2e4-4079-11f0-a300-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1748955138; x=1749559938; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EjLawBkFdZCmVWxeleotfU9HS3zYkrhDKjmwvUJc1RI=; b=Z54Zb7jo+ROHSaK/CPdecyHh9z8OCqh6AF4+uq+aJgdFYCZkjb0+xZJbEveiBz1CMy vPW2WudUWVJOYfbgDVUWNJlS538nEAwIoSYw47BUULaZEUKq8Ef6U26SJs/49dgWmOPM xINsw6prUNd9k2qUfWHE+SlZAaMu2T41aKv0g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748955138; x=1749559938; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EjLawBkFdZCmVWxeleotfU9HS3zYkrhDKjmwvUJc1RI=; b=oYNWI5NrJkv2ueZTyr1HQF/yi1u4aVrholxdq7nhEduO1xz7DkdhLCjVT3wTN1IU3y +6z0YGzSX9puw3gReoSOePJB2Mq1BTgnKfCHkYDxuj5z2gl8fW/qky5RG4zW22FR4zkR G5c4wsIxPEdCqqIsjUS9rxE0amU1TnsG1FY+AvtYiIy1OBe4XgGZOVZkBsUHCfZmexUQ jtBuljaUuobZBHbypjVkIXtzANb5J8Wj8hncE+c2MTWUInh2LCSNC9aHfIMzBxqtZ+Bm YqYR5KHPuEdwwJzWPY3BF7iV+p7BqzjbfoewcB+54R2+pM1h/O2YbINJPoIgpxy6TK83 qz/A== X-Gm-Message-State: AOJu0Yy+Er898lV7s0M5b9i0TF7qg17CnBz0CyVLdymoEqakNtSjNHWF KruKqaBeHJuimyMNNhOhcf4Q6exfiM8mz9Hdv4ATSF/EfFKENgPYBR3cLP9lCgErjFcRkMiIJ1C NrV+c X-Gm-Gg: ASbGncvuFK16HcpFwns/kcy6hhIqdqEqKAieiZ7XiIadc8vU/lm4Ji9z9u4L7NjMcR+ wijX/DRDLiYlj8IUoQVloX0yrlRqyuBOCytl/hgAc4iQm4p6bFvKiy3Q7/N0ZHWYnAxlmqLzUdZ NGZRdwXIgAak3EGHfkF1ivD4oNsbrXdW2kwpDSV+fd0XJ4FbZ51dAR1R12FL2UACmFY1vtskwGP X6CuDYQWrv59ovVGD+t18UICa19/lshvIkB1t14i5/gAUB0yu2Nni77YQIz0uBtxQIFClNPt2hy e3DwCcCAywX16ffFK3Fili39tOD5tIuCmw+ZmuDQqv18IlUA5BM87tA2RdNIh6DcI9pC2ECpKlg CUpUIQfMRqS7VcfxnYggzt0iZ X-Google-Smtp-Source: AGHT+IFEms/kCWiCF0W/m/TTgfzKxA40SrJRUxWn9pZdxenYIibsBX2Yp5kC1Jib67+egtOccdmxHQ== X-Received: by 2002:adf:f34a:0:b0:3a4:f8e9:cee0 with SMTP id ffacd0b85a97d-3a4f8e9cf5cmr10768484f8f.40.1748955138087; Tue, 03 Jun 2025 05:52:18 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH] xen/kernel: Move parse_params() back into __init Date: Tue, 3 Jun 2025 13:52:15 +0100 Message-Id: <20250603125215.2716132-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1748955153581116600 It's non-init caller was dropped in Xen 4.14 No functional change. Fixes: 02e9a9cf2095 ("xen: remove XEN_SYSCTL_set_parameter support") Signed-off-by: Andrew Cooper Acked-by: Julien Grall --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini Found while reviewing the lockdown series, where an __init callee was added. It appears that GCC has inlined it into it's single caller (which is __init= ), and not emitted a non-__init form. --- xen/common/kernel.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index 8b63ca55f14f..5be668ba855a 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -67,8 +67,9 @@ static int assign_integer_param(const struct kernel_param= *param, uint64_t val) return 0; } =20 -static int parse_params(const char *cmdline, const struct kernel_param *st= art, - const struct kernel_param *end) +static int __init parse_params( + const char *cmdline, const struct kernel_param *start, + const struct kernel_param *end) { char opt[MAX_PARAM_SIZE], *optval, *optkey, *q; const char *p =3D cmdline, *key; base-commit: 2c4a3d688943b2034756859844b8337a5a97ce07 --=20 2.39.5