From nobody Fri Oct 31 11:33:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1748533850; cv=none; d=zohomail.com; s=zohoarc; b=jF6JU+83b0EcYHV7e/Y6T5ATcrTclQ/cjlYClvnikJ1q/h7X/IcdhP7sPNBl1754Dae/VS4ZhaCIrrSn+uq3OEdUQOfjHYWEEwy34ahiQf/I6Tl0ecGuFN0HSR+x3vdr4Qm3RimPxzNtwHiq1elkI7CsvxzXQWoOsxW7Yj3MC8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748533850; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VbUTwQzmmaewl5uonTpiY2JHveYiify6lhAK/r8MJhY=; b=Z3UXM8/zwEyaPNLFP38yRGysHNJHHLCkJmb1hTjRiUX0cC1jIqAWkGd9rQBkFo75PLWysU3BDe/4SP9Vgnc1z5GcPvHVc34H9qAxDqWIcnJrvYn/WJf9xHNOXe1BZT1lnr8hGjfpRTV1n9FMM1c28LnQUt4nhApR7eK/uE+B9BI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1748533850862841.8829717191819; Thu, 29 May 2025 08:50:50 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1000010.1380449 (Exim 4.92) (envelope-from ) id 1uKfWa-00072T-Aj; Thu, 29 May 2025 15:50:32 +0000 Received: by outflank-mailman (output) from mailman id 1000010.1380449; Thu, 29 May 2025 15:50:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uKfWa-00072M-64; Thu, 29 May 2025 15:50:32 +0000 Received: by outflank-mailman (input) for mailman id 1000010; Thu, 29 May 2025 15:50:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uKfWY-0006oV-7v for xen-devel@lists.xenproject.org; Thu, 29 May 2025 15:50:30 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a55c7f23-3ca4-11f0-a2ff-13f23c93f187; Thu, 29 May 2025 17:50:29 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-553280c345cso1424160e87.0 for ; Thu, 29 May 2025 08:50:29 -0700 (PDT) Received: from gmail.com (213-67-3-247-no600.tbcn.telia.com. [213.67.3.247]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-32a85bd29a2sm2999991fa.105.2025.05.29.08.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 08:50:27 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a55c7f23-3ca4-11f0-a2ff-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748533828; x=1749138628; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VbUTwQzmmaewl5uonTpiY2JHveYiify6lhAK/r8MJhY=; b=NIyUr3hApuoG9OW/Ee9j8PxmzIQZmPpJIc8sFX6zKW7WdYtMn85jpX5udTJiZQfUy9 gP/7lkRMdZoOJGWOBz9tAnc+B7In4Uq6jXUyv+OT/UWgVN4QJ7mcZNLBGvWx7ZaHwXdz 89QB2JQqYPNvNCvvVmSEAD3xnKJoA42XHOXK5AtX3uOsYyYtRqHvXLefdaBjayXMBnxU wEXY9R/zyNYLMCwKYz5jkWWAD+yTL3krALxLzatbiR+5VqxaKEFCvZxSb24HvGpExp6w B/0ITfuydYKESfjSHr1WM+GFZncsaVDb94bSYb7L+MsqzaYHm+IAkN1B4qfhEbVy5yOH Xnlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748533828; x=1749138628; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VbUTwQzmmaewl5uonTpiY2JHveYiify6lhAK/r8MJhY=; b=f+Rz1B7f1QwX1eBaTzaGepFRgc+yWiH+y+BieZlmnvutXZtYDsfWy+JUUGSRbq4tbh 6Ys2Dqi7UiO+STaQQmB/v9OGvGybphH7y2JJP/X7ZOey5L8xN7VsVjzys76LU7YksZAK DD+HQZ94SRSSRxEG3M5rzxCWAAvk0aDnplve75bwlMYkjunOr3dkNGGS6w6lIAUJMAVU FcD869fcYrEv5JRcawEHjgD2Xo95YwdFzCaBYjtbRVM3/+IMMLyeoslDmUlm3xHfeRCw TTkX38HQEIq9iTWOgMe/cG70e+Q5yGsKjzBVr8nedRgxh1ZucWRsHcjRyJLQwEKCcLyw VrUw== X-Gm-Message-State: AOJu0YzY6eZyxETsBK42fNVedSS4+G+6WDowy57wh3rDnMpCWzUHRWFa IAhKrZupsDk14uB+npTPK56HgWOYKDFY6fJYLLumnGKN6WOIfl8ZDmfFJLZwDxX+Prc= X-Gm-Gg: ASbGncvut19UwwSCYl9vD9uZ7zsvh+OC7wCNSBCz9ioOIFF8t8gJoDiCGKeQDbzx7rA aCOhimfqZ5sFiP9H5rdNjM12PFTIm6Et52nMp9pxVEg9oh2tnfQylPWbMqGtzr2HAZ6xplXA9i9 CffCnL40rAU4gue9fl0wuOXap86nMVs3zYY+HR3luw54ATceZcd7dDp0yL580HjoVzxNz5COxR7 bjjFaXKwvwSiKfphwVS22tt70ov2r/Mkl9bo4p3P3v6ZKDMc7XHiTZhbXcX3b+8NqBAInz+Y6tU PiaZAMDWSZWKx2F7KV3fjm/Y5rKsWj34ZF8jY1ndHumEeOGkz7eI8/BgmDDIVEu9GncecHXM1tD /aUsAl9WbMT9VyGFIkAdIuFvlBJgvt0dEKQ== X-Google-Smtp-Source: AGHT+IFscQ5zcDBfHcEEPM38Enf5fSV1b5NR14i4xCcjg/PtOY1YU11OlIFSUtrqUXzo2hAB0uU6BQ== X-Received: by 2002:a2e:a545:0:b0:32a:749a:14d4 with SMTP id 38308e7fff4ca-32a8cd46753mr1204501fa.12.1748533828080; Thu, 29 May 2025 08:50:28 -0700 (PDT) From: "Edgar E. Iglesias" To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, andrew.cooper3@citrix.com, edgar.iglesias@amd.com, Anthony PERARD , Juergen Gross , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 1/3] xen/arm: Add way to disable traps on accesses to unmapped addresses Date: Thu, 29 May 2025 17:50:21 +0200 Message-ID: <20250529155024.1284227-2-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250529155024.1284227-1-edgar.iglesias@gmail.com> References: <20250529155024.1284227-1-edgar.iglesias@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1748533853324116600 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add a per-domain way to optionally disable traps for accesses to unmapped addresses. The domain flag is general but it's only implemented for ARM for now. Signed-off-by: Edgar E. Iglesias --- tools/libs/light/libxl_arm.c | 3 +++ xen/arch/arm/dom0less-build.c | 3 +++ xen/arch/arm/domain.c | 3 ++- xen/arch/arm/domain_build.c | 3 ++- xen/arch/arm/io.c | 36 +++++++++++++++++++++++++++++++++-- xen/common/domain.c | 3 ++- xen/include/public/domctl.h | 4 +++- 7 files changed, 49 insertions(+), 6 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 75c811053c..9530996e72 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -233,6 +233,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, config->arch.sve_vl =3D d_config->b_info.arch_arm.sve_vl / 128U; } =20 + /* Trap accesses to unmapped areas. */ + config->flags |=3D XEN_DOMCTL_CDF_trap_unmapped_accesses; + return 0; } =20 diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index a49764f0ad..a4e0a33632 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -343,6 +343,9 @@ void __init arch_create_domUs(struct dt_device_node *no= de, panic("'sve' property found, but CONFIG_ARM64_SVE not selected\n"); #endif } + + /* Trap accesses to unmapped areas. */ + d_cfg->flags |=3D XEN_DOMCTL_CDF_trap_unmapped_accesses; } =20 int __init init_intc_phandle(struct kernel_info *kinfo, const char *name, diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 45aeb8bddc..be58a23dd7 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -612,7 +612,8 @@ int arch_sanitise_domain_config(struct xen_domctl_creat= edomain *config) unsigned int max_vcpus; unsigned int flags_required =3D (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_h= ap); unsigned int flags_optional =3D (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF= _vpmu | - XEN_DOMCTL_CDF_xs_domain ); + XEN_DOMCTL_CDF_xs_domain | + XEN_DOMCTL_CDF_trap_unmapped_accesses ); unsigned int sve_vl_bits =3D sve_decode_vl(config->arch.sve_vl); =20 if ( (config->flags & ~flags_optional) !=3D flags_required ) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b189a7cfae..7ff9c1b584 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2003,7 +2003,8 @@ void __init create_dom0(void) { struct domain *dom0; struct xen_domctl_createdomain dom0_cfg =3D { - .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, + .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap | + XEN_DOMCTL_CDF_trap_unmapped_accesses, .max_evtchn_port =3D -1, .max_grant_frames =3D gnttab_dom0_frames(), .max_maptrack_frames =3D -1, diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index 5a4b0e8f25..adfc822e7e 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -21,6 +21,32 @@ =20 #include "decode.h" =20 +/* Handler for unmapped ranges. Writes ignored, reads return all ones. */ +static int unmapped_read(struct vcpu *v, mmio_info_t *info, register_t *r, + void *priv) +{ + uint64_t mask =3D GENMASK_ULL((1U << info->dabt.size) * 8 - 1, 0); + + /* Mask off upper bits. */ + *r =3D UINT64_MAX & mask; + return 1; +} + +static int unmapped_write(struct vcpu *v, mmio_info_t *info, register_t r, + void *priv) +{ + return 1; +} + +static const struct mmio_handler_ops unmapped_ops =3D { + .read =3D unmapped_read, + .write =3D unmapped_write +}; + +static const struct mmio_handler unmapped_handler =3D { + .ops =3D &unmapped_ops +}; + static enum io_state handle_read(const struct mmio_handler *handler, struct vcpu *v, mmio_info_t *info) @@ -175,11 +201,17 @@ enum io_state try_handle_mmio(struct cpu_user_regs *r= egs, handler =3D find_mmio_handler(v->domain, info->gpa); if ( !handler ) { + bool trap_unmapped =3D v->domain->options & + XEN_DOMCTL_CDF_trap_unmapped_acce= sses; rc =3D try_fwd_ioserv(regs, v, info); if ( rc =3D=3D IO_HANDLED ) return handle_ioserv(regs, v); - - return rc; + else if ( rc =3D=3D IO_UNHANDLED && !trap_unmapped ) + { + /* Fallback to the unmapped handler. */ + handler =3D &unmapped_handler; + } else + return rc; } =20 /* diff --git a/xen/common/domain.c b/xen/common/domain.c index abf1969e60..ac4f58f638 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -721,7 +721,8 @@ static int sanitise_domain_config(struct xen_domctl_cre= atedomain *config) ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap | XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off | XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu | - XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) ) + XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu | + XEN_DOMCTL_CDF_trap_unmapped_accesses) ) { dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags); return -EINVAL; diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 5b2063eed9..be19ab5e26 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -66,9 +66,11 @@ struct xen_domctl_createdomain { #define XEN_DOMCTL_CDF_nested_virt (1U << _XEN_DOMCTL_CDF_nested_virt) /* Should we expose the vPMU to the guest? */ #define XEN_DOMCTL_CDF_vpmu (1U << 7) +/* Should we trap guest accesses to unmapped addresses? */ +#define XEN_DOMCTL_CDF_trap_unmapped_accesses (1U << 8) =20 /* Max XEN_DOMCTL_CDF_* constant. Used for ABI checking. */ -#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu +#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_trap_unmapped_accesses =20 uint32_t flags; =20 --=20 2.43.0 From nobody Fri Oct 31 11:33:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1748533848; cv=none; d=zohomail.com; s=zohoarc; b=jIBHkluxhUHARzwhX0sxzwEr7YLoIBrHSfb4f+Ttz4DCa169Bn5yuNtx48YCXGaQ6PNWyx5mMzAxCuOmYWSDDf23AJNXH4IXEL0Pkw+/2NlN86rZ4ihb/QbuJEA3AQJphsNjyARo9Jf+4uMCztaySFj35zYzsj7RAPSc1/OCh9w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748533848; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=m/ZAsDiyBEUJhyA3+Rgv4QwvFmR3/7Sm2UmwbErJIko=; b=FmVC1PRYcL7iniLMpg4fbiV1dcKc9ieZZPpax8inaHZGukDLGBwLG/fnQLNNIGPbiqkAvQZFGyDzpdWLBKUFnR//vKb6Y5rmlBjJrwTmOeZaP42kRDDT3PIYesxZ7XvEMDCf0WjhK089ofZgdzcYb6wDZuw8wBk1LdovjXj+Efg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 174853384889310.186002883262972; Thu, 29 May 2025 08:50:48 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1000011.1380454 (Exim 4.92) (envelope-from ) id 1uKfWa-00075m-LJ; Thu, 29 May 2025 15:50:32 +0000 Received: by outflank-mailman (output) from mailman id 1000011.1380454; Thu, 29 May 2025 15:50:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uKfWa-00075d-E2; Thu, 29 May 2025 15:50:32 +0000 Received: by outflank-mailman (input) for mailman id 1000011; Thu, 29 May 2025 15:50:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uKfWZ-0006oV-Jv for xen-devel@lists.xenproject.org; Thu, 29 May 2025 15:50:31 +0000 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [2a00:1450:4864:20::12e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a643580c-3ca4-11f0-a2ff-13f23c93f187; Thu, 29 May 2025 17:50:31 +0200 (CEST) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-553280c345cso1424197e87.0 for ; Thu, 29 May 2025 08:50:31 -0700 (PDT) Received: from gmail.com (213-67-3-247-no600.tbcn.telia.com. [213.67.3.247]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55337937bf7sm359434e87.254.2025.05.29.08.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 08:50:28 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a643580c-3ca4-11f0-a2ff-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748533830; x=1749138630; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m/ZAsDiyBEUJhyA3+Rgv4QwvFmR3/7Sm2UmwbErJIko=; b=Zt6B2JIRDMTTvW9FJqUXW/eeE5VCTF/OIo3XXoDoMLcMY6IUzOXhHOFBHSMgk4XF2K qgGs4cKnEvCtXPB9VQb0Nz3dqoONHNI+PWA7sm2JpxZbEsfm/8zUWWnzA1hMWwZTBd2W A61mJI7K8CnNfWGludJxAulzCQ4eWb7FAxWMW0GeAkJdw8jHvHtMRB5B/48NlYyWYOAw m3zRiu6RbYOUKkSE3xItT4j9vtdf+5gMDtCSKZ41fBRHb5kLdRS76mN7LRuQV8cKkaM6 jCV5vzAZpz1LQBeOIazrXjrXvRP0P+lZturKAoj0W0vet7ObL6CzKnl9Umvglp3+86/R ZXrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748533830; x=1749138630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m/ZAsDiyBEUJhyA3+Rgv4QwvFmR3/7Sm2UmwbErJIko=; b=A3zpQTpq69Hg1HRawq5YOatyxB68KciC0fn14RixE171zGzr5DiRo4utvtKFT1hyG3 NsCcxIVbO0ugXWaP45qnvlxt4MUKlQWwPx++iHpb75S9fivYLqB6hUznLz7KKsHoxU23 9wZbEqfZhBCVqv/j0wkisGlt4u5rOI+OY8gchd7G7930XfqDbEu9ra7Ydq9AQ0vbMViQ 4ZYiCx2FUxGMEuJsjJvSQBpUfw1P+aMRGTCgEq+YNX9c3eMLd4Oz/ue/0e8eIYCk4/tE xOo8YiggyyIPA96GblYOfg+90hT1f7roVLpr6XxsoZQqJS+R9iCMCY8uZxSeXFjdx3Eh etqA== X-Gm-Message-State: AOJu0Ywe+O6u1zoeET32AC2UuIoSRmZBBjsD2Xyj84eGFx4jVuS3GgB3 TwiTXzzfb3QvLd98/PGy1BkN23nJLt8dEO45w3CpZ4yboUVWNTV+ryQa80KX7Q6ze70= X-Gm-Gg: ASbGnctv4W8t/LaTjhqOoP7rq/Jr4Y3vDNu2odRxTmHjABjI9UN3OopxspkOlwAp7Jj VmuRztCHCh9U9kPt+6nPWnix54cb8/mUFa/3ATYuMjCCgPdvUpDYlBVF8Fnscz/MUutQVAIVUB0 89RHGoJBSaKxPaXgY22GRHxbKlDeDaMhqk5CGba7Gdgssu58ZUvMFp2scaDnZzMxtSBzcI1AGVd Uk/AgojGYtFtwgagn+UBdFxap+gh7sgpjl4O8atEAPc4ytIIL2HHAbU7AS/UI9HcVa1vr2sL00K klO85RMDuiLY+/b0iyNF9lMZz0GzCQp0c4l/JDLQEYkPlKjiWW1Pja2bqh/dAWnE6RuXoIumN5e 8lLpWn/b5JylprL/452k17es= X-Google-Smtp-Source: AGHT+IGa2r4D/VITSjdFBTxYkg6da0wYsZ2CMlkEQD6cZ8UUgLv8rIZMzxdmwr9D4pjVitwMZiA4/w== X-Received: by 2002:a05:6512:630f:b0:553:2357:2890 with SMTP id 2adb3069b0e04-55323572a08mr5344205e87.45.1748533830134; Thu, 29 May 2025 08:50:30 -0700 (PDT) From: "Edgar E. Iglesias" To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, andrew.cooper3@citrix.com, edgar.iglesias@amd.com Subject: [PATCH v2 2/3] xen/arm: dom0less: Add trap-unmapped-accesses Date: Thu, 29 May 2025 17:50:22 +0200 Message-ID: <20250529155024.1284227-3-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250529155024.1284227-1-edgar.iglesias@gmail.com> References: <20250529155024.1284227-1-edgar.iglesias@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1748533851198116600 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add the trap-unmapped-accesses per-domain fdt property. Signed-off-by: Edgar E. Iglesias --- docs/misc/arm/device-tree/booting.txt | 9 +++++++++ xen/arch/arm/dom0less-build.c | 9 ++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-t= ree/booting.txt index 59fa96a82e..8a5c40ddf3 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -225,6 +225,15 @@ with the following properties: option is provided with a non zero value, but the platform doesn't sup= port SVE. =20 +- trap-unmapped-accesses + + Optional. An integer that configures handling of accesses to unmapped + address ranges. + If set to 0, guest accesses will read 0xFFFFFFFF and writes will be ig= nored. + If set to 1, guest accesses will trap. + + This option is only implemented for ARM where the default is 1. + - xen,enhanced =20 A string property. Possible property values are: diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index a4e0a33632..69324aa597 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -344,8 +344,15 @@ void __init arch_create_domUs(struct dt_device_node *n= ode, #endif } =20 - /* Trap accesses to unmapped areas. */ + /* Trap unmapped accesses by default. */ d_cfg->flags |=3D XEN_DOMCTL_CDF_trap_unmapped_accesses; + if ( dt_property_read_u32(node, "trap-unmapped-accesses", &val) ) + { + if ( val > 1 ) + panic("trap-unmapped-accesses: supported values are 0 or 1"); + if ( !val ) + d_cfg->flags &=3D ~XEN_DOMCTL_CDF_trap_unmapped_accesses; + } } =20 int __init init_intc_phandle(struct kernel_info *kinfo, const char *name, --=20 2.43.0 From nobody Fri Oct 31 11:33:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1748533856; cv=none; d=zohomail.com; s=zohoarc; b=Lb9e1doNzdgzyEcjuQ4lDxjKs/Ri92TIXi6l3ipSH2iMry88Jc0yhHtafKgJC0o1Lag5rapvvIeX9A8H6xS/Y8kfkx9ySCVLtlqKhjIP0a5QekzEPD6S3igblnbpaDmSCxb70IOaWjXizmhCMkDrbhGbcSw2t5JtK4hAA+3SZHs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748533856; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tqOCJb7GRiVBBvisLzyRysHis/O4eLeaHxcKgZ0AZIA=; b=m6yOQp5RGvGsE/dQsuidZEa/BNPfs9N8DillOxjaIExITgAExore/ou93mYY0RvtELq9KuFFiPQfe0l6fNejUaSrVUIvyt08f66Ir9SQihbFvnNS4XMQK0X3AZ3p/lstnVCOSAD70IkCYgNWNF4slbtEliLc2XrTdOqIkH0G734= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1748533856585758.6360930582277; Thu, 29 May 2025 08:50:56 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1000012.1380468 (Exim 4.92) (envelope-from ) id 1uKfWd-0007Wv-VX; Thu, 29 May 2025 15:50:35 +0000 Received: by outflank-mailman (output) from mailman id 1000012.1380468; Thu, 29 May 2025 15:50:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uKfWd-0007Wm-Rm; Thu, 29 May 2025 15:50:35 +0000 Received: by outflank-mailman (input) for mailman id 1000012; Thu, 29 May 2025 15:50:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uKfWc-0007Vh-Vn for xen-devel@lists.xenproject.org; Thu, 29 May 2025 15:50:34 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a769275d-3ca4-11f0-b894-0df219b8e170; Thu, 29 May 2025 17:50:33 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-5532e0ad84aso1333445e87.2 for ; Thu, 29 May 2025 08:50:33 -0700 (PDT) Received: from gmail.com (213-67-3-247-no600.tbcn.telia.com. [213.67.3.247]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5533791ca53sm359962e87.162.2025.05.29.08.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 08:50:30 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a769275d-3ca4-11f0-b894-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748533832; x=1749138632; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tqOCJb7GRiVBBvisLzyRysHis/O4eLeaHxcKgZ0AZIA=; b=ko59lp1pcADCPjyIonyrKJ00bHjveyoXr/Sqr1y1XfXkLq9EBudYMP1StzXa12EYc5 Of+4BJc2ERzsgtFNZYpEZyAw3xqQP9aivvLMUMVg05u72Za1EAZW5bWkcXYJjLM0h0pp gvcRRveo9rrQPsgrzrXUJDHsn0oJKlAcNGpluPY3WbTWVw1b3j+dpuI8A1Nw9yMn2Bto 0ytiC4rIzzNclMOpuozw7OSChGgTtNpOvGODwfAZcGeu8gCHg9w9MVab8SLH1Cb4LoTz rVT6qM3XYeEge1Dvtd5NADx4ZfTd8PcBRG0GlZpYXxRnJaBnp9I/WvTBNvmlHE8bp58E AM8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748533832; x=1749138632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tqOCJb7GRiVBBvisLzyRysHis/O4eLeaHxcKgZ0AZIA=; b=ZClrXo3uedd71c1RAkTBj1C8rbB39DjWGMyyVLjn//R/c+mCEHm78YujDBef3GwyIt VzXvNBL3swwivVhkspqLeVd+jJl8PRllsG2doB5PJA2vpmHxQkyVFXWKSi5r/LZZ1veI GpNPxCwCENHG2wXwOBcbjM4Yl/NlBKwXfBDZJtgirtGhnqqRBAfWFIGuR7bPPnMfrB2y 6gNCmFSTCZlKbjsgwrshKZUEF+ioBliTpiHeXXms/7FFt+S1U7+6t61aXTF27H7q+hZs PYZ0j3JwolYDUMAUM55inrjfVfIU0qfJ2hcb13Muv/MDf9lrFwRYqp9SsLGz2UWic6R3 jb0A== X-Gm-Message-State: AOJu0YzTOM+74bpKaJtjS5tSQ/7tJdixrP8fjQt93YW8Yxe61vLsH1Kr UfGG9K03sQ4pZfL7xcAdQj3ZMXmABt++5AHF/jC9zcWM2RePQhEUh0+DVkx+NfvERzU= X-Gm-Gg: ASbGnctlWnOlYD+QK4LQG1d+M/4UcG5Rkz6D9pjev3bgqVhLmbwDjvkN5F3wEX68AWo WzhjvUm2RHskmIb3sKGM0qgVx+XC1LWQkuhtt1XgBxxgzIZ1RfW/NdXcjTwrAd0+n1BOGOwl4oh xfv9G8LuFH6UwJXDbQwXxyfRasK2Mj/bGIqNE8Zd7y8MBNFYDrCpF0eUooZP1k41CypevzZsKZo oi66NjixOnqKgfcSklvsuKmhhL8hT66WsVaS9mLMKp8zzB7T9/QWg2SbwAAyQD+S/WjZGoEX4OH X0MZJQOsIOSsyHXvTUTasPQB20o3ljPKMRgWp5C0zY906ghS0MXsj2Ji8xmtBJf8b4TSqnR3xSW uKK/4OazD78UeWjIY/6G8mWc= X-Google-Smtp-Source: AGHT+IGPSue7MKunY2H9Ufyk2OZJ0tuTN/kpP94dQEQDIdlzvOjh5NgxGK1YbNNMufi/pOt/OJ3gWw== X-Received: by 2002:a05:6512:3193:b0:553:388a:e794 with SMTP id 2adb3069b0e04-553388ae8f6mr1069086e87.17.1748533831821; Thu, 29 May 2025 08:50:31 -0700 (PDT) From: "Edgar E. Iglesias" To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, andrew.cooper3@citrix.com, edgar.iglesias@amd.com, Anthony PERARD , Juergen Gross Subject: [PATCH v2 3/3] tools/arm: Add the trap_unmapped_accesses xl config option Date: Thu, 29 May 2025 17:50:23 +0200 Message-ID: <20250529155024.1284227-4-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250529155024.1284227-1-edgar.iglesias@gmail.com> References: <20250529155024.1284227-1-edgar.iglesias@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1748533857460116600 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- docs/man/xl.cfg.5.pod.in | 8 ++++++++ tools/libs/light/libxl_arm.c | 6 +++--- tools/libs/light/libxl_create.c | 3 +++ tools/libs/light/libxl_types.idl | 1 + tools/libs/light/libxl_x86.c | 6 ++++++ tools/xl/xl_parse.c | 3 +++ 6 files changed, 24 insertions(+), 3 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 7339c44efd..55e9cb5bd9 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -3089,6 +3089,14 @@ will be used for the domain. Otherwise, the value sp= ecified by the `nr_spis` parameter will be used. The number of SPIs should match the highest interr= upt ID that will be assigned to the domain. =20 +=3Ditem B + +An Optional boolean parameter that configures handling of accesses to unma= pped +address ranges. If enabled, guest accesses will trap. If disabled, guest +accesses will read 0xFFFFFFFF and writes will be ignored. + +This option is only implemented for ARM where the default is enabled. + =3Dback =20 =3Dhead3 x86 diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 9530996e72..afc62a5299 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -233,9 +233,6 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, config->arch.sve_vl =3D d_config->b_info.arch_arm.sve_vl / 128U; } =20 - /* Trap accesses to unmapped areas. */ - config->flags |=3D XEN_DOMCTL_CDF_trap_unmapped_accesses; - return 0; } =20 @@ -1714,6 +1711,9 @@ int libxl__arch_domain_build_info_setdefault(libxl__g= c *gc, /* ACPI is disabled by default */ libxl_defbool_setdefault(&b_info->acpi, false); =20 + /* Trapping of unmapped accesses enabled by default. */ + libxl_defbool_setdefault(&b_info->trap_unmapped_accesses, true); + /* Sanitise SVE parameter */ if (b_info->arch_arm.sve_vl) { unsigned int max_sve_vl =3D diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_creat= e.c index e03599ea99..38770eea5b 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -667,6 +667,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_conf= ig *d_config, if (libxl_defbool_val(b_info->vpmu)) create.flags |=3D XEN_DOMCTL_CDF_vpmu; =20 + if (libxl_defbool_val(b_info->trap_unmapped_accesses)) + create.flags |=3D XEN_DOMCTL_CDF_trap_unmapped_accesses; + assert(info->passthrough !=3D LIBXL_PASSTHROUGH_DEFAULT); LOG(DETAIL, "passthrough: %s", libxl_passthrough_to_string(info->passthrough)); diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_type= s.idl index 9bb2969931..e33785c661 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -736,6 +736,7 @@ libxl_domain_build_info =3D Struct("domain_build_info",[ ("vmtrace_buf_kb", integer), =20 ("vpmu", libxl_defbool), + ("trap_unmapped_accesses", libxl_defbool), =20 ], dir=3DDIR_IN, copy_deprecated_fn=3D"libxl__domain_build_info_copy_deprecated", diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 0b1c2d3a96..a9d470c9f6 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -26,6 +26,11 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed)) config->arch.misc_flags |=3D XEN_X86_MSR_RELAXED; =20 + if (libxl_defbool_val(d_config->b_info.trap_unmapped_accesses)) { + LOG(ERROR, "trap_unmapped_accesses is not supported on x86\n"); + return ERROR_FAIL; + } + return 0; } =20 @@ -813,6 +818,7 @@ int libxl__arch_domain_build_info_setdefault(libxl__gc = *gc, { libxl_defbool_setdefault(&b_info->acpi, true); libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false); + libxl_defbool_setdefault(&b_info->trap_unmapped_accesses, false); =20 /* * The config parameter "altp2m" replaces the parameter "altp2mhvm". diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 089a88935a..40da75ef74 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2975,6 +2975,9 @@ skip_usbdev: if (!xlu_cfg_get_long (config, "nr_spis", &l, 0)) b_info->arch_arm.nr_spis =3D l; =20 + xlu_cfg_get_defbool(config, "trap_unmapped_accesses", + &b_info->trap_unmapped_accesses, 0); + parse_vkb_list(config, d_config); =20 d_config->virtios =3D NULL; --=20 2.43.0