From nobody Fri Oct 31 09:28:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1748375805; cv=none; d=zohomail.com; s=zohoarc; b=dOlghqyjlciQz9a/uANgZ1ixyrys7S4Xuag+Hh93k01u2mAdN8l7lp30JlC9WI2RWMS4fXfA7Kz8KN3nSFqVJoHS1HZmyUNPIUAjHqv1eRwGJN8KZkPKGP8whB+zk6dz7IpTmcqZdOcDormJjQz+lpnnov0ThSZpI68CuUbvQJ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748375805; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PW4Ul/brgurN+ahlG/LjWsE4mRdaFGlUa4ZnyTf/6ck=; b=eqlqW+xf53DBmMOGR9UCiQ2xWZBdb/LU+j+djcdZRbbd0VzQc9wQtLF4hGnJFcqa2B4h1uSp2yGGm5UCE4xlrYxOT1ileR687NpZyRaVb9UpedOdNy8AU0jiodiw+vPCcv4CyuW+W+HRlRbssly1PMV7MduXkHXsZlilmT46I00= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1748375805668429.07707977170094; Tue, 27 May 2025 12:56:45 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.998702.1379432 (Exim 4.92) (envelope-from ) id 1uK0PQ-0006tn-OE; Tue, 27 May 2025 19:56:24 +0000 Received: by outflank-mailman (output) from mailman id 998702.1379432; Tue, 27 May 2025 19:56:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uK0PQ-0006tg-JR; Tue, 27 May 2025 19:56:24 +0000 Received: by outflank-mailman (input) for mailman id 998702; Tue, 27 May 2025 19:56:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uK0PO-0006fw-S7 for xen-devel@lists.xenproject.org; Tue, 27 May 2025 19:56:22 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9ee8c48-3b34-11f0-a2fe-13f23c93f187; Tue, 27 May 2025 21:56:22 +0200 (CEST) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-553280c345cso1315068e87.0 for ; Tue, 27 May 2025 12:56:22 -0700 (PDT) Received: from gmail.com (213-67-3-247-no600.tbcn.telia.com. [213.67.3.247]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5532ee71af1sm4355e87.212.2025.05.27.12.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 May 2025 12:56:19 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9ee8c48-3b34-11f0-a2fe-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748375781; x=1748980581; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PW4Ul/brgurN+ahlG/LjWsE4mRdaFGlUa4ZnyTf/6ck=; b=bw/xY25X28E+cPcQavaGvMJAf8FI5XSin7ALy7NZHdn/AUSjuZjd4AATsf/QHh+c7v hNdJQV1Svwmvenii3WIOZ/+1bLWwB0p9FBbe6g+9efqpT1mMFSuQKih0dCYLIViwSw1G IV94JfpaseMJJdkI1NWZE7PJUNTJrpu8oeCJmWe885E3ppSr5ndmfzn01yiyyCOO53nJ +zM0y58S59wI0kupc+0IiF9K/sv89gxjnio6OsBe+5VgGRFcx4TxjR0CDoKt0vmejyHd GCvk0rKVexm+2uIos9t/FCdqVpDr5Jlgs2YYRW8RwJm25m3A/Ay2VPWX73WKf8Uc3qpW pzyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748375781; x=1748980581; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PW4Ul/brgurN+ahlG/LjWsE4mRdaFGlUa4ZnyTf/6ck=; b=NIp+2Q5dkuRjdl/ugDSn7IJETKfLdPIZMt1dDRhBT//trBbqzWaVJsqtSCLbTl3d26 1W+9nzdjMrZcYbad5OEw5zdsiGfxtVjziH8MPZOD3p04vtfb0wS0nNVRR2Sq2mIhA+Zm P1jzWu5ml+OPEV29VSSs09ZynRMH9+1ZLMTwYwvfRufzvhLq8Gvmv3vYpAsYoRQIQ/4n H4eO4NmxW6wXojthmMDn1TapfGC/qU+s0/ZeUCKoOaJMDgh4IbLVa6YGSjInbqx3IkB5 EYdhMpMd7CbZvOicFNRfBKBsXxvdNcGhdcdY1W31OaLNrFD1mlRi92LgZzqbovjzyY/X MEOA== X-Gm-Message-State: AOJu0YwC3B1Jy/3sVacn574JU/hr9Lgr8A1dK+fwPwu8+NiQxm0P2bHh hBK/wMJk2vNkF6hMBrp0aCgjeRe/8V+GvhdQ5k2ODJ0OsJBQtDzBzOHdnDMkDFN0i2k= X-Gm-Gg: ASbGnctaAUr7RSASOg/0jpGySVIqh67gh++EIhuN1BLglusxCHb94rUyiLGbMJA87R6 U/VtZa0N8IkZIXCSFsff0fJUQnl7iHv6pko+27j/x0rCUhSFkPGchGWQ0JtrriDykcq1askFUgO cKqDIqv3qsA370JTnh5Kdwf4EtzSiKEAaVWJf/7R0IMNILihLWQiY1XxaOGR2ykzNz6IOVTHN+p I4k/vp6STwr2t05zxBHkFzJYgKqax6X0MR016a8FMkgN3Xsa0fRFsJKFChK/DUikjk7BFzCWAzi i6Kg8cWwtUKRaChvAWKMr6P59Gdilqt4iIBACTVPx8gjyg9wxAna3293CgqQwPzBjV1TU4VXzt5 osk67u6bB7n8Uuh5uiHQpxK0= X-Google-Smtp-Source: AGHT+IHrDm2Qy6vp9VEqaHnRTakLi2LeAuU7KzcB3N2VPuRneBPy+2xU8AZM4IMeoq4oAeVXe0vaGA== X-Received: by 2002:a05:6512:68f:b0:54f:cc4e:a9ef with SMTP id 2adb3069b0e04-5521cba987cmr4748985e87.43.1748375781216; Tue, 27 May 2025 12:56:21 -0700 (PDT) From: "Edgar E. Iglesias" To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, edgar.iglesias@amd.com, Anthony PERARD , Juergen Gross Subject: [PATCH v1 1/3] xen/arm: Add a way to disable traps on unmapped MMIO Date: Tue, 27 May 2025 21:56:14 +0200 Message-ID: <20250527195616.874614-2-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250527195616.874614-1-edgar.iglesias@gmail.com> References: <20250527195616.874614-1-edgar.iglesias@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1748375806415116600 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add a per-domain way to optionally disable traps on unmapped MMIO. Signed-off-by: Edgar E. Iglesias --- tools/libs/light/libxl_arm.c | 3 +++ xen/arch/arm/dom0less-build.c | 3 +++ xen/arch/arm/domain.c | 2 ++ xen/arch/arm/domain_build.c | 3 +++ xen/arch/arm/include/asm/domain.h | 2 ++ xen/arch/arm/io.c | 33 +++++++++++++++++++++++++++++-- xen/include/public/arch-arm.h | 9 +++++++++ 7 files changed, 53 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 75c811053c..40cd005619 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -233,6 +233,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, config->arch.sve_vl =3D d_config->b_info.arch_arm.sve_vl / 128U; } =20 + /* Trap accesses to unmapped MMIO. */ + config->arch.flags =3D XEN_ARM_TRAP_UNMAPPED_MMIO; + return 0; } =20 diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index a49764f0ad..e5e13e07d0 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -343,6 +343,9 @@ void __init arch_create_domUs(struct dt_device_node *no= de, panic("'sve' property found, but CONFIG_ARM64_SVE not selected\n"); #endif } + + /* Trap accesses to unmapped MMIO. */ + d_cfg->arch.flags =3D XEN_ARM_TRAP_UNMAPPED_MMIO; } =20 int __init init_intc_phandle(struct kernel_info *kinfo, const char *name, diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 45aeb8bddc..54c6ae7678 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -714,6 +714,8 @@ int arch_domain_create(struct domain *d, ioreq_domain_init(d); #endif =20 + d->arch.trap_unmapped_mmio =3D config->arch.flags & XEN_ARM_TRAP_UNMAP= PED_MMIO; + /* p2m_init relies on some value initialized by the IOMMU subsystem */ if ( (rc =3D iommu_domain_init(d, config->iommu_opts)) !=3D 0 ) goto fail; diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b189a7cfae..c3c8212260 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2018,6 +2018,9 @@ void __init create_dom0(void) dom0_cfg.arch.tee_type =3D tee_get_type(); dom0_cfg.max_vcpus =3D dom0_max_vcpus(); =20 + /* Dom0 always traps on unmapped MMIO. */ + dom0_cfg.arch.flags |=3D XEN_ARM_TRAP_UNMAPPED_MMIO; + if ( iommu_enabled ) dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu; =20 diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/d= omain.h index a3487ca713..4d1a180ce2 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -121,6 +121,8 @@ struct arch_domain void *tee; #endif =20 + bool trap_unmapped_mmio; + } __cacheline_aligned; =20 struct arch_vcpu diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index 5a4b0e8f25..11ffa48969 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -21,6 +21,32 @@ =20 #include "decode.h" =20 +/* Handler for unmapped ranges. Writes ignored, reads return all ones. */ +static int unmapped_read(struct vcpu *v, mmio_info_t *info, register_t *r, + void *priv) +{ + uint64_t mask =3D GENMASK_ULL((1U << info->dabt.size) * 8 - 1, 0); + + /* Mask off upper bits. */ + *r =3D UINT64_MAX & mask; + return 1; +} + +static int unmapped_write(struct vcpu *v, mmio_info_t *info, register_t r, + void *priv) +{ + return 1; +} + +static const struct mmio_handler_ops unmapped_ops =3D { + .read =3D unmapped_read, + .write =3D unmapped_write +}; + +static const struct mmio_handler unmapped_handler =3D { + .ops =3D &unmapped_ops +}; + static enum io_state handle_read(const struct mmio_handler *handler, struct vcpu *v, mmio_info_t *info) @@ -178,8 +204,11 @@ enum io_state try_handle_mmio(struct cpu_user_regs *re= gs, rc =3D try_fwd_ioserv(regs, v, info); if ( rc =3D=3D IO_HANDLED ) return handle_ioserv(regs, v); - - return rc; + else if ( rc =3D=3D IO_UNHANDLED && !v->domain->arch.trap_unmapped= _mmio ) { + /* Fallback to the unmapped handler. */ + handler =3D &unmapped_handler; + } else + return rc; } =20 /* diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index e2412a1747..32b023504d 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -350,6 +350,15 @@ struct xen_arch_domainconfig { * */ uint32_t clock_frequency; + /* + * IN + * + * XEN_ARM_TRAP_UNMAPPED_MMIO enables trapping of memory accesses + * into unmapped ranges. When disabled, Xen will handle the access + * by reading 0xFFFFFFFF and ignoring writes. + */ +#define XEN_ARM_TRAP_UNMAPPED_MMIO (1U << 0) + uint32_t flags; }; #endif /* __XEN__ || __XEN_TOOLS__ */ =20 --=20 2.43.0 From nobody Fri Oct 31 09:28:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1748375805; cv=none; d=zohomail.com; s=zohoarc; b=QAPLE78Wpvoxm0x57sEUwEL6Vkm4+QbcOsbWL8TXvzkKCdJkC6KULMuwnvKIuRYrcPidL2m1E2mM+IZk9GXlaVCaKcunpdkWttCG7kb6F+E9GQQ5my7zhV67j0btl7FwpGvy835hqE1cRGBR823Ue1QTNGDBNw3HcKo3DNB0YQ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748375805; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vngFOrYt1JIZC6w4O6KMiqSaaieHXb8/DgKrm2QoDwc=; b=f0A6kNgorxsaNsHeutgzGF0iCfgWt/ThZYP+0y+xJQxLe28WyqjnqiKamdYj6GE8yYJP/Ym+/Nhy1fW63x4SfAp77M8iDR+MrNx6vgkhxCOie5qeRnva+31RxzBAlbfQLLvZ4c6Mf11WBDM9+trWCfQrCpXd83ElBejUlxe/e7s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1748375805146547.7955211166939; Tue, 27 May 2025 12:56:45 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.998703.1379439 (Exim 4.92) (envelope-from ) id 1uK0PR-00070r-5R; Tue, 27 May 2025 19:56:25 +0000 Received: by outflank-mailman (output) from mailman id 998703.1379439; Tue, 27 May 2025 19:56:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uK0PR-0006zU-1A; Tue, 27 May 2025 19:56:25 +0000 Received: by outflank-mailman (input) for mailman id 998703; Tue, 27 May 2025 19:56:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uK0PQ-0006fw-HI for xen-devel@lists.xenproject.org; Tue, 27 May 2025 19:56:24 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aae83a57-3b34-11f0-a2fe-13f23c93f187; Tue, 27 May 2025 21:56:24 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-551fb4d153dso4512477e87.3 for ; Tue, 27 May 2025 12:56:24 -0700 (PDT) Received: from gmail.com (213-67-3-247-no600.tbcn.telia.com. [213.67.3.247]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5532ede9ffdsm7253e87.69.2025.05.27.12.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 May 2025 12:56:21 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aae83a57-3b34-11f0-a2fe-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748375783; x=1748980583; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vngFOrYt1JIZC6w4O6KMiqSaaieHXb8/DgKrm2QoDwc=; b=OBUpXaPx5pGiFnIsa0NhKGsRlku4XM6txbbT9Si18Nn9P/2DEQatNLw6a3Avnar3tL 3HozaU5jW5cN95MXwOfb1GLaBKN14OHPtbB3zBu4TF3P1CBlhr2413PsW3XBl4BfRXwA mutHK4wlipAOgBkoTKxEpIPAW1shYI9mbl8CiDANnFn8p1SzDOvsGNNrhflcFFL1KWkQ KnAsEOWZ80ZvxlBeWg/YIbqo8RKP8kS6oG+6fxV0A0GkJf2cIZsMvgXHma1tBCN7SIi9 SAkapv5Sl/hua4dgBU28scbs1GHG9KaQ/ntJlBiA+FlFeVKfel2ZBq8rhMQOGWpnhtjS FBpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748375783; x=1748980583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vngFOrYt1JIZC6w4O6KMiqSaaieHXb8/DgKrm2QoDwc=; b=b6RNeAZOhHVbxwsXE6DFp7jPwW635S0xsYNg6I/qBSMV7f7VdG24kQMwtfmtW0BS0c d1U9J5I6h701m+6772QSUljWA+LnXjuoI5z2/rataUG0anXs8BZn5W1a4BasnRESgOCr iHA0pL6DP0pZOgv62slbfkc/GqTvmadyw+GwFIQJLE0yTpQ07MAv3s/fouinXGZw+SYN R/nFaD729H97WkTOG4eB+r6P13djCOYAlLoJ/1cMb7x5ieDKNb45LV4afFT0/Iutt1r5 zVQMHPVwH7sJ6y+wSYYjnmevjgAgznc0wVlWRvgIOT5sncG9LjiFORAc+LlMGpItnH+I Tgcw== X-Gm-Message-State: AOJu0YxlHvVEcnnyhlkD4RecZXVa3G2QK12lLT87ANnwtmDVwwhIpbQf c4mGIkpabUgkp1ShiBHk+Alh8u5u7P3RYaMa6JJmSd/KtjfKvk/4qphIC04HUKfvGqw= X-Gm-Gg: ASbGncv3ebk+28CMxoyUVi+wa780b10DCXpbYvzeVgLnm8gtSdchqPn+k/v84quqA35 QkaTM28uU1VdinxbHuE+dAAGPaYVTkDzEhYaWubcBfJ17MLcMm2a+KLMGpRygMAo87066kGLwPt OfLu42p1tXuzeqddpOTQ84vvUf4aJZpBRRv+OKduokaEOkzAvjQOlDWv30m6CFHYpQfGo+zLkzf 7X6H5z4y0y/Nj2B8Q8JoYH7yiJzBZHukgegvsu5GwEzx+2dR47CyNVFKBolvyKR9xQFvBfrxlCe yQwqjFCyMLDlfzUP2brl8R+2npFQhFlweapWjCzyvyW3Ut8GrBUCoLQxJ9Y/fh8Et2sTnJcuEjN DTbXa726kZVRU2nVOr0MjiD8= X-Google-Smtp-Source: AGHT+IHR+DnsITbWw3w2KJ6g1xT+1csv74B4Ak8LZYh+iyCpIdRa16eHii8xvgpf58bV561Lmfxtbw== X-Received: by 2002:a05:6512:39c3:b0:54b:117c:1356 with SMTP id 2adb3069b0e04-5521cbafc09mr4298306e87.56.1748375782892; Tue, 27 May 2025 12:56:22 -0700 (PDT) From: "Edgar E. Iglesias" To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, edgar.iglesias@amd.com Subject: [PATCH v1 2/3] xen/arm: dom0less: Add trap-unmapped-mmio-disabled Date: Tue, 27 May 2025 21:56:15 +0200 Message-ID: <20250527195616.874614-3-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250527195616.874614-1-edgar.iglesias@gmail.com> References: <20250527195616.874614-1-edgar.iglesias@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1748375806318116600 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add the trap-unmapped-mmio-disabled per-domain fdt property. Signed-off-by: Edgar E. Iglesias --- docs/misc/arm/device-tree/booting.txt | 7 +++++++ xen/arch/arm/dom0less-build.c | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-t= ree/booting.txt index 59fa96a82e..75fbb245d1 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -225,6 +225,13 @@ with the following properties: option is provided with a non zero value, but the platform doesn't sup= port SVE. =20 +- trap-unmapped-mmio-disabled + + Optional. A boolean property that configures handling of accesses to + unmapped MMIO ranges. + If set, guest accesses will read 0xFFFFFFFF and writes ignored. + If not set, guest accesses will trap. + - xen,enhanced =20 A string property. Possible property values are: diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index e5e13e07d0..cd1ef05d89 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -344,8 +344,9 @@ void __init arch_create_domUs(struct dt_device_node *no= de, #endif } =20 - /* Trap accesses to unmapped MMIO. */ d_cfg->arch.flags =3D XEN_ARM_TRAP_UNMAPPED_MMIO; + if ( dt_property_read_bool(node, "trap-unmapped-mmio-disabled") ) + d_cfg->arch.flags &=3D ~XEN_ARM_TRAP_UNMAPPED_MMIO; } =20 int __init init_intc_phandle(struct kernel_info *kinfo, const char *name, --=20 2.43.0 From nobody Fri Oct 31 09:28:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1748375807; cv=none; d=zohomail.com; s=zohoarc; b=Sohl8sdpeunKJgwZw6EDbpPydCYqVDDJaLJSbBSGIJ7CYbosAirJeiuY29R+qTUAR2H63qwec9Nt1CS+f9f8AIGHiPGR/FiOk15XvCH2iWDogSPW4BPycwaUuCO4TiC7pG9o8s1gkkf25h6e6Z/+u3EZrGOUSttIntZvarYa+qI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748375807; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8uoMcemAbIQbPzslSOx3EYsiOCGjdfZV67/ilufqHkE=; b=Mjj0JO0HFA5GG8u4um/GZIhpxeWHPTJ5kUpDrpBwd9ZjzfOimRXj0CppzD2kZObXvlbqoB4TIDA27PfMnYDEyMNg6arBlqKEKVurTFnyvC4S9aOJcZR0muFVNkqUqMtjJIKAi7qFXPU9bLI72ux+z0roHO00vIzRD0egcY7QkLc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1748375807660717.6893673779563; Tue, 27 May 2025 12:56:47 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.998704.1379452 (Exim 4.92) (envelope-from ) id 1uK0PV-0007PW-BH; Tue, 27 May 2025 19:56:29 +0000 Received: by outflank-mailman (output) from mailman id 998704.1379452; Tue, 27 May 2025 19:56:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uK0PV-0007PN-80; Tue, 27 May 2025 19:56:29 +0000 Received: by outflank-mailman (input) for mailman id 998704; Tue, 27 May 2025 19:56:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uK0PT-0007N3-No for xen-devel@lists.xenproject.org; Tue, 27 May 2025 19:56:27 +0000 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [2a00:1450:4864:20::231]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abe1bb51-3b34-11f0-b894-0df219b8e170; Tue, 27 May 2025 21:56:25 +0200 (CEST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-32a63ff3bdfso16209101fa.3 for ; Tue, 27 May 2025 12:56:25 -0700 (PDT) Received: from gmail.com (213-67-3-247-no600.tbcn.telia.com. [213.67.3.247]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-32a7610ce19sm589641fa.14.2025.05.27.12.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 May 2025 12:56:23 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abe1bb51-3b34-11f0-b894-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748375785; x=1748980585; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8uoMcemAbIQbPzslSOx3EYsiOCGjdfZV67/ilufqHkE=; b=fhbn8DtQNQqbnqIFfw/CYkBzAXcw557zAWEMDYHQbHO1L2ZDuQfBTuX6xUIOdQr6eg jpymoWSNBfl5xMUtf9PFDz8QBvCGe+sML20CIHDhNpBz8YJOJIykQ5XEYDTbPWxW+P79 FPPTTvjAVjyy8D2JNFhp8EcGfi/u9zrFOBrElSM4dRFn3N3xYqXdVWqfQ4q/qDPRGBFK +QStzAh7/ZNMQsEL4oYEBiBg59J/KaS9BCEYQ9/p6+Kivu/dg1X3DPYc9TMwU5MFPAAN bT49CcRLFM4jp2l2O2c42E1Gl2jsXMOu3/Y2VDi9fE18lgqKWMpAgNqdthKsDGR7VBWJ 1QKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748375785; x=1748980585; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8uoMcemAbIQbPzslSOx3EYsiOCGjdfZV67/ilufqHkE=; b=Iw6d7HrjNglTSwINbPYhd3184mMKzAUUS63EGTbp/Ib28NAXl/GIgu6uej4rxr2wDI VzM/QSlMAX3HGh6qQsYNam0zlDj6Mizq4R5HYPZIPAItTtzJp/T4JH9oaHP17pqAS1iu aTmvmW1BcWY58rB1als2tQYjsdcLcOPPC25DVRrOxocRb1nlk6+x1TLJHSRRiMFtEcuQ uQL0487KoDoLYBF34uYXwROo9zhM0roggzuC/Og7klWqVJA/gEYGZtFs/WJljpH0xwVk aD4JNLEWQhbDAtR1LlvcWD0WWNbaD48DR1foxRRlPtPy7Fo9X06z94r+XL3XRcB8lagB tYVw== X-Gm-Message-State: AOJu0YwRcE1iIdtGW7t+SNzgWyl37Tg3DCuh/QxrynzUvXUfcXDUTp2w 1YOK9I1O19pQYpkZX6jBU7ucREZF7bm49p57mTtEvxzLsIBkZOGUzrwN7E8aBxTk+PQ= X-Gm-Gg: ASbGncuO6ztNGmbpwvh/WSNSf0K2C5b3ufSm7Uxe2o8Aexvvsw7dbgheahTUvarbI6k MdD1e2HLTKuckNEVVx+qoXimlqLHBLwrCsWO6VUwXEJgUhj9a74D1+ULmAoRElP2X/k/+m8vY2y lW6J9ZgGj/6FhKtwG1zE1pOsZK0Fk1Ql5bPNGkIOegShUVvOpoI7u9ohIlp/OdsYVVt09sckZQF 7IpUi5kV1ujMbSVcXLNUQBHil118Ts30xuVP4uI4afwFfRzTfE0tFDZykvlNcRwF0cGWGphXtn8 KBs/z9IG2Y4EdHHY074qV9iXHZFgKwN0dSstPFs5n8eUsEGm0W4Go+j/X57ipj/V0US+AKmpzmo 1wmVgsHzetKEJR4n1yVIKKvA= X-Google-Smtp-Source: AGHT+IGGrSO3iFT/tQMaWnySP3c4+esSsUmT69PdcEitGWv/Yax8lntWxvFNYDU5c6s2y14seZ1z0Q== X-Received: by 2002:a2e:9fc5:0:b0:32a:724e:ab8d with SMTP id 38308e7fff4ca-32a724eaef1mr9103641fa.40.1748375784578; Tue, 27 May 2025 12:56:24 -0700 (PDT) From: "Edgar E. Iglesias" To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, edgar.iglesias@amd.com, Anthony PERARD , Nick Rosbrook , George Dunlap , Juergen Gross Subject: [PATCH v1 3/3] tools/arm: Add the trap_unmapped_mmio xl config option Date: Tue, 27 May 2025 21:56:16 +0200 Message-ID: <20250527195616.874614-4-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250527195616.874614-1-edgar.iglesias@gmail.com> References: <20250527195616.874614-1-edgar.iglesias@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1748375808515116600 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- docs/man/xl.cfg.5.pod.in | 6 ++++++ tools/golang/xenlight/helpers.gen.go | 3 ++- tools/golang/xenlight/types.gen.go | 1 + tools/libs/light/libxl_arm.c | 8 ++++++-- tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_parse.c | 3 +++ 6 files changed, 19 insertions(+), 3 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 7339c44efd..6dd0a05482 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -3089,6 +3089,12 @@ will be used for the domain. Otherwise, the value sp= ecified by the `nr_spis` parameter will be used. The number of SPIs should match the highest interr= upt ID that will be assigned to the domain. =20 +=3Ditem B + +An Optional boolean parameter that configures handling of accesses to unma= pped +MMIO ranges. If enabled, guest accesses will trap. If disabled, guest acce= sses +will read 0xFFFFFFFF and writes ignored. + =3Dback =20 =3Dhead3 x86 diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/h= elpers.gen.go index 90846ea8e8..b04561929c 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1163,6 +1163,7 @@ x.ArchArm.GicVersion =3D GicVersion(xc.arch_arm.gic_v= ersion) x.ArchArm.Vuart =3D VuartType(xc.arch_arm.vuart) x.ArchArm.SveVl =3D SveType(xc.arch_arm.sve_vl) x.ArchArm.NrSpis =3D uint32(xc.arch_arm.nr_spis) +x.ArchArm.TrapUnmappedMmio =3D uint32(xc.arch_arm.trap_unmapped_mmio) if err :=3D x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err !=3D = nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } @@ -1687,7 +1688,7 @@ return fmt.Errorf("invalid union key '%v'", x.Type)} xc.arch_arm.gic_version =3D C.libxl_gic_version(x.ArchArm.GicVersion) xc.arch_arm.vuart =3D C.libxl_vuart_type(x.ArchArm.Vuart) xc.arch_arm.sve_vl =3D C.libxl_sve_type(x.ArchArm.SveVl) -xc.arch_arm.nr_spis =3D C.uint32_t(x.ArchArm.NrSpis) +xc.arch_arm.trap_unmapped_mmio =3D C.uint32_t(x.ArchArm.TrapUnmappedMmio) if err :=3D x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err !=3D n= il { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/typ= es.gen.go index e7667f1ce3..89cc976bdc 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -599,6 +599,7 @@ GicVersion GicVersion Vuart VuartType SveVl SveType NrSpis uint32 +TrapUnmappedMmio Defbool } ArchX86 struct { MsrRelaxed Defbool diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 40cd005619..cce3fc4684 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -233,8 +233,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, config->arch.sve_vl =3D d_config->b_info.arch_arm.sve_vl / 128U; } =20 - /* Trap accesses to unmapped MMIO. */ - config->arch.flags =3D XEN_ARM_TRAP_UNMAPPED_MMIO; + config->arch.flags =3D 0; + if (libxl_defbool_val(d_config->b_info.arch_arm.trap_unmapped_mmio)) + config->arch.flags |=3D XEN_ARM_TRAP_UNMAPPED_MMIO; =20 return 0; } @@ -1714,6 +1715,9 @@ int libxl__arch_domain_build_info_setdefault(libxl__g= c *gc, /* ACPI is disabled by default */ libxl_defbool_setdefault(&b_info->acpi, false); =20 + /* Trapping of unmapped MMIO access enabled by default. */ + libxl_defbool_setdefault(&b_info->arch_arm.trap_unmapped_mmio, true); + /* Sanitise SVE parameter */ if (b_info->arch_arm.sve_vl) { unsigned int max_sve_vl =3D diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_type= s.idl index 9bb2969931..bd5425fe50 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -724,6 +724,7 @@ libxl_domain_build_info =3D Struct("domain_build_info",[ ("vuart", libxl_vuart_type), ("sve_vl", libxl_sve_type), ("nr_spis", uint32, {'init_val': 'LIBXL_NR_= SPIS_DEFAULT'}), + ("trap_unmapped_mmio", libxl_defbool), ])), ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), ])), diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 089a88935a..3099086198 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2975,6 +2975,9 @@ skip_usbdev: if (!xlu_cfg_get_long (config, "nr_spis", &l, 0)) b_info->arch_arm.nr_spis =3D l; =20 + xlu_cfg_get_defbool(config, "trap_unmapped_mmio", + &b_info->arch_arm.trap_unmapped_mmio, 0); + parse_vkb_list(config, d_config); =20 d_config->virtios =3D NULL; --=20 2.43.0