From nobody Fri Oct 31 23:32:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1743470312; cv=pass; d=zohomail.com; s=zohoarc; b=R9RRH5IIKdKF0vRY+49xPc4bQuqJ2n4hykovbdzYCe5jSa5KcazOfqpirhQMZr2Pa+qodk28sHQPfIC6eHWzA0XB7vMRg1qkPBSyC2VmluyMhj/NlkW+R2cK1FDJXipGYTrmbClaG1ZzIbhvmqgTqFNIKNrCZVbiUMHzDehwGdQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743470312; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6eauTMPP1KriVl2OZ/pYML5XrBsfISutp4e5CHq9zXk=; b=f9CJj0slwlPpvHjP0uRPlZ6qKW+I06elANPgrXvZHAYFmsPC9un8nWrPccrnAxPKXhaZwIyqD/IXb6iHEHNo8+/ky0vIn3LzepiSux4XsN7N/Hy3L7fLlXfqGjauUdmYFYFf/0SF0EgQUoprVIgjD6bzNJhuw9k6H10H+gusOB4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1743470312889776.0567932051317; Mon, 31 Mar 2025 18:18:32 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.933347.1335322 (Exim 4.92) (envelope-from ) id 1tzQGL-0006qk-7l; Tue, 01 Apr 2025 01:17:57 +0000 Received: by outflank-mailman (output) from mailman id 933347.1335322; Tue, 01 Apr 2025 01:17:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzQGL-0006qA-2l; Tue, 01 Apr 2025 01:17:57 +0000 Received: by outflank-mailman (input) for mailman id 933347; Tue, 01 Apr 2025 01:17:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzQGK-0006nG-CK for xen-devel@lists.xenproject.org; Tue, 01 Apr 2025 01:17:56 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20630.outbound.protection.outlook.com [2a01:111:f403:2607::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 23d7f4c8-0e97-11f0-9ea7-5ba50f476ded; Tue, 01 Apr 2025 03:17:55 +0200 (CEST) Received: from GV1PR03MB10456.eurprd03.prod.outlook.com (2603:10a6:150:16a::21) by PA4PR03MB6703.eurprd03.prod.outlook.com (2603:10a6:102:ec::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.46; Tue, 1 Apr 2025 01:17:51 +0000 Received: from GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e]) by GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e%4]) with mapi id 15.20.8534.043; Tue, 1 Apr 2025 01:17:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23d7f4c8-0e97-11f0-9ea7-5ba50f476ded ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HmUDlfz14M7RkPqJu/JFHDVAAYvGPh4RaVloRgwAOKkbkph6qXig4Wp3X4YezopFdCPoo9hb1UECQvI2auy01Jx3GeIJrftjqtU8n3qqixoplFQnDrzWbbYjCoifNPlqpycZMbUqv8BhheRdxH1IgJIgsDXfhUExZnP8E/48In2A8h7gPdLik2qlctZAQTep4nQHE6Mf7y4jdN8cUN/vQzwf2W8kk9kU1ORUNr8C9473rUlJ2ghSniWU+g99QyAxjJcsOeLMFULrBOyQDuYy1iGHqiB4f/TvYifrTptz+6UdQz1n6s0w7Nq5lZjzLPzAbLob0KiL9pAlNL/JXxw9RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6eauTMPP1KriVl2OZ/pYML5XrBsfISutp4e5CHq9zXk=; b=Rh1f0J1sQOCnONn2lZ6au3YLNRcjqiRDG0f4Ftu96rrHLysqw1b30TOm2VXCB5K7v09QQp5IYUhO3nENG5UzK1xPNO82s7iL3FH3u0dN8ZQz+4J3oX8V/yD4ZkXQ2nIeqnIS4uah10sxsIda0fFrYKg/SJbTq7qvosZ4Qaok7HkiuzasglBpYug57edEURqtKgI569QUJrHH2osEjpsshiSFcoC7DrS71K63nv+kr9LZ6GRVD2M+LdxFUkD1KpLS2cN6ecPRpOIS0vk3O8CxcTmC4vJcBHwE4CajG2FShMn/qDquMljgEcDY2YJogkDhCfLuLYYS6Y9erzT5OQDR2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6eauTMPP1KriVl2OZ/pYML5XrBsfISutp4e5CHq9zXk=; b=OLGhuDc4wXoAJeI68NticqjH+ss5QthC7Slg6xxqIHOotpW2p5Pormm550Dn139xxrnUTXckOZSNcSF01m9HVlFkq/X10WNHf4cGbc0ZvqbuJmqEjo8llVPHFTcYeb4eHUyZTV87ZqYvwPdxOLKD7tM1+uhUZyqufwq22NKirTIUci6O/EZxrdfE2C9l4HCJQOPRddJkBc8KTSZc5OCHsQygaqr4lXrmyaextNJFtxc6KyvyhJ0pGZNysy8SAD8dg3P5ykXJfBQQNICp9Yve65xy0gg2KjKS09OsrWtgIGuvxkWhY5KQ399jEDH2YtouZoNsyCMCEZjYFci07afxEg== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Stefano Stabellini Subject: [PATCH v3 1/3] xen: gcov: add support for gcc 14 Thread-Topic: [PATCH v3 1/3] xen: gcov: add support for gcc 14 Thread-Index: AQHboqPjoKv09jK/Dk2C7qcEL02CdA== Date: Tue, 1 Apr 2025 01:17:51 +0000 Message-ID: <20250401011744.2267367-2-volodymyr_babchuk@epam.com> References: <20250401011744.2267367-1-volodymyr_babchuk@epam.com> In-Reply-To: <20250401011744.2267367-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.48.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: GV1PR03MB10456:EE_|PA4PR03MB6703:EE_ x-ms-office365-filtering-correlation-id: 20e60f01-19eb-45c7-a7ff-08dd70bb05fb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?Pp8//HL1rigYOceyxaJPEO2Uab6ZrCi2NKfRDTrmHZMBheTrORYoI7ptoA?= =?iso-8859-1?Q?7qwyMMUbK7O/lXNH6TeTTQTB8k+NoWCPqo6qlp/lBl7Q0+elEN+4LBxury?= =?iso-8859-1?Q?JHWFgw0h+lfO2R/YwEUUgLtmGCVILUOzDhSn80/Wqnwgxb0YF5/28+GQf4?= =?iso-8859-1?Q?j0tBDaeXwqlK46m5XPA2cSjLvky3b2tvlzmledTeSFQ/tnxNV90OHIeq9+?= =?iso-8859-1?Q?Y+ee1z4CDWRlTPeXE/VccgBVbAbIkd5LczRxmvh4CmbgUW55ucfzPJrIq9?= =?iso-8859-1?Q?DUq6FMSuvPlMdQpYa1rRybr30dSd31fRFDuWL6Mn9ahTBNaF/KilOhmz41?= =?iso-8859-1?Q?AiL8i1bZS6k/MliQQHUTTienyLyl0k8GQRsmcOqRUHcVPaBy7AYRPb20He?= =?iso-8859-1?Q?jYO5UJi21b6H4GdGGg6ZjSY4u505o1T9UBUU5VBJhj9YO78yq3P4AAVm13?= =?iso-8859-1?Q?/zznHFiy5X9FA8ZE83y5GRhrsH/kJRp2HwfDTpRUdDnxm7aFv6FeE0UY/I?= =?iso-8859-1?Q?Bpdq+/nm4kJLqa7TmzRkPTIon6H32RKVqoAHBdKSe40MR79KQOtA8mtjFY?= =?iso-8859-1?Q?YSt2n+pQXF+n4l3Kp1sCcjJt/InKvQcqk2idlOFrMNAodY/oryDDyz/U4E?= =?iso-8859-1?Q?badrlos2tEzcmVKpZ2rYEEkTldgHFYkKRI+mhr+XeaJ9l1tC4ZV7fFuJtw?= =?iso-8859-1?Q?reSBOAkvRtNtrub+TcuB9VxeG6fv1wVJcAyWZtcruzx+qaHXCSESYyxcZm?= =?iso-8859-1?Q?vl2w4Z3sdWTuvErsYa2PuA5VPP8No8IQz+hY4NH4UsSTk7ivgFK/VsH45H?= =?iso-8859-1?Q?CCG0snZg+/nw4kF5bBeR+CxKA6ePJsqpGl6tNeyNwqEHc9q7qL41P08EpR?= =?iso-8859-1?Q?51/gC64PD0fe801jbCK0H4w7cXDmwfb/zCcztBuahjzabromiUSpXt6+Kf?= =?iso-8859-1?Q?YD+LD9rwO9kjDOj1jSAMlAW4B2PYzRjtL5ULM/Rq3lQWJM5q+WVWNrx3+3?= =?iso-8859-1?Q?Dgh+AbNv9wO6+NXxLMYkeshcopqgkA6G4HTuHkiE5Z+SHGX/VmyU3cyNBB?= =?iso-8859-1?Q?RhqEZ/sW4rjqowPVkByDRh73faabyk6l4KjN4UfN1uN3IbpC8H2bwYwvi8?= =?iso-8859-1?Q?VlVMbIuVcpkCs3b+2YETCsOqkIG1+1yFmUXUnpR4RCaEr//St0FFf2IN0h?= =?iso-8859-1?Q?JPbKyUy/VJd6TK+S4cXf4X9+KJco+v7radcXPaFi29pIRRc2RJM0u0uyw3?= =?iso-8859-1?Q?RnrHzTWJhuNdLAnMq/KhaF945xuv2+RSVgUdjCBkSFPylh4RwJ4ZklyWYg?= =?iso-8859-1?Q?WQ5FMcwVOE8u+Z0QbJhEWICvVt7UXjrL7BWzNnst0VUu6twux7xLzvHwSN?= =?iso-8859-1?Q?AkYpcUJDS3Ihk/J15yuvvKaAQYxMrAXhxXtKCCNvUILMXPhklEPiVz4PR4?= =?iso-8859-1?Q?rBcxCWUm5F6ePUAyrlWEk8SekglPU4qN+rODSYH+ArguweY5+kVUqVCcec?= =?iso-8859-1?Q?DWgiHzz+6Gq+rk+b0QEyrx?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR03MB10456.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?XjC+f851RNrbupabmBI99y8vEzHz22snNgVbiXwbLxqX4ff4UbHWyuMuKg?= =?iso-8859-1?Q?VluMYmwO+cUIJjj6Mi3EkPHZojgElqyw+NSta8H3TRsulRTIw934kWHevQ?= =?iso-8859-1?Q?RDadOuK+Dr+1oPUdeiPfOjuzTnrQBR0/KILPKFAbApa4BtlAIvOab3daqh?= =?iso-8859-1?Q?jWuiL1Xzo0BF7r6rL29lVUSh/ZT79FPBlNvtKNtN5Zu+Df5dYu1Ym6Qssw?= =?iso-8859-1?Q?AwocYaHyWey2M8XgFK7AYyHs4/pQlr67KZMu3VMOjcOA3bNrby2mWXOUdh?= =?iso-8859-1?Q?bdicNDButkI0kjeDH9lXKcuEGDnAdrLog7s1WPOnpqsDySXE7lgjEEb2YM?= =?iso-8859-1?Q?fqK8TLdcvc7ZW+gJQminO0odqssHZzglv1EdFTC8aafHmsVSE+/T0HN6do?= =?iso-8859-1?Q?RNIPF+9nyxDSOjLCFooI43H4d488njHpuZfL+LLgKeRXDDDZttFpbgBJQg?= =?iso-8859-1?Q?hMoM0aqEaRRw4t2vIt0Mu9wkDRPFll1zD4mmFFirqTj/gD52QDDGwyYrJM?= =?iso-8859-1?Q?M7GcbWwaRu8vSEArzXjZ4Q598pomALgrVskOcubA+j5eI0UPUj6OGJyN7p?= =?iso-8859-1?Q?KxwcaNreLsnic74vrTc6g88ZvT4pZr/TeV4fR9UkQGuwx/eqTzw3Ixb28t?= =?iso-8859-1?Q?zOpIIw5rpX3S5BXrL4CcQNNSvn8DyKUMa62dVaVRp5/B6Q3GQnLy+0eEzy?= =?iso-8859-1?Q?V9sJclxDYXR21dqQn0Rn+GXDdbcosRoBBW0AOFuvB151Z1GZeCjOH9BGjp?= =?iso-8859-1?Q?pn+evk9xOK8+bq1PaRk7jrCbDsJSwNyoFkafjvKksHMIhkkoBKRCR6SFCe?= =?iso-8859-1?Q?RrM7a5uM5z6oKCGFNRFh4a3eOBa3mbxnxUiUCpezAHajYtuB/P2MdnGmL2?= =?iso-8859-1?Q?lBdYxvAPt/M5HCni2rcVjq2uXz/5yzDE62mIGhxaQAsSTHd/SVEP6yWxVH?= =?iso-8859-1?Q?0rh/ZEaq5q/EaQhXVku8w6/rhVCWWSDNTcZf26NQNoeiQSZ3mPksE1ULDf?= =?iso-8859-1?Q?ElX9PXS9lZrAZpm+AALhE7UdlS57PV2/DK5kUbuLHjAzr3AgMUZW/xKBzR?= =?iso-8859-1?Q?JuExteDLVr5yKp+lel/eJ70gNgMFKDTfrMWagp1lmyz+seVcCAlzYuCqYm?= =?iso-8859-1?Q?OhAX/bYednFrsEVz+GPO4Nvvc/C6UMdTwZ9NZch1zQvegGnVcOV9cz7/wp?= =?iso-8859-1?Q?crsHGNs5GimhHEHOknnIVmy/8BMSkGGg6c0rpsA00o5ekeEDSPoVjNMgCO?= =?iso-8859-1?Q?FHQmiVTJoD9DjzF5rnPUt1kBBwhQ0/HAX1ZfBLi6m9BRxrXk6B6CjsQ8I0?= =?iso-8859-1?Q?DTnkS2xe4DamSn7X2N1B0lsow76uurPePYqxsYDzUaunrADMUpI+3aRjIu?= =?iso-8859-1?Q?7yCmP9g2C9iqSZOEm98P4dbMNZ14HmpJj/JuocsDJ4s25I2vysbXmLltSx?= =?iso-8859-1?Q?985QYR8jzG/jJh+P75xK06g9pUphiRqFVbrcs+NskXNTOXcowwheyUJZMC?= =?iso-8859-1?Q?s6MbIKFbY8cS3NrbJNMLTBjPSGNjqvJeAOg7lvKzHBrtA8+diMZOYVq46w?= =?iso-8859-1?Q?mzDqPvGb9P/Z1vfK+7vb43dMS+QVqFh3ofAIGjnJpP9LZ6f+uD20kH45PQ?= =?iso-8859-1?Q?tH0Dlwd8NY0/MeJsOB7hjgjxmnReRU7NT3aoDeD1rr6E0Ye59qvlUjZQ?= =?iso-8859-1?Q?=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR03MB10456.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20e60f01-19eb-45c7-a7ff-08dd70bb05fb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2025 01:17:51.3584 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gG6QQC3pAHoXU74YI2PAH+aXxp7SoU478Ny1RiL4L+4ww0mvZiTuwQ81UqivtU1ZaWQ4TapRktT2FULl2PbHsvgq0/lIQs2oQmix0+dz11c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6703 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1743470314099019000 Content-Type: text/plain; charset="utf-8" gcc 14 (with patch "Add condition coverage (MC/DC)") introduced 9th gcov counter. Also this version can call new merge function __gcov_merge_ior(), so we need a new stub for it. Signed-off-by: Volodymyr Babchuk Reviewed-by: Jan Beulich --- Changes in v3: - Added Jan's R-b tag Changes is v2: - Check for gcc 14, not gcc 14.1 --- xen/common/coverage/gcc_4_7.c | 4 +++- xen/common/coverage/gcov_base.c | 5 +++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/common/coverage/gcc_4_7.c b/xen/common/coverage/gcc_4_7.c index 1c20e35ee5..f4c1802303 100644 --- a/xen/common/coverage/gcc_4_7.c +++ b/xen/common/coverage/gcc_4_7.c @@ -28,8 +28,10 @@ #define GCOV_COUNTERS 10 #elif GCC_VERSION < 100000 #define GCOV_COUNTERS 9 -#else +#elif GCC_VERSION < 140000 #define GCOV_COUNTERS 8 +#else +#define GCOV_COUNTERS 9 #endif =20 #define GCOV_TAG_FUNCTION_LENGTH 3 diff --git a/xen/common/coverage/gcov_base.c b/xen/common/coverage/gcov_bas= e.c index d0c6d0a3f9..742034e039 100644 --- a/xen/common/coverage/gcov_base.c +++ b/xen/common/coverage/gcov_base.c @@ -56,6 +56,11 @@ void __gcov_merge_delta(gcov_type *counters, unsigned in= t n_counters) /* Unused. */ } =20 +void __gcov_merge_ior(gcov_type *counters, unsigned int n_counters) +{ + /* Unused. */ +} + /* * Local variables: * mode: C --=20 2.48.1 From nobody Fri Oct 31 23:32:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1743470309; cv=pass; d=zohomail.com; s=zohoarc; b=UwEWkG3AeNNmQtdsQMHM7ttKYJb+DTwtyBSKjaxQeuFcN6vowGS1w3bS7KZXy9YTpOmN8wlhWHYSHxW77OKdDJHI5TnbxVEsCcpg5SzTOyfGxj10AK9mtio32iJfTRIRRFle46gJxh9zaC2EB0dKQFvTLJGKjGMAAyrrhZrfFFg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743470309; h=Content-ID:Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pYY5TMzKZzk8Pg6xp60F/cK2FtqsNx/Afg43r5Pf3JM=; b=LbQKmmklMm3KHaWquBnAmuuoZun0DwB0OuX8WOJDsoNIE3KeEgnSI6RC+DUh4tzAktLKm/DWac4pQ4p5Gbo/ncA2+5qK2LSqJsr6R13Q6lyP4xvWy9RCMCCEeLUwvlDqRQgxT12yIenHyWJ9S6tdomlzZnzfrgNFGbPHuW8yDMQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1743470309004134.0591233663431; Mon, 31 Mar 2025 18:18:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.933348.1335336 (Exim 4.92) (envelope-from ) id 1tzQGM-0007FT-HG; Tue, 01 Apr 2025 01:17:58 +0000 Received: by outflank-mailman (output) from mailman id 933348.1335336; Tue, 01 Apr 2025 01:17:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzQGM-0007FI-Ck; Tue, 01 Apr 2025 01:17:58 +0000 Received: by outflank-mailman (input) for mailman id 933348; Tue, 01 Apr 2025 01:17:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzQGL-0006nG-Cb for xen-devel@lists.xenproject.org; Tue, 01 Apr 2025 01:17:57 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20630.outbound.protection.outlook.com [2a01:111:f403:2607::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 241708ab-0e97-11f0-9ea7-5ba50f476ded; Tue, 01 Apr 2025 03:17:55 +0200 (CEST) Received: from GV1PR03MB10456.eurprd03.prod.outlook.com (2603:10a6:150:16a::21) by PA4PR03MB6703.eurprd03.prod.outlook.com (2603:10a6:102:ec::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.46; Tue, 1 Apr 2025 01:17:52 +0000 Received: from GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e]) by GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e%4]) with mapi id 15.20.8534.043; Tue, 1 Apr 2025 01:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 241708ab-0e97-11f0-9ea7-5ba50f476ded ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nAwatLDyaajIHjiL/s5mfEpHBsbwKLOAGOTkfgtUeIMilYYDcjsWvQOs6G0zozNkMC7qGx/DG6UkH03NzM3BYapxhhiTPipH4KUXC9xU5vnqsUlhX7W1SakJEX6028VqLaZSuqoVlC8rotawfVCSEFeFyJYzi52HsyWcFyl4kJo2nZ6eVQ3l/3q4lU6czc4MKroajrfmOUGvdSBKz9xIYJtX4MOPSGsTI6Lq7vlkTr3qKJwdPjDmPBCbIBYoFxURWNycYsM7nTuAH8GO6mkWLTLQRKFdC38nQZQnEQIIklKL+6b2OJJfl8HTwBipacyiQgDBK6yOwdnf4HUKLtst/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pYY5TMzKZzk8Pg6xp60F/cK2FtqsNx/Afg43r5Pf3JM=; b=mOrbLM/vuq9wFjCobJL4h6WgP0EUf0bCNJfkVFrgQZmE/ykKUs7zmwAtf4iqjZUscF2GeZ1iPcj0TP2MXkXY1TMChrszNIuMUr3uF+Qpc8vVHAXJKsRgqVPQIQPfIimGulLsV1c7FEM7z4+zMh4guMbygkJ/PwffjnEnfbB+oNUvvMz4rrcKJ/gjxDlihybtySNigmA2kl+RrxzallUaVk9PyEGkpS93e7nHMDE6M10aS7w3GFMkGFayI7P1N3prdYrMfoLQJl3A0iiR7MU8pcfgCzRTkOkKannmsVL0cePRoVG8n88uOrBAGocyzh2w1pWnbocVbfGq9Kp7xaHNpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pYY5TMzKZzk8Pg6xp60F/cK2FtqsNx/Afg43r5Pf3JM=; b=J1h9Xh5r2iq8Gw4JEDG1f4qW7TX3eYASmChHMjhGirR4LOhMPEYBNowFLAsU+FHvWV8pUQiSiD5xTnwFAab56SY4Oyj/Oo/+38VIrihCab9C3QO42Kn+EkH3iipNM9CfyTArz9cTtaXBtNiFrKApfapXPdfUPLZHNwWt78DAw26LHbPS8Vhu1HquOv0uA0mOCo7Jw024gyXmemitf9c9Etysf8lZF1S3BN6shBpAdZKiA/0+KG29aOVOax8FjtcJJWPeOwq23jiPhT3vGyNjhZZSN6aHJq/jLeRRABYNUlFRPHmBnlvaxoTzbOqni4wfSAYfzpJVYpf3f7i/0N/qhA== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: [PATCH v3 2/3] xen: x86: irq: use do-while loop in create_irq() Thread-Topic: [PATCH v3 2/3] xen: x86: irq: use do-while loop in create_irq() Thread-Index: AQHboqPjgHkUwEzR90uZDjrf8rDceQ== Date: Tue, 1 Apr 2025 01:17:51 +0000 Message-ID: <20250401011744.2267367-3-volodymyr_babchuk@epam.com> References: <20250401011744.2267367-1-volodymyr_babchuk@epam.com> In-Reply-To: <20250401011744.2267367-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.48.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: GV1PR03MB10456:EE_|PA4PR03MB6703:EE_ x-ms-office365-filtering-correlation-id: 9100af57-b86e-46f7-630e-08dd70bb061f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?SWMrZ3JtKzd2SGpwT1dZR3BLWndGNjhYSVhLdVJrWnpOaDZ1TlVtS3lRN0hs?= =?utf-8?B?bU00ZUQvVk5DbGJWVEhnUloxem4vZitYcHhpcGY2aFMxNnhJR2dPMHZqUElq?= =?utf-8?B?UEMwdXYySXpXQmNoM0F3YXAvTnpLNzhZMWRvaVRLdzJmd0hySmV0QTlxQzFY?= =?utf-8?B?N1NRdzFmZm1nbnpXMjB1eG16Zy83ZWM1SVhSNHhWa0dncDQ2WVlBazFlWmYz?= =?utf-8?B?UUZqWm0yMngxRmU1c0NpYTVjdjZQTXZZdm9TSExIMk9SdjRWdDBqQVN6ejFH?= =?utf-8?B?WkcwWkFjVUY0ZGFLc1lERStBSmFJTlBXSEVEYUwzdmtWUHlxRmk4WFJpRHpm?= =?utf-8?B?YVlldHFQVnNidU56V24rM09EZW5SU3lzVGlJYXY4Vmo4NGdBM2ZaWmJubWRV?= =?utf-8?B?RFpiUUxxak9VbkFsRmFDNjZhU2o5TmprOXZFa0laZU83c1R2dFJyUmpidzhs?= =?utf-8?B?Slh1a1NQWDVMZFVoK1hhc2F4TU1nVDNjOGZidXdPQllKSmJDNFQ2VEtNYkxL?= =?utf-8?B?NjZocWhUUDdIblRiekRRRzBDVWU0NW5SVU5LbEZCZ3FwRUFNNnRJUUQyOFpz?= =?utf-8?B?ZUprQmVMcTA0L0VwSEtQQWEwRTFDZHhoWUpSSTAvdDJmK0xwSHg0Uy9RRkRM?= =?utf-8?B?WVU3cmRYTEdpUDlNeUJ3djlxMFhVNXozbWxYUlpJY080SmhlWWFjVzBabEFS?= =?utf-8?B?Wm5jZlAzWDBrck4rOTNjcUN2TDhaY0RXUmw5MGoydEFWQmlLK2ZtRVIzbnBl?= =?utf-8?B?TmJRbDU5ek5HUjNXS1ZWSHU3MzlMZlIxVHlieTAzYnNkdzNOSEV1U2ZucS8w?= =?utf-8?B?Y1RPUWlhZmRHWG5uQnV5TUZOWWNIQWtobjIwUi8rdVlVNVB5cDQ3R21Zd3p5?= =?utf-8?B?REZrb0twcUpOM0RzckgvcWgyckxRNFF6VDZBdTRhMDVUeWUySHhLQTdsUFEx?= =?utf-8?B?MGdla1dzdWVXUy9zRjZSbWVTcURLQkV5OXltYWxrVXBXOUNKbFFvSG1xcGE1?= =?utf-8?B?Tnd1bnU4OWxjN05MUjVLckVHdlZ1QlltdXJaWVVWWEtYcU0vajM1K01mRUt1?= =?utf-8?B?ckxRNmk2OXN0ZjEwVlBUUDBsemhHN3RHSFVXTmc4Rkd0QzQrcGdGWG1hb0Ns?= =?utf-8?B?MW93cGFjT3BJenkvU3NUTktLK1A5K0J0eGVWbE5meFEzcG00SHhnRlk5bmds?= =?utf-8?B?eFNsbTdBVHFva3g3Q1l3SmNMSjNYZ09BSGJOZE5WTWJSVGh4Q0tXVU1Qa1ps?= =?utf-8?B?VjM2aUI2MmRzSkxOZVpWNVJPWWtGUk5oV3cvelBTaTUxbWY5QURaa2pxaHcw?= =?utf-8?B?dVZiNERwcFFLU0VFZzdnS25yaUxyaVdHN3ZqQUd2eFRucmUzN2ZNMHBhWUI2?= =?utf-8?B?U0R3bWl4MUJXRis5SDRHSnVuNVBBc3dPMEIvM21ZenhrcWNORkR6UXBWNnpC?= =?utf-8?B?ZjJjSVRkSnp5aklKZUNheFB6OUlzdkFOZFhvY3RpL21DYmZwT3lab1FWVm1z?= =?utf-8?B?bmFmWWlwMzkwaDMybHZWNksyWm5qMGdlVWhlM3BIc1dNM2diMmtBdFhHdmVD?= =?utf-8?B?SGNqaEZhSzR4aUJCNVh6L0UzMlZIbnVjQ0JmektlUGVQa1N0c3dkSm1XWHZB?= =?utf-8?B?bldBTkViV3BZMndMTnFVWVRGWCtCK2RsOGh2blF3a05nQXpVQjFLTlpDNVMr?= =?utf-8?B?MnZoR2hhUFBzZVJoMlIxR0QxNFRjaXdxRnFoMjVtVlZSUTFDdktaeVIwVk1l?= =?utf-8?B?TEVsNFREeFd2Uy9NNW1paWEvcDA3aVhhVDU3VG1uV3kzem5jRWpISE1janBh?= =?utf-8?B?b28zRjN1ZEtmT3lCSnl4S09lYUx3Qld1UnhXKzV0YXhPYWZrRk9hTEdkMmlo?= =?utf-8?B?c3dLVEVNeEROektyZElwa0c0N2dxVlZYb2FwTmdHY1lqc3owaFd1UzE1R3ZY?= =?utf-8?Q?ns7eJ6HRCQX4FlVbfmlKu7GdBZfK2Pq2?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR03MB10456.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eDI5ZEFnMFB4K0lkWi83SmFYYzBqVVN3cjduM0NOSjFRUFY1WVpXU0EwWS9h?= =?utf-8?B?Ym1MTTYvODQ5dlFRQlV0UTJqU3hUSm8xVC9rMHZKSnRXUEJYaEpHR2J5UzFU?= =?utf-8?B?bE5uY1NFdVJSbXFXVHpXcUMyN0M3MjJyc1ZjdG05NVpjY253UzhYcUJsNXd1?= =?utf-8?B?V09TUXdIZjZGNE9ZblJSREQxems5dWZZMzc1aGplK2ppOWFDUTBuMUFERUlJ?= =?utf-8?B?ajNVaWozaGkvRnZPcjhCVThmWUR6S1ZkaEtxaUtQMW9TSnFmdC80TDQyUlNo?= =?utf-8?B?d2JJMXBNazdvQ3FzQXc4WlRwREJsN3padDhTaXpURUhqaWNab2Zjdk5wSGw0?= =?utf-8?B?NUhJdVhJY3NJcFp2Q0VpVGdxNEUzeGlKbnJDa084S2hsVG5OKzQ5N1MzaWJY?= =?utf-8?B?d3laMHlOWTZ6V3ZzV1RkUWhGWFVqaTV5ZTFYTW5RcFJZVGpLbTd1clBPcUVN?= =?utf-8?B?aVZtM2l6TTM5ZDk1TnNLU1U1REZMRWdIdnVyTUZDQ3dmWVhabWJMa2dVUk1R?= =?utf-8?B?Tkw4Q2pTTktZTmlQVEh1R1VCemtJU3ZxNDlyYVIrNWZBaDd3QTlIYUVOSHJt?= =?utf-8?B?bVAxaEdwcG5vVlRWSENJWUlxeEZ0cndqOVZLazY1SkJIaDZlcjY1SWNlSGE3?= =?utf-8?B?RE1HWCt4Q3NFQUNPdDFvQkYwbFQ1OVkvL2k5ZXhDVTR6SllzbnJXam1PbDEw?= =?utf-8?B?QzZaQkdJN3Q3VVpWOTZtTElSTGdkb2xtNjFOT0hTWnRWTkhhTVgreFN1NVdi?= =?utf-8?B?dTNnMFRMcXhCUFVNcFRsc3ZqTnlOa3BHSUVYZ3pzL001RlJhcGkrbDM2ZENZ?= =?utf-8?B?V2tPNGxWSW5vNWdpTG1iZHJVaGhGV1NMWU1qRnVXMW9GaGdIRlVJVmpNdllB?= =?utf-8?B?dkxYOEhHa3RkQ2Zaa3FaZGs5bFlNV29xcTZvVW5qcWlkZlRVM3lEYmc1MndJ?= =?utf-8?B?M2ZvTkJwRlo3TFZUN2VhWnYwT3RpcFFPM0NkR1ZJNlpqbk9QL3A0WjI4V2gz?= =?utf-8?B?YkxOT3BidEJlbnhpTHJ2MDBVM3JtV1VyYUs2UWVXTGU2aERaODZPMWdlNkpF?= =?utf-8?B?OTVneFB0Z2ZRR1ZQSWxlUTUycVdxUE5ib3ZSZjlsT2NPbHVSZWl0Uy9nQjFI?= =?utf-8?B?WGhJMlpDb1FncENRMFJHRXl6bVliamNxeVpXVVJtbkI2YVBleVBnUG9Jd3pN?= =?utf-8?B?RE5yQXJBR2xYS05nMHhPeHREaDd1SWFid00rbnExVGF4SUsvUGdldTZBZ29x?= =?utf-8?B?R3FNaXVGSlF4R3l5Z2ZoRGxoOFNseEU4b2ZtemptcW5DemxRZ2I5b2hHTVVY?= =?utf-8?B?SFRlQnhCVEdDbmpkc2pQV1hxWFdncW8xQ2ZHbXZCcmhOMXYxcmRuelo3d3Zh?= =?utf-8?B?NWdvUzZXbmhRNnFUcW1SQUFEakdTaWxOR2x2MG1HWHI0ckVkR0lQU2lyVXVH?= =?utf-8?B?K3cveHN6N3k1NUtoa0orOXN1cml2V0dkMEtmb2Y4Qyt1THhyK1RiWHdkV1JE?= =?utf-8?B?N1dKRS93SWtDa2NUSVFXVTBYNUhtSFBGUFJ1T0xyM0tYckt5S1dvclVFa2c1?= =?utf-8?B?L2hRSzl1UE1IUkE5Z0pjdUNDdFdsY21YWTVYL2llODhnVmVWQnh6YTVWK3A4?= =?utf-8?B?cm1VOFVtVkg1N29tZFRPbzJndHdFamZ3TGd1VTZSaU9WbFZGSFRtVUtDZ1pD?= =?utf-8?B?U2pFdmRURDFFYXRrTEN3UzJUbWptTDRYZnltSTJhOW9PRy9pNzhDcDZCcE41?= =?utf-8?B?WUJSRjJtZm1yVWlpdGczNXBOWHNqSVFVSUVGM3ZPeVlYV1JmQzM1L2s1dHJ5?= =?utf-8?B?eGdwNlhQU3o5cXk4Qllxa05hakJVeTlzekxESytDSVhaZ2VBc3JVcnVwSXZ5?= =?utf-8?B?b2QzemxWQlNaSU5mdEM4MzZHL0lkTStVL1BHSGJvcnlpRXNRd3NEMkpIWi9P?= =?utf-8?B?bmtWYTdCQzRKaDVKSnpiOU5Td0ZTL2owSUhCcWF5bHI2UC9YcXM3QUZwOEhC?= =?utf-8?B?QVhSVmhweCtONkZYYzUwbU9DVUxRTGx2dGlPaFByLzEyVWtHVDBaelF1QUtE?= =?utf-8?B?US9DYk9taTNVcjdYY1dLbVQwV0RabmNLakM1Qzl1ZW5CT2huaHNBN25IVnho?= =?utf-8?B?cHZOU3lXUkx6R2h4TGpXdXpYbHFvOEJQTTVPZ1lPUFkvbnB2T0hDS2k5enE0?= =?utf-8?B?UEE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <6EE89C3D6CF6004F9DD0A0D8CB2A0C39@eurprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR03MB10456.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9100af57-b86e-46f7-630e-08dd70bb061f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2025 01:17:51.6593 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zsh/WTgvIvAxew5xeHXv1ZP/H3Z2PgHGa+1dOypOV9a0W3/WEpsEwP1+Vwbl1W8NknLMUk9Ef0Co+5/VBPsZGB5FbnIhnRo/WyfFmUTlXk4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6703 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1743470309953019100 While building xen with GCC 14.2.1 with "-fcondition-coverage" option, the compiler produces a false positive warning: arch/x86/irq.c: In function =E2=80=98create_irq=E2=80=99: arch/x86/irq.c:281:11: error: =E2=80=98desc=E2=80=99 may be used uninitia= lized [-Werror=3Dmaybe-uninitialized] 281 | ret =3D init_one_irq_desc(desc); | ^~~~~~~~~~~~~~~~~~~~~~~ arch/x86/irq.c:269:22: note: =E2=80=98desc=E2=80=99 was declared here 269 | struct irq_desc *desc; | ^~~~ cc1: all warnings being treated as errors make[2]: *** [Rules.mk:252: arch/x86/irq.o] Error 1 The same behavior can be observed when building Xen with "-Og" optimization level. Fix this by using "do { } while" loop instead of "for" loop. Signed-off-by: Volodymyr Babchuk --- Changes in v3: - Correct code style ("do {") - Add comment describing why we need do { } while loop. I prefer to leave do {} while because Nicola Vetrini said that this approach might help with MISRA Rule 9.1 without needing an explicit initializer. Changes in v2: - Use do { } while loop instead of initializing desc with NULL --- xen/arch/x86/irq.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index dd8d921f18..2f288704b5 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -264,15 +264,24 @@ void __init clear_irq_vector(int irq) =20 int create_irq(nodeid_t node, bool grant_access) { - int irq, ret; + int ret; + int irq =3D nr_irqs_gsi; struct irq_desc *desc; =20 - for (irq =3D nr_irqs_gsi; irq < nr_irqs; irq++) - { + if ( irq >=3D nr_irqs ) + return -ENOSPC; + + /* + * do { } while loop is used here to convince gcc14 that 'desc' is + * really assigned. Otherwise with -Og or -fcondition-coverage it + * may throw an false error stating that 'desc' may be used before + * initialization. + */ + do { desc =3D irq_to_desc(irq); if (cmpxchg(&desc->arch.used, IRQ_UNUSED, IRQ_RESERVED) =3D=3D IRQ= _UNUSED) break; - } + } while ( ++irq < nr_irqs ); =20 if (irq >=3D nr_irqs) return -ENOSPC; --=20 2.48.1 From nobody Fri Oct 31 23:32:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass(p=quarantine dis=none) header.from=epam.com ARC-Seal: i=2; a=rsa-sha256; t=1743470313; cv=pass; d=zohomail.com; s=zohoarc; b=i/og79SWHH6946mfKhcc6zlTj7QksCy+xdRfWFPAGg+Pd2f2OfJZBVrhGXqQ9CkR4gJy6OO+p2i5LHjskrnePk/zyGVl9uOMHZwjKuyPyCMJ6RKOirduZGLWhyFLbIgtieZzVSpdeJc7yIlQLaJrHRwl1+iZueeyDP/i5TAJxIk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743470313; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HGPtfu1XySmVw/zK9unEnF48Uef93WdT2NZnuvi0GjM=; b=TnOuGOKWoLC9++/+1WK2EWSyhm1pjCLbKfEOJ07pWvmx5q6VNLCj59WwjY5QLmgeGKs4NLLXPXSkvom+YA049MlVCuwlg4njw42sVih8FLimKrYALQmDqfWw7Yg3ZOI3lj1rYkVnhiHWr6sFd8HJeLs1UsqBE5DFVVeYLBNvtjw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=epam.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1743470313471430.39712116167846; Mon, 31 Mar 2025 18:18:33 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.933349.1335346 (Exim 4.92) (envelope-from ) id 1tzQGN-0007To-Nz; Tue, 01 Apr 2025 01:17:59 +0000 Received: by outflank-mailman (output) from mailman id 933349.1335346; Tue, 01 Apr 2025 01:17:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzQGN-0007Tb-LD; Tue, 01 Apr 2025 01:17:59 +0000 Received: by outflank-mailman (input) for mailman id 933349; Tue, 01 Apr 2025 01:17:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzQGM-0006nG-Ce for xen-devel@lists.xenproject.org; Tue, 01 Apr 2025 01:17:58 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20630.outbound.protection.outlook.com [2a01:111:f403:2607::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 245813c6-0e97-11f0-9ea7-5ba50f476ded; Tue, 01 Apr 2025 03:17:56 +0200 (CEST) Received: from GV1PR03MB10456.eurprd03.prod.outlook.com (2603:10a6:150:16a::21) by PA4PR03MB6703.eurprd03.prod.outlook.com (2603:10a6:102:ec::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.46; Tue, 1 Apr 2025 01:17:52 +0000 Received: from GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e]) by GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e%4]) with mapi id 15.20.8534.043; Tue, 1 Apr 2025 01:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 245813c6-0e97-11f0-9ea7-5ba50f476ded ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Oj+tm7K88H1MPomCItq+65O8sldxVITws5ECAYwPaFuFd8OMpYF6sTrLRHxaBQzcwoRO6o01Bep1Dd9K+PLR2DsjXewyw/JT2DO88KbfTHr9uNvBHmxjssO4Wmg6odxAjRFKbZuFDm4BEeFF4EB2w8o7eBc3uljOCSwGTERvURgjePz/whmkrLIMQ5UNUrh7dd5fxp4WGh4Nzn82dbzI5U5jQn5q8C8cfKQs7+Ru32RLt3UKFNonNzu9sAx+v42VPA7r/QWKyez2TOaxSLiB9a1hp+cFEpw8cMR5boi6iF2AMPjjMezK+Pe9iWWrOxF9SS2QfvHY2iujJpcf1i6cVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HGPtfu1XySmVw/zK9unEnF48Uef93WdT2NZnuvi0GjM=; b=e8K2eMp3aRnoPoUtuAnQxa2oI+MtKt7CQW9vMI5/JdBXLSKw3MFvmrLn/TZk7nmczmKK45rElcmtP/vIXVlc9wHnyWGk6Dak1KmcAwQYbhKNwpIwYRqeQTFkeb2DCMFUnUCuqLSokXnIqSvcOI8UamgdhSb/zZMkHrKJ9KMRMYq4IKsNSvrpLxqbvLpnz0EodwIKorx1tXoxvFAt28rBak4dk9DdNJAy6gqsOCv7QNJ26ucgh0zQY5mWsV9Dvr5WU9IK74jlc2WpcQjsls3rqFxRyUR2XafV6M0A2d9i0aUHImxVQzUCnxdCKn/xC6qh8HuK9hqych/VFEOktOrvWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HGPtfu1XySmVw/zK9unEnF48Uef93WdT2NZnuvi0GjM=; b=QIyQF/3BBmLCCUbx7fSOsupVbRyKEukdcYmFNy7RLNSoxvgoRWNH+F8NnF0h1K6kJV8qXNmiwKt6EdGo1cbKUsyFV/yfT60k2BsYhCnTY6rpncpRr5MPDblFEl+WJKA+xT2l+k9Usvb2VWcoTgI0R6f0oG3g4u5wajGx5VqlGQVM5ksxtUQkBZbCP/qQBI6sDcgJw6TsG0JIu/49Q9O+ZtluurKxQdp6jn1BPNBjhv7ksITzBmigEE4kaddErnA43oyPK+1/OP3oVMnNyfkn5WJLzX5gu5KJsMOgg61+IBD5L10OjyZQPiGrx8JDEaeU6c1qFtRup9o8e1Dwrjnjgg== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Stefano Stabellini Subject: [PATCH v3 3/3] xen: debug: gcov: add condition coverage support Thread-Topic: [PATCH v3 3/3] xen: debug: gcov: add condition coverage support Thread-Index: AQHboqPjQYlXeZrAE0u+zEMqLR0ZhQ== Date: Tue, 1 Apr 2025 01:17:51 +0000 Message-ID: <20250401011744.2267367-4-volodymyr_babchuk@epam.com> References: <20250401011744.2267367-1-volodymyr_babchuk@epam.com> In-Reply-To: <20250401011744.2267367-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.48.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: GV1PR03MB10456:EE_|PA4PR03MB6703:EE_ x-ms-office365-filtering-correlation-id: 399a3fc3-8d76-4b02-68f6-08dd70bb064b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?Jg/adk7Pyci12INTJhjq7QhoMvO4U8qyLLFmtl62heHCbflCPXprux4npv?= =?iso-8859-1?Q?Cj3qXUGEN33w7oH8i/p3lt8i4Maxqm81eUBv8S/VZE5H/Ts6kDujmTeI8T?= =?iso-8859-1?Q?eArPLxjPI9IAxPh+QZanQ/DD0nU1TncB9gY2zSYmjfmKbMGSCm7wjoCqBj?= =?iso-8859-1?Q?BgfqSnizv6oU0KJnKKXfRPMG8Zm2zqhcPpZ58ZqcezLAFcjmPz5UnhIIT4?= =?iso-8859-1?Q?4Jsl6HalAXsszYYUpNxreqxqJYzvDsHqG6FZS7YXQQQApkrbNdpA+Tya/U?= =?iso-8859-1?Q?aunDnsRx/VCgEGI7NQ4MLMkz2KQbWCvHznRi3w43NONOUBzI+yzwUkjekK?= =?iso-8859-1?Q?7Lcfv8Ps/GTqEBVcuwd4c9WWAVb5mFC79gKtcxNTu7J6ay4dtBo+RKLBH9?= =?iso-8859-1?Q?yDdp1WrtwsGLBnaA2PscFTkLkvJlk0YFjVCNI0osGkJOJMdCNy8apM6Bol?= =?iso-8859-1?Q?uT06wvMfsrTzhKqx9VwTsu8Xe4Snvk+t2iAI/kK/VJ2Q5f15AsfUyn9fus?= =?iso-8859-1?Q?YpVuJWFyt9XlA05sB9D+SwPeqPJuXpa+2qaoN+teoiGYODMjs3wjdiV2SZ?= =?iso-8859-1?Q?xNp0mnKICTEKDRwey+e5z/oXHYu014CkJtu6eN/grtWTpNO83/QNonZCSw?= =?iso-8859-1?Q?aLi5Z9SOIHe1H/srqAqjx9s1ulHQGOLS0lqjvJgeP+cTHVi6Djj9gj36zo?= =?iso-8859-1?Q?yAv5ImxPoSFEQaLSH+zyypWi3FIRvjyVjPDirFiOQ+mJ6P4JgJM2lG59bH?= =?iso-8859-1?Q?kfTztwx7HauhZyR2zTALGBoGM/p2RReLURsfNOs+pDvYPYviwgsd/wq2y1?= =?iso-8859-1?Q?V6OxonVH7bab0HPG4VrXJeB4UUPy/Bfc/B1qZW6+3zmfbo3h3ptMQH1AeI?= =?iso-8859-1?Q?YJCXIhWAV4JDFQvfQI8LV6OAj7U6MpHXy/dmXH2YJNQ99J6l44ZcJXOeJY?= =?iso-8859-1?Q?XfZF56T0VKAtNchsaB3p6mK9nMEBwwnPPLAsQsD/3pDI/j8lny0g6kpaUl?= =?iso-8859-1?Q?eQ2UXbvtFuKgYMH8T6d9udCfVpWnrgz7hlhQ/2V/UXAYX2InTCf/UKLBbI?= =?iso-8859-1?Q?Nzxb9veyCwUz/I8NVsGkoOn9lBSvUTSKC38E5AcNJ3D3Szs5J4WKGmkJLc?= =?iso-8859-1?Q?gYT7j/vqhePrhh+KFsz2XlGFM1QvBHgdWNbHRXcuDjUZK3Xdj2XUtCYiQs?= =?iso-8859-1?Q?QvIL42lQtCWgRWERxHbawq0ys4+z8F4PgNTfI4DH528XqLPuoZpZ/cPo+N?= =?iso-8859-1?Q?GbmjRfhx5/bqVjIM0FOhV6Wl3Z58CColRSEcCoPn8DcN/DmOcRZ19SMm71?= =?iso-8859-1?Q?UKQLma1lhSquEDxl+2lI/h6bMemLKjBHHmdI4pAD1z4x9w4b2CFAaPxQ4i?= =?iso-8859-1?Q?pCcuBXm+QT2UOlJm2xlFqTzKiU5QU0prQIiLbjBLQjU423H32IH2IyKGZV?= =?iso-8859-1?Q?iYSupNSwoDSWUiTPzlk0WpKUXCQejo459XThhzviqGNQ5gDpjqB+AIcHem?= =?iso-8859-1?Q?XHhaLzBbHe5UT5SqtGp/5r?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR03MB10456.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?hMD6/aby3vH4GXE36eywehfK2XS9uI4P1nw7FuHiB1ZMU6SwBuMm34rosL?= =?iso-8859-1?Q?ysamHclTW6Ot02r0lSJUjjF9N/Q0LMD+Zm07737cIdxktu4SYmkjY5X70a?= =?iso-8859-1?Q?XG+QU2ogB4DuBwTo6wh6T6zRIisJDpxJ+y9W238vqhOinPFYc1VfdyyB53?= =?iso-8859-1?Q?uqSRTAcqlqKyubFceZTkxOiJcMeeGhRObrmV2Bcuijxifp/nchzLD+KyPR?= =?iso-8859-1?Q?Ka7npV/LRj06GCXwaor2YBZOOD4BoCYz3ecItOOi3Ib6qtvImZczRduMQT?= =?iso-8859-1?Q?quEZ1z27B5JTwKj10RUxSRvvkRatJ6JmKxh4mJO9AZV2nvxUkReJOp9UAS?= =?iso-8859-1?Q?48Asx6y30ZPcF3lddyPw4UY4BcHr6+MEkDBbZ+BSCgS/G74DYs8uchQNUn?= =?iso-8859-1?Q?WtUqoEIHdfNW/1Zh+4NFqH9XTGBke6uMwlrN7rVGG2xA2bgfZX+duRvAcG?= =?iso-8859-1?Q?HoL+hPj9mVV1ei9+ScZIWe6hd6VDqKuQvrHtrAzjYqZqJfBsadz0+PjS4u?= =?iso-8859-1?Q?uNjOfPnR9D+KN4ZWJ0/dth2fuEhQ/faj/IenSmI5wqKnPtL3qDsz19ZIEn?= =?iso-8859-1?Q?cSEomY60XPnl6jPzWwKNpShskuDD/15wY7utiiVPPjiMDp/mKLqyfhx6xY?= =?iso-8859-1?Q?IxcA2HkSHNyLhRGTe4nO1lCqitRSl1ql3LcP60ZFdzg5S2V7wegWiIpSkn?= =?iso-8859-1?Q?zWrpCEFE6k9L+mQbTn9s9hapqvLfoJGOMWCdbE1/WUTN/bUzznbkEhUGlY?= =?iso-8859-1?Q?yRATe+5OVIFLZvPozcGxid4gFNAjwi+RIVgV6A7z7OV8yuWUSwtCaJ4hje?= =?iso-8859-1?Q?crvtYLVcl+sK6YJc1fJUdfthziqUSRphEHxCdxcfCZ8+TPdvz8RknrkUb7?= =?iso-8859-1?Q?1PSmpMgiMsV9cC3IuIxWg8l6S/NluJP0tiJVTT21/Q7pEq2spAHsDNW6cr?= =?iso-8859-1?Q?ay0P98jp5Ux3l0GNfGs0CRI5nv9/jarhZ5b0aHdKvPQJiLA9jhIxBOB6F3?= =?iso-8859-1?Q?VUrgcRZGCwC7GmIVIWqAe5EvMjTMXpjJ3/yBgLngSVCWZ/pSxTZ/29xej1?= =?iso-8859-1?Q?PYzg3fPvS1/DC4Xob8KLcZjj7TArTYf7thZt/b5G2jT4kYWHZCNYrD4Zj+?= =?iso-8859-1?Q?FSzVm66kqR6qMoMqe3NMX76BvcD60KnYmzuJcWV7XxN1CVPRIbQInAPEsR?= =?iso-8859-1?Q?zj4rZ0IeR3eXIh9zFfXgsX+Zq3g4YbeMqlPfzB2rJBaSYAXdg2oWICAVXk?= =?iso-8859-1?Q?U/I0ZInME7hm7xcvEDk/0Bu5PCR9MqHenDgFU/YCwZpxeKzJfw6YlrWISX?= =?iso-8859-1?Q?ujGdlfW0VgFIq+FKauS70IhG6odjVSN2Vo1EW1x5zrQJu87o42EiRl/6HN?= =?iso-8859-1?Q?FO7SYIIlJiX0GSfH4NInNPvrXdVsdGfRhScMSk8Rhs+4u3E1wNJswZ04Vy?= =?iso-8859-1?Q?odwavlBe9U6zwo8YWon3yAWvNrbsk2e16IeKt6oCy6/faMXJVSNBKwkoaE?= =?iso-8859-1?Q?tlOEEFmaGHrIGfkfzU0hhzBqD4cfRBeD5aJjFH1iVlxxB/iU/OUSfcZqU9?= =?iso-8859-1?Q?OIj2Z/+8W5/x/q9IsBPwEKXzhWOwfcRg8qvfZs7ImK47ArB72jFEXk1IhR?= =?iso-8859-1?Q?00aiA0srN1IH+rNpe1GUc+G2TFMtXb9SLsAU6qH+w/CrKJ/DvG607Pvw?= =?iso-8859-1?Q?=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR03MB10456.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 399a3fc3-8d76-4b02-68f6-08dd70bb064b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2025 01:17:51.9544 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T7+UJ9blVH+nnhdI5iEPRDZCA9vRPblO5Gjod5i2A8fMYI+rg4NXqSNdfswlmS21fV/GDNtAmorupBKIBoq5eeymKCeRZ/g5kca8iKM4zFA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6703 X-ZohoMail-DKIM: pass (identity @epam.com) X-ZM-MESSAGEID: 1743470315527019100 Content-Type: text/plain; charset="utf-8" Condition coverage, also known as MC/DC (modified condition/decision coverage) is a coverage metric that tracks separate outcomes in boolean expressions. This patch adds CONFIG_CONDITION_COVERAGE option to enable MC/DC for GCC. Clang is not supported right now. Signed-off-by: Volodymyr Babchuk --- Changes in v3: - Introduced CC_HAS_MCDC that checks if compiler supports required feature Changes in v2: - Move gcc version check from .c file to Rules.mk (I can't find an easy way to check GCC version at Kconfig level) - Check for gcc 14, not gcc 14.1 --- xen/Kconfig | 5 +++++ xen/Kconfig.debug | 9 +++++++++ xen/Rules.mk | 3 +++ 3 files changed, 17 insertions(+) diff --git a/xen/Kconfig b/xen/Kconfig index 2128f0ccfc..2bdebfc808 100644 --- a/xen/Kconfig +++ b/xen/Kconfig @@ -41,6 +41,11 @@ config CC_SPLIT_SECTIONS config CC_HAS_UBSAN def_bool $(cc-option,-fsanitize=3Dundefined) =20 +# Compiler supports -fcondition-coverage aka MC/DC +config CC_HAS_MCDC + def_bool $(cc-option,-fcondition-coverage) + + # Set code alignment. # # Allow setting on a boolean basis, and then convert such selection to an diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index f7cc5ffaab..f89cbd823b 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -44,6 +44,15 @@ config COVERAGE =20 If unsure, say N here. =20 +config CONDITION_COVERAGE + bool "Condition coverage support" + depends on COVERAGE && CC_HAS_MCDC + help + Enable condition coverage support. Used for collecting MC/DC + (Modified Condition/Decision Coverage) metrics. + + If unsure, say N here. + config DEBUG_LOCK_PROFILE bool "Lock Profiling" select DEBUG_LOCKS diff --git a/xen/Rules.mk b/xen/Rules.mk index d759cccee3..0a2933cffa 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -138,6 +138,9 @@ ifeq ($(CONFIG_CC_IS_CLANG),y) COV_FLAGS :=3D -fprofile-instr-generate -fcoverage-mapping else COV_FLAGS :=3D -fprofile-arcs -ftest-coverage +ifeq ($(CONFIG_CONDITION_COVERAGE),y) + COV_FLAGS +=3D -fcondition-coverage +endif endif =20 # Reset COV_FLAGS in cases where an objects has another one as prerequisite --=20 2.48.1