From nobody Wed Dec 17 10:26:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1742287713; cv=none; d=zohomail.com; s=zohoarc; b=QX2BOqOVBPH4GvNZPdAzYUKuNO5/vUfqxxb/aUOyMuoX3GTRZ/WkgmKzFaLhuUeMrHitAmrll8q5CB6EUCvsHiNO9lQaB2XlQIRn7PfJzp8FZTllHzk92f4zmEGL3cgPW+B8adj7RgzxxkWDvnrkz0ypcPXsSiU854VAG6gnUvE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742287713; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ThJQB3tJJbLra9ACRWvyMzL1XPDAWQ8f8WNTPFDs/GU=; b=AD9N5QnTDGPS2exT4S40XJ7vCJ2t0wpWcfwKot0qAQ2MWdqgHyhofoMROFIAvPZmdsDmwQhMkSYGFSFHIF1BFoLeSo5jlf74+YpYxsK3LWJilymHtVNP7hN7vMg7vHjfP+jrM3y/SXvClgLynR4U3C987IMv4MFvOFOxdCexdYU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1742287713080178.36129494430077; Tue, 18 Mar 2025 01:48:33 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.918643.1323288 (Exim 4.92) (envelope-from ) id 1tuScC-0008SS-Eo; Tue, 18 Mar 2025 08:48:00 +0000 Received: by outflank-mailman (output) from mailman id 918643.1323288; Tue, 18 Mar 2025 08:48:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tuScC-0008SL-BL; Tue, 18 Mar 2025 08:48:00 +0000 Received: by outflank-mailman (input) for mailman id 918643; Tue, 18 Mar 2025 08:47:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tuScA-0008SA-PM for xen-devel@lists.xenproject.org; Tue, 18 Mar 2025 08:47:58 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b015bca6-03d5-11f0-9899-31a8f345e629; Tue, 18 Mar 2025 09:47:56 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43cf034d4abso32732945e9.3 for ; Tue, 18 Mar 2025 01:47:56 -0700 (PDT) Received: from localhost ([84.78.159.3]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-395cb3189a0sm17833911f8f.67.2025.03.18.01.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 01:47:55 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b015bca6-03d5-11f0-9899-31a8f345e629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1742287676; x=1742892476; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ThJQB3tJJbLra9ACRWvyMzL1XPDAWQ8f8WNTPFDs/GU=; b=emD5KraCIyOXtNRyosduVnLUPBBanSDabFtNn5fI2W1cSddfPfuLrVw9UnDt9yg0Ua gxPU/zmDktE+SCVRjmqohZoGY4C/P6Ccb2bdmbELgAA3hQes4QMWeV9eae5y0Javdy/A JTCtmhBUej/cy5G42Rxgoa/iHfEaK8VckkbWE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742287676; x=1742892476; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ThJQB3tJJbLra9ACRWvyMzL1XPDAWQ8f8WNTPFDs/GU=; b=MxNzTG//EcHMX9ssH9fM135zXvPKGCbnJxx9Yw2H4BqrsrZwwvWKtND0UVBnkOTwiE KHxfwrjoLpiOpJUw7cl9x+drHyoMekr4SI8T6osvjtR2HHuJDdygSSZbVPd9K9n0BlIa ldE98XLKitE41MOvJ4vj+UyiklhBzzxzrgPxgKFQH2uNvkPeMQS5tGW5IBPxudw3FZPM r67pOyYEesNYg8EQ1N059aYMq5xZu2EFfFeSvsKuwufSDaI0ljG3H6bC/OlK7yu6MFvF S9L+kLFMtPpB7NXa1eudqBN/TgYQMLJ9+1j3cU8qgChJulNAB4LmmCC8+Tn7eCZW8fK4 OmRA== X-Gm-Message-State: AOJu0YzkOm/ySIuxnP38uDKj58EEDxGvfCuAwiaFTRSnVAKl9s3j0xvy JdgHKEUCpmI4Ja9bYSXW31er4mBTNs2mVAFN8byttfvuBbCGK2rvgPNHMW3r0xhOaECLwg8WFDi 2 X-Gm-Gg: ASbGncukwiReWm8c3UDfXORfCYs0O/Hj8QcABYt+SGHmApivukFYWG/JLoXmO++SeUU N5X2WHt40LBK6X7K6E+3tgIOXp9UxQaXqkwYhzBr43JVdOuSWZ3yv3gq3WhUEFnoCUcqfAS3cjl FN8pvviUSycGD8YvFU4LYCs7qtW1pgJjBFZwmR5gmlDv7FkxQ71NrRcbSwXxC9u+YR0agfzgDY9 Fnmds9bxTURMnak80AfUrg4nze/b4fbeTWOwdmwpwOQb5wWJeUP+sSmbU2ibhvsMcAejqcnVrr0 X4C1RVww61B+SNcRaKLI8XmCBgJLTsu4gykXK9xJraKyb9eXuA== X-Google-Smtp-Source: AGHT+IFAbL3jipT1NLsrdSSW895ADiBLnHqkdUS3/JN1fy5bvxM6Wry2YwrlpspAZfDJqWGFtWm+eA== X-Received: by 2002:a05:600c:63d1:b0:43c:ec28:d310 with SMTP id 5b1f17b1804b1-43d3e14fa7dmr7344865e9.10.1742287675872; Tue, 18 Mar 2025 01:47:55 -0700 (PDT) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper Subject: [PATCH] x86/msi: always propagate MSI register writes from __setup_msi_irq() Date: Tue, 18 Mar 2025 09:47:25 +0100 Message-ID: <20250318084725.52261-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1742287714593019100 After 8e60d47cf011 writes from __setup_msi_irq() will no longer be propagated to the MSI registers if the IOMMU IRTE was already allocated. Given the purpose of __setup_msi_irq() is MSI initialization, always propagate the write to the hardware, regardless of whether the IRTE was already allocated. No functional change expected, as the write should always be propagated in __setup_msi_irq(), but make it explicit on the write_msi_msg() call. Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich --- I haven't actually spotted any cases where this would go wrong, but better stay on the safe side and always propagate the write there. __setup_msi_irq() should not be a hot path. --- xen/arch/x86/msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index 8bb3bb18af61..5389bc08674a 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -532,7 +532,7 @@ int __setup_msi_irq(struct irq_desc *desc, struct msi_d= esc *msidesc, desc->msi_desc =3D msidesc; desc->handler =3D handler; msi_compose_msg(desc->arch.vector, desc->arch.cpu_mask, &msg); - ret =3D write_msi_msg(msidesc, &msg, false); + ret =3D write_msi_msg(msidesc, &msg, true); if ( unlikely(ret) ) { desc->handler =3D &no_irq_type; --=20 2.48.1