From nobody Mon Mar 10 02:48:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1741273091; cv=none; d=zohomail.com; s=zohoarc; b=c/bvBpGBX2qE2yYX3gcw7YiJ0HP8bWXgRs4U/MRc5u1mbaJqTYMlflKh17R7oA7SCK1+0+VwRK9J0Rp4btOnnBsLA5myZQgoLnxrco/Li2cBmbEUivVLxPcnRjuETuvHJ/9xnNagDCnrtvRhjk9HD0hD0lUuG/hPBeXoNLN+KFU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1741273091; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vNP8vm8lWdnrLbuaqz+aHqlLq12YGejtAmi/o97vgI4=; b=Rp/M8qwfyfnrKT3m4yAUlundX30vfW1w04O8B6IhhHi0+jffp+OlROg84k1Tt26EyRMxSbYScoRgbefrDfECW4RAH0ACxs+fOuvhAQ3tAy1nHCsF+o2Imx3PLYPMeWuha5U9xoZYP6zPl+Yt6QEfsIEPvPV5e6T7JgnAz7K05QE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1741273091527279.4527639206834; Thu, 6 Mar 2025 06:58:11 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.903670.1311644 (Exim 4.92) (envelope-from ) id 1tqCfZ-0003cC-TQ; Thu, 06 Mar 2025 14:57:53 +0000 Received: by outflank-mailman (output) from mailman id 903670.1311644; Thu, 06 Mar 2025 14:57:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqCfZ-0003ba-QD; Thu, 06 Mar 2025 14:57:53 +0000 Received: by outflank-mailman (input) for mailman id 903670; Thu, 06 Mar 2025 14:57:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqCfY-0003Ye-Tn for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 14:57:52 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60063f9f-fa9b-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 15:57:51 +0100 (CET) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-ac202264f9cso142640466b.0 for ; Thu, 06 Mar 2025 06:57:51 -0800 (PST) Received: from localhost ([84.78.159.3]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ac2397366b0sm108721266b.95.2025.03.06.06.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:57:49 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60063f9f-fa9b-11ef-9898-31a8f345e629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1741273070; x=1741877870; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vNP8vm8lWdnrLbuaqz+aHqlLq12YGejtAmi/o97vgI4=; b=TJdmp6Zu2lFXbVJPlBCUJK3UujvTS4qKcLTax0etcuECMKZcTocI2ytum4Lcz+lefG hSrk2PlVB05Uvq7kzDGgr0M7OxamurAdQCDRGCWFkw+xUWbI5ym3+mdif2bTHt9eFath hzGqjBzYfZvE/abCID7GfBiy0avKXlhiPSd+c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741273070; x=1741877870; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vNP8vm8lWdnrLbuaqz+aHqlLq12YGejtAmi/o97vgI4=; b=jdSISu1sUrXdTAmk5CDL7X4S8naIi8rUY1RFa/BDWN57u3yM7JwAZxXZreXMXvH6bm 9RoV58fpuQKJaW5YFy58smqLnoWQkicGUScpvXGHxQlUy5n8O17DzpULSg9hI+lRa3S5 m/2WDTAMOsi4+L4tADiCZg5fAgXHrDhsymkLjTHAeLN/2YIH4nEmKkwqYcL4i6Hzn2l9 QppPfsCuOIxPAq1lVC2Z3Xxg0KEzuRE8eDiT0uIRGsD+BrYucBHRWzuTXRd7mie5s8sO jWj6bRvN4S+5CXMDYTHjZ8wkIF16b2Ahv+Kzs0zMcS88mZqbq7t3W5uL1OEacZ3QgGH3 4VXA== X-Gm-Message-State: AOJu0YwYSEdoHh3/8nNbWCQVTyewLMkXSBFghJjH4t08cLvX4Vsl6y8J fozrjJY0hU/f6fXLBJaVNxpHZ5xcAjjGFxGX2MYuM0NFFG8n8aUoxTUFZdCo7NEbNfqLanVKFvH 1 X-Gm-Gg: ASbGncuuN+lN0kKKONbC/V5GzkJBLuptNuuKm4Y62XzMMNeaMdurhLKfZQ7fbK4cgv5 RH7MR0hLnDSNUDoqGnkqnXANTfVVPplyDK8p2Ck2052yERtCXWcszva44mq2RyliIzzqLctUkNw SCkI5/jLqzPOMY06qisUYg3QL7bSaBfhIqWj/dPu9etLMpRYnj7qel9Mpn03IdBoRULr4AxgZUI khF9w0WKDPXRksRlJ1JozwgHqKJV3VT2M/SOty5wAbVGdAbOj0+gMMwZ3J9hkFMjAiGp2xIsL6M njHMDvTRGNZmMgg1ceGeii5qsC+e/MuT/I/JKloHrelYS7u2qw== X-Google-Smtp-Source: AGHT+IG0pm1OZ77YuKmjL3LH/3H8U9L5m9NV2t1kaq5tZs3yxKMeA8gmbqAImUfjwe6gxUaizZysVw== X-Received: by 2002:a17:907:7ea6:b0:ac1:e00c:a561 with SMTP id a640c23a62f3a-ac20dac2c06mr781304266b.18.1741273070145; Thu, 06 Mar 2025 06:57:50 -0800 (PST) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper Subject: [PATCH v2 2/3] x86/msi: don't use cached address and data fields in msi_desc for dump_msi() Date: Thu, 6 Mar 2025 15:57:32 +0100 Message-ID: <20250306145733.99927-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306145733.99927-1-roger.pau@citrix.com> References: <20250306145733.99927-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1741273092169019000 Instead compose a dummy MSI message just for the purpose of getting the delivery attributes, which are the same for all messages. Note that the previous usage of the cached MSI message wasn't fetching the hardware MSI fields either. No functional change intended. Signed-off-by: Roger Pau Monn=C3=A9 --- xen/arch/x86/msi.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index 6c11d76015fb..8efe41b1526c 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -1454,6 +1454,16 @@ void __init early_msi_init(void) static void cf_check dump_msi(unsigned char key) { unsigned int irq; + struct msi_msg msg =3D {}; + uint32_t addr, data; + + /* + * Compose a dummy msg message for the purpose of getting the delivery + * attributes. + */ + msi_compose_msg(FIRST_DYNAMIC_VECTOR, NULL, &msg); + addr =3D msg.address_lo; + data =3D msg.data; =20 printk("MSI information:\n"); =20 @@ -1461,7 +1471,7 @@ static void cf_check dump_msi(unsigned char key) { struct irq_desc *desc =3D irq_to_desc(irq); const struct msi_desc *entry; - u32 addr, data, dest32; + uint32_t dest32; signed char mask; struct msi_attrib attr; unsigned long flags; @@ -1495,8 +1505,6 @@ static void cf_check dump_msi(unsigned char key) break; } =20 - data =3D entry->msg.data; - addr =3D entry->msg.address_lo; dest32 =3D entry->msg.dest32; attr =3D entry->msi_attrib; if ( entry->msi_attrib.type ) @@ -1512,8 +1520,7 @@ static void cf_check dump_msi(unsigned char key) mask =3D '?'; printk(" %-6s%4u vec=3D%02x%7s%6s%3sassert%5s%7s" " dest=3D%08x mask=3D%d/%c%c/%c\n", - type, irq, - (data & MSI_DATA_VECTOR_MASK) >> MSI_DATA_VECTOR_SHIFT, + type, irq, desc->arch.vector, data & MSI_DATA_DELIVERY_LOWPRI ? "lowest" : "fixed", data & MSI_DATA_TRIGGER_LEVEL ? "level" : "edge", data & MSI_DATA_LEVEL_ASSERT ? "" : "de", --=20 2.48.1