x86/pv: don't populate the GDT/LDT L3 slot at domain creation

[PATCH] x86/pv: don't populate the GDT/LDT L3 slot at domain creation

Roger Pau Monne posted 1 patch 2 weeks, 1 day ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20241121171504.55383-1-roger.pau@citrix.com

xen/arch/x86/pv/domain.c | 6 ------
1 file changed, 6 deletions(-)

Expand all Fold all

[PATCH] x86/pv: don't populate the GDT/LDT L3 slot at domain creation

Posted by Roger Pau Monne 2 weeks, 1 day ago

The current code in pv_domain_initialise() populates the L3 slot used for the
GDT/LDT, however that's not needed, since the create_perdomain_mapping() in
pv_create_gdt_ldt_l1tab() will already take care of allocating an L2 and
populating the L3 entry if not present.

No functional change intended.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/pv/domain.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c
index d5a8564c1cbe..7aef628f55be 100644
--- a/xen/arch/x86/pv/domain.c
+++ b/xen/arch/x86/pv/domain.c
@@ -376,12 +376,6 @@ int pv_domain_initialise(struct domain *d)
          (d->arch.pv.cpuidmasks = xmemdup(&cpuidmask_defaults)) == NULL )
         goto fail;
 
-    rc = create_perdomain_mapping(d, GDT_LDT_VIRT_START,
-                                  GDT_LDT_MBYTES << (20 - PAGE_SHIFT),
-                                  NULL, NULL);
-    if ( rc )
-        goto fail;
-
     d->arch.ctxt_switch = &pv_csw;
 
     if ( !is_pv_32bit_domain(d) && use_invpcid && cpu_has_pcid )
-- 
2.46.0

Re: [PATCH] x86/pv: don't populate the GDT/LDT L3 slot at domain creation

Posted by Jan Beulich 1 week, 4 days ago

On 21.11.2024 18:15, Roger Pau Monne wrote:
> The current code in pv_domain_initialise() populates the L3 slot used for the
> GDT/LDT, however that's not needed, since the create_perdomain_mapping() in
> pv_create_gdt_ldt_l1tab() will already take care of allocating an L2 and
> populating the L3 entry if not present.
> 
> No functional change intended.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>