[PATCH] MISRA: Mark Rule 8.4 as clean

Andrew Cooper posted 1 patch 2 weeks, 3 days ago
Failed in applying to current master (apply log)
automation/eclair_analysis/ECLAIR/tagging.ecl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] MISRA: Mark Rule 8.4 as clean
Posted by Andrew Cooper 2 weeks, 3 days ago
All violations have been fixed up, so mark it as clean.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: consulting@bugseng.com <consulting@bugseng.com>

As I've not committed "xen/bootinfo: Include declaration for
fw_unreserved_regions()" yet, I'm very tempted to drop the churn in the arm64
line and have this as the singular patch adjusting the clean list.
---
 automation/eclair_analysis/ECLAIR/tagging.ecl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl b/automation/eclair_analysis/ECLAIR/tagging.ecl
index 7944ce2ee3b2..755ea3271fc9 100644
--- a/automation/eclair_analysis/ECLAIR/tagging.ecl
+++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
@@ -47,6 +47,7 @@ MC3R1.R7.4||
 MC3R1.R8.1||
 MC3R1.R8.2||
 MC3R1.R8.3||
+MC3R1.R8.4||
 MC3R1.R8.5||
 MC3R1.R8.6||
 MC3R1.R8.8||
@@ -115,7 +116,7 @@ if(string_equal(target,"x86_64"),
 )
 
 if(string_equal(target,"arm64"),
-    service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3R1.R8.4||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"})
+    service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"})
 )
 
 -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"}

base-commit: 3128d7248f2ad389b8e9a3e252958cbfbd1898ee
prerequisite-patch-id: 46b8fc2e9df2fd6be1bbbd6b50463e0e15a8f94d
prerequisite-patch-id: c122b170f57ab96fe52c37aebf1f4bb366194637
prerequisite-patch-id: 1c2d96bf17c5da0981b6c62939d3b7cc1e05933e
prerequisite-patch-id: b3e43902729416e18b4fada7f529b4cb02b1815e
prerequisite-patch-id: 9cb4598ff123c3b153f50f08798ad66a849c1af6
-- 
2.39.5


Re: [PATCH] MISRA: Mark Rule 8.4 as clean
Posted by Stefano Stabellini 2 weeks, 3 days ago
On Tue, 19 Nov 2024, Andrew Cooper wrote:
> All violations have been fixed up, so mark it as clean.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien@xen.org>
> CC: consulting@bugseng.com <consulting@bugseng.com>
> 
> As I've not committed "xen/bootinfo: Include declaration for
> fw_unreserved_regions()" yet, I'm very tempted to drop the churn in the arm64
> line and have this as the singular patch adjusting the clean list.
> ---
>  automation/eclair_analysis/ECLAIR/tagging.ecl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl b/automation/eclair_analysis/ECLAIR/tagging.ecl
> index 7944ce2ee3b2..755ea3271fc9 100644
> --- a/automation/eclair_analysis/ECLAIR/tagging.ecl
> +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
> @@ -47,6 +47,7 @@ MC3R1.R7.4||
>  MC3R1.R8.1||
>  MC3R1.R8.2||
>  MC3R1.R8.3||
> +MC3R1.R8.4||
>  MC3R1.R8.5||
>  MC3R1.R8.6||
>  MC3R1.R8.8||
> @@ -115,7 +116,7 @@ if(string_equal(target,"x86_64"),
>  )
>  
>  if(string_equal(target,"arm64"),
> -    service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3R1.R8.4||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"})
> +    service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"})
>  )
>  
>  -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"}
> 
> base-commit: 3128d7248f2ad389b8e9a3e252958cbfbd1898ee
> prerequisite-patch-id: 46b8fc2e9df2fd6be1bbbd6b50463e0e15a8f94d
> prerequisite-patch-id: c122b170f57ab96fe52c37aebf1f4bb366194637
> prerequisite-patch-id: 1c2d96bf17c5da0981b6c62939d3b7cc1e05933e
> prerequisite-patch-id: b3e43902729416e18b4fada7f529b4cb02b1815e
> prerequisite-patch-id: 9cb4598ff123c3b153f50f08798ad66a849c1af6
> -- 
> 2.39.5
>